mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
13507 commits 9 branches 364 tags 290 MiB
Commit graph

10650 commits

Author SHA1 Message Date
Adomas Venčkauskas
41907975b0 Adjust integration function comments and test dummy signature 2022-07-26 10:53:05 +03:00
Abe Jellinek
808375d5e3 fx-compat: Item box: Fix creator name field sizing 
Not the exact same sizing as Fx60, because that relied on some quirks
of the Mozilla box model that I can't reproduce with flexbox, but still
works about as well.
 2022-07-21 16:12:28 -04:00
Abe Jellinek
26a2398399 fx-compat: Restore guidance panels as CE 
Fixes #2711.
 2022-07-20 11:12:52 -04:00
Dan Stillman
7b10182e4a Disable obsolete "Open in External Viewer" menu option 
Hasn't done anything since in-browser viewing of certain file types in
Zotero 4 for Firefox. Perhaps we'd bring it back at some point, but
disable for now.
 2022-07-19 22:38:01 -04:00
Dan Stillman
744837cce7 fx-compat: Remove Zotero.MIME.hasInternalHandler() 
Hasn't been relevant since the Firefox NPAPI days, but was returning
true for `application/pdf` (possibly due to the bundled pdf.js in
Firefox still being included in our builds, which we should remove if
so), which was causing "Open in External Viewer" to appear, even though
it just opened the internal reader.
 2022-07-19 22:38:01 -04:00
Abe Jellinek
5e6dc290b6 fx-compat: Scaffold: Read ESLint output from stdin 
Need to update your zotero/translators clone to get linting working again.
 2022-07-19 16:26:17 -04:00
Abe Jellinek
14f79018ad fx-compat: Scaffold: Fix "undefined" attributes 2022-07-19 14:44:28 -04:00
Abe Jellinek
db3aa5248c fx-compat: Scaffold: Fix list overflow in Tests 2022-07-19 14:44:28 -04:00
Abe Jellinek
8ff75607a5 fx-compat: Item box: Disable guidancepanel trigger + cleanup 2022-07-19 14:44:28 -04:00
Abe Jellinek
6f8c5d7c51 fx-compat: Item box: Make vertically scrollable 2022-07-19 14:44:20 -04:00
Abe Jellinek
083e3c7a36 fx-compat: Search: Clear join mode condition 
Fixes an error that prevents changing the join mode from having an effect
after clearing the search when a join mode was already set. Bug also
present on master, not introduced with fx102.
 2022-07-12 22:01:20 -04:00
Abe Jellinek
fba349b144 fx-compat: Remove more unused binding CSS 2022-07-12 14:55:12 -04:00
Abe Jellinek
5f8a5056f1 fx-compat: Remove unused progress display 2022-07-12 14:50:53 -04:00
Abe Jellinek
5c6837c1fc fx-compat: Add copyright to CE base 2022-07-12 14:47:24 -04:00
Abe Jellinek
916627b590 fx-compat: Scaffold: Fix indentation using spaces 2022-07-11 13:03:48 -04:00
Abe Jellinek
dc96c1a175 fx-compat: Fix ZP progress queue button creation 2022-07-11 13:02:51 -04:00
Abe Jellinek
ab6b683d90
fx-compat: More progress on platform menus (#2675) 
Not able to test on non-Mac yet, but this behavior should be right.
Removes all the #ifdefs and moves the behavior into platformKeys.js.
 2022-07-07 00:04:13 -04:00
Abe Jellinek
9a8e78aaf4
fx-compat: Restore quick search menu and update styles (#2684) 2022-07-06 23:42:23 -04:00
Abe Jellinek
bc41c3b7b0 fx-compat: Make changelog link in About work 2022-07-06 15:24:31 -04:00
Abe Jellinek
abe19b9435 fx-compat: Fix error when v-t tooltip shows 2022-07-06 11:12:44 -04:00
Abe Jellinek
0983ffbef2 fx-compat: Make sync / retraction links tabbable 
Addresses #2655. Still need to add roles.
 2022-07-06 10:53:08 -04:00
Abe Jellinek
8face792c0
fx-compat: Fix search dialogs (#2631) 2022-07-04 01:48:52 -04:00
Abe Jellinek
b78b9cad1f fx-compat: Duplicates: UI fixes 
- Scroll vertically
- Restore margins between groupboxes
- Restore field version dropmarker
 2022-06-30 12:32:11 -04:00
Abe Jellinek
97786bfa77 fx-compat: Fix multiline Add Item by Identifier 
Now just one textarea instead of an input and a textarea.

Fixes #2677
 2022-06-30 11:48:15 -04:00
Abe Jellinek
f81b4b071f fx-compat: Correct create[XUL]Element[NS]() calls 
This fixes the dictionary manager and various other places where a XUL
element was being created with createElement(), and also simplifies a lot
of createElementNS(HTML_NS, ...) calls.

This might cause some minor regressions but everything tested has
worked. Not touching preferences (#2659) or bindings.
 2022-06-29 11:14:40 -04:00
Abe Jellinek
8b7d959781 fx-compat: Fix column picker context menu 2022-06-29 09:27:11 -04:00
Dan Stillman
4fcde6c8c5 fx-compat: hiddenWindow.xul → hiddenWindow.xhtml 2022-06-29 06:17:21 -04:00
Dan Stillman
41f54624b1 fx-compat: Fix "Hide {-brand-shorter-name}" in Mac application menu 2022-06-29 03:38:16 -04:00
Abe Jellinek
1eb9718b6b Style editor: Light theme, leave selection if unchanged 
Since onStyleModified() is called when a style is loaded.
 2022-06-28 15:12:57 -04:00
Abe Jellinek
9c837b3361 Improve Monaco integration and use in csledit 
And remove timedtextarea.xml. Fixes #2665.
 2022-06-28 15:05:16 -04:00
Abe Jellinek
8681e8ffe9 fx-compat: Make macOS application menu shortcuts work 
e.g. Cmd-H flashed the menu but didn't actually hide.
 2022-06-28 12:15:11 -04:00
Abe Jellinek
00e46443a6 Add XULElementBase class for custom elements 
https://github.com/zotero/zotero/pull/2631#discussion_r906723540
 2022-06-28 11:52:11 -04:00
Abe Jellinek
6295050fa6
Restore platform edit menu behavior without #ifdef (#2674) 2022-06-27 23:06:01 -04:00
Abe Jellinek
f0aef79c7a fx-compat: Use permalink in comment 2022-06-27 14:26:00 -04:00
Abe Jellinek
a654ad291f fx-compat: Add comment explaining menubar change 2022-06-27 14:22:02 -04:00
Abe Jellinek
a8c4e0637b fx-compat: Restore Mac application menu 
The stuff in hiddenWindow.xul doesn't seem to have been doing anything
in Fx102 anyway.
 2022-06-27 14:15:11 -04:00
Abe Jellinek
89587e6b76 fx-compat: native="true" on more checkboxes/menulists 2022-06-24 09:11:38 -04:00
Dan Stillman
3805f901cf fx-compat: Fix centering of library pane progress bar 2022-06-23 04:17:08 -04:00
Dan Stillman
f827b9ef50 fx-compat: initKeyEvent() → new KeyboardEvent() 
Quick Format change is untested
 2022-06-21 03:31:58 -04:00
Dan Stillman
587ae6ba7e fx-compat: Fix blurring of textarea fields in item box 
And fix tests
 2022-06-21 03:03:37 -04:00
Dan Stillman
3743c179e1 Add missing commonDialog.js from dictionary manager 
Currently provides close-on-Esc functionality
 2022-06-21 01:39:07 -04:00
Dan Stillman
20945f60c9 fx-compat: Remove nsIURI.clone() usage 2022-06-21 01:39:07 -04:00
Dan Stillman
6297d0862f fx-compat: Replace last use of getURLSpecFromFile() 
Follow-up to 8f7a160ba1

Untested, since it's in the prefs -- we'll have to see if this works
after #2659
 2022-06-21 01:39:00 -04:00
Dan Stillman
789a8a5fe9 fx-compat: Use new mozILocaleService API 
Replace functions with arrays, as in https://phabricator.services.mozilla.com/D6339
 2022-06-20 23:09:46 -04:00
Dan Stillman
96f6b871ce fx-compat: Fix sync error panel 2022-06-20 18:43:09 -04:00
Martynas Bagdonas
5b879f75c5 fx-compat: Avoid dead object errors in note-editor 
Fixes #2663
 2022-06-20 11:33:10 +03:00
Dan Stillman
b3077182d2 fx-compat: Fix Zotero.MIME.getMIMETypeFromURL() 
Replace

```
Components.classes["@mozilla.org/network/standard-url;1"]
	.createInstance(Components.interfaces.nsIURL)
```

with

```
Services.io.newURI(url).QueryInterface(Ci.nsIURL);
```
 2022-06-20 01:12:57 -04:00
Dan Stillman
30f636274b Update Notifier ids for itemBox/notesEditor custom elements 2022-06-20 00:47:50 -04:00
Dan Stillman
be3b245dbe Don't index PDF if fulltext.textMaxLength is 0 
Follow-up to 13adfd131c
 2022-06-19 19:03:41 -04:00
Dan Stillman
dfff86df72 fx-compat: Fix Zotero.File.download() 2022-06-19 18:58:25 -04:00
Dan Stillman
8f7a160ba1 fx-compat: getURLSpecFromFile() → Zotero.File.pathToFileURI() 
One remaining instance in the prefs that will need to be fixed
 2022-06-19 15:20:54 -04:00
Abe Jellinek
9c69f73de5 Manually remove handler instead of using once 
Since we only want to remove if the target matches.
 2022-06-18 03:45:32 -04:00
Abe Jellinek
a48ebe2dd7 Show native menus from toolbar 2022-06-18 03:45:32 -04:00
Abe Jellinek
a60e46dd5c fx-compat: Fix toolbar 2022-06-18 03:45:32 -04:00
Abe Jellinek
dd3385ec67 Revert "fx-compat: Remove Mac toolbarbutton images" 
This reverts commit 280a1265c8.
 2022-06-18 03:45:32 -04:00
Dan Stillman
d90334e883 fx-compat: Initial nsIWebBrowserPersist.saveURI() fixes 
Will need additional fixes for cookie handling, etc., but this at least
fixes the signature
 2022-06-17 20:29:01 -04:00
Dan Stillman
2b41b0127c Get binary contents in Zotero.File.getSample() 
And fix magic numbers for content-type sniffing, which wrongly used the
Unicode replacement character (which likely just meant we were falling
back to file-extension-based detection)
 2022-06-17 20:29:01 -04:00
Dan Stillman
13adfd131c fx-compat: Update full-text indexing 
Use the new PageData mechanism for character set detection, don't try to
index HTML files directly without properly detecting the charset, and
generally simplify the indexing code.

HTML files are now considered cached files that require indexing and
won't be indexed automatically in Zotero.FullText.findTextInItems(),
which breaks certain expectations, including in some tests. This will
need to be addressed.
 2022-06-17 20:29:01 -04:00
Dan Stillman
1dd24f7082 Remove Zotero.File.getCharsetFromFile()/addCharsetListener() 
Unused in over a decade, and now replaced by the PageData actor
 2022-06-17 20:29:01 -04:00
Dan Stillman
6a2949be8a fx-compat: Add HiddenBrowser.jsm 
Remove Zotero.Browser and add HiddenBrowser.jsm. Post-Fission, web/file
content loads in a separate process, so it's not possible (as best as I
can tell) to directly access the contents of a hidden browser -- it just
appears as about:blank in the parent process. We now use Mozilla's
JSWindowActor mechanism [1] to get page data, including character set
and body text for full-text indexing. We'll have to evaluate other uses
of hidden browsers to see how to handle them.

This also adds include.jsm for loading the Zotero object into a JSM.

[1] https://firefox-source-docs.mozilla.org/dom/ipc/jsactors.html
 2022-06-17 20:28:58 -04:00
Dan Stillman
7f748b2620 Take path or nsIFile in Zotero.File.pathToFileURI() 2022-06-17 20:24:43 -04:00
Dan Stillman
730e86d661 fx-compat: Restore tests and test using actual Zotero executable 
The test runner now uses the Zotero executable from
`zotero-standalone-build/staging` rather than the Firefox from
`zotero-standalone-build/xulrunner`. Along with testing the actual
program, this restores visible UI updates during tests, which should
make debugging various things easier. We can also now remove anything
related to Zotero being an extension.

Many tests are still broken, but this at least lets us start running
them.
 2022-06-17 20:24:43 -04:00
Dan Stillman
3c9dcea46b Add comment explaining CSS rule to hide menuitem icons on macOS 2022-06-17 20:24:43 -04:00
Abe Jellinek
0e1a16b96b fx-compat: Show native field/creator transform popups 
No longer anchored to the element, but instead to the cursor.
 2022-06-17 18:49:07 -05:00
Abe Jellinek
c31df4ae6b fx-compat: Display item box using CSS grid 
- Widths are now correct
- Rows are a little too tall
- Field value vertical alignment is off
- Platform styling isn't done and some styles might be redundant
- Still can't scroll vertically
- Creator name inputs still displayed wrong
 2022-06-16 16:27:16 -05:00
Tom Najdek
cb3d4b1800
Fix tag selector menus not appearing on fx102 (#2654) 
Also tweaked offset where a context menu appears to 1px from cursor
(was 2px) to match other context menus.
 2022-06-14 18:28:02 -04:00
Abe Jellinek
cd17c90f2e fx-compat: Don't show hidden types in Item Type menu 2022-06-10 14:03:53 -05:00
Abe Jellinek
ac9e882bda fx-compat: Item box: Fix URL opening and field blurring 2022-06-10 13:59:01 -05:00
Martynas Bagdonas
097d423275 fx-compat: Fix spellchecker and dictionary manager 2022-06-10 12:57:27 +03:00
Martynas Bagdonas
5924753fd1 fx-compat: Fix unloaded tab loading 2022-06-09 16:30:34 +03:00
Martynas Bagdonas
64c652ea06 fx-compat: Replace eval with wrappedJSObject in PDF reader 2022-06-09 13:13:08 +03:00
Abe Jellinek
9a2e98360a fx-compat: Scaffold: Update Monaco 
Now that we can. Quite a bit faster and more customizable.
 2022-06-08 17:38:59 -05:00
Abe Jellinek
e537018e71 fx-compat: Initial fix for Scaffold 
Not working:
- Web tests (hidden browser is broken)
- Test Updated status text
- Various platform menu things (code copied from ZP and will use whichever
  approach we settle on there)
 2022-06-08 17:16:50 -05:00
Martynas Bagdonas
1b324f9bd1 fx-compat: Fix color rendering in annotation popup, use checkbox 2022-06-08 21:22:37 +03:00
Martynas Bagdonas
1e25e2ac4c fx-compat: Fix invisible caret issue in linksBox tags popup 2022-06-08 21:22:37 +03:00
Martynas Bagdonas
a7bc25b553 fx-compat: Fix PDF reader window 2022-06-08 18:57:26 +03:00
Martynas Bagdonas
08089d6120 fx-compat: Fix tooltip node to work in PDF reader tab 2022-06-08 18:57:26 +03:00
Martynas Bagdonas
2e5388af5b fx-compat: Implement tagsBox element 2022-06-07 17:13:48 +03:00
Abe Jellinek
7e55ea59bb fx-compat: Item box: Change creator type label correctly 2022-05-31 16:31:20 -07:00
Abe Jellinek
b9f3bea8c3 fx-compat: Attachment box: Only add listener once 2022-05-31 16:30:55 -07:00
Abe Jellinek
1b74befd64 fx-compat: Fix Item Type menu regression 2022-05-31 15:04:14 -07:00
Abe Jellinek
d3555228b2 fx-compat: Fix Duplicate Items merge view 2022-05-31 14:57:47 -07:00
Abe Jellinek
59d5013952 fx-compat: Item box: Fix menu actions, plus/minus buttons 2022-05-31 11:23:19 -07:00
Abe Jellinek
496f34117c fx-compat: Fix attachment rename, remove <links-box> observer 
<links-box> doesn't actually have a notify() method, so an error was
being thrown on each notification.
 2022-05-27 13:28:07 -06:00
Abe Jellinek
1ef40d9423 fx-compat: Fix attachment box 2022-05-27 12:56:13 -06:00
Martynas Bagdonas
307701788f fx-compat: Fix and extract notesBox into a separate element 2022-05-27 13:21:18 +03:00
Abe Jellinek
f05d6fe0e0 fx-compat: Fix basicViewer for http(s):// URLs 
maychangeremoteness="true" is required to successfully load pages from
the web even though we never actually change remoteness.

https://searchfox.org/comm-central/rev/2cf3a09a0127fe73e932c5ee793986f3bed2ccd2/mail/base/content/aboutMessage.xhtml#118
 2022-05-26 10:45:57 -06:00
Abe Jellinek
e26fd18450 fx-compat: Change autocomplete-input load method 2022-05-26 09:39:30 -06:00
Martynas Bagdonas
0079fbdb08 fx-compat: Fix relatedBox 'Add' button visibility 2022-05-26 18:31:07 +03:00
Martynas Bagdonas
db0ac723fa fx-compat: Note editor and links box fixes: 
- Add links-box component (inside noteEditor.js).
- Add related-box component and fix related pane.
- Use tagsBox.jsx instead of tagsbox.xml in note editor links box popup.
- Remove CSS styles and bindings for noteeditor, relatedbox and tagsbox.
 2022-05-26 18:23:31 +03:00
Martynas Bagdonas
4a1812e5ba fx-compat: Fix selectItemsDialog 2022-05-26 18:23:31 +03:00
Abe Jellinek
4a856b94cc fx-compat: Item box: Fix abstract expander 2022-05-25 13:22:52 -06:00
Abe Jellinek
3566d1fc1f fx-compat: Item box: Fix item type menulist 
- Use IDs as list item values
- Use addEventListener() so events are actually received
- Put menulist inside <td>
    * This causes a small appearance regression at the moment because
      <td> margins/padding are a bit off, but that issue is visible on
      all other fields already.
 2022-05-25 12:51:15 -06:00
Abe Jellinek
c2ce5c7596 fx-compat: Remove duplicate menulistItemTypes.js 2022-05-24 15:56:09 -06:00
Abe Jellinek
5d96f9960a fx-compat: Item box: Fix unstyled menulists 2022-05-24 15:48:10 -06:00
Abe Jellinek
fdd73d4ada fx-compat: Item box: Fix multiline fields & autocomplete 2022-05-24 15:42:54 -06:00
Abe Jellinek
02bcb1712c fx-compat: Fix content shrinking to half of window height 
On my system, this would always happen after adding a new attachment.
 2022-05-24 13:59:12 -06:00
Abe Jellinek
29b270e761 fx-compat: Fix progress queue / Find Available PDFs 2022-05-24 13:52:52 -06:00
Abe Jellinek
195dd379d9 fx-compat: Fix context menu icons showing on Mac 
Why does :is match when a regular selector doesn't? I have absolutely no
idea, but it's more concise anyway.

Fixes #2620
 2022-05-24 13:37:20 -06:00
Abe Jellinek
87decd0f8d fx-compat: Fix _getExtensionFromURL() 2022-05-24 12:07:30 -06:00
Abe Jellinek
300af4477f fx-compat: Fix Attach Link dialog 2022-05-24 12:02:37 -06:00
Abe Jellinek
a2215cb8f6 fx-compat: Fix hard confirmation dialog 
ID changed to commonDialog so we get commonDialog.css styling for free.
 2022-05-24 11:43:45 -06:00
Dan Stillman
1a1a5924da fx-compat: Simplify Zotero.File.download() 
`NetUtil.newChannel()` can take a string spec, so don't bother parsing
to an nsIURI first

Follow-up to 7adb8fd150
 2022-05-24 03:03:36 -04:00
Abe Jellinek
7adb8fd150 fx-compat: Fix Zotero.File.download() 2022-05-24 00:47:22 -06:00
Abe Jellinek
eae9a4447d fx-compat: Mostly fix locateManager 
Still many selectors to update in preferences.css, but how we do that
depends on what our <prefwindow>/<prefpane> replacement looks like.
 2022-05-24 00:46:39 -06:00
Martynas Bagdonas
7b4c4e528c fx-compat: Fix context pane: 
- Stacked view.
- Item pane tabs.
- Note list search box.
 2022-05-19 14:10:51 +03:00
Martynas Bagdonas
e99a0d4515 fx-compat: Partial fixes for note editor 2022-05-19 14:10:51 +03:00
Dan Stillman
29bc36c02a fx-compat: Tweak styling of Create Bibligraphy window 
And generalize CSS rules for richlistitem and groupbox headers (using
HTML H2s for the latter, as Mozilla does)

Follow-up to 547311ff26
 2022-05-19 02:06:42 -04:00
Dan Stillman
9bf61f9914 fx-compat: Update CSL Edit window 2022-05-18 23:45:51 -04:00
Dan Stillman
d6e0c90baa Revert "fx-compat: Fix item box CSS link casing" 
This reverts commit 4c21a42b53.

itemBox.css is correct
 2022-05-18 23:45:51 -04:00
Abe Jellinek
948b09a27f fx-compat: Remove uses of defunct DOM constructors 
This fixes feed translation. Getting a lot of '[object Object]' fields
from that, but I don't think it's related to these changes.
 2022-05-18 20:03:37 -07:00
Abe Jellinek
09ec5b1fde fx-compat: Fix ProgressWindow 
popup -> alwaysontop because popup removes the background.
 2022-05-18 19:52:59 -07:00
Abe Jellinek
547311ff26 Fix Create Bibliography 
listbox is gone, but richlistbox is still here as a custom element and
works fine for cases where we don't need virtualization.

groupbox label and richlistitem styles should probably be copied to
somewhere global once tuned a bit.
 2022-05-18 19:32:39 -07:00
Abe Jellinek
4c21a42b53 fx-compat: Fix item box CSS link casing 2022-05-17 10:03:29 -07:00
Abe Jellinek
5f24b2dc98 Fix Create Parent dialog 2022-05-17 09:47:19 -07:00
Abe Jellinek
49a9c2dba9 fx-compat: Fix Export dialog 
RDF isn't working yet, but CSV works well.
 2022-05-16 14:27:23 -07:00
Abe Jellinek
60606a8528 fx-compat: Fix Add to Collection menu 
Document.createXULElement is handy.
 2022-05-16 13:18:16 -07:00
Martynas Bagdonas
9e93007355 fx-compat: Initial fixes for PDF reader, tabs and contextPane 2022-05-13 18:50:19 +03:00
Dan Stillman
4eb405d405 Update utilities submodule 2022-05-13 04:28:57 -04:00
Dan Stillman
da9154d811 fx-compat: Get basicViewer working for debug output 
Doesn't work with, e.g., zotero://timeline/library
 2022-05-13 04:28:57 -04:00
Dan Stillman
d6875e1182 fx-compat: Switch to Mozilla's method of loading window scripts 2022-05-13 04:28:57 -04:00
Dan Stillman
9b3d7a32e3 Include error message in startup error dialog 2022-05-13 04:28:57 -04:00
Dan Stillman
7c458b9bd3 fx-compat: Fix positioning of some context menus 2022-05-13 04:28:57 -04:00
Dan Stillman
bc68b6e9fe fx-compat: Start to fix tag color chooser dialog 
Among other things, need to recreate XBL <customcolorpicker> as a Custom
Element and need to change `ondialogaccept`/etc. to event listeners:

https://searchfox.org/mozilla-central/rev/b72e9d7d63bf499d1d8168291b93d4ec7fde236e/browser/components/places/content/bookmarkProperties.js#232-237
 2022-05-13 04:28:57 -04:00
Dan Stillman
63634eed02 fx-compat: Fix clicking URL label 
Now that it's a div rather than a label, have to use `textContent`
instead `nodeValue`
 2022-05-13 04:28:57 -04:00
Dan Stillman
516c76a4ab fx-compat: Start to update feed settings dialog 2022-05-13 04:28:57 -04:00
Dan Stillman
909d68eac3 fx-compat: Fix New Item menu 2022-05-13 04:28:57 -04:00
Dan Stillman
2e26703b50 fx-compat: goQuitApplication() now takes an event argument 2022-05-13 04:28:57 -04:00
Dan Stillman
172c2da2cc fx-compat: Add dropmarkers to toolbarbuttons 2022-05-13 04:28:57 -04:00
Dan Stillman
758c3187fc fx-compat: Update Edit menu (WIP) 2022-05-13 04:28:57 -04:00
Dan Stillman
280a1265c8 fx-compat: Remove Mac toolbarbutton images 
Need to replace with proper styling, but the former approach doesn't
work with the new toolbarbutton component.
 2022-05-13 04:28:57 -04:00
Dan Stillman
10a801fcc7 WIP: Localization 2022-05-13 04:28:57 -04:00
Dan Stillman
a16e0620d2 WIP: Localization 3 2022-05-13 04:28:57 -04:00
Dan Stillman
65658b16e6 WIP: Localization 2 2022-05-13 04:28:57 -04:00
Dan Stillman
77015336a4 WIP: Localization 2022-05-13 04:28:56 -04:00
Dan Stillman
c82af749ac Don't force Lucida Grande in various components on macOS 2022-05-13 04:28:56 -04:00
Dan Stillman
4f5b7bbccb Remove old commented-out lines in include.js 2022-05-13 04:28:56 -04:00
Dan Stillman
002132bc4b fx-compat: Populate Window menu on macOS 2022-05-13 04:28:56 -04:00
Dan Stillman
ebc511f418 coroutine() → async for Zotero.init() 2022-05-13 04:28:56 -04:00
Dan Stillman
f8e10f80cc fx-compat: __defineGetter__() → defineProperty() 2022-05-13 04:28:56 -04:00
Dan Stillman
13b9837524 fx-compat: Fix New Item menu and serializePersist() 
`document.getElementsByAttribute` → `document.querySelectorAll`
 2022-05-13 04:28:56 -04:00
Dan Stillman
9222b939ab fx-compat: Fix error viewing items 
`Components.classes["@mozilla.org/network/standard-url;1"]` no longer
exists
 2022-05-13 04:28:56 -04:00
Dan Stillman
31677dd296 fx-compat: Fix error generating item context menus with locate options 2022-05-13 04:28:56 -04:00
Dan Stillman
f91bf49aae fx-compat: nsIIdleService → nsIUserIdleService 2022-05-13 04:28:56 -04:00
Dan Stillman
1714351cc9 fx-compat: Fix position of collection and item context menus 2022-05-13 04:28:56 -04:00
Dan Stillman
b49b8ad140 fx-compat: Mostly fix About pane 
Example of converting top-level XUL `<dialog/>` to
`<window><dialog/></window>`, which uses a Mozilla-provided `<dialog>`
Custom Element
 2022-05-13 04:28:56 -04:00
Dan Stillman
f4675c02df fx-compat: Update nsILoginManager::findLogins() calls 2022-05-13 04:28:56 -04:00
Dan Stillman
c7c61f72c9 fx-compat: Stop trying to load overlay.js, which was removed 2022-05-13 04:28:56 -04:00
Dan Stillman
7ee40c4682 fx-compat: Fix Add Item by Identifier window 
Still a little buggy
 2022-05-13 04:28:56 -04:00
Dan Stillman
8075c2d938 Remove obsolete tab.css 2022-05-13 04:28:56 -04:00
Dan Stillman
753824a7e2 fx-compat: Temporarily disable quick search bar mode menu 2022-05-13 04:28:56 -04:00
Dan Stillman
a54da965a7 fx-compat: Use search-textbox custom element for quick search bar 2022-05-13 04:28:56 -04:00
Dan Stillman
26c4bea4fd fx-compat: .boxObject was removed in Fx69 
https://bugzilla.mozilla.org/show_bug.cgi?id=1519948
 2022-05-13 04:28:56 -04:00
Dan Stillman
0717612b4b fx-compat: Remove contentAreaContextMenu menupopup 
No longer necessary
 2022-05-13 04:28:56 -04:00
Dan Stillman
260c110d05 fx-compat: Convert itembox XBL to custom element 
Still lots of things to fix, particularly with styling, but the basic
functionality is there.
 2022-05-13 04:28:56 -04:00
Dan Stillman
3c6f0b26af Move .zotero-clicky to its own SCSS component 
This will allow it to be included in shadow DOM.
 2022-05-12 05:18:47 -04:00
Dan Stillman
87f2716da8 fx-compat: zoteroPane.xul → zoteroPane.xhtml 2022-05-12 05:18:47 -04:00
Dan Stillman
abfa09df51 fx-compat: loadURI() signature change in HTTP.loadDocuments() 2022-05-12 05:18:47 -04:00
Dan Stillman
59fd8247b4 fx-compat: Remove overlay.js, since overlays no longer exist 2022-05-12 05:18:47 -04:00
Dan Stillman
d635fdda41 fx-compat: AddonManager.getAllAddons() now returns a promise 2022-05-12 05:18:47 -04:00
Dan Stillman
94c7e0674d fx-compat: Remove 'context' from onStartRequest()/onStopRequest()/etc. 2022-05-12 05:18:47 -04:00
Dan Stillman
3a77abc8d2 fx-compat: Zotero files are now packaged in app/omni.ja, not zotero.jar 2022-05-12 05:18:47 -04:00
Dan Stillman
004d5db2c3 fx-compat: Services.console.getMessageArray() returns an actual array 2022-05-12 05:18:47 -04:00
Dan Stillman
fb8984c947 fx-compat: XULDocument → XMLDocument 2022-05-12 05:18:47 -04:00
Dan Stillman
46a52b3e3e fx-compat: Update locales code 2022-05-12 05:18:47 -04:00
Dan Stillman
6d5b2c3d12 Fx-compat: nsIUTF8ConverterService → nsIScriptableUnicodeConverter 
It's not totally clear what this does or if it's necessary (see #1540),
but this is a replacement that Thunderbird used.
 2022-05-12 05:18:47 -04:00
Dan Stillman
bbecb4d0bd fx-compat: Add appcontent container to zoteroPane.xul 
Part of inlining XUL

(View with -w for real diff)
 2022-05-12 05:18:47 -04:00
Dan Stillman
1bb99a6bc8 fx-compat: nsIWebNavigation::loadURI() signature change 2022-05-12 05:18:47 -04:00
Dan Stillman
b6f5d7183f fx-compat: Remove use of tree.treeBoxObject and change getCellAt() signature 
Properties and methods are now available on the tree itself, and
getCellAt() now returns an object instead of using in-out variables.
 2022-05-12 05:18:47 -04:00
Dan Stillman
ee78dd308b fx-compat: Remove XBL stylesheets (WIP) 2022-05-12 05:18:47 -04:00
Dan Stillman
3f64310d45 fx-compat: Inline all XUL overlays 2022-05-12 05:18:47 -04:00
Dan Stillman
dd2ff63019 fx-compat: Replace nsIDOMParser with new DOMParser() 2022-05-12 02:38:59 -04:00
Dan Stillman
993320655e fx-compat: Throw error if generator is passed to DB.executeTransaction() 2022-05-12 02:38:59 -04:00
Dan Stillman
03242e8984 fx-compat: DB.executeTransaction() no longer takes generator functions 2022-05-12 02:38:59 -04:00
Dan Stillman
ccbc785499 fx-compat: XPCOMUtils.generateQI() → ChromeUtils.generateQI() 2022-05-12 02:38:59 -04:00
Adomas Venčkauskas
4d35cdf095 Remove unneeded constant in virtualized table 2022-05-10 17:03:34 +03:00
Adomas Venčkauskas
eb6b14a218 Fix item tree column resizing issues 
Report https://forums.zotero.org/discussion/97077/problem-with-column-width-adjustment
 2022-05-10 17:02:36 +03:00
Adomas Venčkauskas
a406e62fd3 Item Tree: Fix column dividers not aligned for second-level items 
Closes #2605
 2022-05-10 13:52:32 +03:00
Adomas Venčkauskas
aa483f579f HTML tree: Find-as-you-type remains on matching string. 
Closes #2607
 2022-05-10 13:35:31 +03:00
Dan Stillman
273fc6c657 Update locales from Transifex 2022-05-09 10:05:55 -04:00
Abe Jellinek
db5b535ea6 Update translate submodule 2022-05-07 20:34:37 -07:00
Adomas Ven
c49a05d486
Improve column resizing robustness (#2588) 
Also:

* Add staticWidth and minWidth column properties
 2022-05-03 03:00:23 -04:00
Martynas Bagdonas
01645c5e51
Pin library tab (#2589) 
Fixes #2575
 2022-05-03 01:21:59 -04:00
Abe Jellinek
097308c5c6 Update utilities submodule 2022-05-02 17:12:39 -07:00
Dan Stillman
b6fdeeca13 Fix deadlock in integrity check before DB schema upgrade 
One of the repair steps uses a transaction, which is reasonable, so
don't run integrity check within transaction at startup.
 2022-05-01 02:14:45 -04:00
Dan Stillman
d201fdc119 Fix target is undefined error during upgrade from Zotero 4 
https://forums.zotero.org/discussion/96811/database-upgrade-error-when-migrating-from-version-4-0-to-6-0-directly-skipping-zotero-5

Regression from 078e3bb07, probably
 2022-05-01 02:14:36 -04:00
Dan Stillman
5e0674b842 Add logging for PDF exports 2022-04-30 05:17:41 -04:00
Abe Jellinek
9829ea7009
Update utilities, move tests, add to CI (#2584) 2022-04-30 04:55:11 -04:00
Dan Stillman
fd859bd976 Update locales from Transifex and merge new English strings 2022-04-29 18:28:52 -04:00
Dan Stillman
b536432866 Fix mistake in tab-unavailable integration message 2022-04-29 16:54:16 -04:00
Dan Stillman
644cce219a Tweak tab-unavailable integration message 2022-04-29 16:51:41 -04:00
Adomas Venčkauskas
ff920de130 Fix integration transaction getting stuck when google docs tab is closed 
Closes #2583
 2022-04-29 15:19:20 +03:00
Adomas Venčkauskas
fca16d2ad5 Fix find-as-you-type not matching beyond first letter 
Closes #2581
 2022-04-29 15:19:20 +03:00
Martynas Bagdonas
70c9bef320 Switch tabs with Cmd-Option-←/→ 
Fixes #2475
 2022-04-29 12:56:04 +03:00
Abe Jellinek
3bfc6740c4
Add tests for improved compareCallNumbers (#2579) 2022-04-28 04:43:30 -04:00
Abe Jellinek
5196ba379b
Update typeSchemaData and builder script (#2576) 2022-04-28 02:12:29 -04:00
Martynas Bagdonas
fe14ee79a3 Show a few missing options in Tools menu when PDF reader tab is open 
Fixes #2502
 2022-04-27 18:20:41 +03:00
Martynas Bagdonas
41bdd36068 Add an option to disable smart quotes 
Fixes #2524
 2022-04-27 10:23:10 +03:00
Dan Stillman
a4cdaf0407 Show "Add Note from Annotations" in attachment context menu 2022-04-27 02:34:42 -04:00
Dan Stillman
c405fa76a1 Add sortNotesChronologically.reader pref for PDF reader notes list 
And default to true. I forgot we were sorting reverse chronologically by
default in order to make it easy to open recent notes.

Follow-up to https://github.com/zotero/zotero/issues/2526 for
https://forums.zotero.org/discussion/96743/pdf-reader-two-feature-requests
 2022-04-26 17:59:45 -04:00
Dan Stillman
40501c3953 Update locales from Transifex and merge new English strings 2022-04-26 17:22:39 -04:00
Martynas Bagdonas
10c8fc4c74 Implement tab duplication 
Fixes #2566
 2022-04-26 19:41:51 +03:00
Abe Jellinek
89aaa10504
Sort LC call numbers better, sort integers as integers (#2569) 
* Update utilities submodule after https://github.com/zotero/utilities/pull/8
* Extract and add tests
 2022-04-26 04:11:29 -04:00
Martynas Bagdonas
7a06671ecb Fix undefined variable issue in annotation templates 2022-04-26 08:29:42 +02:00
Adomas Venčkauskas
d96ebad82a Allow adding multiple sources at once in classic citation dialog. 
Closes #2568
 2022-04-25 13:28:00 +03:00
Adomas Venčkauskas
1be2d69f1e Log integration invocations before other integration actions 2022-04-25 12:43:48 +03:00
Martynas Bagdonas
b8d427790c Fix error when using a note template and checking if array is not empty 2022-04-23 14:52:24 +07:00
Adomas Venčkauskas
d9463daa66 HTML Tree: Search by typing loops instead of starting from beginning 
Closes #2559
 2022-04-22 10:58:25 +03:00
Martynas Bagdonas
c1fde1d3d9 Improve tab title visibility and adjust scroll arrow scroll step 
Fixes #2554
Fixes #2553
 2022-04-22 13:07:18 +07:00
Dan Stillman
114b48d5b8 Update locales from Transifex 2022-04-21 15:46:50 -04:00
Dan Stillman
031ff1824b Fix middle click to close tabs (#1993) 2022-04-21 12:23:14 -04:00
Martynas Bagdonas
a8cb9bfddd Restore custom note styling 
Fixes #2560
 2022-04-21 13:17:04 +07:00
Abe Jellinek
f91ca9c18a Don't merge with a deleted master attachment 2022-04-20 11:04:24 -07:00
Martynas Bagdonas
142e3b09f8
Unload tabs (#2500) 
- Keep all tabs unloaded on Zotero opening.
- Keep loaded only the last five selected tabs.
- Keep loaded only in the last 24h selected tabs.

Fixes #2383
 2022-04-20 03:14:50 -04:00
Dan Stillman
578986ab1e Fix item types not appearing in New Item submenu 
https://forums.zotero.org/discussion/96530/a-issue-about-new-item-drop-down-menu

After a type from the submenu was selected and added to the MRU, the
submenu wouldn't be updated. Not sure how long this has been going on.

Fixes #2534
 2022-04-19 23:04:18 -04:00
Martynas Bagdonas
5d442b706e
Make tab bar scrollable (#2506) 
Fixes #2232
 2022-04-19 18:51:32 -04:00
Adomas Ven
7b0d6951d2
Update csl validator for CSL 1.0.2 (#2493) 2022-04-19 18:42:48 -04:00
Dan Stillman
3f10e4c064 Bad JSON in sync cache shouldn't break syncing 
https://forums.zotero.org/discussion/95926/zotero-not-syncing-report-id-1924846177
 2022-04-19 17:49:13 -04:00
Martynas Bagdonas
5c8ea0174a Fix empty table row height in generated report, prevent table overflow 
Fixes #2545
 2022-04-15 21:59:27 +07:00
Adomas Venčkauskas
5ca8486047 Adjust conditional clause for Windows from 76276a3 2022-04-15 11:21:07 +03:00
Adomas Venčkauskas
76276a39ce HTML Tree: adjust row padding per OS 2022-04-15 11:15:40 +03:00
Abe Jellinek
e8ad2fab95
getSortTitle: Only strip initial punctuation clusters (#2537) 
Specifically exclude @, #, and *
 2022-04-15 02:08:14 -04:00
Dan Stillman
c9b39675ba Update locales from Transifex and merge new English strings 2022-04-14 18:06:32 -04:00
Dan Stillman
498e38730b Update translate submodule 2022-04-14 18:06:32 -04:00
Abe Jellinek
d842e7a9bc Fix save() without transaction when saving search 2022-04-14 14:39:34 -07:00
Martynas Bagdonas
f494ab5114
Allow creating and editing tables in note-editor (#2511) 
Fixes #2480
 2022-04-14 17:17:32 -04:00
Adomas Venčkauskas
01506b27e9 Allow moving cursor by clicking on collection name while editing 
Closes #2513
 2022-04-14 17:03:54 +03:00
Adomas Venčkauskas
599c6821b7 Ensure columns don't resize when switching tabs 2022-04-14 16:51:13 +03:00
Abe Jellinek
1538a836b9
Show label of translator that causes import error (#2539) 2022-04-14 07:01:43 -04:00
Dan Stillman
08d3880d88 Don't remove relations in annotation item JSON 
This was causing UUIDs for annotations from Mendeley imports to be
removed after a sync, resulting in annotations being duplicated on a
reimport.
 2022-04-14 06:37:30 -04:00
Abe Jellinek
3792c89fbd Allow >4 numbers after the decimal point in Dewey 
https://github.com/zotero/zotero/pull/2538#issuecomment-1097292396
 2022-04-12 15:45:50 -07:00
Abe Jellinek
ce39185fa7
Sort call numbers alphabetically, handle Dewey specially (#2538) 2022-04-12 17:40:25 -04:00
Dan Stillman
a72deb4648 Update locales from Transifex and merge new English strings 2022-04-12 02:57:07 -04:00
Abe Jellinek
e03c1603ca Fix "%S" in displayed startup error message 2022-04-11 19:03:29 -07:00
Abe Jellinek
38f5551ee5
Add "Open PDF in New Window" to context menu (#2490) 
Also:

* Remove Locate tooltips
 2022-04-11 17:53:40 -04:00
Abe Jellinek
a5fc8b859c Context Pane: Use getNoteTitle() 
ad36c9fb2a (r71022779)
 2022-04-11 13:36:03 -07:00
Abe Jellinek
b8b1f8be55
Disable Import actions in uneditable libraries (#2471) 2022-04-11 16:12:43 -04:00
Abe Jellinek
ad36c9fb2a Context Pane: Sort notes in item tree order 
Fixes #2526.
 2022-04-11 10:13:50 -07:00
Abe Jellinek
892c1169c8 Attachment merge: Compare link mode type 
Actually fixes #2527.
 2022-04-11 09:30:16 -07:00
Adomas Venčkauskas
237bd8f0ce Fix Restore Column Order in Item Tree not always working 
Closes #2521
 2022-04-11 13:55:30 +03:00
Adomas Ven
4c445554a3
Item Tree: Attempt to fix OS font scaling (#2488) 2022-04-11 05:16:59 -04:00
Martynas Bagdonas
2af7275968 Fix template condition evaluating to true for empty string from function 
Fixes #2529
 2022-04-11 12:22:20 +07:00
Abe Jellinek
be0b0a7151
Always autocomplete creators in hideEditor (#2516) 2022-04-11 00:21:14 -04:00
Abe Jellinek
47a2f3cad9 Attachment merge: Compare linkModes, improve logging 
Using keys instead of IDs should make logs more useful.
Fixes #2527.
 2022-04-09 20:39:37 -07:00
Dan Stillman
0df8b7670d Fix broken tag selector with colored tags that differ with normalization 
https://forums.zotero.org/discussion/96138/lost-content-in-tag-selector

An entered character from the CJK_COMPATIBILITY_IDEOGRAPHS block (char
code 63834, or similar) was normalized to the CJK_UNIFIED_IDEOGRAPHS
block (char code 35712), which then caused an expected key not to exist.

To fix, normalize colored tag values coming from the DB.
 2022-04-09 06:24:17 -04:00
Martynas Bagdonas
2112aa7271 Don't jump back to library tab when PDF recognition finishes 2022-04-08 15:31:28 +07:00
Adomas Venčkauskas
b850d16c89 Fix integration error handling code when citeproc-rs disabled. 
Closes #2508
 2022-04-08 10:41:35 +03:00
Martynas Bagdonas
bdbde99fa7 Remove alpha channel from highlight color when inserting a note 
Fixes #2499
 2022-04-08 13:00:33 +07:00
Abe Jellinek
dea9fc5e88 Scaffold: setInterval -> activate listener 2022-04-07 19:50:13 -07:00
Abe Jellinek
a40ab83b71
Fix double separator in Edit menu on Win/Linux (#2507) 2022-04-06 23:42:13 -04:00
Abe Jellinek
fbaa1c6e61 Fix huge Scaffold toolbar icons on Win/Linux 2022-04-05 14:50:05 -07:00
Adomas Venčkauskas
c510d91461 Fix an error that causes test failures (regression 9a5657b) 2022-04-05 10:08:10 +03:00
Adomas Venčkauskas
5b9ac2ca53 Fix a non-terminal startup error introduced in d7b1a53 2022-04-05 10:08:10 +03:00
Dan Stillman
28ec72666f Update locales from Transifex and merge new English strings 2022-04-04 14:02:08 -04:00
Adomas Venčkauskas
9a5657bf79 Item Tree: Fix fixed-width columns sometimes changing width 2022-04-04 16:06:51 +03:00
Martynas Bagdonas
f877476c1a Partially disable buggy ff <64 table resizing handles in note-editor 
Unfortunately the first opened note will still have the handles.
 2022-04-01 17:09:08 +07:00
Martynas Bagdonas
3f4030ff80 Allow copying image annotations to external text fields 
Fixes #2447
 2022-04-01 17:09:08 +07:00
Abe Jellinek
a5b3d6440b
Fix next duplicates set selection after merge (#2448) 2022-03-31 17:46:30 -07:00
Martynas Bagdonas
3356557493 Add 'Zoom to Page Height' PDF reader option 
Fixes #2255
 2022-03-31 15:52:00 +07:00
Martynas Bagdonas
8e54f1649b Add annotation to note at cursor position 
Fixes #2487
 2022-03-31 12:14:11 +07:00
Abe Jellinek
e922ae711a Fix ProgressQueue titles for cases, letters, etc. 
Handles items with an alternate field that maps to title (like cases)
and items for which the title is usually filled in by updateDisplayTitle()
(like letters).
 2022-03-30 16:30:07 -07:00
Abe Jellinek
2a1ce292d2 Remove Note Font Size -> Reset restart prompt 
+ replace empty menuitem with a divider as in the Font Size menu.
 2022-03-30 14:55:48 -07:00
Abe Jellinek
27c9086222 Scaffold: Show "defer" value in test list 2022-03-30 14:49:42 -07:00
Abe Jellinek
745069c070 Don't strip punctuation before numbers 
Fixes #2496
 2022-03-30 11:58:55 -07:00
Dan Stillman
f2209974b2 Don't show "Export PDF" in reader 
Save As already exists
 2022-03-30 14:13:24 -04:00
Dan Stillman
e0097df068
Remove "Store Annotations in File" option (#2498) 
This is a confusing, bad option, which was already disabled in groups,
and this removes it from personal libraries as well. People seem to be
using it mainly because they think annotations are locked into Zotero if
they don't, which is causing them to ask for this to be done
automatically on every edit, which we don't do because it would result
in constant file syncing and file conflicts [1].

We provide multiple export options for exporting PDFs with annotations,
and people can use those when sharing a file with people who don't use
Zotero. Otherwise, if storing annotations in the file is a priority,
they can use an external reader that's not designed to be tightly
integrated into Zotero.

(As a rare hack, it's of course also possible to export the PDF with
annotations, replace the original file, and import the annotations.)

[1] https://www.zotero.org/support/kb/annotations_in_database
 2022-03-30 13:58:59 -04:00
Tom Najdek
56321a7a6d
Fix regression: download() fails for non-http URLs (#2497) 
This fixes compatiblity with some addons that use Zotero.File.download
to extract files from their XPI bundle.
 2022-03-30 12:15:40 -04:00
Tom Najdek
776769f480
Citavi import: Tweak how page label is determined (#2494) 
Instead of attempting to extract `PageRange` value we now let pdf worker
always determine page label.

Also improved citavi tests and fixtures.
 2022-03-30 09:34:07 -04:00
Abe Jellinek
a9d7a08a05 Fix merge interface doubling rows in master selector 
Master choices would occasionally be doubled in the listbox. Clearing
the innerHTML instead of using removeItemAt() fixes the issue.
 2022-03-28 13:24:59 -07:00
Adomas Venčkauskas
d7b1a53248 HTML Tree: Improve item tree column header alignment. 
Addresses #2153
 2022-03-28 13:32:17 +03:00
Dan Stillman
17d9f06b65 Update more try-wrapped calls to getString 2022-03-27 02:37:49 -04:00
Abe Jellinek
470d9cd7c2 Update more try-wrapped calls to getString 2022-03-25 16:49:52 -07:00
Abe Jellinek
82228a1072 Search: Use item field localization if string == key 
91faa73b19 made getString return the key
instead of throwing on non-en-US locales, so we check if the getString
result is equal to the key even if it doesn't throw.

Fixes #2472.
 2022-03-25 16:35:01 -07:00
Abe Jellinek
a3322a9afb
Merge pull request #2397 from AbeJellinek/scaffold-sanitize-for-display 2022-03-25 11:59:05 -07:00
Martynas Bagdonas
4dcb3e7a53 Fix deletion confirmation and copying in standalone PDF reader window 
Fixes #2462
 2022-03-25 15:53:49 +02:00
Martynas Bagdonas
2f5974e1ab Reduce probability of annotation comment/text being cleared while typing 
Fixes #2361
 2022-03-24 13:40:43 +02:00
Dan Stillman
91faa73b19 Don't throw from getString() for missing strings in non-English locales 
Just show the key

We still merge strings before pushing betas, but this means it won't
crash for source builds, or if we forget. Not sure why we didn't do this
15 years ago.
 2022-03-24 07:06:53 -04:00
Dan Stillman
1d1adbca70 Fix error merging items with missing attachment files 
Fixes #2453
 2022-03-24 06:39:47 -04:00
Dan Stillman
9d91e0d4f7 Update locales from Transifex and merge new English strings 2022-03-24 06:18:17 -04:00
Adomas Venčkauskas
f7e49630c8 Fix some more column picker brokenness 2022-03-24 11:00:16 +02:00
Adomas Venčkauskas
c87b40e5ca Fix secondary sort submenu breakage in 8e31bf5b 2022-03-24 10:33:58 +02:00
Adomas Venčkauskas
8e31bf5b6d Possible fix for missing More Columns submenu. Addresses #2443 2022-03-24 10:28:37 +02:00
Martynas Bagdonas
62f07a7356 Upgrade note-editor schema to v8: 
- Allow highlight and citation nodes in headers

Fixes #2467
Related #2390
 2022-03-24 10:21:04 +02:00
Adomas Venčkauskas
229f42bed2 HTML Tree: Change Cu.reportError() to Zotero.logError() 2022-03-23 13:28:46 +02:00
Martynas Bagdonas
23a4a14b44 Upgrade note-editor schema to v7: 
- Allow ul/ol nodes to have `dir` attribute
 2022-03-23 12:35:08 +02:00
Adomas Venčkauskas
c083c69be1 Fix note insertion dialog not appearing when classic mode is enabled. 
Closes #2463
 2022-03-23 11:58:06 +02:00
Adomas Venčkauskas
1b124bff2d Actually fix quick format color issues. See cc5e110 2022-03-23 11:28:50 +02:00
Adomas Venčkauskas
0f2273ea43 Link to manual word plugin installation instructions on install failure. 
Closes #2444
 2022-03-23 11:12:42 +02:00
Dan Stillman
fcb16f628b Fix "path.startsWith is not a function" sync error on Windows 
`OS.Path.join()` on Windows throws if an integer is passed. Seems like
this would happen on another computer whenever an image annotation is
deleted in a group?
 2022-03-23 00:01:00 -04:00
Dan Stillman
37c48dc3ee Remove Zotero.Items.moveChildItems() transaction requirement exception 
Follow-up to 734057ff9b

This was supposed to allow ZotFile to continue to work but 1) it
contained a bug and 2) another transaction messed things up for ZotFile
anyway, so we'll just fix this in jlegewie/zotfile#593.
 2022-03-22 18:07:40 -04:00
Abe Jellinek
95d8b37f0a Potentially fix ProgressWindow crash 
The call to _window.addEventListener() might have been causing an error
when _window was null or undefined (no main Zotero window could be
found), which would prevent _windowLoading from being set to true and
the window from being added to the ProgressWindowSet, which might have
caused unpredictable behavior when positioning windows later on.

I could only briefly reproduce the issue, so this is just one idea. The
call to addEventListener on a potentially null _window was definitely a
bug but I don't know if it caused the crash.
 2022-03-22 12:55:47 -07:00
Adomas Venčkauskas
cc5e1106ec Fix quick format issues in Linux dark themes. Closes #2441 2022-03-22 14:32:15 +02:00
Adomas Venčkauskas
227b6354de Item Tree: Reset scrollbar to top on collection change 2022-03-22 13:58:02 +02:00
Adomas Venčkauskas
25230b0fca HTML Tree: Fix focused row losing focus sometimes not being redrawn 2022-03-22 13:58:02 +02:00
Dan Stillman
5df1017689 Correction to Scite access date fix in dc886d3cec 2022-03-22 06:01:30 -04:00
Dan Stillman
dc886d3cec Remove access dates broken by Scite 
A non-date value ('INVALID_SCITE_VALUE') apparently gets output as
`false` in toJSON(), which results in a sync error.
 2022-03-22 05:53:24 -04:00
Dan Stillman
d14a8b1d92 Put Scite cleanup code in a try/catch 
Just to be safe
 2022-03-22 05:01:50 -04:00
Dan Stillman
f8e9aa147b Add temporary code to fix invalid values from Scite at startup 
https://github.com/scitedotai/scite-zotero-plugin/issues/38
 2022-03-22 05:00:28 -04:00
Dan Stillman
f95bf41d13 Revert "Fix "cleanDOI: argument must be a string" startup error" 
This reverts commit 8763190328.

This is caused by the Scite plugin, and it's better to block startup
until this is fixed, since it's wrecking other fields too.
 2022-03-21 23:49:33 -04:00
Dan Stillman
174f1aadde Fix error adding group item before syncing in Zotero 6 
Fixes #2440
 2022-03-21 22:50:43 -04:00
Dan Stillman
8763190328 Fix "cleanDOI: argument must be a string" startup error 
Due to 0 integer value for DOI from somewhere (a plugin?)

https://forums.zotero.org/discussion/comment/402388/#Comment_402388
https://forums.zotero.org/discussion/comment/402391/#Comment_402391
 2022-03-21 22:02:54 -04:00
Abe Jellinek
bca76319ce
getSortTitle: Strip less punctuation, trim (#2442) 
Now it:

1. Strips punctuation at the beginning, no matter what it is.
2. Strips non-dash punctuation in other positions.
3. Trims the result.

This should better prevent numerical ranges from being joined into a
single number that ends up incorrectly being sorted to the very bottom.
 2022-03-21 20:06:27 -04:00
Martynas Bagdonas
388d18d017 Terminate PDF worker after processing PDFs queue 
Fixes #2421
 2022-03-17 14:26:07 +02:00
Martynas Bagdonas
edf0c31bdb Remove old note editor binding 2022-03-17 11:18:17 +02:00
Dan Stillman
121f3f3037 Update locales from Transifex 2022-03-16 20:45:18 -04:00
Abe Jellinek
b1d11bf7dc Really fix lastSync log spam 
6b6c27029b didn't do the trick because
library.lastSync can be false and the ?. operator doesn't catch that.
 2022-03-15 10:43:17 -07:00
Abe Jellinek
8a235c07f1 Fix et al. regex for sorting by creator 
\. -> \\. and apply the same escaping to general.and.
 2022-03-15 10:05:09 -07:00
Martynas Bagdonas
26e4de500e Fix overflowing itemPane and hidden contextPane for new profiles, in stacked view 
Fixes #2305
 2022-03-15 18:27:18 +02:00
Martynas Bagdonas
982b41359b Fix oversized tagBox icons in standalone PDF reader window 
Fixes #2143
 2022-03-15 18:27:18 +02:00
Martynas Bagdonas
d02eb145d5 Fix copying over PDF reader context pane 
Fixes #2408
 2022-03-15 18:27:18 +02:00
Dan Stillman
1f2f91d2d2 Update locales from Transifex 2022-03-15 07:43:11 -04:00
Martynas Bagdonas
d4339f20bd Don't try to modify non-editable annotation item when saving image 2022-03-15 11:04:02 +02:00
Martynas Bagdonas
769bfbc892 Fix PDF reader up/down keyboard navigation regression in RTL mode 2022-03-15 09:53:11 +02:00
Martynas Bagdonas
59caaf56ea Fix PDF reader keyboard navigation in RTL mode 2022-03-14 17:25:28 +02:00
Adomas Venčkauskas
12cd201b48 HTML Tree: Multi-selection fixes 
- Clarification between focused row and pivot:
  - Pivot is only the row from which shift-selection pivots
  - Focused row is the one with the border around it
- Fixed an issue where clicking the focused row didn't select it.
  Closes #2402
- Allows to create a non-contiguous range-selection with ctrl/cmd+shift.
  Closes #2403
 2022-03-14 14:57:59 +02:00
Dan Stillman
3ec883a7f6 Get attachment text on-demand if not cached in Item::attachmentText 
Follow-up to 58f515058 with a better approach: if no full-text cache
file, just get text directly without indexing. In the one existing use
of `attachmentText`, attachment merging, this is better anyway, because
we might be deleting the file, so there's no point wasting time
inserting words into the database.
 2022-03-12 20:22:29 -05:00
Dan Stillman
58f5150583 Don't automatically index full-text content in Item::attachmentText 
Indexing starts a transaction, which will cause `.attachmentText` to
hang if accessed within another transaction. If a caller wants to make
sure it has attachment text, it should index items first outside a
transaction.
 2022-03-12 19:11:02 -05:00
Dan Stillman
6aa401bceb Don't show annotation-only tags in tag selector 2022-03-12 03:00:40 -05:00
Martynas Bagdonas
c7972b3d38
Improve keyboard navigation in PDF reader tab (#2395) 2022-03-12 02:22:13 -05:00
Abe Jellinek
6b6c27029b
Fix log spam when library hasn't been synced (#2409) 
This happens a lot during tests - library.lastSync is null, so
showAutoSyncReminder() throws. It doesn't fail tests but it does spam
the log.
 2022-03-11 20:19:02 -05:00
Abe Jellinek
80bb40b153 Fix error when menus haven't been created 2022-03-11 14:02:07 -08:00
Abe Jellinek
52bc93adc9 Always select new items, disable File -> New Item appropriately 
Fixes #2405. This also fixes an issue where Cmd/Ctrl-Shift-N in a
collection like Duplicate Items would open the item type menu on top of
a blank white item pane (since the new item didn't get selected first).
 2022-03-11 13:42:15 -08:00
Abe Jellinek
c9ccd758bc Fix undefined error when new collection title is empty 2022-03-11 13:08:33 -08:00
Martynas Bagdonas
78e1e8593a Fix note template condition evaluating to true on empty array 
Fixes #2386
 2022-03-11 17:04:47 +02:00
Abe Jellinek
ef82becf00
Merge attachments and update notes (#2336) 
We follow a different merge procedure for each attachment type:

- For PDF attachments, compare by MD5. If no match, get the top 50 words
  in the attachment's text and hash those, then check again for a match.
  Update references to item keys in notes and annotations.
- For web (snapshot / link) attachments, compare by title and URL.
  Prefer a title + URL match but accept a title-only match.
- For other attachment types, keep all attachments from all items being
  merged.

Also:

- Move most merge tests from Duplicates to Items#merge(). It just doesn't
  make sense to worry about the UI in these.
 2022-03-09 17:26:26 -05:00
Abe Jellinek
ed31a11fce Scaffold: Sanitize items for display more accurately 2022-03-09 11:42:16 -08:00
Tom Najdek
1ad2056674
Add support for importing Citavi annotatons (#2351) 2022-03-09 04:06:44 -05:00
Dan Stillman
c7ece79f79 Fix missing creators not being removed in item.fromJSON() 
Apparently there's been a bug for years where removing a creator
remotely hasn't caused it to be removed locally via sync...

https://forums.zotero.org/discussion/94910/desktop-app-not-correctly-syncing
 2022-03-09 02:43:22 -05:00
Dan Stillman
326d3425db Update Preprint icon 
Journal article plus pencil, similar to manuscript (blank page plus
pencil)

Follow-up to zotero/zotero-bits#88
 2022-03-08 01:05:54 -05:00
Abe Jellinek
cc47359080 Update translate submodule 2022-03-07 13:46:07 -08:00
Abe Jellinek
6ad829a7e5 Set sync reminder lastDisplayed when dismissed by sync 2022-03-07 09:39:40 -08:00
Dan Stillman
e5558b6f3e Remove note backup functionality 
Closes #2191
 2022-03-05 06:12:29 -05:00
Dan Stillman
a1305712f3 Update locales from Transifex and merge new English strings 2022-03-05 05:35:22 -05:00
Dan Stillman
053d6a0116 Add Preprint item type 
See zotero/zotero-bits#88
 2022-03-05 02:03:29 -05:00
Dan Stillman
d750da089f Show clearer error for SSL certificate error 
For both startup proxy auth requests and subsequent requests to
zotero.org domains

Closes #2337
 2022-03-05 02:03:29 -05:00
Dan Stillman
f6bd7269ae Fix changing locale via keyboard on Windows 
(And maybe Linux)

https://forums.zotero.org/discussion/94866/beta-6-0-no-shortcut-key-could-be-applied-in-language-of-advanced-setting
 2022-03-05 00:48:44 -05:00
Martynas Bagdonas
3c42103848
Allow to Quick Copy annotations (#2377) 2022-03-04 03:52:23 -05:00
Dan Stillman
6da38c292e Scaffold: Tweak tooltip text for Run and Update button 2022-03-02 22:36:44 -05:00
Abe Jellinek
5409ae3313 Overhaul Scaffold (#2293) 2022-03-02 22:36:04 -05:00
Dan Stillman
a7cf689df2 Update locales from Transifex and merge new English strings 2022-03-02 16:39:04 -05:00
Abe Jellinek
d82981d601
Fix item tree jumping to top on focus without selection (#2347) 2022-03-02 14:55:01 -05:00
Adomas Ven
b38d7107d8
HTML Tree: Add a dotted border to pivot rows (#2375) 2022-03-02 05:41:59 -05:00
Dan Stillman
c0ab16e79d Merge pull request #2354 
Add sync reminders
 2022-03-02 05:25:38 -05:00
Dan Stillman
706233c974 Sync reminders changes (#2354) 
- Adjust text
- Add "Learn More" button with link to sync documentation for
  set-up-sync notification
- Show "Don't Show Again" for set-up-sync even on first display
- Don't perform any action when clicking unlinked text
- Use yellow/orange background instead of blue for notification bar
- Prevent text from wrapping out of the bar at narrow window widths
- Use local variable for observer id
 2022-03-02 05:20:34 -05:00
Abe Jellinek
b0f09b3a86 Sync reminders changes (#2354) 
- Always wait seven days, standardize casing
- Enable auto-sync without opening preferences
- Implement suggestions
 2022-03-02 05:20:22 -05:00
Fletcher Hazlehurst
1a3f6301b7 Add syncing reminders (#2354) 
There are two:
- Sync never set up (no username in DB) / set up, but unlinked
- Sync set up but auto-sync disabled and sync not completed in 30 days

Checks are trigged on item adds.
 2022-03-02 05:19:10 -05:00
Abe Jellinek
939ee6159d Use XRegExp in getSortTitle() 
Fixes #2372
 2022-03-01 16:37:13 -08:00
Dan Stillman
1cc03492c4 Split annotations on sync error 
Follow-up to b7f26c47c1
 2022-03-01 05:09:15 -05:00
Dan Stillman
a10fcfd58e Speed up comparison of items with huge numbers of tags 
Can cause a freeze while syncing items with 1000s of tags
 2022-03-01 02:45:07 -05:00
Martynas Bagdonas
b7f26c47c1 Split annotation if position data exceeds the limit 2022-02-28 20:10:20 +02:00
Abe Jellinek
b54466f089 Fix error restoring top-level notes & attachments 
Fixes #2369
 2022-02-28 08:18:59 -07:00
Martynas Bagdonas
003b3db281
Implement custom keyboard navigation (#2317) 2022-02-23 13:00:57 -05:00
Dan Stillman
1743360de7
Merge pull request #2366 from AbeJellinek/short-title-column 
Add Short Title item tree column
 2022-02-22 15:40:45 -05:00
Abe Jellinek
2e74bdd2ad De-duplicate column strings and use getString() 2022-02-22 10:59:07 -08:00
Dan Stillman
8d81705831 Move Duplicate Item in items list context menu 
Move below Add to Collection and Remove from Collection
 2022-02-21 23:16:49 -05:00
Dan Stillman
c192dacc76 Merge new English strings 2022-02-21 21:53:36 -05:00
Abe Jellinek
f333585d98
Add items to collection via context menu (#2360) 2022-02-21 19:36:37 -05:00
Abe Jellinek
198ae65b4a Fix Import placing items in feeds/uneditable libraries 2022-02-21 15:40:19 -08:00
Abe Jellinek
fb98fe5d2c Add Short Title item tree column 2022-02-21 14:50:43 -08:00
Dan Stillman
ca3fd80825 Remove use of Promise.tap() from Bluebird and our own Promise.check() 2022-02-21 15:46:23 -05:00
Dan Stillman
e48d069687 Update locales from Transifex and merge new English strings 2022-02-21 15:26:58 -05:00
Dan Stillman
4d79e162c9 Remove DB diagnostics for missing schema updates problem 2022-02-21 15:13:43 -05:00
Dan Stillman
7700cd776a Repeat itemAnnotations schema update step after 078e3bb079 2022-02-21 15:13:38 -05:00
Dan Stillman
078e3bb079 Switch from Bluebird coroutine to async/await for DB/schema 
We've been seeing some behavior in `Schema::_migrateUserDataSchema()`
that should be impossible, with conditional blocks totally skipped. I
can't see how this is anything other than either a JS engine bug with
generators or some sort of bug in our version of Bluebird, but with any
luck it will go away by switching everything to async/await.
 2022-02-21 15:13:05 -05:00
Dan Stillman
9a2aec970d Load styles list in preferences even if custom style has an invalid date 
A bundled style will get replaced from the repo if it has an invalid
date, but a custom style would result in an empty list.

https://forums.zotero.org/discussion/comment/399774/#Comment_399774
 2022-02-21 15:12:46 -05:00
Adomas Ven
191e43dcfa
Delay querying attachment state from DB on tree scroll (#2357) 
This improves item tree fast-scrolling performance when attachment
column is enabled, but adds a noticable attachment state pop-in
 2022-02-21 13:28:15 -05:00
Martynas Bagdonas
b71367760d Don't jump to library tab when closing tab after startup 
Fixes #2362
 2022-02-21 18:43:04 +02:00
Martynas Bagdonas
822f821718 Set the current author name when creating an annotation in a group 
Fixes #2322
 2022-02-21 18:11:56 +02:00
Martynas Bagdonas
04fa89ffc8 Don't copy/import/delete note images if library files aren't editable 
#2364
 2022-02-21 18:11:56 +02:00
Adomas Venčkauskas
000599bfff Do not load citeproc-rs on Style.init() unless it's enabled 
Closes #2363
 2022-02-21 13:50:08 +02:00
Abe Jellinek
48a3235a2e
Disable Delete/Restore menu items appropriately (#2340) 2022-02-20 11:45:53 -05:00
Abe Jellinek
13f48ec5c7
Render markup in item tree, strip when sorting (#2355) 2022-02-19 15:49:35 -05:00
Dan Stillman
a45da8df17 Add Greek locale 2022-02-19 14:18:50 -05:00
Dan Stillman
5d6318fd3e Update locales from Transifex and merge new English strings 2022-02-19 14:10:07 -05:00
Dan Stillman
fac8d55002 Update submodules 2022-02-19 13:53:03 -05:00
Dan Stillman
b54b7edf9b Don't set author name of current user when copying annotation from group 
Fixes #2358
 2022-02-19 13:47:28 -05:00
Dan Stillman
72ac453a8c Set createdByUserID to current user for locally created group item 
Addresses #2322
 2022-02-19 13:47:28 -05:00
Dan Stillman
4a914c26db Set user display name from /keys/current 
So that it can be available for annotations created locally before
they're uploaded
 2022-02-19 13:47:28 -05:00
Dan Stillman
a2458614df Don't include date line when generating filename for annotations note 
Since in many locales it would contain slashes and colons, both of which
would be stripped in the filename, leaving long strings of numbers in
the filename
 2022-02-19 13:45:29 -05:00
Dan Stillman
5eee488e20 Update utilities submodule 
And add tests for `Utilities.Internal.noteToTitle()`

Follow-up to zotero/utilities@df2dda23b
 2022-02-19 13:43:41 -05:00
Martynas Bagdonas
5405da99db
Add support for annotation templates (#2359) 2022-02-18 14:38:36 -05:00
Dan Stillman
7606c88e79 Tweak Word/Apple Silicon warning text 2022-02-17 01:43:39 -05:00
Dan Stillman
db35f55c96 Limit autocomplete in Advanced Search to specific creator types 
For `author`, `bookAuthor`, and `editor` conditions added in #2253
 2022-02-17 01:43:39 -05:00
Abe Jellinek
91cdc5610b
Search by specific creator type (#2353) 
Author, editor, or book author.
 2022-02-17 01:06:14 -05:00
Martynas Bagdonas
924d29ff7e Fix undefined Zotero_Tabs issue 2022-02-14 14:13:30 +02:00
Adomas Venčkauskas
06676be8e4 Add defaultSort attribute to columns 
Sort date columns in descending order by default.
Closes #2344
 2022-02-11 16:19:59 +02:00
Martynas Bagdonas
e6c835abc8
Allow to show/hide citations in notes (#2288) 2022-02-11 12:50:43 +02:00
Martynas Bagdonas
bcfd93bc79 Set lastModifiedByUser even if an annotation author is authoritative 2022-02-10 10:55:02 +02:00
qqobb
47799adb3c
Improve directoryContains() (#2335) 2022-02-10 03:17:46 -05:00
Dan Stillman
f509e9063a Fix arrow keys in View menu 
Arrow keys still step through `collapsed` menuitems, whereas `hidden`
properly hides them from key navigation.
 2022-02-10 02:52:02 -05:00
Dan Stillman
76c7e832bb Add accesskey for View menu 
https://forums.zotero.org/discussion/94431/6-0-beta-underline-of-view-menu
 2022-02-10 02:52:02 -05:00
Martynas Bagdonas
ee3e28e126 Changes to how author name is passed to pdf-reader and pdf-worker 2022-02-09 16:54:46 +02:00
Adomas Venčkauskas
8c846468f2 Update strings for Mac Word errors 2022-02-09 15:25:45 +02:00
Dan Stillman
c6d03753fd Don't copy external annotations to between libraries 2022-02-09 07:08:18 -05:00
Dan Stillman
9bf842a3ae Update locales from Transifex and merge new English strings 2022-02-09 06:44:03 -05:00
Dan Stillman
bacc5b4428 Preserve explicit annotation author name when copying from group 2022-02-08 23:57:49 -05:00
Abe Jellinek
9cf45c0a0b
Set default filename when exporting single note (#2339) 2022-02-08 23:28:53 -05:00
Dan Stillman
734057ff9b Require DB transaction in Zotero.Items.moveChildItems() 
But make optional with deprecation warning for now, since it's used in
ZotFile
 2022-02-08 06:38:48 -05:00
Dan Stillman
f684984b07 Copy annotations across libraries 
Based on option in prefs

When copying an annotation group the
 2022-02-08 06:38:32 -05:00
Dan Stillman
67451dffd5 Add annotationAuthorName property to annotation items 
And pass both `authorName` and `lastCreatedByUser` to the PDF reader.
The former can either come from `createdByUser` or be set directly on
the item (for group annotations dragged to personal libraries).
 2022-02-08 06:38:32 -05:00
Dan Stillman
60f9a0417f Remove isAuthor from JSON passed to PDF reader 2022-02-08 06:38:32 -05:00
Dan Stillman
bf9ef5fc01 Disable PDF annotation transfer in group libraries 2022-02-08 06:38:32 -05:00
Dan Stillman
cc0687a574 Fix selectLibrary() in CollectionTree if no libraryID passed 2022-02-08 06:38:32 -05:00
Adomas Venčkauskas
0d2cfef160 HTML Tree: fix errors being thrown on hover over empty cells 
Regression in 54ad6da1
 2022-02-08 10:00:36 +02:00
Martynas Bagdonas
b865ee8b65 Fix tagsBox issues in a separate note window: 
- Invisible auto-suggested tags
- Oversized tag icon
 2022-02-07 17:39:09 +02:00
Dan Stillman
e4f5241058 Add missing quote in logged error 2022-02-05 03:17:51 -05:00
Adomas Venčkauskas
54ad6da1af HTML Tree: make tooltip setting code use any parent xul node 2022-02-04 14:19:20 +02:00
Dan Stillman
c78bf1b2a3 Fix feed item guid in logged warning when item exists in different feed 2022-02-04 02:18:38 -05:00
Abe Jellinek
e8b574da0b
Fix React icons only using 2x image once (#2324) 
a1267bc fixed repeated re-appending of '@2x' by moving the modified URL
to a local variable, but it still set hasHiDPI to false permanently;
this meant that icons displayed repeatedly in the same window, like the
tab close button, would only use their 2x versions the first time they
were displayed (in the case of tabs, this is the library tab's invisible
close button, so *no* tabs got visible 2x buttons).

This commit moves the HiDPI check and URL modification out of the render
function and instead runs it a single time when i() is first called.
 2022-02-04 00:38:01 -05:00
Adomas Venčkauskas
8de1ddcaf4 HTML Tree: Display a tooltip with full cell contents when truncated 
Closes #2321

Also added tooltips for cells that use an icon in their contents
 2022-02-03 16:09:40 +02:00
Abe Jellinek
4777f0ec89 Double-click/enter to edit feed 
Closes #2323
 2022-02-02 23:03:04 -08:00
Tom Najdek
90da2563c8
Decouple progress queue table from progress window (#2318) 
* Tweaked ProgressQueue to accept multiple listeners per event.
  Removing listeners now requires specifying which one to remove.
* Decoupled progress queue table into new ProgressQueueTable component
 2022-02-02 17:15:57 -05:00
Dan Stillman
1ea1a134ba Reset extensions.spellcheck.inline.max-misspellings 
Closes #2108
 2022-02-02 05:48:23 -05:00
Adomas Venčkauskas
060d2f1c37 Item tree: Add tooltips for header cells. 
Restrict the html-tooltip [title] selector to not fall back to
window title when no title attributes are present.
 2022-02-02 12:25:50 +02:00
Dan Stillman
4e6b68477d PDF reader: Annotation name display changes 
- Show creator's name in groups even when it's the current user
- Don't show name for external annotations
 2022-02-02 03:54:34 -05:00
Dan Stillman
3902043669 Update locales from Transifex and merge new English strings 2022-02-02 02:22:34 -05:00
Dan Stillman
a6e0432848 PDF reader: Tweak annotation deletion confirmation text 2022-02-02 02:09:20 -05:00
Martynas Bagdonas
21ca1555c1 Focus tag input field if tagsBox doesn't have tags 
Fixes #2315
 2022-01-31 19:49:58 +02:00
Dan Stillman
637acbe693 Fix incorrect isEditable() test in Item::moveToLibrary() 2022-01-31 06:48:05 -05:00
Dan Stillman
df64a16b55 Disallow unowned group annotation edits, but allow deletions 
Update `DataObject::isEditable()` to take an optional `op` argument to
test individual operations as opposed to general library editing.
Erasing objects now tests `erase`, and `Item::isEditable()` allows
`erase` for unowned group annotations while disallowing the default
`edit`.

It's still up to the reader to handle this appropriately in the UI and
not allow operations it shouldn't, but this enforces it in the data
layer.
 2022-01-31 06:48:05 -05:00
Dan Stillman
5a0cd78f06 Enable PDF reader by default and enable for groups 
"Zotero" is now the first and default option in the "Open PDFs using"
drop-down in the General pane of the preferences.
 2022-01-31 06:48:05 -05:00
Martynas Bagdonas
f8d7eb8ed7 Prompt confirmation when deleting annotations in PDF reader 2022-01-28 17:32:41 +02:00
Dan Stillman
ae7bfe7f48 "Suppress Author" → "Omit Author" 
Authors shall be suppressed no more.
 2022-01-26 23:52:47 -05:00
Adomas Venčkauskas
d2aa945083 Select full item name upon entering edit mode in the collection tree 
(Instead of placing the cursor at the end of the edit field)
Closes #2316
 2022-01-26 15:10:59 +02:00
Dan Stillman
da8f4df8ca Update locales from Transifex and merge new English strings 2022-01-17 05:10:30 -05:00
Martynas Bagdonas
e46f210b6c
Add color and tag selector to annotations sidebar (#2299) 2022-01-17 04:20:35 -05:00
Martynas Bagdonas
f2e9efaf1d Don't show multiple separators in PDF reader annotation context menu 2022-01-04 19:11:38 +02:00
Dan Stillman
035aac30f2 Fix misplaced '?' in regexp from 52d5652540 2022-01-03 01:31:02 -05:00
Dan Stillman
52d5652540 Don't use Firefox UA for proxy-check S3 domain 
https://forums.zotero.org/discussion/comment/396502/#Comment_396502
 2022-01-03 01:22:49 -05:00
Dan Stillman
b1b9759864 Doc Prefs: Don't increase style list height at larger font sizes 
https://forums.zotero.org/discussion/93655/is-there-a-fix-for-high-dpi-screens
 2022-01-02 16:57:06 -05:00
Dan Stillman
ad02b70198 Update locales from Transifex and merge new English strings 2021-12-28 01:27:07 -05:00
Dan Stillman
4f8fccd598 PDF reader: Page label popup tweaks (#2267) 
- Change text of context menu option
- Add header line above radio boxes
 2021-12-28 01:19:48 -05:00
Martynas Bagdonas
2cd756b7ae PDF reader: Add page label update option to annotation popup (#2267) 2021-12-28 01:19:48 -05:00
Martynas Bagdonas
3cb5340b26 PDF reader: Remove import bar artifacts 2021-12-28 01:19:48 -05:00
Martynas Bagdonas
6913c179dc Optimize annotations batch modification and deletion 2021-12-28 01:19:48 -05:00
Dan Stillman
819dc7f6f4 Include "Zotero/[version]" in file sync requests 
To avoid blocking by some institutional firewalls

https://forums.zotero.org/discussion/93510/general-sync-error
 2021-12-27 15:54:12 -05:00
Dan Stillman
3dab64ddbb Fix error deleting some orphaned or invalid WebDAV files 
If a .prop file was passed to `_deleteStorageFiles()`, it would throw
`deletePropURI.QueryInterface is not a function`.
 2021-12-27 14:53:28 -05:00
Dan Stillman
d955a77e98 Update locales from Transifex and merge new English strings 2021-12-27 01:20:24 -05:00
Dan Stillman
71248b591d Better handling of export option for notes in items list context menu 
- Show "Export Note…"/"Export Notes…" if only notes or attachments
  selected
- Don't show export option if only attachments and no embedded notes
  (was previously disabled, and still is if all notes or a mixture of
  empty notes and attachments)
 2021-12-26 23:50:15 -05:00
Dan Stillman
5c024e2859 Use Sets instead of Arrays in ZoteroPane.buildItemContextMenu() 2021-12-26 23:27:44 -05:00
Dan Stillman
f3a71a2c09 Log timing info for copying bibliography to clipboard and CSL Preview 2021-12-26 23:19:35 -05:00
Dan Stillman
24104dc685 Fix error generating context menu for multiple standalone attachments 
Regression from f161d167ae
 2021-12-26 23:15:47 -05:00
Dan Stillman
14caa3a895 Update locales from Transifex and merge new English strings 2021-12-24 02:13:36 -05:00
Dan Stillman
918570479e Hard-code "storage" in error when trying to set data dir to 'storage' 2021-12-24 02:06:39 -05:00
Dan Stillman
d361930bcc Remove PDF metadata retrieval problem reporting 
Closes #1854
 2021-12-23 06:11:13 -05:00
Dan Stillman
d3691473bc HTML tree: Fix Shift-Enter for opening PDFs in separate windows 
This also required React 17, which removed event pooling [1], which was
breaking this even after the code change.

https://forums.zotero.org/discussion/comment/396112/#Comment_396112

[1] https://reactjs.org/blog/2020/08/10/react-v17-rc.html#no-event-pooling
 2021-12-23 01:18:22 -05:00
Dan Stillman
a1349d4a22 Merge new English strings 2021-12-22 16:29:50 -05:00
Adomas Venčkauskas
5dabe390a2 Fix collection and item tree focusing code. Closes #2286 2021-12-22 13:48:41 +02:00
Tom Najdek
bbf3180a10 Fix rtfscan icons reported as having HiDPI variant 2021-12-22 05:06:21 -05:00
Dan Stillman
7285c32d28 Support Cmd/Ctrl-Shift-F to open advanced search window 
https://forums.zotero.org/discussion/93600/shortcut-for-advanced-search

In olden days this used to trigger full-screen mode of our weird "tab
mode" in Firefox, but that hasn't existed in many years. At least on
macOS, the standard shortcut for that is Cmd-Ctrl-F.
 2021-12-22 05:04:41 -05:00
Dan Stillman
0f676dd720 Remove lower row height in virtualized table on macOS 
With the additional PDF icon in the Attachments column from b0ba7e464,
might as well have the same amount of spacing to tell the rows apart.
 2021-12-22 05:04:28 -05:00
Dan Stillman
b0ba7e4646 Show small PDF icon in Attachments column when there's a PDF 
Closes #2265

There's also new code for showing a different icon for snapshots, files,
and DOI/URL links, like the web library and iOS app, but it's commented
out for now. The bitmap icons create too much visual noise with the
greater information density and hierarchical tree of the desktop app
(not to mention many more low-DPI displays). We can revisit after
switching to SVGs across the board.
 2021-12-22 03:38:12 -05:00
Dan Stillman
04fa066a14 Delete items with unmodified delete key when not in collections 
Closes #2209
 2021-12-21 03:19:13 -05:00
Dan Stillman
978e2c32b4 Remove "Toggle Tag Selector" command from Shortcuts preference pane 
Cmd/Ctrl-Shift-T is now used for reopening a closed tab

This is now a View menu option, so macOS users can assign an
app-specific shortcut key for it. For other platforms that can't do
that, Zutilo could add it, and it will be an option if we add general
key-binding configurability in a future version.

Closes #2281
 2021-12-21 02:22:29 -05:00
Dan Stillman
f161d167ae Show "Add Note from Annotations" for all items with PDF attachments 
So that this works for PDFs with external annotations that haven't yet
been processed. Going forward, if we add automatic/background scanning,
we can avoid showing this option if the file hasn't changed and there
are no Zotero annotations, which would probably be the majority of
attachments.
 2021-12-21 02:22:29 -05:00
Dan Stillman
ea18641a62 Annotation import: Use skipAll for lastProcessedModificationTime save 2021-12-21 02:22:29 -05:00
Dan Stillman
d76cf829b1 Additional logging for PDF annotation import 2021-12-21 02:22:29 -05:00
Adomas Venčkauskas
59969d1a7b Fix citeproc engine variable name in rtfScan.jsx 2021-12-20 15:53:59 +02:00
Dan Stillman
fa95de396d Add en-AU and en-NZ as available locales 
Addresses #2268, but better support for other en-* locales will require
other changes, including `timeStyle` support in `Intl.DateTimeFormat` in
a newer Firefox version, which will let us use a custom `DateTimeFormat`
for dates instead of relying on `toLocaleString()`.
 2021-12-20 01:24:43 -05:00
Dan Stillman
14402125f8 Add English strings from connector 2021-12-20 01:24:43 -05:00
Dan Stillman
abe8c39c5b Ignore blank tags when saving from translator 
Instead of throwing an error
 2021-12-19 03:01:59 -05:00
Dan Stillman
f734e53ed9 Fix broken Export Library after #2214 2021-12-18 22:42:12 -05:00
Martynas Bagdonas
78526d7795 Include annotationKey when using "Add Item Note from Annotation" 
Fixes #2279
 2021-12-16 13:09:22 +02:00
Dan Stillman
88c3e6ca00 Fix wrong aria-disabled on context/non-context item rows 
Regression from #2263
 2021-12-15 22:05:28 -05:00
Adomas Ven
44b6cd0525
citeproc-rs support (#2220) 
Disabled under zotero.cite.useCiteprocRs by default
 2021-12-15 17:28:41 -05:00
Dan Stillman
55e8f7914b Handle style errors in CSL Preview window 
Keep going, and log the error
 2021-12-15 17:21:26 -05:00
Dan Stillman
9de954afc7 Merge new English strings 2021-12-15 16:55:23 -05:00
Dan Stillman
b28db2c8f9 Show "Add Notes from Annotations" when multiple items are selected 
Closes #2277
 2021-12-15 16:37:21 -05:00
Dan Stillman
964f5cec90 Merge new English strings 2021-12-15 06:25:15 -05:00
Dan Stillman
a648da8507 Markdown/HTML note export: Switch hard-coded translator ids to constants 2021-12-15 06:10:58 -05:00
Dan Stillman
ad21d73ad9 Markdown note export: Replace zotero:// without separate saving code path 2021-12-15 06:10:58 -05:00
Martynas Bagdonas
19977598eb Markdown note export (#2214) 2021-12-15 06:10:58 -05:00
Dan Stillman
63a0452a77 Update submodules 2021-12-15 01:55:36 -05:00
Dan Stillman
c89fe96531 Update locales from Transifex and merge new English strings 2021-12-15 01:53:29 -05:00
Adomas Ven
0a8ba2bced
Improve tree screen reader accessibility (#2263) 
Also:

* Allow opening tree context menu with Shift + F10 and Context Menu button
 2021-12-15 01:47:06 -05:00
Dan Stillman
fbef7c00dd Fix error deleting feed item with invalid attachment 
This shouldn't happen, and we should make sure we prevent plugins from
doing it, but if an attachment existed in a feed library, neither the
item nor the feed could be deleted.

https://forums.zotero.org/discussion/93453/unsubscribe-rss-feed-fail
 2021-12-14 08:17:42 -05:00
Martynas Bagdonas
338d753eb3 Fix itemBox opening popups in wrong bindings 2021-12-13 16:36:47 +02:00
Dan Stillman
644c4e5925 Add objects from failed download requests to sync queue 
Previously only individual objects from successful requests that
couldn't be processed for some reason would be added to the queue.

`Sync.APIClient.downloadObjects()` now returns clearer and more
consistent results. It now returns an array of promises for objects with
a `keys` array of requested keys and either a `json` array of returned
API JSON objects or an `error` Error, depending on whether the request
succeeded or failed. This makes it easier to detect remotely missing
objects and request failures.
 2021-12-10 05:56:46 -05:00
Martynas Bagdonas
86965988b4 Make PDF reader File menu "Show in Library" option to show parent item 
Fixes #2266
 2021-12-09 15:32:24 +02:00
Adomas Venčkauskas
aefd3dd94a Reduce timeout when downloading PDF via browser. 
Follow up to 4405b59
 2021-12-07 16:12:14 +02:00
Adomas Venčkauskas
73fb9c13df Fix preference style list refresh on modification. Closes #2256 2021-12-02 12:40:48 +02:00
Adomas Venčkauskas
0fdfa5f64b Fix test failure after #2248. Closes #2257 2021-12-02 12:21:23 +02:00
Adomas Ven
4405b59044
Add a function to download PDFs via a browser (#2248) 
Fixes zotero/translators#2739
 2021-12-02 04:27:33 -05:00
Dan Stillman
e54f59ae28 Fix error fetching Nature feeds 
Fixes #2249
 2021-11-26 04:20:13 -05:00
Dan Stillman
07df7d0dec Fix standalone notes not being added to collections on RDF import 
This includes the `Zotero.RDF.getResourceURI()` fix in
zotero/translate@85b39a5be.

This position change here for `this._handleRelated()` for attachments
isn't necessary, since the attachment is already saved and already has
an id, but it's done for consistency with the call for notes (where the
note previously didn't yet have an id).
 2021-11-25 00:24:56 -05:00
Tom Najdek
1f6b626717
Change browser in basicViewer to be type="content" 
This fixes an issue where JS on a page loaded in the viewer would error
when referring to window.top or window.parent.
 2021-11-25 01:02:02 +01:00
Tom Najdek
34d62426c3
Tweak URL matching regexp to be more precise 
Institutional login process goes through multiple pages, the URL regexp
is tweaked to be more precise to ensure that no arbitrary URLs are
matched while polling for the final URL with auth code.
 2021-11-25 01:01:55 +01:00
Adomas Venčkauskas
d03c495563 Update SingleFile to the latest version 2021-11-19 14:22:45 +02:00
Dan Stillman
32a5826a1f Log more of the response for downloaded PDFs that aren't PDFs 2021-11-16 14:29:53 -05:00
Martynas Bagdonas
d37662cce7 Fix FF 60 ESR + Apple Silicon CPU usage issue for stacked view 2021-11-16 17:38:48 +02:00
Martynas Bagdonas
8f4084d374 Work around FF 60 ESR + Apple Silicon issue causing 40-60% CPU usage: 
It seems that style calculation gets insane when `overflow: auto` is used inside a collapsed box (specifically inside contextPane), although there might be more factors
 2021-11-16 17:17:38 +02:00
Dan Stillman
54588453dc Fix selection of collections pane on "Focus Libraries Pane" shortcut 2021-11-15 23:13:53 -05:00
Tom Najdek
f10649483e
Mendeley Import: Add more tests for the importer 
Also rephrased a comment in the importer code and renamed tests file
to mendeleyImportTest.js for consistency.
 2021-11-15 11:19:19 +01:00
Adomas Venčkauskas
dcce807e92 Enable publicationTitle column in feeds. Closes #2242 2021-11-09 16:23:33 +02:00
Adomas Venčkauskas
b9e1923656 Fix rows not deselecting with single click on one item. 
Closes #2241
 2021-11-08 14:06:36 +02:00
Martynas Bagdonas
80be9f9e3a Disable annotations transferring for read-only items 
#2239
 2021-11-08 13:24:13 +02:00
Martynas Bagdonas
af689b17fa Fix CMap loading for pdf-worker 2021-11-08 11:42:39 +02:00
Dan Stillman
f5eb99ad4c Upload settings in batches of 250 
Closes #2000
 2021-11-07 23:46:54 -05:00
Abe Jellinek
cd3304e16c
Don't reset isRead when feed item metadata changes (#2215) 
This prevents metadata changes from clearing the isRead status of feed
items as long as GUIDs remain constant. Previously, feed items with
randomized properties (like URLs generated dynamically each time the
feed is served) would be incorrectly marked as unread on every update.
 2021-11-05 23:16:12 -04:00
Abe Jellinek
2cf436c67d
Async web translation (#2229) 2021-11-05 23:12:37 -04:00
Martynas Bagdonas
b4cf566d0d Return back writeAtomic for PDF reader setState #2210 2021-11-05 17:09:40 +02:00
Dan Stillman
f583416d80 Update locales from Transifex and merge new English strings 2021-11-05 03:42:02 -04:00
Dan Stillman
eb4090058d Tweak menu position and alert text for annotation transferring 2021-11-05 00:30:06 -04:00
Dan Stillman
f400d2a4a4 Include item type name in field-not-valid-for-type error 2021-11-05 00:29:45 -04:00
Tom Najdek
7940915bb0
Fix arXiv ID not imported. Fix #2236. (#2238) 
Mendeley online schema uses "arxiv", local DB uses "arxivId" hence it
was skipped. This commit adds mapping and a test.
 2021-11-04 15:32:35 -04:00
Tom Najdek
882ecc205e
Mendeley import: Remove code to patch after earlier imports (#2234) 
Fixes #2233, Mendeley import: Invalid-field-for-type error
 2021-11-03 23:32:36 -04:00
Martynas Bagdonas
c9d4ff4314 Add additional error logging for PDF reader and note editor 2021-11-03 11:50:21 +02:00
Martynas Bagdonas
6ac663a002 Encode a wider range of unicode characters when inserting a note 2021-11-02 15:06:40 +02:00
Adomas Venčkauskas
d530d9cf95 Fix collection open state persistance. Closes #2228 2021-10-29 11:28:41 +03:00
Martynas Bagdonas
90cc53361b Refocus to the last focused node when switching back to Zotero Pane tab 2021-10-28 11:25:25 +03:00
Adomas Venčkauskas
be49786668 Fix column reordering and hiding breaking sorting 2021-10-27 15:18:10 +03:00
Adomas Venčkauskas
5f3eeb7fcd Revert "Hack to fix sorting after reordering columns" 
This reverts commit 69a43ec456.
 2021-10-27 15:18:10 +03:00
Adomas Venčkauskas
aa7e502bad Restore ability to select individual items in duplicates view. 
Closes #2225. Only mouse clicks without modifiers will select the group
of duplicate items. This is the same behavior as with the XUL tree.
 2021-10-27 15:18:10 +03:00
Martynas Bagdonas
bc8b1a7c6d
Implement annotations transferring (#2202) 2021-10-27 13:48:40 +03:00
Martynas Bagdonas
a4cf36794e Focus itemsView when switching to Zotero Pane tab 2021-10-27 11:58:35 +03:00
Martynas Bagdonas
91dfcc96bf Make ZoteroPane keydown handler to catch all key presses on the window 
Fixes #2231
 2021-10-27 11:58:34 +03:00
Martynas Bagdonas
cdb826e358 Don't suggest to create note if only ink annotations exist 2021-10-26 16:56:15 +03:00
Martynas Bagdonas
3736a93c2c Add a work-around for mouseup events that are never triggered in reader 2021-10-26 12:12:03 +03:00
Martynas Bagdonas
d1322bd4b6 Improve PDFRenderer efficiency and add support for ink annotations 2021-10-25 12:46:12 +03:00
Martynas Bagdonas
59455ebfa7 Improve ink annotations support: 
- Allow to select in sidebar or PDF page
- Allow to delete or change color
- Generate image and store as with image annotation
 2021-10-22 10:14:28 +03:00
Martynas Bagdonas
6206209ed2 Fix item pane opening creator-type-menu in a wrong itembox binding 2021-10-19 17:14:44 +03:00
Dan Stillman
5f61ac23aa Don't include non-regular items in one-off bibliographies 
Applies to "Create Bibliography from Collection" and "Create
Bibliography from Items". Quick Copy already got this right.

https://forums.zotero.org/discussion/92305/sticky-notes-showing-in-bibliography
 2021-10-18 17:53:14 -04:00
Martynas Bagdonas
a07c052cf0 Allow to use Quick Copy from PDF reader tab 
Fixes #2023
 2021-10-18 09:57:57 +03:00
Adomas Venčkauskas
4e68b624f2 Persist column settings in the select items dialog. Closes #2224 
I didn't check the previous behavior, but I assume it's the same:
This will persist the same settings for the select items dialog in the
classic citation view as well as the add related item dialog.
 2021-10-15 15:43:00 +03:00
Adomas Venčkauskas
7a9bd56b9d Fix when dragging outside of the text of item pane message. Closes #2223 2021-10-14 15:33:43 +03:00
Dan Stillman
3d4a1a230e
Merge pull request #2217 from tnajdek/2216-mendeley-import-skips-over-large-files 
Concurrently downloading large files
 2021-10-13 13:20:00 -04:00
Martynas Bagdonas
8b11737b82 Import existing images when opening a note 
#2186
 2021-10-13 17:49:44 +03:00
Martynas Bagdonas
a4f09419e5 Fix context pane not properly assigning new note as standalone/child 2021-10-08 22:18:23 +03:00
Martynas Bagdonas
645eb86cbc Don't focus Zotero Pane window when opening a tab in background 2021-10-05 17:30:44 +03:00
Martynas Bagdonas
3c3eac43de Don't focus recognized PDF parent if Zotero Pane tab is not selected 2021-10-05 17:30:44 +03:00
Adomas Venčkauskas
78e31cf50f Fix broken font scaling in the retrieve metadata/progress queue dialog. 
Closes #2218
 2021-10-05 12:55:38 +03:00
Adomas Venčkauskas
62e2ccafa0 Replace deprecated usage of Utilities.itemToCSLJSON 2021-10-05 12:55:38 +03:00
Adomas Venčkauskas
82eb7453a8 Add a method to remove event listeners from event dispatchers 2021-10-05 12:55:38 +03:00
Martynas Bagdonas
05139cfff8 Persist pdf-reader sidebar width 
#2184
 2021-10-04 17:10:31 +03:00
Martynas Bagdonas
7f23533ee9 Automatically update citations when user opens a note 2021-10-04 13:23:03 +03:00
Tom Najdek
a745cde2cf
New implementation of a download function #2216 
This resolves a problem where, in certain scenarios,
Zotero.file.download throws an exception even though file is
successfully downloaded.

Furthermore this new download function should be more memory-efficient,
improving performance when dealing with large files.
 2021-10-02 00:39:10 +02:00
Martynas Bagdonas
3b84e29c9e Update context pane notes list when note is moved to/from parent 2021-10-01 14:47:50 +03:00
Martynas Bagdonas
47c61d3a4d Add limitations for attachment notes 2021-10-01 13:19:20 +03:00
Martynas Bagdonas
c0ecd7691b Focus parent from tab "Show in Library", and PDF file from File menu 2021-09-27 13:46:19 +03:00
Martynas Bagdonas
1f634f9e31 Use OS.File.writeAtomic without tmpPath to avoid #2210 2021-09-23 13:53:47 +03:00
Martynas Bagdonas
47d4949b2a Upgrade note-editor schema to v5: 
- Make citation node a leaf node.
- Don't parse citation node inner text.
- Don't trigger citation inner text updating on citation item changes.
- Format citation text only when serializing note HTML.
- Wrap individual citation items into `<span class="citation-item"></span>`.
 2021-09-22 19:30:44 +03:00
Dan Stillman
571801e1fb Fix min-height on search results in advanced search window 
Regression from HTML tree

Fixes #2206
 2021-09-17 06:11:51 -04:00
Dan Stillman
e2cbb51c31 Update locales from Transifex and merge new English strings 2021-09-17 06:11:51 -04:00
Dan Stillman
7e8bc80c1d "Manage Lookup Engines" dialog tweaks (#2195) 
- Lowercase "engines"
- Increase font size
- Switch to hyphenated element id
 2021-09-17 05:38:56 -04:00
Abe Jellinek
241981057b Correct Lookup Engine description 
The Locate dropdown isn't in the Info pane, and the text was a bit more
verbose than it needed to be.
 2021-09-17 05:38:56 -04:00
Dan Stillman
f0a8c9ada3 Merge pull request #2070 from mrtcode:restore-context-pane-tags-related 2021-09-14 01:53:21 -04:00
Dan Stillman
647afbb089 Update related box if related items are renamed or deleted 2021-09-14 01:50:58 -04:00
Martynas Bagdonas
61e3e339bb Restore tags and related tabs, display note links box 2021-09-14 01:50:58 -04:00
Dan Stillman
fa4020f784 HTML tree: Disable clickthrough on collection and item trees 
And also the tag selector, while we're at it. Leaving enabled for the
item pane.

(Clickthrough is responding to a click when the window doesn't have
focus, rather than having the first click just raise the window.)

Fixes #2203
 2021-09-14 00:43:15 -04:00
Dan Stillman
aeabe0b3f6 Fix inability to drag subcollection to top level within group library 
HTML tree regression

Fixes #2201
 2021-09-14 00:43:15 -04:00
Abe Jellinek
c5067edd2d
Fix Scaffold failing to initialize (#2200) 2021-09-09 05:17:35 -04:00
Martynas Bagdonas
7468065528 Switch to library tab when dragging a PDF file over Zotero window 2021-09-07 16:53:20 +03:00
Martynas Bagdonas
d38d42d60c Focus main window when navigating to annotation from note window 2021-09-07 12:01:42 +03:00
Dan Stillman
7672340819 HTML tree: Don't select all items on Cmd-Shift-A 2021-09-02 20:24:44 -04:00
Dan Stillman
576b9b7817 Fix SQL error saving an item with hundreds of related items 
Fixes #2139
 2021-09-01 06:19:56 -04:00
Dan Stillman
14b7206276 Get row height from tree for ItemTree::ensureRowsAreVisible() 2021-09-01 05:15:44 -04:00
Dan Stillman
dadf630728 HTML tree: ensureRowsAreVisible() shouldn't scroll if unnecessary 
Fixes #2166
 2021-09-01 01:45:54 -04:00
Dan Stillman
69a43ec456 Hack to fix sorting after reordering columns 
There's probably a better fix for this, but this seems to work.
 2021-08-31 06:55:57 -04:00
Dan Stillman
4fa7070a31 Fix item tree sorting when column doesn't have .sortDirection property 2021-08-31 06:55:57 -04:00
Martynas Bagdonas
d77b00bf9a Clarify and comment tab moving code 2021-08-31 11:37:01 +03:00
Adomas Venčkauskas
d8af5b7923 Fix wrong collection contents shown when switching collections at startup 
Closes #2175
 2021-08-30 15:19:12 +03:00
Adomas Venčkauskas
d4b3ed7fd8 HTML Tree: Fix opening multiple items with [Enter] 2021-08-30 15:19:12 +03:00
Martynas Bagdonas
b5ea925d02 Jump back to the opening tab even if the PDF was already open 
Fixes #1985
 2021-08-30 14:56:09 +03:00
Martynas Bagdonas
295874f803 Fix issue where non-existing tab is selected when closing multiple tabs 2021-08-30 14:12:22 +03:00
Martynas Bagdonas
b8cb093f79 Open multiple PDFs in tabs if SHIFT wasn't pressed, remove old code 2021-08-30 13:43:14 +03:00
Adomas Ven
cb9df902bc
HTML Tree: make find as you type a virtualized table functionality (#2176) 
Closes #2168, closes #2169.
Adds find-as-you-type to locate, preference style and export
formats managers.

To enable find as you type you need to specify the getRowString(index) prop
on the VirtualizedTable. See prop comment for more info.
 2021-08-30 06:01:08 -04:00
Adomas Venčkauskas
94c4d975a9 HTML Tree: fix item deletion breakage when child items are selected. 
Closes #2174
 2021-08-30 12:50:29 +03:00
Adomas Venčkauskas
873846261e Fix export preferences HTML tree 2021-08-30 12:06:17 +03:00
Martynas Bagdonas
aa7f5289a3 Filter ink annotations before creating note from annotations 2021-08-30 11:06:10 +03:00
Dan Stillman
c2df338430 Allow 'ink' annotation type to be created 2021-08-30 03:58:58 -04:00
Adomas Venčkauskas
37d5e99fde Fix some keyboard selection bugs in HTML collection tree 
Moving pivot via [CMD/CTRL]+[ArrowKey] would change collection tree
focus without updating the UI
Select-all shortcut worked in the collection tree
 2021-08-30 10:23:03 +03:00
Adomas Venčkauskas
b8545590d5 HTML Tree: more fixes to find as you type 2021-08-30 09:57:28 +03:00
Adomas Venčkauskas
2ef5afdd9c Disable typing navigation with modifier keys pressed. Closes #2170 2021-08-30 09:52:13 +03:00
Dan Stillman
d723065a3d HTML tree: Don't move dragged external files by default on macOS 
Fixes #2172
 2021-08-30 02:40:06 -04:00
Dan Stillman
952663de73 Fix failing repo notice tests 2021-08-29 04:41:52 -04:00
Dan Stillman
2459614f04 Add mechanism for showing dialog with notice from repo 
- Messages are shown once a day by default (within the same session for
  id-less messages)
- Messages with an `id` attribute include a checkbox to not show again
  for 30 days
- If an `infoURL` attribute is provided, a "More Information" button is
  shown that launches that URL
- If `title` is provided, it's used for the dialog title. Otherwise
  "Warning" is shown.
 2021-08-29 04:25:49 -04:00
Dan Stillman
ba7d0a18aa Restore itemTree::saveSelection() 
Deprecated for years, but used by ZotFile
 2021-08-29 01:41:40 -04:00
Dan Stillman
8d3adb6f46 HTML tree: Add tree.focus() 
And fix shortcut key for selecting library
 2021-08-28 22:43:09 -04:00
Dan Stillman
10f2400c59 Merge new English strings 2021-08-27 17:01:33 -04:00
Dan Stillman
dba77cd332 Additional tab context menu tweaks (#2162) 
- Select last reopened tab instead of opening all in background
- Rearrange Close/Close Other Tabs/Reopen Closed Tabs options
- Use proper plural for Reopen Closed Tab[s]
 2021-08-27 16:52:22 -04:00
Martynas Bagdonas
50732d1479 Add tab context menu (#2162) 2021-08-27 16:52:02 -04:00
Dan Stillman
7019544b48 Add ink annotation type 2021-08-27 16:28:45 +03:00
Adomas Venčkauskas
77f726fef3 HTML Tree: improve row scrolling into row behavior upon toggling open 2021-08-27 13:54:33 +03:00
Adomas Venčkauskas
b05e22fa77 HTML Tree: Make search context rows selectable. Closes #2164 
Adds special handling such that context rows are not selected only
when performing a select-all.
 2021-08-27 13:36:03 +03:00
Adomas Venčkauskas
0a7aa10463 HTML Tree: Fix refresh bugs when a feed is modified. Closes #2163 2021-08-27 13:05:35 +03:00
Adomas Venčkauskas
ab9414d1a4 HTML Tree: some additional documentation 2021-08-26 16:40:41 +03:00
Adomas Venčkauskas
a71addb12a Make sure including include.js multiple times does not break monkey-patching 
This is important for plugins that want to monkey-patch interfaces that
are only accessible via require() calls
 2021-08-26 16:21:52 +03:00
Adomas Venčkauskas
b08f2d829f Update the HTML tree to allow extension via Zotero plugins 2021-08-26 16:16:44 +03:00
Adomas Venčkauskas
20e2f33064 HTML Tree: Optimize tree invalidation 2021-08-26 14:40:59 +03:00
Adomas Venčkauskas
bffa64bdda HTML Tree: Re-add item tree methods lost in transition 2021-08-26 10:14:35 +03:00
Adomas Venčkauskas
b91664435f HTML Tree: Fix Show Items from Subcollections. Closes #2160 2021-08-26 09:33:47 +03:00
Martynas Bagdonas
89d1899690 Add UI feedback when moving tab 
Fixes #1988
 2021-08-26 08:23:19 +03:00
Martynas Bagdonas
d55b80df80 Show author and year in PDF reader tab/window title 
Fixes #2034
 2021-08-26 08:23:19 +03:00
Martynas Bagdonas
ecd6d7ce2c Implement tab jumpback 
#1985
 2021-08-26 08:23:19 +03:00
Martynas Bagdonas
b6d562b0cb Allow middle button click to close a tab 
Fixes #1993
 2021-08-26 08:23:19 +03:00
Adomas Venčkauskas
da7527e384 Fix intro message not getting cleared when adding new item. Closes #2158 2021-08-25 18:19:30 +03:00
Dan Stillman
13f2c57196 Fix sizes of items pane messages 
7ef7943a17 made "Loading items…" small again after it got big during
HTMLification but made everything else (e.g., welcome message, My
Publications intro) small as well. This adds an ugly hack to keep the
loading message small for now (without passing dedicated HTML from a
bunch of different places).
 2021-08-25 03:50:12 -04:00
Dan Stillman
e14bd828ca Merge new English strings 2021-08-25 02:36:00 -04:00
Dan Stillman
3592ca9f92 Remove new and unused localized string after 462af98380 2021-08-25 02:29:24 -04:00
Dan Stillman
0bbe064245 Don't toggle libraries-to-sync row on Enter 
Otherwise if you close the dialog with Enter the current row (which is
probably the row you just changed) is toggled

Regression from HTMLification
 2021-08-25 02:27:45 -04:00
Dan Stillman
4d88e99e9e Increase icon column width in libraries-to-sync dialog 
A bit wider than d4e3a437f, since the column header seems to not
currently be centered properly at narrow widths
 2021-08-25 02:18:08 -04:00
Dan Stillman
92e6a536f1 HTML tree: Add alternating rows to all trees except collections on macOS 2021-08-25 02:16:19 -04:00
Dan Stillman
d0635e12cb
Add disableFontSizeScaling prop to HTML tree (#2155) 
Removes `defaultRowHeight` prop added in adb8aa39f in favor of a prop
that disables font size scaling. A non-default row height can still be
specified with `rowHeight`.

Most of our existing trees need to disable font size scaling, but the
idea is that pretty much everything _should_ scale with font size for
accessibility, and it's a limitation of the current prefs and other UIs
that they don't currently, so it's better to default to scaling and
gradually remove uses of this prop.

This fixes a bug where the HTML trees other than the collection and item
trees would have larger rows but without larger text when font size was
increased.

Also:

- Fixes #2157 by fixing line height adjustment on macOS when at the
  default font size, applying it to all trees, and moving the explicit
  `rowHeight` override from the item tree to the collection tree, which
  should have more spacing than all other trees (rather than the item tree
  having less).
 2021-08-25 01:53:22 -04:00
Adomas Venčkauskas
462af98380 Restore libraries-to-sync UX. Closes #2156 2021-08-24 17:15:17 +03:00
Adomas Venčkauskas
6010390525 HTML Tree: Fix column separators misaligned at startup. Closes #2153 2021-08-24 16:44:55 +03:00
Dan Stillman
d4e3a437fd Reduce width of icon column in libraries-to-sync dialog 
Changed during HTMLification
 2021-08-24 01:25:47 -04:00
Martynas Bagdonas
85b142ccb2
Restore tabs state (#2148) 2021-08-23 13:02:57 -04:00
Dan Stillman
f9035c8fda Show emoji colored tags directly in items list 
We can do fun things now.

Also:

- Make colored tag swatches resize with the font size
- Increase border radius for color swatches, and adjust with size
 2021-08-22 04:41:34 -04:00
Dan Stillman
cc4225db1a Restore localized date in Styles list in Cite prefs 
With the new tree, this was showing the full timestamp from the style
object.
 2021-08-21 06:58:12 -04:00
Dan Stillman
adb8aa39f8 Reduce item tree row spacing 
This matches the previous tree on macOS.
 2021-08-21 06:58:12 -04:00
Dan Stillman
7ef7943a17 Reduce item pane message font size 
E.g., "Loading items…"

Maybe we want this bigger, but this is roughly what we had before and
matches the tag selector and item pane messages.
 2021-08-21 06:58:12 -04:00
Dan Stillman
ec35291060 Decrease item tree indent 
Roughly center child item icons between the parent item icon and text,
which looks a bit less awkward than the previous tree's positioning. An
alternative would be to align with the beginning of the parent item text
(a value of 21), but that's a bit spaced out, at least until we have
multiple levels with additional twisties.
 2021-08-21 06:58:12 -04:00
Dan Stillman
c85a434eb6 Reduce collection tree indent 
At least on macOS, this brings it back in line roughly with the previous
version.
 2021-08-21 06:58:12 -04:00
Dan Stillman
c965e6159a Fix collection tree header indentation on macOS 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
881ab5f59e Store column prefs to a dedicated file in a profile dir instead of XPCOM prefs 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
a2062bf011 Fix selection not being maintained when collapsing/expanding rows 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
55c758c9d0 Fix header columns being misaligned with table columns in item tree 
And reindent _virtualized-table.scss
 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
431d7e1eaa Fix alternating-row colours switching upon child expand-collapse 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
efc009f724 Fix collection tree header alignment on macOS 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
7ec89c44ce Improve column sorting speed 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
ff627b7d3f Ensure column order and width prefs are properly retained 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
9e04250142 Do not sort a column on mouseup if mousedown occurred on a different one 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
4cea4519b8 Fix column resizing weirdness with fixed with columns 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
277503f879 Fix rows not being properly redrawn in duplicates view 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
a15fb83cc4 Fix feed sort being wrong 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
c496b5e367 Fix crash message not getting locked 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
8ebf1609b6 Item tree selection changes and fixes 
- Fixes selection events always being debounced
- Fixes some failing tests
- Ensures Select All command selects search matching children of
collapsed parents. Adds tests for this case
 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
6dce19d546 Expand search parents whith Select All shortcut in item tree 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
1db2eb4aea Ensure disabled item tree rows are not selectible with Select All 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
7265393be9 Fix item PDF not opening on double click in tree 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
9c7f28b126 Fix trees not properly redrawing on drag events 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
b671611b51 Fix item tree message not being centered outside of main window 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
d83ec19c23 Do not try to open/close empty collection tree rows on + and - hotkeys 
Causes performance issues
 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
b5dc0e7630 Add a comment for how to open the data generator 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
87014451de Fix item tree selection issues when using + and - hotkeys 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
cc97545bd6 Fix advanced search item tree being invisible on open 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
700ac31eef Ensure \n\n in itemPaneMessage is displayed as a newline 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
82f87a0d8d Add a Restore Column Order choice in the column picker 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
2b6c7277f7 Item Tree: Do not display Title in the columnpicker 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
af597d943b Move js-tree files out from /containers subfolder 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
e68685521b Do not change selection on macOS when using PageUp/Down 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
f773f79d10 Documentation adjustments for virtualized-table 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
82914a9583 JSWindow - WindowedList 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
67d9e87c55 Icons.getDomElement() -> Icons.getDOMElement() 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
47094fc4c3 Misc new tree cleanup 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
d26eba2d2c Adjustments and documentation for Utilities.Internal.makeClassEventDispatcher 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
bcd9d777c9 Remove unused Debug._setLevel() 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
51f13412b9 Documentation for the tree selection 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
5a97f2bdd8 ReactDom -> ReactDOM 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
1e75425698 Fix highlighted collection not unhighlighting 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
2f72ed17b7 Ensure columns with different visibility group retain their config 2021-08-21 06:58:12 -04:00
Adomas Venčkauskas
cbbff600a6 XUL -> JS tree megacommit 
- Just a single huge commit. This has been developed over too long a
time, required many tiny changes across too many files and has seen too
many iterations to be separated into separate commits.
The original branch with all the messy commits will be kept around for
posterity
bb220ad0f2...adomasven:feature/react-item-tree
- Replaces XUL <tree> element across the whole zotero client codebase
with a custom supermegafast virtualized-table inspired by
react-virtualized yet mimicking old XUL treeview API. The
virtualized-table sits on top on a raw-to-the-metal,
interpreted-at-runtime JS based windowing solution inspired by
react-window. React-based solutions could not be used because they were
slow and Zotero UI needs to be responsive and be able to
display thousands of rows in a treeview without any slowdowns.
- Attempts were made at making this screen-reader friendly, but yet to
be tested with something like JAWS
- RTL-friendly
- Styling and behaviour across all platforms was copied as closely as
possible to the original XUL tree
- Instead of row-based scroll snapping this has smooth-scrolling. If
you're using arrow keys to browse through the tree then it effectively
snap-scrolls. Current CSS snap scroll attributes do not seem to work in
the way we would require even on up-to-date browsers, yet alone the ESR
version of FX that Zotero is on. JS solutions are either terrible for
performance or produce inexcusable jitter.
- When dragging-and-dropping items the initial drag freezes the UI for
a fairly jarring amount of time. Does not seem to be fixable due to
the synchronous code that needs to be run in the dragstart handler.
Used to be possible to run that code async with the XUL tree.
- Item tree column picker no longer has a dedicated button. Just
right-click the columns. The column preferences (width, order, etc) are
no longer handled by XUL, which required a custom serialization and
storage solution that throws warnings in the developer console due to
the amount of data being stored. Might cause temporary freezing on HDDs
upon column resize/reorder/visibility toggling.
- Context menu handling code basically unchanged, but any UI changes
that plugins may have wanted to do (including adding new columns) will
have to be redone by them. No serious thought has gone into how plugin
developers would achieve that yet.
- Opens up the possibility for awesome alternative ways to render the
tree items, including things like multiple-row view for the item tree,
which has been requested for a long while especially by users switching
from other referencing software
 2021-08-21 06:58:12 -04:00
Tom Najdek
f274323478
Mendeley import: Move temp downloaded files instead of copying #2149 (#2150) 
During Mendeley api import all attachments are fetched into temporary
location and were previously copied to the storage folder. Only after
import completed, temporary files were deleted. Therefore a complete
import required storage equal to twice the final library size. Switching
to move avoids this problem.

Also:

- Fix _isTempDownloadedFile() check
 2021-08-20 00:07:28 -04:00
Dan Stillman
ddc7be75c7 Use PRAGMA legacy_alter_table=ON for existing schema updates 
This won't make a difference until we update Firefox and get a new
SQLite version, but at that point the existing schema update steps that
recreate tables by renaming the old table would result in broken foreign
keys.

This patch will make sure that newer SQLite versions will use the legacy
behavior for the existing steps, and going forward schema update steps
that want to recreate tables will need to create a new table, migrate
the data, delete the old table, and rename the new one into place.
 2021-08-17 00:41:59 -04:00
Dan Stillman
0f96c20f3c Fix several possible DB upgrade errors from 4.0 to 5.0 
- We were updating global schema before migrating userdata, but a 4 → 5
  upgrade involved a system.sql version bump, which wiped out itemTypes,
  causing 'annotation' to not exist after the upgrade. This moves global
  schema updates after userdata migration and bumps the global schema
  version to repair DBs that were already upgraded and broken.

- A system.sql bump without a global schema update would result in empty
  tables. This moves the global-schema-related tables to userdata.sql.

- The DB integrity check before userdata updates added in 5b9e6497a
  could fail when coming from an older DB, because the checks assume
  current schema. An integrity check is now done after a userdata update.
  (We were already skipping the new table/index reconciliation stuff. If
  old DBs are discovered to have problems that would cause a migration
  step to fail, we'll fix those explicitly in the steps.)

Also:

- Make sure `version` is `versionNumber` in the `fields` table. It was
  changed with a system.sql bump in 5.0, but hard-coded fields were later
  removed from system.sql in favor of schema.json, meaning that anyone who
  upgraded from 4.0 after that would never have `version` removed and so
  would have both fields (one from before and one from schema.json).
 2021-08-17 00:41:59 -04:00
Dan Stillman
f50a3b0840 Merge new English strings 2021-08-13 06:32:37 -04:00
Dan Stillman
3732f97d41 Add OpenURL resolver directory 
Remove the apparently obsolete [1] WorldCat `lookup?IP=requestor` search
functionality and replace with a hierarchical menu populated directly
from our directory [2].

Also switch to https://www.worldcat.org/registry/gateway as the default
resolver, which seems to be the same as
http://worldcatlibraries.org/registry/gateway but with HTTPS support

Fixes #1811
Fixes #1853

[1] https://forums.zotero.org/discussion/79312/search-for-resolvers-gives-out-of-date-information
[2] https://www.zotero.org/support/locate/openurl_resolvers
 2021-08-13 06:25:16 -04:00
Adomas Venčkauskas
5118cd4164 Fix note insertion errors when note does not contain citations 2021-08-13 13:18:15 +03:00
Dan Stillman
15162c277b Update locales from Transifex and merge new English strings 2021-08-12 00:43:18 -04:00
Dan Stillman
ee2b63bf18 Update submodules 2021-08-06 16:56:31 -04:00
Dan Stillman
5ae8e819ef Update utilities submodule and add comment for MAX_TITLE_LENGTH 2021-08-06 16:06:29 -04:00
Martynas Bagdonas
9b3367f227 Allow zotero://open-pdf/ to navigate to specific annotation by key 
zotero://open-pdf/library/items/AABBCCDD?annotation=[annotation-key]

Fallback to a page if annotation is missing:
zotero://open-pdf/library/items/AABBCCDD?page=123&annotation=[annotation-key]

Fixes #2125
 2021-08-06 13:06:40 +03:00
Martynas Bagdonas
6472321000 Upgrade note-editor schema to v4: 
- Set `annotation.attachmentURI` instead of `annotation.uri` when inserting annotations
- Migrate `annotation.uri` to `annotation.attachmentURI`
- Add `annotation.annotationKey` that references to the original annotation
 2021-08-06 13:06:40 +03:00
Martynas Bagdonas
a065d477ed Add zoom options to View menu 
Fixes #2138
 2021-08-05 11:27:54 +03:00
Martynas Bagdonas
bd56b16247 Fix missing checkbox issue for standalone PDF reader window 2021-08-05 11:23:35 +03:00
Dan Stillman
97b381f435 Update utilities submodule (fixes #2141) 
Follow-up to #2128
 2021-08-04 20:40:27 -04:00
Dan Stillman
b1e63c8fe1 Update translate and utilities submodules 2021-08-04 20:02:46 -04:00
Abe Jellinek
4ebed5dee7
Update strings and add test for ADS Bibcode extraction (#2128) 2021-08-04 19:37:49 -04:00
Abe Jellinek
4475e86eac
Fix error when connector requests translators (#2135) 
The call to done() resulted in a 500 response and prevented the
connector from fetching the list of available translators.
 2021-08-04 04:39:43 -04:00
Martynas Bagdonas
7015c8df59 Fix missing menu checkbox issue on pdf-reader and note-editor on Windows 2021-08-02 11:45:30 +03:00
Abe Jellinek
5bfdeb36ca
Exclude unmergeable types by name, not by ID (#2137) 
Excluding by ID obscured which types were being excluded. IDs drifted
and we ended up blacklisting artwork and encyclopediaArticle.
 2021-07-30 16:15:10 -04:00
Adomas Venčkauskas
0e2073b251 Revert removal of Utilities.Internal.itemToExportFormat() (since c929055) 2021-07-30 14:28:14 +03:00
Adomas Venčkauskas
4d497afea0 Use Translator Tester code from shared repo for Scaffold 2021-07-28 15:46:07 +03:00
Adomas Venčkauskas
8f90cfbcfd Remove obsolete files after shared code modularization 2021-07-28 15:46:07 +03:00
Adomas Venčkauskas
7814efcfe2 Use zotero/translate and zotero/utilities for shared code 2021-07-28 15:46:07 +03:00
Adomas Venčkauskas
c929055571 Refactor utilities code in preparation to move to external repo 2021-07-28 15:46:07 +03:00
Martynas Bagdonas
e0bc873bce Improve embedded note image loading and deletion: 
- Delete unused embedded images when note is closed.
- Load images as soon as they are downloaded.
- Introduce new notification for download event, and a test for it.
- Prevent simultaneous downloads of the same attachment.
 2021-07-28 13:49:04 +03:00
Martynas Bagdonas
3c658fc672
Copy embedded images, downloaded when needed or show a warning (#2129) 2021-07-26 13:04:38 +03:00
Martynas Bagdonas
a40ac2907e Open PDF files over viewAttachment() to reuse its logic (download, etc.) 2021-07-22 17:54:46 +03:00
Martynas Bagdonas
415973d83c Update citations only on note edit to avoid sync loops 2021-07-21 21:30:53 +03:00
Martynas Bagdonas
aa11c36a64 Little fixes to note editor: 
- Fix invalid selector
- Filter itself sent postMessage messages
 2021-07-21 21:20:20 +03:00
Dan Stillman
6a6e4fa92c Don't update retractions on bundled file update notification 2021-07-21 03:45:25 -04:00
Dan Stillman
2dd16b44d6 Ignore items in target library trash for cross-library drags 
Just don't consider items in the trash to be linked items in
item.getLinkedItem(). I'm not totally sure why we didn't do this many
years ago, since it's one of the biggest sources of confusion in Zotero.

This addresses #1648 and closes #1610, though not by undeleting and
overwriting the item in the trash. When deleting an item and then
re-dragging it from another library, I think most people would expect
the item in the trash to still exist (possibly with notes, etc.), rather
than having been automatically restored and overwritten with new data.
 2021-07-20 23:45:40 -04:00
J. Ryan Stinnett
6b8bbaf980 Rename metaOrCtrl to cmdOrCtrl 
Since we're already testing for macOS, let's go for clarity and call the meta
key Cmd here, since that's what it is.
 2021-07-15 09:26:36 +01:00
Tom Najdek
ec2ad91938
Mendeley import: Add "★" tag for favourite items (#2122) 
Also ensure that "★" tag is added to an existing item on re-import
where appropriate.
 2021-07-13 06:28:05 -04:00
Abe Jellinek
d2db842938
Scaffold: Add action to open test URL in internal browser (#2117) 2021-07-13 03:33:57 -04:00
J. Ryan Stinnett
738d449bea Add MetaOrCtrl-1 through 9 tab navigation 2021-07-11 02:28:25 +01:00
J. Ryan Stinnett
051a84686f Add Ctrl-Tab / Ctrl-Shift-Tab tab navigation 2021-07-11 02:28:25 +01:00
J. Ryan Stinnett
3a95e2e303 Add Cmd-Shift-[ / ] tab navigation on macOS only 2021-07-11 02:28:25 +01:00
J. Ryan Stinnett
28b34bb958 Add stop propagation to existing tab navigation 2021-07-11 01:32:17 +01:00
J. Ryan Stinnett
9afc6e8f47 Tweak existing tab navigation style 2021-07-11 01:29:42 +01:00
J. Ryan Stinnett
d231a03308 Move tab navigation above from and document checks 
This ensure tab navigation functions are always available throughout Zotero.
 2021-07-11 01:03:10 +01:00
Abe Jellinek
f942c224f5
Scaffold: Run/delete tests with the keyboard (#2118) 2021-07-09 03:42:08 -04:00
Dan Stillman
fb01339c6b Implement library.isGroup property, which was never properly implemented 
And since `Zotero.Libraries.isGroupLibrary()` just checked that
property, that hasn't worked either since `isGroup` was added in 2015.

There's no test for `.isGroup`, and the test for `isGroupLibrary()` used
`if()` instead of `it()`, so it never actually ran.

Also:

- Remove old code block in search.js that called `isGroupLibrary()`.
  Since `isGroupLibrary()` didn't work, this block was unused, and its
  logic was previously added elsewhere.
 2021-07-07 01:43:22 -04:00
Dan Stillman
314f66c84a Fix comment on Zotero.Item::clone() 2021-07-07 00:17:29 -04:00
Martynas Bagdonas
9e7ab68fb4 Localize color names in pdf-reader 2021-07-06 16:57:47 +03:00
Martynas Bagdonas
28f5fed509 Increase pdf-reader default sidebar width 2021-07-06 16:52:47 +03:00
Martynas Bagdonas
3b6c31319d Tweak pdf-reader and note-editor read-only mode code 2021-07-06 16:52:46 +03:00
Martynas Bagdonas
de7ede5d9b Properly disable read-only actions in notes list context menus 2021-07-01 14:14:43 +03:00
Martynas Bagdonas
0e76c31608 Add Zotero.enablePDFBuildForGroups switch 2021-06-30 17:30:24 +03:00
Martynas Bagdonas
26d784ca0f Allow read-only note editing in a separate window in PDF build 2021-06-30 17:03:10 +03:00
Martynas Bagdonas
ee9ebc6152 Fix contextPane note regression that unpurposely enables read-only mode 2021-06-30 17:03:10 +03:00
Martynas Bagdonas
f4e7c8293b Don't allow to create/delete notes in contextPane in read-only libraries 2021-06-29 17:27:27 +03:00
Martynas Bagdonas
ab200cc60b Improve annotations insertion into notes: 
- Properly transform HTML tags flavored plain-text into actual HTML
- Add support for multiline comments and highlights
- Insert newline before citation/comment when necessary
 2021-06-29 16:03:54 +03:00
Martynas Bagdonas
f2a440185b Filter i, b, sub, sup tags from annotation comment when exporting to PDF 2021-06-29 13:49:36 +03:00
Dan Stillman
fdcd4e51c5 Handle additional cases of conflicting translators 
And fix test failure from bde9a74f9d in CI, where the file list order is
different
 2021-06-26 20:17:57 -04:00
Dan Stillman
06075a25c0 Fix regression in b8ad18e96d 
We're relying on Bluebird's synchronous promise inspection for noWait
translate mode (as used in Quick Copy). We should decide if we want to
keep the Bluebird dependency or rewrite this to use native promises
(e.g., with a separate synchronous `_loadTranslator()` function for
noWait mode), but for now just restore the `Zotero.Promise.method()`.
 2021-06-26 17:51:17 -04:00
Dan Stillman
ebc21742dd Update locales from Transifex and merge new English strings 2021-06-26 17:51:17 -04:00
Dan Stillman
261bb7ee91 Dictionary handling improvements 
- Fix installation of dictionaries on Windows
- Use version in XPI download URL (zotero/zotero-build@c3308c7a4)
- Improve display of download errors
 2021-06-26 17:09:23 -04:00
Martynas Bagdonas
425daa3622 Make pdf-reader read-only when item is in trash or read-only group 2021-06-25 19:21:39 +03:00
Dan Stillman
b8ad18e96d Fix broken detection after error loading a translator's code 
The bug fixed in bde9a74f9d was triggering an error getting code for a
deleted search translator, which due to this bug caused a double
complete() call that got detection all out of sync, which caused some
search translators to be skipped, which resulted in ISBN lookup
failures.
 2021-06-25 06:49:54 -04:00
Dan Stillman
bde9a74f9d Clear caches properly when deleting duplicate translator 
Among other things, if the name of a translator was changed, until
restart Zotero.Translators.getAllForType() would return the old cache
entry pointing to a file that no longer existed.
 2021-06-25 06:49:18 -04:00
Martynas Bagdonas
d9eb45bf0e Don't show note-editor replace bar by default, rename input to "Replace" 
Fixes #2107
 2021-06-24 13:53:40 +03:00
Dan Stillman
f80ba89971 Massively speed up tests 
- Make a copy of the database after first initialization that can be
  swapped in when reinitializing in resetDB()
- Avoid unnecessary one-second delay on every reset

Probably more that can be done, but this should take minutes off the
test runs
 2021-06-24 06:10:40 -04:00
Martynas Bagdonas
88280641ac Avoid setTimeout call on every note-editor context menu popup 
Fixes #2111
 2021-06-24 11:32:43 +03:00
Dan Stillman
3fc7ce8e7d Update locales from Transifex and merge new English strings 2021-06-23 22:06:31 -04:00
Martynas Bagdonas
e3758dc581 Delay popup with spell checker initialization to fix missing checkmark 2021-06-23 21:56:11 -04:00
Dan Stillman
9a7016ad64 Spell checker improvements 
- Add/Remove Dictionaries window
- Better account for the (unlikely) possibility that a dictionary could
  be replaced by another more popular dictionary provided by a different
  extension id (tested)
- Better account for the (very unlikely) possibility that an extension
  could bundle multiple dictionaries (untested)
- Use toolkit version comparator for proper extension version
  comparisons
- Localize strings
- Add tests for updating
 2021-06-23 21:56:11 -04:00
Dan Stillman
7f2296b1fb Tweak a couple error messages for HTTP.BrowserOfflineException 2021-06-23 21:56:11 -04:00
Dan Stillman
1e2ad01f99 Zotero.File.download(): Throw error on non-200 response 2021-06-23 21:56:07 -04:00
Martynas Bagdonas
814cbc0ee3 Introduce spell checker context menu and dictionaries managing 2021-06-23 19:25:46 -04:00
Dan Stillman
02db8e620e Update locales from Transifex and merge new English strings 2021-06-22 16:06:04 -04:00
Martynas Bagdonas
ac47578a7b Add an option to remove previously set annotation colors in note-editor 
Fixes #2106
 2021-06-22 12:25:45 +03:00
Martynas Bagdonas
6c16d7625a Redesign find-replace bar 2021-06-22 09:34:37 +03:00
Dan Stillman
5c5b3c8565 Updates locales from Transifex and merge new English strings 2021-06-22 01:24:09 -04:00
Dan Stillman
00a0231e4f Remove "\n" from localized string for note annotation header 
Follow-up to 47f897fe8c
 2021-06-22 01:13:17 -04:00
Dan Stillman
91ebbc1bc9 Changes to colored tag toggling via keyboard 
- Update Date Modified when toggling tags via keyboard
  (https://forums.zotero.org/discussion/90371/bug-toggling-a-colored-tag-with-number-keys-doesnt-update-date-modified)
- If any selected items don't have the tag, add it to all items, instead
  of deciding based on the first item
  (https://forums.zotero.org/discussion/79900/minor-issue-related-to-colored-tags)
 2021-06-22 01:01:51 -04:00
Dan Stillman
42b4b173f3 Store lastCompatibleVersion during schema initialization 
Otherwise switching back to release from beta doesn't show the last-used
version if the beta hasn't gone through at least one
compatibility-breaking schema update.
 2021-06-21 01:16:18 -04:00
Abe Jellinek
e285415451
Make resolveURL available to translators (#2101) 2021-06-18 15:18:44 -04:00
Martynas Bagdonas
47f897fe8c Use two lines for extracted annotation header and fix title extraction 
Fixes #2095
 2021-06-18 13:03:25 +03:00
Martynas Bagdonas
b5edc0d9c1 Reorganize note-editor toolbar 2021-06-17 14:07:09 +03:00
Dan Stillman
7a4b27e774
Merge pull request #2071 from jryans/feed-processor 
Import feed processor
 2021-06-17 03:27:36 -04:00
J. Ryan Stinnett
eaa01901ef Wire up new feed processor to Zotero's feed reader 
This connects the new feed processor to Zotero's existing feed reader. The new
feed processor assumes a content window environment, so a sandbox in a parent
window is used to load it.
 2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
af6029b854 Convert feed processor to native URLs 2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
be80598c6b Convert feed processor data away from XPCOM 
This changes the feed processor XPCOM array and property bags to native arrays
and objects.
 2021-06-16 20:59:57 +01:00
J. Ryan Stinnett
088483b776 Fix lint issues in feedReader.js 2021-06-16 20:59:57 +01:00
Tom Najdek
f1414731da
Blur active field in switchCreatorMode #2087 (#2088) 2021-06-14 17:33:55 -04:00
Abe Jellinek
f83559feb8
Correct creator fields in OpenURL (#2079) 
There is no isInstitution field, so OpenURL search was producing invalid
data for items with institutional authors. Instead we use the name field
in API JSON and the isInstitution flag in internal JSON.
 2021-06-14 14:49:49 -04:00
qqobb
5359db39d0
Run JavaScript: Improve await regex (#2083) 
Tests: https://regex101.com/r/eQYCIp/1
 2021-06-12 02:44:39 -04:00
Tom Najdek
864b135da4
Mendeley import: Simplify filename logic #2067 (#2085) 2021-06-11 13:35:09 -04:00
Martynas Bagdonas
3beb858275 Upgrade note-editor schema to v3: 
- No longer store `text` property in highlight annotation
- Remove `text` property when modifying a note
 2021-06-09 17:48:55 +03:00
Martynas Bagdonas
43bd1af3e9 Prepare read-only check for group library annotations 2021-06-08 10:10:21 +03:00
Martynas Bagdonas
87ef6ceacc Fix notesList more button notes count 2021-06-04 18:27:43 +03:00
Martynas Bagdonas
6d0067b806 Do not escape existing HTML entities when citing note 2021-06-04 11:49:11 +03:00
Dan Stillman
2fd46157f3 Enable Basque locale 2021-06-04 02:16:20 -04:00
Dan Stillman
3cfc31c445 Add TODO to pass libraryID in advanced search autocomplete 
This will probably conflict with an open PR, but that should be fixed to
do the same.
 2021-06-04 02:15:16 -04:00
Dan Stillman
07eda894f3 Don't trigger 'redraw' event on attachment download 404 
There's no need to refresh the attachments column of the item row if
nothing was downloaded.

Also remove some unnecessary logging
 2021-06-03 23:39:52 -04:00
Martynas Bagdonas
a5fe49b866 Remove sync buttons from PDF reader toolbar 
Fixes #2045
 2021-06-02 20:39:44 +03:00
Martynas Bagdonas
a418d5ae8d Fix RTL mode in pdf-reader, note-editor, contextPane 2021-06-01 11:37:07 +03:00
Dan Stillman
1bf7b1e88e Fix updating of attachment title in right-hand pane when changed 
https://forums.zotero.org/discussion/88225/attached-file-name-doesnt-change-immediately-at-5-0-97-beta-2-8b1b2ee56
 2021-05-31 03:26:06 -04:00
Dan Stillman
1daf4b0413 Update locales from Transifex and merge new English strings 2021-05-28 02:58:53 -04:00
Martynas Bagdonas
ded077dc8e Use Zotero.appName for localization in note-editor 
Fixes #2073
 2021-05-27 13:38:09 +03:00
Dan Stillman
6be797bc14 Fix additional imported Mendeley annotation color ("#000") 
This is going to start redacting people's PDFs until we change the
default opacity.
 2021-05-27 05:30:39 -04:00
Martynas Bagdonas
cf344335ed Use item display title for PDF reader tabs 2021-05-25 19:48:35 +03:00
Martynas Bagdonas
bb40928720 Localize formatted citations in notes 
Fixes #2040
 2021-05-25 13:07:24 +03:00
Martynas Bagdonas
faec1f1dee Provide filename for recognizer server 2021-05-25 10:30:54 +03:00
Martynas Bagdonas
b2acb5e339 Fix missing title in PDF reader standalone window 2021-05-21 17:20:12 +03:00
Martynas Bagdonas
eb085f2bbe Reorganize View menu, add checkmarks, introduce Go menu 
Fixes #2037
Fixes #1997
 2021-05-21 17:20:11 +03:00
Martynas Bagdonas
39b56a66dc Fix blank standalone PDF reader window issue 2021-05-21 15:44:38 +03:00
Martynas Bagdonas
1e0b5272a4 Add missing Page and Read-only localizations 2021-05-21 15:24:56 +03:00
Martynas Bagdonas
a7c6979e75 Add space between items in multi-item citation 2021-05-21 15:24:56 +03:00
Dan Stillman
cdf1f3c856 Mendeley import: Use bytes for path/filename limits on Windows 
It's not totally clear how it's calculated, but it doesn't seem to be
just characters.

And make the path limit 255, which is the File Explorer limit, even if
the filesystem can allow up to 260.
 2021-05-21 03:02:41 -04:00
Abe Jellinek
06660d04f0
Scaffold: Update year and add spacing in template (#2066) 2021-05-21 00:53:19 -04:00
Dan Stillman
bec42fe2a5 Handle multibyte characters in Zotero.File.truncateFileName() 
Filesystems care about byte length, not character length, so treat
maxLength as the byte length limit and truncate accordingly.

This will also now remove entire emoji characters without corrupting
them.
 2021-05-20 19:25:57 -04:00
Dan Stillman
b511e452a8 Mendeley import: Only limit paths to 260 characters on Windows 2021-05-20 19:25:15 -04:00
Tom Najdek
7582147dd5
Mendeley Import: Prevent tmp path > 260 chars 2021-05-20 12:53:34 +02:00
Tom Najdek
63205a73e8
Improve truncateFileName logic for edge cases 2021-05-20 12:41:49 +02:00
Tom Najdek
89d81cee41
Mendeley import: Sanitize names of fetched files 2021-05-20 12:41:44 +02:00
Tom Najdek
faf094f0aa
Mendeley import: shorten tmp file path 2021-05-20 11:18:23 +02:00
Martynas Bagdonas
5497598c63 Localize pdf-reader and note-editor 2021-05-20 10:49:03 +03:00
Dan Stillman
861d5787d8 Mendeley online import: Fix error if downloaded file doesn't exist 
If a file attached to an item with a URL wasn't found in the temp
directory, it would trigger an error that stopped the sync. (I'm not
sure how a file wouldn't exist.)
 2021-05-20 03:15:15 -04:00
J. Ryan Stinnett
d3d2212a0f Start tab title tooltips on mousemove 
By changing to `mousemove` to start the tab title tooltip, the behavior matches
applications like Firefox more closely: you can always get the latest tooltip
back after changing state by nudging the mouse (without having to exit and
re-enter anything).
 2021-05-18 14:43:09 +01:00
J. Ryan Stinnett
b27ac6649e Hide tab title tooltips whenever the tab bar changes 
This hides tooltips (such as the tab title tooltip) whenever the tab bar state
changes, such as when adding or removing a tab, to ensure we don't leave any
tooltips behind that no longer match reality.

Fixes https://github.com/zotero/zotero/issues/2060
 2021-05-18 14:42:56 +01:00
J. Ryan Stinnett
5b7e01dff6 Rename tab event handlers to clarify target 2021-05-18 13:31:32 +01:00
Dan Stillman
e7f93cb548 Fix appearance of error report text in dark mode on Linux 
Closes #2021
 2021-05-16 05:08:44 -04:00
Dan Stillman
3815197b92 Don't allow site-specific Quick Copy setting without domain 
And remove existing blank entry in schema update step

Closes #2053
 2021-05-16 05:08:44 -04:00
Dan Stillman
1b2a6c13a8
Merge pull request #2016 from Dylan-Evan/master 
Fix dark theme on Item Type
 2021-05-16 04:25:54 -04:00
Dan Stillman
7217cd407a
Merge pull request #2009 from WesleyFord/master 
Fix background color of the dropdown menu.
 2021-05-16 04:22:03 -04:00
Dan Stillman
3880687d2b
Merge pull request #2039 from HollandeP/master 
Made About page text visible across default Linux themes
 2021-05-16 04:15:17 -04:00
Dan Stillman
675184f7a7 Update locales from Transifex and merge new English strings 2021-05-15 15:21:21 -04:00
Dan Stillman
2799dfef5b Clarify sync-to-empty-database warning 
Closes #1959
 2021-05-15 15:09:33 -04:00
Dan Stillman
3aa355a8b4 Add Zotero.DB.path property 2021-05-15 15:09:33 -04:00
Dan Stillman
146e1af189 Update submodules 2021-05-14 22:44:33 -04:00
Dan Stillman
6834c6062b Fix auto-sync timeout in notes 
Regression in 7ace5ea29
 2021-05-14 05:13:19 -04:00
Dan Stillman
53f53779a3 Mendeley import: Don't show local import option 
It's still possible to trigger a local import from a 1.18 database by
selecting the .sqlite file directly from the file option, but don't
offer it in the dialog.
 2021-05-14 04:27:19 -04:00
Dan Stillman
7e23cfef96 Fix invalid imported Mendeley annotation color 
After fix in 808b71832e

And require annotation colors to be 6-char hex colors going forward
 2021-05-14 04:20:50 -04:00
Dan Stillman
f925f0e402 Don't cache SQL statements during initialization 
From executeSQLFile()
 2021-05-14 04:20:50 -04:00
Dan Stillman
d2b36c4218 Deduplicate libraryIDs passed to setSyncTimeout() for an auto-sync 2021-05-14 04:20:50 -04:00
Dan Stillman
5eb6935842 Deduplicate queued sync options 
E.g., if a sync is ongoing and there are multiple item saves that would
trigger auto-sync with the same options, only queue a single sync.

7ace5ea29e fixed the main cause of this, but in case some other
saves end up happening during a sync, this will prevent them from
triggering multiple sync loops with the same options.
 2021-05-14 04:20:36 -04:00
Dan Stillman
7ace5ea29e Fix unnecessary sync looping after downloading items 
An extra sync loop would be performed for every object downloaded, so a
download to an empty database could result in a huge number of
unnecessary loops. This was a regression from 52932b6eb, which started
queuing auto-syncs while a sync was in progress. The fix here is to skip
auto-sync for all objects saved from a sync download.

There are two new mechanisms involved:

- Event-level notifier options that get passed to passed to notify() at
  the top level of extraData rather than being included with every
  object (e.g., because `skipAutoSync` should apply to an entire save
  transaction)
- The ability to pass event-level notifier options when initializing
  a Zotero.Notifier.Queue, such as the one used for sync downloads
 2021-05-14 03:49:26 -04:00
Dan Stillman
5b0f02a12b Trigger auto-sync after item deletion 
It looks like this has been broken for years.
 2021-05-14 03:49:26 -04:00
Dan Stillman
9a47f74787 Specify note auto-sync timeout in save call, not in sync event listener 
This will allow other operations to specify a longer timeout.
 2021-05-14 03:49:26 -04:00
Tom Najdek
808b71832e Fix rgb to hex color conversion 2021-05-13 15:52:54 -04:00
Tom Najdek
833ee10516 Mendeley import: Switch to authorisation code flow via proxy 2021-05-10 14:32:02 -04:00
Dan Stillman
d3a78982f0 Add attr()/text() to search translators 2021-05-07 14:57:55 -04:00
Dan Stillman
d27b622f9f Mendeley import: Fill in Publication field on existing items if empty 
It was skipped in online imports before eef0fc6fa8.
 2021-05-06 15:59:46 -04:00
Dan Stillman
eef0fc6fa8 Mendeley online import: Fix "Journal" → "Publication" mapping 2021-05-06 15:46:35 -04:00
Dan Stillman
6d5b00e94c Fix descendant collections not skipping delete log 
If a collection was deleted with `skipDeleteLog: true`, descendant
collections still ended up in the delete log, which could cause
constant "Reset Group and Sync" prompts.

https://forums.zotero.org/discussion/89485/warning-when-syncing-group-library
 2021-05-06 03:34:09 -04:00
J. Ryan Stinnett
74b9604c7b Show full tab title on hover 
Fixes https://github.com/zotero/zotero/issues/2033
 2021-05-05 01:20:42 -04:00
J. Ryan Stinnett
12b100fd4b Hide tab bar for single tab case on Windows and Linux 
This hides the tab bar on Windows and Linux, where it currently takes up a lot
of vertical space below the menu bar. On macOS, the tab bar remains always shown
since we don't have the menu bar and can move tabs in the window there.

Fixes https://github.com/zotero/zotero/issues/2019
 2021-05-03 17:24:05 -04:00
Martynas Bagdonas
a74c012b65 Improve contextPane notes list performance 2021-05-03 21:41:41 +03:00
Dan Stillman
83a12bca89 Update locales from Transifex and merge new English strings 2021-04-30 07:34:01 -04:00
Dan Stillman
48d5ec240e Mendeley import: Tweak intro text 2021-04-30 07:14:19 -04:00
Dan Stillman
3877563abe Mendeley import: Clear cookies when closing OAuth window 2021-04-30 07:10:58 -04:00
Dan Stillman
911e1637f2 Update locales from Transifex and merge new English strings 2021-04-29 03:34:56 -04:00
Dan Stillman
57fbe61f93 Use notifier queue during Mendeley import 
This dramatically speeds up Mendeley imports by avoiding UI updates.
Regular imports in fileInterface have done this for a while, but the
Mendeley importer used a fake translation object that didn't use the
passed queue.

After this change, a 10,000-item import goes from 9m30s to 2m45s, a 71%
decrease.
 2021-04-29 00:46:18 -04:00
Dan Stillman
bb75fcd784 Fix support link in encrypted Mendeley database message 
It started being flattened at some point.
 2021-04-29 00:46:18 -04:00
Dan Stillman
3032cc6a02 Increase default basicViewer height to 700 
Though this is currently persisted, so it stops being relevant as soon
as one instance of the basic viewer is resized, which maybe we don't
want.
 2021-04-29 00:45:52 -04:00
Dan Stillman
d35719d0e8 Mendeley online import tweaks 
- Add "(online import)" and "(local import)" next to "Mendeley Referance
  Manager" and "Mendeley Desktop", respectively
- Adjust size of OAuth window
- Use bound parameter instead of string literal for Fx78 compatibility
 2021-04-29 00:45:23 -04:00
Tom Najdek
962222a5f5 Mendeley import: Import annotations from matching files in groups 
All annotations in all groups are fetched and hashes are compared to
detect annotations created on the same file while it was in a group
library. Annotations created by other users are filtered out.
 2021-04-29 00:40:44 -04:00
Tom Najdek
d4d2080a31 Mendeley online importer 2021-04-29 00:40:44 -04:00
Martynas Bagdonas
8799de5284 Display embedded images in item reports 
Fixes #2002
 2021-04-28 13:05:43 +03:00
Martynas Bagdonas
65329dbf27 Improve popup actions when read-only or multiple annotations selected 
Fixes #2046
 2021-04-28 12:45:53 +03:00
Martynas Bagdonas
3c3c1ba88a Add "Show in Library" option to PDF reader file menu #2032 2021-04-27 12:50:13 +03:00
Martynas Bagdonas
09125277ac Focus note-editor faster 2021-04-27 11:01:23 +03:00
Martynas Bagdonas
0b219ed8a7 Prevent opening multiple PDFs in windows when shift isn't pressed 2021-04-26 22:49:52 +03:00
Martynas Bagdonas
e7eae06d8d Optimize contextPane notes list rendering 2021-04-26 22:08:11 +03:00
Dan Stillman
76d8818bed Don't count missing annotation values as changed if empty string passed 
Similar to 0d377a1c4a, this fixes an unnecessary annotation reload and
loss of unsaved typing on auto-sync immediately after an annotation is
created.
 2021-04-26 03:49:59 -04:00
Dan Stillman
0d377a1c4a Clear changed state of annotation after saving color change 
This was resulting in an extra 'modify' event after each sync upload.
 2021-04-24 19:49:08 -04:00
Dan Stillman
ea42789206 Avoid memory leaks from caching unique DB statements 
Many DB statements that were being cached included embedded ids or temp
table names, so they would permanently use memory and never get reused.
During large imports, this could result in hundreds of megabytes of
extra memory usage.

This commit marks many more statements as `noCache`, adds `noCache`
support for column and value queries, adds a log line at DB shutdown in
source builds with the number of cached statements, and adds
Zotero.DB.getCachedStatements() for auditing of cached statements.

Addresses #1531
 2021-04-22 02:53:29 -04:00
Dan Stillman
12045a7cf8 Add Zotero.isSourceBuild 
This should be used sparingly, since it risks missing problems in
released builds.
 2021-04-21 21:37:56 -04:00
Martynas Bagdonas
1eb888d026 Fix missing itemData when creating a note from annotations 2021-04-21 16:55:44 +03:00
Martynas Bagdonas
3de7b6c5ec Trim whitespace from highlights and comments when creating a note 2021-04-21 16:52:19 +03:00
Dan Stillman
6eed0876de Update locales from Transifex and merge new English strings 2021-04-20 17:24:34 -04:00
Dan Stillman
78920f0aca Missing string changes from 7065dacee 2021-04-20 16:32:42 -04:00
Dan Stillman
7065dacee8 Move About pane strings and URLs to ZOTERO_CONFIG 2021-04-19 18:30:21 -04:00
Dan Stillman
749e28dc1f Fix alphabetical sorting of child attachments in new databases 
Broken after global schema introduction
 2021-04-18 01:44:39 -04:00
Martynas Bagdonas
633710c90b Improve note-editor: 
- Allow to format citations inside note-editor
- Allow quickFormat dialog to display and pick already cited items, even if an item no longer exists
- Watch and automatically update citation itemData in metadata container and re-format citations in body in opened notes
- Reorganize note metadata container handling and improve resistance to accidentally breaking it in further development
- Improve performance when typing in larger notes
- Rewrite note saving mechanism to support automatic note changes and reduce complexity for further development
- Cleanup and comment some core parts or note-editor as the preparation for further development
- Prepopulate quickFormat dialog with the currently opened PDF parent #1984 (doesn't include the currently scrolled page label yet)
 2021-04-16 17:55:05 +03:00
HollandeP
4ab6fe8c59 Made About page text visible across default Linux themes 2021-04-13 11:46:56 -04:00
Adomas Venčkauskas
ffab4d5243 Add an optional callback for Integration.initPipe(). Addresses #2031 2021-04-12 12:35:51 +03:00
Dan Stillman
52932b6eb0 Reduce auto-sync timeout to 3 seconds and optimize auto-sync process 
Reduce timeout after an object change from 15 seconds to 3 seconds,
ecxept for individual notes. We should probably kick off an auto-sync
3 seconds after a note is blurred, but that's not implemented.

We also now skip file syncing and full-text content syncing altogether
unless an attachment has changed.

Reindexing an item now kicks off auto-sync, whereas before it didn't.
 2021-04-06 05:09:42 -04:00
Adomas Venčkauskas
8bff4cff42 Fix the attempt to display the delay citation updates dialog breaking updates 
Since 2b3669afd
 2021-04-05 16:23:43 +03:00
Adomas Venčkauskas
a6fc2cb206 Fix embedded item citing (since 2e9e6554) 
I don't know how this has not been reported yet
 2021-04-05 16:23:43 +03:00
Martynas Bagdonas
bbb0f8bca4 Do not strip abstract from citation items data in notes 2021-04-05 09:00:28 +03:00
Martynas Bagdonas
c3a74a22d7 Update signature for _serializeAnnotations and return object instead 2021-04-03 11:08:57 +03:00
Martynas Bagdonas
20022a5d7c Properly check schema version in note editor tests 2021-04-02 21:57:35 +03:00
Martynas Bagdonas
415e644211 Upgrade note schema to v2: 
- Automatically upgrade all editable v1 notes when note is being opened
- Pull `itemData` from existing citations and annotations into metadata container attribute `data-citation-items`
- Strip `abstract` from `itemData`
- Fill `citationItem` (in citations and annotations) with `itemData` when passing an HTML fragment for further processing in `note-editor`
- Keep only `uri`, `text`, `color`, `pageLabel`, `position`, `citationItem` annotation properties
 2021-04-02 18:35:01 +03:00
Dan Stillman
26bf507fe2 Throw invalid-data error on unknown annotation type 2021-04-01 05:52:14 -04:00
Dan Stillman
40b871c2fd Updates locales from Transifex and merge new English strings 2021-03-29 02:19:04 -04:00
Dan Stillman
e5ef3affd2
Merge pull request #2017 from Elaborendum/master 
Add localizable strings from connector
 2021-03-29 02:18:41 -04:00
Dan Stillman
6d212b1759 Update About window 
- Add Zotero logo
- Move most acknowledgements to the website, where they can be more more
easily updated and more comprehensive
- Increase font size
- Center window on screen
 2021-03-29 01:41:37 -04:00
Dan Stillman
5e9636089d Fix primary item types not appearing in More menu when not in MRU list 
Regression in 1c366de54
 2021-03-29 01:41:37 -04:00
Elaborendum
5b17bd0a43
Update connector.json 2021-03-27 21:33:11 -05:00
Dylan
d992edcd17
Fix dark theme on Item Type 2021-03-27 15:50:23 -04:00
Martynas Bagdonas
5e98b9c533 Select library tab when navigating to item from syncRunner popup 2021-03-25 20:56:02 +02:00
Martynas Bagdonas
f6fa81fdac Strip abstract field to save note space, set new itemData on export 2021-03-25 20:56:01 +02:00
Martynas Bagdonas
3536a384a9 Ensure attachment storage dir exists when saving pdf-reader state 2021-03-24 18:51:27 +02:00
Martynas Bagdonas
ec7251fd98 Fix tab toolbar button icon scaling on HiDPI 2021-03-23 18:04:38 +02:00
Martynas Bagdonas
3d204f75e9 Focus pdf-reader on tab selection if not focused contextPane note editor 2021-03-23 18:00:07 +02:00
Dan Stillman
f690c666d4 Don't make 'engine' required in Sync.Storage.Request 
Follow-up to dc12a2c95a
 2021-03-23 03:49:05 -04:00