mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

HTML Tree: Optimize tree invalidation

Browse source
This commit is contained in:
Adomas Venčkauskas 2021-08-26 14:40:59 +03:00
parent bffa64bdda
commit 20e2f33064
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
chrome/content/zotero/components/windowed-list.js
View file

@ -108,8 +108,11 @@ module.exports = class {
invalidate() {
// Removes any items out of view and adds the ones not in view
this.render();
let oldRenderedRows = new Set(this._renderedRows.keys());
// Rerender the rest
for (let index of Array.from(this._renderedRows.keys())) {
// Rerender only old rows, new ones got a fresh render in this.render() call
if (!oldRenderedRows.has(index)) continue;
this.rerenderItem(index);
}
}
@ -125,15 +128,13 @@ module.exports = class {
const [startIndex, stopIndex] = this._getRangeToRender();
if (stopIndex - startIndex > 0) {
for (let index = startIndex; index < stopIndex; index++) {
if (this._renderedRows.has(index)) continue;
let elem = renderItem(index);
elem.style.top = this._getItemPosition(index) + "px";
elem.style.position = "absolute";
innerElem.appendChild(elem);
this._renderedRows.set(index, elem);
}
for (let index = startIndex; index < stopIndex; index++) {
if (this._renderedRows.has(index)) continue;
let elem = renderItem(index);
elem.style.top = this._getItemPosition(index) + "px";
elem.style.position = "absolute";
innerElem.appendChild(elem);
this._renderedRows.set(index, elem);
}
for (let [index, elem] of this._renderedRows.entries()) {
if (index < startIndex || index >= stopIndex) {