mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid setTimeout call on every note-editor context menu popup

Browse source 
Fixes #2111
This commit is contained in:
Martynas Bagdonas 2021-06-24 11:32:43 +03:00
parent 3fc7ce8e7d
commit 88280641ac
1 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
chrome/content/zotero/xpcom/editorInstance.js
View file

@ -661,9 +661,7 @@ class EditorInstance {
}
case 'openContextMenu': {
let { x, y, pos, itemGroups } = message;
// If `contenteditable` area wasn't focused before, the spell checker
// might not be fully initialized on right-click
setTimeout(() => this._openPopup(x, y, pos, itemGroups), 50);
this._openPopup(x, y, pos, itemGroups);
return;
}
case 'return': {
@ -764,7 +762,7 @@ class EditorInstance {
return attachment.key;
}
_openPopup(x, y, pos, itemGroups) {
async _openPopup(x, y, pos, itemGroups) {
let appendItems = (parentNode, itemGroups) => {
for (let itemGroup of itemGroups) {
for (let item of itemGroup) {
@ -811,6 +809,23 @@ class EditorInstance {
// Spell checker
let spellChecker = this._getSpellChecker();
// If `contenteditable` area wasn't focused before, the spell checker
// might not be fully initialized on right-click.
// The wait time depends on system performance/load
let n = 0;
// Wait for 200ms
while (n++ < 20) {
try {
if (spellChecker.mInlineSpellChecker.spellChecker.GetCurrentDictionary()) {
break;
}
}
catch (e) {
break;
}
await Zotero.Promise.delay(10);
}
// Separator
var separator = this._popup.ownerDocument.createElement('menuseparator');
this._popup.appendChild(separator);