mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Don't allow to create/delete notes in contextPane in read-only libraries

Browse source
This commit is contained in:
Martynas Bagdonas 2021-06-29 17:27:27 +03:00
parent ab200cc60b
commit f4e7c8293b
1 changed files with 28 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

40
chrome/content/zotero/contextPane.js
View file

@ -238,7 +238,7 @@ var ZoteroContextPane = new function () {
var reader = Zotero.Reader.getByTabID(Zotero_Tabs.selectedID);
if (reader) {
var editor = _getActiveEditor();
var libraryReadOnly = editor && editor.item && !_isLibraryEditable(editor.item.libraryID);
var libraryReadOnly = editor && editor.item && _isLibraryReadOnly(editor.item.libraryID);
var noteReadOnly = editor && editor.item
&& (editor.item.deleted || editor.item.parentItem && editor.item.parentItem.deleted);
reader.enableAddToNote(!!editor && !libraryReadOnly && !noteReadOnly);
@ -384,6 +384,8 @@ var ZoteroContextPane = new function () {
}
function _addNotesContext(libraryID) {
let readOnly = _isLibraryReadOnly(libraryID);
var list = document.createElement('vbox');
list.setAttribute('flex', 1);
list.className = 'zotero-context-notes-list';
@ -587,9 +589,11 @@ var ZoteroContextPane = new function () {
break;
case 'context-pane-list-move-to-trash':
Zotero.Items.trashTx(id);
context.cachedNotes = context.cachedNotes.filter(x => x.id != id);
_updateNotesList(true);
if (!readOnly) {
Zotero.Items.trashTx(id);
context.cachedNotes = context.cachedNotes.filter(x => x.id != id);
_updateNotesList(true);
}
break;
default:
@ -597,6 +601,9 @@ var ZoteroContextPane = new function () {
}
function _handleAddChildNotePopupClick(event) {
if (readOnly) {
return;
}
switch (event.originalTarget.id) {
case 'context-pane-add-child-note':
_createNote(true);
@ -609,8 +616,11 @@ var ZoteroContextPane = new function () {
default:
}
}
function _handleAddStandaloneNotePopupClick(event) {
if (readOnly) {
return;
}
switch (event.originalTarget.id) {
case 'context-pane-add-standalone-note':
_createNote();
@ -624,6 +634,12 @@ var ZoteroContextPane = new function () {
}
}
document.getElementById('context-pane-add-child-note').setAttribute('disabled', readOnly);
document.getElementById('context-pane-add-child-note-from-annotations').setAttribute('disabled', readOnly);
document.getElementById('context-pane-add-standalone-note').setAttribute('disabled', readOnly);
document.getElementById('context-pane-add-standalone-note-from-annotations').setAttribute('disabled', readOnly);
document.getElementById('context-pane-list-move-to-trash').setAttribute('disabled', readOnly);
ReactDOM.render(
<NotesList
ref={notesListRef}
@ -674,14 +690,14 @@ var ZoteroContextPane = new function () {
_notesContexts = _notesContexts.filter(x => x.libraryID != libraryID);
}
function _isLibraryEditable(libraryID) {
function _isLibraryReadOnly(libraryID) {
var type = Zotero.Libraries.get(libraryID).libraryType;
if (type == 'group') {
var groupID = Zotero.Groups.getGroupIDFromLibraryID(libraryID);
var group = Zotero.Groups.get(groupID);
return group.editable;
return !group.editable;
}
return true;
return false;
}
function _setPinnedNote(itemID) {
@ -689,12 +705,12 @@ var ZoteroContextPane = new function () {
if (!item) {
return;
}
var editable = _isLibraryEditable(item.libraryID);
var readOnly = (item.libraryID);
var context = _getNotesContext(item.libraryID);
if (context) {
var { editor, node } = context;
node.setAttribute('selectedIndex', 1);
editor.mode = editable ? 'edit' : 'view';
editor.mode = readOnly ? 'view' : 'edit';
editor.item = item;
editor.parentItem = null;
editor.hideLinksContainer = true;
@ -734,7 +750,7 @@ var ZoteroContextPane = new function () {
return;
}
var libraryID = item.libraryID;
var editable = _isLibraryEditable(libraryID);
var readOnly = _isLibraryReadOnly(libraryID);
var parentID = item.parentID;
var container = document.createElement('vbox');
@ -773,7 +789,7 @@ var ZoteroContextPane = new function () {
panelInfo.append(itemBox);
container.append(panelInfo);
itemBox.mode = editable ? 'edit' : 'view';
itemBox.mode = readOnly ? 'view' : 'edit';
itemBox.item = parentItem;
}
};