mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix missing menu checkbox issue on pdf-reader and note-editor on Windows

Browse source
This commit is contained in:
Martynas Bagdonas 2021-08-02 11:45:30 +03:00
parent 5bfdeb36ca
commit 7015c8df59
3 changed files with 13 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
chrome/content/zotero/standalone/standalone.xul
View file

@ -237,6 +237,7 @@
<menuitem
id="view-menuitem-hand-tool"
class="menu-type-reader"
type="checkbox"
label="&zotero.pdfReader.handTool;"
oncommand="ZoteroStandalone.onReaderCmd('switchcursortool_hand')"
/>
@ -244,18 +245,21 @@
<menuitem
id="view-menuitem-vertical-scrolling"
class="menu-type-reader"
type="checkbox"
label="&zotero.pdfReader.verticalScrolling;"
oncommand="ZoteroStandalone.onReaderCmd('switchscrollmode_vertical')"
/>
<menuitem
id="view-menuitem-horizontal-scrolling"
class="menu-type-reader"
type="checkbox"
label="&zotero.pdfReader.horizontalScrolling;"
oncommand="ZoteroStandalone.onReaderCmd('switchscrollmode_horizontal')"
/>
<menuitem
id="view-menuitem-wrapped-scrolling"
class="menu-type-reader"
type="checkbox"
label="&zotero.pdfReader.wrappedScrolling;"
oncommand="ZoteroStandalone.onReaderCmd('switchscrollmode_wrapped')"
/>
@ -263,18 +267,21 @@
<menuitem
id="view-menuitem-no-spreads"
class="menu-type-reader"
type="checkbox"
label="&zotero.pdfReader.noSpreads;"
oncommand="ZoteroStandalone.onReaderCmd('switchspreadmode_none')"
/>
<menuitem
id="view-menuitem-odd-spreads"
class="menu-type-reader"
type="checkbox"
label="&zotero.pdfReader.oddSpreads;"
oncommand="ZoteroStandalone.onReaderCmd('switchspreadmode_odd')"
/>
<menuitem
id="view-menuitem-even-spreads"
class="menu-type-reader"
type="checkbox"
label="&zotero.pdfReader.evenSpreads;"
oncommand="ZoteroStandalone.onReaderCmd('switchspreadmode_even')"
/>

4
chrome/content/zotero/xpcom/editorInstance.js
View file

@ -847,6 +847,9 @@ class EditorInstance {
menuitem.setAttribute('value', item.name);
menuitem.setAttribute('label', item.label);
menuitem.setAttribute('disabled', !item.enabled);
if (item.checked) {
menuitem.setAttribute('type', 'checkbox');
}
menuitem.setAttribute('checked', item.checked);
menuitem.addEventListener('command', () => {
this._postMessage({
@ -901,6 +904,7 @@ class EditorInstance {
var menuitem = this._popup.ownerDocument.createElement('menuitem');
menuitem.setAttribute('label', Zotero.getString('spellCheck.checkSpelling'));
menuitem.setAttribute('checked', spellChecker.enabled);
menuitem.setAttribute('type', 'checkbox');
menuitem.addEventListener('command', () => {
// Possible values: 0 - off, 1 - only multi-line, 2 - multi and single line input boxes
Zotero.Prefs.set('layout.spellcheckDefault', spellChecker.enabled ? 0 : 1, true);

2
chrome/content/zotero/xpcom/reader.js
View file

@ -332,6 +332,7 @@ class ReaderInstance {
// Zoom 'Auto'
menuitem = this._window.document.createElement('menuitem');
menuitem.setAttribute('label', Zotero.getString('pdfReader.zoomAuto'));
menuitem.setAttribute('type', 'checkbox');
menuitem.setAttribute('checked', data.isZoomAuto);
menuitem.addEventListener('command', () => {
this._postMessage({ action: 'popupCmd', cmd: 'zoomAuto' });
@ -340,6 +341,7 @@ class ReaderInstance {
// Zoom 'Page Width'
menuitem = this._window.document.createElement('menuitem');
menuitem.setAttribute('label', Zotero.getString('pdfReader.zoomPageWidth'));
menuitem.setAttribute('type', 'checkbox');
menuitem.setAttribute('checked', data.isZoomPageWidth);
menuitem.addEventListener('command', () => {
this._postMessage({ action: 'popupCmd', cmd: 'zoomPageWidth' });