mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fx-compat: Fix Add to Collection menu

Browse source 
Document.createXULElement is handy.
This commit is contained in:
Abe Jellinek 2022-05-16 13:18:16 -07:00
parent 9e93007355
commit 60606a8528
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
chrome/content/zotero/xpcom/utilities_internal.js
View file

@ -1705,10 +1705,11 @@ Zotero.Utilities.Internal = {
createMenuForTarget: function(libraryOrCollection, elem, currentTarget, clickAction, disabledPred) {
var doc = elem.ownerDocument;
function _createMenuitem(label, value, icon, command, disabled) {
let menuitem = doc.createElement('menuitem');
let menuitem = doc.createXULElement('menuitem');
menuitem.setAttribute("label", label);
menuitem.setAttribute("type", "checkbox");
if (value == currentTarget) {
// type="checkbox" hides icon, so only set if checked
menuitem.setAttribute("type", "checkbox");
menuitem.setAttribute("checked", "true");
}
menuitem.setAttribute("value", value);
@ -1720,7 +1721,7 @@ Zotero.Utilities.Internal = {
}
function _createMenu(label, value, icon, command) {
let menu = doc.createElement('menu');
let menu = doc.createXULElement('menu');
menu.setAttribute("label", label);
menu.setAttribute("value", value);
menu.setAttribute("image", icon);
@ -1731,7 +1732,7 @@ Zotero.Utilities.Internal = {
}
});
menu.classList.add('menu-iconic');
let menupopup = doc.createElement('menupopup');
let menupopup = doc.createXULElement('menupopup');
menu.appendChild(menupopup);
return menu;
}
@ -1774,7 +1775,7 @@ Zotero.Utilities.Internal = {
);
var menupopup = menu.firstChild;
menupopup.appendChild(menuitem);
menupopup.appendChild(doc.createElement('menuseparator'));
menupopup.appendChild(doc.createXULElement('menuseparator'));
for (let collection of collections) {
let collectionMenu = this.createMenuForTarget(
collection, elem, currentTarget, clickAction, disabledPred