mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Implement custom keyboard navigation (#2317)

Browse source
This commit is contained in:
Martynas Bagdonas 2022-02-23 20:00:57 +02:00 committed by GitHub
parent 1743360de7
commit 003b3db281
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
chrome/content/zotero/xpcom/reader.js
View file

@ -365,7 +365,7 @@ class ReaderInstance {
return `data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><rect shape-rendering="geometricPrecision" fill="${fill}" stroke-width="2" x="2" y="2" stroke="${stroke}" width="12" height="12" rx="3"/></svg>`;
}
_openTagsPopup(x, y, item) {
_openTagsPopup(item, selector) {
let menupopup = this._window.document.createElement('menupopup');
menupopup.className = 'tags-popup';
menupopup.style.minWidth = '300px';
@ -374,7 +374,8 @@ class ReaderInstance {
menupopup.appendChild(tagsbox);
tagsbox.setAttribute('flex', '1');
this._popupset.appendChild(menupopup);
menupopup.openPopupAtScreen(x, y, false);
let element = this._iframeWindow.document.querySelector(selector);
menupopup.openPopup(element, 'overlap', 0, 0, true);
tagsbox.mode = 'edit';
tagsbox.item = item;
if (tagsbox.mode == 'edit' && tagsbox.count == 0) {
@ -537,7 +538,14 @@ class ReaderInstance {
});
});
popup.appendChild(menuitem);
popup.openPopupAtScreen(data.x, data.y, true);
if (data.x) {
popup.openPopupAtScreen(data.x, data.y, true);
}
else if (data.selector) {
let element = this._iframeWindow.document.querySelector(data.selector);
popup.openPopup(element, 'after_start', 0, 0, true);
}
}
_openColorPopup(data) {
@ -662,12 +670,12 @@ class ReaderInstance {
return;
}
case 'openTagsPopup': {
let { id: key, x, y } = message;
let { id: key, selector } = message;
let attachment = Zotero.Items.get(this._itemID);
let libraryID = attachment.libraryID;
let annotation = Zotero.Items.getByLibraryAndKey(libraryID, key);
if (annotation) {
this._openTagsPopup(x, y, annotation);
this._openTagsPopup(annotation, selector);
}
return;
}

2
pdf-reader

@ -1 +1 @@
Subproject commit 13aa2cf7f1e23f631d4dd173207741abd44b6510
Subproject commit 826cce2fa0c754b9de456aa2d52f9bfc95dfd3ba