mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fix item pane opening creator-type-menu in a wrong itembox binding

Browse source
This commit is contained in:
Martynas Bagdonas 2021-10-19 16:56:40 +03:00
parent 5f61ac23aa
commit 6206209ed2
1 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
chrome/content/zotero/bindings/itembox.xml
View file

@ -749,7 +749,10 @@
var typeBox = document.createElement("hbox");
typeBox.setAttribute("typeid", typeID);
typeBox.setAttribute("popup", "creator-type-menu");
typeBox.onclick = () => {
document.popupNode = typeBox;
this._id("creator-type-menu").openPopup(typeBox);
}
typeBox.setAttribute("fieldname", 'creator-' + this._creatorCount + '-typeID');
if (this.editable) {
typeBox.className = 'creator-type-label zotero-clicky';
@ -2570,10 +2573,10 @@
var hideMoveDown = !exists || !moreCreators;
var hideMoveSep = hideMoveUp && hideMoveDown;
document.getElementById('zotero-creator-move-sep').setAttribute('hidden', hideMoveSep);
document.getElementById('zotero-creator-move-to-top').setAttribute('hidden', hideMoveToTop);
document.getElementById('zotero-creator-move-up').setAttribute('hidden', hideMoveUp);
document.getElementById('zotero-creator-move-down').setAttribute('hidden', hideMoveDown);"
document.getBindingParent(this)._id('zotero-creator-move-sep').setAttribute('hidden', hideMoveSep);
document.getBindingParent(this)._id('zotero-creator-move-to-top').setAttribute('hidden', hideMoveToTop);
document.getBindingParent(this)._id('zotero-creator-move-up').setAttribute('hidden', hideMoveUp);
document.getBindingParent(this)._id('zotero-creator-move-down').setAttribute('hidden', hideMoveDown);"
oncommand="return async function () {
var typeBox = document.popupNode.localName == 'hbox' ? document.popupNode : document.popupNode.parentNode;
var index = parseInt(typeBox.getAttribute('fieldname').split('-')[1]);