mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
12412 commits 9 branches 364 tags 290 MiB
Commit graph

9879 commits

Author SHA1 Message Date
Dan Stillman
dd2ff63019 fx-compat: Replace nsIDOMParser with new DOMParser() 2022-05-12 02:38:59 -04:00
Dan Stillman
993320655e fx-compat: Throw error if generator is passed to DB.executeTransaction() 2022-05-12 02:38:59 -04:00
Dan Stillman
03242e8984 fx-compat: DB.executeTransaction() no longer takes generator functions 2022-05-12 02:38:59 -04:00
Dan Stillman
ccbc785499 fx-compat: XPCOMUtils.generateQI() → ChromeUtils.generateQI() 2022-05-12 02:38:59 -04:00
Adomas Venčkauskas
4d35cdf095 Remove unneeded constant in virtualized table 2022-05-10 17:03:34 +03:00
Adomas Venčkauskas
eb6b14a218 Fix item tree column resizing issues 
Report https://forums.zotero.org/discussion/97077/problem-with-column-width-adjustment
 2022-05-10 17:02:36 +03:00
Adomas Venčkauskas
a406e62fd3 Item Tree: Fix column dividers not aligned for second-level items 
Closes #2605
 2022-05-10 13:52:32 +03:00
Adomas Venčkauskas
aa483f579f HTML tree: Find-as-you-type remains on matching string. 
Closes #2607
 2022-05-10 13:35:31 +03:00
Dan Stillman
273fc6c657 Update locales from Transifex 2022-05-09 10:05:55 -04:00
Abe Jellinek
db5b535ea6 Update translate submodule 2022-05-07 20:34:37 -07:00
Adomas Ven
c49a05d486
Improve column resizing robustness (#2588) 
Also:

* Add staticWidth and minWidth column properties
 2022-05-03 03:00:23 -04:00
Martynas Bagdonas
01645c5e51
Pin library tab (#2589) 
Fixes #2575
 2022-05-03 01:21:59 -04:00
Abe Jellinek
097308c5c6 Update utilities submodule 2022-05-02 17:12:39 -07:00
Dan Stillman
b6fdeeca13 Fix deadlock in integrity check before DB schema upgrade 
One of the repair steps uses a transaction, which is reasonable, so
don't run integrity check within transaction at startup.
 2022-05-01 02:14:45 -04:00
Dan Stillman
d201fdc119 Fix target is undefined error during upgrade from Zotero 4 
https://forums.zotero.org/discussion/96811/database-upgrade-error-when-migrating-from-version-4-0-to-6-0-directly-skipping-zotero-5

Regression from 078e3bb07, probably
 2022-05-01 02:14:36 -04:00
Dan Stillman
5e0674b842 Add logging for PDF exports 2022-04-30 05:17:41 -04:00
Abe Jellinek
9829ea7009
Update utilities, move tests, add to CI (#2584) 2022-04-30 04:55:11 -04:00
Dan Stillman
fd859bd976 Update locales from Transifex and merge new English strings 2022-04-29 18:28:52 -04:00
Dan Stillman
b536432866 Fix mistake in tab-unavailable integration message 2022-04-29 16:54:16 -04:00
Dan Stillman
644cce219a Tweak tab-unavailable integration message 2022-04-29 16:51:41 -04:00
Adomas Venčkauskas
ff920de130 Fix integration transaction getting stuck when google docs tab is closed 
Closes #2583
 2022-04-29 15:19:20 +03:00
Adomas Venčkauskas
fca16d2ad5 Fix find-as-you-type not matching beyond first letter 
Closes #2581
 2022-04-29 15:19:20 +03:00
Martynas Bagdonas
70c9bef320 Switch tabs with Cmd-Option-←/→ 
Fixes #2475
 2022-04-29 12:56:04 +03:00
Abe Jellinek
3bfc6740c4
Add tests for improved compareCallNumbers (#2579) 2022-04-28 04:43:30 -04:00
Abe Jellinek
5196ba379b
Update typeSchemaData and builder script (#2576) 2022-04-28 02:12:29 -04:00
Martynas Bagdonas
fe14ee79a3 Show a few missing options in Tools menu when PDF reader tab is open 
Fixes #2502
 2022-04-27 18:20:41 +03:00
Martynas Bagdonas
41bdd36068 Add an option to disable smart quotes 
Fixes #2524
 2022-04-27 10:23:10 +03:00
Dan Stillman
a4cdaf0407 Show "Add Note from Annotations" in attachment context menu 2022-04-27 02:34:42 -04:00
Dan Stillman
c405fa76a1 Add sortNotesChronologically.reader pref for PDF reader notes list 
And default to true. I forgot we were sorting reverse chronologically by
default in order to make it easy to open recent notes.

Follow-up to https://github.com/zotero/zotero/issues/2526 for
https://forums.zotero.org/discussion/96743/pdf-reader-two-feature-requests
 2022-04-26 17:59:45 -04:00
Dan Stillman
40501c3953 Update locales from Transifex and merge new English strings 2022-04-26 17:22:39 -04:00
Martynas Bagdonas
10c8fc4c74 Implement tab duplication 
Fixes #2566
 2022-04-26 19:41:51 +03:00
Abe Jellinek
89aaa10504
Sort LC call numbers better, sort integers as integers (#2569) 
* Update utilities submodule after https://github.com/zotero/utilities/pull/8
* Extract and add tests
 2022-04-26 04:11:29 -04:00
Martynas Bagdonas
7a06671ecb Fix undefined variable issue in annotation templates 2022-04-26 08:29:42 +02:00
Adomas Venčkauskas
d96ebad82a Allow adding multiple sources at once in classic citation dialog. 
Closes #2568
 2022-04-25 13:28:00 +03:00
Adomas Venčkauskas
1be2d69f1e Log integration invocations before other integration actions 2022-04-25 12:43:48 +03:00
Martynas Bagdonas
b8d427790c Fix error when using a note template and checking if array is not empty 2022-04-23 14:52:24 +07:00
Adomas Venčkauskas
d9463daa66 HTML Tree: Search by typing loops instead of starting from beginning 
Closes #2559
 2022-04-22 10:58:25 +03:00
Martynas Bagdonas
c1fde1d3d9 Improve tab title visibility and adjust scroll arrow scroll step 
Fixes #2554
Fixes #2553
 2022-04-22 13:07:18 +07:00
Dan Stillman
114b48d5b8 Update locales from Transifex 2022-04-21 15:46:50 -04:00
Dan Stillman
031ff1824b Fix middle click to close tabs (#1993) 2022-04-21 12:23:14 -04:00
Martynas Bagdonas
a8cb9bfddd Restore custom note styling 
Fixes #2560
 2022-04-21 13:17:04 +07:00
Abe Jellinek
f91ca9c18a Don't merge with a deleted master attachment 2022-04-20 11:04:24 -07:00
Martynas Bagdonas
142e3b09f8
Unload tabs (#2500) 
- Keep all tabs unloaded on Zotero opening.
- Keep loaded only the last five selected tabs.
- Keep loaded only in the last 24h selected tabs.

Fixes #2383
 2022-04-20 03:14:50 -04:00
Dan Stillman
578986ab1e Fix item types not appearing in New Item submenu 
https://forums.zotero.org/discussion/96530/a-issue-about-new-item-drop-down-menu

After a type from the submenu was selected and added to the MRU, the
submenu wouldn't be updated. Not sure how long this has been going on.

Fixes #2534
 2022-04-19 23:04:18 -04:00
Martynas Bagdonas
5d442b706e
Make tab bar scrollable (#2506) 
Fixes #2232
 2022-04-19 18:51:32 -04:00
Adomas Ven
7b0d6951d2
Update csl validator for CSL 1.0.2 (#2493) 2022-04-19 18:42:48 -04:00
Dan Stillman
3f10e4c064 Bad JSON in sync cache shouldn't break syncing 
https://forums.zotero.org/discussion/95926/zotero-not-syncing-report-id-1924846177
 2022-04-19 17:49:13 -04:00
Martynas Bagdonas
5c8ea0174a Fix empty table row height in generated report, prevent table overflow 
Fixes #2545
 2022-04-15 21:59:27 +07:00
Adomas Venčkauskas
5ca8486047 Adjust conditional clause for Windows from 76276a3 2022-04-15 11:21:07 +03:00
Adomas Venčkauskas
76276a39ce HTML Tree: adjust row padding per OS 2022-04-15 11:15:40 +03:00
Abe Jellinek
e8ad2fab95
getSortTitle: Only strip initial punctuation clusters (#2537) 
Specifically exclude @, #, and *
 2022-04-15 02:08:14 -04:00
Dan Stillman
c9b39675ba Update locales from Transifex and merge new English strings 2022-04-14 18:06:32 -04:00
Dan Stillman
498e38730b Update translate submodule 2022-04-14 18:06:32 -04:00
Abe Jellinek
d842e7a9bc Fix save() without transaction when saving search 2022-04-14 14:39:34 -07:00
Martynas Bagdonas
f494ab5114
Allow creating and editing tables in note-editor (#2511) 
Fixes #2480
 2022-04-14 17:17:32 -04:00
Adomas Venčkauskas
01506b27e9 Allow moving cursor by clicking on collection name while editing 
Closes #2513
 2022-04-14 17:03:54 +03:00
Adomas Venčkauskas
599c6821b7 Ensure columns don't resize when switching tabs 2022-04-14 16:51:13 +03:00
Abe Jellinek
1538a836b9
Show label of translator that causes import error (#2539) 2022-04-14 07:01:43 -04:00
Dan Stillman
08d3880d88 Don't remove relations in annotation item JSON 
This was causing UUIDs for annotations from Mendeley imports to be
removed after a sync, resulting in annotations being duplicated on a
reimport.
 2022-04-14 06:37:30 -04:00
Abe Jellinek
3792c89fbd Allow >4 numbers after the decimal point in Dewey 
https://github.com/zotero/zotero/pull/2538#issuecomment-1097292396
 2022-04-12 15:45:50 -07:00
Abe Jellinek
ce39185fa7
Sort call numbers alphabetically, handle Dewey specially (#2538) 2022-04-12 17:40:25 -04:00
Dan Stillman
a72deb4648 Update locales from Transifex and merge new English strings 2022-04-12 02:57:07 -04:00
Abe Jellinek
e03c1603ca Fix "%S" in displayed startup error message 2022-04-11 19:03:29 -07:00
Abe Jellinek
38f5551ee5
Add "Open PDF in New Window" to context menu (#2490) 
Also:

* Remove Locate tooltips
 2022-04-11 17:53:40 -04:00
Abe Jellinek
a5fc8b859c Context Pane: Use getNoteTitle() 
ad36c9fb2a (r71022779)
 2022-04-11 13:36:03 -07:00
Abe Jellinek
b8b1f8be55
Disable Import actions in uneditable libraries (#2471) 2022-04-11 16:12:43 -04:00
Abe Jellinek
ad36c9fb2a Context Pane: Sort notes in item tree order 
Fixes #2526.
 2022-04-11 10:13:50 -07:00
Abe Jellinek
892c1169c8 Attachment merge: Compare link mode type 
Actually fixes #2527.
 2022-04-11 09:30:16 -07:00
Adomas Venčkauskas
237bd8f0ce Fix Restore Column Order in Item Tree not always working 
Closes #2521
 2022-04-11 13:55:30 +03:00
Adomas Ven
4c445554a3
Item Tree: Attempt to fix OS font scaling (#2488) 2022-04-11 05:16:59 -04:00
Martynas Bagdonas
2af7275968 Fix template condition evaluating to true for empty string from function 
Fixes #2529
 2022-04-11 12:22:20 +07:00
Abe Jellinek
be0b0a7151
Always autocomplete creators in hideEditor (#2516) 2022-04-11 00:21:14 -04:00
Abe Jellinek
47a2f3cad9 Attachment merge: Compare linkModes, improve logging 
Using keys instead of IDs should make logs more useful.
Fixes #2527.
 2022-04-09 20:39:37 -07:00
Dan Stillman
0df8b7670d Fix broken tag selector with colored tags that differ with normalization 
https://forums.zotero.org/discussion/96138/lost-content-in-tag-selector

An entered character from the CJK_COMPATIBILITY_IDEOGRAPHS block (char
code 63834, or similar) was normalized to the CJK_UNIFIED_IDEOGRAPHS
block (char code 35712), which then caused an expected key not to exist.

To fix, normalize colored tag values coming from the DB.
 2022-04-09 06:24:17 -04:00
Martynas Bagdonas
2112aa7271 Don't jump back to library tab when PDF recognition finishes 2022-04-08 15:31:28 +07:00
Adomas Venčkauskas
b850d16c89 Fix integration error handling code when citeproc-rs disabled. 
Closes #2508
 2022-04-08 10:41:35 +03:00
Martynas Bagdonas
bdbde99fa7 Remove alpha channel from highlight color when inserting a note 
Fixes #2499
 2022-04-08 13:00:33 +07:00
Abe Jellinek
dea9fc5e88 Scaffold: setInterval -> activate listener 2022-04-07 19:50:13 -07:00
Abe Jellinek
a40ab83b71
Fix double separator in Edit menu on Win/Linux (#2507) 2022-04-06 23:42:13 -04:00
Abe Jellinek
fbaa1c6e61 Fix huge Scaffold toolbar icons on Win/Linux 2022-04-05 14:50:05 -07:00
Adomas Venčkauskas
c510d91461 Fix an error that causes test failures (regression 9a5657b) 2022-04-05 10:08:10 +03:00
Adomas Venčkauskas
5b9ac2ca53 Fix a non-terminal startup error introduced in d7b1a53 2022-04-05 10:08:10 +03:00
Dan Stillman
28ec72666f Update locales from Transifex and merge new English strings 2022-04-04 14:02:08 -04:00
Adomas Venčkauskas
9a5657bf79 Item Tree: Fix fixed-width columns sometimes changing width 2022-04-04 16:06:51 +03:00
Martynas Bagdonas
f877476c1a Partially disable buggy ff <64 table resizing handles in note-editor 
Unfortunately the first opened note will still have the handles.
 2022-04-01 17:09:08 +07:00
Martynas Bagdonas
3f4030ff80 Allow copying image annotations to external text fields 
Fixes #2447
 2022-04-01 17:09:08 +07:00
Abe Jellinek
a5b3d6440b
Fix next duplicates set selection after merge (#2448) 2022-03-31 17:46:30 -07:00
Martynas Bagdonas
3356557493 Add 'Zoom to Page Height' PDF reader option 
Fixes #2255
 2022-03-31 15:52:00 +07:00
Martynas Bagdonas
8e54f1649b Add annotation to note at cursor position 
Fixes #2487
 2022-03-31 12:14:11 +07:00
Abe Jellinek
e922ae711a Fix ProgressQueue titles for cases, letters, etc. 
Handles items with an alternate field that maps to title (like cases)
and items for which the title is usually filled in by updateDisplayTitle()
(like letters).
 2022-03-30 16:30:07 -07:00
Abe Jellinek
2a1ce292d2 Remove Note Font Size -> Reset restart prompt 
+ replace empty menuitem with a divider as in the Font Size menu.
 2022-03-30 14:55:48 -07:00
Abe Jellinek
27c9086222 Scaffold: Show "defer" value in test list 2022-03-30 14:49:42 -07:00
Abe Jellinek
745069c070 Don't strip punctuation before numbers 
Fixes #2496
 2022-03-30 11:58:55 -07:00
Dan Stillman
f2209974b2 Don't show "Export PDF" in reader 
Save As already exists
 2022-03-30 14:13:24 -04:00
Dan Stillman
e0097df068
Remove "Store Annotations in File" option (#2498) 
This is a confusing, bad option, which was already disabled in groups,
and this removes it from personal libraries as well. People seem to be
using it mainly because they think annotations are locked into Zotero if
they don't, which is causing them to ask for this to be done
automatically on every edit, which we don't do because it would result
in constant file syncing and file conflicts [1].

We provide multiple export options for exporting PDFs with annotations,
and people can use those when sharing a file with people who don't use
Zotero. Otherwise, if storing annotations in the file is a priority,
they can use an external reader that's not designed to be tightly
integrated into Zotero.

(As a rare hack, it's of course also possible to export the PDF with
annotations, replace the original file, and import the annotations.)

[1] https://www.zotero.org/support/kb/annotations_in_database
 2022-03-30 13:58:59 -04:00
Tom Najdek
56321a7a6d
Fix regression: download() fails for non-http URLs (#2497) 
This fixes compatiblity with some addons that use Zotero.File.download
to extract files from their XPI bundle.
 2022-03-30 12:15:40 -04:00
Tom Najdek
776769f480
Citavi import: Tweak how page label is determined (#2494) 
Instead of attempting to extract `PageRange` value we now let pdf worker
always determine page label.

Also improved citavi tests and fixtures.
 2022-03-30 09:34:07 -04:00
Abe Jellinek
a9d7a08a05 Fix merge interface doubling rows in master selector 
Master choices would occasionally be doubled in the listbox. Clearing
the innerHTML instead of using removeItemAt() fixes the issue.
 2022-03-28 13:24:59 -07:00
Adomas Venčkauskas
d7b1a53248 HTML Tree: Improve item tree column header alignment. 
Addresses #2153
 2022-03-28 13:32:17 +03:00
Dan Stillman
17d9f06b65 Update more try-wrapped calls to getString 2022-03-27 02:37:49 -04:00
Abe Jellinek
470d9cd7c2 Update more try-wrapped calls to getString 2022-03-25 16:49:52 -07:00
Abe Jellinek
82228a1072 Search: Use item field localization if string == key 
91faa73b19 made getString return the key
instead of throwing on non-en-US locales, so we check if the getString
result is equal to the key even if it doesn't throw.

Fixes #2472.
 2022-03-25 16:35:01 -07:00
Abe Jellinek
a3322a9afb
Merge pull request #2397 from AbeJellinek/scaffold-sanitize-for-display 2022-03-25 11:59:05 -07:00
Martynas Bagdonas
4dcb3e7a53 Fix deletion confirmation and copying in standalone PDF reader window 
Fixes #2462
 2022-03-25 15:53:49 +02:00
Martynas Bagdonas
2f5974e1ab Reduce probability of annotation comment/text being cleared while typing 
Fixes #2361
 2022-03-24 13:40:43 +02:00
Dan Stillman
91faa73b19 Don't throw from getString() for missing strings in non-English locales 
Just show the key

We still merge strings before pushing betas, but this means it won't
crash for source builds, or if we forget. Not sure why we didn't do this
15 years ago.
 2022-03-24 07:06:53 -04:00
Dan Stillman
1d1adbca70 Fix error merging items with missing attachment files 
Fixes #2453
 2022-03-24 06:39:47 -04:00
Dan Stillman
9d91e0d4f7 Update locales from Transifex and merge new English strings 2022-03-24 06:18:17 -04:00
Adomas Venčkauskas
f7e49630c8 Fix some more column picker brokenness 2022-03-24 11:00:16 +02:00
Adomas Venčkauskas
c87b40e5ca Fix secondary sort submenu breakage in 8e31bf5b 2022-03-24 10:33:58 +02:00
Adomas Venčkauskas
8e31bf5b6d Possible fix for missing More Columns submenu. Addresses #2443 2022-03-24 10:28:37 +02:00
Martynas Bagdonas
62f07a7356 Upgrade note-editor schema to v8: 
- Allow highlight and citation nodes in headers

Fixes #2467
Related #2390
 2022-03-24 10:21:04 +02:00
Adomas Venčkauskas
229f42bed2 HTML Tree: Change Cu.reportError() to Zotero.logError() 2022-03-23 13:28:46 +02:00
Martynas Bagdonas
23a4a14b44 Upgrade note-editor schema to v7: 
- Allow ul/ol nodes to have `dir` attribute
 2022-03-23 12:35:08 +02:00
Adomas Venčkauskas
c083c69be1 Fix note insertion dialog not appearing when classic mode is enabled. 
Closes #2463
 2022-03-23 11:58:06 +02:00
Adomas Venčkauskas
1b124bff2d Actually fix quick format color issues. See cc5e110 2022-03-23 11:28:50 +02:00
Adomas Venčkauskas
0f2273ea43 Link to manual word plugin installation instructions on install failure. 
Closes #2444
 2022-03-23 11:12:42 +02:00
Dan Stillman
fcb16f628b Fix "path.startsWith is not a function" sync error on Windows 
`OS.Path.join()` on Windows throws if an integer is passed. Seems like
this would happen on another computer whenever an image annotation is
deleted in a group?
 2022-03-23 00:01:00 -04:00
Dan Stillman
37c48dc3ee Remove Zotero.Items.moveChildItems() transaction requirement exception 
Follow-up to 734057ff9b

This was supposed to allow ZotFile to continue to work but 1) it
contained a bug and 2) another transaction messed things up for ZotFile
anyway, so we'll just fix this in jlegewie/zotfile#593.
 2022-03-22 18:07:40 -04:00
Abe Jellinek
95d8b37f0a Potentially fix ProgressWindow crash 
The call to _window.addEventListener() might have been causing an error
when _window was null or undefined (no main Zotero window could be
found), which would prevent _windowLoading from being set to true and
the window from being added to the ProgressWindowSet, which might have
caused unpredictable behavior when positioning windows later on.

I could only briefly reproduce the issue, so this is just one idea. The
call to addEventListener on a potentially null _window was definitely a
bug but I don't know if it caused the crash.
 2022-03-22 12:55:47 -07:00
Adomas Venčkauskas
cc5e1106ec Fix quick format issues in Linux dark themes. Closes #2441 2022-03-22 14:32:15 +02:00
Adomas Venčkauskas
227b6354de Item Tree: Reset scrollbar to top on collection change 2022-03-22 13:58:02 +02:00
Adomas Venčkauskas
25230b0fca HTML Tree: Fix focused row losing focus sometimes not being redrawn 2022-03-22 13:58:02 +02:00
Dan Stillman
5df1017689 Correction to Scite access date fix in dc886d3cec 2022-03-22 06:01:30 -04:00
Dan Stillman
dc886d3cec Remove access dates broken by Scite 
A non-date value ('INVALID_SCITE_VALUE') apparently gets output as
`false` in toJSON(), which results in a sync error.
 2022-03-22 05:53:24 -04:00
Dan Stillman
d14a8b1d92 Put Scite cleanup code in a try/catch 
Just to be safe
 2022-03-22 05:01:50 -04:00
Dan Stillman
f8e9aa147b Add temporary code to fix invalid values from Scite at startup 
https://github.com/scitedotai/scite-zotero-plugin/issues/38
 2022-03-22 05:00:28 -04:00
Dan Stillman
f95bf41d13 Revert "Fix "cleanDOI: argument must be a string" startup error" 
This reverts commit 8763190328.

This is caused by the Scite plugin, and it's better to block startup
until this is fixed, since it's wrecking other fields too.
 2022-03-21 23:49:33 -04:00
Dan Stillman
174f1aadde Fix error adding group item before syncing in Zotero 6 
Fixes #2440
 2022-03-21 22:50:43 -04:00
Dan Stillman
8763190328 Fix "cleanDOI: argument must be a string" startup error 
Due to 0 integer value for DOI from somewhere (a plugin?)

https://forums.zotero.org/discussion/comment/402388/#Comment_402388
https://forums.zotero.org/discussion/comment/402391/#Comment_402391
 2022-03-21 22:02:54 -04:00
Abe Jellinek
bca76319ce
getSortTitle: Strip less punctuation, trim (#2442) 
Now it:

1. Strips punctuation at the beginning, no matter what it is.
2. Strips non-dash punctuation in other positions.
3. Trims the result.

This should better prevent numerical ranges from being joined into a
single number that ends up incorrectly being sorted to the very bottom.
 2022-03-21 20:06:27 -04:00
Martynas Bagdonas
388d18d017 Terminate PDF worker after processing PDFs queue 
Fixes #2421
 2022-03-17 14:26:07 +02:00
Martynas Bagdonas
edf0c31bdb Remove old note editor binding 2022-03-17 11:18:17 +02:00
Dan Stillman
121f3f3037 Update locales from Transifex 2022-03-16 20:45:18 -04:00
Abe Jellinek
b1d11bf7dc Really fix lastSync log spam 
6b6c27029b didn't do the trick because
library.lastSync can be false and the ?. operator doesn't catch that.
 2022-03-15 10:43:17 -07:00
Abe Jellinek
8a235c07f1 Fix et al. regex for sorting by creator 
\. -> \\. and apply the same escaping to general.and.
 2022-03-15 10:05:09 -07:00
Martynas Bagdonas
26e4de500e Fix overflowing itemPane and hidden contextPane for new profiles, in stacked view 
Fixes #2305
 2022-03-15 18:27:18 +02:00
Martynas Bagdonas
982b41359b Fix oversized tagBox icons in standalone PDF reader window 
Fixes #2143
 2022-03-15 18:27:18 +02:00
Martynas Bagdonas
d02eb145d5 Fix copying over PDF reader context pane 
Fixes #2408
 2022-03-15 18:27:18 +02:00
Dan Stillman
1f2f91d2d2 Update locales from Transifex 2022-03-15 07:43:11 -04:00
Martynas Bagdonas
d4339f20bd Don't try to modify non-editable annotation item when saving image 2022-03-15 11:04:02 +02:00
Martynas Bagdonas
769bfbc892 Fix PDF reader up/down keyboard navigation regression in RTL mode 2022-03-15 09:53:11 +02:00
Martynas Bagdonas
59caaf56ea Fix PDF reader keyboard navigation in RTL mode 2022-03-14 17:25:28 +02:00
Adomas Venčkauskas
12cd201b48 HTML Tree: Multi-selection fixes 
- Clarification between focused row and pivot:
  - Pivot is only the row from which shift-selection pivots
  - Focused row is the one with the border around it
- Fixed an issue where clicking the focused row didn't select it.
  Closes #2402
- Allows to create a non-contiguous range-selection with ctrl/cmd+shift.
  Closes #2403
 2022-03-14 14:57:59 +02:00
Dan Stillman
3ec883a7f6 Get attachment text on-demand if not cached in Item::attachmentText 
Follow-up to 58f515058 with a better approach: if no full-text cache
file, just get text directly without indexing. In the one existing use
of `attachmentText`, attachment merging, this is better anyway, because
we might be deleting the file, so there's no point wasting time
inserting words into the database.
 2022-03-12 20:22:29 -05:00
Dan Stillman
58f5150583 Don't automatically index full-text content in Item::attachmentText 
Indexing starts a transaction, which will cause `.attachmentText` to
hang if accessed within another transaction. If a caller wants to make
sure it has attachment text, it should index items first outside a
transaction.
 2022-03-12 19:11:02 -05:00
Dan Stillman
6aa401bceb Don't show annotation-only tags in tag selector 2022-03-12 03:00:40 -05:00
Martynas Bagdonas
c7972b3d38
Improve keyboard navigation in PDF reader tab (#2395) 2022-03-12 02:22:13 -05:00
Abe Jellinek
6b6c27029b
Fix log spam when library hasn't been synced (#2409) 
This happens a lot during tests - library.lastSync is null, so
showAutoSyncReminder() throws. It doesn't fail tests but it does spam
the log.
 2022-03-11 20:19:02 -05:00
Abe Jellinek
80bb40b153 Fix error when menus haven't been created 2022-03-11 14:02:07 -08:00
Abe Jellinek
52bc93adc9 Always select new items, disable File -> New Item appropriately 
Fixes #2405. This also fixes an issue where Cmd/Ctrl-Shift-N in a
collection like Duplicate Items would open the item type menu on top of
a blank white item pane (since the new item didn't get selected first).
 2022-03-11 13:42:15 -08:00
Abe Jellinek
c9ccd758bc Fix undefined error when new collection title is empty 2022-03-11 13:08:33 -08:00
Martynas Bagdonas
78e1e8593a Fix note template condition evaluating to true on empty array 
Fixes #2386
 2022-03-11 17:04:47 +02:00
Abe Jellinek
ef82becf00
Merge attachments and update notes (#2336) 
We follow a different merge procedure for each attachment type:

- For PDF attachments, compare by MD5. If no match, get the top 50 words
  in the attachment's text and hash those, then check again for a match.
  Update references to item keys in notes and annotations.
- For web (snapshot / link) attachments, compare by title and URL.
  Prefer a title + URL match but accept a title-only match.
- For other attachment types, keep all attachments from all items being
  merged.

Also:

- Move most merge tests from Duplicates to Items#merge(). It just doesn't
  make sense to worry about the UI in these.
 2022-03-09 17:26:26 -05:00
Abe Jellinek
ed31a11fce Scaffold: Sanitize items for display more accurately 2022-03-09 11:42:16 -08:00
Tom Najdek
1ad2056674
Add support for importing Citavi annotatons (#2351) 2022-03-09 04:06:44 -05:00
Dan Stillman
c7ece79f79 Fix missing creators not being removed in item.fromJSON() 
Apparently there's been a bug for years where removing a creator
remotely hasn't caused it to be removed locally via sync...

https://forums.zotero.org/discussion/94910/desktop-app-not-correctly-syncing
 2022-03-09 02:43:22 -05:00
Dan Stillman
326d3425db Update Preprint icon 
Journal article plus pencil, similar to manuscript (blank page plus
pencil)

Follow-up to zotero/zotero-bits#88
 2022-03-08 01:05:54 -05:00
Abe Jellinek
cc47359080 Update translate submodule 2022-03-07 13:46:07 -08:00
Abe Jellinek
6ad829a7e5 Set sync reminder lastDisplayed when dismissed by sync 2022-03-07 09:39:40 -08:00
Dan Stillman
e5558b6f3e Remove note backup functionality 
Closes #2191
 2022-03-05 06:12:29 -05:00
Dan Stillman
a1305712f3 Update locales from Transifex and merge new English strings 2022-03-05 05:35:22 -05:00
Dan Stillman
053d6a0116 Add Preprint item type 
See zotero/zotero-bits#88
 2022-03-05 02:03:29 -05:00
Dan Stillman
d750da089f Show clearer error for SSL certificate error 
For both startup proxy auth requests and subsequent requests to
zotero.org domains

Closes #2337
 2022-03-05 02:03:29 -05:00
Dan Stillman
f6bd7269ae Fix changing locale via keyboard on Windows 
(And maybe Linux)

https://forums.zotero.org/discussion/94866/beta-6-0-no-shortcut-key-could-be-applied-in-language-of-advanced-setting
 2022-03-05 00:48:44 -05:00
Martynas Bagdonas
3c42103848
Allow to Quick Copy annotations (#2377) 2022-03-04 03:52:23 -05:00
Dan Stillman
6da38c292e Scaffold: Tweak tooltip text for Run and Update button 2022-03-02 22:36:44 -05:00
Abe Jellinek
5409ae3313 Overhaul Scaffold (#2293) 2022-03-02 22:36:04 -05:00
Dan Stillman
a7cf689df2 Update locales from Transifex and merge new English strings 2022-03-02 16:39:04 -05:00
Abe Jellinek
d82981d601
Fix item tree jumping to top on focus without selection (#2347) 2022-03-02 14:55:01 -05:00
Adomas Ven
b38d7107d8
HTML Tree: Add a dotted border to pivot rows (#2375) 2022-03-02 05:41:59 -05:00
Dan Stillman
c0ab16e79d Merge pull request #2354 
Add sync reminders
 2022-03-02 05:25:38 -05:00
Dan Stillman
706233c974 Sync reminders changes (#2354) 
- Adjust text
- Add "Learn More" button with link to sync documentation for
  set-up-sync notification
- Show "Don't Show Again" for set-up-sync even on first display
- Don't perform any action when clicking unlinked text
- Use yellow/orange background instead of blue for notification bar
- Prevent text from wrapping out of the bar at narrow window widths
- Use local variable for observer id
 2022-03-02 05:20:34 -05:00
Abe Jellinek
b0f09b3a86 Sync reminders changes (#2354) 
- Always wait seven days, standardize casing
- Enable auto-sync without opening preferences
- Implement suggestions
 2022-03-02 05:20:22 -05:00
Fletcher Hazlehurst
1a3f6301b7 Add syncing reminders (#2354) 
There are two:
- Sync never set up (no username in DB) / set up, but unlinked
- Sync set up but auto-sync disabled and sync not completed in 30 days

Checks are trigged on item adds.
 2022-03-02 05:19:10 -05:00
Abe Jellinek
939ee6159d Use XRegExp in getSortTitle() 
Fixes #2372
 2022-03-01 16:37:13 -08:00
Dan Stillman
1cc03492c4 Split annotations on sync error 
Follow-up to b7f26c47c1
 2022-03-01 05:09:15 -05:00
Dan Stillman
a10fcfd58e Speed up comparison of items with huge numbers of tags 
Can cause a freeze while syncing items with 1000s of tags
 2022-03-01 02:45:07 -05:00
Martynas Bagdonas
b7f26c47c1 Split annotation if position data exceeds the limit 2022-02-28 20:10:20 +02:00
Abe Jellinek
b54466f089 Fix error restoring top-level notes & attachments 
Fixes #2369
 2022-02-28 08:18:59 -07:00
Martynas Bagdonas
003b3db281
Implement custom keyboard navigation (#2317) 2022-02-23 13:00:57 -05:00
Dan Stillman
1743360de7
Merge pull request #2366 from AbeJellinek/short-title-column 
Add Short Title item tree column
 2022-02-22 15:40:45 -05:00
Abe Jellinek
2e74bdd2ad De-duplicate column strings and use getString() 2022-02-22 10:59:07 -08:00
Dan Stillman
8d81705831 Move Duplicate Item in items list context menu 
Move below Add to Collection and Remove from Collection
 2022-02-21 23:16:49 -05:00
Dan Stillman
c192dacc76 Merge new English strings 2022-02-21 21:53:36 -05:00
Abe Jellinek
f333585d98
Add items to collection via context menu (#2360) 2022-02-21 19:36:37 -05:00
Abe Jellinek
198ae65b4a Fix Import placing items in feeds/uneditable libraries 2022-02-21 15:40:19 -08:00
Abe Jellinek
fb98fe5d2c Add Short Title item tree column 2022-02-21 14:50:43 -08:00
Dan Stillman
ca3fd80825 Remove use of Promise.tap() from Bluebird and our own Promise.check() 2022-02-21 15:46:23 -05:00
Dan Stillman
e48d069687 Update locales from Transifex and merge new English strings 2022-02-21 15:26:58 -05:00
Dan Stillman
4d79e162c9 Remove DB diagnostics for missing schema updates problem 2022-02-21 15:13:43 -05:00
Dan Stillman
7700cd776a Repeat itemAnnotations schema update step after 078e3bb079 2022-02-21 15:13:38 -05:00
Dan Stillman
078e3bb079 Switch from Bluebird coroutine to async/await for DB/schema 
We've been seeing some behavior in `Schema::_migrateUserDataSchema()`
that should be impossible, with conditional blocks totally skipped. I
can't see how this is anything other than either a JS engine bug with
generators or some sort of bug in our version of Bluebird, but with any
luck it will go away by switching everything to async/await.
 2022-02-21 15:13:05 -05:00
Dan Stillman
9a2aec970d Load styles list in preferences even if custom style has an invalid date 
A bundled style will get replaced from the repo if it has an invalid
date, but a custom style would result in an empty list.

https://forums.zotero.org/discussion/comment/399774/#Comment_399774
 2022-02-21 15:12:46 -05:00
Adomas Ven
191e43dcfa
Delay querying attachment state from DB on tree scroll (#2357) 
This improves item tree fast-scrolling performance when attachment
column is enabled, but adds a noticable attachment state pop-in
 2022-02-21 13:28:15 -05:00
Martynas Bagdonas
b71367760d Don't jump to library tab when closing tab after startup 
Fixes #2362
 2022-02-21 18:43:04 +02:00
Martynas Bagdonas
822f821718 Set the current author name when creating an annotation in a group 
Fixes #2322
 2022-02-21 18:11:56 +02:00
Martynas Bagdonas
04fa89ffc8 Don't copy/import/delete note images if library files aren't editable 
#2364
 2022-02-21 18:11:56 +02:00
Adomas Venčkauskas
000599bfff Do not load citeproc-rs on Style.init() unless it's enabled 
Closes #2363
 2022-02-21 13:50:08 +02:00
Abe Jellinek
48a3235a2e
Disable Delete/Restore menu items appropriately (#2340) 2022-02-20 11:45:53 -05:00
Abe Jellinek
13f48ec5c7
Render markup in item tree, strip when sorting (#2355) 2022-02-19 15:49:35 -05:00
Dan Stillman
a45da8df17 Add Greek locale 2022-02-19 14:18:50 -05:00
Dan Stillman
5d6318fd3e Update locales from Transifex and merge new English strings 2022-02-19 14:10:07 -05:00
Dan Stillman
fac8d55002 Update submodules 2022-02-19 13:53:03 -05:00
Dan Stillman
b54b7edf9b Don't set author name of current user when copying annotation from group 
Fixes #2358
 2022-02-19 13:47:28 -05:00
Dan Stillman
72ac453a8c Set createdByUserID to current user for locally created group item 
Addresses #2322
 2022-02-19 13:47:28 -05:00
Dan Stillman
4a914c26db Set user display name from /keys/current 
So that it can be available for annotations created locally before
they're uploaded
 2022-02-19 13:47:28 -05:00
Dan Stillman
a2458614df Don't include date line when generating filename for annotations note 
Since in many locales it would contain slashes and colons, both of which
would be stripped in the filename, leaving long strings of numbers in
the filename
 2022-02-19 13:45:29 -05:00
Dan Stillman
5eee488e20 Update utilities submodule 
And add tests for `Utilities.Internal.noteToTitle()`

Follow-up to zotero/utilities@df2dda23b
 2022-02-19 13:43:41 -05:00
Martynas Bagdonas
5405da99db
Add support for annotation templates (#2359) 2022-02-18 14:38:36 -05:00
Dan Stillman
7606c88e79 Tweak Word/Apple Silicon warning text 2022-02-17 01:43:39 -05:00
Dan Stillman
db35f55c96 Limit autocomplete in Advanced Search to specific creator types 
For `author`, `bookAuthor`, and `editor` conditions added in #2253
 2022-02-17 01:43:39 -05:00
Abe Jellinek
91cdc5610b
Search by specific creator type (#2353) 
Author, editor, or book author.
 2022-02-17 01:06:14 -05:00
Martynas Bagdonas
924d29ff7e Fix undefined Zotero_Tabs issue 2022-02-14 14:13:30 +02:00
Adomas Venčkauskas
06676be8e4 Add defaultSort attribute to columns 
Sort date columns in descending order by default.
Closes #2344
 2022-02-11 16:19:59 +02:00
Martynas Bagdonas
e6c835abc8
Allow to show/hide citations in notes (#2288) 2022-02-11 12:50:43 +02:00
Martynas Bagdonas
bcfd93bc79 Set lastModifiedByUser even if an annotation author is authoritative 2022-02-10 10:55:02 +02:00
qqobb
47799adb3c
Improve directoryContains() (#2335) 2022-02-10 03:17:46 -05:00
Dan Stillman
f509e9063a Fix arrow keys in View menu 
Arrow keys still step through `collapsed` menuitems, whereas `hidden`
properly hides them from key navigation.
 2022-02-10 02:52:02 -05:00
Dan Stillman
76c7e832bb Add accesskey for View menu 
https://forums.zotero.org/discussion/94431/6-0-beta-underline-of-view-menu
 2022-02-10 02:52:02 -05:00
Martynas Bagdonas
ee3e28e126 Changes to how author name is passed to pdf-reader and pdf-worker 2022-02-09 16:54:46 +02:00
Adomas Venčkauskas
8c846468f2 Update strings for Mac Word errors 2022-02-09 15:25:45 +02:00
Dan Stillman
c6d03753fd Don't copy external annotations to between libraries 2022-02-09 07:08:18 -05:00
Dan Stillman
9bf842a3ae Update locales from Transifex and merge new English strings 2022-02-09 06:44:03 -05:00
Dan Stillman
bacc5b4428 Preserve explicit annotation author name when copying from group 2022-02-08 23:57:49 -05:00
Abe Jellinek
9cf45c0a0b
Set default filename when exporting single note (#2339) 2022-02-08 23:28:53 -05:00
Dan Stillman
734057ff9b Require DB transaction in Zotero.Items.moveChildItems() 
But make optional with deprecation warning for now, since it's used in
ZotFile
 2022-02-08 06:38:48 -05:00
Dan Stillman
f684984b07 Copy annotations across libraries 
Based on option in prefs

When copying an annotation group the
 2022-02-08 06:38:32 -05:00
Dan Stillman
67451dffd5 Add annotationAuthorName property to annotation items 
And pass both `authorName` and `lastCreatedByUser` to the PDF reader.
The former can either come from `createdByUser` or be set directly on
the item (for group annotations dragged to personal libraries).
 2022-02-08 06:38:32 -05:00
Dan Stillman
60f9a0417f Remove isAuthor from JSON passed to PDF reader 2022-02-08 06:38:32 -05:00
Dan Stillman
bf9ef5fc01 Disable PDF annotation transfer in group libraries 2022-02-08 06:38:32 -05:00
Dan Stillman
cc0687a574 Fix selectLibrary() in CollectionTree if no libraryID passed 2022-02-08 06:38:32 -05:00
Adomas Venčkauskas
0d2cfef160 HTML Tree: fix errors being thrown on hover over empty cells 
Regression in 54ad6da1
 2022-02-08 10:00:36 +02:00
Martynas Bagdonas
b865ee8b65 Fix tagsBox issues in a separate note window: 
- Invisible auto-suggested tags
- Oversized tag icon
 2022-02-07 17:39:09 +02:00
Dan Stillman
e4f5241058 Add missing quote in logged error 2022-02-05 03:17:51 -05:00
Adomas Venčkauskas
54ad6da1af HTML Tree: make tooltip setting code use any parent xul node 2022-02-04 14:19:20 +02:00
Dan Stillman
c78bf1b2a3 Fix feed item guid in logged warning when item exists in different feed 2022-02-04 02:18:38 -05:00
Abe Jellinek
e8b574da0b
Fix React icons only using 2x image once (#2324) 
a1267bc fixed repeated re-appending of '@2x' by moving the modified URL
to a local variable, but it still set hasHiDPI to false permanently;
this meant that icons displayed repeatedly in the same window, like the
tab close button, would only use their 2x versions the first time they
were displayed (in the case of tabs, this is the library tab's invisible
close button, so *no* tabs got visible 2x buttons).

This commit moves the HiDPI check and URL modification out of the render
function and instead runs it a single time when i() is first called.
 2022-02-04 00:38:01 -05:00
Adomas Venčkauskas
8de1ddcaf4 HTML Tree: Display a tooltip with full cell contents when truncated 
Closes #2321

Also added tooltips for cells that use an icon in their contents
 2022-02-03 16:09:40 +02:00
Abe Jellinek
4777f0ec89 Double-click/enter to edit feed 
Closes #2323
 2022-02-02 23:03:04 -08:00
Tom Najdek
90da2563c8
Decouple progress queue table from progress window (#2318) 
* Tweaked ProgressQueue to accept multiple listeners per event.
  Removing listeners now requires specifying which one to remove.
* Decoupled progress queue table into new ProgressQueueTable component
 2022-02-02 17:15:57 -05:00
Dan Stillman
1ea1a134ba Reset extensions.spellcheck.inline.max-misspellings 
Closes #2108
 2022-02-02 05:48:23 -05:00
Adomas Venčkauskas
060d2f1c37 Item tree: Add tooltips for header cells. 
Restrict the html-tooltip [title] selector to not fall back to
window title when no title attributes are present.
 2022-02-02 12:25:50 +02:00
Dan Stillman
4e6b68477d PDF reader: Annotation name display changes 
- Show creator's name in groups even when it's the current user
- Don't show name for external annotations
 2022-02-02 03:54:34 -05:00
Dan Stillman
3902043669 Update locales from Transifex and merge new English strings 2022-02-02 02:22:34 -05:00
Dan Stillman
a6e0432848 PDF reader: Tweak annotation deletion confirmation text 2022-02-02 02:09:20 -05:00
Martynas Bagdonas
21ca1555c1 Focus tag input field if tagsBox doesn't have tags 
Fixes #2315
 2022-01-31 19:49:58 +02:00
Dan Stillman
637acbe693 Fix incorrect isEditable() test in Item::moveToLibrary() 2022-01-31 06:48:05 -05:00
Dan Stillman
df64a16b55 Disallow unowned group annotation edits, but allow deletions 
Update `DataObject::isEditable()` to take an optional `op` argument to
test individual operations as opposed to general library editing.
Erasing objects now tests `erase`, and `Item::isEditable()` allows
`erase` for unowned group annotations while disallowing the default
`edit`.

It's still up to the reader to handle this appropriately in the UI and
not allow operations it shouldn't, but this enforces it in the data
layer.
 2022-01-31 06:48:05 -05:00
Dan Stillman
5a0cd78f06 Enable PDF reader by default and enable for groups 
"Zotero" is now the first and default option in the "Open PDFs using"
drop-down in the General pane of the preferences.
 2022-01-31 06:48:05 -05:00