Commit graph

9879 commits

Author SHA1 Message Date
Abe Jellinek
9a2e98360a fx-compat: Scaffold: Update Monaco
Now that we can. Quite a bit faster and more customizable.
2022-06-08 17:38:59 -05:00
Abe Jellinek
e537018e71 fx-compat: Initial fix for Scaffold
Not working:
- Web tests (hidden browser is broken)
- Test Updated status text
- Various platform menu things (code copied from ZP and will use whichever
  approach we settle on there)
2022-06-08 17:16:50 -05:00
Martynas Bagdonas
1b324f9bd1 fx-compat: Fix color rendering in annotation popup, use checkbox 2022-06-08 21:22:37 +03:00
Martynas Bagdonas
1e25e2ac4c fx-compat: Fix invisible caret issue in linksBox tags popup 2022-06-08 21:22:37 +03:00
Martynas Bagdonas
a7bc25b553 fx-compat: Fix PDF reader window 2022-06-08 18:57:26 +03:00
Martynas Bagdonas
08089d6120 fx-compat: Fix tooltip node to work in PDF reader tab 2022-06-08 18:57:26 +03:00
Martynas Bagdonas
2e5388af5b fx-compat: Implement tagsBox element 2022-06-07 17:13:48 +03:00
Abe Jellinek
7e55ea59bb fx-compat: Item box: Change creator type label correctly 2022-05-31 16:31:20 -07:00
Abe Jellinek
b9f3bea8c3 fx-compat: Attachment box: Only add listener once 2022-05-31 16:30:55 -07:00
Abe Jellinek
1b74befd64 fx-compat: Fix Item Type menu regression 2022-05-31 15:04:14 -07:00
Abe Jellinek
d3555228b2 fx-compat: Fix Duplicate Items merge view 2022-05-31 14:57:47 -07:00
Abe Jellinek
59d5013952 fx-compat: Item box: Fix menu actions, plus/minus buttons 2022-05-31 11:23:19 -07:00
Abe Jellinek
496f34117c fx-compat: Fix attachment rename, remove <links-box> observer
<links-box> doesn't actually have a notify() method, so an error was
being thrown on each notification.
2022-05-27 13:28:07 -06:00
Abe Jellinek
1ef40d9423 fx-compat: Fix attachment box 2022-05-27 12:56:13 -06:00
Martynas Bagdonas
307701788f fx-compat: Fix and extract notesBox into a separate element 2022-05-27 13:21:18 +03:00
Abe Jellinek
f05d6fe0e0 fx-compat: Fix basicViewer for http(s):// URLs
maychangeremoteness="true" is required to successfully load pages from
the web even though we never actually change remoteness.

https://searchfox.org/comm-central/rev/2cf3a09a0127fe73e932c5ee793986f3bed2ccd2/mail/base/content/aboutMessage.xhtml#118
2022-05-26 10:45:57 -06:00
Abe Jellinek
e26fd18450 fx-compat: Change autocomplete-input load method 2022-05-26 09:39:30 -06:00
Martynas Bagdonas
0079fbdb08 fx-compat: Fix relatedBox 'Add' button visibility 2022-05-26 18:31:07 +03:00
Martynas Bagdonas
db0ac723fa fx-compat: Note editor and links box fixes:
- Add links-box component (inside noteEditor.js).
- Add related-box component and fix related pane.
- Use tagsBox.jsx instead of tagsbox.xml in note editor links box popup.
- Remove CSS styles and bindings for noteeditor, relatedbox and tagsbox.
2022-05-26 18:23:31 +03:00
Martynas Bagdonas
4a1812e5ba fx-compat: Fix selectItemsDialog 2022-05-26 18:23:31 +03:00
Abe Jellinek
4a856b94cc fx-compat: Item box: Fix abstract expander 2022-05-25 13:22:52 -06:00
Abe Jellinek
3566d1fc1f fx-compat: Item box: Fix item type menulist
- Use IDs as list item values
- Use addEventListener() so events are actually received
- Put menulist inside <td>
    * This causes a small appearance regression at the moment because
      <td> margins/padding are a bit off, but that issue is visible on
      all other fields already.
2022-05-25 12:51:15 -06:00
Abe Jellinek
c2ce5c7596 fx-compat: Remove duplicate menulistItemTypes.js 2022-05-24 15:56:09 -06:00
Abe Jellinek
5d96f9960a fx-compat: Item box: Fix unstyled menulists 2022-05-24 15:48:10 -06:00
Abe Jellinek
fdd73d4ada fx-compat: Item box: Fix multiline fields & autocomplete 2022-05-24 15:42:54 -06:00
Abe Jellinek
02bcb1712c fx-compat: Fix content shrinking to half of window height
On my system, this would always happen after adding a new attachment.
2022-05-24 13:59:12 -06:00
Abe Jellinek
29b270e761 fx-compat: Fix progress queue / Find Available PDFs 2022-05-24 13:52:52 -06:00
Abe Jellinek
195dd379d9 fx-compat: Fix context menu icons showing on Mac
Why does :is match when a regular selector doesn't? I have absolutely no
idea, but it's more concise anyway.

Fixes #2620
2022-05-24 13:37:20 -06:00
Abe Jellinek
87decd0f8d fx-compat: Fix _getExtensionFromURL() 2022-05-24 12:07:30 -06:00
Abe Jellinek
300af4477f fx-compat: Fix Attach Link dialog 2022-05-24 12:02:37 -06:00
Abe Jellinek
a2215cb8f6 fx-compat: Fix hard confirmation dialog
ID changed to commonDialog so we get commonDialog.css styling for free.
2022-05-24 11:43:45 -06:00
Dan Stillman
1a1a5924da fx-compat: Simplify Zotero.File.download()
`NetUtil.newChannel()` can take a string spec, so don't bother parsing
to an nsIURI first

Follow-up to 7adb8fd150
2022-05-24 03:03:36 -04:00
Abe Jellinek
7adb8fd150 fx-compat: Fix Zotero.File.download() 2022-05-24 00:47:22 -06:00
Abe Jellinek
eae9a4447d fx-compat: Mostly fix locateManager
Still many selectors to update in preferences.css, but how we do that
depends on what our <prefwindow>/<prefpane> replacement looks like.
2022-05-24 00:46:39 -06:00
Martynas Bagdonas
7b4c4e528c fx-compat: Fix context pane:
- Stacked view.
- Item pane tabs.
- Note list search box.
2022-05-19 14:10:51 +03:00
Martynas Bagdonas
e99a0d4515 fx-compat: Partial fixes for note editor 2022-05-19 14:10:51 +03:00
Dan Stillman
29bc36c02a fx-compat: Tweak styling of Create Bibligraphy window
And generalize CSS rules for richlistitem and groupbox headers (using
HTML H2s for the latter, as Mozilla does)

Follow-up to 547311ff26
2022-05-19 02:06:42 -04:00
Dan Stillman
9bf61f9914 fx-compat: Update CSL Edit window 2022-05-18 23:45:51 -04:00
Dan Stillman
d6e0c90baa Revert "fx-compat: Fix item box CSS link casing"
This reverts commit 4c21a42b53.

itemBox.css is correct
2022-05-18 23:45:51 -04:00
Abe Jellinek
948b09a27f fx-compat: Remove uses of defunct DOM constructors
This fixes feed translation. Getting a lot of '[object Object]' fields
from that, but I don't think it's related to these changes.
2022-05-18 20:03:37 -07:00
Abe Jellinek
09ec5b1fde fx-compat: Fix ProgressWindow
popup -> alwaysontop because popup removes the background.
2022-05-18 19:52:59 -07:00
Abe Jellinek
547311ff26 Fix Create Bibliography
listbox is gone, but richlistbox is still here as a custom element and
works fine for cases where we don't need virtualization.

groupbox label and richlistitem styles should probably be copied to
somewhere global once tuned a bit.
2022-05-18 19:32:39 -07:00
Abe Jellinek
4c21a42b53 fx-compat: Fix item box CSS link casing 2022-05-17 10:03:29 -07:00
Abe Jellinek
5f24b2dc98 Fix Create Parent dialog 2022-05-17 09:47:19 -07:00
Abe Jellinek
49a9c2dba9 fx-compat: Fix Export dialog
RDF isn't working yet, but CSV works well.
2022-05-16 14:27:23 -07:00
Abe Jellinek
60606a8528 fx-compat: Fix Add to Collection menu
Document.createXULElement is handy.
2022-05-16 13:18:16 -07:00
Martynas Bagdonas
9e93007355 fx-compat: Initial fixes for PDF reader, tabs and contextPane 2022-05-13 18:50:19 +03:00
Dan Stillman
4eb405d405 Update utilities submodule 2022-05-13 04:28:57 -04:00
Dan Stillman
da9154d811 fx-compat: Get basicViewer working for debug output
Doesn't work with, e.g., zotero://timeline/library
2022-05-13 04:28:57 -04:00
Dan Stillman
d6875e1182 fx-compat: Switch to Mozilla's method of loading window scripts 2022-05-13 04:28:57 -04:00
Dan Stillman
9b3d7a32e3 Include error message in startup error dialog 2022-05-13 04:28:57 -04:00
Dan Stillman
7c458b9bd3 fx-compat: Fix positioning of some context menus 2022-05-13 04:28:57 -04:00
Dan Stillman
bc68b6e9fe fx-compat: Start to fix tag color chooser dialog
Among other things, need to recreate XBL <customcolorpicker> as a Custom
Element and need to change `ondialogaccept`/etc. to event listeners:

https://searchfox.org/mozilla-central/rev/b72e9d7d63bf499d1d8168291b93d4ec7fde236e/browser/components/places/content/bookmarkProperties.js#232-237
2022-05-13 04:28:57 -04:00
Dan Stillman
63634eed02 fx-compat: Fix clicking URL label
Now that it's a div rather than a label, have to use `textContent`
instead `nodeValue`
2022-05-13 04:28:57 -04:00
Dan Stillman
516c76a4ab fx-compat: Start to update feed settings dialog 2022-05-13 04:28:57 -04:00
Dan Stillman
909d68eac3 fx-compat: Fix New Item menu 2022-05-13 04:28:57 -04:00
Dan Stillman
2e26703b50 fx-compat: goQuitApplication() now takes an event argument 2022-05-13 04:28:57 -04:00
Dan Stillman
172c2da2cc fx-compat: Add dropmarkers to toolbarbuttons 2022-05-13 04:28:57 -04:00
Dan Stillman
758c3187fc fx-compat: Update Edit menu (WIP) 2022-05-13 04:28:57 -04:00
Dan Stillman
280a1265c8 fx-compat: Remove Mac toolbarbutton images
Need to replace with proper styling, but the former approach doesn't
work with the new toolbarbutton component.
2022-05-13 04:28:57 -04:00
Dan Stillman
10a801fcc7 WIP: Localization 2022-05-13 04:28:57 -04:00
Dan Stillman
a16e0620d2 WIP: Localization 3 2022-05-13 04:28:57 -04:00
Dan Stillman
65658b16e6 WIP: Localization 2 2022-05-13 04:28:57 -04:00
Dan Stillman
77015336a4 WIP: Localization 2022-05-13 04:28:56 -04:00
Dan Stillman
c82af749ac Don't force Lucida Grande in various components on macOS 2022-05-13 04:28:56 -04:00
Dan Stillman
4f5b7bbccb Remove old commented-out lines in include.js 2022-05-13 04:28:56 -04:00
Dan Stillman
002132bc4b fx-compat: Populate Window menu on macOS 2022-05-13 04:28:56 -04:00
Dan Stillman
ebc511f418 coroutine()async for Zotero.init() 2022-05-13 04:28:56 -04:00
Dan Stillman
f8e10f80cc fx-compat: __defineGetter__()defineProperty() 2022-05-13 04:28:56 -04:00
Dan Stillman
13b9837524 fx-compat: Fix New Item menu and serializePersist()
`document.getElementsByAttribute` → `document.querySelectorAll`
2022-05-13 04:28:56 -04:00
Dan Stillman
9222b939ab fx-compat: Fix error viewing items
`Components.classes["@mozilla.org/network/standard-url;1"]` no longer
exists
2022-05-13 04:28:56 -04:00
Dan Stillman
31677dd296 fx-compat: Fix error generating item context menus with locate options 2022-05-13 04:28:56 -04:00
Dan Stillman
f91bf49aae fx-compat: nsIIdleServicensIUserIdleService 2022-05-13 04:28:56 -04:00
Dan Stillman
1714351cc9 fx-compat: Fix position of collection and item context menus 2022-05-13 04:28:56 -04:00
Dan Stillman
b49b8ad140 fx-compat: Mostly fix About pane
Example of converting top-level XUL `<dialog/>` to
`<window><dialog/></window>`, which uses a Mozilla-provided `<dialog>`
Custom Element
2022-05-13 04:28:56 -04:00
Dan Stillman
f4675c02df fx-compat: Update nsILoginManager::findLogins() calls 2022-05-13 04:28:56 -04:00
Dan Stillman
c7c61f72c9 fx-compat: Stop trying to load overlay.js, which was removed 2022-05-13 04:28:56 -04:00
Dan Stillman
7ee40c4682 fx-compat: Fix Add Item by Identifier window
Still a little buggy
2022-05-13 04:28:56 -04:00
Dan Stillman
8075c2d938 Remove obsolete tab.css 2022-05-13 04:28:56 -04:00
Dan Stillman
753824a7e2 fx-compat: Temporarily disable quick search bar mode menu 2022-05-13 04:28:56 -04:00
Dan Stillman
a54da965a7 fx-compat: Use search-textbox custom element for quick search bar 2022-05-13 04:28:56 -04:00
Dan Stillman
26c4bea4fd fx-compat: .boxObject was removed in Fx69
https://bugzilla.mozilla.org/show_bug.cgi?id=1519948
2022-05-13 04:28:56 -04:00
Dan Stillman
0717612b4b fx-compat: Remove contentAreaContextMenu menupopup
No longer necessary
2022-05-13 04:28:56 -04:00
Dan Stillman
260c110d05 fx-compat: Convert itembox XBL to custom element
Still lots of things to fix, particularly with styling, but the basic
functionality is there.
2022-05-13 04:28:56 -04:00
Dan Stillman
3c6f0b26af Move .zotero-clicky to its own SCSS component
This will allow it to be included in shadow DOM.
2022-05-12 05:18:47 -04:00
Dan Stillman
87f2716da8 fx-compat: zoteroPane.xul → zoteroPane.xhtml 2022-05-12 05:18:47 -04:00
Dan Stillman
abfa09df51 fx-compat: loadURI() signature change in HTTP.loadDocuments() 2022-05-12 05:18:47 -04:00
Dan Stillman
59fd8247b4 fx-compat: Remove overlay.js, since overlays no longer exist 2022-05-12 05:18:47 -04:00
Dan Stillman
d635fdda41 fx-compat: AddonManager.getAllAddons() now returns a promise 2022-05-12 05:18:47 -04:00
Dan Stillman
94c7e0674d fx-compat: Remove 'context' from onStartRequest()/onStopRequest()/etc. 2022-05-12 05:18:47 -04:00
Dan Stillman
3a77abc8d2 fx-compat: Zotero files are now packaged in app/omni.ja, not zotero.jar 2022-05-12 05:18:47 -04:00
Dan Stillman
004d5db2c3 fx-compat: Services.console.getMessageArray() returns an actual array 2022-05-12 05:18:47 -04:00
Dan Stillman
fb8984c947 fx-compat: XULDocument → XMLDocument 2022-05-12 05:18:47 -04:00
Dan Stillman
46a52b3e3e fx-compat: Update locales code 2022-05-12 05:18:47 -04:00
Dan Stillman
6d5b2c3d12 Fx-compat: nsIUTF8ConverterServicensIScriptableUnicodeConverter
It's not totally clear what this does or if it's necessary (see #1540),
but this is a replacement that Thunderbird used.
2022-05-12 05:18:47 -04:00
Dan Stillman
bbecb4d0bd fx-compat: Add appcontent container to zoteroPane.xul
Part of inlining XUL

(View with -w for real diff)
2022-05-12 05:18:47 -04:00
Dan Stillman
1bb99a6bc8 fx-compat: nsIWebNavigation::loadURI() signature change 2022-05-12 05:18:47 -04:00
Dan Stillman
b6f5d7183f fx-compat: Remove use of tree.treeBoxObject and change getCellAt() signature
Properties and methods are now available on the tree itself, and
getCellAt() now returns an object instead of using in-out variables.
2022-05-12 05:18:47 -04:00
Dan Stillman
ee78dd308b fx-compat: Remove XBL stylesheets (WIP) 2022-05-12 05:18:47 -04:00
Dan Stillman
3f64310d45 fx-compat: Inline all XUL overlays 2022-05-12 05:18:47 -04:00
Dan Stillman
dd2ff63019 fx-compat: Replace nsIDOMParser with new DOMParser() 2022-05-12 02:38:59 -04:00
Dan Stillman
993320655e fx-compat: Throw error if generator is passed to DB.executeTransaction() 2022-05-12 02:38:59 -04:00
Dan Stillman
03242e8984 fx-compat: DB.executeTransaction() no longer takes generator functions 2022-05-12 02:38:59 -04:00
Dan Stillman
ccbc785499 fx-compat: XPCOMUtils.generateQI() → ChromeUtils.generateQI() 2022-05-12 02:38:59 -04:00
Adomas Venčkauskas
4d35cdf095 Remove unneeded constant in virtualized table 2022-05-10 17:03:34 +03:00
Adomas Venčkauskas
eb6b14a218 Fix item tree column resizing issues
Report https://forums.zotero.org/discussion/97077/problem-with-column-width-adjustment
2022-05-10 17:02:36 +03:00
Adomas Venčkauskas
a406e62fd3 Item Tree: Fix column dividers not aligned for second-level items
Closes #2605
2022-05-10 13:52:32 +03:00
Adomas Venčkauskas
aa483f579f HTML tree: Find-as-you-type remains on matching string.
Closes #2607
2022-05-10 13:35:31 +03:00
Dan Stillman
273fc6c657 Update locales from Transifex 2022-05-09 10:05:55 -04:00
Abe Jellinek
db5b535ea6 Update translate submodule 2022-05-07 20:34:37 -07:00
Adomas Ven
c49a05d486
Improve column resizing robustness (#2588)
Also:

* Add staticWidth and minWidth column properties
2022-05-03 03:00:23 -04:00
Martynas Bagdonas
01645c5e51
Pin library tab (#2589)
Fixes #2575
2022-05-03 01:21:59 -04:00
Abe Jellinek
097308c5c6 Update utilities submodule 2022-05-02 17:12:39 -07:00
Dan Stillman
b6fdeeca13 Fix deadlock in integrity check before DB schema upgrade
One of the repair steps uses a transaction, which is reasonable, so
don't run integrity check within transaction at startup.
2022-05-01 02:14:45 -04:00
Dan Stillman
d201fdc119 Fix target is undefined error during upgrade from Zotero 4
https://forums.zotero.org/discussion/96811/database-upgrade-error-when-migrating-from-version-4-0-to-6-0-directly-skipping-zotero-5

Regression from 078e3bb07, probably
2022-05-01 02:14:36 -04:00
Dan Stillman
5e0674b842 Add logging for PDF exports 2022-04-30 05:17:41 -04:00
Abe Jellinek
9829ea7009
Update utilities, move tests, add to CI (#2584) 2022-04-30 04:55:11 -04:00
Dan Stillman
fd859bd976 Update locales from Transifex and merge new English strings 2022-04-29 18:28:52 -04:00
Dan Stillman
b536432866 Fix mistake in tab-unavailable integration message 2022-04-29 16:54:16 -04:00
Dan Stillman
644cce219a Tweak tab-unavailable integration message 2022-04-29 16:51:41 -04:00
Adomas Venčkauskas
ff920de130 Fix integration transaction getting stuck when google docs tab is closed
Closes #2583
2022-04-29 15:19:20 +03:00
Adomas Venčkauskas
fca16d2ad5 Fix find-as-you-type not matching beyond first letter
Closes #2581
2022-04-29 15:19:20 +03:00
Martynas Bagdonas
70c9bef320 Switch tabs with Cmd-Option-←/→
Fixes #2475
2022-04-29 12:56:04 +03:00
Abe Jellinek
3bfc6740c4
Add tests for improved compareCallNumbers (#2579) 2022-04-28 04:43:30 -04:00
Abe Jellinek
5196ba379b
Update typeSchemaData and builder script (#2576) 2022-04-28 02:12:29 -04:00
Martynas Bagdonas
fe14ee79a3 Show a few missing options in Tools menu when PDF reader tab is open
Fixes #2502
2022-04-27 18:20:41 +03:00
Martynas Bagdonas
41bdd36068 Add an option to disable smart quotes
Fixes #2524
2022-04-27 10:23:10 +03:00
Dan Stillman
a4cdaf0407 Show "Add Note from Annotations" in attachment context menu 2022-04-27 02:34:42 -04:00
Dan Stillman
c405fa76a1 Add sortNotesChronologically.reader pref for PDF reader notes list
And default to true. I forgot we were sorting reverse chronologically by
default in order to make it easy to open recent notes.

Follow-up to https://github.com/zotero/zotero/issues/2526 for
https://forums.zotero.org/discussion/96743/pdf-reader-two-feature-requests
2022-04-26 17:59:45 -04:00
Dan Stillman
40501c3953 Update locales from Transifex and merge new English strings 2022-04-26 17:22:39 -04:00
Martynas Bagdonas
10c8fc4c74 Implement tab duplication
Fixes #2566
2022-04-26 19:41:51 +03:00
Abe Jellinek
89aaa10504
Sort LC call numbers better, sort integers as integers (#2569)
* Update utilities submodule after https://github.com/zotero/utilities/pull/8
* Extract and add tests
2022-04-26 04:11:29 -04:00
Martynas Bagdonas
7a06671ecb Fix undefined variable issue in annotation templates 2022-04-26 08:29:42 +02:00
Adomas Venčkauskas
d96ebad82a Allow adding multiple sources at once in classic citation dialog.
Closes #2568
2022-04-25 13:28:00 +03:00
Adomas Venčkauskas
1be2d69f1e Log integration invocations before other integration actions 2022-04-25 12:43:48 +03:00
Martynas Bagdonas
b8d427790c Fix error when using a note template and checking if array is not empty 2022-04-23 14:52:24 +07:00
Adomas Venčkauskas
d9463daa66 HTML Tree: Search by typing loops instead of starting from beginning
Closes #2559
2022-04-22 10:58:25 +03:00
Martynas Bagdonas
c1fde1d3d9 Improve tab title visibility and adjust scroll arrow scroll step
Fixes #2554
Fixes #2553
2022-04-22 13:07:18 +07:00
Dan Stillman
114b48d5b8 Update locales from Transifex 2022-04-21 15:46:50 -04:00
Dan Stillman
031ff1824b Fix middle click to close tabs (#1993) 2022-04-21 12:23:14 -04:00
Martynas Bagdonas
a8cb9bfddd Restore custom note styling
Fixes #2560
2022-04-21 13:17:04 +07:00
Abe Jellinek
f91ca9c18a Don't merge with a deleted master attachment 2022-04-20 11:04:24 -07:00
Martynas Bagdonas
142e3b09f8
Unload tabs (#2500)
- Keep all tabs unloaded on Zotero opening.
- Keep loaded only the last five selected tabs.
- Keep loaded only in the last 24h selected tabs.

Fixes #2383
2022-04-20 03:14:50 -04:00
Dan Stillman
578986ab1e Fix item types not appearing in New Item submenu
https://forums.zotero.org/discussion/96530/a-issue-about-new-item-drop-down-menu

After a type from the submenu was selected and added to the MRU, the
submenu wouldn't be updated. Not sure how long this has been going on.

Fixes #2534
2022-04-19 23:04:18 -04:00
Martynas Bagdonas
5d442b706e
Make tab bar scrollable (#2506)
Fixes #2232
2022-04-19 18:51:32 -04:00
Adomas Ven
7b0d6951d2
Update csl validator for CSL 1.0.2 (#2493) 2022-04-19 18:42:48 -04:00
Dan Stillman
3f10e4c064 Bad JSON in sync cache shouldn't break syncing
https://forums.zotero.org/discussion/95926/zotero-not-syncing-report-id-1924846177
2022-04-19 17:49:13 -04:00
Martynas Bagdonas
5c8ea0174a Fix empty table row height in generated report, prevent table overflow
Fixes #2545
2022-04-15 21:59:27 +07:00
Adomas Venčkauskas
5ca8486047 Adjust conditional clause for Windows from 76276a3 2022-04-15 11:21:07 +03:00
Adomas Venčkauskas
76276a39ce HTML Tree: adjust row padding per OS 2022-04-15 11:15:40 +03:00