mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
24781 commits 1 branch 183 tags 5.3 GiB
Commit graph

2677 commits

Author SHA1 Message Date
Cheng Zhao
a6256c672a feat: getGPUInfo not longer supports 'complete' on macOS 
See https://chromium-review.googlesource.com/c/chromium/src/+/1208362
 2018-10-09 14:38:00 -07:00
Charles Kerr
05f4860889
fix: power observer dbus crash (#15030) 
* fix: check dbus response for nullptr before using

* chore: use BindOnce for ProxyObject::CallMethod cb

* chore: comment out name of unused argument

* fix: re-enable and fix linux power monitor tests

* fix: change tyop from code comments

* refactor: don't keep unnecessary dbus pointer

* chore: remove the 'TODO: fix this' spec comment
 2018-10-09 00:32:19 -05:00
Milan Burda
b50f86ef43 refactor: use separate ipc-renderer-internal / ipc-main-internal APIs for Electron internals (#13940) 2018-10-07 00:48:00 +13:00
Robo
6e5dd735f6 refactor: enable weak ptr unwrap sequence dcheck (#14816) 
* refactor: enable weak ptr unwrap sequence dcheck

* spec: remove WeakPtrDeathTest.* from disabled list
 2018-10-05 15:29:57 -05:00
Charles Kerr
9d4818c784
fix relaunch on linux (#14975) 
* chore: re-enable relaunch test for Linux

* fix: relauncher_linux listening for parent exit
 2018-10-04 18:41:37 -05:00
Milan Burda
ae8c0f71b1 chore: remove duplicate code in spec/security-warnings-spec.js (#14967) 2018-10-05 00:24:14 +02:00
Robo
434a6e3561 refactor: create request context from network context (#14656) 
* [ci skip] refactor: create request context from network context

* [ci skip] refactor: subscribe to mojo cookiemanager for cookie changes

* [ci skip] refactor: manage the lifetime of custom URLRequestJobFactory

* refactor: use OOP mojo proxy resolver

* revert: add support for kIgnoreCertificateErrorsSPKIList

* build: provide service manifest overlays for content services

* chore: gn format

* fix: log-net-log switch not working as expected

* spec: verify proxy settings are respected from pac script with session.setProxy

* chore: use chrome constants where possible

* fix: initialize request context for global cert fetcher

* refactor: fix destruction of request context getters

* spec: use custom session for proxy tests

* fix: queue up additional stop callbacks while net log is being stopped

* fix: Add CHECK for cookie manager retrieval

* chore: add helper to retrieve logging state for net log module

* fix: ui::ResourceBundle::GetRawDataResourceForScale => GetRawDataResource

* style: comment unused parameters

* build: move //components/certificate_transparency deps from //brightray

* chore: update gritsettings_resource_ids patch

* chore: update api for chromium 68

* fix: net log instance is now a property of session
 2018-10-04 13:08:56 -05:00
John Kleinschmidt
038b56e31e
ci: Trigger an arm test on VSTS after CircleCI build (#14898) 
* ci: Trigger an arm test on VSTS after CircleCI build
 2018-10-04 12:01:16 -04:00
Alexey Kuzmin
f161835fc3 test: disable one test in base_unittests (#14968) 
Fails after the Chromium 68 upgrade.
 2018-10-04 10:00:30 -04:00
Aleksei Kuzmin
21f382fcae test: disable the "app.relaunch" test on Linux 2018-10-04 00:21:58 +02:00
Jeremy Apthorp
45c2dcddb0 disable failing assert in beginFrameSubscription dirty-rectangle test 2018-10-04 00:15:00 +02:00
Samuel Attard
0ee46cdc26 test: make run-as-node --inspect test more robust on windows 2018-10-04 00:14:59 +02:00
Cheng Zhao
b11b4f2235 test: make before-input-event test more robust 2018-10-04 00:14:59 +02:00
Jeremy Apthorp
09f018ce8c test: fix frame-subscriber test on Mac 2018-10-04 00:14:59 +02:00
Jeremy Apthorp
cc53269231 better crash diagnostics in ffmpeg test 2018-10-04 00:14:59 +02:00
Aleksei Kuzmin
ae95f77d68 test: minor improvements to the Node spec 
- reformat some parts
 - better failures reporting with `expect`
 - skip some tests instead of marking them as passed
 2018-10-04 00:14:59 +02:00
Milan Burda
5efb0fdff1 feat: add security warnings to sandboxed renderers (#14869) 
Also refactor not to use the remote module.
 2018-10-03 21:36:12 +02:00
Cheng Zhao
4c4d8c5bfa fix: support ASAR in fs.copyFile (#14942) 2018-10-03 09:36:20 -07:00
Milan Burda
3ad3ade828 refactor: add prefer-const to .eslintrc + fix errors (#14880) 2018-10-02 11:56:31 +10:00
Alexey Kuzmin
c9edf77e8e test: slightly rewrite getGPUInfo() tests (#14863) 
Rewrite GPUInfo tests for linux and update `getGPUInfo` functionality for linux.
`basic` and `complete` GPUInfo is same for linux.
 2018-10-01 18:34:52 -07:00
Alexey Kuzmin
f1b097024e ci: run more unittests (#14861) 2018-10-01 17:50:52 -05:00
Alexey Kuzmin
60ac03c08f test: disable getGPUInfo() tests on Linux (#14875) 2018-10-01 12:57:38 +10:00
Milan Burda
d48f9bcf7f refactor: implement <webview> methods via dedicated IPCs without the remote module (#14377) 2018-10-01 10:07:50 +09:00
Milan Burda
c61db523c7 refactor: replace var with const / let (#14866) 2018-09-29 09:17:00 +10:00
Samuel Attard
b42493e6e6 test: guarantee the order of webview and devtools creation (#14849) 2018-09-28 12:34:57 -07:00
Samuel Attard
2adb44a402 chore: remove unused files to simply out_dir replacements 2018-09-28 11:16:37 +10:00
Samuel Attard
6be69048e6
fix: handle shortcuts by default if no WebPreferences object exists (#14766) 
DevTools webcontents do not have webpreferences

Fixes #14685
 2018-09-28 01:41:09 +10:00
Nitish Sakhawalkar
5c108728d6 feat: Implementation of getGPUInfo API. (#13486) 
* Implementation of getGPUInfo API.

* Clear promise set

* Changes to promise usage

* Minor fixes

* Fix linux build

* Update spec

* Fix lint (linter didn't run on windows locally)

* Test running single test for CI

* Update spec
 2018-09-28 00:59:23 +10:00
Samuel Attard
7dc7cd1d89
fix: send null in debugger callback when no error (#14814) 
Fixes #13811
 2018-09-27 17:43:45 +10:00
Milan Burda
3df739fa89 refactor: implement crashReporter.start() without the remote module (#14434) 2018-09-26 15:43:34 +10:00
Troy
560b1c17af fix: setMaximizable to be true if window is resizable & maximizable (#14648) 
* setMaximizable to be true if window is resizable & maximizable

* Fix linting

* Add regressive test to verify maxmizable state

* Leaves maximizable state of window alone if setResizable is called

* Fix exclusive test

* Fix crashing text

* SetMaximizable unconditionally

* Remember former maximizable state

* Fix accidental mac variable deletion

* Logic modification

* Lint

* Remove unneeded test

* Remove unneeded variable since only Windows is effect
 2018-09-26 11:41:40 +10:00
Samuel Attard
50a4a8e9c3
spec: add test for syncronous access to blink APIs (#14637) 
This test should ensure we catch a regression of #13787
 2018-09-25 10:40:15 +12:00
John Kleinschmidt
8854d9872c test: reenable app moduele > app.exit(exitCode) > closes all windows 2018-09-20 09:32:02 -04:00
Jeremy Apthorp
73d1b76b54
test: runas is not an optional dependency (#14704) 2018-09-19 15:59:37 -07:00
Milan Burda
e22142ef9c feat: add process.takeHeapSnapshot() / webContents.takeHeapSnapshot() (#14456) 2018-09-18 11:00:31 -07:00
Samuel Attard
6d01952e66
chore: replace standard with eslint-config-standard and add custom rules (#14636) 
* chore: replace standard with eslint-config-standard

This adds support for --cache so linting JS only takes ~1 second and only lints things that changed

It also allows us to add custom linting rules

* chore: add eslint-plugin-mocha and enable the no-exclusive-tests rule

This will block anyone from pushing / merging a `.only` test or describe
 2018-09-16 03:51:23 +10:00
Samuel Attard
7065093869
feat: add will-redirect (#13866) 
* feat: add will-redirect to allow people to prevent 30X redirects

* spec: add tests for the will-redirect event

* refactor: implement will-redirect using NavigationThrottle instead of PostTask

This avoids a potential race condition and immediately cancels the
navigation

* docs: add docs for did-redirect-navigation

* refactor: move AtomNavigationThrottle out of net folder

* refactor: update header guard for atom_navigation_throttle.h

* refactor: fix chromium style errors in the GN build

* refactor: update throttle impl to NOTREACHED and std::make_unqique
 2018-09-16 01:42:43 +10:00
John Kleinschmidt
838b26ee26 ci: Move Mac builds to Azure Devops (VSTS) (#14588) 
* Add support for multiple mocha reporters

Allows us to output to junit file and to console at the same time

* Cleanup VSTS file

Don't install depot_tools everytime as it is already installed.

Only run tests if "RUN_TESTS" environment variable is set
Only notify slack if "NOTIFY_SLACK" environment variable is set

Don't use sccache for release builds

Move CircleCI mac builds to VSTS

* Only build mac PRS from forks

Don't install depot_tools everytime as it is already installed.

Only run tests if "RUN_TESTS" environment variable is set
Only notify slack if "NOTIFY_SLACK" environment variable is set

Don't use sccache for release builds

Move CircleCI mac builds to VSTS

Use sccache helper script

* rename vsts-gn.yml to vsts.yml
Make sure Electron isn't running before starting tests
 2018-09-14 11:56:16 -07:00
Samuel Attard
dc2a6c5d71
spec: fix crashReporter upload assertions 2018-09-14 22:23:58 +10:00
Samuel Attard
40f0f049a2
spec: fix final node and chromium specs after assert change 2018-09-14 18:32:17 +10:00
Samuel Attard
4bcc08826b
spec: fix headers tests to match APIs 2018-09-14 17:05:26 +10:00
Samuel Attard
9e59d2a78d
spec: fix broken remote specs 2018-09-14 16:57:39 +10:00
Samuel Attard
3487bbe356
spec: handle null prototypes in specs 2018-09-14 16:47:54 +10:00
Samuel Attard
21aa28d60f
refactor: s/resolverGetters/resolveGetters 2018-09-14 16:41:21 +10:00
Samuel Attard
5c8c31c93d
spec: update 'BrowserWindow.fromBrowserView(browserView) returns undefined if not attached - returns undefined if not attached' to match docs (null not undefined) 2018-09-14 16:38:44 +10:00
Samuel Attard
91cc453ccc
spec: add helper to resolve property getters 2018-09-14 16:36:23 +10:00
Samuel Attard
558fff69e7
chore: update to standard 12 2018-09-14 14:57:01 +10:00
Samuel Attard
a55fd16349
fix: update node ref to fix patch handling unhandled rejections (#14603) 
Fixes #14573
 2018-09-13 16:32:49 +10:00
Robo
d9c6dd0254 chore: add debugger specs for multiple sessions (#14598) 2018-09-13 16:32:30 +10:00
Charles Kerr
a3f7e298cf
refactor: remove unused, duplicated code in deprecate module (#14579) 
* remove obsolete tests

 * remove unused deprecate API

 * make a warnOnce helper for the deprecate methods

 * misc. copyediting, e.g. variable names, whitespace

 * test that any deprecation warns once at most

 * use strict
 2018-09-12 17:13:22 -05:00
Robo
e860748d6b fix: Invalidate weak ptrs before window Javascript object is destroyed (#14532) 
* fix: Invalidate weak ptrs before window Javascript object is destroyed

* chore: add regression test for #14513

This test is similar to the original gist at https://gist.github.com/bpasero/a02a645e11f4946dcca1331d0299149d -- the key is to open multiple windows and add an `app.on('browser-window-focus') listener that accesses window.id.

* fix: last commit didn't test the right thing.

The test needs to run in the main process to reproduce the
conditions reported in #14513
 2018-09-12 13:58:04 -05:00
Shelley Vohr
a8a610cb34
chore: remove only on deprecations api spec (#14564) 
* chore: remove only

* add option to ignore missing properties
 2018-09-11 23:00:41 -07:00
Aleksei Kuzmin
ce8e93bad3 tests: ignore nulls and undefined in the "util.promisify" test 2018-09-11 20:24:04 +02:00
Aleksei Kuzmin
56f5d6f8fa FIXME: tests: disable a "unhandledrejection" test of the remote module 2018-09-11 20:24:04 +02:00
Samuel Attard
dde194d853 Remove the memory property from getAppMetrics 
See 03d0bfd593 for more information
 2018-09-11 20:24:03 +02:00
Samuel Attard
14df89f214 Remove the 'getProcessMemoryInfo' API 
* Underlying APIs have been removed in Chromium
  * https://chromium-review.googlesource.com/c/chromium/src/+/969089
  * https://chromium-review.googlesource.com/c/chromium/src/+/953723
  * https://bugs.chromium.org/p/chromium/issues/detail?id=819289
* https://github.com/electron/electron/projects/11#card-11509601
 2018-09-11 20:21:32 +02:00
Robo
14ed71fa1b fix: use render client id to track deleted render process hosts (#14520) 
* fix: use render client id to track deleted render process hosts

Instead of relying on OS process id, which may not be unique
when a process is reused, we rely on the renderer client id
passed by the content layer when starting the renderer process
which is guaranteed to be unique for the lifetime of the app.

* fix: store context id as int64_t

Ensuring that it doesn't wrap easily with a large number
of context creation on some malformed web pages.
 2018-09-11 11:18:10 -07:00
Shelley Vohr
2157d09956
chore: refactor deprecation apis (#14495) 2018-09-11 11:16:49 -07:00
Milan Burda
38419e3a6a chore: address TODO for WebContents.prototype.setSize / reportRemovedAttribute removal (#14517) 
* chore: remove WebContents.prototype.setSize

* chore: remove reportRemovedAttribute

* chore: remove unused fixtures
 2018-09-11 17:58:57 +10:00
Milan Burda
58577bd431 feat: add options to webContents.loadFile (#14515) 2018-09-11 17:56:49 +10:00
Milan Burda
dcd580b6cf chore: remove app.makeSingleInstance / releaseSingleInstance (#14518) 2018-09-10 16:33:36 +10:00
Alexey Kuzmin
98eee52fac Revert "fix: re-enable power monitor test (#14458)" (#14506) 
This reverts commit 567f8a7583.
 2018-09-08 19:37:19 -05:00
Charles Kerr
567f8a7583 fix: re-enable power monitor test (#14458) 
* fix: re-enable power monitor test

* update test for correct return type

* fix: mocha 'after' hook of dbus powerMonitor test
 2018-09-07 15:23:27 -07:00
Nitish Sakhawalkar
a2ab0d8ebe fix: notify focus change right away rather not on next tick (#14453) 
* fix: Notify focus change right away, not on next tick

* fix: emit the JS blur/focus events on next tick to avoid race condition

* address feedback from review

* fix: bind deferred Emit() calls to a WeakPtr

This is so that the deferred Emit() calls will be canceled
if the TopLevelWindow is destroyed.

* chore: remove wip/test code cruft

* fix: make linter happy

* Enable disabled tests

* refactor: cleaner impl of EmitEventSoon()

* Revert "Merge branch 'fix-win-focus' of github.com:electron/electron into fix-win-focus"

This reverts commit 90576806eb271d059f0a215c67e9b4b04f7396a4, reversing
changes made to 9c13e47779a3af78fe0970c1f3d6cd040a5354e6.

* Restore 704722c1, which was removed in error.

We apologise again for the fault in the subtitles. Those responsible for sacking the people who have just been sacked have been sacked.
 2018-09-07 13:21:58 -05:00
Alexey Kuzmin
c7bec13069 test: refactor the "util.promisify" test (#14491) 2018-09-07 10:13:10 -05:00
Robo
35a1849e31 chore: enable debugger api specs (#14475) 2018-09-07 00:44:22 +10:00
Robo
8441d09a18 chore: refactor webContents module isCurrentlyAudible api spec (#14410) 2018-09-05 16:00:05 -05:00
Milan Burda
c63014c256 refactor: use loadFile when appropriate in tests (#14422) 2018-09-04 09:50:53 -05:00
Cheng Zhao
10176c71ff
fix: webview.focus() should move page focus to webview (#14427) 2018-09-03 11:41:54 +09:00
Milan Burda
c17a1b37ea feat: add event.senderId property to IPCs sent via ipcRenderer.sendTo (#14395) 2018-08-31 20:13:51 -05:00
Shelley Vohr
dac435b411 test: update power/notification specs to expect (#13497) 
* spec: update power/process specs to expect

* Address comments
 2018-09-01 08:52:32 +12:00
Robo
32158ca5dd chore: refactor context isolation spec (#14394) 
* spec: refactor BrowserWindow module contextIsolation option

* spec: check for serialzation in isolated renderers separately
 2018-09-01 08:51:29 +12:00
Milan Burda
3a79eacb6f refactor: don't expose CallbacksRegistry as an internal module (#14389) 2018-08-31 11:29:00 -07:00
Milan Burda
5a0770f1d3 fix: allow Tray with title only (without icon) on Mac (#13851) 2018-08-30 21:16:56 +12:00
Cheng Zhao
459a2304b4 fix: emit focus/blur events for webview (#14344) 
* fix: emit focus/blur events for webview

* test: webview can emit focus event
 2018-08-28 13:35:44 -05:00
Robo
edd5c4b9bb fix: use OS process handle to clear object registry (#14324) 
RenderProcessHost switch can happen between ipc calls when
speculative process are invvolved, which will lead to deletion
of entries on current context. Use OS process handles to
uniquely associate a destruction handler for a render process.
 2018-08-28 13:32:46 -05:00
Samuel Attard
68da311ed1 feat: add session.setPermissionCheckHandler (#13925) 
* feat: add session.setPermissionCheckHandler to handle syncornous permission checks vs requests

* spec: add tests for session.setPermissionCheckHandler

* docs: add docs for session.setPermissionCheckHandler

* feat: add mediaType to media permission checks

* chore: cleanup check impl
 2018-08-28 09:05:08 -05:00
Milan Burda
a08ca9defb fix: don't crash on tray.setContextMenu(null) (#14322) 2018-08-27 11:58:47 -05:00
Aleksei Kuzmin
4943f9fc14 tests: disable "app moduele > app.exit(exitCode) > closes all windows" 2018-08-27 16:21:12 +02:00
Aleksei Kuzmin
1293b463ba tests: refactor "app module" tests 2018-08-26 16:54:51 +03:00
Emmanuel Kimmerlin
5f6706ac33 feat: BrowserWindow.getNormalBounds() (#13290) 
* First commit

* Add Mac support (1st attempt)

* Add Mac support (2nd attempt)

* Simplify tests

* Restore window state !

* Looking at other tests, seems minimize, maximize, fullscreen are skipped when in CI

* Fix Mac tests

* Restore tests in CI

* Fix typo

* widget getRestoredBounds not working on Mac !!

* widget getRestoredBounds not working on Mac !!

* Add IsNormal function

* Add IsNormal

* IsNormal => isNormal

* Deactivate fullscreen on Mac. Do not receive leave-fullscreen event

* Set default original_frame_

* Set default original_frame_

* Fix Mac
 2018-08-24 14:33:27 -07:00
Jeremy Apthorp
c452be02b9 refactor: properly report on skipped native modules tests (#13894) 2018-08-24 14:24:24 -07:00
Milan Burda
e6e3ccfc50 refactor: use std::string instead of base::string16 for IPC channel names (#14286) 2018-08-24 10:30:37 -05:00
Robo
bce5bd87a8 fix: opt into location services once device service has been started (#14253) 
* fix: opt into location services once device service has been started

* refactor: provide fake location provider to mock geolocation reponses

* chore: add spec for navigator.geolocation api using fake location provider
 2018-08-23 08:51:46 -07:00
Milan Burda
fc85d02786 feat: expose missing process APIs in sandboxed renderers (#13505) 2018-08-21 11:05:45 -07:00
Troy
5ea05ddee7 fix: Stricter Testing For Menu Items (#13992) 
This PR includes stricter testing for empty objects so that false context menus are not created along with the tests to ensure future compatibility.
 2018-08-17 13:10:14 -07:00
Cheng Zhao
dd5b8769be fix: use OOPIF for webview tag (#13869) 
* fix: use OOIF for webview tag

* fix: do not call GetNativeView for webview

* fix: OOIPF webview's WebContents is managed by embedder frame

* fix: guest view can not be focused

* fix: clear zoom controller when guest is destroyed

* fix: implement the webview resize event

The webview is no longer a browser plugin with the resize event, use
ResizeObserver instead.

* test: disable failed tests due to OOPIF webview

* fix: embedder can be destroyed earlier than guest

This happens when embedder is manually destroyed.

* fix: don't double attach

* fix: recreate iframe when webview is reattached

* fix: resize event may happen very early

* test: some tests are working after OOPIF webview

* chore: remove unused browser plugin webview code

* fix: get embedder via closure

When the "destroyed" event is emitted, the entry in guestInstances would be
cleared.

* chore: rename browserPluginNode to internalElement

* test: make the visibilityState test more robust

* chore: guestinstance can not work with OOPIF webview

* fix: element could be detached before got response from browser
 2018-08-16 15:57:40 -07:00
John Kleinschmidt
828e317360 Fix flaky sandbox tests 
Windows apparently has issues running opening two windows at once which is causing flakiness on the mixed sandbox tests.
 2018-08-13 09:30:20 -07:00
Shelley Vohr
590ae5cd29
fix: re-enable mixed-sandbox tests 2018-08-12 21:29:29 -07:00
Shelley Vohr
b785f45852
fix: override fs.realpathSync.native and fs.realpath.native (#14031) 
* fix: override fs.realpathSync.native and fs.realpath.native
* spec: test new native functions
 2018-08-12 00:10:55 -07:00
Milan Burda
702cc84bd3 Don't pass preloadPath via ELECTRON_BROWSER_SANDBOX_LOAD for security reasons (#13031) 2018-08-10 17:19:49 -05:00
Husayn
19cb5bad94 feat: Add creationTime function to process (#13542) 
* Add process creation time

* Making docs clear for process creation time

* Address comments for process creation time

* Add process info cc file

* fixing comments around documentation

* Update doc for return val

* Capitalize number in docs

* chore: bump electron-typescript-definitions
 2018-08-10 09:03:30 -05:00
Shelley Vohr
7c7543cb39 spec: re-enable app.getAppMetric API (#13962) 2018-08-09 13:35:29 -05:00
Milan Burda
9a1ad2b93f fix: ipcRemote.sendSync regression after moving away from JSON for return values (#13941) 2018-08-09 19:45:10 +10:00
Dominic
a7052efaf4 fix: make menu.popup options optional (#13977) 
* add empty object as default param for options

* update docs

* add spec for optional options

* fix: add null check for options
 2018-08-08 17:38:52 -05:00
Jeremy Apthorp
e6e621515f chore: disable flaky isCurrentlyAudible test (#13970) 2018-08-07 14:23:48 -05:00
Milan Burda
f904057104 fix: add missing "simple" property in several APIs to prevent proxying of return values (#13905) 
* fix: add missing "simple" property in several APIs to prevent proxying of return values

* add tests
 2018-08-03 12:07:27 -07:00
Jeremy Apthorp
c068bc7d3d test: make nativeImage relative path test robust to different cwd 2018-08-01 15:19:26 -07:00
Jeremy Apthorp
a4f02724bf refactor: use env var to skip native module tests on win32/debug (#13890) 2018-08-01 13:33:13 +10:00
Samuel Attard
4990b3990b
spec: add more assertions to help smoke out the close all window failures (#13868) 2018-08-01 13:32:07 +10:00
Milan Burda
c52b3d921e fix: some APIs modified for ASAR support cannot be util.promisify'ed (#13845) 2018-08-01 13:06:48 +10:00
Jeremy Apthorp
3bdff2d238
feat: allow setting window shape (#13789) 
This binds Widget::SetShape, an API that already exists in Chromium (for
Windows and Linux). It's a more reliable method of having some parts of
your window be "click-through" than the current `setIgnoreMouseEvents`
API, which messes around with the `WS_EX_LAYERED` window style on
Windows, causing strange bugs and incompatibility with hardware
acceleration.
 2018-07-30 13:37:40 -07:00
Alexey Kuzmin
69f6bd921b chore(tests): allow usage of deprecated APIs in tests (#13659) 2018-07-30 11:27:58 +10:00
Milan Burda
39c5c200ba fix: util.promisify(setTimeout) (#13840) 2018-07-30 11:14:04 +10:00
Milan Burda
db38c8b620 Fix process.execPath returning parent process path instead of the helper in sandboxed renderer (#13839) 2018-07-30 11:13:42 +10:00
Birunthan Mohanathas
a42ca9eecc feat: Add BrowserWindow.setWindowButtonVisibility() 
Fixes #12701 and supersedes #13131.

Ideally we would have added `setTitleBarStyle()`, but that is a
significantly more involved change. For example, consider the case where
we switch from `hidden` to `normal`. We would not only have to show the
traffic light buttons, we would also have to switch the window from a
frameless to a framed window and deal with various other window state.
Lets instead implement a simple solution for #12701.
 2018-07-25 10:12:27 -07:00
Aleksei Kuzmin
ea16445be7 chore: [tests] update some BrowserWindow tests 
- manually close an existing windows before creating a new one.
  We have to do it because the `afterEach` hook doesn't get called
  if a test fails.
- add some async/await goodies
 2018-07-24 10:02:54 -07:00
Cheng Zhao
305e3aad40
refactor: remove private webContents.getId() API (#13674) 2018-07-23 18:08:36 +09:00
Cheng Zhao
a88cdf2d1f
spec: suppress mixed-sandbox test in Windows CI (#13769) 2018-07-23 18:08:06 +09:00
Cheng Zhao
9d6f1a372e
fix: create WebContents for webview on request (#13713) 2018-07-21 11:11:28 +09:00
John Kleinschmidt
613b03c3c7 build: disable found-in-page event test 
On Windows release builds, the found-in-page event test causes the test suite to hang.  If the test is run individually, it works fine, but running it as part of the whole test suite causes the test suite to hang.  This works around the issue in #13704 by temporarily disabling that test.
 2018-07-18 14:59:46 -04:00
Samuel Attard
777d0113d5
fix: create a window capturer correctly (#13689) 
* fix: create a window capturer correctly

We were incorrectly creating two screen capturers instead of a window
capturer

* spec: ensure dc tests pass

* spec: enable all tests after verifying dc tests work
 2018-07-17 14:20:50 +10:00
Cheng Zhao
222291631d spec: openDevTools should not crash for frameless window 2018-07-16 10:23:43 +09:00
PalmerAL
ffc15e02a6 fix: add native function to create preload script (#13032) 
* add native function to create preload script

* add tests

* fix formatting

* fix tests

* rerun CI
 2018-07-13 11:17:11 +09:00
John Kleinschmidt
facb210f64
Merge pull request #13494 from electron/expect-short-specs 
chore(spec): convert smaller specs to expect
 2018-07-12 08:45:34 -04:00
Felix Rieseberg
deedf6c3f4 feat: Add isCurrentlyAudible() to WebContents (#13614) 
* 🔧 Add isCurrentlyAudible() to WebContents

* ❤️ Implement feedback, use await to wait for event

* 👷 Add missing imports
 2018-07-12 21:35:11 +10:00
Jeremy Apthorp
bdceea6aca fix: enable spell checking, which broke in upgrade to ch66 
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.

Added the first (!) test for spellchecking, too.

Fixes #13608.

[1]: 03563dd163
 2018-07-11 10:27:56 -07:00
Shelley Vohr
d5d76c56ed
address feedback 2018-07-10 14:20:03 -07:00
Tomas Rycl
9b6a37ead7 test: Better path compare than just strings (#13548) 
* Better path comparision than just strings

* Linter fix

* Resolving paths first to always obtain absolute path so path.relative() can work

* Using assert.ok which better fits the test

* No need to resolve parameters of path.resolve

* Added assertion to type of returned path for download item
 2018-07-10 21:38:11 +10:00
Cheng Zhao
35b867ff7d Fix failed devtools tests due to fs.statSyncNoException not working (#13584) 
* Revert "spec: disable the i18nString test"

This reverts commit 86c79653de.

* update node to fix fs.statSyncNoException
 2018-07-09 09:38:48 -05:00
Jeremy Apthorp
f50f8e3f3d chore: [gn] fix CSP warning in debugger API test (#13541) 
There's an attempt to suppress the warning in `spec/static/main.js`, which
sets `process.env.ELECTRON_DISABLE_SECURITY_WARNINGS`. However, it sets the
variable too late in the boot process: by the time that line in main.js has
run, a child zygote has already been booted. `test.py` works around this by
setting that environment variable outside of the test process, to ensure that
it gets propagated to all children.

I've been running the GN tests directly with `./out/Default/electron
electron/spec`, rather than through the wrapper script, and the
`api-debugger-spec.js` tests were failing, because they depend on a particular
log message being the first one emitted, and the CSP warning was causing that
test to fail, since it wasn't being correctly suppressed.

Instead of writing another wrapper script, this just fixes the underlying thing
that the warning is complaining about, which I think is reasonable because the
test's pass/fail depends on this specific behaviour.
 2018-07-06 15:01:33 -04:00
Cheng Zhao
86c79653de spec: disable the i18nString test 
It is failed because of fs.statSyncNoException, I'll fix it in another
PR.
 2018-07-06 09:07:56 +09:00
Cheng Zhao
56c24406d6 spec: enable back devtools tests 2018-07-06 09:07:56 +09:00
Hari Juturu
eb223f8bc3 Enable webview in sandbox renderer (#13435) 
* Enable webview in sandbox renderer
Security: Inherit embedder prefs onto webview

* cache lastwebprefs
 2018-07-03 02:06:26 +10:00
Shelley Vohr
42d173b343
spec: convert menu specs to expect (#13485) 
* spec: convert menu-item spec to expect

* spec: convert menu spec to expect
 2018-06-30 00:25:28 -07:00
Cheng Zhao
e42c6d3eb7
fix the crash when loading site with jquery (#13475) 2018-06-29 09:42:04 +09:00
Shelley Vohr
9489401e7d
spec: convert smaller specs to expect 2018-06-28 15:40:30 -07:00
Shelley Vohr
fa0704665f
test: temporarily disable failing specs (#13470) 2018-06-27 14:15:24 -07:00
Shelley Vohr
f9e2ec43d0
fix: deprecate properties in app.getAppMetrics() (#13446) 
* fix: deprecate properties in app.getAppMetrics()

* address feedback from review

* fix deprecated property location

* simplify test
 2018-06-26 23:47:01 -07:00
Cheng Zhao
44aad039c6 fix: do not expose Node's external strings (#13438) 2018-06-27 10:18:09 +10:00
Alexey Kuzmin
f4039d82c3 spec: rewrite and enable a webview's disableguestresize attr test (#13428) 2018-06-26 08:38:04 -07:00
Alexey Kuzmin
10a174fc6a spec: refactor helper closeWindow() function (#13337) 2018-06-22 00:43:15 +10:00
Alexey Kuzmin
b9da1575f0 spec: enable a disabled test (#13346) 2018-06-22 00:42:55 +10:00
Felix Rieseberg
562eddf0e9 test: Upgrade spec dependencies (#13310) 
* 📦 Update mocha, mocha-junit-reporter

* 📦 Update graceful-fs, multiparty, q, walkdir

* 📦 Update basic-auth

* 📦 Update ws

* 📦 Update dbus-native

* 📦 Upgrade yargs

* 🔒 Run `npm audit fix`

* 🔧 Fix websocket API change
 2018-06-20 17:18:24 +10:00
John Kleinschmidt
fc12b5cab3
Merge pull request #13283 from jack-teng1/fix-asar-pack-cant-find-module 
fix: can't load module error when app is packaged
 2018-06-19 14:58:37 -04:00
Heilig Benedek
f643ce4f66 revert: frame subscriber deprecation and re-enable tests 2018-06-19 19:49:44 +02:00
Jack Teng
3044607746 spec: fix asar spec due to change in node.js 
node.js rename the internalModuleReadFile to internalModuleReadJSON
change spec to reflect this change
 2018-06-19 10:42:21 -07:00
John Kleinschmidt
36c1e4cd75
Merge pull request #13267 from electron/expect-debugger-spec 
spec: convert debugger spec to expect
 2018-06-19 11:22:47 -04:00
John Kleinschmidt
faef453df5
Merge branch 'master' into expect-debugger-spec 2018-06-19 11:22:25 -04:00
Shelley Vohr
cba3a9fcce spec: convert deprecations to expect (#13268) 
* spec: convert deprecations to expect

* address feedback from review
 2018-06-19 10:22:08 -05:00
Shelley Vohr
9a79889692 spec: convert ipc specs to expect (#13273) 
* spec: convert ipc specs to expect

* fix buffer value comparison
 2018-06-19 10:21:50 -05:00
John Kleinschmidt
0219ef0feb
Merge pull request #13269 from electron/expect-desktop-capturer-spec 
spec: convert desktop capturer to expect
 2018-06-19 11:21:13 -04:00
Aleksei Kuzmin
5151a04613 spec: slightly rewrite webview tests 2018-06-19 13:27:49 +02:00
Aleksei Kuzmin
bbc8d50799 spec: add helper functions for async/await tests 2018-06-19 13:27:43 +02:00
Samuel Attard
efdf4f44c8 Remove stray .only 2018-06-19 11:49:46 +10:00
Samuel Attard
650631421f re-enable desktop capturer 2018-06-19 11:49:46 +10:00
Aleksei Kuzmin
25e5c174f5 Disable a test 2018-06-19 11:49:46 +10:00
Aleksei Kuzmin
b70ca6309c Disable a test 2018-06-19 11:49:46 +10:00
Aleksei Kuzmin
8f4d6a1995 Rewrite and enable one of the webview tests 2018-06-19 11:49:46 +10:00
Aleksei Kuzmin
ad74fb9210 Enable a test 2018-06-19 11:49:46 +10:00
Aleksei Kuzmin
da7cfba357 Enable Desktop Capturer tests 2018-06-19 11:49:46 +10:00
Aleksei Kuzmin
10c5141da0 Enable a few tests 2018-06-19 11:49:46 +10:00
Samuel Attard
10160b369b FIXME: getAppMetrics fails on windows CI 2018-06-19 11:49:46 +10:00
Samuel Attard
76f26341bf powerMontor crashes linux ia32, re-disable 2018-06-19 11:49:46 +10:00
Samuel Attard
8200a132be Re-enable cookie specs and add custom cookie name/url validation 2018-06-19 11:49:46 +10:00
Samuel Attard
c4f80a6d89 Enable power monitor test for linux 2018-06-19 11:49:46 +10:00
Samuel Attard
10e0d9b198 Enable process resource test 2018-06-19 11:49:46 +10:00
Samuel Attard
e70b93ad91 Enable childprocess.fork asar specs, fixed during run_as_node fixes 2018-06-19 11:49:46 +10:00
Samuel Attard
bc8525d2f3 re-enable native module tests 2018-06-19 11:49:46 +10:00
Samuel Attard
d9ec885dbc Fixed the spawn tests with the RUN_AS_NODE tests 2018-06-19 11:49:46 +10:00
Samuel Attard
f43eafb94e Fixed the fork tests, remove comment 2018-06-19 11:49:46 +10:00
Samuel Attard
de5bdc8be4 Fix inspector tests, you can now have multiple inspector sessions 
Refs: https://github.com/nodejs/node/pull/20137
 2018-06-19 11:49:46 +10:00
Samuel Attard
9b37e7d988 Re-enable node fork specs 2018-06-19 11:49:46 +10:00
Aleksei Kuzmin
0b12e425bd FIXME: Disable powerMonitor tests 2018-06-19 11:49:46 +10:00
Aleksei Kuzmin
03a63a485f FIXME: Disable some of the focus related tests 
They all pass localy, so it must be a CI issue.
 2018-06-19 11:49:46 +10:00
Aleksei Kuzmin
e96d8b664d Skip one of the "chromium feature" tests 2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
1fae6a321c Skip crashReported tests on linux 2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
de6a5de914 Disable all failing tests 2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
417fe29dc0 Fix the media events test 
Playing a media now requires a user gesture.
See https://goo.gl/xX8pDD.
 2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
c786abf1e9 Add gfx:PointF support to mate::Converter 
It's needed by atom_api_screen, BuildPrototype function on Windows.
 2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
7886cfe408 FIXME: Disable "node feature child_process.fork" tests 2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
368734b8ab FIXME: Disable "node feature inspector" tests 2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
e240a16a20 FIXME: Disable "ses.cookies calls back with an error when setting a cookie with missing required fields" test 2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
4a08779bc8 FIXME: Disable a couple of "debugger module debugger.sendCommand" tests 2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
3ca288aba4 FIXME: Disable "BrowserWindow module extensions and dev tools extensions works when used with partitions" test 2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
6c0b5cd76c FIXME: Disable "BrowserWindow module beginFrameSubscription method" tests 2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
9b9a818c43 FIXME: Disable one of the <webview> tag tests. 2018-06-19 11:49:44 +10:00
Aleksei Kuzmin
7e4c0b304b Enable a few tests 2018-06-19 11:49:44 +10:00
Aleksei Kuzmin
32ff2ff8fb FIXME: Disable some of <webview> tag tests 2018-06-19 11:49:44 +10:00
Aleksei Kuzmin
a45b1a9205 FIXME: Disable a couple of webContents module tests 2018-06-19 11:49:44 +10:00
Aleksei Kuzmin
123b35a7f1 FIXME: Disable "asar package child_process.fork" tests 2018-06-19 11:49:44 +10:00
Aleksei Kuzmin
77ae8b65f7 FIXME: Disable desktopCapturer tests 2018-06-19 11:49:44 +10:00
deepak1556
7b47d69efe Remove did-get-response-details and did-get-redirect-request events 
https://chromium-review.googlesource.com/c/chromium/src/+/805008
https://chromium-review.googlesource.com/c/chromium/src/+/786320
 2018-06-19 11:49:41 +10:00
Zhuo Lu
ab24a1e36d feat: netLog API for dynamic logging control (#13068) 
* Introduce `net.{start|stop}Logging()`

- Slight regression right now as Electron won't automatically start logging net-logs at launch, will soon be fixed
- To implement callback for async controls

* Add `net.isLogging` & optional callback param for `net.stopLogging()`

* Fix small regression on --log-net-log

--log-net-log should work again

* Error on empty file path

* Only start with valid file path

* Remove unused var

* Allow setting log file path before URLRequestContextGetter starts logging

* Add net log tests

* Remove redundant checks

* Use brightray::NetLog

* Clean up code

* Should automatically stop listening

* 🎨 Attempt to fix styles

* Only run non-null callback

* Dump file to tmpdir

* Simplify net log spec

Spawned Electron process on Linux CI can fail to launch

* Separate netLog module

* Remove net logging test from net spec

* Add tests for netLog

* Fix header guard

* Clean up code

* Add netLog.currentlyLoggingPath

* Callback with filepath

* Add test for case when only .stopLogging() is called

* Add docs

* Reintroduce error on invalid arg

* Update copyright

* Update error message

* Juggle file path string types
 2018-06-19 11:45:58 +10:00
Shelley Vohr
b4cce8e240
spec: convert IAP and GC specs to expect (#13272) 
* spec: convert IAP and GC specs to expect

* address review
 2018-06-18 09:50:37 -07:00
Shelley Vohr
c65844a7d0
address review feedback 2018-06-18 08:56:24 -07:00
Shelley Vohr
314071d79f
feedback from review 2018-06-18 08:12:54 -07:00
Shelley Vohr
fe94bf7c1d
spec: convert dialog spec to expect (#13271) 2018-06-18 07:56:03 -07:00
Milan Burda
2eb5b751f3 exit HTML fullscreen when window leaves fullscreen (#13090) 2018-06-18 16:48:20 +09:00
Shelley Vohr
2c2e8317de
spec: convert desktop capturer to expect 2018-06-17 16:00:28 -07:00
Shelley Vohr
4dec5ec5f9
spec: update browser-view spec to expect (#13238) 
* spec: update browser-view spec to expect
 2018-06-17 15:56:04 -07:00
Shelley Vohr
79c2d22c25
remove assert require 2018-06-17 15:37:16 -07:00
Shelley Vohr
8d5fc61c12
spec: update browser-window-affinity spec to expect (#13239) 
* spec: update browser-window-affinity spec to expect

* final cleanup
 2018-06-17 15:36:30 -07:00
Shelley Vohr
e023035393
spec: convert debugger spec to expect 2018-06-17 15:35:24 -07:00
Shelley Vohr
c5c571f8ec
spec: update callback registry spec to expect (#13263) 
* spec: update callback-reg-spec to sexpect

* remove stray only

* remove redundant assertions
 2018-06-17 15:08:17 -07:00
Shelley Vohr
0ef0e69f03
spec: convert clipboard spec to use expect (#13266) 2018-06-17 14:47:51 -07:00
Shelley Vohr
a0d252870c
spec: update auto-updater spec to expect (#13237) 
* spec: update auto-updater to expect
 2018-06-16 00:28:28 -07:00
Shelley Vohr
91559191c9
spec: update app spec to assert (#13155) 
* convert app spec from assert to expect and add dirty-chai
 2018-06-14 09:44:27 -07:00
Alexey Kuzmin
6a59b37bea spec: better texts for the Crash Reporter tests (#13227) 
* Better failure messages for a Crash Reporter test

* Add a TODO
 2018-06-14 19:24:28 +10:00
Alexey Kuzmin
dee9aef975 Add "enable_desktop_capturer" build flag (#13133) 
* Make it possible to disable a module for a renderer

* Put DesktopCapturer API under a build flag

The name is "enable_desktop_capturer".
Enabled by default.
 2018-06-13 11:15:34 -05:00
Thiago de Arruda
6ff111a141 perf: don't use JSON to send the result of ipcRenderer.sendSync. (#8953) 
* Don't use JSON to send the result of `ipcRenderer.sendSync`.

- Change the return type of AtomViewHostMsg_Message_Sync from `base::string16`
  to `base::ListValue`
- Adjust lib/browser/api/web-contents.js and /lib/renderer/api/ipc-renderer.js
  to wrap/unwrap return values to/from array, instead of
  serializing/deserializing JSON.

This change can greatly improve `ipcRenderer.sendSync` calls where the return
value contains Buffer instances, because those are converted to Array before
being serialized to JSON(which has no efficient way of representing byte
arrays).

A simple benchmark where remote.require('fs') was used to read a 16mb file got
at least 5x faster, not to mention it used a lot less memory.  This difference
tends increases with larger buffers.

* Don't base64 encode Buffers

* Don't allocate V8ValueConverter on the heap

* Replace hidden global.sandbox with NodeBindings::IsInitialized()

* Refactoring: check NodeBindings::IsInitialized() in V8ValueConverter

* Refactor problematic test to make it more reliable

* Add tests for NaN and Infinity
 2018-06-13 17:38:31 +10:00
Milan Burda
6ad0a22602 Add process.getHeapStatistics() (#13183) 2018-06-10 22:00:36 +10:00
Alexey Kuzmin
0d5e98a201 Slightly rewrite <webview> tag tests (#13122) 2018-06-01 10:56:48 +02:00
Charles Kerr
b89fe86fa1
Merge pull request #13050 from electron/3.0.0-deprecations 
chore: removal of 3.0.0 deprecations
 2018-05-30 09:25:36 +02:00
Shelley Vohr
d40cce92bf
remove deprecated signature tests 2018-05-29 11:42:03 -04:00
Shelley Vohr
2660859434
update signature for setCertificateVerifyProc in session spec 2018-05-29 10:54:27 -04:00
Charles Kerr
2275625e1a feat: warn if deprecated property is already set 2018-05-29 15:58:02 +02:00
Charles Kerr
61fac1bbc1 test: add tests for deprecate.property() 2018-05-29 15:40:48 +02:00
Milan Burda
4cfe5ecaa4 add proper support for typed arrays in remote (#13055) 2018-05-24 21:05:46 +09:00
Aleš Pergl
93bee69266 Remove command line argument black-list (#13039) 
* Remove command line argument black-list

Instead block all arguments following a URL.

* Updated tests
 2018-05-22 11:51:03 -05:00
Shelley Vohr
560c0e72e6
Fix vulnerabilities both top-level and in spec (#13029) 
* fix dependency vulnerabilities

* fix vulnerabilities in spec
 2018-05-21 21:15:18 -07:00
Cheng Zhao
300c7a4b04 add tests for View and WebContentsView 2018-05-21 10:53:09 +09:00
Alexey Kuzmin
fc34076c2b Refactor <webview> tag tests (#12886) 2018-05-14 17:00:49 -05:00
Alexey Kuzmin
d5dfb19508 Update some tests (#12917) 
* Use Chai for webview tests

* Slightly rewrite one of the <webview> tests

"dom-ready event" > "throws a custom error..."

* Use Chai for BrowserWindow tests

* Rewrite BrowserWindow.addDevToolsExtension tests
 2018-05-14 13:17:31 -05:00
Heilig Benedek
eae0674f61 Match chromium's workaround when setting size of unresizable windows 2018-05-12 17:37:31 +02:00
Shelley Vohr
daf75dd375
add app.isPackaged (#12656) 
* add isPackaged method

* add false test case for app.isPackaged()

* document add.isPackaged()

* check isPackaged() without fs call

* convert to non-method property

* document app.isPackaged as a property

* update tests for app.isPackaged

* remove unused fs require

* clarify docs for isPackaged()
 2018-05-07 23:15:31 -07:00
Samuel Attard
5b5c161601
feat: new makeSingleInstance API (#12782) 
* Refactor app.makeSingleInstance
* new API `app.isPrimaryInstance()`
* new API `app.isSingleInstance()`
* new event `app.on('second-instance')`
* deprecated old syntax `app.makeSingleInstance(cb)`
* deprecated old syntax of `app.makeSingleInstance() --> bool` in favor
of `app.isPrimaryInstance()`
* Fix spec, we don't need process.nextTick hacks any more
* Make deprecation TODO for the return value of makeSingleInstance
* Refactor makeSingleInstance to requestSingleInstanceLock and add appropriate deprecation comments
* I swear this isn't tricking the linter
* Make const
* Add deprecation warnings for release, and add to planned-breaking-changes

BREAKING CHANGE
 2018-05-08 01:29:18 +10:00
Shelley Vohr
9c8952aef0
Add menu item order control (#12362) 
Add four new optional properties to menus in Electron. The four properties are:
'before'
'after'
'beforeGroupContaining'
'afterGroupContaining'

'before/after' - provides a means for a single context menu item to declare its placement relative to another context menu item. These also imply that menu item in question should be placed in the same “group” as the item.

'beforeGroupContaining/afterGroupContaining - provides a means for a single menu item to declare the placement of its containing group, relative to the containing group of the specified item.
 2018-05-05 09:37:29 -07:00
Alexey Kuzmin
3fd0ec99ae Better OSR tests (#12817) 
* Add features.isOffscreenRenderingEnabled()

* Use .isOffscreenRenderingEnabled() to determine if OSR is available

* Add a helper closeTheWindow() function

* Skip OSR tests if they are disabled
 2018-05-03 11:10:25 -05:00
Cheng Zhao
d46aa92f0b
make security-warnings tests more robust (#12757) 2018-05-01 14:28:55 +09:00
Cheng Zhao
e00b128a50
fix flaky security-warnings test (#12749) 2018-05-01 09:49:45 +09:00
Tatsuya Hiroishi
9c65abd746 handle remote exception (#12694) 
* add cause property to exception in callFunction

* update exceptionToMeta function

* add sender argument
* and cause property to return value

* update exception convert in metaToValue function

* add from and cause properties to the exception error

* unit test for remote exception
 2018-04-24 08:40:19 -04:00
Nitish Sakhawalkar
2579071b98 Deprecate did-get-response-details and did-get-redirect-request (#12615) 
* Deprecate webContents events did-get-response-details and did-get-redirect-request.

* Update guest view files

* Update webview tag docs and update specs

* Update deprecate.event function

* Update comment

* Update more

* Update documentation for other deprecated event
 2018-04-23 14:46:12 -05:00
Alexey Kuzmin
fcc82ebd35 Add "app.whenReady()" (#12652) 
* Make "chai-as-promised" avaialble in tests

* Add "app.whenReady()"

Closes #9561.
 2018-04-20 17:09:23 +10:00
Jeremy Apthorp
97fb15ac49 Enable WebFrame method forwarding in sandboxed renderers (#12538) 
* Enable WebFrame method forwarding in sandboxed renderers

Fixes #9073

* Non-change to kick CI
 2018-04-12 11:57:40 +10:00
Nitish Sakhawalkar
6fc819dae1 Fix transparency in capturePage (#12561) 
* Fix transparent window capture. Transparency is preserved and not converted to black pixels anymore

* Add test to make sure aplha channel exists in captured image
 2018-04-10 19:07:15 +09:00
Andrew MacDonald
6bfb122cd1 Add a display_id parameter to the desktopCapturer API. (#12417) 
* Add a screen_api_id parameter to the desktopCapturer API.

When using the DirectX capturer on Windows, there was previously no way
to associate desktopCapturer/getUserMedia and electron.screen API
screens. This new parameter provides the association.

* Fix non-Windows build.

* Fix Mac.

* Fix Mac harder.

* JS lint

* clang-format C++ code.

* IWYU

* display_id, Linux comment, better test

* lint

* Fix tests on Linux.

* Add display_id documentation.
 2018-04-09 14:43:35 +09:00
Nitish Sakhawalkar
970f79e32f Check for devtools in BrowserWindow.getFocusedWindow() (#12526) 2018-04-06 09:21:32 -04:00
Robo
65e8199a93 Enable plznavigate aka browser side navigation (#12535) 
* enable plznavigate code path

* AtomBrowserClient::GetGeolocationApiKey returns the right default

* use IsLoadingToDifferentDocument to identify top level navigation in mainFrame

* use candidate site instance when available

* spec: don't test httpReferrer option for file origin

* update libcc ref

* affinity: only group same site in this mode

* plznavigate: don't emit did-get-response-details event for blob scheme
 2018-04-06 16:22:52 +09:00
Jeremy Apthorp
f0d08f4da1 Propagate referrer to new windows (#12397) 
* Propagate referrer to new windows

Fixes #9205

* Rearrange -new-window event arguments for backwards-compatibility

* Plumb referrer policy through guest-window-manager

* Document the Referrer structure and its uses

* Add tests for referrer in new windows

* Docs nits
 2018-04-05 18:13:24 -05:00
Adrien Fery
5486a65702 Improve in-app purchase for MacOS (#12464) 
* Add methods to finish transactions

* Add a method to get the product descriptions from the App Store

* Improve the documentation of a transaction structure

* Add a tutorial for In App Purchase

* Fix typo in In-App Purchase tutorial

* Fix style of In-App Purchase files

* Fix In-App-Purchase product structure conversion in amr64

* Fix code style in In-App Purchase tutorial documentation

* Fix typos in In-App Purchase documentation

* Fix typo in In-App Purchase spec

* Slight style fixes
 2018-04-05 15:33:13 +09:00
Nitish Sakhawalkar
fbff355742 Support for navigator.languages (#12419) 2018-04-02 12:47:00 +09:00
Cheng Zhao
f41cce96a3 Increase timeout for inAppPurchase test (#12403) 2018-03-22 08:47:29 -05:00
deepak1556
e24c0dda5d add features module to detect availability of build time features at runtime 2018-03-20 10:13:17 +03:00
deepak1556
4b39d17e5f move pdf viewer behind feature flag 2018-03-20 10:13:17 +03:00
deepak1556
f9de29ed8c Enable node crypto spec 2018-03-20 10:13:16 +03:00
Aleksei Kuzmin
d5ecbfc539 spec: Do not assume en-US locale to be the current 2018-03-20 10:13:16 +03:00
Nitish Sakhawalkar
524f56354c Fix webview resize test 2018-03-20 10:13:16 +03:00
deepak1556
80772c2419 FIXME: Disable node crypto spec 2018-03-20 10:13:15 +03:00
deepak1556
719980a948 REVIEW: remove device emulation ipc dependecny on rvh 2018-03-20 10:13:15 +03:00
Aleksei Kuzmin
490b1e2532 FIXME: Disable some tests to avoid crashes 2018-03-20 10:13:15 +03:00
Shelley Vohr
31d688ad3d
Check menu.popup options are an object (#12325) 
* check menu.popup options are an object

* Add a spec for menu.popup options check

* remove stray .only
 2018-03-17 06:31:10 +09:00
Birunthan Mohanathas
2681e769a6 Document BrowserView.{destroy,isDestroyed} (#12274) 2018-03-15 16:15:56 +09:00
Charles Kerr
c2673aa970 Set appropriate defaults for webview options (#12271) 
* Persist defaults to webPreferences object to JS land can read the inferred values instead of just user defined values

* Test inherited default propogation

* Refactor to remove coupling from fetching values and defaults

* Test description type

* Fix up tests
 2018-03-15 13:56:46 +09:00
Samuel Attard
9ed9885c8d
fix remote setInterval flake (#12263) 2018-03-14 14:51:47 +09:00
OJ Kwon
e7181eb89c feat(powerMonitor): expose interface to query system idle state (#11807) 
* feat(BrowserWindow): expose interface to query system idle state

* test(BrowserWindow): update test cases for querySystemIdle interface

* docs(BrowserWindow): add querySystemIdle interface documentation

* refactor(powerMonitor): move querySystemIdle into powerMonitor

* test(powerMonitor): split test cases for all platform
 2018-03-14 14:42:08 +09:00
Samuel Attard
90dc897f71 add missing report.length > 1 assertion (#12257) 2018-03-14 13:14:29 +09:00
Hari Juturu
704af29543 Exposing process.env status (#12166) 2018-03-14 12:01:40 +09:00
Robo
e741bc0577 fix crash when using getWebPreferences api with devtools webContents (#12254) 2018-03-14 11:19:22 +09:00
Samuel Attard
e62349cffb
Merge pull request #12253 from felixrieseberg/fix-last-crash-report 
fix: Ensure that `getLastCrashReport()` is actually the last crash report
 2018-03-14 10:36:27 +09:00
Felix Rieseberg
ee67211035 🔧 Linter's gotta lint 2018-03-13 17:41:02 -07:00
Felix Rieseberg
582ef30b4a 👷 Tests, how do they work 2018-03-13 17:35:55 -07:00
Felix Rieseberg
1b3568e66e 👷 Fancy test 2018-03-13 17:28:15 -07:00
Felix Rieseberg
3575dae75c 🔪 Cut typo 2018-03-13 16:58:40 -07:00
Felix Rieseberg
673335de4b 🔧 Actually test the method 2018-03-13 16:51:20 -07:00
deepak1556
c3bcb606a9 spec: isolate sw file scheme spec storage with temp partition 2018-03-14 02:03:55 +09:00
Charles Kerr
e400585a0e Apply further ES6 bikeshedding 2018-03-13 17:09:47 +09:00
Charles Kerr
e4d5ae53fc Add tests 2018-03-13 15:55:48 +09:00
Charles Kerr
86af20ded0
Linux named notifications (#12192) 
* Set name & desktop-entry on Linux notifications

* DBusMock now honors verbose mode flag

* Disable DBus Notification tests on ia32
 2018-03-12 09:33:06 +09:00
Cheng Zhao
cf36fdecbf Skip client-certificate test for Linux (#12189) 2018-03-09 14:43:49 +09:00
Cheng Zhao
cde0c1d418 Print detailed error for serviceWorker test (#12186) 2018-03-08 21:06:29 -05:00
John Kleinschmidt
134d3f98c9 Allow CI building on arm64 hardware 2018-03-08 09:53:47 -05:00
Hari Juturu
2f4fd3324b Preload doesn't load in sandboxed render if preload path contains special chars (#12037) 
* Adding missing headers

* adding ut

* Removing the file path exists check

* fixing test

* exposing window.require in UT
 2018-03-07 11:40:00 -05:00
Cheng Zhao
cc6bcb6c81 Fix some flaky tests in CI (#12153) 
* Guard whole InitPrefs with ScopedAllowIO

Saw a crash:
0 0x7f8d2f7d918d base::debug::StackTrace::StackTrace()
1 0x7f8d2f7d755c base::debug::StackTrace::StackTrace()
2 0x7f8d2f867caa logging::LogMessage::~LogMessage()
3 0x7f8d2fa157c7 base::ThreadRestrictions::AssertIOAllowed()
4 0x7f8d2f83453a base::OpenFile()
5 0x7f8d2f82a967 base::ReadFileToStringWithMaxSize()
6 0x7f8d2f82ad44 base::ReadFileToString()
7 0x7f8d2f846f73 JSONFileValueDeserializer::ReadFileToString()
8 0x7f8d2f84738c JSONFileValueDeserializer::Deserialize()
9 0x7f8d35a5d1f6 <unknown>
10 0x7f8d35a5c217 JsonPrefStore::ReadPrefs()
11 0x7f8d35a87d3e PrefService::InitFromStorage()
12 0x7f8d35a87c60 PrefService::PrefService()
13 0x7f8d35a91a10 PrefServiceFactory::Create()
14 0x000000e86e1b brightray::BrowserContext::InitPrefs()
15 0x000000c2bd64 atom::AtomBrowserContext::AtomBrowserContext()
16 0x000000c320db atom::AtomBrowserContext::From()
17 0x000000b4b8b5 atom::api::Session::FromPartition()

* Fix done being called twice in setInterval test

The callback passed to browser process is called asyncly, so it is
possible that multiple callbacks has already been scheduled before we
can clearInternval.

* Fix failing test when dir name has special chars

The pdfSource is not escaped while parsedURL.search is.

* Call done with Error instead of string

* Fix crash caused by not removing input observer

Solve crash:
0 libcontent.dylib content::RenderWidgetHostImpl::DispatchInputEventWithLatencyInfo(blink::WebInputEvent const&, ui::LatencyInfo*) + 214
1 libcontent.dylib content::RenderWidgetHostImpl::ForwardMouseEventWithLatencyInfo(blink::WebMouseEvent const&, ui::LatencyInfo const&) + 1350
2 libcontent.dylib content::RenderWidgetHostViewMac::ProcessMouseEvent(blink::WebMouseEvent const&, ui::LatencyInfo const&) + 44
3 libcontent.dylib content::RenderWidgetHostInputEventRouter::RouteMouseEvent(content::RenderWidgetHostViewBase*, blink::WebMouseEvent*, ui::LatencyInfo const&) + 1817

* Print detailed error

* Run tests after server is ready
 2018-03-07 14:40:27 +09:00
Charles Kerr
65ee977a86 Exit gracefully on linux (#12139) 
* Fix timing issue in singleton fixture.

Singleton now sends the "we've started" message out only after it's
received a `'ready'` event from `app`. Previously it sent the message
out immediately, resulting in the parent test trying to manipulate it
before Singleton's event loop was fully bootstrapped.

* Check for graceful exits on Linux, too.

Rewrite the "exits gracefully on macos" spec to run on Linux too.

* Check for graceful exits everywhere.

* Tweak comment

* Better error logging in api-app-spec.js. (#12122)

In the 'exits gracefully' test for app.exit(exitCode),
print the relevant error information if the test fails.

* Run the exit-gracefully test on macOS and Linux.

Windows does not support sending signals, but Node.js offers some
emulation with process.kill(), and subprocess.kill(). Sending signal 0
can be used to test for the existence of a process. Sending SIGINT,
SIGTERM, and SIGKILL cause the unconditional termination of the target
process.

So, we'll need a different approach if we want to test this in win32.
 2018-03-06 22:01:17 -05:00
Cheng Zhao
90bd1fd7e9 Native confirm/alert throws differently 2018-03-06 14:06:29 +09:00
Shelley Vohr
3635872f37
remove screen.getMenuBarHeight spec 2018-03-05 20:10:34 -05:00
Charles Kerr
e9808d138f
Better error logging in api-app-spec.js. (#12122) 
In the 'exits gracefully on macos' test for app.exit(exitCode),
print the relevant error information if the test fails.
 2018-03-06 03:13:47 +09:00
shelley vohr
dfa1dc43df
Merge pull request #12059 from electron/add-tabbedwindow-warning 
add warning when addTabbedWindow is called on self
 2018-02-28 01:18:10 -08:00
Shelley Vohr
bf491de9fe
fix styling and add spec 2018-02-28 00:22:42 -08:00
Cheng Zhao
35cbe9d140 Fix dockMenu not being referenced in JavaScript (#12062) 
* Fix dockMenu not being referenced in JavaScript

* spec: Test garbage collecting dock menu
 2018-02-26 22:15:06 -08:00
Cheng Zhao
f7786a9e48
Merge pull request #11230 from electron/upgrade-to-chromium-62 
Upgrade to Chromium 62
 2018-02-26 14:20:21 +09:00
shelley vohr
18362eb948 improve Menu and MenuItem testing (#12015) 
* split menu/menuitem and add some tests

* fix ipc send issue

* feedback: make tests less brittle

* clean up MenuItem accelerator and label tests
 2018-02-23 07:53:59 -06:00
Aleksei Kuzmin
dcb369ee46 Fail "navigator.serviceWorker" tests if WebContents crashes 2018-02-23 10:21:24 +09:00
Aleksei Kuzmin
fbd5e4c2b3 Disable the "ffi" module test 2018-02-23 10:21:24 +09:00
John Kleinschmidt
2a97e48465
Merge pull request #11968 from electron/refactor-menu-popup 
Refactor menu.popup
 2018-02-21 14:29:52 -05:00
Charles Kerr
5a25b88b50 Fix browserWindow detection in menu.popup() 2018-02-20 18:35:39 -06:00
Charles Kerr
708f39a1a5 update a few menu.popup() calls to use the new API 2018-02-20 14:02:24 -06:00
shelley vohr
846be03f1d remove support for hidden-inset (#11975) 2018-02-20 11:09:54 -06:00
Cheng Zhao
dc62e51ba4 Fix the cyclic reference in menu delegate (#11967) 
* Fix the cyclic reference in menu delegate

* Fix menu tests due to delegate change
 2018-02-20 10:11:35 -06:00
Shelley Vohr
fb7fb4972d
options all the things 2018-02-20 11:10:53 -05:00
shelley vohr
8d4bf3e29a
Merge pull request #11974 from electron/remove-setZoomLevelLimits 
remove setZoomLevelLimits
 2018-02-20 10:51:41 -05:00
shelley vohr
a2856db982 Remove nativeImage deprecated methods (#11978) 
* remove deprecated nativeimage methods

* remove .only from spec
 2018-02-20 09:15:27 -06:00
Shelley Vohr
211b542ae4
remove setZoomLevelLimits 2018-02-20 08:57:48 -05:00
Shelley Vohr
73ab87b87f
add new and changed specs 2018-02-19 20:59:47 -05:00
Shelley Vohr
9c52d273dd
add spec for menu.popup(window, callback) 2018-02-19 13:15:49 -05:00
Paul Frazee
01a6104727 Add download from custom protocol test (#11931) 2018-02-16 13:03:53 -05:00
Cheng Zhao
67fa13d7cf
Merge pull request #11925 from electron/squirrel-mac-cdn 
Update to use Squirrel.Mac that supports CDN releases
 2018-02-16 15:28:39 +09:00
Samuel Attard
a20b379f26 fix windows tests 2018-02-16 16:02:10 +11:00
Cheng Zhao
af92b04eb9
Merge pull request #11654 from sethlu/set-notification-close-button-text 
feat: Set macOS notification close button title
 2018-02-15 16:01:30 +09:00
Samuel Attard
6318cd781d Update to use Squirrel.Mac that supports CDN releases 2018-02-15 14:00:46 +11:00
shelley vohr
a55fd06aa2
Revert "Merge pull request #11737 from kwonoj/feat-cache-capacity" (#11906) 
This reverts commit 181169b743, reversing
changes made to baced3152f.
 2018-02-13 10:49:27 -05:00
Emmanuel Kimmerlin
9c1b47361f Add an "affinity" option to webPreferences 2018-02-13 15:18:55 +09:00
Samuel Attard
9bd7d53cf8 Handle empty handles (#11598) 
* Handle empty handles

* Close and dispose window at end of void test

* Dispose of existing window before running void 0 spec
 2018-02-12 14:46:29 -05:00
Samuel Attard
181169b743
Merge pull request #11737 from kwonoj/feat-cache-capacity 
feat(webframe): export set cache capacity interface
 2018-02-13 06:02:25 +11:00
Samuel Attard
b3234f634b Add ability to set arbitrary arguments in a renderer process (#11850) 2018-02-12 11:54:31 -06:00
Zhuo Lu
38d284590f Add Notification tests 2018-02-10 03:19:47 -08:00
Shelley Vohr
1e090b9ee7
remove .only 2018-02-08 13:50:44 -05:00
Shelley Vohr
f6d389b159
fix child process import 2018-02-08 13:50:19 -05:00
Shelley Vohr
e10b5e13e9
move spec to chromium_spec 2018-02-08 13:00:41 -05:00
shelley vohr
ca34978e73 add app.setLocale() (#11469) 
* infrastructure for setLocale via klang

* add documentation for setLocale

* add test for setLocale

* fix spec

* add spec and update docs

* fix carriage feeds on windows

* SetLocale() sets LC_ALL on Linux

* in SetLocale() on Linux, use g_setenv()

* fix tyop: '#ifdef OSX_POSIX'

* make the linter happy

* improvements from review
 2018-02-08 08:26:37 -06:00
shelley vohr
5240352326 Remove extra menu separators (#11827) 
* add function to remove leading/trailing separators

* change const  name for clarity

* add spec to check filtered separators

* clean method and add edge case spec per review
 2018-02-05 11:55:12 -06:00
shelley vohr
e6a5990b95
Merge pull request #11774 from nitsakh/fix-invalid-utf 
Handle invalid utf8 characters for debugger
 2018-02-05 12:44:41 -05:00
Thiago de Arruda
df6328e5d7 Add some tests for powerMonitor "shutdown" event 2018-02-05 15:21:31 +09:00
Felix Rieseberg
d586ef2f39 feature: Hot security tips (#11810) 
* 🔧 Add security issue detection (and logs)

* 🔧 Check for it on load

* 👷 Add some tests

* 👷 Make the linter happy

* 🔧 Allow them to be enabled by force

* 📝 Make message slightly prettier

* 🔧 Fix a typo in the code comment

* 🔧 Classic mistake

* 🚀 Optimize things a bit more

* 👷 Add tests, fix tests

* 📝 Document things

* 🔧 Make linter happy

* 🔧 One more piece of cleanup
 2018-02-03 07:50:12 -07:00
Nitish Sakhawalkar
62d2a3472f Fix test BrowserWindow.addTabbedWindow() (#11795) 
* Fix test BrowserWindow.addTabbedWindow()

* Address review comments
 2018-02-02 19:31:02 -07:00
Nitish Sakhawalkar
e411b49f4e Fix and update debugger UTF char test 2018-02-01 16:47:52 -08:00
Shelley Vohr
3d032c2b57
forgot to remove .only from spec 2018-01-27 12:38:55 -05:00
Shelley Vohr
3679a9c37a
fix event callback placement in spec 2018-01-27 12:36:51 -05:00
Shelley Vohr
e345342e36
add first pass at menu event specs 2018-01-27 11:23:46 -05:00
OJ Kwon
690a9e9483
test(webframe): add basic test case 2018-01-26 10:57:52 -08:00
Aleš Pergl
c49cb29ddf Disallow launching unknown apps via browser client. 
CVE-2018-1000006
 2018-01-22 16:49:30 -06:00
Nitish Sakhawalkar
ea2056b513 Replace arrow function 2018-01-17 15:27:11 +09:00
Nitish Sakhawalkar
7aefc73ffd Fix lint 2018-01-17 15:27:11 +09:00
Nitish Sakhawalkar
28f1abcb05 Change macos app termination process 2018-01-17 15:27:11 +09:00
Cheng Zhao
bd271cffb9 Throw when inAppPurchase is used on unsupported platforms 2018-01-10 18:53:55 +09:00
Cheng Zhao
ac6f895f64 Turn InAppPurchase into an EventEmitter 2018-01-10 16:37:05 +09:00
Cheng Zhao
bdeb979d41 spec: Simple tests for inAppPurchase module 2018-01-10 15:21:53 +09:00
deepak1556
fd297722a8 Note about incorrect usage of blink::SchemeRegistry methods 2018-01-02 16:37:10 +09:00
deepak1556
1912fbb073 reenable some specs 2018-01-02 16:37:08 +09:00
deepak1556
88e53b1b5e REVIEW: destroy process singleton on sequence where IO is allowed 2018-01-02 16:37:07 +09:00
deepak1556
c3154d86e0 FIXME: disable some specs 2018-01-02 16:37:07 +09:00
deepak1556
b4e6516ad8 fix dcheck failure with invalid UTF8 string conversion for base::Value 2018-01-02 16:37:05 +09:00
Cheng Zhao
46330ac2a9 Remove the closed event of Menu 
The callback of Menu.popup does more things, and there is actually no
request for the closed event.
 2018-01-01 17:22:07 +09:00
Cheng Zhao
73d78d345a Make callback work for old-style Menu.popup call 
While the old-style Menu.popup has been deprecated, it is still being
used widely in apps and even in Electron itself.
 2018-01-01 17:17:01 +09:00
Cheng Zhao
2ec3b8ce76 spec: callback for Menu.popup 2018-01-01 16:56:22 +09:00
Cheng Zhao
2e3d940749 Fix "test.py -g Menu" not working 2018-01-01 15:46:39 +09:00
Felix Rieseberg
5f4b62b6c8 feat: Allow testing of single spec modules (#11409) 
* 🔧 ES6 for the spec

* 👷 Allow testing of single modules

* ❤️ Implement feedback

* 📝 Add a testing doc

* 📝 Link to it

* 📝 Cleanup
 2017-12-28 06:18:33 -05:00
Cheng Zhao
75ac7d9ff2 spec: Add test for crypto operation 2017-12-27 20:37:04 +09:00
Heilig Benedek
5bf16c2495 remove async:true from menu tests 2017-12-20 15:41:12 +09:00
Heilig Benedek
ef7357dedc update tests for menu closed event and call cancel on closePopup 2017-12-20 15:40:07 +09:00
Heilig Benedek
14b65467d8 add test for menu closed event 2017-12-20 15:40:07 +09:00
Charles Kerr
a8b76e1a80
Merge pull request #11418 from electron/add-reg-defaults 
[WIP] add back systemPreferences.registerDefaults()
 2017-12-13 15:48:20 -06:00
Shelley Vohr
3fc844c15a
add loop to catch null values 2017-12-13 14:02:43 -05:00
Felix Rieseberg
317422f431 👷 Close popup in aftereach 2017-12-12 12:23:02 -08:00
Felix Rieseberg
c4ec8b4545 🔧 Feedback 2017-12-12 11:25:01 -08:00
Felix Rieseberg
76df41b5d0 👷 Properly test x vs y 2017-12-12 11:25:01 -08:00
Felix Rieseberg
ace558f54a 👷 Hence, better testing 2017-12-12 11:25:01 -08:00
Felix Rieseberg
5a658fa5f6 👷 Add a spec 2017-12-12 11:25:01 -08:00
Shelley Vohr
6252ce466c
remove failing badDefault 2017-12-12 13:39:38 -05:00
Shelley Vohr
8b447b9291
fixing error in registerDefaults 2017-12-12 13:08:09 -05:00
Charles Kerr
5720a8e7d5
Merge pull request #11415 from electron/revert-11385-async-menu 
Revert "fix: Fix `menu.popup()` bugs"
 2017-12-12 08:56:12 -06:00
Alexey Kuzmin
1c8eb03574
Revert "fix: Fix menu.popup() bugs" 2017-12-12 13:59:34 +03:00
Alexey Kuzmin
1caa04c0bf
Revert "Add systemPreferences.registerDefaults()" 2017-12-12 13:59:15 +03:00
Charles Kerr
e73fe100d5
Merge pull request #11385 from electron/async-menu 
fix: Fix `menu.popup()` bugs
 2017-12-11 18:02:33 -06:00
Shelley Vohr
a8e67e7f61
fixes from review 2017-12-11 18:20:12 -05:00
Felix Rieseberg
89b90be6a2 🔧 Feedback 2017-12-11 14:43:35 -08:00
Felix Rieseberg
f7ebfff8ae 👷 Properly test x vs y 2017-12-11 14:05:07 -08:00
Felix Rieseberg
dfd7598d48 👷 Hence, better testing 2017-12-11 14:03:04 -08:00
Shelley Vohr
84bab48627
improve error handling 2017-12-11 13:11:03 -05:00
Shelley Vohr
765f223fef
update docs and spec 2017-12-11 13:06:23 -05:00
Shelley Vohr
c5aeda1fdd
fixes from code review 2017-12-11 00:20:26 -05:00
Shelley Vohr
8a24733ee6
add fail spec and only run mac ci 2017-12-10 12:52:03 -05:00
Shelley Vohr
becabdfff2
add test for registerDefaults 2017-12-10 11:26:07 -05:00
Felix Rieseberg
725f6c97d6 👷 Add a spec 2017-12-08 14:52:21 -08:00
Shelley Vohr
276f758560
remove deprecated method call 2017-12-07 14:26:57 -05:00
Charles Kerr
5fa29fcf58
Merge pull request #11329 from electron/remove-classes-key 
fix: Properly cleanup in `removeAsDefaultProtocolClient`
 2017-12-06 17:31:50 -06:00
Felix Rieseberg
bd4c7a114a 👷 Fix the last broken test 2017-12-05 17:07:22 -08:00
Felix Rieseberg
bf043c92af 👷 Ugh, whitespace 2017-12-05 13:20:34 -08:00
Felix Rieseberg
e6cbb2f3aa 👷 Cleanup on Windows only 2017-12-05 12:14:19 -08:00
Felix Rieseberg
d519bfc5fb 👷 Linter fascism 2017-12-05 11:38:19 -08:00
Felix Rieseberg
997f3f31d2 👷 Cleanup after the test 2017-12-05 11:31:40 -08:00
Felix Rieseberg
e77751aab5 👷 Test registry interaction 2017-12-05 11:28:39 -08:00
Felix Rieseberg
60634cac42 📦 Install winreg 2017-12-05 11:28:19 -08:00
Thiago de Arruda
dfd98e3428 Add linux powerMonitor tests using python-dbusmock 2017-12-05 08:33:36 -03:00
Cheng Zhao
cb3a9c69ab Add a SessionPreferences to manage session related data 
By design the BrowserClient should not be aware of the api:: classes.
 2017-12-05 15:59:15 +09:00
Samuel Attard
eaa4b71c24 Remove .only 2017-12-05 11:35:54 +09:00
Samuel Attard
009459bd38 Standard JS 2017-12-05 11:35:54 +09:00
Samuel Attard
3b80ee0655 Move global preload implementation to be session based 2017-12-05 11:35:53 +09:00
Samuel Attard
0ddd078aaf Add ability to set global preload scripts 2017-12-05 11:35:27 +09:00
Cheng Zhao
d598aa1a67
Merge pull request #11300 from electron/external-devtools 
Add API to set arbitrary WebContents as devtools
 2017-12-05 10:35:49 +09:00
Charles Kerr
3e056eec9e
Merge pull request #11297 from electron/remove-travis 
Remove Travis references
 2017-12-04 10:56:53 -06:00
Ales Pergl
ecdbe79e29 Make the asar-video test run faster 
I cut the video to 3 seconds and removed the audio track, which makes the test
finish a lot sooner. Also the asar file is 160 kB instead of 1 MB.
 2017-12-02 11:30:57 +01:00
Shelley Vohr
45de1e6a7c
remove extraneous variables 2017-12-01 16:11:54 -05:00
Shelley Vohr
af6489576a
remove onlys 2017-12-01 16:01:03 -05:00
Shelley Vohr
00e8713eac
split ipc tests into three files 2017-12-01 15:57:41 -05:00
John Kleinschmidt
d182bacd00 Ignore/remove package-lock files 2017-12-01 12:55:55 -05:00
Cheng Zhao
ea9771702b spec: setDevToolsWebContents 2017-12-01 10:35:23 +09:00
John Kleinschmidt
0ef8f58090 Remove Travis references 2017-11-30 15:39:32 -05:00
Zeke Sikelianos
aab35073ee
Merge pull request #11255 from electron/fix-11245 
Enable nativeImage module addRepresentation() tests
 2017-11-30 10:48:11 -08:00
Zeke Sikelianos
c1728720a7
Merge pull request #11256 from electron/fix-11244 
Enable "<webview> tag found-in-page event emits when a request is made"
 2017-11-30 10:48:00 -08:00
shelley vohr
2bc8b33c2a
Merge pull request #11291 from electron/fix-failing-spec 
spec: Fix the failing coffee-script test
 2017-11-30 13:43:58 -05:00
John Kleinschmidt
2d75eea82a
Merge pull request #11254 from electron/fix-11246 
Enable crashReporter module tests
 2017-11-30 12:55:49 -05:00
Aleksei Kuzmin
b9ed7380aa Explicitly set alpha type of bitmaps with JPEG data to opaque 
Actually fixes #11245.
 2017-11-30 17:56:32 +01:00
Aleksei Kuzmin
c0c983d28d Light refactoring of the nativeImage module tests 2017-11-30 17:50:51 +01:00
Cheng Zhao
04872bb001 spec: Fix the failing coffee-script test 
The latest version has some regression causing our test to fail.
 2017-11-30 21:10:22 +09:00
Aleksei Kuzmin
275815002f Inscrease timeout for crashReporter tests 
Fixes #11246.
 2017-11-29 12:27:06 +01:00
Cheng Zhao
c0e9dbcc00
Merge pull request #11144 from dittos/mas-login-helper-again 
Re-land MAS login helper (w/ regression fix)
 2017-11-27 17:02:57 +09:00
Cheng Zhao
1c0ea0286e
Merge pull request #11235 from electron/standard-10 
infra: Upgrade to StandardJS 10
 2017-11-27 15:42:52 +09:00
deepak1556
084292f3ab fix: focus the webview as a temp workaround 2017-11-25 20:18:01 +05:30
Aleksei Kuzmin
3e9f9429d1 Enable "<webview> tag found-in-page event emits when a request is made" 
Fixes #11244.
 2017-11-25 13:21:26 +01:00
Aleksei Kuzmin
91e4193622 Enable nativeImage module addRepresentation() tests 
Fixes #11245.
 2017-11-25 12:58:33 +01:00
shelley vohr
c18afc924b
Merge pull request #10213 from electron/upgrade-to-chromium-61 
[WIP] Upgrade to Chromium 61
 2017-11-24 10:17:52 +01:00
Aleksei Kuzmin
efd949ea83 Disable a couple of crashReporter tests 2017-11-24 10:58:53 +09:00
Aleksei Kuzmin
d61564bfb1 Disable "<webview> tag > found-in-page event > emits when a request is made" test 2017-11-24 10:58:53 +09:00
Aleksei Kuzmin
c73ba5802e Disable "nativeImage module > addRepresentation()" tests 2017-11-24 10:58:53 +09:00
deepak1556
0b88873e77 add basic inspector module test 2017-11-24 10:58:53 +09:00
Ales Pergl
82394cc06d Use an existing host name so that it resolves quickly and tests don't time out. 2017-11-24 10:58:53 +09:00
deepak1556
2fa0b3d33e Enable client certificate tests 2017-11-24 10:58:53 +09:00
Birunthan Mohanathas
4e859b4718 Remove "async" option from menu.popup() 
All menus are async now. See "Cleanup MenuRunner API"
https://codereview.chromium.org/2790773002
 2017-11-24 10:58:17 +09:00
Felix Rieseberg
9f0df695ca 🔧 Spec: Fix style issues 2017-11-23 14:22:58 -08:00
Felix Rieseberg
0278e380de 🔧 Spec: Don’t use deprecated new Buffer() 2017-11-23 14:22:31 -08:00
Heilig Benedek
62594780e0 run the new test only on windows 2017-11-23 21:25:26 +01:00
Heilig Benedek
710ca230f3 update tests to reflect new behaviour 2017-11-23 21:25:25 +01:00
Charles Kerr
9c217fc6c7
Merge pull request #11224 from electron/browser-view-window 
feature: Add `BrowserWindow.fromBrowserView()`
 2017-11-23 14:41:36 +01:00
Felix Rieseberg
690e8cf75b 👷 Add specs 2017-11-22 17:06:14 -08:00
Felix Rieseberg
b7bc4eb586 👷 Let’s test the undefined case, too 2017-11-22 14:38:08 -08:00
Felix Rieseberg
14db204315 👷 Add a spec 2017-11-22 14:37:46 -08:00
shelley vohr
c7e40a2a64
Merge pull request #11133 from electron/skip-tests-that-should-be-skipped 
Explicitly skip tests that should be skipped
 2017-11-21 10:13:18 +01:00
Charles Kerr
5eb00e45aa
Merge pull request #11158 from electron/execute-errors 
fix: Pass on errors thrown in `executeJavaScript`
 2017-11-20 09:14:05 -06:00
Charles Kerr
4c04f1c7ed
Merge pull request #11117 from electron/add_deprecations_spec 
Add to deprecations spec
 2017-11-20 09:07:06 -06:00
Shelley Vohr
7904be8763
comment out unused methods 2017-11-20 15:12:34 +01:00
Aleksei Kuzmin
cf749a8e18 Explicitly skip tests that should be skipped 2017-11-20 14:43:23 +01:00
shelley vohr
42d7d51b75
Merge pull request #11171 from him2him2/electron.atom.io 
Update electron.atom.io -> electronjs.org
 2017-11-20 13:05:14 +01:00
Cheng Zhao
79414d4822 Do not open devtools in tests 2017-11-20 11:05:38 +09:00
Cheng Zhao
3cc8330998 Merge branch 'master' into ahmedmohamedali-master 2017-11-20 11:04:47 +09:00
Ted Kim
71c16ad76f lint 2017-11-20 10:17:34 +09:00
Ted Kim
1660fc8d13 Fix getLoginItemSettings timing issue 2017-11-20 10:15:45 +09:00
Ronald Eddy
14c6e78147 Update electron.atom.io -> electronjs.org 
Update electron.atom.io -> electronjs.org to reduce redirects and speed navigation.
 2017-11-19 04:01:33 -08:00
Felix Rieseberg
5b18bea7e3 🔧 Alex has good ideas 2017-11-18 10:59:09 -08:00
Felix Rieseberg
3311e0bd67 👷 This calls for tests 2017-11-18 00:51:27 -08:00
Ted Kim
d9481430df Fix test failure 2017-11-17 10:53:21 +09:00
Shelley Vohr
7f4c501f81
remove only 2017-11-16 14:51:24 -05:00
Shelley Vohr
933c7330a5
changes from review 2017-11-16 13:39:07 -05:00
Shelley Vohr
f5c04c7037
fix includes 2017-11-16 13:27:08 -05:00
Shelley Vohr
c8b544a47d
linting is important 2017-11-16 13:27:08 -05:00
Shelley Vohr
e5983eacd6
add callbacks registry spec 2017-11-16 13:27:07 -05:00
Aleksei Kuzmin
b51a9cf4f6 Rewrite "nativeImage module" tests assertions with chai.expect() 2017-11-16 16:00:11 +03:00
Aleksei Kuzmin
367b4b05a1 Add Chai library for tests 2017-11-16 15:59:26 +03:00
Charles Kerr
3a1106d026
Merge pull request #11103 from electron/full-version-string 
fix: Provide full and correct version in `process.version`
 2017-11-14 19:18:03 -06:00
Shelley Vohr
dc410efa36
rename and fix assoc. test 2017-11-14 14:56:16 -05:00
Shelley Vohr
99d35f7786
a few more updates to tests 2017-11-14 13:33:38 -05:00
Shelley Vohr
d05a1f8053
first pass at deprecation spec updates 2017-11-13 20:21:57 -05:00
Ahmed Mohamed Ali
b6109030a1 Fix missing eof missing from html test files 2017-11-13 21:22:36 +01:00
Ahmed Mohamed Ali
1f2c949316 Merge branch 'master' of https://github.com/ahmedmohamedali/electron 2017-11-13 21:16:52 +01:00
Ahmed Mohamed Ali
ff707a0f3d Fix issues in the file for the tests. 2017-11-13 21:13:19 +01:00
Felix Rieseberg
7c446cc61c 🔧 Actually fix the test 2017-11-13 11:22:34 -08:00
Thiago de Arruda
639dc2377f Add tests for URLRequestStreamJob 2017-11-13 16:16:14 -03:00
Felix Rieseberg
8de9d5265a 👷 Fix the spec 2017-11-12 23:06:04 -08:00
Samuel Attard
a06a8a6f79
Merge pull request #11056 from ajmacd/allow-browser-window-logs 
Allow BrowserWindows to emit `console-message` events.
 2017-11-11 14:34:39 +11:00
Samuel Attard
ba754cf5c3
Merge pull request #11055 from electron/fix-menu-bug 
fix: Don't crash on `setApplicationMenu(null)`
 2017-11-11 14:33:18 +11:00
Ahmed
26fedcf8da
Update chromium-spec.js 2017-11-08 18:12:50 +01:00
Ahmed
9b3960fe90
Merge branch 'master' into master 2017-11-08 18:03:55 +01:00
John Kleinschmidt
26baea58c9
Merge pull request #10990 from electron/fix-10988 
Enable "document.visibilityState/hidden" tests
 2017-11-08 09:55:40 -05:00
Andrew MacDonald
51f6311f32 Handle the possibility of unexpected logs. 2017-11-08 00:09:54 -08:00
Andrew MacDonald
e51042f5a1 Add console-message test. 2017-11-07 23:45:27 -08:00
Felix Rieseberg
07dea13c77 👷 Let’s add a spec! 2017-11-07 13:29:37 -08:00
Shelley Vohr
498742d6b3
remove function invocation from crash test 2017-11-02 07:07:19 -04:00
Shelley Vohr
9727717839
Merge pull request #10974 from electron/add_crashreport_tests 
Update Crash Report Tests
 2017-11-02 01:45:39 -04:00
Shelley Vohr
a7f059d951
switch from set to add in paramater test 2017-11-02 01:02:16 -04:00
Shelley Vohr
1d6803b234
remove deprecated tests 2017-11-02 00:16:51 -04:00
Shelley Vohr
24acd74d15
update deprecation warning 2017-11-01 22:23:33 -04:00
Shelley Vohr
3af83f1c97
add new method and mark setExtraParameter for deprecation 2017-11-01 21:57:43 -04:00
Aleksei Kuzmin
2bd44612fd Revert "Merge pull request #10989 from electron/temporary-disable-visibility-state-tests" 
This reverts commit f3125358c0, reversing
changes made to 7b9ad5001b.
 2017-11-02 03:22:27 +03:00
Aleksei Kuzmin
2f7718265a Light refactoring of the nativeImage module tests 2017-11-02 03:18:32 +03:00
Aleksei Kuzmin
0df058dc1e Temporary disable "document.visibilityState/hidden" tests 
Task to enable them:
https://github.com/electron/electron/issues/10988
 2017-11-02 00:06:38 +03:00
Shelley Vohr
6961162636
another try at fixing travis test 2017-11-01 14:26:39 -04:00
Shelley Vohr
28c009fcc0
linting is important 2017-11-01 10:56:53 -04:00
Shelley Vohr
d2e1705c80
convert app and browser spec to ES6 2017-11-01 10:48:09 -04:00
Shelley Vohr
0adf775d9a
clean fixture and fix failing travis test 2017-11-01 08:57:22 -04:00
Shelley Vohr
7f89cd0774
remove const from non-member function 2017-10-31 23:55:22 -04:00
Shelley Vohr
93df164485
add const and other small edits 2017-10-31 23:42:25 -04:00
Shelley Vohr
7b08a93549
remove pesky 'only' 2017-10-31 18:31:44 -04:00
Shelley Vohr
a538e47994
complete GetParameters method & all tests passing 2017-10-31 18:19:04 -04:00
Shelley Vohr
3136f833a5
fixes and updates to GetParameters 2017-10-31 13:51:44 -04:00
Shelley Vohr
cd19d7c705
add crashReporter parameter tests 2017-10-31 10:38:48 -04:00
Shelley Vohr
cb78e4875b
fix two failing tests 2017-10-30 23:15:57 -04:00
Shelley Vohr
603060f051
add new tests 2017-10-30 22:51:22 -04:00
Shelley Vohr
e4214a6cbe
[WIP] Upgrade more specs (#10945) 
Finish upgrading specs to ES6
 2017-10-27 16:45:58 -04:00
Felix Rieseberg
541b369175 👷 Add a spec 2017-10-27 11:44:41 -07:00
Shelley Vohr
9292c7ec53 Merge pull request #10938 from electron/update_protocol_test 
Upgrade protocol spec
 2017-10-27 09:48:33 -04:00
Shelley Vohr
e2d5aaf0f3 Merge pull request #10942 from electron/upgrade_specs 
[WIP] Upgrade specs
 2017-10-26 22:12:19 -04:00
Shelley Vohr
eed54a18c4
fix comment typo 2017-10-26 22:09:38 -04:00
Shelley Vohr
7a3efd1543
stop leaving onlys there 2017-10-26 21:41:29 -04:00
Shelley Vohr
abecde0572
fix shortcut spec error 2017-10-26 21:41:06 -04:00
Shelley Vohr
0317189213
update touch bar spec 2017-10-26 21:08:47 -04:00
Shelley Vohr
1130ccf69b
upgrade system pref spec 2017-10-26 20:58:48 -04:00
Shelley Vohr
d8f2183b3d
upgrade screen spec 2017-10-26 20:55:07 -04:00
Shelley Vohr
e64e9995b6
small tweak to process spec 2017-10-26 20:53:47 -04:00
Shelley Vohr
13fc080213
small tweaks to global shortcut spec 2017-10-26 20:49:21 -04:00
Shelley Vohr
6feff1d6e8
update desktop capturer spec 2017-10-26 20:44:06 -04:00
Shelley Vohr
6cd308f9ad
update deprecations spec 2017-10-26 20:37:35 -04:00
Shelley Vohr
83a290a411
update debugger spec 2017-10-26 20:32:04 -04:00
Shelley Vohr
d4350079c9
update crash reporter spec 2017-10-26 20:21:36 -04:00
Shelley Vohr
56979804ec
update clipboard spec 2017-10-26 20:12:51 -04:00
Shelley Vohr
68314dbc05
remove stray only 2017-10-26 20:11:12 -04:00
Shelley Vohr
b53e41af42
migrate api-browser-view-spec to ES6 2017-10-26 20:05:15 -04:00
Shelley Vohr
17f4e53d6b
match earlier tests to ES6 later ones 2017-10-26 16:30:07 -04:00
Shelley Vohr
bb04b22ec8 Merge pull request #10888 from electron/menu_refactor 
refactor menu.js to bring it up to readability and es6 standards
 2017-10-26 00:31:47 -04:00
Cheng Zhao
4db34ff092 Merge pull request #10711 from yuya-oc/did-attach-webview 
Add did-attach-webview event
 2017-10-26 10:55:50 +09:00
Shelley Vohr
135454342d
remove .only from spec 2017-10-24 22:41:28 -04:00
Shelley Vohr
f7bc5481f3
add a few more tests to api_menu_spec 2017-10-24 22:40:31 -04:00
Shelley Vohr
d54148de4e
remove from spec 2017-10-24 20:31:02 -04:00
Shelley Vohr
0e6100ae17
upgrade menu spec to ES6 2017-10-24 20:27:26 -04:00
Ahmed Mohamed Ali
1e9942c1bf Fix js coding style errors 2017-10-20 08:46:41 +02:00
Ahmed Mohamed Ali
44f91e12e1 Add tests for fix described in #10793 2017-10-19 16:15:02 +02:00
Boik
f40cc5ab54 add error code to session.setCertificateVerifyProc 2017-10-16 17:17:21 +08:00
Birunthan Mohanathas
13b9b5c0c0 Merge pull request #10746 from electron/removeuserdefault 
Add systemPreferences.removeUserDefault()
 2017-10-12 16:08:57 +03:00
Birunthan Mohanathas
06d782279c Add systemPreferences.removeUserDefault() 
This can be used to restore the default or global value of a `key`
previously set with `setUserDefault`.
 2017-10-10 22:57:47 +03:00
Samuel Attard
ed25941c65
Add basic specs 2017-10-10 17:30:27 +11:00
Yuya Ochiai
6326c6727e Add did-attach-webview event 2017-10-07 22:52:20 +09:00
John Kleinschmidt
15bfb86eec Make sure test closes window 
Newly added test was leaving window open causing tests to fail
 2017-10-04 11:35:41 -04:00
Cheng Zhao
8c5bb5969c Merge pull request #10667 from dittos/window-opacity 
Add window opacity support
 2017-10-04 15:03:45 +09:00
Daniel Ma
1bb042a661 feat(NativeWindowMac): addTabbedWindow 
Add support for the [`NSWindow addTabbedWindow`][nsw] method on MacOSX

This plays nicely with the changes from #9052 and #9725

Usage samples available in [this commit][c] in my fork of
`electron-quick-start`

[nsw]: https://developer.apple.com/documentation/appkit/nswindow/1855947-addtabbedwindow
[c]: 79f06591df
 2017-10-03 20:11:16 +09:00
Taeho Kim
7570ec9d39 Add BrowserWindow.getOpacity for consistency 2017-10-03 00:08:10 +09:00
Ted Kim
7f2c4a9e06 Add window opacity support 2017-09-29 17:49:10 +09:00
John Kleinschmidt
d9d557dcc5 CircleCI updates (#10647) 
* Update CircleCi for release and test

* Update test storage dir
 2017-09-28 13:05:42 -04:00
Shelley Vohr
15b0878a17 Merge pull request #10618 from electron/add-menuitembyid 
[WIP] add getMenuItemById to Menu API
 2017-09-26 22:33:05 -04:00
Shelley Vohr
3c6a7c332a
add unit test for getMenuItemById 2017-09-26 20:05:51 -04:00
Cheng Zhao
d87ea5713d spec: It is not certain which process starts first 2017-09-25 11:19:25 +09:00
Cheng Zhao
5940231b76 spec: Do not assume which process exits first in singleton test 2017-09-25 10:49:54 +09:00
Cheng Zhao
b4075bed87 spec: Add test case for app.makeSingleInstance 2017-09-20 11:58:32 +09:00
Cheng Zhao
af329a9429 Suppress the destroy() spec on all platforms 
It is also crashing on mac, but just not as frequent as other platforms.
 2017-09-14 17:20:14 +09:00
Cheng Zhao
073583ff3d spec: The parent option should not affect show option 2017-09-14 14:48:42 +09:00
xaviergonz
0d69738bd6 using standard javascript 2017-09-14 14:38:54 +09:00
xaviergonz
0301961c25 Update api-browser-window-spec.js 2017-09-14 14:38:54 +09:00
Cheng Zhao
2048a1a638 Merge pull request #10429 from qazbnm456/web-request-origin 
Track the origin of webRequest events
 2017-09-13 22:23:44 +09:00
Vanessa Yuen
9a7d8a0511 merge master into fix-fullscreen-with-resizable-flag. 2017-09-12 18:34:23 -04:00
Boik
2d771674bb get webContentsId instead 2017-09-12 20:17:11 +08:00
Boik
549c30f9b2 first attempt to track the origin requesters of webRequest events 2017-09-12 15:40:35 +08:00
Cheng Zhao
10ab870237 Merge pull request #10321 from kaylanm/macos-native-tab-api 
🍎 Add macOS native tab methods to window API
 2017-09-11 18:49:56 +09:00
Cheng Zhao
cc9771a3d0 Merge pull request #10307 from liusy182/10240-theme-color-2 
return null when theme color is transparent or not found
 2017-09-11 18:40:35 +09:00
Samuel Attard
6b010614e2 Implement moveToApplicationsFolder (#10142) 
* Implement moveToApplicationsFolder

* Fix tabs / spaces

* Fix linting

* Use Browser::Quit, instead of exit

* Update documentation as per feedback

* Fix spec
 2017-08-31 10:37:12 -04:00
Cheng Zhao
7f4b74f8c6 spec: Compare id instead of the object 
Otherwise it is impossible to see what's wrong.
 2017-08-29 15:45:16 +09:00
Cheng Zhao
f0f17fffd8 spec: Do not test window positions 
They were too flaky.
 2017-08-29 14:23:39 +09:00
Cheng Zhao
5510d8cfb1 Revert "Revert "spec: Suppress the select-client-certificate test"" 
This reverts commit 8e989170f1.
 2017-08-29 14:19:22 +09:00
Cheng Zhao
68e0fbfd60 Revert "Revert "spec: Suppress the app.importCertificate test"" 
This reverts commit a7cb89aeb5.
 2017-08-29 14:19:21 +09:00
Cheng Zhao
6e6b097968 Revert "Revert "spec: Suppress the test that destroys WebContents in event listener"" 
This reverts commit 210652ed54.
 2017-08-29 14:19:19 +09:00
sungpark
eca7ff986c add webFrame to sandboxed renderer 2017-08-23 10:52:02 -07:00
sungpark
bf07c5aebd fix contextIsolation issue while webPreference sandbox is on 
contextIsolation didn't work while sandbox is on. The fix is contextIsolation picked up while sandbox on
 2017-08-23 10:52:02 -07:00
Michael Kaylan
b4428e7e41 🍎 Add macOS native tab methods to window API 2017-08-21 23:24:30 -04:00
Aleksei Kuzmin
8b55e6e2f5 Revert "Disable a failing test" 
This reverts commit 9487222726.
 2017-08-22 11:49:53 +09:00
Aleksei Kuzmin
c0331673da Revert "Disable a failing test" 
This reverts commit 25c0cf0612.
 2017-08-21 16:48:24 +09:00
Siyuan Liu
eeb2e58ad8 return null when theme color is not found 2017-08-20 22:48:13 +08:00
Aleksei Kuzmin
25c0cf0612 Disable a failing test 
BrowserWindow module window states resizable state works for a frameless window
 2017-08-15 16:19:29 +03:00
Aleksei Kuzmin
9487222726 Disable a failing test 
BrowserWindow module "webPreferences" option "sandbox" option can print to PDF
 2017-08-15 16:19:29 +03:00
Kevin Sawicki
d943519fb4 Update text expectation for new --inspect-brk message 2017-08-15 16:19:23 +03:00
Kevin Sawicki
29dc06c89d Configure spec UI to run in docker container 2017-08-15 16:19:22 +03:00
Aleksei Kuzmin
ba0c43e1fc Do not run navigator.getUserMedia related test on CI build machines 2017-08-15 16:19:22 +03:00
John Kleinschmidt
72d2e176dd Merge pull request #10160 from liusy182/liusy182-10128-asar 
Return empty string when fs.readFile with 'utf8' option from asar file
 2017-08-07 21:42:15 -04:00
John Kleinschmidt
ccdff72ee4 Merge pull request #9918 from alexstrat/add-extensions-loading-api 
Introduce Chrome extensions management APIs independent of Dev Tools Extensions
 2017-08-07 20:06:22 -04:00
Kevin Sawicki
dfec48dd44 End response and set status code for unexpected URLs 2017-08-07 13:33:01 -07:00
Kevin Sawicki
8e989170f1 Revert "spec: Suppress the select-client-certificate test" 
This reverts commit dc1269615a.
 2017-08-07 12:57:01 -07:00
Kevin Sawicki
a7cb89aeb5 Revert "spec: Suppress the app.importCertificate test" 
This reverts commit 5ccae79ea7.
 2017-08-07 12:56:54 -07:00
Kevin Sawicki
210652ed54 Revert "spec: Suppress the test that destroys WebContents in event listener" 
This reverts commit b315eb83fd.
 2017-08-07 12:56:48 -07:00
Cheng Zhao
dc1269615a spec: Suppress the select-client-certificate test 
Not sure why it is not working
 2017-08-02 16:07:46 +09:00
Cheng Zhao
7d7bb1581b spec: Disable crashReporter tests for some CI machines 
Have no idea why it is failing on our CI machines, but at least Appveyor
works fine.
 2017-08-02 15:54:50 +09:00
Cheng Zhao
5ccae79ea7 spec: Suppress the app.importCertificate test 
I have no idea why it failed, somehow the page can not load with the
provided certificated.
 2017-08-02 15:17:18 +09:00
Cheng Zhao
28959da2b7 spec: Fix the event test calling done for multiple times 2017-08-02 15:06:06 +09:00
Cheng Zhao
b315eb83fd spec: Suppress the test that destroys WebContents in event listener 
It is crashing when Electron is built in Debug mode.
 2017-08-02 11:14:06 +09:00