mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Re-enable cookie specs and add custom cookie name/url validation

Browse source
This commit is contained in:
Samuel Attard 2018-06-18 14:34:26 +10:00
parent c4f80a6d89
commit 8200a132be
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
atom/browser/api/atom_api_cookies.cc
View file

@ -231,7 +231,15 @@ void SetCookieOnIO(scoped_refptr<net::URLRequestContextGetter> getter,
last_access_time, secure, http_only,
net::CookieSameSite::DEFAULT_MODE, net::COOKIE_PRIORITY_DEFAULT));
auto completion_callback = base::BindOnce(OnSetCookie, callback);
if (!canonical_cookie) {
if (!canonical_cookie || !canonical_cookie->IsCanonical()) {
std::move(completion_callback).Run(false);
return;
}
if (url.empty()) {
std::move(completion_callback).Run(false);
return;
}
if (name.empty()) {
std::move(completion_callback).Run(false);
return;
}

4
spec/api-session-spec.js
View file

@ -90,13 +90,13 @@ describe('session module', () => {
})
})
// TODO(alexeykuzmin): [Ch66] Fails. Fix it and enable back.
xit('calls back with an error when setting a cookie with missing required fields', (done) => {
it('calls back with an error when setting a cookie with missing required fields', (done) => {
session.defaultSession.cookies.set({
url: '',
name: '1',
value: '1'
}, (error) => {
assert(error, 'Should have an error')
assert.equal(error.message, 'Setting cookie failed')
done()
})