mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
electron/spec
History
Thiago de Arruda 6ff111a141 perf: don't use JSON to send the result of ipcRenderer.sendSync. (#8953) 
* Don't use JSON to send the result of `ipcRenderer.sendSync`.

- Change the return type of AtomViewHostMsg_Message_Sync from `base::string16`
  to `base::ListValue`
- Adjust lib/browser/api/web-contents.js and /lib/renderer/api/ipc-renderer.js
  to wrap/unwrap return values to/from array, instead of
  serializing/deserializing JSON.

This change can greatly improve `ipcRenderer.sendSync` calls where the return
value contains Buffer instances, because those are converted to Array before
being serialized to JSON(which has no efficient way of representing byte
arrays).

A simple benchmark where remote.require('fs') was used to read a 16mb file got
at least 5x faster, not to mention it used a lot less memory.  This difference
tends increases with larger buffers.

* Don't base64 encode Buffers

* Don't allocate V8ValueConverter on the heap

* Replace hidden global.sandbox with NodeBindings::IsInitialized()

* Refactoring: check NodeBindings::IsInitialized() in V8ValueConverter

* Refactor problematic test to make it more reliable

* Add tests for NaN and Infinity
2018-06-13 17:38:31 +10:00
..
fixtures perf: don't use JSON to send the result of ipcRenderer.sendSync. (#8953) 2018-06-13 17:38:31 +10:00
static Exposing process.env status (#12166) 2018-03-14 12:01:40 +09:00
api-app-spec.js Remove command line argument black-list (#13039) 2018-05-22 11:51:03 -05:00
api-auto-updater-spec.js fix windows tests 2018-02-16 16:02:10 +11:00
api-browser-view-spec.js Document BrowserView.{destroy,isDestroyed} (#12274) 2018-03-15 16:15:56 +09:00
api-browser-window-affinity-spec.js Add an "affinity" option to webPreferences 2018-02-13 15:18:55 +09:00
api-browser-window-spec.js perf: don't use JSON to send the result of ipcRenderer.sendSync. (#8953) 2018-06-13 17:38:31 +10:00
api-callbacks-registry-spec.js remove only 2017-11-16 14:51:24 -05:00
api-clipboard-spec.js Explicitly skip tests that should be skipped 2017-11-20 14:43:23 +01:00
api-crash-reporter-spec.js add missing report.length > 1 assertion (#12257) 2018-03-14 13:14:29 +09:00
api-debugger-spec.js Fix and update debugger UTF char test 2018-02-01 16:47:52 -08:00
api-deprecations-spec.js feat: warn if deprecated property is already set 2018-05-29 15:58:02 +02:00
api-desktop-capturer-spec.js Add a display_id parameter to the desktopCapturer API. (#12417) 2018-04-09 14:43:35 +09:00
api-dialog-spec.js Add specs for showCertificateTrustDialog option errors 2017-04-04 10:49:21 -07:00
api-global-shortcut-spec.js Explicitly skip tests that should be skipped 2017-11-20 14:43:23 +01:00
api-in-app-purchase-spec.js Improve in-app purchase for MacOS (#12464) 2018-04-05 15:33:13 +09:00
api-ipc-main-spec.js remove extraneous variables 2017-12-01 16:11:54 -05:00
api-ipc-renderer-spec.js remove extraneous variables 2017-12-01 16:11:54 -05:00
api-menu-item-spec.js improve Menu and MenuItem testing (#12015) 2018-02-23 07:53:59 -06:00
api-menu-spec.js Add menu item order control (#12362) 2018-05-05 09:37:29 -07:00
api-native-image-spec.js Remove nativeImage deprecated methods (#11978) 2018-02-20 09:15:27 -06:00
api-net-spec.js 🔧 Spec: Fix style issues 2017-11-23 14:22:58 -08:00
api-notification-dbus-spec.js Linux named notifications (#12192) 2018-03-12 09:33:06 +09:00
api-notification-spec.js Add Notification tests 2018-02-10 03:19:47 -08:00
api-power-monitor-spec.js feat(powerMonitor): expose interface to query system idle state (#11807) 2018-03-14 14:42:08 +09:00
api-power-save-blocker-spec.js Add initial power save blocker spec 2016-08-09 15:05:56 -07:00
api-process-spec.js Add process.getHeapStatistics() (#13183) 2018-06-10 22:00:36 +10:00
api-protocol-spec.js reenable some specs 2018-01-02 16:37:08 +09:00
api-remote-spec.js perf: don't use JSON to send the result of ipcRenderer.sendSync. (#8953) 2018-06-13 17:38:31 +10:00
api-screen-spec.js remove screen.getMenuBarHeight spec 2018-03-05 20:10:34 -05:00
api-session-spec.js remove deprecated signature tests 2018-05-29 11:42:03 -04:00
api-shell-spec.js Explicitly skip tests that should be skipped 2017-11-20 14:43:23 +01:00
api-system-preferences-spec.js add loop to catch null values 2017-12-13 14:02:43 -05:00
api-touch-bar-spec.js update touch bar spec 2017-10-26 21:08:47 -04:00
api-view-spec.js add tests for View and WebContentsView 2018-05-21 10:53:09 +09:00
api-web-contents-spec.js Deprecate did-get-response-details and did-get-redirect-request (#12615) 2018-04-23 14:46:12 -05:00
api-web-contents-view-spec.js add tests for View and WebContentsView 2018-05-21 10:53:09 +09:00
api-web-frame-spec.js remove setZoomLevelLimits 2018-02-20 08:57:48 -05:00
api-web-request-spec.js 🔧 Spec: Fix style issues 2017-11-23 14:22:58 -08:00
asar-spec.js 🔧 Spec: Don’t use deprecated new Buffer() 2017-11-23 14:22:31 -08:00
chromium-spec.js Support for navigator.languages (#12419) 2018-04-02 12:47:00 +09:00
modules-spec.js Allow CI building on arm64 hardware 2018-03-08 09:53:47 -05:00
node-spec.js Enable node crypto spec 2018-03-20 10:13:16 +03:00
package.json Fix vulnerabilities both top-level and in spec (#13029) 2018-05-21 21:15:18 -07:00
security-warnings-spec.js update signature for setCertificateVerifyProc in session spec 2018-05-29 10:54:27 -04:00
webview-spec.js Slightly rewrite <webview> tag tests (#13122) 2018-06-01 10:56:48 +02:00
window-helpers.js Assert single window from closeWindow helper 2016-11-29 11:29:20 -08:00