refactor: properly report on skipped native modules tests (#13894)

This commit is contained in:
Jeremy Apthorp 2018-08-24 14:24:24 -07:00 committed by Samuel Attard
parent 4cf264f87a
commit c452be02b9
3 changed files with 5 additions and 14 deletions

View file

@ -1697,10 +1697,8 @@ describe('BrowserWindow module', () => {
done()
})
w.loadURL(`file://${path.join(fixtures, 'api', 'native-window-open-iframe.html')}`)
})
it('loads native addons correctly after reload', (done) => {
if (!nativeModulesEnabled) return done()
});
(nativeModulesEnabled ? it : it.skip)('loads native addons correctly after reload', (done) => {
ipcMain.once('answer', (event, content) => {
assert.equal(content, 'function')
ipcMain.once('answer', (event, content) => {

View file

@ -11,9 +11,7 @@ describe('modules support', () => {
const fixtures = path.join(__dirname, 'fixtures')
describe('third-party module', () => {
describe('runas', () => {
if (!nativeModulesEnabled) return
(nativeModulesEnabled ? describe : describe.skip)('runas', () => {
it('can be required in renderer', () => {
require('runas')
})

View file

@ -204,14 +204,9 @@ describe('<webview> tag', function () {
allowpopups: 'on',
src
})
})
it('loads native modules when navigation happens', async function () {
if (!nativeModulesEnabled) {
this.skip()
return
}
});
(nativeModulesEnabled ? it : it.skip)('loads native modules when navigation happens', async function () {
await loadWebView(webview, {
nodeintegration: 'on',
src: `file://${fixtures}/pages/native-module.html`