mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

remove support for hidden-inset (#11975)

Browse source
This commit is contained in:
shelley vohr 2018-02-20 12:09:54 -05:00 committed by Charles Kerr
parent 7bcccdec41
commit 846be03f1d
3 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
atom/browser/native_window_mac.mm
View file

@ -813,8 +813,7 @@ struct Converter<atom::NativeWindowMac::TitleBarStyle> {
return false;
if (title_bar_style == "hidden") {
*out = atom::NativeWindowMac::HIDDEN;
} else if (title_bar_style == "hidden-inset" || // TODO(kevinsawicki): Remove in 2.0, deprecate before then with warnings
title_bar_style == "hiddenInset") {
} else if (title_bar_style == "hiddenInset") {
*out = atom::NativeWindowMac::HIDDEN_INSET;
} else if (title_bar_style == "customButtonsOnHover") {
*out = atom::NativeWindowMac::CUSTOM_BUTTONS_ON_HOVER;

1
docs/api/browser-window.md
View file

@ -220,7 +220,6 @@ It creates a new `BrowserWindow` with native properties as set by the `options`.
* `hidden` - Results in a hidden title bar and a full size content window, yet
the title bar still has the standard window controls ("traffic lights") in
the top left.
* `hidden-inset` - Deprecated, use `hiddenInset` instead.
* `hiddenInset` - Results in a hidden title bar with an alternative look
where the traffic light buttons are slightly more inset from the window edge.
* `customButtonsOnHover` Boolean (optional) - Draw custom close, minimize,

2
spec/api-browser-window-spec.js
View file

@ -927,7 +927,7 @@ describe('BrowserWindow module', () => {
show: false,
width: 400,
height: 400,
titleBarStyle: 'hidden-inset'
titleBarStyle: 'hiddenInset'
})
const contentSize = w.getContentSize()
assert.equal(contentSize[1], 400)