From 846be03f1dbc18af1daa1526617fecd48c6f6570 Mon Sep 17 00:00:00 2001 From: shelley vohr Date: Tue, 20 Feb 2018 12:09:54 -0500 Subject: [PATCH] remove support for hidden-inset (#11975) --- atom/browser/native_window_mac.mm | 3 +-- docs/api/browser-window.md | 1 - spec/api-browser-window-spec.js | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/atom/browser/native_window_mac.mm b/atom/browser/native_window_mac.mm index a8dc6c3a1f4..ad1713e4012 100644 --- a/atom/browser/native_window_mac.mm +++ b/atom/browser/native_window_mac.mm @@ -813,8 +813,7 @@ struct Converter { return false; if (title_bar_style == "hidden") { *out = atom::NativeWindowMac::HIDDEN; - } else if (title_bar_style == "hidden-inset" || // TODO(kevinsawicki): Remove in 2.0, deprecate before then with warnings - title_bar_style == "hiddenInset") { + } else if (title_bar_style == "hiddenInset") { *out = atom::NativeWindowMac::HIDDEN_INSET; } else if (title_bar_style == "customButtonsOnHover") { *out = atom::NativeWindowMac::CUSTOM_BUTTONS_ON_HOVER; diff --git a/docs/api/browser-window.md b/docs/api/browser-window.md index f5f260fe4ab..2be2da59766 100644 --- a/docs/api/browser-window.md +++ b/docs/api/browser-window.md @@ -220,7 +220,6 @@ It creates a new `BrowserWindow` with native properties as set by the `options`. * `hidden` - Results in a hidden title bar and a full size content window, yet the title bar still has the standard window controls ("traffic lights") in the top left. - * `hidden-inset` - Deprecated, use `hiddenInset` instead. * `hiddenInset` - Results in a hidden title bar with an alternative look where the traffic light buttons are slightly more inset from the window edge. * `customButtonsOnHover` Boolean (optional) - Draw custom close, minimize, diff --git a/spec/api-browser-window-spec.js b/spec/api-browser-window-spec.js index 2b5488d208f..3033eb6a1f6 100644 --- a/spec/api-browser-window-spec.js +++ b/spec/api-browser-window-spec.js @@ -927,7 +927,7 @@ describe('BrowserWindow module', () => { show: false, width: 400, height: 400, - titleBarStyle: 'hidden-inset' + titleBarStyle: 'hiddenInset' }) const contentSize = w.getContentSize() assert.equal(contentSize[1], 400)