mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

comment out unused methods

Browse source
This commit is contained in:
Shelley Vohr 2017-11-20 15:12:34 +01:00
parent dc410efa36
commit 7904be8763
No known key found for this signature in database
GPG key ID: F13993A75599653C
2 changed files with 49 additions and 60 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

95
lib/common/api/deprecate.js
View file

@ -10,9 +10,7 @@ const deprecate = function (oldName, newName, fn) {
}
}
// The method is renamed.
// nota bene: newName should already exist and
// oldName is being injected for compatibility with old code
// The method is aliases and the old method is retained for backwards compat
deprecate.alias = function (object, deprecatedName, existingName) {
let warned = false
const newMethod = function () {
@ -29,50 +27,6 @@ deprecate.alias = function (object, deprecatedName, existingName) {
}
}
// Forward the method to member.
deprecate.member = (object, method, member) => {
let warned = false
object.prototype[method] = function () {
if (!(warned || process.noDeprecation)) {
warned = true
deprecate.warn(method, `${member}.${method}`)
}
return this[member][method].apply(this[member], arguments)
}
}
// Deprecate a property.
deprecate.property = (object, property, method) => {
return Object.defineProperty(object, property, {
get: function () {
let warned = false
if (!(warned || process.noDeprecation)) {
warned = true
deprecate.warn(`${property} property`, `${method} method`)
}
return this[method]()
}
})
}
// Deprecate an event.
deprecate.event = (emitter, oldName, newName, fn) => {
let warned = false
return emitter.on(newName, function (...args) {
if (this.listenerCount(oldName) > 0) {
if (!(warned || process.noDeprecation)) {
warned = true
deprecate.warn(`'${oldName}' event`, `'${newName}' event`)
}
if (fn != null) {
fn.apply(this, arguments)
} else {
this.emit.apply(this, [oldName].concat(args))
}
}
})
}
deprecate.warn = (oldName, newName) => {
return deprecate.log(`'${oldName}' is deprecated. Use '${newName}' instead.`)
}
@ -98,4 +52,51 @@ deprecate.setHandler = (handler) => {
deprecate.getHandler = () => deprecationHandler
// None of the below methods are used, and so will be commented
// out until such time that they are needed to be used and tested.
// // Forward the method to member.
// deprecate.member = (object, method, member) => {
// let warned = false
// object.prototype[method] = function () {
// if (!(warned || process.noDeprecation)) {
// warned = true
// deprecate.warn(method, `${member}.${method}`)
// }
// return this[member][method].apply(this[member], arguments)
// }
// }
//
// // Deprecate a property.
// deprecate.property = (object, property, method) => {
// return Object.defineProperty(object, property, {
// get: function () {
// let warned = false
// if (!(warned || process.noDeprecation)) {
// warned = true
// deprecate.warn(`${property} property`, `${method} method`)
// }
// return this[method]()
// }
// })
// }
//
// // Deprecate an event.
// deprecate.event = (emitter, oldName, newName, fn) => {
// let warned = false
// return emitter.on(newName, function (...args) {
// if (this.listenerCount(oldName) > 0) {
// if (!(warned || process.noDeprecation)) {
// warned = true
// deprecate.warn(`'${oldName}' event`, `'${newName}' event`)
// }
// if (fn != null) {
// fn.apply(this, arguments)
// } else {
// this.emit.apply(this, [oldName].concat(args))
// }
// }
// })
// }
module.exports = deprecate

14
spec/api-deprecations-spec.js
View file

@ -1,7 +1,7 @@
const assert = require('assert')
const {deprecations, deprecate, nativeImage} = require('electron')
describe.only('deprecations', () => {
describe('deprecations', () => {
beforeEach(() => {
deprecations.setHandler(null)
process.throwDeprecation = true
@ -54,16 +54,4 @@ describe.only('deprecations', () => {
deprecate.log('this is deprecated')
}, /this is deprecated/)
})
// it('deprecates a property', () => {
// deprecate.property(object, property, method)
// })
//
// it('deprecates an event', () => {
// deprecate.event(emitter, oldName, newName, fn)
// })
//
// it('forwards a method to member', () => {
// deprecate.member(object, method, member)
// })
})