mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

spec: add test for syncronous access to blink APIs (#14637)

Browse source 
This test should ensure we catch a regression of #13787
This commit is contained in:
Samuel Attard 2018-09-25 10:40:15 +12:00 committed by GitHub
parent e6242d5ef8
commit 50a4a8e9c3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 42 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
spec/api-browser-window-spec.js
View file

@ -1286,6 +1286,21 @@ describe('BrowserWindow module', () => {
})
w.loadFile(path.join(fixtures, 'api', 'preload.html'))
})
it('has synchronous access to all eventual window APIs', async () => {
const preload = path.join(fixtures, 'module', 'access-blink-apis.js')
const w = await openTheWindow({
show: false,
webPreferences: {
preload: preload
}
})
w.loadFile(path.join(fixtures, 'api', 'preload.html'))
const [, test] = await emittedOnce(ipcMain, 'answer')
expect(test).to.be.an('object')
expect(test.atPreload).to.be.an('array')
expect(test.atLoad).to.be.an('array')
expect(test.atPreload).to.deep.equal(test.atLoad, 'should have access to the same window APIs')
})
})
describe('session preload scripts', function () {

13
spec/fixtures/api/preload.html vendored
View file

@ -1,9 +1,16 @@
<html>
<body>
<script type="text/javascript" charset="utf-8">
if (!window.test)
window.test = 'window'
require('electron').ipcRenderer.send('answer', window.test);
const send = () => {
if (!window.test)
window.test = 'window'
require('electron').ipcRenderer.send('answer', window.test);
}
if (window.delayed) {
window.addEventListener('load', send)
} else {
send()
}
</script>
</body>
</html>

17
spec/fixtures/module/access-blink-apis.js vendored Normal file
View file

@ -0,0 +1,17 @@
window.delayed = true
global.getGlobalNames = () => {
return Object.getOwnPropertyNames(global)
.filter(key => typeof global[key] === 'function')
.filter(key => key !== 'WebView')
.sort()
}
const atPreload = global.getGlobalNames()
window.addEventListener('load', () => {
window.test = {
atPreload,
atLoad: global.getGlobalNames()
}
})