mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

a few more updates to tests

Browse source
This commit is contained in:
Shelley Vohr 2017-11-14 13:33:38 -05:00
parent d05a1f8053
commit 99d35f7786
No known key found for this signature in database
GPG key ID: F13993A75599653C
2 changed files with 41 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/common/api/deprecate.js
View file

@ -11,7 +11,8 @@ const deprecate = function (oldName, newName, fn) {
}
// The method is renamed.
deprecate.rename = function (object, oldName, newName) {
deprecate.rename = (object, oldName, newName) => {
console.log('we are here')
let warned = false
const newMethod = function () {
if (!(warned || process.noDeprecation)) {

78
spec/api-deprecations-spec.js
View file

@ -7,44 +7,44 @@ describe.only('deprecations', () => {
process.throwDeprecation = true
})
it('allows a deprecation handler function to be specified', () => {
const messages = []
// it('allows a deprecation handler function to be specified', () => {
// const messages = []
//
// deprecations.setHandler((message) => {
// messages.push(message)
// })
//
// deprecate.log('this is deprecated')
// assert.deepEqual(messages, ['this is deprecated'])
// })
//
// it('returns a deprecation handler after one is set', () => {
// const messages = []
//
// deprecations.setHandler((message) => {
// messages.push(message)
// })
//
// deprecate.log('this is deprecated')
// assert(typeof deprecations.getHandler() === 'function')
// })
//
// it('returns a deprecation warning', () => {
// const messages = []
//
// deprecations.setHandler((message) => {
// messages.push(message)
// })
//
// deprecate.warn('old', 'new')
// assert.deepEqual(messages, [`'old' is deprecated. Use 'new' instead.`])
// })
deprecations.setHandler((message) => {
messages.push(message)
})
deprecate.log('this is deprecated')
assert.deepEqual(messages, ['this is deprecated'])
})
it('returns a deprecation handler after one is set', () => {
const messages = []
deprecations.setHandler((message) => {
messages.push(message)
})
deprecate.log('this is deprecated')
assert(typeof deprecations.getHandler() === 'function')
})
it('returns a deprecation warning', () => {
const messages = []
deprecations.setHandler((message) => {
messages.push(message)
})
deprecate.warn('old', 'new')
assert.deepEqual(messages, [`'old' is deprecated. Use 'new' instead.`])
})
it('throws an exception if no deprecation handler is specified', () => {
assert.throws(() => {
deprecate.log('this is deprecated')
}, /this is deprecated/)
})
// it('throws an exception if no deprecation handler is specified', () => {
// assert.throws(() => {
// deprecate.log('this is deprecated')
// }, /this is deprecated/)
// })
// it('deprecates a property', () => {
// deprecate.property(object, property, method)
@ -60,8 +60,8 @@ describe.only('deprecations', () => {
it('renames a method', () => {
assert(typeof ipcRenderer.sendSync === 'function')
assert(typeof ipcRenderer.sendChannelSync === 'undefined')
deprecate.rename(ipcRenderer, 'sendSync', 'sendChannelSync')
assert(typeof ipcRenderer.sendSync === 'undefined')
// assert(typeof ipcRenderer.sendChannelSync === 'function')
assert(typeof ipcRenderer.sendChannelSync === 'function')
})
})