From 99d35f77866da739405ddad09b28d72c4e576c0c Mon Sep 17 00:00:00 2001
From: Shelley Vohr <shelley.vohr@gmail.com>
Date: Tue, 14 Nov 2017 13:33:38 -0500
Subject: [PATCH] a few more updates to tests

---
 lib/common/api/deprecate.js   |  3 +-
 spec/api-deprecations-spec.js | 78 +++++++++++++++++------------------
 2 files changed, 41 insertions(+), 40 deletions(-)

diff --git a/lib/common/api/deprecate.js b/lib/common/api/deprecate.js
index 97ed3551b545..6d041ca0de5c 100644
--- a/lib/common/api/deprecate.js
+++ b/lib/common/api/deprecate.js
@@ -11,7 +11,8 @@ const deprecate = function (oldName, newName, fn) {
 }
 
 // The method is renamed.
-deprecate.rename = function (object, oldName, newName) {
+deprecate.rename = (object, oldName, newName) => {
+  console.log('we are here')
   let warned = false
   const newMethod = function () {
     if (!(warned || process.noDeprecation)) {
diff --git a/spec/api-deprecations-spec.js b/spec/api-deprecations-spec.js
index 44e20b241739..0f83de26224c 100644
--- a/spec/api-deprecations-spec.js
+++ b/spec/api-deprecations-spec.js
@@ -7,44 +7,44 @@ describe.only('deprecations', () => {
     process.throwDeprecation = true
   })
 
-  it('allows a deprecation handler function to be specified', () => {
-    const messages = []
+  // it('allows a deprecation handler function to be specified', () => {
+  //   const messages = []
+  //
+  //   deprecations.setHandler((message) => {
+  //     messages.push(message)
+  //   })
+  //
+  //   deprecate.log('this is deprecated')
+  //   assert.deepEqual(messages, ['this is deprecated'])
+  // })
+  //
+  // it('returns a deprecation handler after one is set', () => {
+  //   const messages = []
+  //
+  //   deprecations.setHandler((message) => {
+  //     messages.push(message)
+  //   })
+  //
+  //   deprecate.log('this is deprecated')
+  //   assert(typeof deprecations.getHandler() === 'function')
+  // })
+  //
+  // it('returns a deprecation warning', () => {
+  //   const messages = []
+  //
+  //   deprecations.setHandler((message) => {
+  //     messages.push(message)
+  //   })
+  //
+  //   deprecate.warn('old', 'new')
+  //   assert.deepEqual(messages, [`'old' is deprecated. Use 'new' instead.`])
+  // })
 
-    deprecations.setHandler((message) => {
-      messages.push(message)
-    })
-
-    deprecate.log('this is deprecated')
-    assert.deepEqual(messages, ['this is deprecated'])
-  })
-
-  it('returns a deprecation handler after one is set', () => {
-    const messages = []
-
-    deprecations.setHandler((message) => {
-      messages.push(message)
-    })
-
-    deprecate.log('this is deprecated')
-    assert(typeof deprecations.getHandler() === 'function')
-  })
-
-  it('returns a deprecation warning', () => {
-    const messages = []
-
-    deprecations.setHandler((message) => {
-      messages.push(message)
-    })
-
-    deprecate.warn('old', 'new')
-    assert.deepEqual(messages, [`'old' is deprecated. Use 'new' instead.`])
-  })
-
-  it('throws an exception if no deprecation handler is specified', () => {
-    assert.throws(() => {
-      deprecate.log('this is deprecated')
-    }, /this is deprecated/)
-  })
+  // it('throws an exception if no deprecation handler is specified', () => {
+  //   assert.throws(() => {
+  //     deprecate.log('this is deprecated')
+  //   }, /this is deprecated/)
+  // })
 
   // it('deprecates a property', () => {
   //   deprecate.property(object, property, method)
@@ -60,8 +60,8 @@ describe.only('deprecations', () => {
 
   it('renames a method', () => {
     assert(typeof ipcRenderer.sendSync === 'function')
+    assert(typeof ipcRenderer.sendChannelSync === 'undefined')
     deprecate.rename(ipcRenderer, 'sendSync', 'sendChannelSync')
-    assert(typeof ipcRenderer.sendSync === 'undefined')
-    // assert(typeof ipcRenderer.sendChannelSync === 'function')
+    assert(typeof ipcRenderer.sendChannelSync === 'function')
   })
 })