mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
10855 commits 9 branches 364 tags 290 MiB
Commit graph

8605 commits

Author SHA1 Message Date
Dan Stillman
76a1535a60 Full-text indexing improvements 
- Use full-text cache file from syncing if available when reindexing via
  info pane or Rebuild Index → Index Unindexed Items. Only discard it for
  full index rebuild. This allows Index Unindexed Items to be used to
  force immediate processing of queued content from syncing and avoids
  unnecessary syncing back of identical content. Previously, the cache
  file was used for a manual index only when the local file didn't exist.
- When rebuilding index, don't clear indexed items with missing local
  file that are missing stats due to a pre-411180ef bug.
- indexItems() now takes an 'options' object as its second parameter
- Minor code cleanup
 2020-03-09 01:19:52 -04:00
Dan Stillman
411180ef83 Full-text indexing fixes 
- Don't clear item's index stats (and show "Unknown") when an item is
  reindexed remotely and the content matches the local content
- Always update an item's state and its stats in the same query, to
  avoid incorrect feedback immediately after indexing
- Clean up `setItemContent()` tests
 2020-03-06 03:11:16 -05:00
Dan Stillman
2645f0de12 Fix "extra is null" error (also fixed via API) 2020-03-03 00:23:38 -05:00
Dan Stillman
da5e8c549e Convert Zotero fields in Extra to CSL fields for citeproc-js 2020-03-02 01:38:10 -05:00
Dan Stillman
83cc65eea6 Fix parsing of CSL date fields in extractExtraField() 2020-03-02 01:34:27 -05:00
Dan Stillman
78b5dbaca1 Update locales from Transifex 2020-02-29 16:38:13 -05:00
Dan Stillman
691d0ca9d1 Allow saved searches to be edited or deleted on error 
E.g., "too many SQL variables"

Fixes #1734
 2020-02-29 16:38:13 -05:00
Dan Stillman
8170cf09de Fix Editor sorting with >1 editor 
Follow-up to eec0f00784
 2020-02-26 14:45:48 -05:00
Dan Stillman
e51a229e54 Update locales from Transifex 2020-02-24 13:25:50 -05:00
Dan Stillman
8822982199 Fix drop-downs in timeline (regression from 5.0.78) 
Fixes #1773
 2020-02-24 13:16:31 -05:00
Dan Stillman
b7901ec8dc Add "English (Canada)" to locales menu 
en-CA is now a valid locale after zotero-standalone-build@46f3da068
(though the use of ISO date strings is the only difference).
 2020-02-23 21:35:56 -05:00
Brenton M. Wiernik
479edcb68a Change label for Computer Program to Software 
https://forums.zotero.org/discussion/81522/add-video-game-as-a-source#latest
 2020-02-22 13:20:27 -05:00
Dan Stillman
a9dee2f487 Item::fromJSON(): Remove invalid-for-type Type-mapped fields 
"Type: [val]` in Extra means Item Type to citeproc-js, and Type values
from translators mostly aren't going to be useful if the item type
doesn't have a Type-mapped field.

https://forums.zotero.org/discussion/comment/348864/#Comment_348864
 2020-02-17 11:39:35 -05:00
Dan Stillman
b2bf60e1d7 Item.fromJSON(): Dedupe invalid-for-type fields when storing in Extra 
3de54455f6 removed redundant base-mapped fields when a valid-for-type
field was also set, but that still left duplicate fields in Extra when a
valid field wasn't set. This will happen until translators (most notably
Embedded Metadata) are fixed to stop setting redundant fields.

https://forums.zotero.org/discussion/81262/translator-error-sage-lots-of-extra-data-in-extra
 2020-02-17 00:22:34 -05:00
Dan Stillman
b41734924d Further fixing of "Too many sync requests" error 
Follow-up to 804a898c98

Addresses #1788
 2020-02-16 18:05:45 -05:00
Tom Najdek
8f1acad2d8 Allow session history in a hidden browser 
Allows loaded pages to use window.history object without triggering
NS_ERROR_FAILURE
 2020-02-16 13:33:09 -05:00
Dan Stillman
804a898c98 Hopefully fix "Too many sync requests" after file upload 412 
Addresses #1788
 2020-02-16 13:06:49 -05:00
Dan Stillman
5c95d4e0ba Additional logging for "Item collection not found" error in toJSON() 2020-02-16 12:43:46 -05:00
Dan Stillman
a53f363b8d Additional fix for search crash with includeParentsAndChildren 
Follow-up to 76081ab05
 2020-02-11 13:09:54 -05:00
Adomas Venčkauskas
1db3fc0b49 Fix a benign citation dialog error when pressing ESC to quit 2020-02-11 15:24:41 +02:00
Adomas Venčkauskas
43a38d31a7 Fix locator strings (p123) not working when editing a citation with items present 2020-02-11 15:24:41 +02:00
Dan Stillman
76081ab05f Fix crash when search uses no-op condition and includeParentsAndChildren 
E.g., a nonexistent saved search
 2020-02-11 00:23:45 -05:00
Dan Stillman
61684d8899 Fix missing bottom border of toolbar on Windows 2020-02-10 22:24:27 -05:00
Dan Stillman
2a804d5d4a Fix zotero://open-pdf links on Windows if no handler is set in registry 2020-02-09 14:07:11 -05:00
Dan Stillman
4290f26d7c Don't search child items in "Title, Creator, Year" mode 
They can't match, so there's no need to include them. This should speed
up "Title, Creator, Year" searches.
 2020-02-05 09:27:06 -05:00
Adomas Venčkauskas
8fd83795e8 Remove MacWord plugin IPC pipe initialization 
Moved to MacWord plugin codebase:
zotero/zotero-word-for-mac-integration#6adf8a7
 2020-02-05 16:23:14 +02:00
Dan Stillman
86a5c46b1e Find Available PDF: Don't mark URLs that redirect as tried 
https://forums.zotero.org/discussion/81182
 2020-02-02 23:47:40 -05:00
Dan Stillman
eec0f00784 Fix sorting by editor in Creator column (since 5.0.78) 2020-01-29 13:39:59 -05:00
Dan Stillman
851af7f45b Don't save library catalog from translation if not valid for item type 
Fixes #1781
 2020-01-28 20:20:07 -05:00
Dan Stillman
4e11c7927d Don't skip creator lines in Extra in fromJSON 
Regression in 3de54455f6
 2020-01-27 22:01:25 -05:00
Adomas Venčkauskas
39d7f22981 Fix some drag and drop issue in the citation dialog 
See https://forums.zotero.org/discussion/81063/beta-rearranging-citations-in-quick-citation-window
 2020-01-27 11:54:22 +02:00
Dan Stillman
8cac7f63f4 Update locales from Transifex, including new connector files 2020-01-26 03:29:23 -05:00
Dan Stillman
48741100a5 Don't try to pull retractions list from server at startup during tests 
This causes problems with filtered test runs, since the request is
cancelled and the long response gets dumped to the console, making the
test result hard to find.
 2020-01-26 03:29:23 -05:00
Dan Stillman
3de54455f6 Automatically save unknown/invalid fields to Extra in non-strict mode 
This is a prerequisite for starting to use new fields in translators,
since otherwise switching from, say, storing originalDate in Extra to
using an originalDate field would cause the value to be lost in clients
without the newer schema.

Closes #1504
 2020-01-26 03:29:23 -05:00
Dan Stillman
55c88dc91c Fix broken string in nb-NO locale that causes a crash in My Publications 2020-01-22 12:12:55 -05:00
Dan Stillman
98e637d36a Update locales from Transifex 2020-01-21 19:23:41 -05:00
Dan Stillman
9ff88bdf6c Enable Norwegian Bokmål 2020-01-18 11:46:05 -05:00
Dan Stillman
c342618e63 Update locales from Transifex 2020-01-17 18:08:01 -05:00
Adomas Venčkauskas
23550f2951 More citation dialog locator fixes 
Both typing 123 and typing p.123 adds the locator to the most
recently added node
 2020-01-16 11:51:40 +02:00
Adomas Venčkauskas
75465e9096 Some more locator input and locking improvements when citations are resorted 
See #1776
 2020-01-16 11:40:18 +02:00
Adomas Venčkauskas
c70c07bb2e Fix a citation dialog error when the dialog contents are cleared 2020-01-16 11:07:42 +02:00
Adomas Venčkauskas
09dead3a2a Fix more ways that citation dialog textcursor can end up inside bubbles 
See 5a1e3296, 5fa97957
 2020-01-16 10:58:28 +02:00
Adomas Venčkauskas
c6961b26e4 Improve citation dialog locator experience with locator locking. Closes #1776 2020-01-16 10:35:09 +02:00
Adomas Venčkauskas
70d0dc8e14 Restore ability to type page numbers after search terms to set locator 
Regression in 7c1845b3. Closes #1774
 2020-01-13 13:22:45 +02:00
Dan Stillman
1a790c0c3f Update submodules 2020-01-06 16:04:57 -05:00
Dan Stillman
4645f76b8b Update locales from Transifex 2020-01-06 16:02:47 -05:00
Dan Stillman
857c42c40b Allow additional characters in URL scheme for attachments/launchURL() 
https://forums.zotero.org/discussion/comment/345977/#Comment_345977
 2020-01-06 15:47:57 -05:00
Philipp Zumstein
066ec123d0 Update newWeb.js 2020-01-06 15:12:18 -05:00
Adomas Venčkauskas
7c1845b3af Citation dialog search improvements. Closes #1770. Closes #1499 
Allows "p123" in addition to ":123" and "p.123" when specifying
the locator;
Allows searches with numbers only.
 2020-01-06 14:23:41 +02:00
Adomas Venčkauskas
51792ba242 Fixes citation dialog locator string not working. Closes #1771 
Regression in 5a1e329
 2020-01-06 14:23:41 +02:00
Dan Stillman
3d2afa9c7f Additional adjustments to URL handling 
Follow-up to df40ee7216

- Restore opening of non-HTTP URL schemes in link attachments
- Remove scheme whitelist for link attachments, since it's not enforced
  via the API anyway and we prompt before an external application is
  opened. Instead, just block a few schemes (e.g., 'javascript') from
  launching.

TODO:

- Provide some way to change/reset an application association if the
  user checks the box to automatically open that scheme.
- Show an error message if a link attachment with an invalid URL is
  double-clicked
 2020-01-04 02:30:12 -05:00
Dan Stillman
8172f00941 Fix loading of reports and timelines 
Regression from df40ee72
 2020-01-04 02:29:52 -05:00
Dan Stillman
b9d5c33993 Allow setting a cookie sandbox for Zotero.Utilities.Internal.saveURI() 
This isn't used or tested.
 2020-01-04 02:29:52 -05:00
Dan Stillman
6070743ff0 Fix Nextcloud WebDAV syncing 
Add Zotero.HTTP.CookieBlocker mechanism to block storing and sending
of all cookies for a given URL prefix, and use that for the configured
WebDAV URL.

https://forums.zotero.org/discussion/80429/sync-error-in-5-0-80
 2020-01-04 02:29:52 -05:00
Dan Stillman
8c8140e74e Fix hiding of password in WebDAV error messages and debug output 2020-01-02 05:04:02 -05:00
Dan Stillman
46b5876bbb Update locales from Transifex 2020-01-02 02:23:27 -05:00
Dan Stillman
d9be6c3ce2 Update login manager corruption error message for Fx60 files 2020-01-02 01:13:16 -05:00
Dan Stillman
bc7b2cb3d5 Fix extension installation failure message 
And fix logged error when starting an extension installation

https://groups.google.com/d/topic/zotero-dev/rP42v7OF9N0/discussion
 2020-01-01 23:22:12 -05:00
Adomas Venčkauskas
5fa979575e Fix quick format bubble drag-and-drop (see 5a1e3296) 2019-12-31 11:35:13 +02:00
Dan Stillman
991e542888 Fix broken autocomplete popup when editing a saved search 
https://forums.zotero.org/discussion/comment/345646/#Comment_345646

This is probably the actual fix for what I was trying to fix in
360f034b5, and I couldn't reproduce it because it was about saved
searches.
 2019-12-30 02:39:10 -05:00
Adomas Venčkauskas
5a1e329618 Fix being unable to place the cursor in between bubbles in the citation dialog 
Regression in Fx60
 2019-12-23 13:25:02 +02:00
Dan Stillman
0b9f463b9f Fix parsing of 'yesterday'/'today'/'tomorrow' in access date field 
Regression from 5.0.78
 2019-12-23 03:10:43 -05:00
Dan Stillman
9c380c362a Hopefully fix 503 from NextCloud (since 5.0.78) 
https://forums.zotero.org/discussion/comment/344790/#Comment_344790
 2019-12-22 16:32:36 -05:00
Dan Stillman
8fe33dc91c Fix loading of compressed global schema from DB on downgrade 2019-12-21 05:09:01 -05:00
Dan Stillman
f5d544bc15 Generate label if type/field name isn't available in global schema 
E.g., show "Foo Bar" for field fooBar if not available

This could happen after downgrading if the global schema couldn't be
read from the DB for some reason.
 2019-12-21 05:09:01 -05:00
Dan Stillman
fda5df9a82 Fix display of editors in Creator column in new databases 
Regression in 5.0.78
 2019-12-21 05:09:01 -05:00
Dan Stillman
85a3f03002 Fix display of pre-1000 dates in Year column and Quick Format 
And avoid "0000" in Year column if date value but unparsed year
 2019-12-19 03:23:51 -05:00
Dan Stillman
b7dc0d8b0a Fix parsing of pre-1000 years 
If a leading zero (e.g., '068'), parse as actual year instead of
19xx/20xx.
 2019-12-19 02:15:36 -05:00
Dan Stillman
6963016c91 Fixes #1761, Repeating of autocompleted tags 
Regression in 5.0.78
 2019-12-19 01:36:20 -05:00
Dan Stillman
df40ee7216 Adjust URL launching behavior 
- Support launching plausible HTTP URLs without schemes from
  Zotero.loadURI(), and use that when launching from URL field
- Show correct cursor feedback on URL label -- only show pointer if the
  URL is launchable
- Don't launch non-HTTP URLs (e.g., zotero://) from URL field
- Don't open HTTP URLs in viewer when using ZoteroPane.launchURI()
 2019-12-16 14:56:06 -05:00
Dan Stillman
537aa15842 Fix "Report Errors…" button in Utilities.Internal.errorPrompt() prompt 
E.g., the button in an unknown WebDAV error dialog
 2019-12-16 14:56:06 -05:00
Adomas Venčkauskas
88c4cd1a09 Doc integration: fix a rtf wrapper being added to html output 2019-12-11 10:44:24 +02:00
Dan Stillman
d2e14cfff4 Fix autocomplete in Advanced Search 
Since 5.0.78
 2019-12-10 23:34:16 -07:00
Dan Stillman
d2b3ca0cca Remove ellipsis from "RTF Scan" menu item 
For consistency with new separate "ODF Scan" menu item from plugin
 2019-12-10 14:25:17 -07:00
Dan Stillman
bbbd02444b Restore 'yesterday'/'today'/'tomorrow' parsing for dates in searches 
Follow-up to a549a64de9, which removed it from strToDate()
 2019-12-06 03:12:48 -07:00
Dan Stillman
c67e29adc7 Fx60: Fix text links in About pane and preferences 2019-12-05 17:58:47 -07:00
Dan Stillman
6b7b57da3c Remove accidentally committed files from 4077428b4 2019-12-04 02:56:42 -07:00
Dan Stillman
87c3ef6aca Fx60: Fix CSL 0.8 style import 2019-12-04 01:27:12 -07:00
Dan Stillman
22a1b5b2ac Update locales from Transifex 2019-12-03 20:01:00 -07:00
Dan Stillman
381c5fc8d8 Adjust spacing of libraries-to-sync checkmark on Linux 
Follow-up to 6af5732fca
 2019-12-03 15:55:41 -07:00
Dan Stillman
6af5732fca Fix checkmark in libraries-to-sync window on Windows 
And switch to Unicode green checkmark and red prohibited characters on
all platforms, which fixes #1675.

The treecol checkmark stopped working on Windows in Fx60.
 2019-12-03 15:33:31 -07:00
Dan Stillman
f7d895ab52 Fix database after direct upgrade from Zotero 4 to 5.0.78-79 2019-12-03 14:03:22 -07:00
Dan Stillman
d9edf2965a Add IF EXISTS to DROP statements in schema update steps 
https://forums.zotero.org/discussion/80291/zotero-standalone-wont-open-database-upgrade-error
 2019-12-02 12:22:46 -07:00
Dan Stillman
222870d3c7 Don't update item type menus within transaction when updating schema 
This caused an error reported here, though I can't reproduce it:

https://forums.zotero.org/discussion/80287/zotero-database-upgrade-error
 2019-12-02 04:39:19 -07:00
Dan Stillman
858de5e6f2 Update locales from Transifex 2019-12-01 19:00:15 -07:00
Dan Stillman
61cebbd8f7 Fix display of a couple WebDAV verification errors 
"spec is undefined"

Fixes #1745
 2019-12-01 03:39:54 -07:00
Dan Stillman
4077428b4e Update locales from Transifex 2019-12-01 01:42:53 -07:00
Dan Stillman
88b1e10b44 Update locales from Transifex 2019-11-30 01:56:54 -07:00
Dan Stillman
76f1f9cae6 Use standard context menu in HTML input boxes 
This fixes the context menu for text fields in the new React-based tags
box.
 2019-11-30 00:43:42 -07:00
Dan Stillman
0fb9548326 Fix tags box context menu 2019-11-29 23:28:23 -07:00
Dan Stillman
fbb54a7621 Fix "string is undefined" export error 
Regression from a549a64de9
 2019-11-29 01:50:43 -07:00
Dan Stillman
4d7062fc43 Remove Zotero.Utilities.Internal.normalize() 
It no longer works in Fx60, and String.prototype.normalize() has been
available since 2014, so that should just be used instead.
 2019-11-26 23:18:17 -07:00
Dan Stillman
8c7677a009 Fix out-of-memory error syncing collections nested inside each other 
It shouldn't be possible for collections to be nested this way, if it
happens, it shouldn't result in an infinite loop.

This removes one of the parent assignments at sync time.
 2019-11-26 15:30:43 -07:00
Dan Stillman
8417ad7c80 Add extensions.zotero.reopenPanesOnRestart hidden pref 
Closes #1752
 2019-11-21 23:51:37 -07:00
Dan Stillman
98a0699f85 Properly disable React tags box in read-only mode 2019-11-15 04:06:21 -05:00
Dan Stillman
cc3f994207 Fix crash when clicking off an open tag to another item 
Regression in React tags box
 2019-11-13 05:33:16 -05:00
Dan Stillman
5ba5e70b9d Fix overflow issues in React tags box 
- Properly truncate and ellipsize long tags
- Show scrollbar if tags go off the bottom of the pane

These both improve on the pre-React version, which didn't properly
truncate tags (at least in the current version, though I think it used
to) and scrolled the Add button off the top of the screen.
 2019-11-13 05:31:12 -05:00
Dan Stillman
3e3e0b016d Move "Manage Attachments" to the Tools menu 2019-11-12 18:36:16 -05:00
Dan Stillman
a549a64de9 Remove 'yesterday'/'today'/'tomorrow' parsing from strToDate() 
I don't think this ever should've been here. It was added in 2010 but
then added to itembox.xml a couple weeks later in d500b50e2, since
that's where the conversion should happen.

Closes #1749
 2019-11-12 02:13:05 -05:00
Dan Stillman
b0eb048bce Fix New Item menu when tag pane is focused 
Regression from 5791ffeb1
 2019-11-12 01:37:57 -05:00