Cheng Zhao
00d023cd71
Merge pull request #9725 from danielma/dma/native-tab-new-button
...
Add "New Tab" button for Native macOS Tabs
2017-06-26 15:07:10 +09:00
Samuel Attard
7eb14243eb
Refactor notification options
2017-06-24 21:39:06 +10:00
Samuel Attard
17e737eba2
s/label/text
2017-06-23 21:04:39 +10:00
Samuel Attard
4f0d48f164
Add support for notification actions on macOS
2017-06-23 20:50:20 +10:00
Shubham
80e35b6682
🍎 Fix treat packaged app as directory
2017-06-22 17:10:22 -04:00
Birunthan Mohanathas
eb19562316
Fix crash when using file chooser in BrowserView
...
The crash was a segfault caused by a null `WebDialogHelper::window_`.
2017-06-21 16:26:38 -07:00
Shubham
1b8963ff6e
🍎 Fix full screen when resizable is set to true
2017-06-20 16:11:28 -04:00
Tony Ganch
471f6e0fa5
Fix invisible titlebar on macOS 10.13
2017-06-19 14:34:37 +02:00
Shubham
25c651c40a
add alwaysShowTitleTextInFullscreen flag
2017-06-17 20:45:29 -04:00
Samuel Attard
231d4f7581
Use the isdigit helper
2017-06-17 03:52:19 +10:00
Shubham
12b90a2304
🐛 store current level fix
2017-06-15 18:05:58 -04:00
Kevin Sawicki
e8911fe48c
Merge pull request #9610 from shubham2892/incorrect-file-extension-with-showSaveDialog-fix
...
Fix incorrect extension when filters is used
2017-06-15 10:29:11 -07:00
Kevin Sawicki
15dd0eb583
Add braces to if statement
2017-06-15 10:27:34 -07:00
Shubham
8dbb8ccbab
add mouse-enter and mouse-exit events for tray
2017-06-14 18:00:29 -04:00
Kevin Sawicki
dae27de504
Merge pull request #9588 from electron/poiru/dialog-default-file-name
...
Use last selected directory when using default file name in dialog.showSaveDialog()
2017-06-14 14:41:45 -07:00
Kevin Sawicki
45dc6fc04f
Merge pull request #9645 from dharders/issue6036-fix-windows-fullscreen-startup-toggle
...
Fix unresponsive app after fullscreen->normal state toggle (Windows)
2017-06-14 14:10:00 -07:00
Cheng Zhao
fd0a742683
Merge pull request #9700 from brenca/pdf-zoom-improvements
...
Zoom controller improvements
2017-06-14 19:15:28 +09:00
Hari Juturu
421bf71b98
Adding no-sandbox to non sandbox webcontents
2017-06-13 18:45:24 -07:00
dharders
112f4656c3
👕 fix lint warning
2017-06-14 11:30:33 +10:00
dharders
265ab45bd7
🎨 Reuse existing function
2017-06-14 11:05:39 +10:00
Heilig Benedek
a3ec28ddf3
remove unused includes
2017-06-14 00:49:11 +02:00
Yuya Ochiai
be9463b7b7
Add 'All Files (*.*)' filter for <input> file dialog
...
The dialog would filter files as well as Chrome.
2017-06-13 22:33:06 +09:00
Samuel Attard
29dbb93f16
Don't mutate the accelerator character wuth the shift key if it's a number
2017-06-13 20:29:54 +10:00
deepak1556
538b97582a
app: add support for inspect/inspect-brk in forked node process
2017-06-13 00:23:11 +05:30
Daniel Ma
4fb9f825b1
Add "New Tab" button for Native macOS Tabs
...
Adds responders for `newWindowForTab` to `AtomApplicationDelegate` and
`NativeWindowMac`, so that `BrowserWindow`s with a `tabbingIdentifier`
will get the new tab button, and both `app` and `window` will emit a
`new-tab-for-window` event.
2017-06-11 02:26:26 -07:00
Hari Juturu
3ee55d9cd3
lint error
2017-06-08 23:46:37 -07:00
Hari Juturu
7bdd259d2e
Lint error
2017-06-08 23:39:53 -07:00
Hari Juturu
cbbd4a4a3b
Indentation
2017-06-08 23:31:58 -07:00
Hari Juturu
07f550a748
enable-mixed-sandbox option
2017-06-08 23:29:35 -07:00
Kevin Sawicki
4c00176599
Bump v1.7.3
2017-06-08 10:43:50 -07:00
Heilig Benedek
f8d3b363ea
🎨 lint fix
2017-06-08 09:57:24 +02:00
Heilig Benedek
0f4341da42
add zoom behaviour code from chromium and make pdf viewer use manual zoom behaviour to match chromium
2017-06-08 02:15:17 +02:00
Heilig Benedek
a47fe715d1
pass ref part of url to allow #page= for pdf viewer
2017-06-08 02:15:17 +02:00
Shubham
373decd07e
🎨
2017-06-07 19:01:06 -04:00
Shubham
f001377493
🍎 Fix an issue where alwaysOnTop window disappears when restored from the application icon
2017-06-07 12:28:50 -04:00
Kevin Sawicki
7a3a092c72
Merge pull request #9687 from electron/fix-custom-window-button-view
...
Simplify customButtonsOnHover implementation
2017-06-06 18:54:04 -07:00
Birunthan Mohanathas
391c07b80a
Simplify custom window button positioning
2017-06-07 03:33:33 +03:00
Kevin Sawicki
dc5221d551
Guard against null window like before
2017-06-06 17:02:23 -07:00
Birunthan Mohanathas
f60315141b
Remove unnecessary if check
2017-06-07 01:19:53 +03:00
Birunthan Mohanathas
3106478510
Rename SemaphoreView to CustomWindowButtonView
2017-06-07 01:18:22 +03:00
Birunthan Mohanathas
7d2226e05e
Let Chromium manage document.visibilityState and document.hidden
...
Chromium already includes the necessary plumbing to manage the
visibility properties and `visibilitychange` event so this gets rid of
most of our custom logic for `BrowserWindow` and `BrowserView`.
Note that `webview` remains unchanged and is still affected by the issues
listed below.
User facing changes:
- The `document` visibility properties and `visibilitychange` event are
now also updated/fired in response to occlusion changes on macOS. In
other words, `document.visibilityState` will now be `hidden` on macOS
if the window is occluded by another window.
- Previously, `visibilitychange` was also fired by *both* Electron and
Chromium in some cases (e.g. when hiding the window). Now it is only
fired by Chromium so you no longer get duplicate events.
- The visiblity state of `BrowserWindow`s created with `{ show: false }`
is now initially `visible` until the window is shown and hidden.
- The visibility state of `BrowserWindow`s with `backgroundThrottling`
disabled is now permanently `visible`.
This should also fix #6860 (but not for `webview`).
2017-06-06 15:16:01 -07:00
Kevin Sawicki
4989b21dbc
Autorelease semaphore view
2017-06-05 14:28:58 -07:00
Kevin Sawicki
3a2abde804
Add TODO for hidden-inset deprecation
2017-06-05 13:58:50 -07:00
Kevin Sawicki
9537303e9a
Remove unused customWindowButtons switch
2017-06-05 13:57:25 -07:00
Kevin Sawicki
de0daa2481
Autorelease tracking area
2017-06-05 13:48:30 -07:00
Kevin Sawicki
7d10bf229d
Switch to titleBarStyle for custom window buttons on hover
2017-06-05 13:30:32 -07:00
Kevin Sawicki
566e04f1c0
🎨
2017-06-05 13:13:16 -07:00
Kevin Sawicki
37ba1b0a6b
Declare mouse inside variable in interface
2017-06-05 12:55:39 -07:00
Kevin Sawicki
1493d6763c
Make custom window buttons an option
2017-06-05 12:50:18 -07:00
Kevin Sawicki
2880cfdc9c
🎨 Minor formatting tweaks
2017-06-05 11:08:05 -07:00
mst128256
96251e55de
Removed commented code
2017-06-05 10:41:52 -07:00
mst128256
9b4664daa5
Area near the top border in frameless window is clickable
2017-06-05 10:41:52 -07:00
Kevin Sawicki
9a362eed53
Merge pull request #9572 from shubham2892/api-height-menubar-macos
...
API height menubar macos
2017-06-05 10:35:16 -07:00
Kevin Sawicki
653ef6f839
🎨
2017-06-05 10:33:46 -07:00
deepak1556
50ac7b2edd
Revert "Merge pull request #8724 from electron/defer_load_url"
...
Possible cause for #9121
This reverts commit 886b47e713479af3c9e2
2017-06-05 19:04:21 +05:30
Shubham
c2603aaac2
🎨 Add documentation
2017-06-03 11:48:18 -04:00
Shubham
e9aa9eaf5e
🎨 code structure fix
2017-06-03 10:56:37 -04:00
Hari Juturu
3ba0e288f7
fix lint error
2017-05-31 23:20:13 -07:00
Hari Juturu
b5239754ba
Enable sandbox on webview
2017-05-31 23:01:14 -07:00
dharders
4c09b357a7
🏁 Fix #6036 . Ensure window is visible after fullscreen toggle
2017-06-01 14:38:51 +10:00
Kevin Sawicki
9250b559f9
Merge pull request #9623 from miniak/gpu-info
...
Add app.getGPUFeatureStatus
2017-05-31 08:11:50 -07:00
Cheng Zhao
e82af41591
Merge pull request #9269 from electron/main-notifications
...
Notifications from the main process
2017-05-31 17:21:05 +09:00
Cheng Zhao
5fa2831756
Coding style fixes
2017-05-31 16:17:29 +09:00
Shubham
62d9bf9bae
🎨 ✅ code comments and test for getMenuBarHeight function
2017-05-30 17:26:02 -04:00
Kevin Sawicki
bf2fca3dd1
Use base::DictionaryValue converter
2017-05-30 13:00:55 -07:00
Milan Burda
0ecfb4e2f8
Add app.getGPUFeatureStatus
2017-05-30 20:35:14 +02:00
Samuel Attard
3938373ecb
Fix linting errors and add isSupported
2017-05-30 20:27:24 +10:00
Samuel Attard
686b1388b1
Fix linting issues
2017-05-30 19:12:36 +10:00
Samuel Attard
5048425e6e
Update implementation as per feedback
2017-05-30 19:06:51 +10:00
Samuel Attard
6cdfb43e4e
Emit a close event
2017-05-29 21:33:43 +10:00
Samuel Attard
9aa6b83f86
Fix compilation and click events on macOS
2017-05-29 21:22:44 +10:00
Samuel Attard
c741b584a1
Remove OS specific implementations
2017-05-29 21:18:18 +10:00
Samuel Attard
058bdfbced
Use NotificationPresenter - macOS
2017-05-29 20:02:33 +10:00
Cheng Zhao
7d994f2a9e
Merge pull request #9535 from brenca/datalist-element
...
Add datalist element support
2017-05-29 16:01:40 +09:00
Shubham
217ddd629d
🍎 Fix incorrect extension when filters is used
2017-05-28 15:20:22 -04:00
Kevin Sawicki
44862a131c
Bump v1.7.2
2017-05-26 13:33:15 -07:00
Kevin Sawicki
0dff863e30
Add comment about CreateNewGuestWindow origins
2017-05-26 10:10:36 -07:00
Kevin Sawicki
dbd240a7cb
Return null from native window.open when allowpopups is unset
2017-05-26 10:10:36 -07:00
Kevin Sawicki
7baf472c0f
Implement BrowserPluginGuestDelegate::CreateNewGuestWindow for nativeWindowOpen
2017-05-26 10:10:36 -07:00
Kevin Sawicki
c43c3b3d80
Revert "protocol: use streaming interface between fetcher and requestjob"
...
This reverts commit 71b5d946e0
2017-05-26 09:47:22 -07:00
Kevin Sawicki
14c43f654f
🎨
2017-05-26 09:25:35 -07:00
Kevin Sawicki
1e4dd9b163
Store process type as int
2017-05-26 08:53:26 -07:00
Kevin Sawicki
7794cabd13
🎨
2017-05-26 08:35:43 -07:00
Kevin Sawicki
d6e626c7e3
Remove crashed render processes from metrics
2017-05-26 08:32:08 -07:00
Kevin Sawicki
b5879b7399
🎨 Minor formatting/doc changes
2017-05-26 07:51:17 -07:00
Heilig Benedek
192cd7787b
move popup related code to nativewindow
2017-05-26 03:39:36 +02:00
Birunthan Mohanathas
19555bbab2
Use last selected directory when using default file name in dialog.showSaveDialog()
...
Prior to this change, attempting to use
`dialog.showSaveDialog({ defaultPath: 'foo.png' })` would open the save
dialog to the current directory with the default file name set to
`foo.png`. We now use the last selected directory instead of the current
directory.
Absolute paths are not affected by this change.
2017-05-26 02:18:23 +03:00
Hari Krishna Reddy Juturu
c4e5ba6015
Fixing indentations
2017-05-24 21:15:34 -07:00
Hari Krishna Reddy Juturu
e5a9ef296d
Using process handle from RenderProcessHost
2017-05-24 21:07:35 -07:00
Hari Juturu
939747945e
Adding CPU & Memory metrics for App
2017-05-24 21:07:35 -07:00
Shubham
b2f1cdfbae
Add API to get top bar height on macOS
2017-05-23 22:24:56 -04:00
gellert
039908a244
various fixes for macos
2017-05-23 11:41:59 +02:00
rreimann
25015c4c63
Fix naming and formatting
2017-05-22 14:14:59 -07:00
rreimann
791486433d
Extract common code into IsPreferenceEnabled method
2017-05-22 14:14:59 -07:00
rreimann
65da983ccb
Move preferences check to OnPdfResourceIntercepted
2017-05-22 14:14:59 -07:00
rreimann
7982754958
Fix linting violations
2017-05-22 14:14:59 -07:00
rreimann
1b75e45a62
Suppress pdf plugin dispatch if plugins are disabled
2017-05-22 14:14:59 -07:00
Kevin Sawicki
6b7ec621e3
Throw error when non-Buffer specified instead of crashing
2017-05-22 13:53:58 -07:00
Kevin Sawicki
5adf9c47fc
Remove buffers option since only a single is supported
2017-05-22 13:49:26 -07:00
Ryohei Ikegami
8f35afd941
Include map
2017-05-22 13:43:21 -07:00
Ryohei Ikegami
f2471cb1b7
Rename buffer -> buffers
2017-05-22 13:43:21 -07:00
Ryohei Ikegami
03fdc7aa28
Add buffer support in clipboard.write()
2017-05-22 13:43:21 -07:00
Ryohei Ikegami
66cc07d8e9
Add clipboard.writeBuffer
2017-05-22 13:43:21 -07:00
Samuel Attard
d1fc832ca0
Update for the brightray move
2017-05-23 02:18:34 +10:00
Samuel Attard
e7569ed499
Remove shell link validation, users should do this themselves
2017-05-23 02:05:13 +10:00
Samuel Attard
da31615de5
Basic linux impl
2017-05-23 02:05:13 +10:00
Samuel Attard
c6196810a6
Code cleanup
2017-05-23 02:05:13 +10:00
Samuel Attard
03688b9415
Get image notifications working on Win7 + Win10
2017-05-23 02:05:13 +10:00
Samuel Attard
6bbc4c3113
Support Windows 7 notifications from brightray
2017-05-23 02:05:13 +10:00
Samuel Attard
a4bd26fab0
Fix string16 init on macOS
2017-05-23 02:05:13 +10:00
Samuel Attard
7c38633d1e
Initial semi-working windows implementation
2017-05-23 02:05:13 +10:00
Samuel Attard
5dd4d6a961
macOS implementation of notifications in the main process
2017-05-23 02:05:13 +10:00
Heilig Benedek
df911593d8
Fix menubar animations being incorrect in RTL layout
2017-05-21 22:36:10 +02:00
Heilig Benedek
d5c038a7fb
ci build fix
2017-05-21 20:57:19 +02:00
Heilig Benedek
218e28b136
minor fixes and enable datalist elements in OSR
2017-05-21 19:55:19 +02:00
Heilig Benedek
a95d6b997b
add ability to open popup on second click
2017-05-20 04:21:11 +02:00
Heilig Benedek
4949531f57
🎨 lint fix
2017-05-19 21:52:18 +02:00
Heilig Benedek
f360104bee
add datalist element view
2017-05-19 21:36:37 +02:00
Kevin Sawicki
74b7afbec7
Merge origin/master into enable-webview
2017-05-19 10:17:34 -07:00
Kevin Sawicki
43f7520d4f
Add missing brightray prefix
2017-05-19 08:46:15 -07:00
Kevin Sawicki
db6d75ca90
Merge pull request #9518 from TingPing/tingping/gio-trash
...
Support `gio` as trash implementation
2017-05-19 08:44:56 -07:00
Cheng Zhao
f793db2b2a
Merge pull request #9519 from electron/better-patch
...
Use v8::ArrayBuffer::Allocator inside Node
2017-05-19 17:49:02 +09:00
Kevin Sawicki
97160ffa63
Make isDefault a bool
2017-05-18 10:51:44 -07:00
Kevin Sawicki
aa29bf8019
🎨
2017-05-18 10:26:22 -07:00
Kevin Sawicki
92f14f8d52
printerList() -> getPrinters()
2017-05-18 10:14:55 -07:00
Kevin Sawicki
84a9b6a42d
Merge remote-tracking branch 'origin/master' into renaesop_master
2017-05-18 10:08:40 -07:00
Kevin Sawicki
f556d1924d
Merge pull request #9358 from electron/fetch_job_uaf_patch
...
protocol: use streaming interface between fetcher and requestjob
2017-05-18 09:58:05 -07:00
Cheng Zhao
f4420b449f
Use v8::ArrayBuffer::Allocator inside Node
2017-05-18 16:26:46 +09:00
TingPing
98186c4143
Support gio as trash implementation
...
Ideally this will become the default as `gvfs-trash` is deprecated and nothing more than a wrapper to `gio`
but at least allow easily opting into the modern method.
2017-05-17 23:46:29 -04:00
Kevin Sawicki
bde13353fb
Rename option to webviewTag and default to nodeIntegration value
2017-05-17 13:12:23 -07:00
Kevin Sawicki
837ea884de
Merge remote-tracking branch 'origin/master' into enable-webview
2017-05-17 12:45:29 -07:00
Cheng Zhao
9bed0ffdbf
Merge pull request #9440 from brenca/osr-fixes
...
Additional small OSR fixes
2017-05-17 17:14:27 +09:00
Kevin Sawicki
d8aca08da7
Set _debugWaitConnect on --inspect-brk
2017-05-16 14:50:49 -07:00
Kevin Sawicki
5337b4ad94
Only define ICU constants in release builds
2017-05-16 14:44:28 -07:00
Kevin Sawicki
b549b20d2c
Convert arg string to utf8 on Windows
2017-05-16 14:44:28 -07:00
Kevin Sawicki
a33643c518
Start node inspector agent when --inspect is present
2017-05-16 14:44:28 -07:00
Kevin Sawicki
693f6a24fc
Bump v1.7.1
2017-05-16 12:42:37 -07:00
Kevin Sawicki
350528707b
Return base::ProcessId
2017-05-15 13:29:34 -07:00
Kevin Sawicki
d79ac8d9c1
Merge pull request #9222 from alexstrat/add-os-process-id
...
Add OS pid to web-contents
2017-05-15 13:28:47 -07:00
Kevin Sawicki
e708a45496
Merge pull request #9436 from electron/debug-crash
...
Remove support for --debug/--debug-brk
2017-05-15 08:47:52 -07:00
gellert
af2c5d1845
fixes not expected scale factor change
2017-05-13 00:59:25 +02:00
Kevin Sawicki
ef4bf7ed93
Use status code constant
2017-05-11 15:33:56 -07:00
deepak1556
3c88447be6
protocol: provide default response code for custom request jobs
2017-05-11 15:33:56 -07:00
Kevin Sawicki
718cd8d711
Remove unsupported debugger in node processes
2017-05-11 15:02:27 -07:00
Heilig Benedek
9f682ee36b
fix osr window initial sizing
2017-05-11 23:48:14 +02:00
Kevin Sawicki
4824c24fbc
Remove non-functional node debugger usage
2017-05-11 10:59:51 -07:00
deepak1556
71b5d946e0
protocol: use streaming interface between fetcher and requestjob
2017-05-11 22:52:49 +05:30
Kevin Sawicki
190c9c916e
Merge pull request #9331 from 22222/issue2579
...
Add 'will-prevent-unload' event for #2579 .
2017-05-11 09:04:40 -07:00
Cheng Zhao
1b1c663b32
Merge pull request #8839 from brenca/offscreen-child-window
...
Offscreen rendering enhancements
2017-05-11 20:52:47 +09:00
22222
4044548f3e
Add 'will-prevent-unload' event.
2017-05-11 06:35:35 -05:00
Heilig Benedek
bf58373a40
fix NativeImage size hint crashing when image is created from path
2017-05-11 11:38:34 +02:00
Ryohei Ikegami
7ac93045b7
Merge branch 'master' into native-window-open
2017-05-11 13:51:43 +09:00
Heilig Benedek
a76a4ddff2
🎨 lint fix
2017-05-10 23:04:19 +02:00
gellert
b1095faa71
minor fix for macos
2017-05-10 22:19:05 +02:00
Heilig Benedek
6f80379b30
use computeSize64 instead of getSize
2017-05-10 22:19:05 +02:00
Heilig Benedek
8d1c17e036
remove GetSizeForNewRenderView
2017-05-10 22:19:05 +02:00
Heilig Benedek
5c690ea46e
don't store isolate_ in NativeImage and tune size hints
2017-05-10 22:19:05 +02:00
Heilig Benedek
576b702e8b
update native_mate and use the MarkHighMemoryUsage API to speed up garbage collection
2017-05-10 22:19:05 +02:00
Heilig Benedek
92cc6746b1
resolve errors introduced during rebase
2017-05-10 22:19:05 +02:00
gellert
aa89bc0bb8
use outer webcontents for popups
2017-05-10 22:19:05 +02:00
Heilig Benedek
f03dccadb3
use white gutter color and paint damage rects over when paint starts in software osr
2017-05-10 22:19:05 +02:00
Heilig Benedek
3b94d268eb
lint fix 📝
2017-05-10 22:19:05 +02:00
Heilig Benedek
c54f7f2a8d
use bounds instead of bounds_in_pixel
2017-05-10 22:19:05 +02:00
Heilig Benedek
1fcf6ea73f
add size hints to NativeImages to make node GC aware of the high amount of memory used by the instances
2017-05-10 22:19:05 +02:00
Heilig Benedek
89277dda90
fix leaking of NativeImage instances
2017-05-10 22:19:05 +02:00
Heilig Benedek
704fde1939
port CEF pr that speeds up and simplifies GPU rendering
2017-05-10 22:19:05 +02:00
Heilig Benedek
2f32311292
fix black bars around popups and scaled images when using gpu rendering
2017-05-10 22:19:05 +02:00
gellert
155fef99ae
adds offscreen renderer ipc message to disable external popups
2017-05-10 22:19:05 +02:00
gellert
6b33564056
adds ipc send to disable external popups on macos
2017-05-10 22:19:05 +02:00
Heilig Benedek
ff053bbe06
call InvalidateBounds when popup updates
2017-05-10 22:19:05 +02:00
gellert
062b1ed43e
moves createviewfordwidget method to osrrwhv
2017-05-10 22:19:05 +02:00
Heilig Benedek
bccc25165d
fix mouse wheel event sending typo
2017-05-10 22:19:05 +02:00
Heilig Benedek
8f546313b6
add popup window bounds to damage_rect
2017-05-10 22:19:05 +02:00
Heilig Benedek
c9fa71bdb3
lint fix
2017-05-10 22:19:05 +02:00
Heilig Benedek
20d2ab29ab
Add support for child and popup windows in OSR
2017-05-10 22:19:05 +02:00
Kevin Sawicki
b6319698f1
Bump v1.7.0
2017-05-10 10:42:05 -07:00
Kevin Sawicki
de38461a3f
Update NotifyObserversCertDBChanged call to take no arguments
2017-05-10 10:05:48 -07:00
Kevin Sawicki
fb85b26767
Merge remote-tracking branch 'origin/master' into chrome58
2017-05-10 09:42:19 -07:00
Kevin Sawicki
f0c38b7354
Bump v1.6.9
2017-05-10 08:35:30 -07:00
Kevin Sawicki
65bd0ecaa9
Upgrade to Chrome 58.0.3029.110
2017-05-09 21:14:22 -07:00
Hari Juturu
277c3155a6
use will-create-webview event
2017-05-09 10:12:44 -07:00
Kevin Sawicki
8c856922f3
Merge pull request #9292 from 22222/issue8911
...
Fix #8911
2017-05-09 09:06:26 -07:00
Cheng Zhao
efe23b7595
Use Node's memory allocator for ArrayBuffer
...
For Buffers created in Node, they are usually allocated in Node and
freed by Chromium's allocator, which will cause crashes when Node and
Chromium are using different allocators.
This commit makes Chromium use Node' allocator for ArrayBuffers.
2017-05-09 14:12:39 +09:00
renaesop
dfcc882dcc
Add a test for webcontents.printerList.
2017-05-09 10:38:03 +08:00
renaesop
cba5e96496
Merge remote-tracking branch 'ups/master'
2017-05-09 09:44:24 +08:00
Hari Krishna Reddy Juturu
3321f7d39c
Changing command line option name
2017-05-08 17:27:31 -07:00
Kevin Sawicki
8be4332765
coffee -> js
2017-05-08 14:06:58 -07:00
Kevin Sawicki
3dee76a6c1
🎨
2017-05-08 13:43:13 -07:00
Hari Krishna Reddy Juturu
94d054cf11
Add option to override webview security
2017-05-06 22:10:42 -07:00
Hari Krishna Reddy Juturu
b4a8ed01f1
PR 44648: Enabling creation on webview with node-integration disabled and raising events
...
- Enabling creation on webview with node-integration disabled and raising events
Conflicts:
lib/browser/guest-view-manager.js
2017-05-06 20:50:01 -07:00
Hari Krishna Reddy Juturu
d65c4fe912
CPU Usage requires process metrics to be preserved
2017-05-05 02:38:51 -07:00
Hari Krishna Reddy Juturu
6b51c25820
Exposing cpu & io counters function similar to mem methods
2017-05-04 14:48:37 -07:00
Hari Krishna Reddy Juturu
982c5064d8
Removing extra bool
2017-05-04 14:33:59 -07:00
Hari Krishna Reddy Juturu
8a5aa04756
Adding CPU and I/O metrics to process module
2017-05-04 14:33:59 -07:00
Kevin Sawicki
70e199e255
Merge pull request #9333 from electron/process-memory-info-sandbox
...
Expose `process.get{System,Process}MemoryInfo` to sandbox
2017-05-04 14:17:44 -07:00
Kevin Sawicki
eebae82bc1
Merge pull request #9315 from electron/segmented-control-mode
...
Add mode prop to segmented touch bar control
2017-05-04 14:16:28 -07:00
Kevin Sawicki
59511354fd
Merge pull request #9214 from electron/app-memoryinfo
...
API to get memory of all processes of the app
2017-05-04 14:00:30 -07:00
Hari Krishna Reddy Juturu
ab1bcefe9e
Make pid an integer
2017-05-04 13:37:43 -07:00
Kevin Sawicki
e206aae9fc
🎨 Use snake case
2017-05-04 13:27:42 -07:00
Kevin Sawicki
c59fab0179
Merge pull request #9242 from shiftkey/certificate-addition-windows
...
certificate trust API for Windows
2017-05-03 16:39:00 -07:00
Kevin Sawicki
110611f242
🎨
2017-05-03 16:22:56 -07:00
22222
042b511a27
Fix #8911
2017-05-03 12:47:00 -05:00
Kevin Sawicki
e1d564da6e
Upgrade to Chrome 58.0.3029.96
2017-05-03 08:49:57 -07:00
Samuel Attard
718dc732ad
Add docs and add isSelected arg
2017-05-03 20:25:50 +10:00
Kevin Sawicki
c6c93211be
Merge remote-tracking branch 'origin/master' into chrome58
2017-05-02 09:15:16 -07:00
Brendan Forster
e5648072dc
handle untrusted root as well as self-signed
2017-05-02 11:25:51 +10:00
Kevin Sawicki
a748199833
Bump v1.6.8
2017-05-01 15:09:30 -07:00
Kevin Sawicki
b639dd0c81
Remove unused include/require statement
2017-05-01 10:30:11 -07:00
Kevin Sawicki
f2f6415543
Use v8 to parse message as JSON
2017-05-01 10:30:11 -07:00
Thiago de Arruda
bbe21cce67
Expose more atom_bindings.cc functions to sandbox
2017-05-01 09:12:39 -03:00
deepak1556
0476e2fd3d
destroy browserView webContents asynchronously
2017-05-01 16:53:55 +09:00
deepak1556
c68f41b8d8
destroy new window webContents asynchronously
2017-05-01 16:53:55 +09:00
deepak1556
5e976be43b
remove page-title-updated workaround for #3380
2017-05-01 16:53:55 +09:00
deepak1556
9e3b8ade12
invoke WebContentsDestroyed manually when destruction path is async
2017-05-01 16:53:14 +09:00
deepak1556
f974a6bda9
browser: make destruction of webContents async
2017-05-01 16:53:14 +09:00
Ryohei Ikegami
8b6b512485
Pass nativeWindowOpen flag to isolated init.js
2017-04-30 19:35:41 +09:00
Brendan Forster
14f29e1319
it's 2017 get with the times
2017-04-29 19:29:07 +10:00
Brendan Forster
1ccc2afb03
underscore case all the things
2017-04-29 19:28:42 +10:00
Thiago de Arruda
19b6ba044b
Fix context leak in ObjectLifeMonitor.
...
The RemoteObjectFreer class is keeping the context alive even when the window is
closed. For electron applications that use sandbox, this will cause a memory
leak every time a new window is created with `window.open`.
Close #9191
2017-04-28 11:21:53 -03:00
Samuel Attard
225ccab3d2
Add mode prop to segmented touch bar control
2017-04-28 14:50:58 +10:00
Hari Krishna Reddy Juturu
07b53c0284
Return mate::Dictionary instead of v8::value
2017-04-27 21:07:35 -07:00
HariJ
81bd9fa3a2
fixing mac ut failure
2017-04-27 14:06:53 -07:00
Hari Krishna Reddy Juturu
3d12440a4a
Fixing mac build
2017-04-27 14:06:53 -07:00
Hari Krishna Reddy Juturu
27aad902b8
Adding docs, specs and fixing object returned
2017-04-27 14:06:53 -07:00
Hari Krishna Reddy Juturu
bef7d5a520
API to get memory of all processes of the app
2017-04-27 14:06:53 -07:00
Cheng Zhao
dd2d0b3f4f
Update to Chrome 58.0.3029.81
2017-04-27 18:57:04 +09:00
Cheng Zhao
4c47f2d15e
Update to Node v7.9.0
2017-04-27 17:20:01 +09:00
Cheng Zhao
301ed2d66c
Fix typo when updating code
2017-04-27 16:34:52 +09:00
Cheng Zhao
620a1ca167
Fix unresolved symbol to icu::DateInterval
2017-04-27 16:34:52 +09:00
Cheng Zhao
e6e985c677
Fix linking error with icu symbols
2017-04-27 16:34:52 +09:00
Cheng Zhao
5563cf0dc5
Automatically register secure schemes in renderer
...
Otherwise the behavior of secure schemes would be different with before.
2017-04-27 16:34:52 +09:00
Cheng Zhao
0fb746b350
Fix crash when using secure schemes
2017-04-27 16:34:52 +09:00
Cheng Zhao
fb42a72ad8
Fix building on Windows
2017-04-27 16:34:52 +09:00
Cheng Zhao
8c5fd76286
Fix symbol conflicts in Xlib.h
2017-04-27 16:34:52 +09:00
Cheng Zhao
b3d60bfb3a
Fix building on Linux
2017-04-27 16:34:52 +09:00
Cheng Zhao
97fd383c53
There are a few more new values for ChangeCause
2017-04-27 16:34:52 +09:00
Cheng Zhao
08069e18db
Don't use gzip when uploading crash reports
2017-04-27 16:34:52 +09:00
Cheng Zhao
b2b2d8d9a4
Fix crash on exit
2017-04-27 16:34:52 +09:00
Cheng Zhao
d85b58fdb5
Fix API changes of FrameSubscriber
2017-04-27 16:34:52 +09:00
Cheng Zhao
e43b34b8f8
Use blink::SchemeRegistry over WebSecurityPolicy
...
The latter is removing some APIs we use.
2017-04-27 16:34:52 +09:00
Cheng Zhao
481b04358e
Fix blink API changes
2017-04-27 16:34:52 +09:00
Cheng Zhao
8634f37dfc
Add gen/third_party/WebKit to include dirs
2017-04-27 16:34:52 +09:00
Cheng Zhao
dd3d791cb9
IsolateHolder API has been changed
2017-04-27 16:34:52 +09:00
Cheng Zhao
5fb87f0c1e
ResourceHandler API has been changed
2017-04-27 16:34:52 +09:00
Cheng Zhao
6be10ffef2
Fix more API changes due to name changes
2017-04-27 16:34:52 +09:00
Cheng Zhao
50e3bfa764
Fix API changes of base::Value
2017-04-27 16:34:52 +09:00
Cheng Zhao
9d1b88ed59
Fix API changes in OSR code
2017-04-27 16:34:52 +09:00
Cheng Zhao
fc2d62d5cb
Fix API changes of Chrome58
2017-04-27 16:34:52 +09:00
Cheng Zhao
453cb2c0b4
Upgrade to Chrome 58.0.3029.40
2017-04-27 16:34:52 +09:00
Brendan Forster
a1599cf881
focus on the self-signed certificate flow here
2017-04-27 15:06:23 +10:00
Brendan Forster
5151107c28
tighten up indenting
2017-04-27 15:01:55 +10:00
Brendan Forster
50af70a0e8
Merge branch 'master' into certificate-addition-windows
2017-04-27 14:47:50 +10:00
Brendan Forster
80212c0ab4
actually validate the chain before adding
2017-04-27 14:44:58 +10:00
Ryohei Ikegami
1d73e84a29
Merge branch 'master' into native-window-open
2017-04-27 12:03:55 +09:00
Kevin Sawicki
7881376aff
Merge pull request #9254 from electron/endsession-event
...
End session event on browser window
2017-04-24 12:02:05 -07:00
Hari Krishna Reddy Juturu
8458acff26
Removing #ifdef on endsession api
2017-04-24 11:58:08 -07:00
Hari Krishna Reddy Juturu
8a32826876
Removing #ifdef windows for endsession methods
2017-04-24 11:49:21 -07:00
Hari Krishna Reddy Juturu
9e70372c1f
change endsession event name to session-end
2017-04-24 10:16:11 -07:00
Kevin Sawicki
13e4582697
Emit autoUpdater error directly as Error object
2017-04-24 09:47:30 -07:00
Brendan Forster
f644ba56a3
clean up the code a bit
2017-04-24 11:49:55 +10:00
Brendan Forster
253a4b0114
Merge remote-tracking branch 'electron/master' into certificate-addition-windows
2017-04-24 11:13:34 +10:00
Brendan Forster
ac3385124a
reload the current cert database if the certificate was added
2017-04-24 11:12:26 +10:00
Hari Krishna Reddy Juturu
9e8252c1f9
Remove wm_state change
2017-04-21 14:35:30 -07:00
Hari Krishna Reddy Juturu
3c3e14b820
End session event on browser window
2017-04-21 14:22:11 -07:00
Brendan Forster
c181a8269d
and this is how we invoke the callback
2017-04-21 12:47:11 +10:00
Brendan Forster
1439a1e322
and the order here matters apparently
2017-04-21 12:23:50 +10:00
Brendan Forster
b3baf9976f
coding style fixes
2017-04-21 12:17:01 +10:00
Kevin Sawicki
a004cada7c
Merge pull request #9095 from seanchas116/better-path-resolve
...
Search for module from app path when URL is not file protocol
2017-04-20 10:49:53 -07:00
Kevin Sawicki
dc8b43901b
Merge pull request #9108 from yuya-oc/add-macos-sheet-events
...
Add sheet-begin and sheet-end events to macOS BrowserWindow
2017-04-20 10:33:31 -07:00
Kevin Sawicki
29a3e11893
Group sheet event methods with other macOS methods
2017-04-20 10:32:14 -07:00
Brendan Forster
5f1bcd2d16
a first pass at the script to import the certificate for Windows
2017-04-20 21:12:32 +10:00
Brendan Forster
dca08c208b
and use the same signature for Windows
2017-04-20 14:21:08 +10:00
Brendan Forster
4f40b8a42c
stub the windows source file
2017-04-20 14:21:08 +10:00
Kevin Sawicki
4a9383b50b
Bump v1.6.7
2017-04-18 09:17:16 -07:00
Hari Krishna Reddy Juturu
fe88697348
fixup! fixup! Adding cookie flush store api
2017-04-18 09:05:13 -07:00
Hari Krishna Reddy Juturu
19709a50e9
Adding cookie flush store api
2017-04-18 09:05:13 -07:00
Kevin Sawicki
c32a723e29
Only read iconPosition when icon is present
2017-04-18 08:58:54 -07:00
Samuel Attard
526d287d25
Make iconPosition non-breaking by defaulting to overlay
2017-04-18 08:56:39 -07:00
Samuel Attard
11c7c107a9
add iconPosition property to touch bar buttons
2017-04-18 08:56:39 -07:00
Ryohei Ikegami
8dff29185b
Merge branch 'master' into native-window-open
2017-04-18 21:59:22 +09:00
Alexandre Lachèze
9aff17afea
👕 alphabetical order
2017-04-18 13:44:31 +02:00
Alexandre Lachèze
f375e8a7db
Add OS process id to web-contents
2017-04-18 12:31:20 +02:00
Birunthan Mohanathas
3bcf5e0e9f
Fix OverrideSiteInstanceForNavigation() signature
2017-04-18 11:51:38 +03:00
Birunthan Mohanathas
dcf6c52f51
Actually hide menubar area when menu is autohidden
...
This was a regression introduced in 638eae10
2017-04-17 12:31:39 +03:00
Yuya Ochiai
75184046f6
Add events to manage sheets of macOS BrowserWindow
2017-04-15 16:26:45 +09:00
Birunthan Mohanathas
e7d71000ee
Fix missing warning icon with dialog.showMessageBox() on macOS
...
Fixes #9183 .
2017-04-14 19:27:25 +03:00
Ryohei Ikegami
ea6890aa5c
Use const
2017-04-13 23:26:42 +09:00
Kevin Sawicki
fe8726d775
Use Chrome default client inset handling
2017-04-13 13:03:46 +03:00
Ryohei Ikegami
9d62b196d3
Use base::FilePath
2017-04-13 10:59:12 +09:00
Birunthan Mohanathas
06fcf2c19d
Add support for BrowserView autoresizing
2017-04-13 01:27:31 +03:00
Birunthan Mohanathas
638eae1080
Remove MenuLayout in favor of NativeWindowViews::Layout
2017-04-13 01:27:31 +03:00
Birunthan Mohanathas
8b9f7e5b00
Implement initial, experimental BrowserView API
...
Right now, `<webview>` is the only way to embed additional content in a
`BrowserWindow`. Unfortunately `<webview>` suffers from a [number of
problems](https://github.com/electron/electron/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20label%3Awebview%20 ).
To make matters worse, many of these are upstream Chromium bugs instead
of Electron-specific bugs.
For us at [Figma](https://www.figma.com ), the main issue is very slow
performance.
Despite the upstream improvements to `<webview>` through the OOPIF work, it is
probable that there will continue to be `<webview>`-specific bugs in the
future.
Therefore, this introduces a `<webview>` alternative to called `BrowserView`,
which...
- is a thin wrapper around `api::WebContents` (so bugs in `BrowserView` will
likely also be bugs in `BrowserWindow` web contents)
- is instantiated in the main process like `BrowserWindow` (and unlike
`<webview>`, which lives in the DOM of a `BrowserWindow` web contents)
- needs to be added to a `BrowserWindow` to display something on the screen
This implements the most basic API. The API is expected to evolve and change in
the near future and has consequently been marked as experimental. Please do not
use this API in production unless you are prepared to deal with breaking
changes.
In the future, we will want to change the API to support multiple
`BrowserView`s per window. We will also want to consider z-ordering
auto-resizing, and possibly even nested views.
2017-04-13 01:27:27 +03:00
Kevin Sawicki
1c44bcf654
Merge pull request #8786 from electron/per-monitor-dpi-aware
...
Enable per-monitor DPI for Win10
2017-04-12 12:27:41 -07:00
Ryohei Ikegami
b19c5154ca
Fix cpplint errors
2017-04-12 12:25:56 +09:00
Ryohei Ikegami
b07c3adca9
Fix comment for ChildWebContentsTracker
2017-04-12 12:20:53 +09:00
Kevin Sawicki
efa28503a7
Merge pull request #9148 from electron/share-render-frame-observer-with-sandbox
...
Refactor: Share AtomRenderFrameObserver with AtomSandboxedRendererClient
2017-04-11 10:02:12 -07:00
Kevin Sawicki
e7b679ead6
Add IsEmpty helper and remove GetInstance public usage
2017-04-11 09:09:17 -07:00
Kevin Sawicki
da5d7d72b0
Add GetWindows helper that returns a vector
2017-04-11 09:09:17 -07:00
Kevin Sawicki
0883a9f966
Use CloseAllWindows helper
2017-04-11 09:09:17 -07:00
Kevin Sawicki
8311aa667c
Add DestroyAllWindows helper that uses vector copy
2017-04-11 09:09:17 -07:00
Kevin Sawicki
29c68182df
Always set NSScrollViewRubberbanding scroll bounce pref
2017-04-11 08:42:41 -07:00
Cheng Zhao
c59ef0efc5
Enable per-monitor DPI
2017-04-11 15:17:15 +09:00
Thiago de Arruda
039aaba758
Move AtomRenderFrameObserver creation to RendererClientBase.
...
Also remove AtomSandboxedRenderFrameObserver class.
2017-04-08 11:54:58 -03:00
Thiago de Arruda
72781e38c8
Change AtomRenderFrameObserver.renderer_client_ type to RendererClientBase.
2017-04-08 11:27:19 -03:00
Thiago de Arruda
ef07e25f9d
Make SetupMainWorldOverrides/isolated_world pure virtual.
...
Also implement stubs in AtomSandboxedRendererClient.
2017-04-08 11:12:18 -03:00
Thiago de Arruda
f751335bf9
Make DidCreateScriptContext/WillReleaseScriptContext pure virtual.
2017-04-08 10:58:13 -03:00
Thiago de Arruda
0227254774
Move DidClearWindowObject into RendererClientBase.
...
Also adapt AtomSandboxedRenderFrameObserver to forward DidClearWindowObject to
RendererClientBase.
2017-04-08 10:43:19 -03:00
Thiago de Arruda
91ee0ea740
Move AtomRenderFrameObserver into a separate module.
...
Also move SetupMainWorldOverrides into the AtomRendererClient class(since the
code there is specific to AtomRendererClient).
2017-04-08 10:29:05 -03:00
Kevin Sawicki
8a324a9375
Bump v1.6.6
2017-04-07 09:01:28 -07:00
Kevin Sawicki
4ec7cc913d
Merge pull request #9117 from electron/fix_debug_checks
...
Fixed a couple of failing debug checks when calling Chromium APIs
2017-04-06 08:48:15 -07:00
Ryohei Ikegami
34ed1a9ef8
Track child web contents
2017-04-06 12:15:27 +09:00
Ryohei Ikegami
526086d900
Improve RootWebContentsTracker
2017-04-06 11:37:21 +09:00
Ales Pergl
73e3fd01eb
Fixed a couple of failing debug checks when calling Chromium APIs
2017-04-05 14:45:46 +02:00
Ryohei Ikegami
b683584859
Add better comments to ShouldCreateNewSiteInstance
2017-04-05 18:16:10 +09:00
Ryohei Ikegami
cbdd52e43b
Always create new SiteInstance on root WebContents
2017-04-05 17:51:17 +09:00
Ryohei Ikegami
90852c665d
Pass RenderFrameHost to ShouldCreateNewSiteInstance
2017-04-05 13:47:02 +09:00
Kevin Sawicki
aa75e4562e
Restore delivering IPC messages to utility handlers
2017-04-04 20:40:57 -07:00
Kevin Sawicki
6a22c6645e
Guard against missing popover identifier
2017-04-04 13:51:39 -07:00
Kevin Sawicki
9c73c991d7
Use const references for params
2017-04-04 13:51:39 -07:00
Samuel Attard
bea56bbdc8
Update as per feedback
2017-04-04 13:51:38 -07:00
Samuel Attard
2fd62d090a
Allow items to be assigned to multiple popovers
2017-04-04 13:51:33 -07:00
Samuel Attard
f05dfc74da
Store parent popover in popover touch bar items
2017-04-04 13:51:13 -07:00
Kevin Sawicki
7f8e490839
Take const reference
2017-04-04 12:50:41 -07:00
Kevin Sawicki
d596d85288
🎨
2017-04-04 12:50:41 -07:00
Kevin Sawicki
df0f468dea
Add escapeKeyReplacementItemIdentifier forward declaration
2017-04-04 12:50:41 -07:00
Samuel Attard
60cc862031
Make everything pointer like
2017-04-04 12:50:41 -07:00
Samuel Attard
4d6b0fc01b
Add a method to set the escape identifier on the touch bar
2017-04-04 12:50:41 -07:00
Kevin Sawicki
3e9014c371
Merge pull request #9099 from electron/certificate-trust
...
macOS: Add certificate trust API
2017-04-04 11:17:09 -07:00
joshaber
736d6afe73
As you wish linter
2017-04-04 09:23:30 -04:00
joshaber
146e1ed3ce
Don't pass the result through
...
It's meaningless on macOS, at least.
2017-04-04 09:21:15 -04:00
joshaber
0cab8a3322
Put CertFromData in an anon namespace
2017-04-04 09:19:23 -04:00
Ryohei Ikegami
61fa8693d2
Merge branch 'master' into native-window-open
2017-04-04 20:54:37 +09:00
Ryohei Ikegami
e7b9b4b1a5
Always create new site instance
2017-04-04 20:54:10 +09:00
Ryohei Ikegami
3eab5df4a4
Revert "Reuse site instance only on window.open"
...
This reverts commit 4d61d071b2
2017-04-04 13:48:17 +09:00
Cheng Zhao
7265a0c1b4
Merge pull request #8528 from Anatzum/patch-1
...
Use kioclient for MoveItemToTrash on KDE
2017-04-04 12:15:21 +09:00
joshaber
8d465234e4
Appease our linty overlords
2017-04-03 21:40:46 -04:00
joshaber
2badfbe04f
Remove the intermediate function
2017-04-03 21:22:37 -04:00
joshaber
b3e865a478
Fix some style things
2017-04-03 21:22:14 -04:00
Ryohei Ikegami
24fedb2e20
No extra linebreak
2017-04-04 09:40:38 +09:00
Ryohei Ikegami
4a7eec8f2d
Pass app path as command line argument
2017-04-04 09:36:01 +09:00
joshaber
370cf815d9
Get rid of intermediates and rehydrate from issuerCert
2017-04-03 16:27:53 -04:00
joshaber
74c0cbddae
Linebreak to keep the linter happy
2017-04-03 16:07:02 -04:00
joshaber
b8ff4666c8
Remove stale includes
2017-04-03 15:48:47 -04:00
joshaber
b0ef7ddf44
Use better iteration
2017-04-03 15:28:51 -04:00
joshaber
06643e525a
Const ref that message
2017-04-03 15:28:44 -04:00
joshaber
11f5c942ce
Conditionalize
2017-04-03 15:25:09 -04:00
joshaber
bcecba20e6
Fix indentation
2017-04-03 15:09:24 -04:00
joshaber
4ffaf2cd99
Remove old unnecssary change on app
2017-04-03 15:09:04 -04:00
joshaber
6e89cb9d7c
Move it into dialog
2017-04-03 15:05:24 -04:00
joshaber
4bbbcd093b
Handle the callback and cleanup properly
2017-04-03 14:01:48 -04:00
joshaber
1ed443ea29
Do the callback & release dance
2017-04-03 13:21:44 -04:00
Kevin Sawicki
f5a75c4e87
Merge pull request #9076 from electron/cleanup-cpp
...
Cleanup cpp codebase
2017-04-03 08:30:08 -07:00
Haojian Wu
34a91434aa
Remove extra spaces.
2017-04-01 22:01:29 +02:00
Haojian Wu
f09e3f3835
Remove extra blank.
2017-04-01 15:09:53 +02:00
joshaber
ee7389bb6d
Rename to make VS happy
2017-03-31 22:57:56 -04:00
joshaber
4f3d3557cc
Notify that the cert changed
2017-03-31 21:51:29 -04:00
joshaber
bde2a597f3
Decode all the intermediates
2017-03-31 21:27:49 -04:00
joshaber
69defc5166
Encode all the intermediates
2017-03-31 21:27:33 -04:00
joshaber
302ca8669d
Slightly better conversion
2017-03-31 15:44:47 -04:00
Kevin Sawicki
a724b6555f
Bump v1.6.5
2017-03-31 12:10:09 -07:00
Kevin Sawicki
08db63c3cc
Only define NSWindowTabbingModeDisallowed on pre-10.12
2017-03-31 11:28:55 -07:00
joshaber
141a5ad73f
Maybe this is a valid conversion?
2017-03-31 14:16:26 -04:00
Haojian Wu
8ae91682cb
Lines should be <= 80 characters.
2017-03-31 20:09:13 +02:00
joshaber
16cc79354c
Errrrybody's a scoped_refptr now
2017-03-31 13:53:42 -04:00
joshaber
deae70de4d
Dummy out the certificate FromV8 converter
2017-03-31 13:53:31 -04:00
Kevin Sawicki
d677a436ec
🎨
2017-03-31 10:42:43 -07:00
Thiago de Arruda
f0d447cd68
Pass uploadToServer to windows crash reporter
2017-03-31 13:46:30 -03:00
joshaber
653b2d15c3
Expose the certificate trust panel as part of app
2017-03-30 17:25:55 -04:00
joshaber
64369cd07f
Show a certificate trust panel
2017-03-30 17:25:44 -04:00
Haojian Wu
328cf4789b
Should override the virtual destructor.
2017-03-30 23:19:43 +02:00
Haojian Wu
e8abee9ca9
Replace C-style casts with static_cast.
2017-03-30 23:05:47 +02:00
Haojian Wu
ff745e1a82
Use prefix increment in for loops.
2017-03-30 22:56:21 +02:00
Haojian Wu
8d8c7ce6ad
Correct type cast.
2017-03-30 22:53:20 +02:00
Kevin Sawicki
42300ae58e
Make tabbing identifier var local
2017-03-30 13:47:11 -07:00
Kevin Sawicki
c8b992fa39
Remove 10.12 check handled by respondsToSelector
2017-03-30 13:46:34 -07:00
Haojian Wu
bb51401c4c
Use base::mac::NSToCast.
2017-03-30 22:33:09 +02:00
Haojian Wu
1b9780035c
Remove redundant calls to smart pointer's get method.
2017-03-30 22:22:40 +02:00
Haojian Wu
d425b63b0d
NULL => nullptr
2017-03-30 22:12:14 +02:00
Haojian Wu
00693ba075
Replace "size()" with "empty()".
2017-03-30 21:59:18 +02:00
Haojian Wu
6ef3be23fd
Avoid copy in for range loop.
2017-03-30 21:56:28 +02:00
Tony Ganch
bd935b213f
Fix compilation against macOS 10.10 SDK
2017-03-30 15:13:49 +02:00
Haojian Wu
5f724e57bc
Avoid unnecessary copy of parameters.
2017-03-29 22:06:07 +02:00
Haojian Wu
99293dd57f
Fix namespace comments.
2017-03-29 20:47:41 +02:00
Tony Ganch
a7565f0d57
Enable native tabs on macOS
2017-03-29 13:51:39 +02:00
Tony Ganch
9e02c60e22
Revert "Disable Show Tab Bar menu item on macOS Sierrra"
...
This reverts commit 24b9313958
2017-03-29 13:50:56 +02:00
Tony Ganch
ed76e03730
Revert "Add forward declaration of NSWindow.allowsAutomaticWindowTabbing"
...
This reverts commit 770a3509cf
2017-03-29 13:50:56 +02:00
Cheng Zhao
6db827cc9a
Use GetDesktopEnvironment to determien desktop env
...
Which can get a much more precise result for us.
2017-03-29 16:21:38 +09:00
Anatzum
f9dbdf4522
Updated MoveItemToTrash in platform_util_linux.cc
...
If ELECTRON_TRASH is null, first check the DESKTOP_SESSION variable and set trash accordingly. Additional desktop environments can be added easily this way with the fallback of ELECTRON_DEFAULT_TRASH.
2017-03-29 16:08:26 +09:00
Cheng Zhao
208182d8cf
Merge pull request #9039 from electron/extract-renderer-base-class
...
Create base class to share code between sandbox and non-sandbox
2017-03-29 15:20:46 +09:00
Cheng Zhao
9ef1f8cd5d
Merge pull request #9043 from electron/fix-uv-run-crash
...
Fix crash happened in UvRunOnce
2017-03-29 13:37:07 +09:00
Kevin Sawicki
4441d557a2
Merge pull request #9007 from electron/net_redirect_patch
...
net: allow controlling redirects
2017-03-28 09:31:05 -07:00
Kevin Sawicki
03b2167f6c
Merge pull request #9001 from electron/net_source_stream_error_patch
...
net: catch source stream creation failure for content encoding
2017-03-28 09:24:18 -07:00
deepak1556
3ae62615f4
net: allow controlling redirects
2017-03-28 18:46:21 +05:30
Ryohei Ikegami
37c4569982
Use GetBoolean directly
2017-03-28 20:00:33 +09:00
Cheng Zhao
2ef1b70897
Fix crash happened in UvRunOnce
2017-03-28 17:19:14 +09:00
Cheng Zhao
637bdc239b
Merge pull request #8923 from electron/geolocation_request_context_patch
...
browser: Create separate request context for geolocation service.
2017-03-27 22:45:46 -07:00
Thiago de Arruda
d1f08beddf
Make AtomSandboxedRendererClient a RendererClientBase subclass.
2017-03-27 18:49:55 -03:00
Thiago de Arruda
c3a8f665f2
Extract base class from AtomRendererClient
...
The new `RendererClientBase` class contains code that is not specific to node.js
integration with the renderer.
2017-03-27 18:49:55 -03:00
Kevin Sawicki
6a2cdcf32f
Merge pull request #8956 from electron/expose-crash-reporter-to-sandbox
...
Expose crash reporter to sandbox
2017-03-27 10:09:36 -07:00
Kevin Sawicki
b1275a8ef0
Merge pull request #8984 from hansenzhang/display-menuitem-label
...
Fix '&' not showing in MenuItem label
2017-03-27 09:47:50 -07:00
deepak1556
93b444eef9
net: catch source stream creation failure for content encoding
2017-03-23 23:36:05 +05:30
Ryohei Ikegami
6f9dbd4e04
Merge branch 'master' into native-window-open
2017-03-24 00:11:43 +09:00
Thiago de Arruda
bf756e3c00
Prevent browserify from leaking the require function
...
Define a "require" argument in the wrapper functions that runs browserify
bundles, which will prevent browserify from leaking the require function.
Note that this doesn't affect the isolated renderer script, only when `-r` flag
is passed to browserify command it will export a require function. It is still
added to isolated renderer script to prevent future mistakes(doesn't hurt
defining a "require" local).
2017-03-23 10:01:02 -03:00
Thiago de Arruda
e1aebef57c
Make sandbox APIs more compatible with normal renderers
...
- Expose remote shortcuts for the `fs`, `os` and `child_process` modules.
- Expose the `url` and `timers` modules(the browserify versions)
- Add `process.crash` and `process.platform`
2017-03-23 10:01:02 -03:00
Kevin Sawicki
46aed5ff6f
Bump v1.6.4
2017-03-22 09:16:08 -07:00
Cheng Zhao
e539129db2
Merge pull request #8852 from electron/web-worker-hook
...
Add Node.js integration to WebWorker
2017-03-22 09:01:42 -07:00
Hansen Zhang
426563a843
#8881 - Display '&' in MenuItem label
2017-03-22 11:52:25 -04:00
deepak1556
4ab2c92418
CommonWebContentsDelegate::DestroyWebContents => ResetManagedWebContents
2017-03-22 07:30:36 +05:30
Ryohei Ikegami
4d61d071b2
Reuse site instance only on window.open
2017-03-21 10:41:49 +09:00
Cheng Zhao
99d3fce3c7
node::Environment should be destroyed before AtomBindings
...
The shutdown code may still uses the APIs provieded by AtomBindings.
2017-03-20 13:01:28 -07:00
Cheng Zhao
0287f23e3b
Fix cpplint warning
2017-03-20 12:52:46 -07:00
Cheng Zhao
940d77b9a0
Fix typos and adjust sentences
2017-03-20 12:52:46 -07:00
Cheng Zhao
033aa16e04
test: Node integration in web workers
2017-03-20 12:52:46 -07:00
Cheng Zhao
a49af26e39
Add nodeIntegrationInWorker option
2017-03-20 12:52:46 -07:00
Cheng Zhao
e496e18f6e
Make Archive thread safe
2017-03-20 12:52:46 -07:00
Cheng Zhao
c068285ff8
AtomBindings should not use default uv loop
2017-03-20 12:52:46 -07:00
Cheng Zhao
9c9c8ec5f1
WebWorkerObserver should be destroyed on exit
2017-03-20 12:52:46 -07:00
Cheng Zhao
d2f185bea5
Create new uv loop in each worker
2017-03-20 12:52:46 -07:00
Cheng Zhao
69df934710
Converter for base::Callback is not thread safe
2017-03-20 12:52:45 -07:00
Cheng Zhao
b467c3939e
Add a new type of NodeBindings
2017-03-20 12:52:45 -07:00
Cheng Zhao
2cbdb6bac3
Wrap ContextCreated with context scope
2017-03-20 12:52:45 -07:00
Cheng Zhao
e017e157ba
Insert node integrations into WebWorker
2017-03-20 12:52:45 -07:00
Ryohei Ikegami
f3ce93f1bb
Fix C++ style
2017-03-19 18:24:05 +09:00
Ryohei Ikegami
2c7343293a
Allow window.open on native-window-open enabled
2017-03-19 17:47:26 +09:00
Ryohei Ikegami
a1f9a45276
Use native window.open implementation
2017-03-19 17:41:20 +09:00
Ryohei Ikegami
054ba7a964
Add AtomBrowserClient::IsRendererUsesNativeWindowOpen
2017-03-19 17:25:45 +09:00
Ryohei Ikegami
f7935b429a
Add WebContentsPreferences::IsNativeWindowOpenEnabled
2017-03-19 17:12:25 +09:00
deepak1556
72adbf7a2f
destroy guest webcontents before embedder
2017-03-19 10:25:13 +05:30
deepak1556
16f9754445
Create separate request context for geolocation service.
...
* Geolocation service cannot hold reference to browser context,
since it is destroyed at the end of everything and this will
confuse the shutdown path of browser context.
* Geolocation service run on its own thread.
2017-03-19 01:11:55 +05:30
Kevin Sawicki
f119bc0944
Remove unused args param
2017-03-17 10:35:54 -07:00
Kevin Sawicki
ab05346572
Add clipboard.readBuffer
2017-03-17 09:57:17 -07:00
Kevin Sawicki
6d45052eea
Merge pull request #8900 from electron/handle-buffer-instances-in-sandbox
...
Handle Buffer deserialization in sandboxed renderers
2017-03-16 10:12:09 -07:00
Thiago de Arruda
a6e4867111
Handle Buffer deserialization in sandboxed renderers
...
In sandboxed renderers we use browserify to provide a node-like environment. The
Buffer class used by browserify is actually just a wrapper around Uint8Array,
but to deserialize Buffer correctly we must expose the class as a hidden value
and use it in V8ValueConverter.
2017-03-16 13:20:09 -03:00
Kevin Sawicki
da0d0e7aac
Merge pull request #8910 from electron/touchbar-scrubber
...
Touchbar NSScrubber
2017-03-16 09:10:59 -07:00
Kevin Sawicki
e98ac94d51
🎨
2017-03-15 11:22:31 -07:00
Kevin Sawicki
f41db87e47
Use NSZeroRect for scrubber frame
2017-03-15 09:45:50 -07:00
Kevin Sawicki
466c39ed19
Use icon for consistency with other touch bar APIs
2017-03-15 09:33:11 -07:00
Kevin Sawicki
6175ee05e2
Remove unneeded long cast
2017-03-14 13:59:29 -07:00
Kevin Sawicki
8b7675baee
Add more forward declarations for scrubber APIs
2017-03-14 13:57:39 -07:00
Samuel Attard
a55cddaa53
Add more options
2017-03-14 18:57:57 +11:00
deepak1556
15e2b2335f
address review comments
2017-03-14 00:26:27 +05:30
deepak1556
d022d108a3
Dont intercept pdf request for subframes
...
Will not work without OOPIF support
2017-03-14 00:26:27 +05:30
deepak1556
4381e0895f
propagate zoom changes to pdf plugin
2017-03-14 00:26:27 +05:30
deepak1556
eda413861a
update spec
2017-03-14 00:26:27 +05:30
deepak1556
b28e686228
code cleanup
2017-03-14 00:26:27 +05:30
deepak1556
5a8e522526
StreamManager class is no longer required.
...
Stream lifetime is managed by webui
2017-03-14 00:26:27 +05:30
deepak1556
c982af991d
request for pdf resource from the webui
2017-03-14 00:26:27 +05:30
Cheng Zhao
422b7acece
Do not store resource_path as FilePath
...
On Windows the path value returned by PathWithoutParams also uses "/" as
separator, so there is no need to use the FilePath class.
2017-03-14 00:26:27 +05:30
Cheng Zhao
cca1db47ee
Print error when path is not found
2017-03-14 00:26:27 +05:30
deepak1556
528853efbf
handle reload api call from pdf ui
2017-03-14 00:26:27 +05:30
deepak1556
010193ef44
remove unused header
2017-03-14 00:26:27 +05:30
deepak1556
6987e3ecd0
check if target stream is intercepted for correct request
2017-03-14 00:26:27 +05:30
deepak1556
b9710532e1
update api changes
2017-03-14 00:26:27 +05:30
deepak1556
a4400dc549
add basic spec
2017-03-14 00:26:27 +05:30
deepak1556
3aba23b471
view_id=>stream_id and add some code comments.
2017-03-14 00:26:27 +05:30
deepak1556
e90fd1444f
move constants to atom_constants.h
2017-03-14 00:26:27 +05:30
deepak1556
671a8a2cd6
address review comments
2017-03-14 00:26:27 +05:30
deepak1556
6cb626db88
use existing ipc message generator
2017-03-14 00:26:27 +05:30
deepak1556
cc09b9ac7d
BINDINGS_POLICY_WEB_UI is not required
2017-03-14 00:26:27 +05:30
Paul Betts
846d516584
Get us compiling on macOS
2017-03-14 00:26:27 +05:30
Paul Betts
8580a34f9f
Get us compiling on Win32
2017-03-14 00:26:27 +05:30
deepak1556
e767c59da2
enable pdf plugin by default
2017-03-14 00:26:27 +05:30
deepak1556
c15f6af892
fix crash when pdf viewer is reloaded
2017-03-14 00:25:59 +05:30
deepak1556
ddc2e0df71
code cleanup
2017-03-14 00:25:59 +05:30
deepak1556
de7dcdedba
setup strings for ui
2017-03-14 00:25:59 +05:30
deepak1556
0c7bb72891
listen to ipc messages from plugin to perform SaveAs op
2017-03-14 00:25:59 +05:30
deepak1556
fd8c450ef3
move pdfviewer ui data source to separate file
2017-03-14 00:25:59 +05:30
deepak1556
945e26750e
manage the lifetime of streams created
2017-03-14 00:25:59 +05:30
deepak1556
0ab37da785
replace redundant mimetype helper with net utility
2017-03-14 00:25:59 +05:30
deepak1556
578b717b5f
fix cpplint error
2017-03-14 00:25:59 +05:30
deepak1556
c4dd2f4f56
add pdf webui as submodule
2017-03-14 00:25:59 +05:30
deepak1556
3c90fabab7
update pdf ui to work with webui
2017-03-14 00:25:59 +05:30
deepak1556
41c1623824
handle more messages from webui
2017-03-14 00:25:59 +05:30
deepak1556
a2db14476a
create webui message handler
2017-03-14 00:25:59 +05:30
deepak1556
8a2b9c893e
initialize webui with message handlers
2017-03-14 00:25:59 +05:30
deepak1556
be480fb634
import pdf ui
2017-03-14 00:25:59 +05:30
deepak1556
fdd574cea5
browser: implement pdf renderer as webui
2017-03-14 00:25:59 +05:30
Kevin Sawicki
268dd1a6c2
Remove unneeded include
2017-03-13 11:15:36 -07:00
Kevin Sawicki
e52ece1a1e
Implement NSScrubberDataSource in AtomTouchBar
2017-03-13 11:06:41 -07:00
Kevin Sawicki
4f31a5c452
Fix duplicate protocol method declaration
2017-03-13 10:39:42 -07:00
Kevin Sawicki
d7f458d232
Add protocol methods
2017-03-13 10:31:51 -07:00
Kevin Sawicki
2fe21ecdd0
🎨
2017-03-13 10:28:30 -07:00
Kevin Sawicki
37c9d76cd5
Take const references
2017-03-13 10:25:30 -07:00
Kevin Sawicki
634bd7b17f
Add NSScrubber forward declarations
2017-03-13 10:07:48 -07:00
Samuel Attard
a85ae27d68
Fix linting
2017-03-13 11:00:10 +11:00
Samuel Attard
25a231fc50
Initial NSScrubber implementation
2017-03-13 10:51:12 +11:00
deepak1556
4281c73cf2
renderer: reset plugin cache when render frame is created
2017-03-12 00:53:39 +05:30
Kevin Sawicki
280337bf46
Merge pull request #8887 from electron/touchbar-segmneted-control
...
Touchbar segmented control
2017-03-10 14:43:12 -08:00
Kevin Sawicki
5b1d5b39a2
Set automatic via else block
2017-03-10 10:11:56 -08:00
Kevin Sawicki
3349e32196
Verify selectedIndex to prevent NSRangeException
2017-03-10 10:09:18 -08:00
Kevin Sawicki
458e4be77c
Add forward declaration for 10.12 API
2017-03-10 09:53:47 -08:00
Samuel Attard
1c027c526b
Add segmented control implementation
2017-03-10 17:40:39 +11:00
Thiago de Arruda
cd05834d96
Refactor sandboxed renderer init scripts
...
This change gives sandboxed renderer scripts a similar structure to what already
exists in the lib/{browser,renderer,common} directories.
It also allows sandboxed renderer initialization to share more code with
non-sandboxed renderers (ipcRenderer is now imported directly from
lib/renderer/api/ipc-renderer).
2017-03-09 20:39:14 -03:00
Thiago de Arruda
d78f3cae7b
Expose builtin v8 modules to AtomSandboxedRendererClient
...
- Adapt node.cc code that implements `process.binding` to create a similar
object in AtomSandboxedRendererClient.
- Replace the ipc binding object passed to `lib/sandboxed_renderer/init.js` by
the new binding object.
- Refactor the initialization script to use this new object to fetch the ipc
binding and store as a hidden value using the `v8_util` module.
This change also required applying a patch to node.js, so the submodule commit
was updated.
2017-03-09 20:39:14 -03:00
Kevin Sawicki
e79a22da5d
Merge pull request #8883 from electron/pass-crash-reporter-upload-parameter
...
Pass `uploadToServer` parameter to linux crash reporter
2017-03-09 12:59:35 -08:00
Thiago de Arruda
e03e37e984
Pass uploadToServer parameter to linux crash reporter
2017-03-09 17:23:52 -03:00
Kevin Sawicki
14e8e463b3
Merge pull request #8864 from electron/zoom_controller_webview_patch
...
browser: track origin zoom with HostZoomMap
2017-03-09 11:27:34 -08:00
Kevin Sawicki
7e039d92ec
Support adding representation from data URL
2017-03-09 09:56:42 -08:00
Kevin Sawicki
d67863aa9f
Add addRepresentation buffer support
2017-03-09 09:56:42 -08:00
John Kleinschmidt
d5a658bbe4
Fixed pass by reference and added spec
2017-03-08 22:06:26 -05:00
John Kleinschmidt
1c2a78a896
Add WebRTCIPPolicy setting to webContents and webview
...
Resolves #8777
Code to set and get the policy come from the muon framework code:
https://github.com/brave/muon/blob/master/atom/browser/api/atom_api_web_
contents.cc#L1324...L1343
2017-03-08 10:15:48 -05:00
deepak1556
b5cfa2e92d
track host zoom levels with HostZoomMap
2017-03-08 19:03:43 +05:30
Kevin Sawicki
8852b128ec
Add GetScaleFactorFromOptions helper
2017-03-07 12:27:55 -08:00
Kevin Sawicki
82a81bb26e
Support scale factor to buffer APIs
2017-03-07 12:27:55 -08:00
Kevin Sawicki
e4ead6d018
Remove hasRepresentation and just use 1x png result
2017-03-07 12:27:55 -08:00
Kevin Sawicki
c11cdf321b
Support toPNG on image without 1x representation
2017-03-07 12:27:55 -08:00
Kevin Sawicki
86babdd412
Remove unused include
2017-03-07 12:27:55 -08:00
Kevin Sawicki
0bbbeb307e
Support toDataURL without 1x representation
2017-03-07 12:27:55 -08:00
Kevin Sawicki
e0260d6f53
Bump v1.6.3
2017-03-07 09:49:39 -08:00
Kevin Sawicki
f549bda9fc
Merge pull request #8799 from nitsakh/baseURLForDataURL
...
Support base URL option to loadURL for data URLs
2017-03-06 10:25:53 -08:00
Kevin Sawicki
886b47e713
Merge pull request #8724 from electron/defer_load_url
...
webContents: defer url load when there is a pending navigation entry
2017-03-06 10:18:36 -08:00
Kevin Sawicki
479af3c9e2
Merge pull request #8678 from liusy182/download-item
...
only emit `download-item done` event once
2017-03-06 10:11:22 -08:00
Cheng Zhao
aaa8e81cd4
Merge pull request #8811 from electron/clean-node-on-exit
...
Clean up node Environment on exit
2017-03-06 20:36:59 +09:00
deepak1556
e936143da2
listen for browser initiated pending nav entries too
2017-03-06 00:21:52 +05:30
deepak1556
dead1ae1ba
webContents: defer url load when there is a pending navigation entry
2017-03-06 00:10:46 +05:30
Kevin Sawicki
4d6c779839
identList -> identifiers
2017-03-03 15:28:32 -08:00
Kevin Sawicki
b879872317
Always set properties in update calls
2017-03-03 15:24:32 -08:00
Kevin Sawicki
2680ee9f8f
Add support for setting TouchBarLabel text color
2017-03-03 15:14:51 -08:00
Kevin Sawicki
9f323104e7
Remove unused include
2017-03-03 14:11:09 -08:00
Kevin Sawicki
edebb32014
Drop nullable for consistency
2017-03-03 14:07:59 -08:00
Kevin Sawicki
ca2898a60e
Check that window responds to touchBar selector for pre-10.12.1 compat
2017-03-03 14:00:39 -08:00
Kevin Sawicki
002369576f
Add initial touch bar docs
2017-03-03 14:00:39 -08:00
Kevin Sawicki
ce12dcd3b4
Add live popover icon property
2017-03-03 14:00:39 -08:00
Kevin Sawicki
a34f9d3583
Support icon property to match MenuItem
2017-03-03 14:00:39 -08:00
Kevin Sawicki
506b42b563
🎨
2017-03-03 14:00:39 -08:00
Kevin Sawicki
ecc0478e3c
Match Popover casing in macOS APIs
2017-03-03 14:00:39 -08:00
Kevin Sawicki
d1edd80ef8
Use NSTouchBar itemForIdentifier to lookup existing item
2017-03-03 14:00:39 -08:00
Kevin Sawicki
93bbe8e70b
Use device NS colors consistently
2017-03-03 14:00:39 -08:00
Kevin Sawicki
70d61869a5
Use array to create empty NSMutableArray
2017-03-03 14:00:39 -08:00
Kevin Sawicki
5fe3ac60fa
Check that atom_touch_bar_ is set
2017-03-03 14:00:39 -08:00
Kevin Sawicki
708ed9d1cd
Store ordered settings in AtomTouchBar
2017-03-03 14:00:39 -08:00
Kevin Sawicki
5f9e9d4b36
Add move live updating properties
2017-03-03 14:00:39 -08:00
Kevin Sawicki
61aa9bbff4
Add support for spacer items
2017-03-03 14:00:39 -08:00
Kevin Sawicki
f153d08297
Support setting the initial/available colors
2017-03-03 14:00:39 -08:00
Kevin Sawicki
51f1c5a557
Use SetTouchBar withe empty vector instead of DestroyTouchBar
2017-03-03 14:00:39 -08:00
Kevin Sawicki
347d472841
Remove unused clear method
2017-03-03 14:00:39 -08:00
Kevin Sawicki
b959f782f6
Rename instance variable maps
2017-03-03 14:00:39 -08:00
Kevin Sawicki
ec500b2852
Use scoped_nsobject to match Chrome implementation
2017-03-03 14:00:38 -08:00
Kevin Sawicki
812beb240b
Remove unneeded includes
2017-03-03 14:00:38 -08:00
Kevin Sawicki
823b3baed0
Use vector of dictionaries instead of mate::Arguments
2017-03-03 14:00:38 -08:00
Kevin Sawicki
98f5858b11
Initial support for dynamic properties
2017-03-03 14:00:38 -08:00
Kevin Sawicki
cbb6f8c33e
Store event listeners in each TouchBar class
2017-03-03 14:00:38 -08:00
Kevin Sawicki
1972e2eff9
Update renamed variable
2017-03-03 14:00:38 -08:00
Kevin Sawicki
28f2a4951b
touch_bar_helper_ -> atom_touch_bar_
2017-03-03 14:00:38 -08:00
Kevin Sawicki
b39b49a15a
Rename to touch_bar_helper_ to differentiate from touchBar property
2017-03-03 14:00:38 -08:00
Kevin Sawicki
14ef5c5957
Reset helper when makeTouchBar is called
2017-03-03 14:00:38 -08:00
Kevin Sawicki
ca29ec0101
Use reference
2017-03-03 14:00:38 -08:00
Kevin Sawicki
f297ba987e
touchBarFromMutatableArray -> touchBarFromItemIdentifiers
2017-03-03 14:00:38 -08:00
Kevin Sawicki
b30f7c3c94
Use std::string ctor
2017-03-03 14:00:38 -08:00
Kevin Sawicki
8500538793
Use base::SysUTF8ToNSString helper
2017-03-03 14:00:38 -08:00
