mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Use last selected directory when using default file name in dialog.showSaveDialog()

Browse source 
Prior to this change, attempting to use
`dialog.showSaveDialog({ defaultPath: 'foo.png' })` would open the save
dialog to the current directory with the default file name set to
`foo.png`. We now use the last selected directory instead of the current
directory.

Absolute paths are not affected by this change.
This commit is contained in:
Birunthan Mohanathas 2017-05-26 02:11:58 +03:00
parent fea165bef8
commit 19555bbab2
4 changed files with 16 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
atom/browser/ui/file_dialog_gtk.cc
View file

@ -72,8 +72,12 @@ class FileChooserDialog {
gtk_file_chooser_set_current_folder(GTK_FILE_CHOOSER(dialog_),
settings.default_path.value().c_str());
} else {
gtk_file_chooser_set_current_folder(GTK_FILE_CHOOSER(dialog_),
settings.default_path.DirName().value().c_str());
if (settings.default_path.IsAbsolute()) {
gtk_file_chooser_set_current_folder(
GTK_FILE_CHOOSER(dialog_),
settings.default_path.DirName().value().c_str());
}
gtk_file_chooser_set_current_name(GTK_FILE_CHOOSER(dialog_),
settings.default_path.BaseName().value().c_str());
}

7
atom/browser/ui/file_dialog_mac.mm
View file

@ -65,8 +65,11 @@ void SetupDialog(NSSavePanel* dialog,
if (base::DirectoryExists(settings.default_path)) {
default_dir = base::SysUTF8ToNSString(settings.default_path.value());
} else {
default_dir =
base::SysUTF8ToNSString(settings.default_path.DirName().value());
if (settings.default_path.IsAbsolute()) {
default_dir =
base::SysUTF8ToNSString(settings.default_path.DirName().value());
}
default_filename =
base::SysUTF8ToNSString(settings.default_path.BaseName().value());
}

4
atom/browser/ui/file_dialog_win.cc
View file

@ -105,7 +105,9 @@ class FileDialog {
}
}
SetDefaultFolder(settings.default_path);
if (settings.default_path.IsAbsolute()) {
SetDefaultFolder(settings.default_path);
}
}
bool Show(atom::NativeWindow* parent_window) {

3
docs/api/dialog.md
View file

@ -87,7 +87,8 @@ shown.
* `browserWindow` BrowserWindow (optional)
* `options` Object
* `title` String (optional)
* `defaultPath` String (optional)
* `defaultPath` String (optional) - Absolute directory path, absolute file
path, or file name to use by default.
* `buttonLabel` String (optional) - Custom label for the confirmation button, when
left empty the default label will be used.
* `filters` [FileFilter[]](structures/file-filter.md) (optional)