Only read iconPosition when icon is present

This commit is contained in:
Kevin Sawicki 2017-04-18 08:58:54 -07:00
parent 526d287d25
commit c32a723e29

View file

@ -307,17 +307,18 @@ static NSString* const ImageScrubberItemIdentifier = @"scrubber.image.item";
settings.Get("label", &label);
button.title = base::SysUTF8ToNSString(label);
std::string iconPosition = "overlay";
settings.Get("iconPosition", &iconPosition);
gfx::Image image;
if (settings.Get("icon", &image)) {
button.image = image.AsNSImage();
std::string iconPosition;
settings.Get("iconPosition", &iconPosition);
if (iconPosition == "left") {
button.imagePosition = NSImageLeft;
button.imagePosition = NSImageLeft;
} else if (iconPosition == "right") {
button.imagePosition = NSImageRight;
button.imagePosition = NSImageRight;
} else {
button.imagePosition = NSImageOverlaps;
button.imagePosition = NSImageOverlaps;
}
}
}