Commit graph

9835 commits

Author SHA1 Message Date
Abe Jellinek
49a9c2dba9 fx-compat: Fix Export dialog
RDF isn't working yet, but CSV works well.
2022-05-16 14:27:23 -07:00
Abe Jellinek
60606a8528 fx-compat: Fix Add to Collection menu
Document.createXULElement is handy.
2022-05-16 13:18:16 -07:00
Martynas Bagdonas
9e93007355 fx-compat: Initial fixes for PDF reader, tabs and contextPane 2022-05-13 18:50:19 +03:00
Dan Stillman
4eb405d405 Update utilities submodule 2022-05-13 04:28:57 -04:00
Dan Stillman
da9154d811 fx-compat: Get basicViewer working for debug output
Doesn't work with, e.g., zotero://timeline/library
2022-05-13 04:28:57 -04:00
Dan Stillman
d6875e1182 fx-compat: Switch to Mozilla's method of loading window scripts 2022-05-13 04:28:57 -04:00
Dan Stillman
9b3d7a32e3 Include error message in startup error dialog 2022-05-13 04:28:57 -04:00
Dan Stillman
7c458b9bd3 fx-compat: Fix positioning of some context menus 2022-05-13 04:28:57 -04:00
Dan Stillman
bc68b6e9fe fx-compat: Start to fix tag color chooser dialog
Among other things, need to recreate XBL <customcolorpicker> as a Custom
Element and need to change `ondialogaccept`/etc. to event listeners:

https://searchfox.org/mozilla-central/rev/b72e9d7d63bf499d1d8168291b93d4ec7fde236e/browser/components/places/content/bookmarkProperties.js#232-237
2022-05-13 04:28:57 -04:00
Dan Stillman
63634eed02 fx-compat: Fix clicking URL label
Now that it's a div rather than a label, have to use `textContent`
instead `nodeValue`
2022-05-13 04:28:57 -04:00
Dan Stillman
516c76a4ab fx-compat: Start to update feed settings dialog 2022-05-13 04:28:57 -04:00
Dan Stillman
909d68eac3 fx-compat: Fix New Item menu 2022-05-13 04:28:57 -04:00
Dan Stillman
2e26703b50 fx-compat: goQuitApplication() now takes an event argument 2022-05-13 04:28:57 -04:00
Dan Stillman
172c2da2cc fx-compat: Add dropmarkers to toolbarbuttons 2022-05-13 04:28:57 -04:00
Dan Stillman
758c3187fc fx-compat: Update Edit menu (WIP) 2022-05-13 04:28:57 -04:00
Dan Stillman
280a1265c8 fx-compat: Remove Mac toolbarbutton images
Need to replace with proper styling, but the former approach doesn't
work with the new toolbarbutton component.
2022-05-13 04:28:57 -04:00
Dan Stillman
10a801fcc7 WIP: Localization 2022-05-13 04:28:57 -04:00
Dan Stillman
a16e0620d2 WIP: Localization 3 2022-05-13 04:28:57 -04:00
Dan Stillman
65658b16e6 WIP: Localization 2 2022-05-13 04:28:57 -04:00
Dan Stillman
77015336a4 WIP: Localization 2022-05-13 04:28:56 -04:00
Dan Stillman
c82af749ac Don't force Lucida Grande in various components on macOS 2022-05-13 04:28:56 -04:00
Dan Stillman
4f5b7bbccb Remove old commented-out lines in include.js 2022-05-13 04:28:56 -04:00
Dan Stillman
002132bc4b fx-compat: Populate Window menu on macOS 2022-05-13 04:28:56 -04:00
Dan Stillman
ebc511f418 coroutine()async for Zotero.init() 2022-05-13 04:28:56 -04:00
Dan Stillman
f8e10f80cc fx-compat: __defineGetter__()defineProperty() 2022-05-13 04:28:56 -04:00
Dan Stillman
13b9837524 fx-compat: Fix New Item menu and serializePersist()
`document.getElementsByAttribute` → `document.querySelectorAll`
2022-05-13 04:28:56 -04:00
Dan Stillman
9222b939ab fx-compat: Fix error viewing items
`Components.classes["@mozilla.org/network/standard-url;1"]` no longer
exists
2022-05-13 04:28:56 -04:00
Dan Stillman
31677dd296 fx-compat: Fix error generating item context menus with locate options 2022-05-13 04:28:56 -04:00
Dan Stillman
f91bf49aae fx-compat: nsIIdleServicensIUserIdleService 2022-05-13 04:28:56 -04:00
Dan Stillman
1714351cc9 fx-compat: Fix position of collection and item context menus 2022-05-13 04:28:56 -04:00
Dan Stillman
b49b8ad140 fx-compat: Mostly fix About pane
Example of converting top-level XUL `<dialog/>` to
`<window><dialog/></window>`, which uses a Mozilla-provided `<dialog>`
Custom Element
2022-05-13 04:28:56 -04:00
Dan Stillman
f4675c02df fx-compat: Update nsILoginManager::findLogins() calls 2022-05-13 04:28:56 -04:00
Dan Stillman
c7c61f72c9 fx-compat: Stop trying to load overlay.js, which was removed 2022-05-13 04:28:56 -04:00
Dan Stillman
7ee40c4682 fx-compat: Fix Add Item by Identifier window
Still a little buggy
2022-05-13 04:28:56 -04:00
Dan Stillman
8075c2d938 Remove obsolete tab.css 2022-05-13 04:28:56 -04:00
Dan Stillman
753824a7e2 fx-compat: Temporarily disable quick search bar mode menu 2022-05-13 04:28:56 -04:00
Dan Stillman
a54da965a7 fx-compat: Use search-textbox custom element for quick search bar 2022-05-13 04:28:56 -04:00
Dan Stillman
26c4bea4fd fx-compat: .boxObject was removed in Fx69
https://bugzilla.mozilla.org/show_bug.cgi?id=1519948
2022-05-13 04:28:56 -04:00
Dan Stillman
0717612b4b fx-compat: Remove contentAreaContextMenu menupopup
No longer necessary
2022-05-13 04:28:56 -04:00
Dan Stillman
260c110d05 fx-compat: Convert itembox XBL to custom element
Still lots of things to fix, particularly with styling, but the basic
functionality is there.
2022-05-13 04:28:56 -04:00
Dan Stillman
3c6f0b26af Move .zotero-clicky to its own SCSS component
This will allow it to be included in shadow DOM.
2022-05-12 05:18:47 -04:00
Dan Stillman
87f2716da8 fx-compat: zoteroPane.xul → zoteroPane.xhtml 2022-05-12 05:18:47 -04:00
Dan Stillman
abfa09df51 fx-compat: loadURI() signature change in HTTP.loadDocuments() 2022-05-12 05:18:47 -04:00
Dan Stillman
59fd8247b4 fx-compat: Remove overlay.js, since overlays no longer exist 2022-05-12 05:18:47 -04:00
Dan Stillman
d635fdda41 fx-compat: AddonManager.getAllAddons() now returns a promise 2022-05-12 05:18:47 -04:00
Dan Stillman
94c7e0674d fx-compat: Remove 'context' from onStartRequest()/onStopRequest()/etc. 2022-05-12 05:18:47 -04:00
Dan Stillman
3a77abc8d2 fx-compat: Zotero files are now packaged in app/omni.ja, not zotero.jar 2022-05-12 05:18:47 -04:00
Dan Stillman
004d5db2c3 fx-compat: Services.console.getMessageArray() returns an actual array 2022-05-12 05:18:47 -04:00
Dan Stillman
fb8984c947 fx-compat: XULDocument → XMLDocument 2022-05-12 05:18:47 -04:00
Dan Stillman
46a52b3e3e fx-compat: Update locales code 2022-05-12 05:18:47 -04:00
Dan Stillman
6d5b2c3d12 Fx-compat: nsIUTF8ConverterServicensIScriptableUnicodeConverter
It's not totally clear what this does or if it's necessary (see #1540),
but this is a replacement that Thunderbird used.
2022-05-12 05:18:47 -04:00
Dan Stillman
bbecb4d0bd fx-compat: Add appcontent container to zoteroPane.xul
Part of inlining XUL

(View with -w for real diff)
2022-05-12 05:18:47 -04:00
Dan Stillman
1bb99a6bc8 fx-compat: nsIWebNavigation::loadURI() signature change 2022-05-12 05:18:47 -04:00
Dan Stillman
b6f5d7183f fx-compat: Remove use of tree.treeBoxObject and change getCellAt() signature
Properties and methods are now available on the tree itself, and
getCellAt() now returns an object instead of using in-out variables.
2022-05-12 05:18:47 -04:00
Dan Stillman
ee78dd308b fx-compat: Remove XBL stylesheets (WIP) 2022-05-12 05:18:47 -04:00
Dan Stillman
3f64310d45 fx-compat: Inline all XUL overlays 2022-05-12 05:18:47 -04:00
Dan Stillman
dd2ff63019 fx-compat: Replace nsIDOMParser with new DOMParser() 2022-05-12 02:38:59 -04:00
Dan Stillman
993320655e fx-compat: Throw error if generator is passed to DB.executeTransaction() 2022-05-12 02:38:59 -04:00
Dan Stillman
03242e8984 fx-compat: DB.executeTransaction() no longer takes generator functions 2022-05-12 02:38:59 -04:00
Dan Stillman
ccbc785499 fx-compat: XPCOMUtils.generateQI() → ChromeUtils.generateQI() 2022-05-12 02:38:59 -04:00
Adomas Venčkauskas
4d35cdf095 Remove unneeded constant in virtualized table 2022-05-10 17:03:34 +03:00
Adomas Venčkauskas
eb6b14a218 Fix item tree column resizing issues
Report https://forums.zotero.org/discussion/97077/problem-with-column-width-adjustment
2022-05-10 17:02:36 +03:00
Adomas Venčkauskas
a406e62fd3 Item Tree: Fix column dividers not aligned for second-level items
Closes #2605
2022-05-10 13:52:32 +03:00
Adomas Venčkauskas
aa483f579f HTML tree: Find-as-you-type remains on matching string.
Closes #2607
2022-05-10 13:35:31 +03:00
Dan Stillman
273fc6c657 Update locales from Transifex 2022-05-09 10:05:55 -04:00
Abe Jellinek
db5b535ea6 Update translate submodule 2022-05-07 20:34:37 -07:00
Adomas Ven
c49a05d486
Improve column resizing robustness (#2588)
Also:

* Add staticWidth and minWidth column properties
2022-05-03 03:00:23 -04:00
Martynas Bagdonas
01645c5e51
Pin library tab (#2589)
Fixes #2575
2022-05-03 01:21:59 -04:00
Abe Jellinek
097308c5c6 Update utilities submodule 2022-05-02 17:12:39 -07:00
Dan Stillman
b6fdeeca13 Fix deadlock in integrity check before DB schema upgrade
One of the repair steps uses a transaction, which is reasonable, so
don't run integrity check within transaction at startup.
2022-05-01 02:14:45 -04:00
Dan Stillman
d201fdc119 Fix target is undefined error during upgrade from Zotero 4
https://forums.zotero.org/discussion/96811/database-upgrade-error-when-migrating-from-version-4-0-to-6-0-directly-skipping-zotero-5

Regression from 078e3bb07, probably
2022-05-01 02:14:36 -04:00
Dan Stillman
5e0674b842 Add logging for PDF exports 2022-04-30 05:17:41 -04:00
Abe Jellinek
9829ea7009
Update utilities, move tests, add to CI (#2584) 2022-04-30 04:55:11 -04:00
Dan Stillman
fd859bd976 Update locales from Transifex and merge new English strings 2022-04-29 18:28:52 -04:00
Dan Stillman
b536432866 Fix mistake in tab-unavailable integration message 2022-04-29 16:54:16 -04:00
Dan Stillman
644cce219a Tweak tab-unavailable integration message 2022-04-29 16:51:41 -04:00
Adomas Venčkauskas
ff920de130 Fix integration transaction getting stuck when google docs tab is closed
Closes #2583
2022-04-29 15:19:20 +03:00
Adomas Venčkauskas
fca16d2ad5 Fix find-as-you-type not matching beyond first letter
Closes #2581
2022-04-29 15:19:20 +03:00
Martynas Bagdonas
70c9bef320 Switch tabs with Cmd-Option-←/→
Fixes #2475
2022-04-29 12:56:04 +03:00
Abe Jellinek
3bfc6740c4
Add tests for improved compareCallNumbers (#2579) 2022-04-28 04:43:30 -04:00
Abe Jellinek
5196ba379b
Update typeSchemaData and builder script (#2576) 2022-04-28 02:12:29 -04:00
Martynas Bagdonas
fe14ee79a3 Show a few missing options in Tools menu when PDF reader tab is open
Fixes #2502
2022-04-27 18:20:41 +03:00
Martynas Bagdonas
41bdd36068 Add an option to disable smart quotes
Fixes #2524
2022-04-27 10:23:10 +03:00
Dan Stillman
a4cdaf0407 Show "Add Note from Annotations" in attachment context menu 2022-04-27 02:34:42 -04:00
Dan Stillman
c405fa76a1 Add sortNotesChronologically.reader pref for PDF reader notes list
And default to true. I forgot we were sorting reverse chronologically by
default in order to make it easy to open recent notes.

Follow-up to https://github.com/zotero/zotero/issues/2526 for
https://forums.zotero.org/discussion/96743/pdf-reader-two-feature-requests
2022-04-26 17:59:45 -04:00
Dan Stillman
40501c3953 Update locales from Transifex and merge new English strings 2022-04-26 17:22:39 -04:00
Martynas Bagdonas
10c8fc4c74 Implement tab duplication
Fixes #2566
2022-04-26 19:41:51 +03:00
Abe Jellinek
89aaa10504
Sort LC call numbers better, sort integers as integers (#2569)
* Update utilities submodule after https://github.com/zotero/utilities/pull/8
* Extract and add tests
2022-04-26 04:11:29 -04:00
Martynas Bagdonas
7a06671ecb Fix undefined variable issue in annotation templates 2022-04-26 08:29:42 +02:00
Adomas Venčkauskas
d96ebad82a Allow adding multiple sources at once in classic citation dialog.
Closes #2568
2022-04-25 13:28:00 +03:00
Adomas Venčkauskas
1be2d69f1e Log integration invocations before other integration actions 2022-04-25 12:43:48 +03:00
Martynas Bagdonas
b8d427790c Fix error when using a note template and checking if array is not empty 2022-04-23 14:52:24 +07:00
Adomas Venčkauskas
d9463daa66 HTML Tree: Search by typing loops instead of starting from beginning
Closes #2559
2022-04-22 10:58:25 +03:00
Martynas Bagdonas
c1fde1d3d9 Improve tab title visibility and adjust scroll arrow scroll step
Fixes #2554
Fixes #2553
2022-04-22 13:07:18 +07:00
Dan Stillman
114b48d5b8 Update locales from Transifex 2022-04-21 15:46:50 -04:00
Dan Stillman
031ff1824b Fix middle click to close tabs (#1993) 2022-04-21 12:23:14 -04:00
Martynas Bagdonas
a8cb9bfddd Restore custom note styling
Fixes #2560
2022-04-21 13:17:04 +07:00
Abe Jellinek
f91ca9c18a Don't merge with a deleted master attachment 2022-04-20 11:04:24 -07:00
Martynas Bagdonas
142e3b09f8
Unload tabs (#2500)
- Keep all tabs unloaded on Zotero opening.
- Keep loaded only the last five selected tabs.
- Keep loaded only in the last 24h selected tabs.

Fixes #2383
2022-04-20 03:14:50 -04:00
Dan Stillman
578986ab1e Fix item types not appearing in New Item submenu
https://forums.zotero.org/discussion/96530/a-issue-about-new-item-drop-down-menu

After a type from the submenu was selected and added to the MRU, the
submenu wouldn't be updated. Not sure how long this has been going on.

Fixes #2534
2022-04-19 23:04:18 -04:00
Martynas Bagdonas
5d442b706e
Make tab bar scrollable (#2506)
Fixes #2232
2022-04-19 18:51:32 -04:00
Adomas Ven
7b0d6951d2
Update csl validator for CSL 1.0.2 (#2493) 2022-04-19 18:42:48 -04:00
Dan Stillman
3f10e4c064 Bad JSON in sync cache shouldn't break syncing
https://forums.zotero.org/discussion/95926/zotero-not-syncing-report-id-1924846177
2022-04-19 17:49:13 -04:00
Martynas Bagdonas
5c8ea0174a Fix empty table row height in generated report, prevent table overflow
Fixes #2545
2022-04-15 21:59:27 +07:00
Adomas Venčkauskas
5ca8486047 Adjust conditional clause for Windows from 76276a3 2022-04-15 11:21:07 +03:00
Adomas Venčkauskas
76276a39ce HTML Tree: adjust row padding per OS 2022-04-15 11:15:40 +03:00
Abe Jellinek
e8ad2fab95
getSortTitle: Only strip initial punctuation clusters (#2537)
Specifically exclude @, #, and *
2022-04-15 02:08:14 -04:00
Dan Stillman
c9b39675ba Update locales from Transifex and merge new English strings 2022-04-14 18:06:32 -04:00
Dan Stillman
498e38730b Update translate submodule 2022-04-14 18:06:32 -04:00
Abe Jellinek
d842e7a9bc Fix save() without transaction when saving search 2022-04-14 14:39:34 -07:00
Martynas Bagdonas
f494ab5114
Allow creating and editing tables in note-editor (#2511)
Fixes #2480
2022-04-14 17:17:32 -04:00
Adomas Venčkauskas
01506b27e9 Allow moving cursor by clicking on collection name while editing
Closes #2513
2022-04-14 17:03:54 +03:00
Adomas Venčkauskas
599c6821b7 Ensure columns don't resize when switching tabs 2022-04-14 16:51:13 +03:00
Abe Jellinek
1538a836b9
Show label of translator that causes import error (#2539) 2022-04-14 07:01:43 -04:00
Dan Stillman
08d3880d88 Don't remove relations in annotation item JSON
This was causing UUIDs for annotations from Mendeley imports to be
removed after a sync, resulting in annotations being duplicated on a
reimport.
2022-04-14 06:37:30 -04:00
Abe Jellinek
3792c89fbd Allow >4 numbers after the decimal point in Dewey
https://github.com/zotero/zotero/pull/2538#issuecomment-1097292396
2022-04-12 15:45:50 -07:00
Abe Jellinek
ce39185fa7
Sort call numbers alphabetically, handle Dewey specially (#2538) 2022-04-12 17:40:25 -04:00
Dan Stillman
a72deb4648 Update locales from Transifex and merge new English strings 2022-04-12 02:57:07 -04:00
Abe Jellinek
e03c1603ca Fix "%S" in displayed startup error message 2022-04-11 19:03:29 -07:00
Abe Jellinek
38f5551ee5
Add "Open PDF in New Window" to context menu (#2490)
Also:

* Remove Locate tooltips
2022-04-11 17:53:40 -04:00
Abe Jellinek
a5fc8b859c Context Pane: Use getNoteTitle()
ad36c9fb2a (r71022779)
2022-04-11 13:36:03 -07:00
Abe Jellinek
b8b1f8be55
Disable Import actions in uneditable libraries (#2471) 2022-04-11 16:12:43 -04:00
Abe Jellinek
ad36c9fb2a Context Pane: Sort notes in item tree order
Fixes #2526.
2022-04-11 10:13:50 -07:00
Abe Jellinek
892c1169c8 Attachment merge: Compare link mode type
Actually fixes #2527.
2022-04-11 09:30:16 -07:00
Adomas Venčkauskas
237bd8f0ce Fix Restore Column Order in Item Tree not always working
Closes #2521
2022-04-11 13:55:30 +03:00
Adomas Ven
4c445554a3
Item Tree: Attempt to fix OS font scaling (#2488) 2022-04-11 05:16:59 -04:00
Martynas Bagdonas
2af7275968 Fix template condition evaluating to true for empty string from function
Fixes #2529
2022-04-11 12:22:20 +07:00
Abe Jellinek
be0b0a7151
Always autocomplete creators in hideEditor (#2516) 2022-04-11 00:21:14 -04:00
Abe Jellinek
47a2f3cad9 Attachment merge: Compare linkModes, improve logging
Using keys instead of IDs should make logs more useful.
Fixes #2527.
2022-04-09 20:39:37 -07:00
Dan Stillman
0df8b7670d Fix broken tag selector with colored tags that differ with normalization
https://forums.zotero.org/discussion/96138/lost-content-in-tag-selector

An entered character from the CJK_COMPATIBILITY_IDEOGRAPHS block (char
code 63834, or similar) was normalized to the CJK_UNIFIED_IDEOGRAPHS
block (char code 35712), which then caused an expected key not to exist.

To fix, normalize colored tag values coming from the DB.
2022-04-09 06:24:17 -04:00
Martynas Bagdonas
2112aa7271 Don't jump back to library tab when PDF recognition finishes 2022-04-08 15:31:28 +07:00
Adomas Venčkauskas
b850d16c89 Fix integration error handling code when citeproc-rs disabled.
Closes #2508
2022-04-08 10:41:35 +03:00
Martynas Bagdonas
bdbde99fa7 Remove alpha channel from highlight color when inserting a note
Fixes #2499
2022-04-08 13:00:33 +07:00
Abe Jellinek
dea9fc5e88 Scaffold: setInterval -> activate listener 2022-04-07 19:50:13 -07:00
Abe Jellinek
a40ab83b71
Fix double separator in Edit menu on Win/Linux (#2507) 2022-04-06 23:42:13 -04:00
Abe Jellinek
fbaa1c6e61 Fix huge Scaffold toolbar icons on Win/Linux 2022-04-05 14:50:05 -07:00
Adomas Venčkauskas
c510d91461 Fix an error that causes test failures (regression 9a5657b) 2022-04-05 10:08:10 +03:00
Adomas Venčkauskas
5b9ac2ca53 Fix a non-terminal startup error introduced in d7b1a53 2022-04-05 10:08:10 +03:00
Dan Stillman
28ec72666f Update locales from Transifex and merge new English strings 2022-04-04 14:02:08 -04:00
Adomas Venčkauskas
9a5657bf79 Item Tree: Fix fixed-width columns sometimes changing width 2022-04-04 16:06:51 +03:00
Martynas Bagdonas
f877476c1a Partially disable buggy ff <64 table resizing handles in note-editor
Unfortunately the first opened note will still have the handles.
2022-04-01 17:09:08 +07:00
Martynas Bagdonas
3f4030ff80 Allow copying image annotations to external text fields
Fixes #2447
2022-04-01 17:09:08 +07:00
Abe Jellinek
a5b3d6440b
Fix next duplicates set selection after merge (#2448) 2022-03-31 17:46:30 -07:00
Martynas Bagdonas
3356557493 Add 'Zoom to Page Height' PDF reader option
Fixes #2255
2022-03-31 15:52:00 +07:00
Martynas Bagdonas
8e54f1649b Add annotation to note at cursor position
Fixes #2487
2022-03-31 12:14:11 +07:00
Abe Jellinek
e922ae711a Fix ProgressQueue titles for cases, letters, etc.
Handles items with an alternate field that maps to title (like cases)
and items for which the title is usually filled in by updateDisplayTitle()
(like letters).
2022-03-30 16:30:07 -07:00
Abe Jellinek
2a1ce292d2 Remove Note Font Size -> Reset restart prompt
+ replace empty menuitem with a divider as in the Font Size menu.
2022-03-30 14:55:48 -07:00
Abe Jellinek
27c9086222 Scaffold: Show "defer" value in test list 2022-03-30 14:49:42 -07:00
Abe Jellinek
745069c070 Don't strip punctuation before numbers
Fixes #2496
2022-03-30 11:58:55 -07:00
Dan Stillman
f2209974b2 Don't show "Export PDF" in reader
Save As already exists
2022-03-30 14:13:24 -04:00