22222
4044548f3e
Add 'will-prevent-unload' event.
2017-05-11 06:35:35 -05:00
Heilig Benedek
bf58373a40
fix NativeImage size hint crashing when image is created from path
2017-05-11 11:38:34 +02:00
Ryohei Ikegami
7ac93045b7
Merge branch 'master' into native-window-open
2017-05-11 13:51:43 +09:00
Heilig Benedek
a76a4ddff2
🎨 lint fix
2017-05-10 23:04:19 +02:00
gellert
b1095faa71
minor fix for macos
2017-05-10 22:19:05 +02:00
Heilig Benedek
6f80379b30
use computeSize64 instead of getSize
2017-05-10 22:19:05 +02:00
Heilig Benedek
8d1c17e036
remove GetSizeForNewRenderView
2017-05-10 22:19:05 +02:00
Heilig Benedek
5c690ea46e
don't store isolate_ in NativeImage and tune size hints
2017-05-10 22:19:05 +02:00
Heilig Benedek
576b702e8b
update native_mate and use the MarkHighMemoryUsage API to speed up garbage collection
2017-05-10 22:19:05 +02:00
Heilig Benedek
92cc6746b1
resolve errors introduced during rebase
2017-05-10 22:19:05 +02:00
gellert
aa89bc0bb8
use outer webcontents for popups
2017-05-10 22:19:05 +02:00
Heilig Benedek
f03dccadb3
use white gutter color and paint damage rects over when paint starts in software osr
2017-05-10 22:19:05 +02:00
Heilig Benedek
3b94d268eb
lint fix 📝
2017-05-10 22:19:05 +02:00
Heilig Benedek
c54f7f2a8d
use bounds instead of bounds_in_pixel
2017-05-10 22:19:05 +02:00
Heilig Benedek
1fcf6ea73f
add size hints to NativeImages to make node GC aware of the high amount of memory used by the instances
2017-05-10 22:19:05 +02:00
Heilig Benedek
89277dda90
fix leaking of NativeImage instances
2017-05-10 22:19:05 +02:00
Heilig Benedek
704fde1939
port CEF pr that speeds up and simplifies GPU rendering
2017-05-10 22:19:05 +02:00
Heilig Benedek
2f32311292
fix black bars around popups and scaled images when using gpu rendering
2017-05-10 22:19:05 +02:00
gellert
155fef99ae
adds offscreen renderer ipc message to disable external popups
2017-05-10 22:19:05 +02:00
gellert
6b33564056
adds ipc send to disable external popups on macos
2017-05-10 22:19:05 +02:00
Heilig Benedek
ff053bbe06
call InvalidateBounds when popup updates
2017-05-10 22:19:05 +02:00
gellert
062b1ed43e
moves createviewfordwidget method to osrrwhv
2017-05-10 22:19:05 +02:00
Heilig Benedek
bccc25165d
fix mouse wheel event sending typo
2017-05-10 22:19:05 +02:00
Heilig Benedek
8f546313b6
add popup window bounds to damage_rect
2017-05-10 22:19:05 +02:00
Heilig Benedek
c9fa71bdb3
lint fix
2017-05-10 22:19:05 +02:00
Heilig Benedek
20d2ab29ab
Add support for child and popup windows in OSR
2017-05-10 22:19:05 +02:00
Kevin Sawicki
b6319698f1
Bump v1.7.0
2017-05-10 10:42:05 -07:00
Kevin Sawicki
de38461a3f
Update NotifyObserversCertDBChanged call to take no arguments
2017-05-10 10:05:48 -07:00
Kevin Sawicki
fb85b26767
Merge remote-tracking branch 'origin/master' into chrome58
2017-05-10 09:42:19 -07:00
Kevin Sawicki
f0c38b7354
Bump v1.6.9
2017-05-10 08:35:30 -07:00
Kevin Sawicki
65bd0ecaa9
Upgrade to Chrome 58.0.3029.110
2017-05-09 21:14:22 -07:00
Hari Juturu
277c3155a6
use will-create-webview event
2017-05-09 10:12:44 -07:00
Kevin Sawicki
8c856922f3
Merge pull request #9292 from 22222/issue8911
...
Fix #8911
2017-05-09 09:06:26 -07:00
Cheng Zhao
efe23b7595
Use Node's memory allocator for ArrayBuffer
...
For Buffers created in Node, they are usually allocated in Node and
freed by Chromium's allocator, which will cause crashes when Node and
Chromium are using different allocators.
This commit makes Chromium use Node' allocator for ArrayBuffers.
2017-05-09 14:12:39 +09:00
renaesop
dfcc882dcc
Add a test for webcontents.printerList.
2017-05-09 10:38:03 +08:00
renaesop
cba5e96496
Merge remote-tracking branch 'ups/master'
2017-05-09 09:44:24 +08:00
Hari Krishna Reddy Juturu
3321f7d39c
Changing command line option name
2017-05-08 17:27:31 -07:00
Kevin Sawicki
8be4332765
coffee -> js
2017-05-08 14:06:58 -07:00
Kevin Sawicki
3dee76a6c1
🎨
2017-05-08 13:43:13 -07:00
Hari Krishna Reddy Juturu
94d054cf11
Add option to override webview security
2017-05-06 22:10:42 -07:00
Hari Krishna Reddy Juturu
b4a8ed01f1
PR 44648: Enabling creation on webview with node-integration disabled and raising events
...
- Enabling creation on webview with node-integration disabled and raising events
Conflicts:
lib/browser/guest-view-manager.js
2017-05-06 20:50:01 -07:00
Hari Krishna Reddy Juturu
d65c4fe912
CPU Usage requires process metrics to be preserved
2017-05-05 02:38:51 -07:00
Hari Krishna Reddy Juturu
6b51c25820
Exposing cpu & io counters function similar to mem methods
2017-05-04 14:48:37 -07:00
Hari Krishna Reddy Juturu
982c5064d8
Removing extra bool
2017-05-04 14:33:59 -07:00
Hari Krishna Reddy Juturu
8a5aa04756
Adding CPU and I/O metrics to process module
2017-05-04 14:33:59 -07:00
Kevin Sawicki
70e199e255
Merge pull request #9333 from electron/process-memory-info-sandbox
...
Expose `process.get{System,Process}MemoryInfo` to sandbox
2017-05-04 14:17:44 -07:00
Kevin Sawicki
eebae82bc1
Merge pull request #9315 from electron/segmented-control-mode
...
Add mode prop to segmented touch bar control
2017-05-04 14:16:28 -07:00
Kevin Sawicki
59511354fd
Merge pull request #9214 from electron/app-memoryinfo
...
API to get memory of all processes of the app
2017-05-04 14:00:30 -07:00
Hari Krishna Reddy Juturu
ab1bcefe9e
Make pid an integer
2017-05-04 13:37:43 -07:00
Kevin Sawicki
e206aae9fc
🎨 Use snake case
2017-05-04 13:27:42 -07:00
Kevin Sawicki
c59fab0179
Merge pull request #9242 from shiftkey/certificate-addition-windows
...
certificate trust API for Windows
2017-05-03 16:39:00 -07:00
Kevin Sawicki
110611f242
🎨
2017-05-03 16:22:56 -07:00
22222
042b511a27
Fix #8911
2017-05-03 12:47:00 -05:00
Kevin Sawicki
e1d564da6e
Upgrade to Chrome 58.0.3029.96
2017-05-03 08:49:57 -07:00
Samuel Attard
718dc732ad
Add docs and add isSelected arg
2017-05-03 20:25:50 +10:00
Kevin Sawicki
c6c93211be
Merge remote-tracking branch 'origin/master' into chrome58
2017-05-02 09:15:16 -07:00
Brendan Forster
e5648072dc
handle untrusted root as well as self-signed
2017-05-02 11:25:51 +10:00
Kevin Sawicki
a748199833
Bump v1.6.8
2017-05-01 15:09:30 -07:00
Kevin Sawicki
b639dd0c81
Remove unused include/require statement
2017-05-01 10:30:11 -07:00
Kevin Sawicki
f2f6415543
Use v8 to parse message as JSON
2017-05-01 10:30:11 -07:00
Thiago de Arruda
bbe21cce67
Expose more atom_bindings.cc functions to sandbox
2017-05-01 09:12:39 -03:00
deepak1556
0476e2fd3d
destroy browserView webContents asynchronously
2017-05-01 16:53:55 +09:00
deepak1556
c68f41b8d8
destroy new window webContents asynchronously
2017-05-01 16:53:55 +09:00
deepak1556
5e976be43b
remove page-title-updated workaround for #3380
2017-05-01 16:53:55 +09:00
deepak1556
9e3b8ade12
invoke WebContentsDestroyed manually when destruction path is async
2017-05-01 16:53:14 +09:00
deepak1556
f974a6bda9
browser: make destruction of webContents async
2017-05-01 16:53:14 +09:00
Ryohei Ikegami
8b6b512485
Pass nativeWindowOpen flag to isolated init.js
2017-04-30 19:35:41 +09:00
Brendan Forster
14f29e1319
it's 2017 get with the times
2017-04-29 19:29:07 +10:00
Brendan Forster
1ccc2afb03
underscore case all the things
2017-04-29 19:28:42 +10:00
Thiago de Arruda
19b6ba044b
Fix context leak in ObjectLifeMonitor.
...
The RemoteObjectFreer class is keeping the context alive even when the window is
closed. For electron applications that use sandbox, this will cause a memory
leak every time a new window is created with `window.open`.
Close #9191
2017-04-28 11:21:53 -03:00
Samuel Attard
225ccab3d2
Add mode prop to segmented touch bar control
2017-04-28 14:50:58 +10:00
Hari Krishna Reddy Juturu
07b53c0284
Return mate::Dictionary instead of v8::value
2017-04-27 21:07:35 -07:00
HariJ
81bd9fa3a2
fixing mac ut failure
2017-04-27 14:06:53 -07:00
Hari Krishna Reddy Juturu
3d12440a4a
Fixing mac build
2017-04-27 14:06:53 -07:00
Hari Krishna Reddy Juturu
27aad902b8
Adding docs, specs and fixing object returned
2017-04-27 14:06:53 -07:00
Hari Krishna Reddy Juturu
bef7d5a520
API to get memory of all processes of the app
2017-04-27 14:06:53 -07:00
Cheng Zhao
dd2d0b3f4f
Update to Chrome 58.0.3029.81
2017-04-27 18:57:04 +09:00
Cheng Zhao
4c47f2d15e
Update to Node v7.9.0
2017-04-27 17:20:01 +09:00
Cheng Zhao
301ed2d66c
Fix typo when updating code
2017-04-27 16:34:52 +09:00
Cheng Zhao
620a1ca167
Fix unresolved symbol to icu::DateInterval
2017-04-27 16:34:52 +09:00
Cheng Zhao
e6e985c677
Fix linking error with icu symbols
2017-04-27 16:34:52 +09:00
Cheng Zhao
5563cf0dc5
Automatically register secure schemes in renderer
...
Otherwise the behavior of secure schemes would be different with before.
2017-04-27 16:34:52 +09:00
Cheng Zhao
0fb746b350
Fix crash when using secure schemes
2017-04-27 16:34:52 +09:00
Cheng Zhao
fb42a72ad8
Fix building on Windows
2017-04-27 16:34:52 +09:00
Cheng Zhao
8c5fd76286
Fix symbol conflicts in Xlib.h
2017-04-27 16:34:52 +09:00
Cheng Zhao
b3d60bfb3a
Fix building on Linux
2017-04-27 16:34:52 +09:00
Cheng Zhao
97fd383c53
There are a few more new values for ChangeCause
2017-04-27 16:34:52 +09:00
Cheng Zhao
08069e18db
Don't use gzip when uploading crash reports
2017-04-27 16:34:52 +09:00
Cheng Zhao
b2b2d8d9a4
Fix crash on exit
2017-04-27 16:34:52 +09:00
Cheng Zhao
d85b58fdb5
Fix API changes of FrameSubscriber
2017-04-27 16:34:52 +09:00
Cheng Zhao
e43b34b8f8
Use blink::SchemeRegistry over WebSecurityPolicy
...
The latter is removing some APIs we use.
2017-04-27 16:34:52 +09:00
Cheng Zhao
481b04358e
Fix blink API changes
2017-04-27 16:34:52 +09:00
Cheng Zhao
8634f37dfc
Add gen/third_party/WebKit to include dirs
2017-04-27 16:34:52 +09:00
Cheng Zhao
dd3d791cb9
IsolateHolder API has been changed
2017-04-27 16:34:52 +09:00
Cheng Zhao
5fb87f0c1e
ResourceHandler API has been changed
2017-04-27 16:34:52 +09:00
Cheng Zhao
6be10ffef2
Fix more API changes due to name changes
2017-04-27 16:34:52 +09:00
Cheng Zhao
50e3bfa764
Fix API changes of base::Value
2017-04-27 16:34:52 +09:00
Cheng Zhao
9d1b88ed59
Fix API changes in OSR code
2017-04-27 16:34:52 +09:00
Cheng Zhao
fc2d62d5cb
Fix API changes of Chrome58
2017-04-27 16:34:52 +09:00
Cheng Zhao
453cb2c0b4
Upgrade to Chrome 58.0.3029.40
2017-04-27 16:34:52 +09:00
Brendan Forster
a1599cf881
focus on the self-signed certificate flow here
2017-04-27 15:06:23 +10:00
Brendan Forster
5151107c28
tighten up indenting
2017-04-27 15:01:55 +10:00
Brendan Forster
50af70a0e8
Merge branch 'master' into certificate-addition-windows
2017-04-27 14:47:50 +10:00
Brendan Forster
80212c0ab4
actually validate the chain before adding
2017-04-27 14:44:58 +10:00
Ryohei Ikegami
1d73e84a29
Merge branch 'master' into native-window-open
2017-04-27 12:03:55 +09:00
Kevin Sawicki
7881376aff
Merge pull request #9254 from electron/endsession-event
...
End session event on browser window
2017-04-24 12:02:05 -07:00
Hari Krishna Reddy Juturu
8458acff26
Removing #ifdef on endsession api
2017-04-24 11:58:08 -07:00
Hari Krishna Reddy Juturu
8a32826876
Removing #ifdef windows for endsession methods
2017-04-24 11:49:21 -07:00
Hari Krishna Reddy Juturu
9e70372c1f
change endsession event name to session-end
2017-04-24 10:16:11 -07:00
Kevin Sawicki
13e4582697
Emit autoUpdater error directly as Error object
2017-04-24 09:47:30 -07:00
Brendan Forster
f644ba56a3
clean up the code a bit
2017-04-24 11:49:55 +10:00
Brendan Forster
253a4b0114
Merge remote-tracking branch 'electron/master' into certificate-addition-windows
2017-04-24 11:13:34 +10:00
Brendan Forster
ac3385124a
reload the current cert database if the certificate was added
2017-04-24 11:12:26 +10:00
Hari Krishna Reddy Juturu
9e8252c1f9
Remove wm_state change
2017-04-21 14:35:30 -07:00
Hari Krishna Reddy Juturu
3c3e14b820
End session event on browser window
2017-04-21 14:22:11 -07:00
Brendan Forster
c181a8269d
and this is how we invoke the callback
2017-04-21 12:47:11 +10:00
Brendan Forster
1439a1e322
and the order here matters apparently
2017-04-21 12:23:50 +10:00
Brendan Forster
b3baf9976f
coding style fixes
2017-04-21 12:17:01 +10:00
Kevin Sawicki
a004cada7c
Merge pull request #9095 from seanchas116/better-path-resolve
...
Search for module from app path when URL is not file protocol
2017-04-20 10:49:53 -07:00
Kevin Sawicki
dc8b43901b
Merge pull request #9108 from yuya-oc/add-macos-sheet-events
...
Add sheet-begin and sheet-end events to macOS BrowserWindow
2017-04-20 10:33:31 -07:00
Kevin Sawicki
29a3e11893
Group sheet event methods with other macOS methods
2017-04-20 10:32:14 -07:00
Brendan Forster
5f1bcd2d16
a first pass at the script to import the certificate for Windows
2017-04-20 21:12:32 +10:00
Brendan Forster
dca08c208b
and use the same signature for Windows
2017-04-20 14:21:08 +10:00
Brendan Forster
4f40b8a42c
stub the windows source file
2017-04-20 14:21:08 +10:00
Kevin Sawicki
4a9383b50b
Bump v1.6.7
2017-04-18 09:17:16 -07:00
Hari Krishna Reddy Juturu
fe88697348
fixup! fixup! Adding cookie flush store api
2017-04-18 09:05:13 -07:00
Hari Krishna Reddy Juturu
19709a50e9
Adding cookie flush store api
2017-04-18 09:05:13 -07:00
Kevin Sawicki
c32a723e29
Only read iconPosition when icon is present
2017-04-18 08:58:54 -07:00
Samuel Attard
526d287d25
Make iconPosition non-breaking by defaulting to overlay
2017-04-18 08:56:39 -07:00
Samuel Attard
11c7c107a9
add iconPosition property to touch bar buttons
2017-04-18 08:56:39 -07:00
Ryohei Ikegami
8dff29185b
Merge branch 'master' into native-window-open
2017-04-18 21:59:22 +09:00
Alexandre Lachèze
9aff17afea
👕 alphabetical order
2017-04-18 13:44:31 +02:00
Alexandre Lachèze
f375e8a7db
Add OS process id to web-contents
2017-04-18 12:31:20 +02:00
Birunthan Mohanathas
3bcf5e0e9f
Fix OverrideSiteInstanceForNavigation() signature
2017-04-18 11:51:38 +03:00
Birunthan Mohanathas
dcf6c52f51
Actually hide menubar area when menu is autohidden
...
This was a regression introduced in 638eae10
2017-04-17 12:31:39 +03:00
Yuya Ochiai
75184046f6
Add events to manage sheets of macOS BrowserWindow
2017-04-15 16:26:45 +09:00
Birunthan Mohanathas
e7d71000ee
Fix missing warning icon with dialog.showMessageBox() on macOS
...
Fixes #9183 .
2017-04-14 19:27:25 +03:00
Ryohei Ikegami
ea6890aa5c
Use const
2017-04-13 23:26:42 +09:00
Kevin Sawicki
fe8726d775
Use Chrome default client inset handling
2017-04-13 13:03:46 +03:00
Ryohei Ikegami
9d62b196d3
Use base::FilePath
2017-04-13 10:59:12 +09:00
Birunthan Mohanathas
06fcf2c19d
Add support for BrowserView autoresizing
2017-04-13 01:27:31 +03:00
Birunthan Mohanathas
638eae1080
Remove MenuLayout in favor of NativeWindowViews::Layout
2017-04-13 01:27:31 +03:00
Birunthan Mohanathas
8b9f7e5b00
Implement initial, experimental BrowserView API
...
Right now, `<webview>` is the only way to embed additional content in a
`BrowserWindow`. Unfortunately `<webview>` suffers from a [number of
problems](https://github.com/electron/electron/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20label%3Awebview%20 ).
To make matters worse, many of these are upstream Chromium bugs instead
of Electron-specific bugs.
For us at [Figma](https://www.figma.com ), the main issue is very slow
performance.
Despite the upstream improvements to `<webview>` through the OOPIF work, it is
probable that there will continue to be `<webview>`-specific bugs in the
future.
Therefore, this introduces a `<webview>` alternative to called `BrowserView`,
which...
- is a thin wrapper around `api::WebContents` (so bugs in `BrowserView` will
likely also be bugs in `BrowserWindow` web contents)
- is instantiated in the main process like `BrowserWindow` (and unlike
`<webview>`, which lives in the DOM of a `BrowserWindow` web contents)
- needs to be added to a `BrowserWindow` to display something on the screen
This implements the most basic API. The API is expected to evolve and change in
the near future and has consequently been marked as experimental. Please do not
use this API in production unless you are prepared to deal with breaking
changes.
In the future, we will want to change the API to support multiple
`BrowserView`s per window. We will also want to consider z-ordering
auto-resizing, and possibly even nested views.
2017-04-13 01:27:27 +03:00
Kevin Sawicki
1c44bcf654
Merge pull request #8786 from electron/per-monitor-dpi-aware
...
Enable per-monitor DPI for Win10
2017-04-12 12:27:41 -07:00
Ryohei Ikegami
b19c5154ca
Fix cpplint errors
2017-04-12 12:25:56 +09:00
Ryohei Ikegami
b07c3adca9
Fix comment for ChildWebContentsTracker
2017-04-12 12:20:53 +09:00
Kevin Sawicki
efa28503a7
Merge pull request #9148 from electron/share-render-frame-observer-with-sandbox
...
Refactor: Share AtomRenderFrameObserver with AtomSandboxedRendererClient
2017-04-11 10:02:12 -07:00
Kevin Sawicki
e7b679ead6
Add IsEmpty helper and remove GetInstance public usage
2017-04-11 09:09:17 -07:00
Kevin Sawicki
da5d7d72b0
Add GetWindows helper that returns a vector
2017-04-11 09:09:17 -07:00
Kevin Sawicki
0883a9f966
Use CloseAllWindows helper
2017-04-11 09:09:17 -07:00
Kevin Sawicki
8311aa667c
Add DestroyAllWindows helper that uses vector copy
2017-04-11 09:09:17 -07:00
Kevin Sawicki
29c68182df
Always set NSScrollViewRubberbanding scroll bounce pref
2017-04-11 08:42:41 -07:00
Cheng Zhao
c59ef0efc5
Enable per-monitor DPI
2017-04-11 15:17:15 +09:00
Thiago de Arruda
039aaba758
Move AtomRenderFrameObserver creation to RendererClientBase.
...
Also remove AtomSandboxedRenderFrameObserver class.
2017-04-08 11:54:58 -03:00
Thiago de Arruda
72781e38c8
Change AtomRenderFrameObserver.renderer_client_ type to RendererClientBase.
2017-04-08 11:27:19 -03:00
Thiago de Arruda
ef07e25f9d
Make SetupMainWorldOverrides/isolated_world pure virtual.
...
Also implement stubs in AtomSandboxedRendererClient.
2017-04-08 11:12:18 -03:00
Thiago de Arruda
f751335bf9
Make DidCreateScriptContext/WillReleaseScriptContext pure virtual.
2017-04-08 10:58:13 -03:00
Thiago de Arruda
0227254774
Move DidClearWindowObject into RendererClientBase.
...
Also adapt AtomSandboxedRenderFrameObserver to forward DidClearWindowObject to
RendererClientBase.
2017-04-08 10:43:19 -03:00
Thiago de Arruda
91ee0ea740
Move AtomRenderFrameObserver into a separate module.
...
Also move SetupMainWorldOverrides into the AtomRendererClient class(since the
code there is specific to AtomRendererClient).
2017-04-08 10:29:05 -03:00
Kevin Sawicki
8a324a9375
Bump v1.6.6
2017-04-07 09:01:28 -07:00
Kevin Sawicki
4ec7cc913d
Merge pull request #9117 from electron/fix_debug_checks
...
Fixed a couple of failing debug checks when calling Chromium APIs
2017-04-06 08:48:15 -07:00
Ryohei Ikegami
34ed1a9ef8
Track child web contents
2017-04-06 12:15:27 +09:00
Ryohei Ikegami
526086d900
Improve RootWebContentsTracker
2017-04-06 11:37:21 +09:00
Ales Pergl
73e3fd01eb
Fixed a couple of failing debug checks when calling Chromium APIs
2017-04-05 14:45:46 +02:00
Ryohei Ikegami
b683584859
Add better comments to ShouldCreateNewSiteInstance
2017-04-05 18:16:10 +09:00
Ryohei Ikegami
cbdd52e43b
Always create new SiteInstance on root WebContents
2017-04-05 17:51:17 +09:00
Ryohei Ikegami
90852c665d
Pass RenderFrameHost to ShouldCreateNewSiteInstance
2017-04-05 13:47:02 +09:00
Kevin Sawicki
aa75e4562e
Restore delivering IPC messages to utility handlers
2017-04-04 20:40:57 -07:00
Kevin Sawicki
6a22c6645e
Guard against missing popover identifier
2017-04-04 13:51:39 -07:00
Kevin Sawicki
9c73c991d7
Use const references for params
2017-04-04 13:51:39 -07:00
Samuel Attard
bea56bbdc8
Update as per feedback
2017-04-04 13:51:38 -07:00
Samuel Attard
2fd62d090a
Allow items to be assigned to multiple popovers
2017-04-04 13:51:33 -07:00
Samuel Attard
f05dfc74da
Store parent popover in popover touch bar items
2017-04-04 13:51:13 -07:00
Kevin Sawicki
7f8e490839
Take const reference
2017-04-04 12:50:41 -07:00
Kevin Sawicki
d596d85288
🎨
2017-04-04 12:50:41 -07:00
Kevin Sawicki
df0f468dea
Add escapeKeyReplacementItemIdentifier forward declaration
2017-04-04 12:50:41 -07:00
Samuel Attard
60cc862031
Make everything pointer like
2017-04-04 12:50:41 -07:00
Samuel Attard
4d6b0fc01b
Add a method to set the escape identifier on the touch bar
2017-04-04 12:50:41 -07:00
Kevin Sawicki
3e9014c371
Merge pull request #9099 from electron/certificate-trust
...
macOS: Add certificate trust API
2017-04-04 11:17:09 -07:00
joshaber
736d6afe73
As you wish linter
2017-04-04 09:23:30 -04:00
joshaber
146e1ed3ce
Don't pass the result through
...
It's meaningless on macOS, at least.
2017-04-04 09:21:15 -04:00
joshaber
0cab8a3322
Put CertFromData in an anon namespace
2017-04-04 09:19:23 -04:00
Ryohei Ikegami
61fa8693d2
Merge branch 'master' into native-window-open
2017-04-04 20:54:37 +09:00
Ryohei Ikegami
e7b9b4b1a5
Always create new site instance
2017-04-04 20:54:10 +09:00
Ryohei Ikegami
3eab5df4a4
Revert "Reuse site instance only on window.open"
...
This reverts commit 4d61d071b2
2017-04-04 13:48:17 +09:00
Cheng Zhao
7265a0c1b4
Merge pull request #8528 from Anatzum/patch-1
...
Use kioclient for MoveItemToTrash on KDE
2017-04-04 12:15:21 +09:00
joshaber
8d465234e4
Appease our linty overlords
2017-04-03 21:40:46 -04:00
joshaber
2badfbe04f
Remove the intermediate function
2017-04-03 21:22:37 -04:00
joshaber
b3e865a478
Fix some style things
2017-04-03 21:22:14 -04:00
Ryohei Ikegami
24fedb2e20
No extra linebreak
2017-04-04 09:40:38 +09:00
Ryohei Ikegami
4a7eec8f2d
Pass app path as command line argument
2017-04-04 09:36:01 +09:00
joshaber
370cf815d9
Get rid of intermediates and rehydrate from issuerCert
2017-04-03 16:27:53 -04:00
joshaber
74c0cbddae
Linebreak to keep the linter happy
2017-04-03 16:07:02 -04:00
joshaber
b8ff4666c8
Remove stale includes
2017-04-03 15:48:47 -04:00
joshaber
b0ef7ddf44
Use better iteration
2017-04-03 15:28:51 -04:00
joshaber
06643e525a
Const ref that message
2017-04-03 15:28:44 -04:00
joshaber
11f5c942ce
Conditionalize
2017-04-03 15:25:09 -04:00
joshaber
bcecba20e6
Fix indentation
2017-04-03 15:09:24 -04:00
joshaber
4ffaf2cd99
Remove old unnecssary change on app
2017-04-03 15:09:04 -04:00
joshaber
6e89cb9d7c
Move it into dialog
2017-04-03 15:05:24 -04:00
joshaber
4bbbcd093b
Handle the callback and cleanup properly
2017-04-03 14:01:48 -04:00
joshaber
1ed443ea29
Do the callback & release dance
2017-04-03 13:21:44 -04:00
Kevin Sawicki
f5a75c4e87
Merge pull request #9076 from electron/cleanup-cpp
...
Cleanup cpp codebase
2017-04-03 08:30:08 -07:00
Haojian Wu
34a91434aa
Remove extra spaces.
2017-04-01 22:01:29 +02:00
Haojian Wu
f09e3f3835
Remove extra blank.
2017-04-01 15:09:53 +02:00
joshaber
ee7389bb6d
Rename to make VS happy
2017-03-31 22:57:56 -04:00
joshaber
4f3d3557cc
Notify that the cert changed
2017-03-31 21:51:29 -04:00
joshaber
bde2a597f3
Decode all the intermediates
2017-03-31 21:27:49 -04:00
joshaber
69defc5166
Encode all the intermediates
2017-03-31 21:27:33 -04:00
joshaber
302ca8669d
Slightly better conversion
2017-03-31 15:44:47 -04:00
Kevin Sawicki
a724b6555f
Bump v1.6.5
2017-03-31 12:10:09 -07:00
Kevin Sawicki
08db63c3cc
Only define NSWindowTabbingModeDisallowed on pre-10.12
2017-03-31 11:28:55 -07:00
joshaber
141a5ad73f
Maybe this is a valid conversion?
2017-03-31 14:16:26 -04:00
Haojian Wu
8ae91682cb
Lines should be <= 80 characters.
2017-03-31 20:09:13 +02:00
joshaber
16cc79354c
Errrrybody's a scoped_refptr now
2017-03-31 13:53:42 -04:00
joshaber
deae70de4d
Dummy out the certificate FromV8 converter
2017-03-31 13:53:31 -04:00
Kevin Sawicki
d677a436ec
🎨
2017-03-31 10:42:43 -07:00
Thiago de Arruda
f0d447cd68
Pass uploadToServer to windows crash reporter
2017-03-31 13:46:30 -03:00
joshaber
653b2d15c3
Expose the certificate trust panel as part of app
2017-03-30 17:25:55 -04:00
joshaber
64369cd07f
Show a certificate trust panel
2017-03-30 17:25:44 -04:00
Haojian Wu
328cf4789b
Should override the virtual destructor.
2017-03-30 23:19:43 +02:00
Haojian Wu
e8abee9ca9
Replace C-style casts with static_cast.
2017-03-30 23:05:47 +02:00
Haojian Wu
ff745e1a82
Use prefix increment in for loops.
2017-03-30 22:56:21 +02:00
Haojian Wu
8d8c7ce6ad
Correct type cast.
2017-03-30 22:53:20 +02:00
Kevin Sawicki
42300ae58e
Make tabbing identifier var local
2017-03-30 13:47:11 -07:00
Kevin Sawicki
c8b992fa39
Remove 10.12 check handled by respondsToSelector
2017-03-30 13:46:34 -07:00
Haojian Wu
bb51401c4c
Use base::mac::NSToCast.
2017-03-30 22:33:09 +02:00
Haojian Wu
1b9780035c
Remove redundant calls to smart pointer's get method.
2017-03-30 22:22:40 +02:00
Haojian Wu
d425b63b0d
NULL => nullptr
2017-03-30 22:12:14 +02:00
Haojian Wu
00693ba075
Replace "size()" with "empty()".
2017-03-30 21:59:18 +02:00
Haojian Wu
6ef3be23fd
Avoid copy in for range loop.
2017-03-30 21:56:28 +02:00
Tony Ganch
bd935b213f
Fix compilation against macOS 10.10 SDK
2017-03-30 15:13:49 +02:00
Haojian Wu
5f724e57bc
Avoid unnecessary copy of parameters.
2017-03-29 22:06:07 +02:00
Haojian Wu
99293dd57f
Fix namespace comments.
2017-03-29 20:47:41 +02:00
Tony Ganch
a7565f0d57
Enable native tabs on macOS
2017-03-29 13:51:39 +02:00
Tony Ganch
9e02c60e22
Revert "Disable Show Tab Bar menu item on macOS Sierrra"
...
This reverts commit 24b9313958
2017-03-29 13:50:56 +02:00
Tony Ganch
ed76e03730
Revert "Add forward declaration of NSWindow.allowsAutomaticWindowTabbing"
...
This reverts commit 770a3509cf
2017-03-29 13:50:56 +02:00
Cheng Zhao
6db827cc9a
Use GetDesktopEnvironment to determien desktop env
...
Which can get a much more precise result for us.
2017-03-29 16:21:38 +09:00
Anatzum
f9dbdf4522
Updated MoveItemToTrash in platform_util_linux.cc
...
If ELECTRON_TRASH is null, first check the DESKTOP_SESSION variable and set trash accordingly. Additional desktop environments can be added easily this way with the fallback of ELECTRON_DEFAULT_TRASH.
2017-03-29 16:08:26 +09:00
Cheng Zhao
208182d8cf
Merge pull request #9039 from electron/extract-renderer-base-class
...
Create base class to share code between sandbox and non-sandbox
2017-03-29 15:20:46 +09:00
Cheng Zhao
9ef1f8cd5d
Merge pull request #9043 from electron/fix-uv-run-crash
...
Fix crash happened in UvRunOnce
2017-03-29 13:37:07 +09:00
Kevin Sawicki
4441d557a2
Merge pull request #9007 from electron/net_redirect_patch
...
net: allow controlling redirects
2017-03-28 09:31:05 -07:00
Kevin Sawicki
03b2167f6c
Merge pull request #9001 from electron/net_source_stream_error_patch
...
net: catch source stream creation failure for content encoding
2017-03-28 09:24:18 -07:00
deepak1556
3ae62615f4
net: allow controlling redirects
2017-03-28 18:46:21 +05:30
Ryohei Ikegami
37c4569982
Use GetBoolean directly
2017-03-28 20:00:33 +09:00
Cheng Zhao
2ef1b70897
Fix crash happened in UvRunOnce
2017-03-28 17:19:14 +09:00
Cheng Zhao
637bdc239b
Merge pull request #8923 from electron/geolocation_request_context_patch
...
browser: Create separate request context for geolocation service.
2017-03-27 22:45:46 -07:00
Thiago de Arruda
d1f08beddf
Make AtomSandboxedRendererClient a RendererClientBase subclass.
2017-03-27 18:49:55 -03:00
Thiago de Arruda
c3a8f665f2
Extract base class from AtomRendererClient
...
The new `RendererClientBase` class contains code that is not specific to node.js
integration with the renderer.
2017-03-27 18:49:55 -03:00
Kevin Sawicki
6a2cdcf32f
Merge pull request #8956 from electron/expose-crash-reporter-to-sandbox
...
Expose crash reporter to sandbox
2017-03-27 10:09:36 -07:00
Kevin Sawicki
b1275a8ef0
Merge pull request #8984 from hansenzhang/display-menuitem-label
...
Fix '&' not showing in MenuItem label
2017-03-27 09:47:50 -07:00
deepak1556
93b444eef9
net: catch source stream creation failure for content encoding
2017-03-23 23:36:05 +05:30
Ryohei Ikegami
6f9dbd4e04
Merge branch 'master' into native-window-open
2017-03-24 00:11:43 +09:00
Thiago de Arruda
bf756e3c00
Prevent browserify from leaking the require function
...
Define a "require" argument in the wrapper functions that runs browserify
bundles, which will prevent browserify from leaking the require function.
Note that this doesn't affect the isolated renderer script, only when `-r` flag
is passed to browserify command it will export a require function. It is still
added to isolated renderer script to prevent future mistakes(doesn't hurt
defining a "require" local).
2017-03-23 10:01:02 -03:00
Thiago de Arruda
e1aebef57c
Make sandbox APIs more compatible with normal renderers
...
- Expose remote shortcuts for the `fs`, `os` and `child_process` modules.
- Expose the `url` and `timers` modules(the browserify versions)
- Add `process.crash` and `process.platform`
2017-03-23 10:01:02 -03:00
Kevin Sawicki
46aed5ff6f
Bump v1.6.4
2017-03-22 09:16:08 -07:00
Cheng Zhao
e539129db2
Merge pull request #8852 from electron/web-worker-hook
...
Add Node.js integration to WebWorker
2017-03-22 09:01:42 -07:00
Hansen Zhang
426563a843
#8881 - Display '&' in MenuItem label
2017-03-22 11:52:25 -04:00
deepak1556
4ab2c92418
CommonWebContentsDelegate::DestroyWebContents => ResetManagedWebContents
2017-03-22 07:30:36 +05:30
Ryohei Ikegami
4d61d071b2
Reuse site instance only on window.open
2017-03-21 10:41:49 +09:00
Cheng Zhao
99d3fce3c7
node::Environment should be destroyed before AtomBindings
...
The shutdown code may still uses the APIs provieded by AtomBindings.
2017-03-20 13:01:28 -07:00
Cheng Zhao
0287f23e3b
Fix cpplint warning
2017-03-20 12:52:46 -07:00
Cheng Zhao
940d77b9a0
Fix typos and adjust sentences
2017-03-20 12:52:46 -07:00
Cheng Zhao
033aa16e04
test: Node integration in web workers
2017-03-20 12:52:46 -07:00
Cheng Zhao
a49af26e39
Add nodeIntegrationInWorker option
2017-03-20 12:52:46 -07:00
Cheng Zhao
e496e18f6e
Make Archive thread safe
2017-03-20 12:52:46 -07:00
Cheng Zhao
c068285ff8
AtomBindings should not use default uv loop
2017-03-20 12:52:46 -07:00
Cheng Zhao
9c9c8ec5f1
WebWorkerObserver should be destroyed on exit
2017-03-20 12:52:46 -07:00
Cheng Zhao
d2f185bea5
Create new uv loop in each worker
2017-03-20 12:52:46 -07:00
Cheng Zhao
69df934710
Converter for base::Callback is not thread safe
2017-03-20 12:52:45 -07:00
Cheng Zhao
b467c3939e
Add a new type of NodeBindings
2017-03-20 12:52:45 -07:00
Cheng Zhao
2cbdb6bac3
Wrap ContextCreated with context scope
2017-03-20 12:52:45 -07:00
Cheng Zhao
e017e157ba
Insert node integrations into WebWorker
2017-03-20 12:52:45 -07:00
Ryohei Ikegami
f3ce93f1bb
Fix C++ style
2017-03-19 18:24:05 +09:00
Ryohei Ikegami
2c7343293a
Allow window.open on native-window-open enabled
2017-03-19 17:47:26 +09:00
Ryohei Ikegami
a1f9a45276
Use native window.open implementation
2017-03-19 17:41:20 +09:00
Ryohei Ikegami
054ba7a964
Add AtomBrowserClient::IsRendererUsesNativeWindowOpen
2017-03-19 17:25:45 +09:00
Ryohei Ikegami
f7935b429a
Add WebContentsPreferences::IsNativeWindowOpenEnabled
2017-03-19 17:12:25 +09:00
deepak1556
72adbf7a2f
destroy guest webcontents before embedder
2017-03-19 10:25:13 +05:30
deepak1556
16f9754445
Create separate request context for geolocation service.
...
* Geolocation service cannot hold reference to browser context,
since it is destroyed at the end of everything and this will
confuse the shutdown path of browser context.
* Geolocation service run on its own thread.
2017-03-19 01:11:55 +05:30
Kevin Sawicki
f119bc0944
Remove unused args param
2017-03-17 10:35:54 -07:00
Kevin Sawicki
ab05346572
Add clipboard.readBuffer
2017-03-17 09:57:17 -07:00
Kevin Sawicki
6d45052eea
Merge pull request #8900 from electron/handle-buffer-instances-in-sandbox
...
Handle Buffer deserialization in sandboxed renderers
2017-03-16 10:12:09 -07:00
Thiago de Arruda
a6e4867111
Handle Buffer deserialization in sandboxed renderers
...
In sandboxed renderers we use browserify to provide a node-like environment. The
Buffer class used by browserify is actually just a wrapper around Uint8Array,
but to deserialize Buffer correctly we must expose the class as a hidden value
and use it in V8ValueConverter.
2017-03-16 13:20:09 -03:00
Kevin Sawicki
da0d0e7aac
Merge pull request #8910 from electron/touchbar-scrubber
...
Touchbar NSScrubber
2017-03-16 09:10:59 -07:00
Kevin Sawicki
e98ac94d51
🎨
2017-03-15 11:22:31 -07:00
Kevin Sawicki
f41db87e47
Use NSZeroRect for scrubber frame
2017-03-15 09:45:50 -07:00
Kevin Sawicki
466c39ed19
Use icon for consistency with other touch bar APIs
2017-03-15 09:33:11 -07:00
Kevin Sawicki
6175ee05e2
Remove unneeded long cast
2017-03-14 13:59:29 -07:00
Kevin Sawicki
8b7675baee
Add more forward declarations for scrubber APIs
2017-03-14 13:57:39 -07:00
Samuel Attard
a55cddaa53
Add more options
2017-03-14 18:57:57 +11:00
deepak1556
15e2b2335f
address review comments
2017-03-14 00:26:27 +05:30
deepak1556
d022d108a3
Dont intercept pdf request for subframes
...
Will not work without OOPIF support
2017-03-14 00:26:27 +05:30
deepak1556
4381e0895f
propagate zoom changes to pdf plugin
2017-03-14 00:26:27 +05:30
deepak1556
eda413861a
update spec
2017-03-14 00:26:27 +05:30
deepak1556
b28e686228
code cleanup
2017-03-14 00:26:27 +05:30
deepak1556
5a8e522526
StreamManager class is no longer required.
...
Stream lifetime is managed by webui
2017-03-14 00:26:27 +05:30
deepak1556
c982af991d
request for pdf resource from the webui
2017-03-14 00:26:27 +05:30
Cheng Zhao
422b7acece
Do not store resource_path as FilePath
...
On Windows the path value returned by PathWithoutParams also uses "/" as
separator, so there is no need to use the FilePath class.
2017-03-14 00:26:27 +05:30
Cheng Zhao
cca1db47ee
Print error when path is not found
2017-03-14 00:26:27 +05:30
deepak1556
528853efbf
handle reload api call from pdf ui
2017-03-14 00:26:27 +05:30
deepak1556
010193ef44
remove unused header
2017-03-14 00:26:27 +05:30
deepak1556
6987e3ecd0
check if target stream is intercepted for correct request
2017-03-14 00:26:27 +05:30
deepak1556
b9710532e1
update api changes
2017-03-14 00:26:27 +05:30
deepak1556
a4400dc549
add basic spec
2017-03-14 00:26:27 +05:30
deepak1556
3aba23b471
view_id=>stream_id and add some code comments.
2017-03-14 00:26:27 +05:30
deepak1556
e90fd1444f
move constants to atom_constants.h
2017-03-14 00:26:27 +05:30
deepak1556
671a8a2cd6
address review comments
2017-03-14 00:26:27 +05:30
deepak1556
6cb626db88
use existing ipc message generator
2017-03-14 00:26:27 +05:30
deepak1556
cc09b9ac7d
BINDINGS_POLICY_WEB_UI is not required
2017-03-14 00:26:27 +05:30
Paul Betts
846d516584
Get us compiling on macOS
2017-03-14 00:26:27 +05:30
Paul Betts
8580a34f9f
Get us compiling on Win32
2017-03-14 00:26:27 +05:30
deepak1556
e767c59da2
enable pdf plugin by default
2017-03-14 00:26:27 +05:30
deepak1556
c15f6af892
fix crash when pdf viewer is reloaded
2017-03-14 00:25:59 +05:30
deepak1556
ddc2e0df71
code cleanup
2017-03-14 00:25:59 +05:30
deepak1556
de7dcdedba
setup strings for ui
2017-03-14 00:25:59 +05:30
deepak1556
0c7bb72891
listen to ipc messages from plugin to perform SaveAs op
2017-03-14 00:25:59 +05:30
deepak1556
fd8c450ef3
move pdfviewer ui data source to separate file
2017-03-14 00:25:59 +05:30
deepak1556
945e26750e
manage the lifetime of streams created
2017-03-14 00:25:59 +05:30
deepak1556
0ab37da785
replace redundant mimetype helper with net utility
2017-03-14 00:25:59 +05:30
deepak1556
578b717b5f
fix cpplint error
2017-03-14 00:25:59 +05:30
deepak1556
c4dd2f4f56
add pdf webui as submodule
2017-03-14 00:25:59 +05:30
deepak1556
3c90fabab7
update pdf ui to work with webui
2017-03-14 00:25:59 +05:30
deepak1556
41c1623824
handle more messages from webui
2017-03-14 00:25:59 +05:30
deepak1556
a2db14476a
create webui message handler
2017-03-14 00:25:59 +05:30
deepak1556
8a2b9c893e
initialize webui with message handlers
2017-03-14 00:25:59 +05:30
deepak1556
be480fb634
import pdf ui
2017-03-14 00:25:59 +05:30
deepak1556
fdd574cea5
browser: implement pdf renderer as webui
2017-03-14 00:25:59 +05:30
Kevin Sawicki
268dd1a6c2
Remove unneeded include
2017-03-13 11:15:36 -07:00
Kevin Sawicki
e52ece1a1e
Implement NSScrubberDataSource in AtomTouchBar
2017-03-13 11:06:41 -07:00
Kevin Sawicki
4f31a5c452
Fix duplicate protocol method declaration
2017-03-13 10:39:42 -07:00
Kevin Sawicki
d7f458d232
Add protocol methods
2017-03-13 10:31:51 -07:00
Kevin Sawicki
2fe21ecdd0
🎨
2017-03-13 10:28:30 -07:00
Kevin Sawicki
37c9d76cd5
Take const references
2017-03-13 10:25:30 -07:00
Kevin Sawicki
634bd7b17f
Add NSScrubber forward declarations
2017-03-13 10:07:48 -07:00
Samuel Attard
a85ae27d68
Fix linting
2017-03-13 11:00:10 +11:00
Samuel Attard
25a231fc50
Initial NSScrubber implementation
2017-03-13 10:51:12 +11:00
deepak1556
4281c73cf2
renderer: reset plugin cache when render frame is created
2017-03-12 00:53:39 +05:30
Kevin Sawicki
280337bf46
Merge pull request #8887 from electron/touchbar-segmneted-control
...
Touchbar segmented control
2017-03-10 14:43:12 -08:00
Kevin Sawicki
5b1d5b39a2
Set automatic via else block
2017-03-10 10:11:56 -08:00
Kevin Sawicki
3349e32196
Verify selectedIndex to prevent NSRangeException
2017-03-10 10:09:18 -08:00
Kevin Sawicki
458e4be77c
Add forward declaration for 10.12 API
2017-03-10 09:53:47 -08:00
Samuel Attard
1c027c526b
Add segmented control implementation
2017-03-10 17:40:39 +11:00
Thiago de Arruda
cd05834d96
Refactor sandboxed renderer init scripts
...
This change gives sandboxed renderer scripts a similar structure to what already
exists in the lib/{browser,renderer,common} directories.
It also allows sandboxed renderer initialization to share more code with
non-sandboxed renderers (ipcRenderer is now imported directly from
lib/renderer/api/ipc-renderer).
2017-03-09 20:39:14 -03:00
Thiago de Arruda
d78f3cae7b
Expose builtin v8 modules to AtomSandboxedRendererClient
...
- Adapt node.cc code that implements `process.binding` to create a similar
object in AtomSandboxedRendererClient.
- Replace the ipc binding object passed to `lib/sandboxed_renderer/init.js` by
the new binding object.
- Refactor the initialization script to use this new object to fetch the ipc
binding and store as a hidden value using the `v8_util` module.
This change also required applying a patch to node.js, so the submodule commit
was updated.
2017-03-09 20:39:14 -03:00
Kevin Sawicki
e79a22da5d
Merge pull request #8883 from electron/pass-crash-reporter-upload-parameter
...
Pass `uploadToServer` parameter to linux crash reporter
2017-03-09 12:59:35 -08:00
Thiago de Arruda
e03e37e984
Pass uploadToServer parameter to linux crash reporter
2017-03-09 17:23:52 -03:00
Kevin Sawicki
14e8e463b3
Merge pull request #8864 from electron/zoom_controller_webview_patch
...
browser: track origin zoom with HostZoomMap
2017-03-09 11:27:34 -08:00
Kevin Sawicki
7e039d92ec
Support adding representation from data URL
2017-03-09 09:56:42 -08:00
Kevin Sawicki
d67863aa9f
Add addRepresentation buffer support
2017-03-09 09:56:42 -08:00
John Kleinschmidt
d5a658bbe4
Fixed pass by reference and added spec
2017-03-08 22:06:26 -05:00
John Kleinschmidt
1c2a78a896
Add WebRTCIPPolicy setting to webContents and webview
...
Resolves #8777
Code to set and get the policy come from the muon framework code:
https://github.com/brave/muon/blob/master/atom/browser/api/atom_api_web_
contents.cc#L1324...L1343
2017-03-08 10:15:48 -05:00
deepak1556
b5cfa2e92d
track host zoom levels with HostZoomMap
2017-03-08 19:03:43 +05:30
Kevin Sawicki
8852b128ec
Add GetScaleFactorFromOptions helper
2017-03-07 12:27:55 -08:00
Kevin Sawicki
82a81bb26e
Support scale factor to buffer APIs
2017-03-07 12:27:55 -08:00
Kevin Sawicki
e4ead6d018
Remove hasRepresentation and just use 1x png result
2017-03-07 12:27:55 -08:00
Kevin Sawicki
c11cdf321b
Support toPNG on image without 1x representation
2017-03-07 12:27:55 -08:00
Kevin Sawicki
86babdd412
Remove unused include
2017-03-07 12:27:55 -08:00
Kevin Sawicki
0bbbeb307e
Support toDataURL without 1x representation
2017-03-07 12:27:55 -08:00
Kevin Sawicki
e0260d6f53
Bump v1.6.3
2017-03-07 09:49:39 -08:00
Kevin Sawicki
f549bda9fc
Merge pull request #8799 from nitsakh/baseURLForDataURL
...
Support base URL option to loadURL for data URLs
2017-03-06 10:25:53 -08:00
Kevin Sawicki
886b47e713
Merge pull request #8724 from electron/defer_load_url
...
webContents: defer url load when there is a pending navigation entry
2017-03-06 10:18:36 -08:00
Kevin Sawicki
479af3c9e2
Merge pull request #8678 from liusy182/download-item
...
only emit `download-item done` event once
2017-03-06 10:11:22 -08:00
Cheng Zhao
aaa8e81cd4
Merge pull request #8811 from electron/clean-node-on-exit
...
Clean up node Environment on exit
2017-03-06 20:36:59 +09:00
deepak1556
e936143da2
listen for browser initiated pending nav entries too
2017-03-06 00:21:52 +05:30
deepak1556
dead1ae1ba
webContents: defer url load when there is a pending navigation entry
2017-03-06 00:10:46 +05:30
Kevin Sawicki
4d6c779839
identList -> identifiers
2017-03-03 15:28:32 -08:00
Kevin Sawicki
b879872317
Always set properties in update calls
2017-03-03 15:24:32 -08:00
Kevin Sawicki
2680ee9f8f
Add support for setting TouchBarLabel text color
2017-03-03 15:14:51 -08:00
Kevin Sawicki
9f323104e7
Remove unused include
2017-03-03 14:11:09 -08:00
Kevin Sawicki
edebb32014
Drop nullable for consistency
2017-03-03 14:07:59 -08:00
Kevin Sawicki
ca2898a60e
Check that window responds to touchBar selector for pre-10.12.1 compat
2017-03-03 14:00:39 -08:00
Kevin Sawicki
002369576f
Add initial touch bar docs
2017-03-03 14:00:39 -08:00
Kevin Sawicki
ce12dcd3b4
Add live popover icon property
2017-03-03 14:00:39 -08:00
Kevin Sawicki
a34f9d3583
Support icon property to match MenuItem
2017-03-03 14:00:39 -08:00
Kevin Sawicki
506b42b563
🎨
2017-03-03 14:00:39 -08:00
Kevin Sawicki
ecc0478e3c
Match Popover casing in macOS APIs
2017-03-03 14:00:39 -08:00
Kevin Sawicki
d1edd80ef8
Use NSTouchBar itemForIdentifier to lookup existing item
2017-03-03 14:00:39 -08:00
Kevin Sawicki
93bbe8e70b
Use device NS colors consistently
2017-03-03 14:00:39 -08:00
Kevin Sawicki
70d61869a5
Use array to create empty NSMutableArray
2017-03-03 14:00:39 -08:00
Kevin Sawicki
5fe3ac60fa
Check that atom_touch_bar_ is set
2017-03-03 14:00:39 -08:00
Kevin Sawicki
708ed9d1cd
Store ordered settings in AtomTouchBar
2017-03-03 14:00:39 -08:00
Kevin Sawicki
5f9e9d4b36
Add move live updating properties
2017-03-03 14:00:39 -08:00
Kevin Sawicki
61aa9bbff4
Add support for spacer items
2017-03-03 14:00:39 -08:00
Kevin Sawicki
f153d08297
Support setting the initial/available colors
2017-03-03 14:00:39 -08:00
Kevin Sawicki
51f1c5a557
Use SetTouchBar withe empty vector instead of DestroyTouchBar
2017-03-03 14:00:39 -08:00
Kevin Sawicki
347d472841
Remove unused clear method
2017-03-03 14:00:39 -08:00
Kevin Sawicki
b959f782f6
Rename instance variable maps
2017-03-03 14:00:39 -08:00
Kevin Sawicki
ec500b2852
Use scoped_nsobject to match Chrome implementation
2017-03-03 14:00:38 -08:00
Kevin Sawicki
812beb240b
Remove unneeded includes
2017-03-03 14:00:38 -08:00
Kevin Sawicki
823b3baed0
Use vector of dictionaries instead of mate::Arguments
2017-03-03 14:00:38 -08:00
Kevin Sawicki
98f5858b11
Initial support for dynamic properties
2017-03-03 14:00:38 -08:00
Kevin Sawicki
cbb6f8c33e
Store event listeners in each TouchBar class
2017-03-03 14:00:38 -08:00
Kevin Sawicki
1972e2eff9
Update renamed variable
2017-03-03 14:00:38 -08:00
Kevin Sawicki
28f2a4951b
touch_bar_helper_ -> atom_touch_bar_
2017-03-03 14:00:38 -08:00
Kevin Sawicki
b39b49a15a
Rename to touch_bar_helper_ to differentiate from touchBar property
2017-03-03 14:00:38 -08:00
Kevin Sawicki
14ef5c5957
Reset helper when makeTouchBar is called
2017-03-03 14:00:38 -08:00
Kevin Sawicki
ca29ec0101
Use reference
2017-03-03 14:00:38 -08:00
Kevin Sawicki
f297ba987e
touchBarFromMutatableArray -> touchBarFromItemIdentifiers
2017-03-03 14:00:38 -08:00
Kevin Sawicki
b30f7c3c94
Use std::string ctor
2017-03-03 14:00:38 -08:00
Kevin Sawicki
8500538793
Use base::SysUTF8ToNSString helper
2017-03-03 14:00:38 -08:00
Kevin Sawicki
cf7cd1f32b
hasTBDict -> hasItemWithID
2017-03-03 14:00:38 -08:00
Kevin Sawicki
48515d9ecc
Ignore objective-c header lint
2017-03-03 14:00:38 -08:00
Kevin Sawicki
b632cdd37d
Extract helper class to encapsulate touch bar items
2017-03-03 14:00:38 -08:00
Kevin Sawicki
1b5149ae7a
Few memory and scope tweaks
2017-03-03 14:00:38 -08:00
Kevin Sawicki
b16d649819
Use skia color helpers
2017-03-03 14:00:38 -08:00
Kevin Sawicki
69638a399c
Make touchBar readwrite/nullable
2017-03-03 14:00:38 -08:00
Kevin Sawicki
52905ae9b3
Get compiling against 10.10 SDK
2017-03-03 14:00:38 -08:00
Kevin Sawicki
2a00bb30c5
Use new NativeWindowObserver helper
2017-03-03 14:00:38 -08:00
Samuel Attard
ba3fbc9d1b
Fix Group items
2017-03-03 14:00:38 -08:00
Samuel Attard
28d5c8bbde
Add updateConfig ability to other items
2017-03-03 14:00:38 -08:00
Samuel Attard
dd09c91cf2
initial work on updating touch bar item config without rerender
2017-03-03 14:00:38 -08:00
Samuel Attard
d1b3ba39bd
Fix cpp linting
2017-03-03 14:00:38 -08:00
Samuel Attard
257b32b84b
Remove unused ident
2017-03-03 14:00:38 -08:00
Samuel Attard
43cc5079d8
Implement group item
2017-03-03 14:00:38 -08:00
Samuel Attard
269d899a99
Implement popOver item type (woo hoo it worked)
2017-03-03 14:00:38 -08:00
Samuel Attard
c92c4138a8
Add Slider item type and add options to the button type
2017-03-03 14:00:38 -08:00
Samuel Attard
18c7c3ece8
Make label and colorpicker types work
2017-03-03 14:00:38 -08:00
Samuel Attard
7857c83ea1
Make dynamic buttons work along with click events
2017-03-03 14:00:38 -08:00
Samuel Attard
703b5738c8
Initial TouchBar Magic
...
* Make the AtomNSWindow also a NSTouchbarDelegate
* Implement basic makeTouchBar and makeItemForIdentifier methods
* Initial sending of touch / update events through IPC to BrowserWindowObjects
TODO:
* JS API
* JS Object Converters
* Generalize methods so that popovers can work
2017-03-03 14:00:38 -08:00
Nitish Sakhawalkar
bcda67b8eb
No more extra whitespace.
2017-03-02 10:50:48 -08:00
Kevin Sawicki
7fb77ee1cb
Set isolated world security origin
2017-03-02 08:49:18 -08:00
Cheng Zhao
cf198904a4
Fix cpplint warnings
2017-03-02 17:26:15 +09:00
Cheng Zhao
1709e74958
Fix crash when the main frame is replaced
2017-03-02 17:19:00 +09:00
Cheng Zhao
24574f7299
Avoid touch an Environemnt after it gets destroyed
2017-03-02 17:19:00 +09:00
Cheng Zhao
29278e500b
Destroy node environment when a JS context in renderer is destroyed
2017-03-02 17:19:00 +09:00
Cheng Zhao
d379b05890
async handles should be closed on exit
2017-03-02 17:19:00 +09:00
Cheng Zhao
a0605275b9
Clean up node environment on exit in main process
2017-03-02 17:19:00 +09:00
Nitish Sakhawalkar
c06c4c0ccb
Reverting formatting changes made by clang format.
2017-03-01 14:04:41 -08:00
Kevin Sawicki
d009b3267a
Bump v1.6.2
2017-03-01 09:11:05 -08:00
Nitish Sakhawalkar
879082b1a6
Issue #8735:Support base URL option to loadURL for data URLs
2017-02-28 16:49:03 -08:00
Kevin Sawicki
be16e75be2
Support explicit cancelId on macOS
2017-02-24 09:05:55 -08:00
Kevin Sawicki
ef085a1f15
Remove unneeded AddRef/Release calls handled by base::Bind
2017-02-24 08:15:02 -08:00
Kevin Sawicki
6837ec8576
Check render frame host before getting context
2017-02-24 07:49:26 -08:00
Kevin Sawicki
a62c2f9e2e
Remove unused include
2017-02-24 07:37:28 -08:00
Kevin Sawicki
29f92bfb53
Extend RefCounted and add private destructor
2017-02-24 07:37:28 -08:00
Kevin Sawicki
a33ffd621f
Use callback dialog methods in RunFileChooser
2017-02-24 07:37:28 -08:00
liusi
ff513f2a84
remove the call to download_item_->Remove() on cancel
2017-02-24 14:08:21 +08:00
Kevin Sawicki
211bedf910
Invoke close callback after itemSelected runs
2017-02-22 11:47:58 -08:00
Kevin Sawicki
a8d1a7aed4
Make variables private instead of protected
2017-02-22 10:30:28 -08:00
Kevin Sawicki
2006e22aa4
🎨
2017-02-22 10:30:28 -08:00
Kevin Sawicki
ce5ac1b056
Implement ClosePopupAt on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
91d1af053f
Implement Menu.closePopup on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
6a023dc4fe
Add Menu.closePopup API on macOS
2017-02-22 10:30:28 -08:00
Kevin Sawicki
66b6b4f1cb
Map async option to MenuRunner::ASYNC flag
2017-02-22 10:30:28 -08:00
Kevin Sawicki
4430927f98
Add async option to menu.popup
2017-02-22 10:30:28 -08:00
Kevin Sawicki
b091d104f5
Add async menu.popup on Windows/Linux
2017-02-22 10:30:28 -08:00
Kevin Sawicki
636ef0fd29
Add async menu.popup on macOS
2017-02-22 10:30:28 -08:00
Kevin Sawicki
92092bed41
Bump v1.6.1
2017-02-21 08:49:50 -08:00
gellert
a1ede4a4b0
fixes os version check of vibrancy
2017-02-18 20:25:03 +01:00
deepak1556
0c022fdc36
set zoom changes for in page navigaitons
2017-02-18 01:34:32 +05:30
deepak1556
203a920c64
fix signature of zoom getter apis
2017-02-18 01:34:32 +05:30
deepak1556
5687f8b3b7
Destroy icon manager after file thread is destroyed
2017-02-17 14:16:18 +05:30
Yury Solovyov
977abc6458
Update icon loading API implementation
2017-02-16 23:16:34 +03:00
Kevin Sawicki
70849de8c4
Mark constructor as explicit
2017-02-15 08:28:55 -08:00
Kevin Sawicki
52801c4a41
Use internal IsVisible method
2017-02-15 08:28:55 -08:00
Kevin Sawicki
db79f4f450
Implement Activate instead of CanFocus
2017-02-15 08:28:55 -08:00
Kevin Sawicki
bda8af8dd3
Just use visible state in CanFocus delegate
2017-02-15 08:28:55 -08:00
Kevin Sawicki
be79417a03
Include CanFocus on Windows and map to state
2017-02-15 08:28:55 -08:00
Cheng Zhao
c127ce3e46
Merge pull request #8679 from electron/disable-active-tracker
...
Disable the ActiveVerifier
2017-02-15 11:04:36 +09:00
Kevin Sawicki
36e6501c44
Rename variable for compiler error
2017-02-14 12:30:23 -08:00
Kevin Sawicki
9be42db8d5
Merge pull request #8628 from Spacetech/master
...
Implement invalidate for non-offscreen mode
2017-02-14 11:41:16 -08:00
Kevin Sawicki
643cb5d6de
Remove unused variable
2017-02-14 11:13:23 -08:00
Kevin Sawicki
5cb6648686
Use underscore variable name for consistency
2017-02-14 11:12:30 -08:00
Kevin Sawicki
82f452568c
🎨 Minor formatting tweaks
2017-02-14 11:09:15 -08:00
Kevin Sawicki
3b7207da9f
Support removing extra parameters
2017-02-14 09:37:09 -08:00
Kevin Sawicki
9a434af03e
Clear crash keys in InitBreakpad
2017-02-14 09:37:09 -08:00
Kevin Sawicki
ba975d552a
Add setExtraParameter support on macOS
2017-02-14 09:37:09 -08:00
Kevin Sawicki
3e18d8baf5
Remove _ prefix on binding methods
2017-02-14 09:37:09 -08:00
Kevin Sawicki
c54ae66fb9
Call OnWindowScrollTouchEnd instead of Edge
2017-02-14 09:13:07 -08:00
Cheng Zhao
bad6954911
Disable the ActiveVerifier
2017-02-14 17:23:20 +09:00
liusi
d56c1909df
only emit download-item done event once.
2017-02-14 14:39:33 +08:00
Gary Wilber
f19924bcb0
Add Invalidate method to NativeWindow and add Mac implementation
2017-02-13 19:41:24 -08:00
Kevin Sawicki
d7ab142e10
Call content::WebContentsObserver first
2017-02-13 09:09:42 -08:00
Kevin Sawicki
a746651d1c
Use dialog setter for consistency with other properties
2017-02-13 08:23:53 -08:00
Samuel Attard
e45d8079b8
Add support for a noResolveAliases property
2017-02-13 08:23:53 -08:00
deepak1556
7a0aff2bae
code cleanup
2017-02-12 01:48:24 +05:30
deepak1556
cbeaa6be87
simply handling temporary zoom levels of webview
2017-02-12 00:49:17 +05:30
deepak1556
e3fe3cc490
map webframe zoom api to use HostZoomMap
2017-02-12 00:49:17 +05:30
deepak1556
63c0e4cbb1
Add ZoomController to manager zoom changes for webcontents
2017-02-12 00:49:17 +05:30
deepak1556
07794a58aa
use zoom factor webpreference option when required.
...
* When setzoomlevel is not called for the host.
* When there is no zoom preference for the host.
2017-02-12 00:49:17 +05:30
deepak1556
b27c94368d
webContents: set zoom levels with HostZoomMap
2017-02-12 00:49:17 +05:30
Kevin Sawicki
f7f4de36af
Merge remote-tracking branch 'origin/master' into macos-open-save-panel
2017-02-09 11:25:05 -08:00
Kevin Sawicki
867bb5a94e
Add DialogSettings helper struct
2017-02-09 10:13:11 -08:00
Kevin Sawicki
7994acf0ea
Use CHROMEGTK_CALLBACK_0 and ignore gpointer data
2017-02-09 09:49:09 -08:00
Birunthan Mohanathas
c8c11e68c6
Add support for checkbox with dialog.showMessageBox
...
This adds the `checkboxLabel` and `checkboxChecked` options to display a
checkbox in the message box. Fixes #6048 .
2017-02-09 09:03:54 -08:00
Tan Wang Leng
347dc835b5
Fix code formatting
2017-02-09 21:51:11 +08:00
Tan Wang Leng
a4a71a1dc9
Change qualifier of ShowSaveDialog() parameter
...
The normal convention in the codebase is to not use references
or 'const' for primitives like 'bool' and 'int'.
2017-02-09 21:50:55 +08:00
Tan Wang Leng
b0487b7d84
Fix wrong signature for gtk's ShowSaveDialog()
2017-02-09 20:10:57 +08:00
Tan Wang Leng
1bf8270c0d
🏁 Fix dialog method calls for Windows
2017-02-09 20:10:57 +08:00
Tan Wang Leng
36209ddd90
🍎 Add additional options for Mac's open dialog
...
Support an additional attributes available in macOS's NSOpenPanel:
message.
2017-02-09 20:10:57 +08:00
Tan Wang Leng
1d612a12a1
🍎 Add additional options for Mac's save dialog
...
Support additional attributes available in macOS's NSSavePanel: message,
nameFieldLabel and showsTagField
2017-02-09 20:10:57 +08:00
Kevin Sawicki
1e581d6814
Use unique_ptr for passing VerifyRequestParams
2017-02-08 11:59:43 -08:00
Kevin Sawicki
70178adb6e
Use object for verification request
2017-02-08 11:59:43 -08:00
Kevin Sawicki
37db804099
Use NetLogWithSource since BoundNetLog no longer exists
2017-02-08 11:59:43 -08:00
Greg Nolle
e29b64a18a
modify CertVerifier Class
...
* respond to multiple similar verification requests.
* accept net error result as callback response.
2017-02-08 11:59:43 -08:00
Gary Wilber
11e1f6b56c
Fix lint errors
2017-02-08 00:05:16 -08:00
Gary Wilber
ed44b32ff5
Convert indentation to spaces
2017-02-07 23:08:03 -08:00
Gary Wilber
148898fb75
Implement invalidate for non-offscreen mode
2017-02-07 23:03:42 -08:00
Cheng Zhao
5cd18fe32a
Merge pull request #8619 from electron/mac-os-version-checks
...
Use IsAtLeastOS10_* version checks
2017-02-08 13:58:26 +09:00
Cheng Zhao
0643d98d99
Merge pull request #8616 from electron/renew-symbol-trick
...
Simplify the trick used for referencing symbols
2017-02-08 07:56:28 +09:00
Yury Solovyov
bcf0964c61
Fix more review
2017-02-07 09:55:18 -08:00
Yury Solovyov
29452364f3
Use isolate() method to get isolate
2017-02-07 09:54:22 -08:00
Yury Solovyov
c2bf5bb986
Put locker and handle scope to the top of the function. Remove unneeded header
2017-02-07 09:53:34 -08:00
Yury Solovyov
5794138ed4
Normalize path
2017-02-07 09:53:34 -08:00
Yury
1b4ee6e0d8
Image from icon node-style callback ( #2 )
...
* Try implementing node-style callbacks
* Add locker and handle scope
2017-02-07 09:53:34 -08:00
deepak1556
2e85ff1f57
Fix code style
2017-02-07 09:53:34 -08:00
Yury Solovyov
3d47c9b71d
Fix lint
2017-02-07 09:53:34 -08:00
Yury Solovyov
05cb26a174
Use object for options
2017-02-07 09:53:34 -08:00
Yury Solovyov
bec671bac8
Make size optional
2017-02-07 09:52:11 -08:00
Robo
b25b141642
create iconmanager as singleton class and cleanup code ( #1 )
...
* create iconmanager as singleton class and cleanup code
2017-02-07 09:52:11 -08:00
Yury Solovyov
1b3cd87fc9
Add icon manager to browser process
2017-02-07 09:50:17 -08:00
Yury Solovyov
602aba8723
Include proper header
2017-02-07 09:48:12 -08:00
Yury Solovyov
eb889b9b86
Get it compiling, linking till fails though
2017-02-07 09:48:12 -08:00
Yury Solovyov
d118fed5c2
Try my own class
2017-02-07 09:48:12 -08:00
Yury Solovyov
8e4ed664d9
Add icon fetching sources
2017-02-07 09:48:12 -08:00
Yury Solovyov
1d24a3a175
Add callback converters
2017-02-07 09:48:12 -08:00
Yury Solovyov
be5b907179
WIP
2017-02-07 09:48:12 -08:00
Kevin Sawicki
0f98c9d3fb
Use at least OS version checks
2017-02-07 09:32:40 -08:00
Kevin Sawicki
4de637779b
Make int converter helper an instance method
2017-02-07 09:13:42 -08:00
Tan Wang Leng
7ec88d16a6
Use base::StringToInt() instead of std::stringstream
2017-02-07 09:05:55 -08:00
Tan Wang Leng
42f65c52fb
🐛 Fix webpreferences not accepting numeric options
...
The webpreferences attribute values are parsed as strings instead
of numbers. Therefore, a conversion is required.
2017-02-07 09:05:55 -08:00
Cheng Zhao
84c180ac69
Simplify the trick used for referencing symbols
2017-02-07 17:09:43 +09:00
renaesop
26135b412b
Merge remote-tracking branch 'upstream/master'
...
# Conflicts:
# atom/browser/api/atom_api_web_contents.cc
# chromium_src/chrome/browser/printing/print_job_worker.cc
# chromium_src/chrome/browser/printing/print_job_worker.h
# chromium_src/chrome/browser/printing/print_view_manager_base.cc
# chromium_src/chrome/browser/printing/print_view_manager_base.h
# chromium_src/chrome/browser/printing/printer_query.cc
# chromium_src/chrome/common/print_messages.cc
# chromium_src/chrome/renderer/printing/print_web_view_helper.cc
2017-02-07 09:30:36 +08:00
Kevin Sawicki
852519a826
Bump v1.6.0
2017-02-06 16:42:00 -08:00
Cheng Zhao
85e84cc0da
Fix missing of symbols when linking win32 build
2017-02-07 09:14:50 +09:00
Cheng Zhao
ec650b3773
Update to Chrome 56.0.2924.87
2017-02-06 10:34:30 -08:00
Cheng Zhao
86215d4300
Allow filter to use any scheme
2017-02-06 10:34:30 -08:00
Cheng Zhao
e0c021bfef
Fix compilation waring on Mac
2017-02-06 10:34:29 -08:00
Cheng Zhao
1ed8743da8
Update Windows printing code to latest
2017-02-06 10:34:29 -08:00
Cheng Zhao
75627ba6ad
Fix sync printing not working
2017-02-06 10:34:29 -08:00
Cheng Zhao
82d796ded4
Fix missing of symbols issue on Release build
2017-02-06 10:34:29 -08:00
Cheng Zhao
a98e69a80d
Work around the compilation error of v8_value_converter.cc
...
We should apply this patch in future:
0232f57400
2017-02-06 10:34:29 -08:00
Cheng Zhao
be29ea4dad
libgtk2ui => libgtkui
2017-02-06 10:34:29 -08:00
Cheng Zhao
820c0827c0
Fix cpplint warnings
2017-02-06 10:34:29 -08:00
Cheng Zhao
55d4d44f02
Fix Debug building on Windows
2017-02-06 10:34:29 -08:00
Cheng Zhao
6165d36351
There is a new INSERTED type of ChangeCause
...
For the purpose of compatibility, we treat it as "explicit".
2017-02-06 10:34:29 -08:00
Cheng Zhao
09fcb7fb27
Fix crash when using webview
2017-02-06 10:34:29 -08:00
Cheng Zhao
6763977316
Update URLPattern to its latest version
2017-02-06 10:34:29 -08:00
Cheng Zhao
81784827ff
PrintWebViewHelper is attached to RenderFrame
2017-02-06 10:34:29 -08:00
Cheng Zhao
234e1bb811
base::Bind now prevents the case with no arguments
2017-02-06 10:34:29 -08:00
Cheng Zhao
411696ca19
Clear is replaced with ClearEntriesAddedWithin
2017-02-06 10:34:29 -08:00
Cheng Zhao
8a6fd685e3
Interface of crashpad_client.StartHandler has changed
...
Refs:
7b9234c4b2
2017-02-06 10:34:29 -08:00
Cheng Zhao
4a14b17255
WindowOpenDisposition has become enum class
2017-02-06 10:34:29 -08:00
Cheng Zhao
6d5339b74e
insertText is deprecated
2017-02-06 10:34:29 -08:00
Cheng Zhao
5e43ea227e
purgedSize and purgeableSize are removed by Chrome
2017-02-06 10:34:29 -08:00
Cheng Zhao
6d323dd6fe
web/WebInputEvent.h is moved to platform/WebInputEvent.h
2017-02-06 10:34:29 -08:00
Cheng Zhao
53bf82dd7c
Update URLRequestFetchJob
2017-02-06 10:34:29 -08:00
Cheng Zhao
e7f3a25626
Update OffScreenRenderWidgetHostView
2017-02-06 10:34:29 -08:00
Cheng Zhao
2e0780308c
allowDisplayingInsecureContent is removed by Chrome
2017-02-06 10:34:29 -08:00
