mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
6620 commits 9 branches 362 tags 278 MiB
Commit graph

5187 commits

Author SHA1 Message Date
Aurimas Vinckevicius
7b621420f7 Fix possible infinite loops 2015-02-17 22:12:52 -06:00
Dan Stillman
aaeb2cec9d Show address bar icon on all web pages in Firefox 
The icon now will save using a translator if possible and otherwise fall back
to creating a web page item. This also removes the "Create Web Page Item from
Current Page" button.

Let's see how this feels. (Pushing it to the beta so more people can try it.) I
think we ultimately should do this, but my main concern with this
implementation is that it's just too distracting, since the icon disappears and
reappears on every page. A persistent, possibly monochrome icon that was just
sometimes disabled (as is the case for the Firefox bookmark toolbar icon) might
be better.

Regardless of the approach, there are some follow-up tweaks that should be made:

- The same thing in the connectors
- Context-menu options
- Different icons and descriptions for different file types (PDF, image)?
- Adjust guidance text? Have separate guidance panels for web vs. translation?
 2015-02-17 03:43:45 -05:00
Dan Stillman
47a062c9a8 Fix potential infinite loop dragging large HTML notes 2015-02-17 01:39:40 -05:00
Dan Stillman
42c55ee5f3 Fix file sync error with filenames containing slashes 
These shouldn't exist, but something either didn't used to or still isn't
protecting against them, so strip them in getFile().
 2015-02-16 17:26:51 -05:00
Simon Kornblith
64f7710877 Merge pull request #409 from aurimasv/cookies 
Manage cookies received from other hosts.
 2015-02-14 13:24:58 -05:00
Dan Stillman
161733b207 Merge pull request #630 from aurimasv/attach-url 
Don't try to parse path if it looks like a web URL
 2015-02-11 01:22:39 -05:00
Dan Stillman
884132ac8b Merge pull request #629 from aurimasv/varDump-exception 
Handle XPCOM Exceptions in varDump
 2015-02-11 01:18:48 -05:00
Dan Stillman
62aa5acc0d Fix NO_INTERFACE console error after itembox/tagsbox edit in Fx36 
In Fx36+, QIing the scrollbox to nsIScrollBoxObject throws NO_INTERFACE,
presumably because https://bugzilla.mozilla.org/show_bug.cgi?id=364612
was implemented in some other ticket.
 2015-02-10 22:45:51 -05:00
Aurimas Vinckevicius
cae9a89b9d Fix syntax error in varDump 2015-02-10 21:26:50 -06:00
Simon Kornblith
aeada8032c Fix XML-based import, export, and search translators on Firefox 36 2015-02-10 22:01:52 -05:00
Aurimas Vinckevicius
264e1f8835 Don't try to parse path if it looks like a web URL 
Also, cleaner parsing messages
 2015-02-10 20:50:08 -06:00
Aurimas Vinckevicius
8e25a4bdf3 Handle XPCOM Exceptions in varDump 2015-02-10 20:49:16 -06:00
Dan Stillman
1afa1ffea6 Update submodules, repotime, and versions 2015-02-10 00:13:42 -05:00
Dan Stillman
a98e6ab4fb Merge pull request #627 from aurimasv/connector-double-proxy 
Don't proxify proxied hosts
 2015-02-09 04:57:47 -05:00
Dan Stillman
f7a2ef6698 Merge pull request #614 from aurimasv/file-attachments 
Allow file paths to be specified in attachment.url
 2015-02-09 04:49:42 -05:00
Aurimas Vinckevicius
82998e986e Don't proxify proxied hosts 2015-02-09 00:57:56 -06:00
Dan Stillman
f04ae4ce47 Update "Swap First/Last Names" case, in preparation for #605 2015-02-07 05:31:51 -05:00
Aurimas Vinckevicius
ed2b6ccec3 Don't promote attachment.url to attachment.path 
...but allow demoting from path to url if necessary.
 2015-02-04 03:20:11 -06:00
Aurimas Vinckevicius
cf9ec26eb4 Disallow attachment.path in web/search translators 2015-02-04 02:54:13 -06:00
Dan Stillman
424af025b3 Merge pull request #608 from COV-Steve/4.0 
Fix for OpenURL 0.1 resolver detection
 2015-02-03 22:28:17 -05:00
Aurimas Vinckevicius
27502a60b2 Disable expand/collapse shortcuts in coll. tree when in-line editing 2015-02-03 14:43:52 -06:00
Dan Stillman
6f811cbbd0 Update submodules 2015-02-03 00:51:46 -05:00
Simon Kornblith
449086672c Fix #619, Retrieve metadata via Google Scholar broken in Firefox 31-34 2015-02-02 23:28:59 -05:00
Dan Stillman
496d4c5e77 Properly show saveURI errors in Zotero.Attachments.importFromURL() 2015-02-01 21:09:13 -05:00
Dan Stillman
f5c173b1e5 Fix saving files from translators 
(More breakage from 5f8b56ef8)
 2015-02-01 21:07:24 -05:00
Dan Stillman
fb8149e6db Clarify icon comment 2015-01-31 16:01:53 -05:00
Dan Stillman
bcacb79489 Fix remote file saving 
5f8b56ef8 was so many different kinds of broken
 2015-01-31 15:23:58 -05:00
Frank Bennett
5cfe4db098 Use nav-bar as target ID for Zotero nav bar icon 
The statusBarIcon pref is retained to maintain state across
starts.
 2015-01-30 22:42:34 +09:00
Dan Stillman
9232dd5247 Merge locales from Transifex, though it's all Greek to me 2015-01-30 04:45:41 -05:00
Dan Stillman
7aff743da6 Remove trailing space 2015-01-30 04:45:40 -05:00
Dan Stillman
f04b641f3c Merge pull request #617 from aurimasv/content-handler 
Content handlers
 2015-01-30 04:09:03 -05:00
Dan Stillman
d8f2d4b268 Merge branch 'fx36-saveURI' into 4.0 2015-01-30 03:56:58 -05:00
mizu
5f8b56ef86 Fix saveURI() in Firefox 36+ 2015-01-30 03:55:35 -05:00
Dan Stillman
783ba4a0b7 Merge pull request #618 from aurimasv/prefs-unicode 
Retrieve unmangled unicode strings from preferences
 2015-01-30 03:42:34 -05:00
Dan Stillman
f2ffc30728 Merge pull request #607 from rmzelle/rename-style-panes 
Localize Style Editor and Preview and other improvements
 2015-01-28 22:57:10 -05:00
rmzelle
0be9e73b51 Further improvements to Style Editor and Preview 
* Clean up code (remove some pre-CSL 0.8.1 code, see also e32e6aa2f5 )
* Complete localization
* Save vertical space. Editor: remove "pre-wrap" wrapping, use smaller headers, add grippy to collapse CSL code. Preview: remove groupbox
 2015-01-28 22:20:20 -05:00
rmzelle
eec1ba4c73 Put JavaScript code from Style Editor and Preview into separate files 2015-01-28 22:20:20 -05:00
rmzelle
6fd3b298de Rename Reference Test and Preview panes 
* Also start localization of Zotero Style Preview
 2015-01-28 22:07:39 -05:00
Dan Stillman
55d84bcbf3 Merge pull request #609 from aurimasv/retrieve-meta-max-pages 
Allow MAX_PAGES (for retrieving metadata) to be user-adjustable
 2015-01-21 01:01:47 -05:00
Aurimas Vinckevicius
e8e0f5e831 Bump MAX_PAGES to 15 
Re https://forums.zotero.org/discussion/45641/error-getting-metadata/#Item_10
 2015-01-20 23:58:41 -06:00
Aurimas Vinckevicius
11017b650c Retrieve unmangled unicode strings from preferences 2015-01-20 23:28:22 -06:00
Aurimas Vinckevicius
f7893ef400 Don't require Zotero restart to change RIS/BibTeX handling preference 2015-01-20 22:46:30 -06:00
Aurimas Vinckevicius
3f3666c972 Add Zotero.Prefs.registerObserver 
* Easier monitoring of preference changes
* Takes a preference name and a handler function that will be passed the new value of the preference
* Unregister observer via Zotero.Prefs.unregisterObserver with the same parameters
 2015-01-20 22:45:28 -06:00
Aurimas Vinckevicius
4ecdd55717 Continue with default if declining Zotero to handle RIS/BibTex/etc. 2015-01-20 21:54:05 -06:00
Aurimas Vinckevicius
8be83cedec Allow file paths to be specified in attachment.url 
In translators, it may not always be clear whether the given URI is a URL or a local file path.
Regression from 849803473a (that piece of code was introduced by me)
Re https://forums.zotero.org/discussion/45710/ris-import-from-endnote-mac-yosemite-to-zotero-standalone/
 2015-01-19 15:13:49 -06:00
Aurimas Vinckevicius
869fdf61ae Make sure that there's always a title for a given URL 
E.g. https://read.amazon.co.uk/?asin=XXXXXXXXX was resulting in a blank title
 2015-01-18 10:41:17 -06:00
Aurimas Vinckevicius
79a79bb47a Fix typo in attachLink.xul 2015-01-18 10:40:12 -06:00
Simon Kornblith
06615f738f Tweak method for parsing XML without a window to handle UTF-8 properly 
Fixes issue reported at https://forums.zotero.org/discussion/45556
 2015-01-14 01:56:09 -05:00
Steve Jamieson
0d2a205110 Fix for OpenURL 0.1 resolver detection 
The discoverResolvers function was looking for the wrong XML tag name representing OpenURL version 0.1 in the response from the WorldCat Registry
 2015-01-13 14:20:57 -06:00
Simon Kornblith
7d19e17bb9 Ensure that we pass WebPageDump an XPCNativeWrapper 
Fixes some CSS issues in snapshots
 2015-01-13 01:51:03 -05:00
Dan Stillman
f1a3cb3577 Update versions, submodules, and repotime 2015-01-12 21:54:56 -07:00
Simon Kornblith
90625e8a05 Fix translators callback from translators on Fx 35 (affects COinS) 2015-01-12 19:33:12 -05:00
Simon Kornblith
5c76347674 Improve translation on Nightly (with e10s disabled) 
I haven't fully tested, but this fixes Google Scholar
 2015-01-12 11:27:39 -05:00
Simon Kornblith
e082a4fc28 Fix PDF metadata retrieval on Fx 35 2015-01-12 02:44:09 -05:00
Simon Kornblith
da7ee2ba26 Tweak sandboxing for Firefox 35 
Now we have to wrap cross-origin objects with a wrapper on the sandbox
side. Also, Function.prototype.apply.apply...
 2015-01-12 01:41:01 -05:00
Simon Kornblith
fa75beeefd Fix bookmarklet under Chrome 
checkIsOnline isn't called before the connector gets used except in IE.

The mixed content blocker in modern IE combined with the https
redirect breaks communication with ZSA on all pages anyway, so we may
just want to give up on making the bookmarklet talk to ZSA.
 2015-01-08 01:46:20 -05:00
Simon Kornblith
541ebd1f22 Merge pull request #596 from aurimasv/conn-reg 
Fix regression from 0cd183613f
 2015-01-07 20:10:34 -05:00
Philipp Zumstein
d5b4c31575 Right pane (item-pane) can be collapsed 
This belongs to issue #509 and was asked several times in the forum.

 * Add attribute `collapse="after"` to the splitter and add a grippy element.
 * To remember its state after restart I copied `zotero-persist="state"`.
 * Handle zotero-items-splitter the same as zotero-collections-splitter in zotero-platform/mac/overlay.css
 * Change min-width to 250px for #zotero-item-pane in zotero/overlay.css.
 * Update the function `updateToolbarPosition` in zotero/zoteroPane.js:
   * The width of the items-toolbar is corrected if the left pane is collapsed (and the icons are grouped on the left margin together).
   * If the right pane is collapsed, then the items-toolbar is made flexible while making the item-toolbar unflexible. As a result the search box and locate icon are flushed right to the other icons.
 2015-01-07 10:41:18 +01:00
Aurimas Vinckevicius
e530c3a001 Remove unnecessary newline in TranslatorTester log output 2014-12-29 05:28:44 -06:00
Aurimas Vinckevicius
08c3effe6e Allow meta redirects when running tests and account for new document 2014-12-29 05:28:01 -06:00
Dan Stillman
3792e94c10 Merge non-English strings from Transifex 2014-12-27 14:14:31 -05:00
Aurimas Vinckevicius
8d7db5a63e Remove safeDebug 2014-12-27 01:43:33 -06:00
Aurimas Vinckevicius
20a50d1aaa Refactor Zotero.Utilities.varDump. Add handling for Error and XPCOM objects 2014-12-27 01:43:33 -06:00
Dan Stillman
0b3b296e28 Keep active item pane editing field open when window loses focus 
Closes #153
 2014-12-26 14:16:41 -05:00
Dan Stillman
d82f8e91dc Update locales from Transifex 2014-12-19 14:23:46 -05:00
Dan Stillman
3024162bfe Merge pull request #510 from mtd91429/linkURI 
Link URI re: issue #486
 2014-12-16 12:01:22 -05:00
MTD
849803473a Address silent failure of unrecognized URIs in Attach Link to URI 
Generated files for a more robust attached-link-dialog and localized strings
* AttachLink.js
* AttachLink.xul

zotero/xpcom/attachments.js
* created function cleanAttachmentURI
* in function linkFromURL, removed the regex constraints and the comment list of valid protocols
* removed outdated function declaration from beginning of script
* Improved automatic title generation mechanism
 2014-12-16 11:20:55 -05:00
Dan Stillman
950302d8ee Merge pull request #507 from f-mb/quick-search-for-civil-law-case 
Allow QuickSearch to search for civil law cases
 2014-12-15 19:43:58 -05:00
Aurimas Vinckevicius
bb53e7beb2 Fix regression from 0cd183613f 
Was breaking connectors
 2014-12-11 15:00:50 -06:00
Aurimas Vinckevicius
2f79cb221f Fix duplicate matching when ISBN is non-sensical 
Re https://forums.zotero.org/discussion/43046/items-mistakenly-identified-as-duplicates/
 2014-12-10 15:59:26 -06:00
Dan Stillman
ee389f106e Merge pull request #593 from rmzelle/update-csl-preview 
Update cslpreview.xul
 2014-12-10 14:30:02 -05:00
rmzelle
e2f1f354f3 Update Zotero Preview pane 
* Remove splitter
* Add explanation of how Zotero Preview pane works
* Limit filtering to citation format
  Also add support for “citation-format” attribute of CSL 1.0
* Remove redundant warning
  (already happens on this.refresh)
* Use "items" instead of "references"
* Clean up HTML a little
* Fix some JSHint warnings
 2014-12-10 07:42:05 -05:00
Dan Stillman
09638cbd2c Merge pull request #585 from aurimasv/nfc 
Normalize all user and translator input to NFC
 2014-12-09 19:21:04 -05:00
Dan Stillman
20dd8c89d8 Remove "CSL" column in Cite -> Styles preferences 2014-12-09 19:19:40 -05:00
Dan Stillman
3a058c68ed Use config URL for all repo requests, and move config to separate file 2014-12-09 18:53:53 -05:00
Dan Stillman
c28ef6f2d6 Use HTTPS for proxy auth check 2014-12-09 18:36:06 -05:00
Dan Stillman
2a27cd506d Remove DB_REBUILD config option 
I don't think anyone has used this in many years.
 2014-12-09 18:35:03 -05:00
Dan Stillman
4f7e5446e8 Remove unused block 2014-12-09 17:49:15 -05:00
Aurimas Vinckevicius
9ee67ca291 Disable ZSA ping from bookmarklet in non-IE browsers 
This means that bookmarklet will only save to server.
 2014-12-09 13:12:05 -06:00
Dan Stillman
e3d7101923 Update version 2014-12-02 00:26:41 -05:00
Dan Stillman
d894fdb1d4 Fix citation list generation via right-click and quick copy 
Broken by 523724185

Not sure if cslEngine.opt.class is a safe way to get the class. @fbennett?
 2014-12-01 17:12:07 -05:00
Dan Stillman
0fd0da2903 Fix "getItemAtRow(...) is undefined" error for some item modifications 
Since 67c63a29
 2014-12-01 16:51:11 -05:00
Simon Kornblith
01c80610b4 Maybe fix for Firefox 31 
Still need to test more comprehensively
 2014-12-01 03:17:03 -05:00
Simon Kornblith
0cd183613f Fix for Firefox 34 
Passing sandboxes between translators became difficult. This change
loads all translators in the same sandbox, using the same ugly hack as
in the connectors to get us close enough to being able to load
translators into separate scopes for things to work.

Conflicts:
	chrome/content/zotero/xpcom/translation/translate.js
 2014-12-01 02:48:53 -05:00
Dan Stillman
524a71cfe8 Fix sync error with missing base directory set 
Fixes #376
 2014-12-01 02:32:44 -05:00
Dan Stillman
43c03c6aca Update another version 2014-12-01 02:18:04 -05:00
Dan Stillman
d7d542a79c Update version, submodules, and repotime 2014-12-01 02:17:09 -05:00
Dan Stillman
67c63a2968 Remove child items from view when removing parent 
https://forums.zotero.org/discussion/42218/
 2014-11-28 16:37:40 -05:00
Dan Stillman
55068a0059 Use the whole firstCreator string in sortCreatorAsString mode 
And in the default mode, use the whole string up through 'and' or 'et al.'
before falling back to full creator sorting, which could speed things up
slightly.
 2014-11-26 20:12:07 -05:00
Aurimas Vinckevicius
bd87bd3f56 Normalize all user and translator input to NFC 
This includes storing values into DB and performing searches. Note that export/display of existing data is not normalized. We can try to capture all access points to the database and normalize on output, but that seems like a lot of unnecessary normalization happening all the time. Would probably be best to just normalize existing data.
 2014-11-23 13:55:01 -06:00
Aurimas Vinckevicius
ff28b24389 Don't use let inside translate.js. Breaks connectors 2014-11-20 08:42:27 -06:00
Aurimas Vinckevicius
325f0618d6 Resolve protocol-relative URLs outside of document context 
by defaulting to HTTP
 2014-11-20 06:55:22 -06:00
Dan Stillman
6e43942385 Fix UI issues with Cyrillic mime types, hopefully 2014-11-17 23:20:11 -05:00
Dan Stillman
828bcd9a11 Merge pull request #577 from fbennett/csl-once-on-drag 
Instantate CSL processor once on drag, changing output mode on the fly
 2014-11-13 17:15:55 -05:00
Dan Stillman
7ac1ba5242 Fix file sync error with Hola extension enabled 
With Hola enabled, uploads were failing with NS_BASE_STREAM CLOSED -- it
seems to do something that causes the stream to be read more than once.
Adding REOPEN_ON_REWIND fixes this.
 2014-11-12 20:09:39 -05:00
Simon Kornblith
9017aa69db Fix typo 2014-11-12 14:45:15 -05:00
Dan Stillman
cefab23888 Add tooltip to Zotero toolbar button 2014-11-10 18:06:17 -05:00
Frank Bennett
523724185c Instantate CSL processor once on drag, changing output mode on the fly 2014-11-09 06:46:37 +09:00
Dan Stillman
5bfc1e4199 Fix comment - force-delete on Win/Linux is Shift, not Ctrl 2014-10-28 13:45:55 -04:00
Aurimas Vinckevicius
3b4c502ca9 [RecognizePDF] Attempt to search by ISBN even if we found a DOI 
(but only if DOI search failed)
 2014-10-24 14:18:26 -05:00
Aurimas Vinckevicius
15722e5022 Allow calling Zotero.Translate.*.translate without setting translator first. 
This simply means that detection code will be run first.
Attempting this with Export translators will fail, because trying to detect a translator does not make sense in this case.
 2014-10-24 14:18:26 -05:00
Aurimas Vinckevicius
151e95075a Allow dependent styles to override parent style locale 
Re https://forums.zotero.org/discussion/36595/defaultlocale-of-dependent-doesnt-override-that-of-its-parent/
 2014-10-23 13:00:36 -05:00
Dan Stillman
a737f2c2aa Treat 260-character paths as too long on Windows 
I understood the path limit to mean >260, but a user is seeing the error
with a 260-character path [1], so let's try this.

[1] https://forums.zotero.org/discussion/41410
 2014-10-21 13:03:52 -04:00
Dan Stillman
226928f1e9 Debugging for "types[i] is undefined" error 2014-10-21 00:45:48 -04:00
Dan Stillman
6c814e2fa2 Update version 2014-10-14 22:55:07 -04:00
Simon Kornblith
4984e87ade Reinstate __exposedProps__ 
This is ignored in Firefox 33, but seemingly still necessary in
Firefox 32
 2014-10-14 22:44:04 -04:00
Dan Stillman
12619273b5 Update submodules and repotime 2014-10-14 03:26:15 -04:00
Dan Stillman
aab3276276 Use old-style searchbox in Yosemite pre-Fx34 
Yosemite introduces a new search textbox shape, but Firefox still uses
the old focus ring shape until 34, so we fake the old searchbox shape
for earlier versions.
 2014-10-14 02:22:44 -04:00
Simon Kornblith
1f41253256 Update citeproc-js to 1.0.543 2014-10-13 23:25:24 -04:00
Dan Stillman
94060e113f Remove debugging for download overlay issue 2014-10-10 19:23:52 -04:00
Dan Stillman
39b01b80e0 Additional debugging for download overlay issue 2014-10-10 19:18:09 -04:00
Simon Kornblith
d3a69be997 Fix translation under Firefox 33 
Our strategy: put arguments into a property of the function, and then
get them out unwrapped. This avoids security checks on arguments passed
to the function.
 2014-10-10 18:31:10 -04:00
Dan Stillman
fc0f541ad8 Additional debugging for saving from download overlay 2014-10-10 18:03:13 -04:00
Dan Stillman
8359db1426 Better debugging for saving from download overlay 2014-10-10 17:36:49 -04:00
Dan Stillman
9c9b8b835d Fix crash when dragging items to collections from advanced search window 
(Dragging to the items list is still disabled.)
 2014-10-10 16:01:09 -04:00
Dan Stillman
e34c0db060 Make 'https' the default in WebDAV prefs drop-down 2014-10-08 13:49:41 -04:00
Dan Stillman
eba296a45f Closes #554, Sync settings pane should point to new TOS 2014-10-08 13:11:30 -04:00
Dan Stillman
497939bb28 Fix "Open Account Settings" button in quota dialog in Standalone 
(Untested, but this should work.)
 2014-10-08 13:04:56 -04:00
Dan Stillman
71bd1a7f99 Fix state check errors (middle-pane restart messages) during syncing 
The state check errors were caused by 4812ab6f, which was a fix for
"Q.async(...)(...) is undefined" errors caused by ad8b81f4c, which was a
fix for "too much recursion" errors related to Task.spawn() on Windows
with JIT enabled.
 2014-10-05 12:03:50 -04:00
Dan Stillman
72bb8acfd1 Fix previous commit 2014-10-03 16:06:01 -04:00
Dan Stillman
0f2e24dc5c Log state check errors (and other logError calls) to debug output 2014-10-03 16:05:14 -04:00
Dan Stillman
cb707a55c8 Fix breakage from 10ba5e31d 2014-09-20 16:34:36 -04:00
Dan Stillman
b0550273ae Update another version 2014-09-19 20:43:50 -04:00
Dan Stillman
f09871a1ee Convert additional for..in loops to for loops in getDisplayTitle() 2014-09-19 20:39:23 -04:00
Dan Stillman
10ba5e31d6 Fix error from letter items with more than 10 recipients 
https://forums.zotero.org/discussion/40218/
 2014-09-19 20:37:59 -04:00
Dan Stillman
ce6cba7974 Don't log stack trace for getString() failure unless unexpected 2014-09-19 15:52:53 -04:00
Dan Stillman
fd31e41e2f Add localization todos 2014-09-18 17:41:46 -04:00
Dan Stillman
57ec10dfd4 Remove unnecessary var 2014-09-18 17:35:25 -04:00
Dan Stillman
48955c8983 Check ext length explicitly in createShortened when checking path length 2014-09-18 17:34:10 -04:00
Dan Stillman
2a986c8635 Don't match extension in createShortened() for dot-files (.hidden) 2014-09-18 17:23:57 -04:00
Dan Stillman
5a8de7054c Ignore case when extracting extension in Zotero.File.createShortened() 2014-09-18 16:54:05 -04:00
Dan Stillman
f5b5617885 Improve long-filename handling during syncing 
This will hopefully fix some remaining issues with long filenames during
syncing, particularly on Linux with encrypted filenames (which have a
filename length of 143).

(This may have reintroduced some edge case bugs, so it needs some
testing.)
 2014-09-18 16:23:49 -04:00
Dan Stillman
4464e8ed9e Additional debugging for formatStringFromName error 2014-09-16 15:46:13 -04:00
Dan Stillman
61d7bd852b Debugging for strange Zotero.getString() error 2014-09-11 21:07:19 -04:00
Simon Kornblith
55f86f4295 Fix error handling for saveItems 2014-09-05 00:28:34 -04:00
Dan Stillman
9cd7423dd7 Change cert error message URL to https:// 2014-09-02 23:28:20 -04:00
Simon Kornblith
431185cc3a Merge pull request #531 from aurimasv/high-contrast 
Use Mozilla's colors for itembox and tagbox background
 2014-09-01 23:30:35 -04:00
Simon Kornblith
57da88ac3d Fix == use 2014-09-01 23:19:12 -04:00
Simon Kornblith
9146fb03d9 Merge pull request #536 from adam3smith/coinsfix 
test for presence of author's firstName before using it
 2014-09-01 23:18:39 -04:00
adam3smith
17c0f44e66 fix indenting 2014-09-01 19:25:10 -05:00
Simon Kornblith
9c3ec6f0be Fix DataCite under Fx 32 2014-09-01 20:00:31 -04:00
Simon Kornblith
79ed7e503e Fix MODS under Fx 32 2014-09-01 19:29:45 -04:00
Simon Kornblith
a09ff9c9ec Don't unwrap objects passed to chrome 
Unwrapping objects also waives the Xray wrappers for contained objects,
which we need.
 2014-09-01 18:42:24 -04:00
adam3smith
f973897d76 test for presence of author's firstName before using it 2014-09-01 14:31:51 -05:00
Simon Kornblith
5857368131 Update citeproc-js to 1.0.539 2014-09-01 15:04:52 -04:00
Dan Stillman
14a5643f38 Update submodules, repotime, versions 2014-09-01 14:56:01 -04:00
Simon Kornblith
ee35f7df41 Small fix to copyObject 2014-09-01 12:26:36 -04:00
Aurimas Vinckevicius
dc5ccffe43 Use Mozilla's colors for itembox and tagbox background 
This way, the colors play nicely with Windows themes (e.g. high contrast)
Re https://forums.zotero.org/discussion/38870/make-zotero-fully-recognize-windowsff-high-contrast-themes/ and https://twitter.com/stuffilike2know/status/504167872567189504
 2014-08-26 03:11:24 -05:00
Aurimas Vinckevicius
0998b15fac Improved cookie handling when translating from connectors 
* Accept detailed cookie information (including host, path, secureOnly, and hostOnly) from connectors so we can send correct cookies when fetching pages from different hosts. This way we also don't have to worry about exposing cookies to different hosts.
* Don't drop cookies that we receive from other hosts. Some pages (e.g. PDF URLs) result in redirects to other hosts (and even domains) that then set cookies, which are required to retrieve the PDF. (e.g. Cell Press stores PDFs on ScienceDirect, but their PDF links initially point to cell.com).
* Send detailed cookies where possible. Currently that's only for Chrome/Opera and Firefox in Connector mode. Does not seem to be possible in Safari.
 2014-07-28 15:39:07 -05:00
Simon Kornblith
9219100901 Another Fx 32 translation fix 2014-07-23 18:05:56 -04:00
Aurimas Vinckevicius
638d29972c Don't ignore initial punctuation when sorting 
Also, change sorting sensitivity to "base"
Closes #514
 2014-07-23 00:18:48 -05:00
Dan Stillman
15108eea3f Fix intermittent source file deletion when dragging files in on Windows 
(at least, if this is caused by what I think it was caused by)

https://forums.zotero.org/discussion/38486/
 2014-07-20 15:56:55 -04:00
Dan Stillman
3b5bd45433 Further Windows drag-and-drop comment rewriting 2014-07-20 13:16:56 -04:00
Dan Stillman
717a440156 Clarify comment for Windows drag-and-drop mess 2014-07-20 02:50:00 -04:00
Dan Stillman
b8f69d6281 Fix Quick Copy drag to Chrome textareas on Windows 
Possibly to other places as well (but not Notepad, which doesn't work
from Firefox or Chrome either)

Unfortunately this requires going back to 'copy' cursor feedback when
dragging, even when Shift is used. We can only choose one on Windows (as
far as I can tell), and we were previously using the unadorned 'move'.
 2014-07-20 02:16:25 -04:00
Dan Stillman
7d74344b7d Restore highlighting of collection row during drag on Windows 2014-07-20 02:16:20 -04:00
Dan Stillman
813f55d024 Natural sorting of numbers ("1" < "2" < "10") 
This needs testing to see if it has any other unwanted effects.

Closes Trac ticket 1031
 2014-07-08 09:47:03 -04:00
Simon Kornblith
87a0df43d8 Fix some more Fx 32 issues 
Ref https://forums.zotero.org/discussion/37885/
 2014-07-06 14:07:00 -04:00
Simon Kornblith
d9720f18a9 Update to citeproc-js 1.0.536 2014-07-06 08:50:13 -04:00
Dan Stillman
532ebc5239 Fix for startup error w/weird locale language tags ("de-CH@currency=EUR") 
https://forums.zotero.org/discussion/37901

And just return a noop sorter on failure instead of breaking
 2014-06-27 09:36:11 -04:00
Dan Stillman
4a677240d3 Don't use Intl until Fx30, since it's missing in Iceweasel 29 
And nsICollation isn't broken on OS X until 30
 2014-06-27 01:12:25 -04:00
Dan Stillman
d66a6f6680 Ignore punctuation when sorting 
This sorts "St. A" before "St B". I don't know if we want this.
 2014-06-25 12:24:31 -04:00
Dan Stillman
979e62714c Fix startup errors in some non-English locales in Fx30 on OS X 
nsICollation broke for some locales. (Testing requires changing the
language setting in Language & Region and then restarting the computer.
The change seems to not fully go into effect until then, even though the
UI changes.) This is fixed in Nightly, but we can work around it by
using the new Intl.Collator.
 2014-06-25 12:22:04 -04:00
Florian Martin-Bariteau
dbe7640f18 Allow QuickSearch to search for civil law cases 2014-06-24 22:55:56 -04:00
Dan Stillman
be49010783 Use 11 instead of 6 on invalid note font size 
Also don't validate font size until after pref field is blurred, to allow
numbers to be typed in properly
 2014-06-23 23:36:36 -04:00
Simon Kornblith
bcc7a4ae86 Missing word in comment from 8cb081a4e1 2014-06-23 22:56:08 -04:00
Simon Kornblith
8cb081a4e1 Disable argument unwrapping on Fx < 32 
This apparently breaks on Fx 24
 2014-06-23 22:55:02 -04:00
Simon Kornblith
dd5160cc73 Partially revert 76e8ea835f 
Apparently this doesn't work on Firefox 24. Sigh.
 2014-06-23 22:29:32 -04:00
Dan Stillman
f45b219792 Fix inline collection editing when clicking to another collection 
https://forums.zotero.org/discussion/37739
 2014-06-21 13:37:55 -04:00
Simon Kornblith
41e50ef669 Fix check from fc91deb69e 2014-06-21 13:27:49 -04:00
Simon Kornblith
fc91deb69e Fix more Firefox 32 issues 2014-06-21 13:25:33 -04:00
Simon Kornblith
76e8ea835f Slightly cleaner fix for #504 2014-06-21 13:16:39 -04:00
Simon Kornblith
a71f3bbdd8 Fix #504 
Determine whether to copy objects by their constructor names, since the
prototypes do not necessarily match
 2014-06-21 12:51:41 -04:00
Dan Stillman
4812ab6f93 Fixes (cosmetic) "Q.async(...)(...) is undefined" sync error 
Yield immediately so that a generator is always passed to Q.async()
 2014-06-20 03:47:04 -04:00
Dan Stillman
09e53d85d5 Revert "Revert "Use Q instead of Task.spawn to run processUpdatedXML()"" 
This reverts commit 4334260865.
 2014-06-20 03:47:01 -04:00
Dan Stillman
4334260865 Revert "Use Q instead of Task.spawn to run processUpdatedXML()" 
Fixes "Q.async(...)(...) is undefined" sync error

This reverts commit ad8b81f4c7 (which
tried to fix Fx32+ compatibility).
 2014-06-20 03:17:03 -04:00
Simon Kornblith
3a8c77e983 Fix search translation bug from 7950d3a7e2 2014-06-19 21:31:17 -04:00
Simon Kornblith
37f4e61ef2 Remove debug line 2014-06-19 20:11:46 -04:00
Simon Kornblith
7950d3a7e2 Attempt to fix #502, translation broken on Firefox 32 2014-06-19 20:07:31 -04:00
Simon Kornblith
f6dfeee210 Remove more uses of charsetDTD 2014-06-19 19:03:58 -04:00
Simon Kornblith
014c7b5b46 Fix tab mode in Aurora 
Ref https://forums.zotero.org/discussion/37608/
 2014-06-19 19:02:52 -04:00
Dan Stillman
75bdf08131 Fix event handling (e.g., Undo) in notes in Fx32 
Addresses #503
 2014-06-19 17:54:21 -04:00
Dan Stillman
c32144ddfd Fixes #503, Notes broken on Firefox 32 
Unwrap the editor object if it's wrapped
 2014-06-19 17:47:56 -04:00
Simon Kornblith
954f8bd001 Fix #496, Remove uses of nsICharsetConverterManager 
We should confirm that the manually added charsets still work on
Firefox 32 once we #502
 2014-06-19 17:31:27 -04:00
Simon Kornblith
e576416831 Remove old isFxN constants 2014-06-19 16:36:37 -04:00
Dan Stillman
e76cc07371 Merge locales from Transifex 2014-06-19 02:05:29 -04:00
Dan Stillman
b441e2cf9e Update submodules and repotime 2014-06-18 21:12:25 -04:00
Dan Stillman
ad8b81f4c7 Use Q instead of Task.spawn to run processUpdatedXML() 
With Task.spawn, regular expressions in Zotero.DB were causing "too much
recursion" errors on Windows with JIT enabled.

This requires a change to Q to allow async() to take a generator instead
of a generator-maker (which is the reason it was using Task.spawn to
begin with).
 2014-06-18 05:03:06 -04:00
Dan Stillman
fad6174e39 Fix download retrying 
Follow-up from 238a972a
 2014-06-10 03:50:41 -04:00
Dan Stillman
238a972ace Retry failed ZFS uploads and downloads automatically 
S3 upload timeouts were retried already with an exponential backoff, but
this adds retrying for other kinds of upload failures as well as failed
downloads.  If 5 consecutive failures occur a file sync error is
thrown.

Failed file sync requests to the Zotero API are not currently retried,
but S3 accounts for the majority.

The download portion of this still needs further testing.
 2014-06-09 06:47:07 -04:00
Dan Stillman
3d27c2c6a7 Merge locales from Transifex 2014-06-07 17:16:40 -04:00
Dan Stillman
1b6dc5d681 Restore minimize/maximize buttons in note windows on Windows 
From db6ec2b160
 2014-06-05 00:54:22 -04:00
Simon Kornblith
7b7b4e6e9e Merge pull request #495 from aurimasv/Fx-connector 
Fix race condition when starting in Connector mode
 2014-06-04 17:02:28 +02:00
Aurimas Vinckevicius
e4dd38fc84 Fix race condition when starting in Connector mode 
When starting in Connector mode (i.e. Standalone is open), Zotero first starts in Full mode, looks for Standalone, then "shuts down" and restarts in Connector mode. `Zotero.shutdown()` returns a promise which is then followed up by a `Zotero.init` call. Thus, when starting in Connector mode, Zotero initialization is asynchronous and makes it possible for `Zotero_Browser.init()` to be called before `Zotero.initialized` is true, which prevents `Zotero_Browser` from initializing. Additionally, even if `Zotero_Browser.init()` is called after Zotero is initialized in Connector mode, it is possible that `Zotero_Browser.init()` will be called _after_ the "load" event for browser.xul has already fired, so `chromeLoad` is never called. This patch ensures that both of these race conditions are taken into account.
 2014-06-04 03:16:29 -05:00
Aurimas Vinckevicius
59fe54da01 Release server port when shutting down (e.g. switching to Connector mode) 2014-06-04 03:14:01 -05:00
Dan Stillman
825cea47fb Fix "<" in translator error popup in French locale 
ba89dbf0ae (commitcomment-6535838)
 2014-06-03 17:27:24 -04:00
Dan Stillman
a59f3c50ed Hack to fix "Numéro" search condition in French locale 
https://forums.zotero.org/discussion/14942/
 2014-06-03 14:17:54 -04:00
Dan Stillman
cbdc75df9a Fix search condition handling when two conditions have same translation 
This prevented one "Numéro" from working in the French locale.

Also do a proper collation sort
 2014-06-03 14:17:54 -04:00
Aurimas Vinckevicius
85c5c614ea Fix CSL-JSON date import 2014-06-02 17:25:16 -05:00
Dan Stillman
ba89dbf0ae Link translator errors to troubleshooting page instead of known issues 2014-06-02 17:00:57 -04:00