Commit graph

25181 commits

Author SHA1 Message Date
StéphaneGL
20d811f55a 2018-12-03 18:40:17 +00:00
Joey Hess
b71d62b1aa
Merge branch 'master' of ssh://git-annex.branchable.com 2018-12-03 14:36:22 -04:00
Joey Hess
b8f9dea27d
add exportedtree to info
info: When used with an exporttree remote, includes an "exportedtree" info,
which is the tree last exported to the remote. During an export conflict,
multiple values will be listed.

This commit was sponsored by John Pellman on Patreon.
2018-12-03 14:36:00 -04:00
StéphaneGL
8f58627a48 Added a comment 2018-12-03 18:22:10 +00:00
StéphaneGL
e29f5c4b26 removed 2018-12-03 18:21:38 +00:00
StéphaneGL
d502eebd42 Added a comment 2018-12-03 18:20:29 +00:00
Joey Hess
3ad7b7927e
comment 2018-12-03 13:52:10 -04:00
Joey Hess
2544a24765
merge 2018-12-03 13:42:56 -04:00
Joey Hess
f386d8556d
remove spam
This particular page is attacting spam, I assume because of google rank.
I will have to lock comments to it I'm afraid.
2018-12-03 13:36:11 -04:00
Joey Hess
7a2d257159
comment 2018-12-03 13:35:23 -04:00
Joey Hess
41eb9d405e
followup 2018-12-03 13:31:20 -04:00
Joey Hess
bc4aa3f0e3
comment 2018-12-03 13:26:00 -04:00
Joey Hess
33085f4bfe
followup 2018-12-03 13:23:46 -04:00
Joey Hess
ae3beccd7c
comment 2018-12-03 13:07:40 -04:00
Joey Hess
3a9a6bc56b
response 2018-12-03 12:59:42 -04:00
spwhitton
89abe04eb8 Added a comment 2018-12-03 16:38:12 +00:00
Joey Hess
1948af854e
fixed 2018-12-03 12:33:54 -04:00
spwhitton
62f90eed06 post bug 2018-12-02 16:40:27 +00:00
Joey Hess
bb94cc9f8b
Merge branch 'master' of ssh://git-annex.branchable.com 2018-12-01 14:05:51 -04:00
Joey Hess
4cf9daf8b9
remove obsolete warning 2018-12-01 14:04:38 -04:00
anarcat
14213c0e42 Added a comment: how about for regular key/value storage? 2018-12-01 17:42:18 +00:00
Joey Hess
aea6f98727
update 2018-12-01 12:24:11 -04:00
Joey Hess
44c0a08429
add back deltas
also switch all urls to https
2018-12-01 12:13:46 -04:00
Joey Hess
12bec83f45
response 2018-12-01 12:05:20 -04:00
Joey Hess
5b5cff2572
Merge branch 'master' of ssh://git-annex.branchable.com 2018-12-01 11:46:22 -04:00
Joey Hess
01f93bb89f
2018 user survey is live 2018-12-01 11:46:01 -04:00
anarcat
e2fd1a513a feature request: LFS API support! 2018-11-30 21:30:22 +00:00
anarcat
f5ec2f074d note git-annex not supported by gitlab anymore 2018-11-30 21:27:03 +00:00
lukasstraub2@bbbb2ef261a0994edda5f5f55999dfac5998d4e5
1079b5b296 2018-11-30 20:51:48 +00:00
anarcat
84e0ea5ce3 Added a comment: status? 2018-11-30 19:46:20 +00:00
Ilya_Shlyakhter
0b924bc1ce added suggestion for an option to encrypt just the special remote credentials but not its contents 2018-11-29 03:49:39 +00:00
toh_corpora
d4a94a2330 Added a comment 2018-11-28 15:56:54 +00:00
Joey Hess
185287718d
followup 2018-11-28 11:40:13 -04:00
Joey Hess
77c13ca3e8
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-28 11:33:05 -04:00
Joey Hess
2b77dbf6a1
devblog 2018-11-28 11:32:38 -04:00
leni536
7285ffef62 2018-11-28 09:02:12 +00:00
toh_corpora
9443db1d64 2018-11-27 17:24:19 +00:00
Joey Hess
5a741c624e
Make bittorrent special remote work w/o btshowmetainfo installed when it was build with torrentparser. Thanks, Robert Schütz 2018-11-27 12:31:06 -04:00
toh_corpora
568b932c5d Added a comment 2018-11-27 14:10:53 +00:00
toh_corpora
6af0633519 Added a comment 2018-11-27 13:59:36 +00:00
anarcat
c08dfd9a21 Added a comment: restic 2018-11-27 07:13:29 +00:00
anarcat
2c1a0af295 Added a comment: progress? 2018-11-27 06:47:26 +00:00
andrew
bb9580ba66 Added a comment 2018-11-26 15:42:36 +00:00
robert.schuetz@7942237bf71a2ae4f5d3cb047d167612b8c9e311
15d3ecc9cf 2018-11-26 14:26:08 +00:00
techcustomersupport
3263fd42f2 Added a comment: adding a remote 2018-11-26 11:43:08 +00:00
techcustomersupport
95e1c722cb removed 2018-11-26 11:42:18 +00:00
techcustomersupport
7bb6320c60 Added a comment: adding a remote 2018-11-26 11:41:11 +00:00
TroisSinges
a79e467c10 Added a comment 2018-11-23 07:33:55 +00:00
TroisSinges
f8099b45af 2018-11-23 07:31:07 +00:00
jwiklund@3ecbaacd157648da5a91042b6aa44f36b107b5c7
debd21ccba 2018-11-22 16:43:49 +00:00
jwiklund@3ecbaacd157648da5a91042b6aa44f36b107b5c7
b23aba36f9 2018-11-22 16:42:37 +00:00
jwiklund@3ecbaacd157648da5a91042b6aa44f36b107b5c7
3c1df9f4dd 2018-11-22 16:40:41 +00:00
ted.strauss@61d845770f32afe94ef994b2f25d610756b4128b
a0ee220f94 2018-11-22 15:24:53 +00:00
yarikoptic
acb4bcf2db Added a comment 2018-11-21 19:56:45 +00:00
Mowgli
98af4f51d1 Added a comment: reflink and subvolume 2018-11-21 19:41:30 +00:00
Mowgli
9f3dfeb9a1 removed 2018-11-21 19:40:04 +00:00
Mowgli
a23d982153 Added a comment: reflink and subvolume 2018-11-21 19:38:56 +00:00
yarikoptic
beffd92109 Added a comment 2018-11-21 19:21:48 +00:00
Mowgli
8b76e284a8 Added a comment: reflink and subvolume 2018-11-21 19:01:11 +00:00
Joey Hess
f3ff4e7e26
add news item for git-annex 7.20181121 2018-11-21 14:24:30 -04:00
Joey Hess
60ba0371b6
despam 2018-11-21 11:12:52 -04:00
RannyJohns
bb61cf4aae Added a comment: Nice post 2018-11-21 06:16:06 +00:00
Joey Hess
16873782e5
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-20 20:23:09 -04:00
andrew
c429bbea4b 2018-11-20 22:29:21 +00:00
andrew
e95e15f65b Added a comment 2018-11-20 21:56:03 +00:00
andrew
2d03a4fbd2 Added a comment 2018-11-20 21:42:11 +00:00
andrew
802c62e23a Added a comment 2018-11-20 20:43:50 +00:00
andrew
44ee13f245 removed 2018-11-20 20:43:07 +00:00
andrew
56204470ba Added a comment 2018-11-20 20:42:36 +00:00
marvin@3296bf3c446430c3b2ebc32b5c784ee976620847
987af8d251 2018-11-20 19:34:26 +00:00
anarcat
d5fd4d7806 Added a comment: apenwarr on mtimes 2018-11-20 19:17:00 +00:00
andrew
119ca99a62 Added a comment 2018-11-20 17:45:34 +00:00
Joey Hess
40cb1a674c
update from source build instructions
The EKG build flag was removed, so remove the page about it.
2018-11-20 12:14:23 -04:00
Joey Hess
eb627ab98c
close 2018-11-20 12:09:01 -04:00
Joey Hess
694d0185cd
add todo item 2018-11-20 12:07:21 -04:00
Joey Hess
636e6ab67a
close 2018-11-20 11:45:30 -04:00
marvin@3296bf3c446430c3b2ebc32b5c784ee976620847
ffbe86a76f Added a comment 2018-11-20 11:06:31 +00:00
yarikoptic
61f53f09cf initial FTBFS on sid 2018-11-20 03:09:53 +00:00
yarikoptic
76fc9af4c1 Added a comment 2018-11-19 22:46:01 +00:00
Joey Hess
171dbe81c6
finally done with this 2018-11-19 18:44:03 -04:00
Joey Hess
9c0cece35a
followup 2018-11-19 18:12:03 -04:00
Joey Hess
e053df9451
followup 2018-11-19 17:49:59 -04:00
Joey Hess
b82b775639
followup 2018-11-19 17:45:57 -04:00
yarikoptic
a078de4667 Added a comment: reconfirming with new build option 2018-11-19 21:33:34 +00:00
Joey Hess
36d4fee6b0
followup 2018-11-19 17:31:16 -04:00
yarikoptic
cd18edf858 Added a comment 2018-11-19 21:14:10 +00:00
yarikoptic
58a496d8a2 Added a comment 2018-11-19 21:10:48 +00:00
Joey Hess
362605d6c6
followup 2018-11-19 17:07:13 -04:00
Joey Hess
d418557b5e
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-19 17:01:15 -04:00
Joey Hess
ed27662e96
comment 2018-11-19 17:00:56 -04:00
yarikoptic
e52063d046 Added a comment 2018-11-19 20:55:27 +00:00
Joey Hess
12a8634d6b
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-19 16:50:46 -04:00
Joey Hess
ff9d1ed203
clarify 2018-11-19 16:50:17 -04:00
yarikoptic
1475fce58d Added a comment 2018-11-19 20:26:33 +00:00
Joey Hess
c2e298e96e
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-19 15:47:03 -04:00
Joey Hess
3c8f0d1e1b
further comment 2018-11-19 15:46:40 -04:00
yarikoptic
7c024f6882 Added a comment 2018-11-19 19:25:35 +00:00
Joey Hess
9127fe4821
add DebugLocks build flag
Using the method described in
https://www.fpcomplete.com/blog/2018/05/pinpointing-deadlocks-in-haskell
but my own code to implement it, and with callstacks added.

This work is supported by the NIH-funded NICEMAN (ReproNim TR&D3) project.
2018-11-19 15:02:43 -04:00
Joey Hess
953856df5f
comment 2018-11-19 13:28:44 -04:00
Joey Hess
e612633999
rethrow ExitStatus exceptions
Several git-annex commands want to exit right away, but that's an
exception, which is caught due to 39fbaa0682.
So, re-throw it.
2018-11-19 13:18:08 -04:00
Joey Hess
9508e02ad9
comment 2018-11-19 13:17:42 -04:00
Joey Hess
6bbcccc5bb
comment 2018-11-19 13:09:45 -04:00
Joey Hess
17fe45fc6f
comment 2018-11-19 12:41:37 -04:00
Joey Hess
0bdf01079a
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-19 12:40:12 -04:00
Joey Hess
1f9f220816
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-19 12:39:11 -04:00
yarikoptic
9b1c371c13 Added a comment: dependencies information 2018-11-19 15:54:14 +00:00
yarikoptic
aee99a7ce5 2018-11-19 15:39:27 +00:00
yarikoptic
fb079c1dcb Added a comment 2018-11-19 04:08:37 +00:00
yarikoptic
2770e1791a Added a comment 2018-11-19 03:18:23 +00:00
yarikoptic
cabb57232c reverting since or username(yarikoptic) is not understood 2018-11-18 19:09:05 +00:00
yarikoptic
3752dcb8be added or username(yarikoptic) to see if that would add my bugreports without explicit meta author=yoh 2018-11-18 19:08:23 +00:00
yarikoptic
dacb3603dc initial FTBFS on sid 2018-11-18 19:04:50 +00:00
michael.hanke@c60e12358aa3fc6060531bdead1f530ac4d582ec
f39db41d20 Added a comment: git annex init --version=6 leaves repo dirty 2018-11-18 17:00:21 +00:00
andrew
3f0bc854fd 2018-11-18 16:16:55 +00:00
andrew
98d88e058f Added a comment 2018-11-17 19:13:24 +00:00
andrew
64355f8c08 Added a comment 2018-11-17 19:07:07 +00:00
andrew
01abb6cefc Added a comment 2018-11-17 18:17:27 +00:00
andrew
fceefeb22e 2018-11-17 17:55:41 +00:00
andrew
f6a3a8fc69 2018-11-17 14:42:51 +00:00
yarikoptic
900bf34362 Added a comment 2018-11-16 22:12:58 +00:00
yarikoptic
958d037467 initial suggestion to have ghc version reported in annex version output 2018-11-16 22:06:51 +00:00
Joey Hess
fac397c875
remove redundant OPTIONS section 2018-11-15 22:38:35 -04:00
yarikoptic
4238064600 Added a comment 2018-11-15 20:43:27 +00:00
andrew
615cbf5ffe Added a comment 2018-11-15 20:15:16 +00:00
Joey Hess
39fbaa0682
catch all (non-async) exceptions when running a commandAction
When a command is operating on multiple files and there's an error with
one, try harder to continue to the rest. (As was already done for many
types of errors including IO errors.)

This handles cases like lockContentForRemoval throwing an exception when
the content is already locked. Just because a drop of one file fails, does
not mean it shouldn't go on to try to drop other files.

I looked over uses of `giveup` in Command/*; there are too many to check
them all extensively, but none stood out as being problems that should let
one commandAction stop running other commandActions. Worst case, something
bad will happen and rather than stopping right away with an error,
git-annex will display multiple errors as it fails over and over on each
file. I don't think I ever really intended `error`/`giveup` to stop other
commandActions; this was a relic of old confusion over haskell exception
handling.

Test suite passes.

This commit was sponsored by Ethan Aubin.
2018-11-15 15:59:43 -04:00
Joey Hess
2df31610ed
response 2018-11-15 15:21:39 -04:00
Joey Hess
04b5ed09d8
close old unreproducible bug report 2018-11-15 15:17:49 -04:00
Joey Hess
bb059ce8ef
remove spam; user banned 2018-11-15 15:09:59 -04:00
Joey Hess
ee9c974e06
followup 2018-11-15 14:37:25 -04:00
Joey Hess
ca55119749
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-15 14:32:26 -04:00
Joey Hess
025f90bfcc
followup 2018-11-15 14:30:38 -04:00
yarikoptic
98825e26d8 Added a comment 2018-11-15 18:06:10 +00:00
Joey Hess
05bfce7ca8
comments 2018-11-15 13:36:20 -04:00
Joey Hess
71cc9cfaa2
improve smudge --clean behavior on outside work tree files
smudge: When passed a file located outside the working tree, eg by git
diff, avoid erroring out.

This commit was sponsored by Ewen McNeill on Patreon.
2018-11-15 13:04:40 -04:00
Joey Hess
ac27c29490
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-15 12:31:51 -04:00
Joey Hess
f991a08d4e
comment 2018-11-15 12:29:20 -04:00
sorsasampo@35b3d76c4c73ffc3f2c89e965c47a3f6a2721228
1815b027a2 2018-11-15 16:03:12 +00:00
Joey Hess
9063a0fdd7
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-15 11:28:38 -04:00
yarikoptic
90f86575cb Added a comment: my bad 2018-11-15 12:34:58 +00:00
marvin@3296bf3c446430c3b2ebc32b5c784ee976620847
b6e9a69f42 Added a comment 2018-11-15 10:12:49 +00:00
Ilya_Shlyakhter
01de48e537 added suggestion to add xxHash backend 2018-11-15 07:28:24 +00:00
Elina_Williams
4d25933f8b Added a comment 2018-11-15 06:48:31 +00:00
Elina_Williams
3bdf473edc removed 2018-11-15 06:46:18 +00:00
Elina_Williams
80e400cc65 Added a comment 2018-11-15 06:45:04 +00:00
Ilya_Shlyakhter
57f631f156 Added a comment 2018-11-15 02:11:43 +00:00
https://launchpad.net/~barthelemy
ea3d399789 2018-11-15 02:00:18 +00:00
Joey Hess
d6fb123318
requested name change 2018-11-14 13:03:13 -04:00
Ilya_Shlyakhter
827d9c3135 added suggestion about keeping the git-annex branch permanently checked out 2018-11-14 16:42:41 +00:00
andrew
fdab537f46 Added a comment 2018-11-14 13:32:53 +00:00
yarikoptic
5f53dcbf80 Added a comment 2018-11-13 20:02:18 +00:00
Joey Hess
d65df7ab21
improve messages around export conflicts
When an export conflict prevents accessing a special remote, be clearer
about what the problem is and how to resolve it.

This commit was sponsored by Trenton Cronholm on Patreon.
2018-11-13 15:50:06 -04:00
Joey Hess
6a0618f7b3
todo 2018-11-13 15:49:22 -04:00
Joey Hess
e2589670da
update slightly 2018-11-13 15:13:44 -04:00
Joey Hess
4b14438c9a
suggestion 2018-11-13 14:04:37 -04:00
Joey Hess
381bc4ab34
followup 2018-11-13 13:50:59 -04:00
Joey Hess
170b88b95e
followup 2018-11-13 13:50:15 -04:00
Joey Hess
f4e0719aa3
followup and close 2018-11-13 13:34:12 -04:00
https://launchpad.net/~barthelemy
ab4be761be Added a comment: cannot reproduce on git-annex 6.20180913 2018-11-13 09:32:55 +00:00
yarikoptic
329599428b Added a comment: yeap -- it is netbase which is needed 2018-11-13 04:20:28 +00:00
yarikoptic
84b1fb72d4 Added a comment 2018-11-13 04:14:28 +00:00
Joey Hess
6f69ede2ea
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-12 17:31:52 -04:00
Joey Hess
a720f377af
bug report 2018-11-12 17:19:33 -04:00
anarcat
40dddf9ee1 Added a comment: probably fixed indeed 2018-11-12 20:54:05 +00:00
https://launchpad.net/~barthelemy
05d2cd9e14 2018-11-12 20:46:59 +00:00
Joey Hess
5d49408871
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-12 16:40:21 -04:00
Joey Hess
ba32210460
update 2018-11-12 16:37:43 -04:00
Joey Hess
e690da0174
followup 2018-11-12 16:23:51 -04:00
Joey Hess
1e4111a1d2
close dup of fixed issue 2018-11-12 16:16:26 -04:00
Joey Hess
ff9bd9620e
Fix resume of download of url when the whole file content is already actually downloaded
Don't much like that there's no way to distinguish between having the whole
content and having an old version of the file that's bigger, but of course
resuming a http transfer can always yield the wrong result if the file on
the http server is changing, and git-annex will detect that when it
verifies the downloaded content.

This work is supported by the NIH-funded NICEMAN (ReproNim TR&D3) project.
2018-11-12 16:08:47 -04:00
Joey Hess
c24bdfd689
response 2018-11-12 15:44:44 -04:00
yarikoptic
19f7bd294f Added a comment 2018-11-12 19:34:00 +00:00
yarikoptic
7fe1a83f7f Added a comment 2018-11-12 19:27:48 +00:00
yarikoptic
47f6bfdb7e Added a comment 2018-11-12 19:15:53 +00:00
Joey Hess
563f8b7c0f
followup 2018-11-12 14:54:50 -04:00
Joey Hess
e4125318d8
response 2018-11-12 14:52:30 -04:00
yarikoptic
396b6134ac added my meta 2018-11-12 18:02:03 +00:00
yarikoptic
6f0cbbd204 initial report on annex not properly considering http somehow while within docker 2018-11-12 18:00:18 +00:00
Joey Hess
58d1b2510c
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-12 13:26:10 -04:00
yarikoptic
9d47fcac49 Added a comment 2018-11-12 17:25:43 +00:00
Joey Hess
5ce078da92
bash completion fix
Fix bash completion of "git annex" to propertly handle files with spaces
and other problem characters. (Completion of "git-annex" already did.)

This commit was sponsored by Jake Vosloo on Patreon.
2018-11-12 13:23:05 -04:00
andrew
34d77ecdfd 2018-11-12 16:51:12 +00:00
yarikoptic
8f8b746f67 Added a comment: reply on the issue 2018-11-12 16:48:08 +00:00
andrew
b3d6b2dad9 Added a comment 2018-11-12 16:37:44 +00:00
andrew
4184878218 2018-11-12 16:36:26 +00:00
Joey Hess
d01c7c173c
response 2018-11-12 12:10:40 -04:00
Joey Hess
f32d4d57db
exclude the duplicate tag page from the list of bugs 2018-11-12 12:05:03 -04:00
Joey Hess
5bb2c72b6d
followup 2018-11-12 12:03:39 -04:00
Joey Hess
911f75232b
followup 2018-11-12 11:49:44 -04:00
Joey Hess
398bac4530
not dup 2018-11-12 11:23:56 -04:00
marvin@3296bf3c446430c3b2ebc32b5c784ee976620847
0bb3a55646 Added a comment 2018-11-12 08:48:34 +00:00
xelxebar
cd5c53ca60 2018-11-12 03:28:38 +00:00
andrew
2429763490 Added a comment 2018-11-12 03:17:48 +00:00
andrew
d20872e250 removed 2018-11-12 02:37:45 +00:00
andrew
cf8eaab7e0 Added a comment 2018-11-11 23:30:23 +00:00
andrew
f18cbb59f6 removed 2018-11-11 23:29:56 +00:00
andrew
daaf819cbb Added a comment 2018-11-11 23:28:22 +00:00
andrew
22438c42dd Added a comment 2018-11-11 23:20:26 +00:00
andrew
17983fcb3d Added a comment 2018-11-11 23:13:29 +00:00
andrew
8853f6b13c 2018-11-11 21:39:56 +00:00
andrew
87efebb590 Added a comment 2018-11-11 21:35:26 +00:00
andrew
97453224ed 2018-11-11 21:33:37 +00:00
Joey Hess
d733da87f6
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-10 12:38:27 -04:00
Joey Hess
77ea81f945
comment 2018-11-10 12:34:29 -04:00
spwhitton
b3444547a5 Added a comment 2018-11-09 21:07:32 +00:00
Joey Hess
5a25069dfd
comment 2018-11-09 13:10:00 -04:00
Joey Hess
f78f97780c
Fix build with persistent-sqlite older than 2.6.3.
This commit was sponsored by Jack Hill on Patreon.
2018-11-09 13:09:02 -04:00
Joey Hess
4623a037f5
Merge remote-tracking branch 'origin/master' 2018-11-09 13:04:14 -04:00
Joey Hess
0d1b42ef78
update 2018-11-08 15:43:02 -04:00
Joey Hess
82aad90d33
update roadmap 2018-11-08 15:42:53 -04:00
yarikoptic
b1a5ea5f53 original double complain on get -J 2018-11-08 18:05:56 +00:00
Joey Hess
0f5e5703e5
update 2018-11-08 11:46:23 -04:00
andrew
758c2b731f Added a comment 2018-11-08 13:10:23 +00:00
andrew
5afd6d105a Added a comment 2018-11-08 13:06:56 +00:00
seantparsons
352f88226f Added a comment 2018-11-06 22:50:25 +00:00
yarikoptic
60cf067d79 Added a comment 2018-11-06 22:16:39 +00:00
yarikoptic
1011d957aa Added a comment 2018-11-06 20:01:08 +00:00
Joey Hess
6ecd55a9fa
Fixed some other potential hangs in the P2P protocol
Finishes the start made in 983c9d5a53, by
handling the case where `transfer` fails for some other reason, and so the
ReadContent callback does not get run. I don't know of a case where
`transfer` does fail other than the locking dealt with in that commit, but
it's good to have a guarantee.

StoreContent and StoreContentTo had a similar problem.
Things like `getViaTmp` may decide not to run the transfer action.
And `transfer` could certianly fail, if another transfer of the same
object was in progress. (Or a different object when annex.pidlock is set.)

If the transfer action was not run, the content of the object would
not all get consumed, and so would get interpreted as protocol commands,
which would not go well.

My approach to fixing all of these things is to set a TVar only
once all the data in the transfer is known to have been read/written.
This way the internals of `transfer`, `getViaTmp` etc don't matter.

So in ReadContent, it checks if the transfer completed.
If not, as long as it didn't throw an exception, send empty and Invalid
data to the callback. On an exception the state of the protocol is unknown
so it has to raise ProtoFailureException and close the connection,
same as before.

In StoreContent, if the transfer did not complete
some portion of the DATA has been read, so the protocol is in an unknown
state and it has to close the conection as well.

(The ProtoFailureMessage used here matches the one in Annex.Transfer, which
is the most likely reason. Not ideal to duplicate it..)

StoreContent did not ever close the protocol connection before. So this is
a protocol change, but only in an exceptional circumstance, and it's not
going to break anything, because clients already need to deal with the
connection breaking at any point.

The way this new behavior looks (here origin has annex.pidlock = true so will
only accept one upload to it at a time):

git annex copy --to origin -J2
copy x (to origin...) ok
copy y (to origin...)
  Lost connection (fd:25: hGetChar: end of file)

This work is supported by the NIH-funded NICEMAN (ReproNim TR&D3) project.
2018-11-06 14:52:32 -04:00
Joey Hess
9adc0b3417
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-06 13:01:00 -04:00
Joey Hess
983c9d5a53
git-annex-shell: fix transfer hang
Fix hang when transferring the same objects to two different clients at the
same time. (Or when annex.pidlock is used, two different objects to the
same or different clients.)

Could also potentially occur if a client was downloading an object and
somehow lost connection but that git-annex-shell was still running and
holding the transfer lock.

This does not guarantee that, if `transfer` fails for some other reason,
a DATA response will be made.

This work is supported by the NIH-funded NICEMAN (ReproNim TR&D3) project.
2018-11-06 13:00:37 -04:00
metst13@1d16544ec52801db7efb2895d3dc7a4458b8eb45
7bca7542d6 Added a comment 2018-11-06 16:10:11 +00:00
metst13@1d16544ec52801db7efb2895d3dc7a4458b8eb45
1803ba1bcc Added a comment: clone to the server 2018-11-06 14:58:39 +00:00
yarikoptic
68adc08502 initial report on failing to get a file after it actually got to tmp/ fully 2018-11-06 03:43:40 +00:00
Joey Hess
0a0242224d
full analysis 2018-11-05 18:25:55 -04:00
Joey Hess
44769d9285
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-05 17:13:16 -04:00
Joey Hess
14075afbd7
updated analysis 2018-11-05 17:12:19 -04:00
yarikoptic
0f0a6336cd Added a comment 2018-11-05 21:01:35 +00:00
yarikoptic
2003b42efb Added a comment 2018-11-05 20:53:48 +00:00
spwhitton
4bb1a6060f report failure to build against stretch 2018-11-05 20:20:30 +00:00
Joey Hess
c31ea81ee9
pidlock 2018-11-05 15:37:46 -04:00
Joey Hess
bb14843e72
update thanks, listing code and other significant non-financial contributors 2018-11-05 15:07:14 -04:00
Joey Hess
3c50fa130c
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-05 14:39:18 -04:00
Joey Hess
3ef13f128f
followup on bug triage 2018-11-05 14:38:32 -04:00
Joey Hess
fd128e5a3f
code review and response 2018-11-05 14:28:02 -04:00
marvin@3296bf3c446430c3b2ebc32b5c784ee976620847
4d11214908 Added a comment 2018-11-05 18:22:49 +00:00
marvin@3296bf3c446430c3b2ebc32b5c784ee976620847
296c984c66 Added a comment 2018-11-05 18:21:54 +00:00
Joey Hess
d87ebf82a8
add news item for git-annex 7.20181105 2018-11-05 13:33:59 -04:00
yarikoptic
aabfdca800 Added a comment 2018-11-05 17:31:46 +00:00
Joey Hess
5f213d45b1
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-05 12:34:54 -04:00
Joey Hess
0cb6d14383
followup 2018-11-05 12:34:27 -04:00
yarikoptic
13f9e79df1 removed 2018-11-05 16:03:47 +00:00
anarcat
6d954cc132 upload to the test collection, giving users an idea of how to change collections as well as forcing people to think before they upload 2018-11-05 16:02:23 +00:00
yarikoptic
02c74a0dfd Added a comment 2018-11-05 16:00:53 +00:00
yarikoptic
eb218d4e59 Added a comment 2018-11-05 15:57:17 +00:00
Joey Hess
42f1ea72de
followup 2018-11-05 11:47:58 -04:00
Joey Hess
cb69b77625
fix link 2018-11-05 11:39:04 -04:00
Joey Hess
11a37386df
Merge branch 'master' of ssh://git-annex.branchable.com 2018-11-05 11:37:39 -04:00
seantparsons
8570c07d49 2018-11-04 20:59:39 +00:00
anarcat
cb122b9d1e Added a comment: rsync can do this on its own 2018-11-04 19:29:19 +00:00
Joey Hess
7f15339162
update 2018-11-04 15:06:06 -04:00
anarcat
d621846ab8 Added a comment: workaround with youtube-dl 2018-11-03 20:52:49 +00:00