mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

response

Browse source
This commit is contained in:
Joey Hess 2018-12-01 12:05:20 -04:00
parent 5b5cff2572
commit 12bec83f45
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
doc/todo/git_smudge_clean_interface_suboptiomal/comment_2_8ad0fa4f67af60313d3195bc8c0acfb8._comment Normal file
View file

@ -0,0 +1,20 @@
[[!comment format=mdwn
username="joey"
subject="""comment 2"""
date="2018-12-01T15:47:48Z"
content="""
At the same time I was working on that patch set, there was another patch
being developed that affected the same filters (adding the long-running
filter interface to git). I think there may have also been some
uncertianty, on the part of the git developers, in taking the filter
interface in the direction I wanted to.
(Also honestly, I can only rebase large C patch sets some many times before my
time feels better spent doing something else. :-/)
On piping efficiency, `splice()` doesn't avoid the whole file needing to be
read in and and written to the pipe, which is the main bottleneck.
And the way the smudge/clean filters are used by git-annex
(and git-lfs), bouncing the unaltered file content back out the other side
using `splice()` doesn't seem like it would be useful.
"""]]