Commit graph

9926 commits

Author SHA1 Message Date
Joey Hess
5a5873e052
fix bug caught by test suite 2020-07-31 16:11:50 -04:00
kyle
7bae35d840 prop_isomorphic_key_encode test failure 2020-07-30 17:51:20 +00:00
leej
2105c6e9a7 Added a comment 2020-07-28 14:58:00 +00:00
nicholsn
60f3626338 Added a comment: Thank you 2020-07-28 03:57:34 +00:00
kyle
8a594395f3 'beyond symlink' error for upstream link 2020-07-27 19:37:13 +00:00
Joey Hess
2e702960ab
followup and close 2020-07-27 11:33:47 -04:00
leej
e8135f27ef 2020-07-25 00:15:34 +00:00
Joey Hess
00c5f04f20
Deal with unusual IFS settings in the shell scripts for linux standalone and OSX app.
Thanks, Yaroslav Halchenko
2020-07-24 14:46:50 -04:00
Joey Hess
3627f03996
comment 2020-07-24 14:36:50 -04:00
Joey Hess
79187a6eaf
Revert "Unset IFS in shell scripts in the linux standalone build and OSX app."
This reverts commit 24125e8dc4.

yoh has a better patch I see
2020-07-24 14:33:13 -04:00
Joey Hess
24125e8dc4
Unset IFS in shell scripts in the linux standalone build and OSX app. 2020-07-24 14:31:11 -04:00
yarikoptic
d7e04e5e3a Added a comment 2020-07-24 15:22:40 +00:00
yarikoptic
4ff59a85d5 report on intolerance of IFS 2020-07-24 01:42:59 +00:00
karel-de-macil
39337c604b 2020-07-23 10:30:35 +00:00
karel-de-macil
8325db46a6 2020-07-23 10:28:43 +00:00
kyle
155b56f015 Added a comment 2020-07-22 16:12:25 +00:00
kyle
0538dc425c Added a comment 2020-07-22 16:01:05 +00:00
Joey Hess
aa492bc659
Fix a hang when using git-annex with an old openssh 7.2p2
This does mean a 2 second delay after transfers when using that ssh, but
it's an old and apparently quite weirdly broken version of ssh.
2020-07-22 11:04:33 -04:00
Joey Hess
afaae84f49
comment 2020-07-21 16:50:26 -04:00
Joey Hess
cb74cefde7
Fix a hang when using git-annex with an old openssh 7.2p2
Which had some weird inheriting of ssh FDs by sshd.

Bug was introduced in git-annex version 7.20200202.7.
2020-07-21 16:14:25 -04:00
Joey Hess
ac56a5c2a0
Fix a lock file descriptor leak that could occur when running commands like git-annex add with -J
Bug was introduced as part of a different FD leak fix in version 6.20160318.
2020-07-21 15:30:47 -04:00
Joey Hess
fd8339005a
update 2020-07-21 14:44:07 -04:00
Joey Hess
77f7157ddb
analysis 2020-07-21 10:30:46 -04:00
Joey Hess
4de4c36d2b
dup 2020-07-21 10:07:23 -04:00
Joey Hess
abd56fb019
Fix a bug in find --batch in the previous version. 2020-07-20 19:50:53 -04:00
gueux
225fd08b6d Added a comment 2020-07-20 06:45:25 +00:00
Joey Hess
889603336a
fix reversion in skipping deleted files
And add a test case for that.

This certianly loses some of the 2x performance improvement in file
seeking that seekFilteredKeys led to, because now it has to stat the
worktree files again. Without benchmarking, I expect there will still be
a sizable improvement, and also the git-annex branch precaching that
seekFilteredKeys can do will still be a win of its approach.

Also worth noting that lookupKey, when the file DNE, check if it's in an
adjusted branch with hidden files, and if so, finds the key for the
file anyway. That was intended to make git-annex sync --content be able
to process those files, but a side effect was that, when a file was
deleted but the deletion not yet staged, git-annex commands used to
still list it. That was actually a bug. This commit fixes that bug too.
(git-annex sync --content on such a branch does not use seekFilteredKeys
so was not affected by the reversion or by this behavior change)

This commit was sponsored by Jake Vosloo on Patreon.
2020-07-19 21:25:01 -04:00
Joey Hess
b5590e916e
analysis 2020-07-19 20:14:49 -04:00
Joey Hess
1489fbbdde
bug 2020-07-19 18:26:57 -04:00
kyle
f818da2f85 bug: find --batch regression 2020-07-16 21:53:14 +00:00
branchable@bafd175a4b99afd6ed72501042e364ebd3e0c45e
059d56659b Added a comment: GIT_TRACE=1 debug shows smudge --clean is run twice per file 2020-07-16 17:06:13 +00:00
branchable@bafd175a4b99afd6ed72501042e364ebd3e0c45e
1836f7a318 2020-07-16 16:32:41 +00:00
Joey Hess
ebdbb87716
comment 2020-07-15 16:11:34 -04:00
kyle
e8197c9e74 fixed elsewhere 2020-07-15 16:35:46 +00:00
Joey Hess
aa44126bc0
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-15 11:27:38 -04:00
Joey Hess
a7156b875c
fix fsck reversion
75aab72d23 made fsck skip files whose
content is not present, but it should complain if there are not enough
copies.
2020-07-15 11:21:43 -04:00
Joey Hess
32c847d1a1
analysis 2020-07-15 11:13:02 -04:00
Joey Hess
5d59bb9554
add 2020-07-15 10:58:45 -04:00
nolan.nichols@fe8d6ffa163484d0632235838db69df04538caf1
af6088bcba 2020-07-15 03:32:24 +00:00
kyle
e55263046f tag issue 2020-07-15 00:58:03 +00:00
kyle
8c65cab4c6 recent test failures 2020-07-15 00:52:39 +00:00
kyle
ed99f652fa Added a comment 2020-07-14 19:18:10 +00:00
Joey Hess
e223ddb774
comments 2020-07-13 17:52:03 -04:00
Joey Hess
c893743819
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-13 17:13:02 -04:00
kyle
592548a843 Added a comment 2020-07-13 19:27:18 +00:00
kyle
b94481a3b9 Added a comment 2020-07-13 19:04:45 +00:00
Joey Hess
f34edf0011
close 2020-07-13 13:27:43 -04:00
Joey Hess
4dd5cfa463
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-13 13:26:28 -04:00
Joey Hess
8219dbcb95
comment 2020-07-13 13:25:10 -04:00
Joey Hess
ba345e90b5
test metadata 2020-07-13 12:53:09 -04:00
kyle
800b36ccff Added a comment 2020-07-13 16:50:37 +00:00
kyle
ed7afd4f6d Added a comment 2020-07-13 16:46:54 +00:00
Joey Hess
918b1faa3d
avoid hanging on exception 2020-07-13 12:36:15 -04:00
Joey Hess
bff5694f55
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-13 12:18:05 -04:00
Joey Hess
1b2f29b207
comment 2020-07-13 12:16:48 -04:00
kyle
575317a444 metadata --remove hang on 88a7fb5cb 2020-07-11 01:12:31 +00:00
kyle
780f8675f6 git-annex-init hang on older systems 2020-07-10 20:57:47 +00:00
Joey Hess
a7fcda861f
comment 2020-07-10 16:09:13 -04:00
barak
7397bd75ea 2020-07-10 19:52:11 +00:00
kyle
a5142499ce rsync hang 2020-07-07 15:26:38 +00:00
Joey Hess
d66fc1a464
Revert "async exception safety for coprocesses"
This reverts commit 7013798df5.
2020-07-06 15:11:28 -04:00
Joey Hess
6b8c961e1f
some analysis but stuck 2020-07-06 14:46:05 -04:00
Joey Hess
0518b62d2b
update 2020-07-06 12:58:29 -04:00
Joey Hess
27bbeea00e
close 2020-07-06 10:49:06 -04:00
petersjt014@c20995a2e26a13566cd49aef30a99a7dff732a4e
ba209702c1 Added a comment: tor remote 2020-07-03 07:33:54 +00:00
Joey Hess
a3e125c1fe
move to re-notify 2020-07-02 20:05:54 -04:00
Joey Hess
8fc9788363
fix commment 2020-07-02 20:05:36 -04:00
kyle
a379ea833e Added a comment 2020-07-02 20:07:10 +00:00
Joey Hess
629026bdbc
followup 2020-07-02 15:06:00 -04:00
Joey Hess
d8ad2204c7
comment 2020-07-02 14:43:52 -04:00
Joey Hess
f912f8e5fd
refix bug in a better way
Always run Git.Config.store, so when the git config gets reloaded,
the override gets re-added to it, and changeGitRepo then calls extractGitConfig
on it and sees the annex.* settings from the override.

Remove any prior occurance of -c v and add it to the end. This way,
-c foo=1 -c foo=2 -c foo=1 will pass -c foo=1 to git, rather than -c foo=2

Note that, if git had some multiline config that got built up by
multiple -c's, this would not work still. But it never worked because
before the bug got fixed in the first place, the -c value was repeated
many times, so the multivalue thing would have been wrong. I don't think
-c can be used with multiline configs anyway, though git-config does
talk about them?
2020-07-02 13:32:33 -04:00
Joey Hess
ec0f8a6e74
Fix reversion that broke passing git configs with -c
Reverting commit c8fec6ab0
2020-07-02 12:42:13 -04:00
Joey Hess
0b5515899b
comment 2020-07-02 12:18:02 -04:00
Joey Hess
fe1f4632a4
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-02 10:00:11 -04:00
B
d409f92318 Added a comment: Workaround 2020-07-02 12:51:41 +00:00
Joey Hess
117bd04693
more details 2020-07-01 16:20:37 -04:00
Ilya_Shlyakhter
afc705f7c8 Added a comment: adding files also fails 2020-07-01 19:51:34 +00:00
Ilya_Shlyakhter
2db76f8144 added bug report about git-annex-init on a repo in VirtualBox shared folder 2020-07-01 19:39:14 +00:00
https://bmwiedemann.zq1.de/
e3d091f12c Added a comment 2020-07-01 02:47:05 +00:00
kyle
9bd56b5494 Added a comment 2020-06-30 21:24:56 +00:00
Joey Hess
33c26988f6
comment 2020-06-30 17:21:17 -04:00
Joey Hess
4af5fc3505
fixed oops 2020-06-30 17:16:29 -04:00
Joey Hess
3935ce8be5
Merge branch 'master' of ssh://git-annex.branchable.com 2020-06-30 17:15:31 -04:00
Joey Hess
5891e10409
bug report 2020-06-30 16:40:08 -04:00
https://bmwiedemann.zq1.de/
814698bd53 Added a comment 2020-06-30 19:47:35 +00:00
kyle
80bb42a3ca stack build failure 2020-06-30 19:08:32 +00:00
kyle
59e64842a7 Added a comment 2020-06-30 16:26:17 +00:00
kyle
e4e28452a0 annex-ssh-options regression 2020-06-30 15:48:03 +00:00
https://bmwiedemann.zq1.de/
68549767e9 Added a comment 2020-06-30 15:26:10 +00:00
Joey Hess
7a4253a155
followup and close as this is intentional 2020-06-30 10:41:26 -04:00
Joey Hess
6780648bba
comment 2020-06-30 10:20:27 -04:00
https://bmwiedemann.zq1.de/
95b8b4a5af 2020-06-29 14:02:17 +00:00
Joey Hess
7203353e24
comment 2020-06-26 12:18:18 -04:00
yarikoptic
ff8e9f4b5f Added a comment 2020-06-26 14:22:25 +00:00
yarikoptic
50bf73f043 initial report on an odd fail 2020-06-26 14:17:56 +00:00
Joey Hess
b38cc371ad
close per comments 2020-06-24 12:53:13 -04:00
Joey Hess
1b1863673b
close as dup 2020-06-24 12:50:19 -04:00
Joey Hess
725b1395b0
close, fixed 3 years ago 2020-06-24 12:48:46 -04:00
Joey Hess
5eeac2a9c9
close 2020-06-24 12:40:37 -04:00
Joey Hess
f744882e34
comment 2020-06-24 12:37:10 -04:00
Joey Hess
86968e366c
open bug 2020-06-23 17:07:46 -04:00
Joey Hess
e2f739b0c8
comment and close 2020-06-22 14:38:09 -04:00
Joey Hess
b904748ee3
guess yoh meant projects/datalad here, not projects/yoh 2020-06-22 14:26:33 -04:00
Joey Hess
5098236c6b
testremote: Fix over-allocation of resources and bad caching
Including starting up a large number of external special remote processes.
(Regression introduced in version 8.20200501)
2020-06-22 14:25:49 -04:00
ink
a6fffac9ae 2020-06-20 10:45:24 +00:00
yarikoptic
6491691801 initial report on breed of children processes by testremote 2020-06-19 20:41:21 +00:00
Franky
b656c0853f 2020-06-19 02:16:19 +00:00
Franky
0b5d1e17b0 removed 2020-06-19 02:10:29 +00:00
yarikoptic
775c1cb032 Added a comment 2020-06-18 19:17:27 +00:00
Joey Hess
22ac56fece
test suite passing 2020-06-18 13:55:32 -04:00
Joey Hess
348821c9cf
analysis of deadlock 2020-06-18 12:10:54 -04:00
Joey Hess
3464fa12c7
meh 2020-06-17 15:58:39 -04:00
Joey Hess
762fd5ae5d
Merge branch 'master' of ssh://git-annex.branchable.com 2020-06-17 15:35:27 -04:00
Joey Hess
82448bdf39
fix a annex.pidlock issue
That made eg git-annex get of an unlocked file hang until the
annex.pidlocktimeout and then fail.

This fix should be fully thread safe no matter what else git-annex is
doing.

Only using runsGitAnnexChildProcess in the one place it's known to be a
problem. Could audit for all places where git-annex runs itself as a child
and add it to all of them, later.
2020-06-17 15:30:59 -04:00
Franky
bc3f9999b0 2020-06-17 19:07:00 +00:00
Franky
d72d76c06f 2020-06-17 19:01:44 +00:00
Franky
e98f9f7684 2020-06-17 19:00:36 +00:00
Franky
af5369bc92 2020-06-17 18:58:51 +00:00
Joey Hess
9583b267f5
confirmed fix 2020-06-17 12:12:41 -04:00
Joey Hess
b072b71c27
one more bugfix to external special remote creds
The creds are passedthrough in this case, so check for such first to
avoid a crash when getRemoteConfigValue sees a type it was not
expecting.
2020-06-16 18:28:26 -04:00
Joey Hess
ad81feb053
fix implicit embedcreds regression
Fix bug that made creds not be stored in git when a special remote was
initialized with gpg encryption, but without an explicit embedcreds=yes.

(Yet nother regression introduced in version 7.20200202.7. 5th so far.)
2020-06-16 18:00:19 -04:00
Joey Hess
4773713cc9
analysis of regression and fix related less serious regression 2020-06-16 15:16:36 -04:00
Joey Hess
5b8933b914
comment 2020-06-16 15:16:35 -04:00
Joey Hess
9e0bafd70b
Merge branch 'master' of ssh://git-annex.branchable.com 2020-06-16 14:38:27 -04:00
Joey Hess
3d53cbc614
comment 2020-06-16 14:38:02 -04:00
yarikoptic
d7f05a328a Added a comment 2020-06-16 18:30:07 +00:00
Joey Hess
3922f34f8e
comment 2020-06-16 14:16:02 -04:00
Joey Hess
c4f2c56f5e
checkpresentkey: fix behavior to match documentation
checkpresentkey: When no remote is specified, try all remotes, not only
ones that the location log says contain the key. This is what the
documentation has always said it did.

Still try the logged remotes first, because they are far more likely to
have the key.
2020-06-16 13:54:26 -04:00
Joey Hess
f3010afbf6
improve docs and close incorrect bug report 2020-06-16 13:45:00 -04:00
kanakkshetri@9ea0e7639162bddc7bf9f3bb94cc32e93c793b89
6dac582f06 Mark as done 2020-06-15 11:44:20 +00:00
kanakkshetri@9ea0e7639162bddc7bf9f3bb94cc32e93c793b89
1e0dd34566 Added a comment 2020-06-15 11:42:41 +00:00
calmofthestorm
d912685417 2020-06-15 05:25:37 +00:00
yarikoptic
e8edbe1ff3 Added a comment: stalls 2020-06-12 03:40:54 +00:00
lykos@d125a37d89b1cfac20829f12911656c40cb70018
cd326962c8 Added a comment 2020-06-11 22:51:09 +00:00
Joey Hess
e5ec6609c0
Merge branch 'master' of ssh://git-annex.branchable.com 2020-06-11 17:47:16 -04:00
Joey Hess
69efc2c26b
comment 2020-06-11 17:36:17 -04:00
yarikoptic
c2f84a76bc Added a comment 2020-06-11 21:13:38 +00:00
Joey Hess
b60b8ecc78
clarify 2020-06-11 16:20:18 -04:00
Joey Hess
4e778ef849
response 2020-06-11 16:14:17 -04:00
Joey Hess
8a7c615a8f
import: Avoid using some strange names for temporary keys
The ContentIdentifier can contain almost anything, so could have characters
that are not fit for the filesystem, or might be longer than a key usually
is, or contain a newline, or .... genKeyName deals with those problems.

This should not present a back-compat issue, because this is a temporary
key used while downloading the imported file, before the real key for it
can be generated.
2020-06-11 16:07:36 -04:00
Joey Hess
0017d9a347
Merge branch 'master' of ssh://git-annex.branchable.com 2020-06-11 15:44:28 -04:00
Joey Hess
6b0cb2d732
defer cleaning keys db of old data
Avoid creating the keys database during init when there are no unlocked
files, to prevent init failing when sqlite does not work in the filesystem.
2020-06-11 15:40:13 -04:00
Joey Hess
d711dc31fa
response 2020-06-11 14:12:16 -04:00
yarikoptic
646a521473 reporting on a failed unittest on a crippled HOME. 2020-06-11 14:50:37 +00:00
lykos@d125a37d89b1cfac20829f12911656c40cb70018
a0ffdac56e 2020-06-11 11:03:07 +00:00
branchable@bafd175a4b99afd6ed72501042e364ebd3e0c45e
b65e596fb8 Added a comment: I wonder if this is related to the use of tor 2020-06-11 09:56:08 +00:00
kanakkshetri@9ea0e7639162bddc7bf9f3bb94cc32e93c793b89
9102d31721 Added a comment: git-annex-repair and git annex fsck: no errors found 2020-06-10 14:39:44 +00:00
kanakkshetri@9ea0e7639162bddc7bf9f3bb94cc32e93c793b89
c4a9647555 noticed confusing two rsync processes to copy one file. 2020-06-10 10:58:05 +00:00
kanakkshetri@9ea0e7639162bddc7bf9f3bb94cc32e93c793b89
34b088b209 Output of --debug, Formatting 2020-06-08 15:09:20 +00:00
kanakkshetri@9ea0e7639162bddc7bf9f3bb94cc32e93c793b89
634c66ea49 2020-06-08 14:24:37 +00:00