Unset IFS in shell scripts in the linux standalone build and OSX app.

CHANGELOG

@@ -11,6 +11,7 @@ git-annex (8.20200720.2) UNRELEASED; urgency=medium
   * move, copy --to: Sped up seeking files by 2x.
   * drop: Sped up seeking files to drop by 2x, and also some performance
     improvements to checking numcopies.
+  * Unset IFS in shell scripts in the linux standalone build and OSX app.
 
  -- Joey Hess <id@joeyh.name>  Tue, 21 Jul 2020 12:58:30 -0400
 

doc/bugs/standalone_shim_is_segfaulting_if_IFS__61____36____39____92__013__39__/comment_2_7836dffec8167c51c91b96fba90bde27._comment

@@ -0,0 +1,26 @@
+[[!comment format=mdwn
+ username="joey"
+ subject="""comment 2"""
+ date="2020-07-24T18:17:12Z"
+ content="""
+Hmm, so runshell has some things like
+
+	for lib in $(cat "$base/libdirs"); do
+		GIT_ANNEX_LD_LIBRARY_PATH=...
+
+Which, with an unusual IFS, probably set the environment variable to
+something bogus. Which seems the kind of thing that could break things
+badly enough to segfault.
+
+I have so far not been able to reproduce it, I tried:
+
+	tar zxvf ~/src/git-annex/tmp/git-annex-standalone-amd64.tar.gz
+	cd git-annex.linux/
+	IFS=$'\013' ./git-annex version
+
+But this may involve the system the standalone build is used in, if the
+problem is this is breaking its isolation from that system. So might need a
+particular version skew between the two.
+
+I've applied the obvious changes, so please verify the fix.
+"""]]

standalone/linux/skel/git

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink -f "$0" 2>/dev/null || readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/linux/skel/git-annex

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink -f "$0" 2>/dev/null || readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/linux/skel/git-annex-shell

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink -f "$0" 2>/dev/null || readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/linux/skel/git-annex-webapp

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink -f "$0" 2>/dev/null || readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/linux/skel/git-receive-pack

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink -f "$0" 2>/dev/null || readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/linux/skel/git-shell

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink -f "$0" 2>/dev/null || readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/linux/skel/git-upload-pack

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink -f "$0" 2>/dev/null || readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/linux/skel/runshell

@@ -3,6 +3,7 @@
 # libraries bundled with this app.
 
 set -e
+unset IFS
 
 os="$(uname -o 2>/dev/null || true)"
 base="$(dirname "$0")"

standalone/osx/git-annex.app/Contents/MacOS/git

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/osx/git-annex.app/Contents/MacOS/git-annex

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/osx/git-annex.app/Contents/MacOS/git-annex-shell

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/osx/git-annex.app/Contents/MacOS/git-annex-webapp

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/osx/git-annex.app/Contents/MacOS/git-receive-pack

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/osx/git-annex.app/Contents/MacOS/git-shell

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/osx/git-annex.app/Contents/MacOS/git-upload-pack

@@ -1,4 +1,5 @@
 #!/bin/sh
+unset IFS
 link="$(readlink "$0")" || true
 if [ -n "$link" ]; then
 	base="$(dirname "$link")"

standalone/osx/git-annex.app/Contents/MacOS/runshell

@@ -3,6 +3,7 @@
 # bundled with this app.
 
 set -e
+unset IFS
 
 base="$(dirname "$0")"