mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

comment

Browse source
This commit is contained in:
Joey Hess 2020-06-24 12:37:10 -04:00
parent fde6099c59
commit f744882e34
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 25 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

25
doc/bugs/cannot___40__or_how__63____41___to_pass_socket_path_with_a_space_in_its_path_via_annex-ssh-options/comment_2_01cb7ba7d3c19863d39f6fac0d45d235._comment Normal file
View file

@ -0,0 +1,25 @@
[[!comment format=mdwn
username="joey"
subject="""comment 2"""
date="2020-06-24T16:24:29Z"
content="""
Is this still something you need, or does `GIT_SSH_COMMAND` cover the use
case?
The missing case would be, if you need remote.name.annex-ssh-options,
to pass the options only to that one remote and not others.
I don't feel it would be a good idea for git-annex to try to parse quoted
options, etc. It would need to expose the config to the shell, the same way
it implements GIT_SSH_COMMAND`, by wrapping the original command in "sh
-c".
That would need to be a different config than ssh-options, because
existing ssh-options might be broken by the change. Eg, if it is set to
something containing a "$", that would not be exposed to the shell
currently.
So, while this is clearly a gap, I'd prefer to only implement a fix if it's
actually needed. Since the bug report is 3 years old and I've not gotten a
nudge, I'm guessing maybe not needed..
"""]]