From f744882e344180b4bcd3528979d4ea413634bd99 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 24 Jun 2020 12:37:10 -0400 Subject: [PATCH] comment --- ..._01cb7ba7d3c19863d39f6fac0d45d235._comment | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 doc/bugs/cannot___40__or_how__63____41___to_pass_socket_path_with_a_space_in_its_path_via_annex-ssh-options/comment_2_01cb7ba7d3c19863d39f6fac0d45d235._comment diff --git a/doc/bugs/cannot___40__or_how__63____41___to_pass_socket_path_with_a_space_in_its_path_via_annex-ssh-options/comment_2_01cb7ba7d3c19863d39f6fac0d45d235._comment b/doc/bugs/cannot___40__or_how__63____41___to_pass_socket_path_with_a_space_in_its_path_via_annex-ssh-options/comment_2_01cb7ba7d3c19863d39f6fac0d45d235._comment new file mode 100644 index 0000000000..2c4f6c56c2 --- /dev/null +++ b/doc/bugs/cannot___40__or_how__63____41___to_pass_socket_path_with_a_space_in_its_path_via_annex-ssh-options/comment_2_01cb7ba7d3c19863d39f6fac0d45d235._comment @@ -0,0 +1,25 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 2""" + date="2020-06-24T16:24:29Z" + content=""" +Is this still something you need, or does `GIT_SSH_COMMAND` cover the use +case? + +The missing case would be, if you need remote.name.annex-ssh-options, +to pass the options only to that one remote and not others. + +I don't feel it would be a good idea for git-annex to try to parse quoted +options, etc. It would need to expose the config to the shell, the same way +it implements GIT_SSH_COMMAND`, by wrapping the original command in "sh +-c". + +That would need to be a different config than ssh-options, because +existing ssh-options might be broken by the change. Eg, if it is set to +something containing a "$", that would not be exposed to the shell +currently. + +So, while this is clearly a gap, I'd prefer to only implement a fix if it's +actually needed. Since the bug report is 3 years old and I've not gotten a +nudge, I'm guessing maybe not needed.. +"""]]