Cheng Zhao
67886cf513
Parse filters in API code
2015-12-11 21:14:13 +08:00
Cheng Zhao
79a627014c
Unify how listeners are handled
2015-12-11 21:02:44 +08:00
Cheng Zhao
9d406b695f
Simpily the code that fills |details|
2015-12-11 20:40:39 +08:00
Cheng Zhao
e295eb0de7
Fix memory leak
2015-12-11 20:11:59 +08:00
Cheng Zhao
467e3b25b2
EvenTypes => EventType
2015-12-11 20:11:22 +08:00
Cheng Zhao
62f4b25cf9
Allow passing null to webRequest
2015-12-11 19:13:56 +08:00
Cheng Zhao
98ba1a24db
Merge pull request #3640 from deepak1556/webrequest_api_patch
...
session: add webrequest api
2015-12-11 16:56:00 +08:00
Cheng Zhao
9495392a1a
Bump v0.36.0
2015-12-11 11:49:01 +08:00
Cheng Zhao
a6976b7d83
Merge pull request #3768 from atom/window-post-message-origin
...
Fix window.postMessage event.origin value
2015-12-11 11:18:37 +08:00
Kevin Sawicki
8401ece537
removeWindow -> remove
2015-12-10 17:22:05 -08:00
Kevin Sawicki
49ca7509c7
Reuse BrowserWindowProxy instances
2015-12-10 17:20:10 -08:00
Kevin Sawicki
9bc7c62588
Use source origin in window.postMessage event
2015-12-10 16:52:39 -08:00
Kevin Sawicki
afd736d9f9
Guard against null guest or embedder
...
Uncaught exceptions would occur when these were null and
the target origin was '*'
2015-12-10 15:51:15 -08:00
Robo
053c77d6f4
default session should be persistent
2015-12-11 00:27:15 +05:30
Robo
658accab94
fix pointer usage
2015-12-11 00:25:25 +05:30
Cheng Zhao
a05aa81570
Merge pull request #3701 from deepak1556/protocol_post_data_patch
...
protocol: provide upload data when available
2015-12-10 19:38:35 +08:00
Cheng Zhao
991c8b1aa6
Merge pull request #3733 from deepak1556/service_worker_scheme_patch
...
protocol: api to register schemes that can handle service worker
2015-12-10 19:29:51 +08:00
Cheng Zhao
b42695a0b5
win: Don't attach console for third party terms
...
Close #3692 .
2015-12-10 14:37:09 +08:00
Cheng Zhao
f4f4b9428d
Merge pull request #3750 from atom/fullscreen-menu-item
...
Don't add the "Enter Full Screen" menu item automatically
2015-12-10 11:54:26 +08:00
Cheng Zhao
c180607ef6
Merge pull request #3721 from atom/emit-process-exit-event-with-code
...
Emit process exit event with app exit code
2015-12-10 11:39:14 +08:00
Cheng Zhao
2d940b7df7
Don't add the "Enter Full Screen" menu item automatically
2015-12-10 11:27:41 +08:00
Cheng Zhao
388a18b265
Don't emit will-quit
event when calling app.exit
2015-12-10 11:22:55 +08:00
Kevin Sawicki
ea1479a651
Revert comment tweak
2015-12-09 18:20:53 -08:00
Kevin Sawicki
3e5caf7e54
Get exit code from within App::OnQuit
2015-12-09 18:19:51 -08:00
Kevin Sawicki
fc724b51e8
Move event forwarding back to init
2015-12-09 18:11:38 -08:00
Kevin Sawicki
92433be888
Include exit code with quit event
2015-12-09 18:09:59 -08:00
Kevin Sawicki
63c0095efb
Emit process exit event with app exit code
2015-12-09 14:40:53 -08:00
Robo
461ee49988
fix response headers modification
2015-12-09 20:14:18 +05:30
Robo
c5b5bbbeb2
add documentation
2015-12-09 20:14:18 +05:30
Robo
29f32c5ec7
support filtering event with url regex
2015-12-09 20:14:18 +05:30
Robo
13b5cab738
session: add webrequest api
2015-12-09 20:14:18 +05:30
deepak1556
fbb5091f94
provide option to set content for POST request with url_fetcher
2015-12-09 20:10:57 +05:30
deepak1556
940289639e
protocol: provide upload data when available
2015-12-09 20:10:57 +05:30
Cheng Zhao
8aee0f52e9
Merge pull request #3715 from atom/do-not-edit-menu-template
...
Do not modify the specified menu template
2015-12-09 12:13:07 +08:00
Cheng Zhao
774ba2a235
Merge pull request #3706 from billyct/master
...
support an api with SetIgnoreMouseEvents for osx
2015-12-09 12:00:16 +08:00
Robo
855d49100f
protocol: api to register schemes that can handle service worker
2015-12-09 03:11:58 +05:30
Cheng Zhao
836a8b1794
Simplify the desktopCapturer code
2015-12-08 13:49:26 +08:00
Cheng Zhao
51368952a2
Remove deprecated API usages
2015-12-08 12:58:39 +08:00
Cheng Zhao
d458b24945
Add desktopCapturer to electron
2015-12-08 12:44:55 +08:00
Cheng Zhao
04f7ceab73
Merge branch 'master' into desktop-capture-api
2015-12-08 12:43:44 +08:00
Cheng Zhao
407e88cbad
Update brightray
2015-12-08 12:08:33 +08:00
Cheng Zhao
0f2f9b5543
No need to use CommandDispatcher
2015-12-08 11:20:07 +08:00
Cheng Zhao
e8b5a6dedf
Merge pull request #3718 from atom/chrome47-linux
...
Port Chrome47 on Linux
2015-12-08 10:14:27 +08:00
Cheng Zhao
e78a02806e
Make it safe to use sendSync
2015-12-08 10:07:47 +08:00
Paul Betts
af28900189
Fix up Chrome47 changes
2015-12-07 13:27:05 -08:00
Kevin Sawicki
68d937ed47
🎨
2015-12-07 11:20:15 -08:00
Kevin Sawicki
96ef09742c
Directly assign submenu when constructor is Menu
2015-12-07 11:16:36 -08:00
Paul Betts
3931ebb7ef
Fix up Windows build errors
2015-12-07 10:02:06 -08:00
Kevin Sawicki
d5c740957f
🎨
2015-12-07 09:29:03 -08:00
Kevin Sawicki
26ac86c95c
Convert submenu when non-Menu is passed into MenuItem ctor
2015-12-07 09:28:48 -08:00
Cheng Zhao
d0be6c7411
Fix cppling warning
2015-12-07 22:44:35 +08:00
Cheng Zhao
647f151906
Fix the failing sendSync
2015-12-07 21:25:19 +08:00
Cheng Zhao
73e7773d84
Update to API changes of Chrome 47
2015-12-07 19:56:23 +08:00
billyct
5f092a6c65
support an api with SetIgnoreMouseEvents, and worked fine with osx
2015-12-06 10:14:54 +08:00
Cheng Zhao
e1d7ef7e24
Bump v0.35.4
2015-12-04 19:23:48 +08:00
Cheng Zhao
c8e2be7b28
Bump v0.35.3
2015-12-04 16:43:23 +08:00
Cheng Zhao
5e5ae81c53
'key of' is better than Object.keys
2015-12-04 11:40:35 +08:00
Cheng Zhao
973ae06f21
Destroy the native window in next tick
...
It fixes a possible crash when native code is iterating all windows
while the JavaScript code decides to destroy a window.
2015-12-04 11:35:04 +08:00
Cheng Zhao
2c6d232254
Don't add too much listeners in BrowserWindowProxy
2015-12-04 11:12:36 +08:00
Cheng Zhao
504d3d3088
Merge pull request #3670 from mixmaxhq/jeff/fix_window_open
...
Fix `window.open` not respecting the features string
2015-12-04 10:55:51 +08:00
Charlie Hess
f2797d2eab
Merge commit '58567834c7cb9c290ef48c9e8f54ae37246ef665' into web-contents-download-url
...
Conflicts:
atom/browser/api/atom_api_web_contents.cc
2015-12-03 10:31:51 -08:00
Cheng Zhao
48a11bd237
Weak map only needs to be deleted for once
2015-12-03 17:10:14 +08:00
Cheng Zhao
eb8426269f
Remove itself from the cleanup list when it is destroyed
2015-12-03 17:04:40 +08:00
Cheng Zhao
1e7c8c9fda
It is fine to leak a V8 handle on exit
2015-12-03 16:33:57 +08:00
Cheng Zhao
117b7462de
window.id is no longer available when window is closed
2015-12-03 16:17:10 +08:00
Cheng Zhao
a15f9fab5b
Use BuildPrototype to build prototype
...
This saves the step of manually keeping the global template object,
which is easy to forget then leak.
2015-12-03 16:04:46 +08:00
Cheng Zhao
6795bd1d96
Do not manually manage native resources
...
We should rely on the destructor to cleanup everything, instead of
putting them in the Destroy method.
2015-12-03 15:38:43 +08:00
Cheng Zhao
e5358d405a
Make sure V8 Function passed to native code are destroyed on UI thread
2015-12-03 11:24:33 +08:00
Charlie Hess
0d30a8d70c
Make downloadURL available on the webview tag.
2015-12-02 18:40:02 -08:00
Charlie Hess
c311c6cf1b
Add a DownloadURL method on WebContents.
2015-12-02 13:49:30 -08:00
Jeff Wear
225fe72d03
Ensure that window.open
does not override the child options
...
Fixes https://github.com/atom/electron/issues/3652 .
2015-12-02 12:00:51 -08:00
Cheng Zhao
615ce45849
win: Implement menu parameter
2015-12-02 19:58:10 +08:00
Cheng Zhao
3cdd0f35c7
mac: Implement menu parameter
2015-12-02 19:05:22 +08:00
Cheng Zhao
2fba05b5e7
Add menu
parameter for Tray.popUpContextMenu
2015-12-02 18:43:11 +08:00
Cheng Zhao
202475f5a9
Deprecating a property with method of same name causes trouble
...
Close #3511 .
2015-12-02 17:29:58 +08:00
Cheng Zhao
c493bec089
Make sure temp file will be cleaned up when base::Move fails
2015-12-02 11:36:29 +08:00
Cheng Zhao
c3645e3f95
Don't call Move if there is no need to move
2015-12-02 11:07:48 +08:00
Juan Cruz Viotti
a99c193cf2
🏁 Preserve file extension when extracting from asar
...
Currently, when calling `copyFileOut`, the original extension from the
file is lost, and a generic `*.tmp` is added instead.
This becomes problematic in the scenario where we use
`child_process.execFile` on a Windows Batch script that lives inside the
`asar` package.
Windows relies on the extension being present in order to interpret the
script accordingly, which results in the following bug because the
operating system doesn't know what do to with this `*.tmp` file:
```
Error: spawn UNKNOWN
```
Steps to reproduce:
1. Create a dummy batch script (test.bat):
```
@echo off
echo "Hello world"
```
2. Create an electron app that attemps to call this script with
`child_process.execFile`:
```js
var child_process = require('child_process');
var path = require('path');
child_process.execFile(path.join(__dirname, 'test.bat'), function(error, stdout) {
if (error) throw error;
console.log(stdout);
});
```
3. Package this small application as an asar archive:
```sh
> asar pack mytestapp app.asar
```
4. Execute the application:
```sh
> electron.exe app.asar
```
2015-12-01 14:55:58 -04:00
Cheng Zhao
e5974e44ed
Deprecate the page-title-set event
...
We have two names for the same event, page-title-updated wins.
2015-12-01 18:50:56 +08:00
Cheng Zhao
c95117fb22
Delay the page-title-set event to next tick
2015-12-01 18:34:58 +08:00
Cheng Zhao
83ee78451a
Emit event when title becomes empty
2015-12-01 17:53:13 +08:00
Cheng Zhao
8d20dda6d7
No need to override TitleWasSet in NativeWindow
2015-12-01 17:51:09 +08:00
Cheng Zhao
1b3eb1cc5d
Delay the did-fail-provisional-load event to next tick
...
Chrome is doing some stuff after the DidFailProvisionalLoad event, if we
call LoadURL at this time crash would happen.
2015-12-01 17:00:42 +08:00
Cheng Zhao
0f17a0163d
Put common constants in atom_constants
2015-12-01 16:21:15 +08:00
Cheng Zhao
e3ec1fe8ab
Add process.noAsar to turn off asar support
2015-12-01 13:09:37 +08:00
Paul Betts
7fd1db192b
Lint harder
2015-11-30 18:12:00 -08:00
Paul Betts
549da7fd91
Linting
2015-11-30 11:10:18 -08:00
Paul Betts
7cce3987eb
Add CORS header to file jobs
2015-11-30 11:08:45 -08:00
Paul Betts
65cb1488b0
Fix CORS header code to be cleaner
2015-11-30 11:08:44 -08:00
Paul Betts
7622bb40a9
Enable all origins via CORS header for custom schemes
...
This PR disables CORS for custom schemes, which allows you to serve Font
resources from custom schemes after using registerCustomSchemeAsSecure
2015-11-30 11:08:43 -08:00
Cheng Zhao
44e24ebf7a
Delete BridgeTaskRunner when main message loop is ready
2015-11-30 22:29:01 +08:00
Luke Westby
df9ecefe01
fix typo in "rotation" string
2015-11-29 12:22:53 -06:00
Cheng Zhao
62add3abcc
Bump v0.35.2
2015-11-27 22:23:19 +08:00
Cheng Zhao
cfdcfcbd80
Add executable permission in CopyFileOut
2015-11-27 22:06:37 +08:00
Cheng Zhao
42454b07d0
Merge pull request #3595 from jviotti/jviotti/fix/3512/execFile-override-exec-permissions
...
🐛 Fix missing execution permission bit in execFile override
2015-11-27 11:39:45 +08:00
Juan Cruz Viotti
585ff9062c
🐛 Fix missing execution permission bit in execFile override
...
Consider an electron application that uses `execFile` to run a script
that lives within the application code base:
```coffee
child_process = require 'child_process'
child_process.execFile __dirname + '/script.sh', (error) ->
throw error if error?
```
An application like this will fail when being packaged in an `asar` with
an following error:
```
Error: spawn EACCES
```
Electron overrides certain `fs` functions to make them work within an
`asar` package. In the case of `execFile`, the file to be executed is
extracted from the `asar` package into a temporary file and ran from
there.
The problem is that during the extraction, the original permissions of
the file are lost.
We workaround this by:
1. Extending `asar.stat` to return whether a file is executable or not,
which is information that's already saved in the `asar` header.
2. Setting execution permissions on the extracted file if the above
property holds true.
Fixes: https://github.com/atom/electron/issues/3512
2015-11-26 23:30:23 -04:00
Cheng Zhao
932cd92bf6
Fix wrong deprecation wrappers of BrowserWindow
2015-11-27 10:30:51 +08:00
Cheng Zhao
59402eb23f
Add ELECTRON_NO_ATTACH_CONSOLE env var
...
Close #1556 .
2015-11-26 21:11:28 +08:00
Cheng Zhao
b1e6d4f64c
Check ELECTRON_RUN_AS_NODE env var
2015-11-26 20:37:21 +08:00
Cheng Zhao
b0d4aa211d
Fix compatibility with activate-with-no-open-windows event
2015-11-26 13:57:48 +08:00
Cheng Zhao
6c1878d15b
mac: Clears the delegate when window is going to be closed
...
Since EL Capitan it is possible that the methods of delegate would get
called after the window has been closed.
Refs atom/atom#9584 .
2015-11-26 13:56:56 +08:00
Cheng Zhao
8ce19d8059
Merge pull request #3586 from atom/ipc-fasterer
...
Ensure calling webview.send will not block the renderer
2015-11-26 13:15:08 +08:00
Cheng Zhao
9c62be8fc9
Improve the deprecation notice for ipc module
...
Close #3577 .
2015-11-26 11:06:56 +08:00
Paul Betts
789380dfad
Ensure calling webview.send will not block the renderer
...
When the browser process is busy, calling webview.send (a method that appears
on its face to be non-blocking) will actually block, because most webview methods
are remoted to a guest view instance in the browser. Instead, define a few methods
which will instead send its call over an async IPC message.
2015-11-25 15:54:30 -08:00
Ryan Prichard
0f5a3baff4
Fix https://github.com/atom/electron/issues/3565 by adding a typeof
2015-11-24 16:49:52 -06:00
Cheng Zhao
fe88cb01fc
Merge pull request #3531 from deepak1556/fetch_job_nocontent_patch
...
protocol: handle http responses with no content
2015-11-24 15:45:07 +08:00
Cheng Zhao
e98d4c4a2e
Merge pull request #3549 from bengotow/fix-hide-others
...
Remove trailing colons from default menu roles
2015-11-23 17:44:06 +08:00
Cheng Zhao
360a747acf
Merge pull request #3542 from etiktin/fix_menu_item_using_deprcated_api
...
Fix menu-item using deprecated API
2015-11-23 17:11:44 +08:00
Cheng Zhao
634fef2508
Merge pull request #3537 from etiktin/make_BrowserWindow_options_optional
...
Make BrowserWindow options argument optional
2015-11-23 16:56:30 +08:00
Robo
167f11e797
protocol: handle http responses with no content
2015-11-23 01:07:14 +05:30
Ben Gotow
fbdef9e112
Remove trailing colons from default menu roles
...
`hideothers` and `unhide` had trailing colons which prevented them from being enabled / working in the default app. #3543
2015-11-22 09:08:35 -08:00
Eran Tiktin
6db6842c14
Fix menu-item using deprecated API
...
Some of the roles in menu-item use methods on BrowserWindow instead of
WebContents which outputs a deprecation warning.
I changed it to use the correct methods.
2015-11-22 01:13:57 +02:00
Eran Tiktin
18de28c3ff
Make BrowserWindow options argument optional
...
Resolves #3473
2015-11-21 06:22:19 +02:00
Eran Tiktin
9341b9d640
Make links to docs, point to the correct version
...
- Links to docs in the default app, pointed to the docs in the master
branch. I changed them to point to the docs that match Electron's
version.
- Added Electron's version to the header of the default app, so it will
be easier to figure out what version is currently running.
2015-11-21 02:26:59 +02:00
Cheng Zhao
29052b0498
Bump v0.35.1
2015-11-20 13:36:59 +08:00
Cheng Zhao
8e2faba8f7
Small style fix
2015-11-20 13:06:42 +08:00
Cheng Zhao
c1d6d68783
Merge pull request #3509 from bengotow/macosx-desktop-window
...
Support the "desktop" window type on Mac OS X
2015-11-20 13:02:05 +08:00
Cheng Zhao
784d2633a9
Make child_process.execFileSync support asar
2015-11-20 10:33:57 +08:00
Cheng Zhao
08c13cf446
Deprecate app.resolveProxy
...
There is now a public API to get default session, this helper is no
longer necessary.
2015-11-19 21:32:46 +08:00
Cheng Zhao
1392873cbc
Add session.defaultSession and remove app.defaultSession
...
The latter has never been a public API, no need to keep it.
2015-11-19 21:03:42 +08:00
Cheng Zhao
47d7d49d19
Add session module
2015-11-19 20:47:11 +08:00
Cheng Zhao
9a20b33d97
Add isDestroyed method for classes with destroy method
2015-11-19 17:08:16 +08:00
Ben Gotow
d427ae1030
Support the "desktop" window type on Mac OS X
...
Adds the desktop window type referenced in https://github.com/atom/electron/issues/2899 for compatiblity with the linux version. Note that on Mac OS X, the desktop window cannot receive input events (seems to be a limitation of being behind the desktop).
In this diff I also removed the `standardWindow` option from the docs, in favor of an additional `textured` value for window `type` on Mac OS X. The old `standardWindow` option continues to work, but seemed more confusing. If this seems like a bad idea, I can revert that change.
2015-11-19 00:39:45 -08:00
Cheng Zhao
87546bd4f8
Merge pull request #3479 from bengotow/tray-resizing
...
Fix sizing of Mac OS X tray icon after image change
2015-11-18 18:49:15 +08:00
Cheng Zhao
1ee69540b0
Merge pull request #3484 from bengotow/remote-errors
...
Improve exception messages from remote calls
2015-11-18 18:21:02 +08:00
Cheng Zhao
47d7f2c050
Fix cpplint warning
2015-11-18 11:45:15 +08:00
Cheng Zhao
9ca022c98a
docs: Update the certificate APIs
2015-11-18 11:35:26 +08:00
Cheng Zhao
c5bfac1969
Add session.setCertificateVerifyProc
2015-11-18 11:17:08 +08:00
Cheng Zhao
e432abfb42
Add certificate-error event
2015-11-18 10:39:25 +08:00
Cheng Zhao
341341bf28
Rename select-certificate to select-client-certificate
2015-11-18 10:10:21 +08:00
Cheng Zhao
9a0dc3bfd7
Add Delegate for AtomBrowserClient
2015-11-18 10:07:03 +08:00
Ben Gotow
1022179a1f
Improve exception messages from remote calls
...
Spent a while tracking down `Error processing argument -1`, caused by a missing param (`app.exit()` now takes an exit code.) Improve the rpc-server so that it prints the function name when possible, so it's much easier to identify which remote call is causing the error.
2015-11-17 17:36:37 -08:00
Ben Gotow
9c69416e32
Fix sizing of Mac OS X tray icon after image change
...
- Consolidate logic that applies view dimensions into a function
- Use `NSVariableStatusItemLength` instead of trying to sync status item width
- Use modern Obj-C syntax `@[], @{}` in a few places
- Recompute view bounds after updating image in `setImage:`
2015-11-17 13:43:55 -08:00
Cheng Zhao
961ee5a4d9
Rename verify-certificate to untrusted-certificate
2015-11-17 21:41:36 +08:00
Cheng Zhao
ebe66daa56
Emit verify-certificate only when default verifier fails
2015-11-17 21:36:36 +08:00
Cheng Zhao
e3517b701e
Create a new CertVerifierRequest for each request
...
It greatly simplifies the code.
2015-11-17 19:44:55 +08:00
Cheng Zhao
ea1e4160ea
Move AtomSSLConfigService to atom/browser/net
2015-11-17 19:05:38 +08:00
Cheng Zhao
37f355724a
Move AtomCertVerifier to atom/browser/net
2015-11-17 19:03:09 +08:00
Cheng Zhao
217311ef21
No need to use weak reference
...
Ref-counting manages everything.
2015-11-17 19:00:33 +08:00
Cheng Zhao
24f573eceb
Merge pull request #3344 from deepak1556/certificate_verifier_api_patch
...
session: api to allow handling certificate verification
2015-11-17 18:53:35 +08:00
Robo
92c3ee8e16
use delegate to notify verification requests
2015-11-16 20:45:49 +05:30
Cheng Zhao
202d2eeb8a
Merge pull request #3454 from brenca/keyboard-pr
...
Adding further options to specify the character being sent with sendInputEvent (keyboard)
2015-11-16 22:13:09 +08:00
Heilig Benedek
14740eeb8a
Merging keyCode and keyIdentifier and adjusting the docs accordingly
2015-11-16 14:51:26 +01:00
Cheng Zhao
1d800d5e26
Merge pull request #3432 from deepak1556/navigation_patch
...
browser: fix reloadignoringcache api
2015-11-16 20:55:16 +08:00
Cheng Zhao
9e70d35afa
Bump v0.35.0
2015-11-16 16:48:51 +08:00
Heilig Benedek
bb6d7d1498
Added the option to KeyboardEvent
to specify the sent character by it's name (if it can't be sent via the keyCode
parameter)
2015-11-16 04:54:21 +01:00
Heilig Benedek
9f9436d6dc
Moved scope creation before the allocation of the buffer in FrameSubscriber
2015-11-14 23:59:38 +01:00
Robo
2a7f874373
browser: fix reloadignoringcache api
2015-11-14 02:25:23 +05:30
Cheng Zhao
94e24abb99
Use the new style remote module in Electron
2015-11-13 22:22:25 +08:00
Cheng Zhao
b925ac0056
Send sync message to get list of modules
2015-11-13 22:15:16 +08:00
Cheng Zhao
099278855c
Simplify how remote.require('electron') is optimized
2015-11-13 21:54:56 +08:00
Cheng Zhao
9bf0a8647e
Make it easier to use remote
2015-11-13 21:52:27 +08:00
Cheng Zhao
e76a7f7b7d
Fix typo, tray => Tray
2015-11-13 21:52:05 +08:00
Cheng Zhao
e8ffd24e4e
Rename the "clicked" event to "click" in Tray
2015-11-13 16:41:33 +08:00
Cheng Zhao
fbb8e61958
Replace "Url" in API names with "URL"
2015-11-13 16:03:40 +08:00
Cheng Zhao
860c46b3c1
Separate options from switches
...
On Windows the case sensitivity of command line switches are ignored, so
--nodeIntegraion will become --nodeintegration.
We should separate options from switches so we use "nodeIntegraion" in
options, while passing "--node-integration" in command line.
2015-11-13 14:05:49 +08:00
Cheng Zhao
d3caea91b0
Add paths from chrome_paths
2015-11-13 13:05:16 +08:00
Cheng Zhao
996a3c2a35
Merge branch 'content_tracing_patch' of https://github.com/deepak1556/atom-shell into deepak1556-content_tracing_patch
2015-11-13 12:29:18 +08:00
Cheng Zhao
78934dceb9
Cleanup and docs for the --js-flags
2015-11-13 12:22:08 +08:00
Cheng Zhao
0321a77a94
Merge pull request #3412 from skhameneh/master
...
Add --js-flags support for main thread.
2015-11-13 12:10:59 +08:00
Cheng Zhao
f2439cefd0
linux: Don't throw error when using autoUpdater
...
Fix #3194 .
2015-11-13 10:58:10 +08:00
Robo
bfaa50a79e
retrieve download directory using on linux
2015-11-13 07:44:05 +05:30
Cheng Zhao
852500e5fa
Fix a few places using old style require
2015-11-13 09:38:22 +08:00
Robo
37e6e6fab7
emit verify-certificate event for handling verification
2015-11-13 06:44:49 +05:30
Robo
bb439c5f1c
browser: check window liveness before setting title
2015-11-13 02:43:21 +05:30
Robo
3d5437e0a4
tracing: fix docs and allow null values in file path conversion fromv8
2015-11-13 02:36:38 +05:30
Robo
d072e61282
session: api to allow handling certificate verification
2015-11-13 01:27:30 +05:30
Cheng Zhao
edd807d227
Fix a typo
2015-11-12 22:56:18 +08:00
Cheng Zhao
2ca5a33d28
Add electron.hideInternalModules
2015-11-12 21:46:03 +08:00
Cheng Zhao
c649c4cf4f
Rename the env to ELECTRON_HIDE_INTERNAL_MODULES
2015-11-12 21:37:44 +08:00
Cheng Zhao
8b2942c279
Optimize remote.require('electron')
2015-11-12 20:30:40 +08:00
Cheng Zhao
1d1f911b09
Use require('electron') in Electron's code
2015-11-12 20:29:30 +08:00
Shawn K
fb5beb9af5
Add --js-flags support for main thread.
...
Allow use of flags that must be set before V8 is initialized, such as
"--harmony_proxies", e.g. --js-flags="--harmony_proxies
--harmony_collections"
2015-11-12 01:48:23 -08:00
Cheng Zhao
f9d7e7ce55
Add ELECTRON_DISABLE_OLD_STYLE_MODULES env
2015-11-12 17:02:04 +08:00
Cheng Zhao
c2c09daa23
Add "electron" module
2015-11-12 16:40:27 +08:00
Cheng Zhao
0a5b234e3d
Merge pull request #3354 from nishanths/master
...
Add drag-entered and drag-exited events to Tray
2015-11-11 22:44:05 +08:00
Cheng Zhao
60ec1ca3f7
Use new styles of browserWindow options
2015-11-11 10:37:34 +08:00
Cheng Zhao
ba457681b2
Avoid storing unrelated things in WebContentsPreferences
2015-11-11 10:37:34 +08:00
Cheng Zhao
b807685453
Deep copy the options
...
Otherwise a window's options is possible to be affected by others.
2015-11-11 10:37:34 +08:00
Cheng Zhao
960d325a58
Be compatible with old BrowserWindow options
2015-11-11 10:37:34 +08:00
Cheng Zhao
5cca947f4d
Remove unneeded override code
2015-11-11 10:37:34 +08:00
Cheng Zhao
737e22b003
Use minWidth style for options instead of min-width
2015-11-11 10:37:34 +08:00
Cheng Zhao
d37aa8bed9
Reorder switches
2015-11-11 10:37:34 +08:00
Nishanth Shanmugham
d1e8e71e3f
Tray: Add drag-end and drop events
2015-11-10 10:02:50 -06:00
Nishanth Shanmugham
f98147ea01
Tray: Rename events to drag-enter and drag-leave
...
Previously, the names were drag-entered and drag-exited. The new names mirror the HTML Drag and Drop event names
2015-11-10 09:27:39 -06:00
Levin Rickert
08e245e3dc
Fix typo
2015-11-10 12:42:05 +01:00
Cheng Zhao
d234f10177
Implement event.sender for ipcRenderer
2015-11-10 16:59:08 +08:00
Cheng Zhao
751af25f37
Use ipcMain in Electron's code
2015-11-10 16:04:34 +08:00
Cheng Zhao
844cea8f21
Deprecate ipc module for ipcMain
2015-11-10 15:41:24 +08:00
Cheng Zhao
6515a445a0
Use ipcRenderer in Electron's code
2015-11-10 15:29:43 +08:00
Cheng Zhao
828d911ed1
Deprecate ipc module for ipcRenderer
2015-11-10 15:12:07 +08:00
Cheng Zhao
91c4ed26fc
Print warnings for deprecated APIs
2015-11-09 21:51:30 +08:00
Cheng Zhao
f0bd28ca8d
Do not turn off deprecation notice by default
...
It is v4 now, people should be punished if they are still using
deprecated Node.js APIs.
2015-11-09 21:19:16 +08:00
Cheng Zhao
89ff62b1b5
Add "deprecate" module
2015-11-09 21:19:16 +08:00
Cheng Zhao
312a79165b
Bump v0.34.3
2015-11-06 21:37:37 +08:00
Cheng Zhao
d70706f876
Make sure handles of callbacks are releases on exit
...
Some callbacks are stored in native resources that not managed by
JavaScript, so when those resources are destroyed the JavaScript context
may already be destroyed, and releasing callbacks then would result in
crash.
2015-11-06 21:00:32 +08:00
Cheng Zhao
acf4372cf7
win: Add ELECTRON_DEFAULT_ERROR_MODE env
...
It is useful to help debugging crashes without opening debugger.
2015-11-06 20:25:20 +08:00
Cheng Zhao
863199348f
Make process.exit() quit gracefully
...
Instead of abrupting the whole program immediately, we should close all
windows and release all native resources gracefully on exit. This avoids
possible crashes.
Fix #3350 .
2015-11-06 20:25:20 +08:00
Nishanth Shanmugham
8a296f82a0
Tray: Remove extra qualification in header
2015-11-05 19:02:24 -06:00
Nishanth Shanmugham
818892d474
Tray: Add drag-entered and drag-exited events
2015-11-05 18:46:49 -06:00
Cheng Zhao
2505ebb9a6
win: Guard against failure of RtlAddFunctionTable
...
On some machines this call will fail and CHECK will abort the
application.
2015-11-05 22:00:40 +08:00
Cheng Zhao
47649ffd17
win: Fix calling showItemInFolder in renderer process
2015-11-05 20:47:27 +08:00
Tyler Gibson
4ff5ce4d6d
Fixing MoveItemToTrash behavior in Windows
...
Modifying MoveItemToTrash for Windows to actually verify file can be
moved to a drive's recycle bin before attempting to delete it.
PR: #3337 .
2015-11-05 20:42:30 +08:00
Ryan Molden
4ce840d8e6
Re-enable accessibility in Electron on Windows
...
In conjunction with commit 7c41f0e
.
2015-11-05 19:49:48 +08:00
Cheng Zhao
d56b34de3b
Make sure all native resources get freed on exit
2015-11-04 18:21:03 +08:00
Cheng Zhao
07c55f321f
Destroy JS env immediately after running destruction callbacks
2015-11-04 17:31:10 +08:00
Cheng Zhao
84410a7e1c
mac: Destroy the app delegate before running destruction callbacks
...
Otherwise users might be able to access wrapper functions after they are
destroyed.
2015-11-04 17:23:27 +08:00
Cheng Zhao
75f49477ca
Cleanup wrapper function when app has done quitting
...
The app may still do something when quitting, we need to make sure the
wrapper function is still there at that time.
2015-11-04 16:54:36 +08:00
Cheng Zhao
441cc3e57e
Style fix
2015-11-04 16:50:19 +08:00
mgarciaisaia
4013b652ff
🏁 🐛 Buffer overflows in tooltips
...
Fixes #3290 .
2015-11-04 15:34:58 +08:00
Joao Moreno
7c41f0e0e3
remove kDisableLegacyIntermediateWindow switch set
2015-11-03 16:12:01 -08:00
Cheng Zhao
1b165559f5
win: Use electron.app.$1 as default user model id
...
This is to keep compatibility with old apps that don't set app user
model id explicitly.
2015-11-03 15:50:43 +08:00
Cheng Zhao
7b47b70c9e
Fix building on POSIX
2015-11-03 15:30:37 +08:00
Cheng Zhao
9047f81835
win: Set app user model ID in one place
...
Fix #3297 .
Fix #2573 .
2015-11-03 15:09:31 +08:00
Cheng Zhao
7c7a7b96de
win: Do not set app user model id by default
...
When user drags exe file into taskbar directly the pinned icon will not
has an app user model id, so if we set app user model id in the
application two icons will show in the taskbar.
For apps installed with a installer it is not a problem since the
shortcut icon will be created with app user model id, but we should also
keep the ability to make portable apps work out of box.
Fix #3303 .
2015-11-03 14:55:43 +08:00
Cheng Zhao
9236adfbf5
Translate menu template directly in C++
2015-11-02 23:31:44 +08:00
Cheng Zhao
56e6b28370
Merge pull request #3288 from deepak1556/flash_context_menu_pathc
...
browser: handle flash context menu request
2015-11-02 21:20:44 +08:00
Cheng Zhao
f7c0418bd8
Ignore case for type of savePage
2015-11-02 21:19:00 +08:00
Cheng Zhao
647a0c4e2b
Code cleanup for remote module
2015-11-02 20:28:01 +08:00
Max Claus Nunes
bbb5aef5d2
Improve error handling from remote
...
This way copy all properties available in the error object and keep the real stack trace
2015-10-31 21:20:54 -02:00
Robo
c969052f12
browser: handle flash context menu
2015-11-01 01:13:17 +05:30
Cheng Zhao
cb91d4487b
Clean up the code handling renderer callback
2015-10-31 15:00:06 +08:00
Cheng Zhao
323ab92299
Merge pull request #3251 from deepak1556/remote_callback_patch
...
remote: track listeners on browser side
2015-10-31 14:18:58 +08:00
Robo
2c59f4567e
use webcontents id to identify callbacks
2015-10-30 19:51:19 +05:30
Antonio Scandurra
9c69877421
Allow v8 to optimize fs.readFileSync
2015-10-30 10:30:27 +01:00
Cheng Zhao
21a7c459d8
Bump v0.34.2
2015-10-30 14:50:57 +08:00
Robo
3a154ab8ea
add line and column values to callback id
2015-10-29 21:21:30 +05:30
Robo
ac4df34ecd
create binding to idweakmap
2015-10-29 17:51:56 +05:30
Robo
eae7c840b7
use idweakmap for holding callbacks in browser
2015-10-29 17:51:56 +05:30
Robo
62d15953ff
remote: track listeners for browser side
2015-10-29 17:51:56 +05:30
Cheng Zhao
917b33dbe7
Small code cleanup
2015-10-29 10:55:08 +08:00
Cheng Zhao
0f89f67a84
Merge pull request #3254 from templateK/master
...
Fix remove boolean parameter at IsSwitchEnabled function
2015-10-29 10:54:56 +08:00
Cheng Zhao
bf9e6ba11e
Merge pull request #3256 from omrilitov/master
...
Use WPARAM as uint64_t and LPARAM as int64_t
2015-10-29 10:41:11 +08:00
Omri Litov
ef038257d1
Returns buffer instead of WPARAM and LPARAM
2015-10-29 03:00:44 +02:00
Omri Litov
f22837523f
Use WPARAM as uint64_t and LPARAM as int64_t
2015-10-28 21:54:50 +02:00
taemu
16eafdb0ce
Fix remove boolean parameter at IsSwitchEnabled function
2015-10-29 03:22:08 +09:00
Cheng Zhao
51ba37440d
Guard against multiple calls of auth
2015-10-28 21:20:08 +08:00
Cheng Zhao
569e87035a
Also emit "login" on WebContents
2015-10-28 21:00:39 +08:00
Cheng Zhao
f40a3f72d7
Converted callback can only be called for once
2015-10-28 20:44:46 +08:00
Cheng Zhao
4eac6b31b1
Also pass "webContents" in "login" event
2015-10-28 20:23:18 +08:00
Cheng Zhao
131531219e
Pass auth_info and request in "login" event
2015-10-28 20:13:06 +08:00
Cheng Zhao
d05255179a
Add login event for "app" module
2015-10-28 19:54:59 +08:00
Cheng Zhao
54dad72d92
Don't leak TranslaterHolder
2015-10-28 19:54:59 +08:00
Cheng Zhao
9847747736
Use the callback converter in JsAsker
2015-10-28 19:54:59 +08:00
Cheng Zhao
3881ad1c4b
Don't leak FunctionTemplate when converting C++ callback
2015-10-28 19:54:59 +08:00
Cheng Zhao
9df89cf79b
Add dummy LoginHandler
2015-10-28 19:54:59 +08:00
Cheng Zhao
b86267aa3b
Use uint64_t instead of LPARAM
...
LPARAM is defined to differnt types on differnt machines with different
SDKs, so there is no way to represent it on all platforms safely, using
uint64_t seems to be the only safe choice.
2015-10-28 19:51:24 +08:00
Cheng Zhao
5fd310c75f
Add converter for LPARAM
2015-10-28 19:43:05 +08:00
Cheng Zhao
c9b53a6e8b
Merge pull request #3240 from atom/reland-win-remove-wildcard-extension
...
Reland win remove wildcard extension
2015-10-27 20:52:43 +08:00
Cheng Zhao
142f380376
Merge pull request #3231 from omrilitov/master
...
Hooking windows messages
2015-10-27 20:48:19 +08:00
Haojian Wu
f69bafd48a
Win: Fix adding '.*' to filename in callback.
2015-10-27 20:15:43 +08:00
Haojian Wu
fa24e15d8b
Win: Remove adding '*.*' to file name in a save dialog.
2015-10-27 20:15:20 +08:00
Omri Litov
e355532d27
Change windows messages api to hook instead of emitter
2015-10-27 14:00:08 +02:00
Cheng Zhao
dacd921a04
Revert "Win: Remove adding default file filter(*.*) in a save dialog."
...
This reverts commit 00493f64b7
.
2015-10-27 14:58:44 +08:00
Cheng Zhao
3042f604cc
Merge pull request #3234 from atom/win-remove-default-filter
...
Win: Remove adding default file filter(*.*) in a save dialog.
2015-10-27 14:30:35 +08:00
Haojian Wu
00493f64b7
Win: Remove adding default file filter(*.*) in a save dialog.
2015-10-27 13:10:34 +08:00
Omri Litov
edbebf84b9
Added browser-window event 'message'
2015-10-27 03:12:01 +02:00
Gohy Leandre
b29a8c94b9
Add extra headers option to webContents.loadUrl
2015-10-26 22:18:16 +01:00
Cheng Zhao
f399f50e9e
Fix calling showItemInFolder in renderer
...
The remote method always assumes the existence of the remote object but
doesn't keep a reference to it, so if we only keep the reference of a
remote method we will get into troubles once the remote object is
garbage collected.
We should probably fix this in remote module, but since most things are
already working quite good, I'm using the work-around for now.
Fix #3139 .
2015-10-26 16:48:27 +08:00
Robo
70fe169b0f
nativemate: use maybe version of v8::Function::Call to avoid exceptions
2015-10-26 10:59:40 +05:30
Cheng Zhao
30ec7fdeed
Bump v0.34.1
2015-10-23 20:32:02 +08:00
Cheng Zhao
fae2c7bc7a
win: Make auto-updater really work
...
Apparently that PR was never tested.
2015-10-23 19:41:54 +08:00
Cheng Zhao
aeafc46ded
Keep compatibility with old API style
2015-10-23 15:50:55 +08:00
Cheng Zhao
f89d28a63e
Simplify the auto-updater implementations
...
We used to use Sparkle on OS X, and the design was reserved to be
extended to all platforms, which are all wrong now.
2015-10-23 15:40:56 +08:00
Cheng Zhao
d74ef5c078
Move implementation of auto-updater on OS X to another file
2015-10-23 15:13:24 +08:00
Cheng Zhao
85c84a0eb0
Emit Date object in C++ directly
2015-10-23 14:58:19 +08:00
Cheng Zhao
a3f62da615
Fix passing Date object in remote
...
Close #2017 .
2015-10-23 14:51:41 +08:00
Cheng Zhao
95fe4beda8
Pass real Error object in error event
2015-10-23 14:37:35 +08:00
Cheng Zhao
d5c964c68c
Fix passing Error object in remote
...
Closes #3089
2015-10-23 14:37:28 +08:00
Cheng Zhao
07adbc8e8a
Merge pull request #1984 from patrickdet/windows-auto-updater
...
Windows Auto Updater
2015-10-23 13:54:29 +08:00
Cheng Zhao
e36d455d51
Add setBackgroundColor method
2015-10-23 11:35:33 +08:00
Cheng Zhao
4a6134f3f7
win: Set native window's background color
2015-10-23 11:17:14 +08:00
Cheng Zhao
6182e4ce81
Merge pull request #3179 from deepak1556/session_api_patch
...
session: allow setproxy to use external pac script
2015-10-23 10:36:37 +08:00
Cheng Zhao
79d4d52172
Merge pull request #3178 from deepak1556/node_debugger_patch
...
debugger: expose v8debug
2015-10-23 10:36:06 +08:00
Robo
e9a5d05b27
session: allow setproxy to use external pac script
2015-10-22 23:03:47 +05:30
Cheng Zhao
6bfe06ec4e
Pass original argv in callback
2015-10-22 19:02:21 +08:00
Robo
7b5a1b06ba
debugger: expose v8debug
2015-10-22 16:20:48 +05:30
Cheng Zhao
afc1fff792
Remove the need for ProcessSingletonStartupLock
2015-10-22 17:12:09 +08:00
Cheng Zhao
70e74d05e0
Revert "app.makeSingleInstance is not available on OS X"
...
This reverts commit bcb78ebc00
.
2015-10-22 17:03:18 +08:00
Cheng Zhao
f9d797d1ea
win: Fix compiler warning
2015-10-22 16:55:54 +08:00
Cheng Zhao
e14fd62f46
Correctly handle notification callback when shutting down
...
When returning false in the notification callback the ProcessSingleton
will assume current process is quitting, we should met its expectation.
2015-10-22 16:24:35 +08:00
Cheng Zhao
ca876e424b
Fix crash when calling app.quit() before app is ready
2015-10-22 16:06:37 +08:00
Cheng Zhao
05c6300329
Don't discard tasks in BridgeTaskRunner
2015-10-22 15:54:27 +08:00
Cheng Zhao
bcb78ebc00
app.makeSingleInstance is not available on OS X
2015-10-22 15:02:32 +08:00
Cheng Zhao
310954713f
Simplify the usage of singleton
2015-10-22 14:59:12 +08:00
Cheng Zhao
acb2c099f6
Make sure current task runner is available
...
When calling makeSingleInstance we have to ensure current task runnder
is available, otherwise crash may happen.
2015-10-22 14:56:57 +08:00
Cheng Zhao
04d3eed60e
Merge pull request #3145 from atom/single-instance
...
Implement Single-Instance for Windows / Linux
2015-10-22 14:18:31 +08:00
Robo
9411508d3e
browser: option to set window background color
2015-10-22 09:54:29 +05:30
Paul Betts
de66888051
Remove atom_process_singleton, just use the Chrome classes directly
2015-10-21 13:38:39 -07:00
Paul Betts
d020a7dc86
cpplinting
2015-10-21 13:17:56 -07:00
Paul Betts
938d68eb36
Move all the browser.cc code over to atom_api_app.cc
2015-10-21 13:04:50 -07:00
Paul Betts
658a9872fb
Only cleanup if we are the main process
2015-10-21 12:29:21 -07:00
Paul Betts
a160891a27
If a user calls makeSingleInstance more than once, just ignore it
2015-10-21 12:29:00 -07:00
Paul Betts
38d6ff79c8
Need to free this early or get a SIGSEGV on Linux
2015-10-21 11:06:42 -07:00
Cheng Zhao
444f461269
Fix memory corruption when cleaning timer
2015-10-21 20:46:16 +08:00
Cheng Zhao
2d410ede48
Initialize things in the same sequence with main process
2015-10-21 16:24:54 +08:00
Cheng Zhao
d092c6acc9
osx: Implement draggable region with mouseDownCanMoveWindow
...
Previously we implemented draggable region by tracking mouse position,
it is buggy and causing some problems. But it is interesting that until
this didn't cause troubles until recently.
2015-10-21 08:54:46 +08:00
Paul Betts
e5094fff3e
Since setting up process_singleton is now conditional, its cleanup / unlock must be too
2015-10-20 17:27:28 -07:00
Paul Betts
4a7a09aae1
Infinite Linting
2015-10-20 15:00:10 -07:00
Paul Betts
f759471e01
Update to use Chromium sources
2015-10-20 14:36:01 -07:00
Paul Betts
b6f1729acd
Move initialization of Single Instance into MakeSingleInstance call
2015-10-20 13:38:57 -07:00
Paul Betts
5d4c29a1e3
Ditch double-callback, just use mate directly
2015-10-20 13:27:34 -07:00
Paul Betts
a2eedcc027
Wire up the final callback to JS
2015-10-20 13:17:26 -07:00
Paul Betts
63417bc975
I am not good at C++ at all
2015-10-20 13:17:25 -07:00
Paul Betts
4a4b829cfc
Fix callback handle usage
2015-10-20 13:17:25 -07:00
Paul Betts
50fab0733b
At Browser ctor time, DIR_USER_DATA is unset, wait
2015-10-20 13:16:49 -07:00
Paul Betts
b02f89e63b
Typo
2015-10-20 13:16:49 -07:00
Paul Betts
cdd51fa96d
Wire everything up
2015-10-20 13:16:48 -07:00
Paul Betts
c38f2fcf75
Add a native mate converter for command lines
2015-10-20 13:15:12 -07:00
Paul Betts
7491ae4000
Set up Browser to create the process singleton
2015-10-20 13:15:12 -07:00
Paul Betts
4d5495a0a0
Bring in chrome_process_singleton but nuke the active dialog bits
2015-10-20 13:15:11 -07:00
Paul Betts
717aba9631
Create a dummy method in app that we'll twerk
2015-10-20 13:15:11 -07:00
Paul Betts
8288a22458
Fix build against old OneShotTimer
2015-10-20 13:14:08 -07:00
Paul Betts
88dd1480cc
Get POSIX mostly compiling
2015-10-20 13:14:08 -07:00
Paul Betts
c46579b1ac
Remove a bunch of stuff we don't need in process_singleton_win
2015-10-20 13:14:07 -07:00
Paul Betts
1b3363c811
Get process finder working
2015-10-20 13:14:07 -07:00
Paul Betts
daa65a138b
Come Correct with headers
2015-10-20 13:14:06 -07:00
Paul Betts
d3b23a2032
Renames to avoid confusion, add file
2015-10-20 13:14:06 -07:00
Paul Betts
05b22b9372
Import process_finder verbatim
2015-10-20 13:14:05 -07:00
Paul Betts
ff2d9759d5
Start to remove / rearrange some header files
2015-10-20 13:14:05 -07:00
Paul Betts
27fa5d880a
Copy some relevant files over from Chromium
2015-10-20 13:14:04 -07:00
Patrick Detlefsen
db3bc28937
PR feedback adressed
2015-10-20 19:25:03 +02:00
Cheng Zhao
a7a399dcd8
Code cleanup
2015-10-20 13:52:39 +08:00
Cheng Zhao
370cb5b5e1
Merge pull request #3120 from atom/ntlm-part-two
...
Optionally allow NTLM authentication for all domains
2015-10-20 13:48:12 +08:00
Cheng Zhao
fb8ca33d5d
Add ELECTRON_ENABLE_STACK_DUMPING env
...
It enables in-process stack dumping, which is convenient for debugging.
2015-10-20 13:02:48 +08:00
Cheng Zhao
2c4a24d26b
Add ELECTRON_ENABLE_LOGGING env
...
It is the same with --enable-logging.
2015-10-20 13:00:28 +08:00
Cheng Zhao
bb8bb3dbea
Merge pull request #3147 from deepak1556/cipher_suite_disable_patch
...
browser: flag to disable specified cipher suites
2015-10-20 10:29:49 +08:00
Robo
9f8479e9d8
browser: flag to diable specified cipher suites
2015-10-20 02:51:56 +05:30
Paul Betts
e3535d664b
Fixed linter issues but now the code looks awful
2015-10-19 13:12:17 -07:00
Paul Betts
b3c7e2bf33
Plumb the method back
2015-10-19 13:07:14 -07:00
Paul Betts
489090fcf8
Set up our browser context to use new delegate-based API
2015-10-19 13:03:20 -07:00
Cheng Zhao
de3e16ce60
Merge pull request #3129 from brandoncash/fix-tray-notify-typo
...
Fix: tray NotfiyDropFiles typo
2015-10-19 19:11:26 +08:00
Haojian Wu
9c861b9ad3
Fix always passing the first result to renderer when the API is called multiple
...
time at once.
2015-10-19 18:07:35 +08:00
Cheng Zhao
72e0da069c
Merge pull request #3132 from princejwesley/issue-readFileSync
...
Fix: honor fs.readFileSync contract for empty packed asar file
2015-10-19 16:59:47 +08:00
Cheng Zhao
0d9e0a38c0
Merge pull request #3128 from atom/fix-save-page-position
...
Fix: 'savePage API' saves external resources in a wrong directory.
2015-10-19 16:40:45 +08:00
Prince J Wesley
810af2f95d
🐛 Honor fs.readFileSync contract for empty packed asar file
2015-10-19 08:43:50 +05:30
Haojian Wu
fb4efec55d
Add options check.
...
This patch avoids main process never response back to renderer if the options is
invalid.
2015-10-19 11:06:56 +08:00
Brandon Cash
60b14d03e9
Fix: tray NotfiyDropFiles typo
2015-10-18 00:32:13 -05:00
Haojian Wu
49d25d0069
Fix: savePage API saves external resources in a wrong directory.
2015-10-18 11:28:05 +08:00
Haojian Wu
214f8477b3
Fix some typos.
2015-10-17 19:28:14 +08:00
Paul Betts
a3fc25110e
Linter fixes
2015-10-16 16:55:28 -07:00
Paul Betts
5ae6bd2ef4
Wire it up
2015-10-16 16:46:05 -07:00
Paul Betts
7ac643d5f8
Create a new method on App to override URL Security Manager's decisions wrt NTLM
2015-10-16 16:45:54 -07:00
Cheng Zhao
d9fdfb711f
Clean up CallbackRegistry
...
There were some ancient code there.
2015-10-16 20:25:30 +08:00
Cheng Zhao
4871ea715c
Merge pull request #3103 from bengotow/bengotow/debug-release
...
Allow "released callback" errors to be traced to remote calls
2015-10-16 20:21:46 +08:00
Cheng Zhao
22e9c2f4eb
Bump v0.34.0
2015-10-16 18:53:25 +08:00
Cheng Zhao
c371c713a9
Merge pull request #3108 from atom/mas-build
...
Prepare for MAS build and add a guide
2015-10-16 18:51:45 +08:00
Cheng Zhao
776077c8de
Bump v0.33.9
2015-10-16 17:42:55 +08:00
Cheng Zhao
16b9f8995d
Revert "Go back to using node's console.* and std*.write"
...
This reverts commit 4e8db2c3be
.
It seems that we still have problems with Node.js's console.* calls, I'm
reverting this for now unitl we get a solution.
Fixes #3100 .
2015-10-16 17:38:11 +08:00
Cheng Zhao
7bdbe45c91
subpixel-font-scaling option is removed
2015-10-16 15:01:28 +08:00
Cheng Zhao
0e94ccb72b
Merge pull request #3080 from atom/save-page-api
...
Implement webContents.savePage API.
2015-10-16 09:52:43 +08:00
Ben Gotow
aeb24b784d
Allow "released callback" errors to be traced to remote calls
2015-10-15 18:46:59 -07:00
Haojian Wu
facd0fbc08
Implement webContents.savePage API.
2015-10-16 09:23:08 +08:00
Cheng Zhao
f5c25d6277
win: Only install breakpad hook when crash-reporter is used
2015-10-15 18:25:07 +08:00
Cheng Zhao
d90b598125
win: Hook up V8 to breakpad
...
This fixes the crashes happens from V8 not caught by the crash reporter,
for more context, see http://code.google.com/p/v8/issues/detail?id=3597 .
Fix #2365 .
2015-10-15 16:36:30 +08:00
Cheng Zhao
55d5660ddb
win: Make the event in crash service signaled by default
...
Otherwise it seems to block the crash client on some machines.
Fix #2769 .
2015-10-15 16:36:29 +08:00
Cheng Zhao
11a49bba35
win: Fix "enable-larger-than-screen" option spec
2015-10-15 16:36:29 +08:00
Cheng Zhao
6aec8b092c
views: Fix crash when setSizeConstrains is called early
2015-10-15 16:36:28 +08:00
Cheng Zhao
f52c4af605
win: Don't output newline except for main process
2015-10-15 12:44:55 +08:00
Cheng Zhao
74d389b2b0
Bump v0.33.8
2015-10-14 12:36:03 +08:00
Cheng Zhao
51335934c1
mac: Set CFBundleExecutable for Electron Framework
2015-10-14 11:54:59 +08:00
Cheng Zhao
d6842751bb
mac: Don't specify CFBundleExecutable in framework
2015-10-14 11:54:59 +08:00
Cheng Zhao
96c15f19e3
mac: Set LSApplicationCategoryType in Info.plist
2015-10-14 11:54:58 +08:00
Cheng Zhao
9e51ff2b4b
mac: Set CFBundleShortVersionString in Info.plist
2015-10-14 11:54:26 +08:00
Cheng Zhao
df7a9b80b1
Fix linking error
2015-10-14 11:53:53 +08:00
Cheng Zhao
7b57a945f8
mac: Set process.mas to true for MAS build
2015-10-14 11:53:52 +08:00
Cheng Zhao
b62e3554dc
mac: Disable auto updater in MAS build
2015-10-14 11:53:52 +08:00
Cheng Zhao
a9f5667899
mac: Disable crash reporter for MAS build
2015-10-14 11:53:52 +08:00
Robo
5ff97c686a
nativemate: handle binary types in v8 value conversion
2015-10-13 01:13:59 +05:30
Eran Tiktin
cb903a09c0
Block all internal logs when running without --enable-logging
2015-10-10 20:44:22 +03:00
Eran Tiktin
4e8db2c3be
Go back to using node's console.* and std*.write
...
It seems that whatever issues we had with using the original
implementation of node for `console.*` calls and for
`process.std*.write` on Windows were solved.
So I removed the patch.
Tested it with cmd, cygwin and used spawn and exec and everything seems
to work (except for colors/ansi escape codes, but that didn't work
before anyway).
2015-10-10 20:17:08 +03:00
Cheng Zhao
6d20d37101
Bump v0.33.7
2015-10-10 17:43:56 +08:00
Cheng Zhao
df12f181a4
Can not print string16 in wcout on POSIX
2015-10-10 17:43:56 +08:00
Eran Tiktin
c71efc8ca5
Fix process.std*.write
...
- Support printing Buffer
- Don't add '\n' at the end the chunk
2015-10-10 08:13:27 +03:00
Eran Tiktin
1896deb10e
Fix console.* calls on Windows
...
- Calls for console.* on browser process are printed with no need for
--enable-logging
- The output is without the logging prefix
- The cursor in the terminal is always after the last output
- The first output starts on a new line and not at the prompt
- console.* from renderer are not printed to cmd
- Added a missing '\n' in the default_app help output
2015-10-10 06:39:02 +03:00
Robo
fb5260eb30
browser: get accept-language header from system locale
2015-10-09 13:18:37 +05:30
Theo Julienne
6bc59cf2d7
Enable accessibility tree only when VoiceOver enabled, fixes atom/atom#3288 .
2015-10-08 15:56:26 -07:00
Theo Julienne
957de56343
NSWorkspace selectFile:inFileViewerRootedAtPath: requires a non-null second argument.
2015-10-08 11:25:05 -07:00
Cheng Zhao
59b43a6571
Merge pull request #3025 from janwiemers/master
...
add a --app parameter to the default_app
2015-10-08 16:26:05 +08:00
Jan Wiemers
1a55cd3efe
remove the --app option from the default_app documentation
2015-10-08 10:22:37 +02:00
Robo
d9c6cf7b75
webcontents: dont modify response header value
2015-10-08 11:31:41 +05:30
Cheng Zhao
e1318ffb34
Merge pull request #3010 from deepak1556/guest_zoom_level_patch
...
webcontents: notify guests of embedders' zoom level change
2015-10-08 13:52:22 +08:00
Robo
7756bb6762
webcontents: notify guests of embedders' zoom level change
2015-10-08 10:38:22 +05:30
Cheng Zhao
9dd714f056
Fix postMessage
not working for windows opened by window.open
2015-10-08 10:44:30 +08:00
Cheng Zhao
fe4d86925b
Merge pull request #3020 from atom/fix-switch-path
...
Fix a wrong usage of switch commandline.
2015-10-08 10:37:09 +08:00
Jan Wiemers
c7dc901607
add --app parameter and update the example usage in the default_app #1877
2015-10-07 23:22:00 +02:00
Haojian Wu
821005e6b4
Fix a wrong usage of switch commandline.
...
We should not always save switch path as ascii string, which will not be
handled well on Windows.
2015-10-07 12:17:49 +08:00
Haojian Wu
dcb457e76e
Refine API design: desktopCapturer.getSources.
2015-10-07 11:10:35 +08:00
Cheng Zhao
927c3f34c3
Guard against undefined, fix #2995
...
In theory this should never happen, seems like some object is garbage
collected after the JavaScript context has been destroyed.
2015-10-06 22:25:55 +08:00
Cheng Zhao
fa59ea3bc5
Merge pull request #2998 from brenca/master
...
Minor fixes to sendInputEvent API.
2015-10-06 16:56:26 +08:00
Cheng Zhao
f607e81fac
views: Make size constraints work immediately after set
2015-10-06 16:16:02 +08:00
Cheng Zhao
e06778178a
linux: Restore size constraints when became sizable
2015-10-06 16:09:03 +08:00
Cheng Zhao
898db4d6bd
osx: Set resizable flag when creating window
...
Setting resizable for frameless window before it is shown will change
its size.
2015-10-06 15:23:23 +08:00
Cheng Zhao
6fea6cf58a
osx: Fix setting size constraints for frameless window
2015-10-06 15:15:23 +08:00
Cheng Zhao
428c5b6d01
Setting "x" and "y" should not change window size
2015-10-06 14:50:18 +08:00
Heilig Benedek
ccf4ed907a
Fix some minor bugs related to KeyboardEvent sending
2015-10-05 19:11:20 +02:00
Cheng Zhao
b70e7c6a4c
Remove default definition of ContentSizeToWindowSize
2015-10-06 00:39:16 +08:00
Cheng Zhao
c8723238f8
win: Fix building on Windows
2015-10-06 00:21:37 +08:00
Cheng Zhao
60fb406c61
views: Fix content size constraints in window with menubar
2015-10-06 00:15:47 +08:00
Cheng Zhao
bb49515145
Separate Windows specific code of NativeWindow to another file
2015-10-06 00:13:57 +08:00
Cheng Zhao
857acd2574
win: Fix GetContentSize for minimized window
2015-10-05 21:06:57 +08:00
Cheng Zhao
3b1ee994e2
views: Remove hack on setting min/max size for frameless window
2015-10-05 20:37:08 +08:00
Cheng Zhao
e675407552
Make min/max size respect use-content-size
2015-10-05 20:36:28 +08:00
Cheng Zhao
d19ead1907
osx: Call setContentMinSize in SetContentSizeConstraints
2015-10-05 20:09:29 +08:00
Cheng Zhao
a9b0111c3e
views: Use the quicker way of return content size
...
Converting content size to window size on high DPI systems will lose
percise and have 1px offset sometimes.
2015-10-05 20:07:20 +08:00
Cheng Zhao
279407f7a3
osx: Fix converting size for frameless window
2015-10-05 20:07:20 +08:00
Cheng Zhao
a76ea00249
views: Implement NativeWindow::SetSizeConstraints
2015-10-05 20:07:20 +08:00
Cheng Zhao
8577f2b52f
osx: Add NativeWindow::SetSizeConstraints
2015-10-05 20:07:20 +08:00
Cheng Zhao
526cee7ec3
Merge tag 'v0.33.6'
2015-10-05 19:58:47 +08:00
Cheng Zhao
2d676770b1
Bump v0.33.6
2015-10-05 19:57:30 +08:00
Cheng Zhao
7de3aa3cc1
Fix typo, closes #2990
2015-10-05 19:57:14 +08:00
Cheng Zhao
2b9b4c6789
Merge pull request #2979 from etiktin/fix_calculating_min_max_4_frameless
...
Fix calculating min/max size in frameless view
2015-10-05 15:10:27 +08:00
Cheng Zhao
de24ed7cea
Merge pull request #2985 from etiktin/fix_restore_size_windows
...
[Windows] Fix restore/unmaximize wrong window size
2015-10-05 15:09:24 +08:00
Haojian Wu
36c0ad7fda
Refine more about desktop capturer API.
...
* Simplify the coffeescript code.
* Add more options in desktopCapturer.startUpdating.
2015-10-05 12:47:01 +08:00
Cheng Zhao
ec0a8a1321
Bump v0.33.5
2015-10-05 11:42:43 +08:00
Eran Tiktin
c34c123b33
Make it work only on Windows
...
Limiting the solution to Windows only.
2015-10-05 04:01:25 +03:00
Eran Tiktin
4d02fc58fa
Fix restore/unmaximize wrong window size
...
This resolves #2498 .
2015-10-05 03:29:02 +03:00
Haojian Wu
1e69ef79de
Refine: make desktop-capturer as a renderer module.
2015-10-04 22:04:41 +08:00
Cheng Zhao
d4bfeff6ad
Fix crashing on Linux
2015-10-04 20:08:19 +08:00
Cheng Zhao
a2a4970f5f
Fix cpplint warnings
2015-10-04 19:36:41 +08:00
Cheng Zhao
0e131f760b
Quit gracefully when Ctrl-C is pressed
2015-10-04 19:21:36 +08:00
Cheng Zhao
bdd2f91913
Make Browser::Quit more robust
2015-10-04 19:20:52 +08:00
Cheng Zhao
74b76102a8
linux: No longer needs to manually read DPI settings
...
It is now done in brightray by reading the value from GTK+.
2015-10-04 16:53:20 +08:00
Cheng Zhao
add9c38023
linux: Enable force showing menubar
...
This is for debugging purpose.
2015-10-04 16:33:03 +08:00
Cheng Zhao
791f988aba
linux: Fix pressing Alt not showing menubar
2015-10-04 16:32:08 +08:00
Eran Tiktin
aea1f8aebb
Fix calculating min/max size in frameless views
...
The minimum and maximum size that frameless windows had used, was
incorrect. It included the border, so when it was called it actually
added that to the size, so window increased in size. The fix makes sure
that the view will use the frameless size.
This fixes #2945 and partially fixes #1806 (it also refers to some other
issues with hidpi which might still exist).
2015-10-03 22:09:57 +03:00
Cheng Zhao
01d2765e4b
Prevent Node from adding paths outside this app to search paths
2015-10-03 20:38:39 +08:00
Cheng Zhao
9fe326ebeb
Clear node's global search paths
2015-10-03 19:55:59 +08:00
Cheng Zhao
021ee20400
No need to add "app" to search paths
2015-10-03 17:52:46 +08:00
Cheng Zhao
3503b62ff2
Disable logging unless --enable-logging is specified
2015-10-03 15:33:55 +08:00
Haojian Wu
48fbd47416
Make desktop capture API work on Windows.
2015-10-03 10:51:02 +08:00
Haojian Wu
c9fbde321c
Implement desktop capture API on OS X.
2015-10-02 19:17:28 +08:00
Cheng Zhao
9eb7c3ac2d
Bump v0.33.4
2015-10-02 13:41:50 +08:00
Cheng Zhao
5d9e4fc8fd
Override document.hidden
2015-10-01 18:39:35 +08:00
Cheng Zhao
8d61531f4e
Revert #2879
2015-10-01 17:46:11 +08:00
Cheng Zhao
ef4014e14b
Don't show open dialog as sheet in devtools
2015-10-01 14:46:33 +08:00
Cheng Zhao
ca40ea8e2f
Inherit owner window in devtools
2015-10-01 14:41:01 +08:00
Cheng Zhao
1045bbc861
Do not enumerate windows in remote.getCurrentWindow
2015-10-01 14:08:33 +08:00
Cheng Zhao
f2c7943d42
Add WebContents.getOwnerBrowserWindow
2015-10-01 13:45:59 +08:00
Cheng Zhao
83c514001e
Move devtools API to WebContents
2015-10-01 11:25:31 +08:00
Cheng Zhao
0fb68e8130
Make Menu.popup accept no parameter
2015-09-30 23:41:23 +08:00
Cheng Zhao
8c3116851d
Exit the process when unable to find a valid app
...
Fixes #2583 .
2015-09-30 17:30:28 +08:00
Cheng Zhao
4fdf6ceb51
Cache remote WebContents object of webview
2015-09-30 16:58:37 +08:00
Cheng Zhao
21f7316a18
Code cleanup
2015-09-30 10:56:42 +08:00
Robo
464134a31a
protocol: allowing default clients to handle external unhandled protocols
2015-09-29 17:52:58 +05:30
Eran Tiktin
ee0f0f6cfc
Fix window state events on Windows
...
This commit fixes the issue we had with window state events not firing
when triggered through Aero Snap.
Instead of listening to command from the system menu (SC_MAXIMIZE etc.),
we use the WM_SIZE event.
This resolves #1381 .
2015-09-29 02:20:09 +03:00
Cheng Zhao
a987715222
Merge pull request #2914 from deepak1556/network_emulation_api_patch
...
session: api to emulate network conditions
2015-09-28 17:02:23 +08:00
Cheng Zhao
82bb790530
Style fix for #2918
2015-09-28 12:48:33 +08:00
Cheng Zhao
11af4b63ac
Merge pull request #2918 from brenca/master
...
Option to specify button on a MouseEvent and text on a KeyboardEvent when using sendInputEvent
2015-09-28 12:47:22 +08:00
Heilig Benedek
44ee74a9b1
Style fix
2015-09-28 03:05:08 +02:00
Heilig Benedek
70bdfedabf
Added text and unmodifiedtext setting when sending char type keyboard events, and made the type of the character read char16, so I can simulate char events from non-english origins.
2015-09-28 02:41:06 +02:00
Eran Tiktin
6dcc752f67
Set default extension in Windows file dialog
...
On Windows when you open the save dialog and switch the filter, the
extension is supposed to change accordingly. It didn't happen with the
existing code, since the existing code didn't set the default extension
(should be set to the first filter).
This resolves #2915 .
2015-09-28 02:12:47 +03:00
Robo
fc7f4ae24b
session: api to emulate network conditions
2015-09-27 18:55:26 +05:30
Gohy Leandre
9f30e5f526
Add ability to preload modules (--require, -r)
2015-09-26 17:25:07 +02:00
Cheng Zhao
690f859a78
Bump v0.33.3
2015-09-26 22:06:01 +08:00
Heilig Benedek
bb102717b4
Adding option to specify the button of WebMouseEvent.
2015-09-25 13:01:52 +02:00
Cheng Zhao
c0528c5049
Bump v0.33.2
2015-09-25 17:50:53 +08:00
Cheng Zhao
7884a2319c
osx: Make draggable region work for window with hidden titlebar
2015-09-25 16:38:36 +08:00
Cheng Zhao
6f944ad49b
Clean up code
2015-09-25 16:21:08 +08:00
Haojian Wu
4a64d1d946
📝 fix a typo
...
interrputed => interrupted
2015-09-25 13:13:11 +08:00
Cheng Zhao
ecefd3540b
Merge pull request #2840 from atom/download-item
...
Add more download supports in Electron
2015-09-24 21:04:25 +08:00
Haojian Wu
06cc133959
Some cleanup.
2015-09-24 19:31:09 +08:00
Cheng Zhao
da57a3101f
Call WasShown when showing window
...
Otherwise WebContents would be invisible when window is hidden at first
and then show later.
Refs #2879 .
2015-09-24 18:16:41 +08:00
Cheng Zhao
10731de9d6
Merge pull request #2879 from deepak1556/web_contents_visibility_patch
...
browser: notify webcontents hidden when window not shown
2015-09-24 18:00:25 +08:00
Haojian Wu
1879392c7b
Reimplement downloadItem.getFilename API.
...
Previously, the suggested file name(Always 'empty') returned by
'download_item->GetSuggestedFilename' is not the same with the default one saved
in local disk.
The patch reimplement this API allowing it to return the default file name, which
is more expected from user.
2015-09-24 16:39:02 +08:00
Haojian Wu
0861d5d44b
Redefine 'will-download' design.
2015-09-24 16:04:44 +08:00
Robo
5ca5c4fb92
browser: hide webcontents when window not shown
2015-09-24 10:30:18 +05:30
Cheng Zhao
9e90ea8734
win: Fix leaking of fd when reading file in asar
2015-09-24 12:11:07 +08:00
Cheng Zhao
9b1fa04988
win: Fix building
2015-09-24 12:01:57 +08:00
Paul Betts
b0e5039951
Fix initializer
2015-09-23 11:26:57 -07:00
Paul Betts
22e6f15795
Remove GUID from Shell_NotifyIcon calls
...
https://github.com/atom/electron/issues/2468#issuecomment-142684129 has
the details
2015-09-23 11:20:26 -07:00
Cheng Zhao
142702866d
Merge pull request #2861 from deepak1556/ssl_version_config_patch
...
browser: switch to set minimum version for TLS fallback
2015-09-23 17:30:26 +08:00
Robo
748b1387d2
browser: switch to set minimum version for TLS fallback
2015-09-23 09:10:36 +05:30
Cheng Zhao
f2fa0e96eb
Pass options in "new-window" event
2015-09-22 23:40:16 +08:00
Cheng Zhao
de41890196
Inherit parent window's options in window.open
2015-09-22 22:32:10 +08:00
Cheng Zhao
f07fea1936
Add allowpopups attribute for webview
2015-09-22 20:11:05 +08:00
Cheng Zhao
7c65d05b02
Don't print error when window.open failed
2015-09-22 19:59:32 +08:00
Cheng Zhao
619a397ec9
Bump v0.33.1
2015-09-22 15:13:50 +08:00
Cheng Zhao
42515c6f41
No more need of manually setting process as local variable
2015-09-22 14:30:54 +08:00
Cheng Zhao
eccb5e7590
Don't make setImmediate a local variable
...
It makes more troubles than benefits, and somehow it is slowing message
loop down.
2015-09-22 14:29:21 +08:00
Cheng Zhao
008af00044
Merge pull request #2852 from deepak1556/web_frame_scheme_api_patch
...
webframe: api to register scheme as privileged
2015-09-22 09:59:24 +08:00
Robo
325feca864
webframe: api to register scheme as privileged
2015-09-21 22:59:59 +05:30
Haojian Wu
22168bc6d8
Allow emitting 'done' event when user cancel the download saving dialog.
2015-09-21 21:44:18 +08:00
Gohy Leandre
477103191f
Add http_response_code, method, referrer, response_headers to did-get-redirect-request event.
2015-09-21 09:51:58 +02:00
Haojian Wu
57bf0cb615
Refractor in completed
event in DownloadItem.
...
* Rename `completed` to `done`, making it align with Chromium's style.
* Add 'state' in `done` event's result. It can check the download item final
status: cancelled, completed, interrupted.
2015-09-21 14:00:38 +08:00
Cheng Zhao
01a3bf5881
Merge pull request #2837 from rhencke/patch-1
...
Fix small typo in debug message.
2015-09-21 11:49:33 +08:00
Haojian Wu
997ac91fe0
Add donwloadItem.getContentDisposition()
API.
2015-09-21 09:38:38 +08:00
Haojian Wu
4391e81dfe
Keep compatibility with old APIs.
2015-09-21 09:38:06 +08:00
Haojian Wu
d0ee30101d
Fix cpplint warnings.
2015-09-21 09:34:49 +08:00
Haojian Wu
5ec74451ef
Introduce DownloadItem for supporting more downloading features.
2015-09-20 18:56:10 +08:00
Haojian Wu
87b9b0bc31
Implement session.setOpenDownloadDialog() API.
2015-09-20 18:45:34 +08:00
Robert Hencke
76b7cd0908
Fix small typo in debug message.
2015-09-19 17:11:29 -04:00
Indrek Ardel
c626ee6e92
Fix a typo
2015-09-19 21:17:23 +03:00
Cheng Zhao
7b2980434c
Fix wrong return values in a few converters
2015-09-18 18:21:51 +08:00
Cheng Zhao
ff0e15bf58
Expose sendInputEvent in webview
2015-09-18 17:55:42 +08:00
Cheng Zhao
86f523d3c1
Move BeginFrameSubscription to WebContents
2015-09-18 15:57:43 +08:00
Cheng Zhao
42863e4700
Move SendInputEvent to WebContents
2015-09-18 14:20:31 +08:00
Cheng Zhao
9e7de78231
Fix cpplint warnings
2015-09-18 14:12:48 +08:00
Cheng Zhao
c550546ff1
Do not manually convert Object to WebInputEvent
2015-09-18 14:09:31 +08:00
Cheng Zhao
5a599cb6ff
Sequence of definitions should follow the declarations
2015-09-18 13:49:33 +08:00