5689 commits

Author	SHA1	Message	Date
Electron Bot	539d6d20b7	Bump v4.0.0-nightly.20181010	2018-10-10 06:38:01 -07:00
Samuel Attard	5667c16767	Revert "Bump v4.0.0-nightly.20181010" ... This reverts commit c96847206e.	2018-10-11 00:04:35 +11:00
Electron Bot	c96847206e	Bump v4.0.0-nightly.20181010	2018-10-10 03:45:40 -07:00
Samuel Attard	d48c3ec8da	Revert "Bump v4.0.0-nightly.20181010" ... This reverts commit 8b3f915623.	2018-10-10 21:43:32 +11:00
Electron Bot	8b3f915623	Bump v4.0.0-nightly.20181010	2018-10-10 02:22:24 -07:00
Samuel Attard	1b9600e510	Revert "Bump v4.0.0-nightly.20181010" ... This reverts commit 181195ee20.	2018-10-10 20:21:17 +11:00
Electron Bot	181195ee20	Bump v4.0.0-nightly.20181010	2018-10-10 01:04:16 -07:00
Samuel Attard	b0068cecc8	Revert "Bump v4.0.0-nightly.20181009" ... This reverts commit 1b9a8bb854.	2018-10-10 21:02:17 +13:00
Electron Bot	1b9a8bb854	Bump v4.0.0-nightly.20181009	2018-10-09 22:59:47 -07:00
Samuel Attard	f6dd201401	Revert "Bump v4.0.0-nightly.20181009" ... This reverts commit 32e041d917.	2018-10-10 16:53:56 +11:00
Samuel Attard	5b43c249ce	Revert "FIXME: temporary debugging to maybe diagnose netlog issue on mac" ... This reverts commit f8f318da93.	2018-10-10 16:49:31 +11:00
Kevin Lynagh	af4cf1e969	fix: simpleFullscreen window should be on top of other OS X menu bars. (#14881) ... If an app has no menu bar (because `app.dock.hide()` has been called), OS X will still render the menu bar of the previously-focused app. This commit ensures simpleFullscreen windows will be drawn on top of that menu bar by setting their level to NSPopUpMenuWindowLevel while simpleFullscreen mode is active. Ref: https://github.com/electron/electron/issues/11468	2018-10-09 22:38:52 -07:00
Electron Bot	32e041d917	Bump v4.0.0-nightly.20181009	2018-10-09 21:34:34 -07:00
Milan Burda	5bd6de52e0	feat: add app.enableSandbox() (#14999)	2018-10-10 15:32:09 +11:00
Samuel Attard	cc0c6ad14a	Merge pull request #14972 from electron/chromium-upgrade/69 ... feat: upgrade to Chromium 69.0.3497.106	2018-10-10 15:29:21 +11:00
Shelley Vohr	dd43e92186	fix: simplify SetBackgroundColor ... The compositor_superview member of BridgedNativeWidgetMac has been removed so as a consequence there is only one layer on which we need to call setBackgroundColor	2018-10-09 20:37:07 -07:00
Nitish Sakhawalkar	185fe6ced9	fix: Lifetime of auth_info_ in login handler (#15042)	2018-10-10 10:50:44 +11:00
Jeremy Apthorp	f8f318da93	FIXME: temporary debugging to maybe diagnose netlog issue on mac	2018-10-09 15:43:33 -07:00
Jeremy Apthorp	30850f491f	fix: [mac] restore SetBackgroundColor functionality	2018-10-09 14:39:39 -07:00
Jeremy Apthorp	ee8a54d186	chore: update line reference in gpuinfo comment	2018-10-09 14:39:39 -07:00
deepak1556	363aafc25b	fix: ensure webcontents is destroyed before its associated browser context.	2018-10-09 14:39:39 -07:00
Jeremy Apthorp	a71755e1b6	fix: crash in webRequest due to unsafe static_cast ... upstream was changed to wrap the network delegate see https://chromium.googlesource.com/chromium/src/+/69.0.3497.106/services/network/network_context.cc#948	2018-10-09 14:38:00 -07:00
Heilig Benedek	e548ed1a6e	fix: remove conflicting header	2018-10-09 14:38:00 -07:00
Cheng Zhao	a6256c672a	feat: getGPUInfo not longer supports 'complete' on macOS ... See https://chromium-review.googlesource.com/c/chromium/src/+/1208362	2018-10-09 14:38:00 -07:00
Charles Kerr	f027e62b2a	fix: only call NetworkService::SetUpHttpAuth once.	2018-10-09 14:38:00 -07:00
deepak1556	be719a1ec3	fix: Use the new isolate initialization api ... https://chromium-review.googlesource.com/c/chromium/src/+/1015020	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	56e26c27f2	clang-format	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	c920e453dc	Stop using ResourceContext::GetHostResolver() ... https://chromium-review.googlesource.com/c/chromium/src/+/1135366	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	6df9c04270	Hook up HttpAuthHandlerFactory configuration to the network service ... https://chromium-review.googlesource.com/c/chromium/src/+/1089661	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	67611d69af	Refactor of ServiceManagerContext ... https://chromium-review.googlesource.com/c/chromium/src/+/1093021	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	f5eaa97d9d	migrate off QuitCurrent*Deprecated in browser.cc ... modelled after https://chromium-review.googlesource.com/c/chromium/src/+/1096475 and https://chromium-review.googlesource.com/c/chromium/src/+/1096475	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	8eb15f7554	Creates TaskScheduler and MessageLoop on main thread early ... https://chromium-review.googlesource.com/c/chromium/src/+/1072387	2018-10-09 14:38:00 -07:00
Samuel Attard	7589c56cea	fix: intercept the isolate_holder's new isolate and register it with the node platform before initialization ... Chromium Change: https://chromium-review.googlesource.com/c/chromium/src/+/1015020	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	b57b342352	Remove PlatformAccelerator ... https://chromium-review.googlesource.com/c/chromium/src/+/1140211	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	7ce338e420	Handle deleting cookies with session-only policy in network service ... https://chromium-review.googlesource.com/c/chromium/src/+/1090035	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	120b6079a8	Move Net.HttpRequestCompletionErrorCodes to NetworkContext ... https://chromium-review.googlesource.com/c/chromium/src/+/1108083	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	42120b4a72	Remove SupportsOCSPStapling from CertVerifier and CertVerifyProc ... https://chromium-review.googlesource.com/c/chromium/src/+/1117034	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	b8774374a8	Fixed reporting for iframe ugprade-insecure-requests upgrades ... https://chromium-review.googlesource.com/c/chromium/src/+/1096360	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	34e54b93a4	Remove WebContentsUserData::kLocatorKey ... https://chromium-review.googlesource.com/c/chromium/src/+/1093015	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	2d46164ce0	Switch NetworkDelegate to OnceCallbacks ... https://chromium-review.googlesource.com/c/chromium/src/+/1085855	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	0955fa7bcf	Remove unused RunMicrotasksObserver ... https://chromium-review.googlesource.com/c/chromium/src/+/1086889	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	9e110ec915	Remove content::SpeechRecognitionResult ... https://chromium-review.googlesource.com/c/chromium/src/+/1070587	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	56bc636706	Make content::PermissionManager a delegate of PermissionController ... https://chromium-review.googlesource.com/c/chromium/src/+/1111340	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	eef375a428	Port //services/device/geolocation to network::SimpleURLLoader ... https://chromium-review.googlesource.com/c/chromium/src/+/1119398	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	63176acde2	Collect NV12, YUY2, and BGRA overlay support information in GPUInfo ... https://chromium-review.googlesource.com/c/chromium/src/+/1121622	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	e3fef30789	Refactor RWH::RestartHang...Timeout... into a generic base::Closure ... https://chromium-review.googlesource.com/c/chromium/src/+/1096362	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	4570330c7b	Rename WebContentsDelegate methods ... https://chromium-review.googlesource.com/c/chromium/src/+/1085427	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	af03e4a962	Rename content::PermissionManager into content::PermissionControllerDelegate ... https://chromium-review.googlesource.com/c/chromium/src/+/1136858	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	9c2cd5a84c	Support add/overwrite redirect request headers in NavigationURLLoader ... https://chromium-review.googlesource.com/c/chromium/src/+/1072643	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	18128a1582	Use CompletionOnceCallback ... several CLs, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1092933	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	ec1bd5375a	FIXME: Delete RenderWidgetHostViewMac::AcceleratedWidgetGetNSView ... https://chromium-review.googlesource.com/c/chromium/src/+/1121957 https://chromium-review.googlesource.com/c/chromium/src/+/1037145	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	2a3a845262	Change CreateWebUIControllerForURL() to return a unique_ptr ... https://chromium-review.googlesource.com/c/chromium/src/+/1087627	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	c576d442fd	Rename base::Timer to base::TimerBase ... https://chromium-review.googlesource.com/c/chromium/src/+/1124200	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	a7c687f160	ChildProcessSecurityPolicy: only use granted schemes for requests ... https://chromium-review.googlesource.com/c/chromium/src/+/1108485	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	90aa277c26	Migrate MediaResponseCallback to OnceCallback ... https://chromium-review.googlesource.com/c/chromium/src/+/1093052	2018-10-09 14:38:00 -07:00
Jeremy Apthorp	3ded109c2e	stop using x-devtools-emulate-network-conditions-client-id header ... https://chromium-review.googlesource.com/c/chromium/src/+/1086949	2018-10-09 14:38:00 -07:00
Troy	d678d9ee75	fix: Check minSize constraints before resizing (#14931) ... * Inital setSize check * Only resize if above minimum size constraints * lint * Resize to min if size is changed * Remove unneeded if statement * chore: remove trailing whitespace * Add note about setSize method in docs	2018-10-09 12:08:15 -05:00
Charles Kerr	05f4860889	fix: power observer dbus crash (#15030) ... * fix: check dbus response for nullptr before using * chore: use BindOnce for ProxyObject::CallMethod cb * chore: comment out name of unused argument * fix: re-enable and fix linux power monitor tests * fix: change tyop from code comments * refactor: don't keep unnecessary dbus pointer * chore: remove the 'TODO: fix this' spec comment	2018-10-09 00:32:19 -05:00
Milan Burda	b50f86ef43	refactor: use separate ipc-renderer-internal / ipc-main-internal APIs for Electron internals (#13940)	2018-10-07 00:48:00 +13:00
Electron Bot	f7122610cc	Bump v4.0.0-nightly.20181006	2018-10-06 02:43:36 -07:00
Samuel Attard	59681f989f	Revert "Bump v4.0.0-nightly.20181006" ... This reverts commit c74a3b82d7.	2018-10-06 22:21:12 +13:00
Electron Bot	c74a3b82d7	Bump v4.0.0-nightly.20181006	2018-10-06 00:13:06 -07:00
Samuel Attard	251a3c712b	Revert "Bump v4.0.0-nightly.20181005" ... This reverts commit 2a2ec7700e.	2018-10-06 20:10:21 +13:00
Electron Bot	2a2ec7700e	Bump v4.0.0-nightly.20181005	2018-10-05 21:09:00 -07:00
Robo	6e5dd735f6	refactor: enable weak ptr unwrap sequence dcheck (#14816) ... * refactor: enable weak ptr unwrap sequence dcheck * spec: remove WeakPtrDeathTest.* from disabled list	2018-10-05 15:29:57 -05:00
Robo	2700eaca1e	build: remove //chrome/browser/icon_loader source copies (#14955) ... * build: remove //chrome/browser/icon_loader source copies * chore: add DCHECK to ensure IconManager is accessed from UI thread	2018-10-05 14:12:53 -05:00
Shelley Vohr	71058fd9a3	fix: re-enable osr following m68 upgrade (#14973)	2018-10-05 11:03:35 -07:00
Charles Kerr	859567983a	chore: run clang-format to clear linter for #14977 (#14990)	2018-10-05 10:38:27 -05:00
Samuel Attard	8d5de8a0fd	Revert "Bump v4.0.0-nightly.20181004" ... This reverts commit 53d3a96489.	2018-10-05 10:21:56 +10:00
Charles Kerr	9d4818c784	fix relaunch on linux (#14975) ... * chore: re-enable relaunch test for Linux * fix: relauncher_linux listening for parent exit	2018-10-04 18:41:37 -05:00
Electron Bot	53d3a96489	Bump v4.0.0-nightly.20181004	2018-10-04 16:28:34 -07:00
Samuel Attard	21348b9f3d	Revert "Bump v4.0.0-nightly.20181004" ... This reverts commit 7a6d0cd6d2.	2018-10-05 09:15:38 +10:00
Electron Bot	7a6d0cd6d2	Bump v4.0.0-nightly.20181004	2018-10-04 13:56:59 -07:00
Robo	434a6e3561	refactor: create request context from network context (#14656) ... * [ci skip] refactor: create request context from network context * [ci skip] refactor: subscribe to mojo cookiemanager for cookie changes * [ci skip] refactor: manage the lifetime of custom URLRequestJobFactory * refactor: use OOP mojo proxy resolver * revert: add support for kIgnoreCertificateErrorsSPKIList * build: provide service manifest overlays for content services * chore: gn format * fix: log-net-log switch not working as expected * spec: verify proxy settings are respected from pac script with session.setProxy * chore: use chrome constants where possible * fix: initialize request context for global cert fetcher * refactor: fix destruction of request context getters * spec: use custom session for proxy tests * fix: queue up additional stop callbacks while net log is being stopped * fix: Add CHECK for cookie manager retrieval * chore: add helper to retrieve logging state for net log module * fix: ui::ResourceBundle::GetRawDataResourceForScale => GetRawDataResource * style: comment unused parameters * build: move //components/certificate_transparency deps from //brightray * chore: update gritsettings_resource_ids patch * chore: update api for chromium 68 * fix: net log instance is now a property of session	2018-10-04 13:08:56 -05:00
Shelley Vohr	27bbf6a3c6	feat: add evt listeners for SetAlwaysOnTop (#14951) ... * feat: add evt listeners for SetAlwaysOnTop * only emit one event on AlwaysOnTop change * docs: add new alwaysontop event * dont emit if theres no change * address feedback from review	2018-10-04 13:02:16 -05:00
Cheng Zhao	d3ae541397	refactor: Clean up the implementation of the registerStreamProtocol (#11357) ... * Use weak pointer to avoid race condition * Use DeleteSoon to delete pointer across threads * Simplify EventSubscriber * No need to manually mange V8 convertions * Fix cpplint warning We should update cpplint for this, but let's do it in other PR. * Move UI thread operations to EventSubscriber * Less and more assertions Some methods are now private so no more need to assert threads. * Fix cpplint warnings * No longer needs the EventEmitted * EventSubscriber => StreamSubscriber * Reduce the copies when passing data * Fix cpplint warnings	2018-10-04 10:13:09 -04:00
Samuel Attard	01efb6570c	Revert "Bump v4.0.0-nightly.20181003" ... This reverts commit 76dab5ebd1.	2018-10-04 13:45:20 +10:00
Electron Bot	76dab5ebd1	Bump v4.0.0-nightly.20181003	2018-10-03 19:15:29 -07:00
Jeremy Apthorp	6e037f5e71	use new node options parser	2018-10-04 00:13:37 +02:00
Jeremy Apthorp	f0da5bce80	MessageLoop::QuitWhenIdleClosure -> RunLoop::QuitCurrentWhenIdleClosureDeprecated	2018-10-04 00:12:55 +02:00
Jeremy Apthorp	faf57683ce	WasResized -> SynchronizeVisualProperties	2018-10-04 00:12:54 +02:00
Jeremy Apthorp	5d9ba8b821	MessageLoopCurrent	2018-10-04 00:12:54 +02:00
Jeremy Apthorp	08265ba3e2	content::RESULT_CODE_NORMAL_EXIT -> service_manager::RESULT_CODE_NORMAL_EXIT	2018-10-04 00:12:54 +02:00
Jeremy Apthorp	948fe2107e	OnAudioStateChanged doesn't take a WebContents	2018-10-04 00:12:54 +02:00
Jeremy Apthorp	517d38f191	blink::WebFullscreenOptions	2018-10-04 00:12:54 +02:00
Jeremy Apthorp	a5b09e25ea	std::unique_ptr<WebContents>	2018-10-04 00:12:54 +02:00
Jeremy Apthorp	8060e915c2	net::HttpAuthCache::ClearEntriesAddedWithin -> ClearAllEntries	2018-10-04 00:12:54 +02:00
Jeremy Apthorp	5a757449b0	ScopedNestableTaskAllower doesn't take an argument	2018-10-04 00:12:54 +02:00
Jeremy Apthorp	b9cd3493ac	GetHandle() -> GetProcess().Handle()	2018-10-04 00:12:54 +02:00
Jeremy Apthorp	1c60f9e468	use content::ChildProcessTerminationInfo	2018-10-04 00:12:54 +02:00
Jeremy Apthorp	280421393e	net::X509Certificate::Equals -> net::X509Certificate::EqualsExcludingChain	2018-10-04 00:12:54 +02:00
Jeremy Apthorp	de581ca0b4	PathService -> base::PathService	2018-10-04 00:12:54 +02:00
Jeremy Apthorp	7092fa31a4	kNoSandbox moved into service_manager	2018-10-04 00:11:51 +02:00
Robo	820d99d37f	build: remove duplicate cursor resource configs (#14929) ... $target_gen_dir/ui/resources/ui_unscaled_resources.rc provides the required values during compilation.	2018-10-03 08:38:53 -07:00
Robo	596ae2c2df	refactor: desktop capturer module (#14835) ... * Revert "post all desktop capturer apis to worker threads" This reverts commit 5a28759fea. * refactor: desktop capturer module * Creates the screen and window capturer for the liftime of the app * Fixes incorrect usage of weak ptr * build: add //ui/snapshot to chromium_src deps * fix: handle scenarios when there are no captured sources	2018-10-03 21:26:42 +09:00
Shelley Vohr	e06bc311a9	chore: remove dead code in menu controller (#14939)	2018-10-03 16:24:28 +09:00
Cheng Zhao	a1b2162563	fix: use white background for non-OSR renderer by default (#14932)	2018-10-02 20:09:18 -07:00
Felix Rieseberg	79c6e7c3f7	fix: Disable new fade animation for BrowserViews (#14911)	2018-10-02 11:49:26 +10:00
Alexey Kuzmin	c9edf77e8e	test: slightly rewrite getGPUInfo() tests (#14863) ... Rewrite GPUInfo tests for linux and update `getGPUInfo` functionality for linux. `basic` and `complete` GPUInfo is same for linux.	2018-10-01 18:34:52 -07:00
Robo	a24ad6bc14	build: define compile time features with buildflag header (#14840) ... * build: define compile time features with buildflag header * refactor: switch to BUILDFLAG(ENABLE_DESKTOP_CAPTURER) * refactor: switch to BUILDFLAG(ENABLE_RUN_AS_NODE) * refactor: switch to BUILDFLAG(ENABLE_OSR) * refactor: switch to BUILDFLAG(ENABLE_VIEW_API) * refactor: switch to BUILDFLAG(ENABLE_PEPPER_FLASH) * refactor: switch to BUILDFLAG(OVERRIDE_LOCATION_PROVIDER) * refactor: switch to BUILDFLAG(ENABLE_PDF_VIEWER)	2018-10-01 16:00:53 -04:00
Shelley Vohr	ec38561254	chore: wrap new NSAppearance in correct check (#14873) ... * fix: wrap new NSAppearance in correct check * catch dark case on < 10.14 * fix @available conditional organization	2018-10-02 00:52:04 +10:00
Electron Bot	0127bbc8e8	Bump v4.0.0-nightly.20180929	2018-09-29 05:11:59 -07:00
Samuel Attard	3d1247933c	Revert "Bump v4.0.0-nightly.20180929" ... This reverts commit 3cc0a40792.	2018-09-29 22:04:05 +10:00
Electron Bot	3cc0a40792	Bump v4.0.0-nightly.20180929	2018-09-29 04:56:34 -07:00
Samuel Attard	6d205423f5	Revert "Bump v4.0.0-nightly.20180929" ... This reverts commit dac076dfb1.	2018-09-29 21:50:10 +10:00
Electron Bot	dac076dfb1	Bump v4.0.0-nightly.20180929	2018-09-29 02:02:46 -07:00
Samuel Attard	7ac4f7aa3b	Revert "Bump v4.0.0-nightly.20180929" ... This reverts commit e3adffbbac.	2018-09-29 18:36:12 +10:00
Electron Bot	e3adffbbac	Bump v4.0.0-nightly.20180929	2018-09-29 00:04:20 -07:00
Samuel Attard	417150cecf	Revert "Bump v4.0.0-nightly.20180928" ... This reverts commit fa70e65e0f.	2018-09-29 15:32:20 +10:00
Electron Bot	fa70e65e0f	Bump v4.0.0-nightly.20180928	2018-09-28 21:30:52 -07:00
Samuel Attard	2669f1247a	Revert "Bump v4.0.0-nightly.20180928" ... This reverts commit 449bd8e408.	2018-09-29 14:00:41 +10:00
Electron Bot	449bd8e408	Bump v4.0.0-nightly.20180928	2018-09-28 20:13:25 -07:00
Samuel Attard	24576fd0f1	Revert "Bump v4.0.0-nightly.20180927" ... This reverts commit 40bc4afcb3.	2018-09-29 00:04:19 +12:00
Troy	0e1365fc94	fix: enable key accelerator flags for Windows and Linux (#14830) ... * Fix Accelerator Flags for Windows and Linux * Lint fix * Lint whitespace	2018-09-28 06:59:00 -05:00
Electron Bot	40bc4afcb3	Bump v4.0.0-nightly.20180927	2018-09-27 23:51:02 -07:00
Samuel Attard	462d65c203	Revert "Bump v4.0.0-nightly.20180927" ... This reverts commit 8c1d6f2aa2.	2018-09-28 16:47:41 +10:00
Electron Bot	8c1d6f2aa2	Bump v4.0.0-nightly.20180927	2018-09-27 23:01:31 -07:00
Samuel Attard	3006974106	Revert "Bump v4.0.0-nightly.20180927" ... This reverts commit 06aaf71706.	2018-09-28 15:34:47 +10:00
Electron Bot	06aaf71706	Bump v4.0.0-nightly.20180927	2018-09-27 21:03:47 -07:00
Samuel Attard	d51633e598	Revert "Bump v4.0.0-nightly.20180927" ... This reverts commit c48306c80f.	2018-09-28 13:57:04 +10:00
Electron Bot	c48306c80f	Bump v4.0.0-nightly.20180927	2018-09-27 20:22:40 -07:00
Samuel Attard	a524c5ec12	chore: move the view APIs to their own directory (#14722) ... * chore: move the view APIs to their own directory * move view api cpp files	2018-09-28 12:47:09 +10:00
Samuel Attard	6be69048e6	fix: handle shortcuts by default if no WebPreferences object exists (#14766) ... DevTools webcontents do not have webpreferences Fixes #14685	2018-09-28 01:41:09 +10:00
Samuel Attard	0d2a0c7583	feat: add APIs to support mojave dark modes (#14755) ... * feat: add APIs to support mojave dark mode Closes #13387 * docs: fix system-prefs typo	2018-09-27 10:33:31 -05:00
Nitish Sakhawalkar	5c108728d6	feat: Implementation of getGPUInfo API. (#13486) ... * Implementation of getGPUInfo API. * Clear promise set * Changes to promise usage * Minor fixes * Fix linux build * Update spec * Fix lint (linter didn't run on windows locally) * Test running single test for CI * Update spec	2018-09-28 00:59:23 +10:00
Alexey Kuzmin	638311b6b3	build: turn on OSR for GN builds (#14352) ... * build: turn on OSR for GN builds * remove mac-only speech functions in osr They were removed as a part of https://chromium-review.googlesource.com/c/chromium/src/+/923548 * implement WasResized in MacHelper * add missing screen include * fix: use proper bitmap operations to construct frame to avoid failing checks * switch to SkCanvas for drawing	2018-09-27 09:32:31 -04:00
Samuel Attard	7dc7cd1d89	fix: send null in debugger callback when no error (#14814) ... Fixes #13811	2018-09-27 17:43:45 +10:00
Shelley Vohr	985d35fc1c	fix: update deprecated NSWindow masks (#14760)	2018-09-26 16:00:57 -07:00
Troy	560b1c17af	fix: setMaximizable to be true if window is resizable & maximizable (#14648) ... * setMaximizable to be true if window is resizable & maximizable * Fix linting * Add regressive test to verify maxmizable state * Leaves maximizable state of window alone if setResizable is called * Fix exclusive test * Fix crashing text * SetMaximizable unconditionally * Remember former maximizable state * Fix accidental mac variable deletion * Logic modification * Lint * Remove unneeded test * Remove unneeded variable since only Windows is effect	2018-09-26 11:41:40 +10:00
Shelley Vohr	c9bc3471e7	fix: get background color from GtkMenuBar#menubar (#14785) ... * fix: get background color from GtkMenuBar#menubar * expose libgtkui::GetBgColor	2018-09-25 13:57:06 -07:00
Shelley Vohr	c7b91acf41	fix: inconsistent titleBarStyle on transparent fullscreen (#14765)	2018-09-24 17:15:18 -07:00
Jeremy Apthorp	335caef9ad	fix: support macos 10.14 SDK (#14758) ... * support macos 10.14 SDK * forward-declare NSUserActivityRestoring for backwards compatibility * that didn't work, let's resort to #ifdef	2018-09-24 10:41:17 -04:00
Cheng Zhao	6f494b3c58	fix: do not set layer explicitly for frameless window (#14730)	2018-09-20 12:24:55 -05:00
Aleksei Kuzmin	7fc3bcaa02	chore: run clang-format ... - atom/ - brightray/ - chromium_src/	2018-09-19 17:18:10 +02:00
Milan Burda	e22142ef9c	feat: add process.takeHeapSnapshot() / webContents.takeHeapSnapshot() (#14456)	2018-09-18 11:00:31 -07:00
Shelley Vohr	12a435273d	fix: quit properly in simpleFullScreen mode (#14620)	2018-09-16 22:22:09 -07:00
Samuel Attard	7065093869	feat: add will-redirect (#13866) ... * feat: add will-redirect to allow people to prevent 30X redirects * spec: add tests for the will-redirect event * refactor: implement will-redirect using NavigationThrottle instead of PostTask This avoids a potential race condition and immediately cancels the navigation * docs: add docs for did-redirect-navigation * refactor: move AtomNavigationThrottle out of net folder * refactor: update header guard for atom_navigation_throttle.h * refactor: fix chromium style errors in the GN build * refactor: update throttle impl to NOTREACHED and std::make_unqique	2018-09-16 01:42:43 +10:00
Jeremy Apthorp	961147151f	fix: re-enable high-dpi support on windows (#14596) ... fixes #14568	2018-09-13 10:40:29 -05:00
Samuel Attard	7025cbd0c9	feat: add mediaTypes to media permission requests ... This is done to be consistent with setPermissionCheckHandler and to be backwards compatible Fixes #14168	2018-09-13 16:58:57 +10:00
Charles Kerr	d663b4eaee	fix: fix gn cpplint warnings (#14583) ... * chore: fix cpplint 'include_what_you_use' warnings Typically by including <memory>, <utility> etc. * chore: fix 'static/global string constant' warning Use C style strings instead of std::string. Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables /home/charles/electron/electron-gn/src/electron/script/cpplint.js * refactor: remove global string variables. Fix 'global string variables are not permitted' linter warnings by using the base::NoDestructor<> wrapper to make it explicit that these variables are never destroyed. The style guide's take on globals with nontrivial destructors: https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables * fix: initializer error introduced in last commit * fix: remove WIP file that was included by accident * fix: include order * fix: include order * fix: include order * fix: include order, again	2018-09-12 19:25:56 -05:00
Jeremy Apthorp	183a043216	chore: remove unneeded ssize_t hack ... See electron/libchromiumcontent#682	2018-09-12 15:33:59 -07:00
Nitish Sakhawalkar	e90c281ef3	fix: Windows Background color issue (#14561) ... Call InvalidateRect for windows after setting the bg color	2018-09-12 13:41:47 -07:00
Robo	e860748d6b	fix: Invalidate weak ptrs before window Javascript object is destroyed (#14532) ... * fix: Invalidate weak ptrs before window Javascript object is destroyed * chore: add regression test for #14513 This test is similar to the original gist at https://gist.github.com/bpasero/a02a645e11f4946dcca1331d0299149d -- the key is to open multiple windows and add an `app.on('browser-window-focus') listener that accesses window.id. * fix: last commit didn't test the right thing. The test needs to run in the main process to reproduce the conditions reported in #14513	2018-09-12 13:58:04 -05:00
Robo	2cd03bf360	build: remove duplicate devtools sources (#14522) ... * build: remove duplicate devtools sources * build: create separate target for chrome sources * Move sources that are always depended on by electron, starting with security_state_tab_helper.{cc|h} * Add //component/strings to pak for devtools security tab * fix: allow specifying type of the added filesystem. https://chromium-review.googlesource.com/c/chromium/src/+/729250 * fix: do not index excluded folders https://chromium-review.googlesource.com/c/chromium/src/+/972579	2018-09-12 08:45:08 -05:00
Jeremy Apthorp	829b230b85	fix: initialize tracing controller before starting platform (#14499)	2018-09-11 20:24:03 +02:00
Aleksei Kuzmin	7589555cec	inspector: stop dragging platform pointer ... https://github.com/nodejs/node/commit/296fd57324	2018-09-11 20:24:03 +02:00
Aleksei Kuzmin	9f6cf9623c	chore: fix a chromium-style error ... osr_render_widget_host_view.cc:1150:12: error: [chromium-style] auto variable type must not deduce to a raw pointer type. (cherry picked from commit cc8e4ef68376627d20377ae3491df8e4f8dee08e)	2018-09-11 20:24:03 +02:00
Heilig Benedek	1a9e253259	fix: fix osr compilation on Windows	2018-09-11 20:24:03 +02:00
Jeremy Apthorp	5b25c2db5d	Need new #include for base::UTF8ToUTF16	2018-09-11 20:24:03 +02:00
deepak1556	63006aebe8	REVIEW: Delete WidgetDelegate before widget is destroyed. ... Ideally widget delegates must outlive their widget, but since we manage the lifetime of native widget, allow the delegate to be destroyed when widget is destroyed. https://chromium-review.googlesource.com/c/chromium/src/+/977244	2018-09-11 20:24:03 +02:00
Samuel Attard	dc5c49ea7f	SetUserAgentOverride now takes a 2nd override_for_new_tabs argument ... refs: https://chromium-review.googlesource.com/c/chromium/src/+/846713	2018-09-11 20:24:03 +02:00
Samuel Attard	6e2bb728b9	Replace ProxyConfigSource with ProxyConfigWithAnnotation. ... https://chromium-review.googlesource.com/c/chromium/src/+/934126	2018-09-11 20:24:03 +02:00
Samuel Attard	a0a4c7b82c	Implement GetPermissionStatusForFrame in AtomPermissionManager ... Implenation and requirement comes from CR: https://chromium-review.googlesource.com/c/chromium/src/+/940744	2018-09-11 20:24:03 +02:00
Samuel Attard	8a6fccf3d1	[GURL] (1 of 2) Prep for stripping "username:password" from internal schemes ... https://chromium-review.googlesource.com/c/chromium/src/+/978450	2018-09-11 20:24:03 +02:00
Samuel Attard	aa6d769229	Handle external protocols with the network service. ... https://chromium-review.googlesource.com/c/chromium/src/+/956091	2018-09-11 20:24:03 +02:00
Samuel Attard	dde194d853	Remove the memory property from getAppMetrics ... See 03d0bfd593 for more information	2018-09-11 20:24:03 +02:00
Aleksei Kuzmin	833b55107d	Plumb the RenderFrameHost through for CheckMediaAccessPermission ... https://chromium-review.googlesource.com/938862	2018-09-11 20:21:32 +02:00
deepak1556	d15d08bad6	Improve ClearOnExit behavior of cookies using domain matching ... https://chromium-review.googlesource.com/c/chromium/src/+/975861	2018-09-11 20:21:32 +02:00
Aleksei Kuzmin	0afebdc531	The Great Blink mv for source files, part 2. ... https://chromium-review.googlesource.com/1001153	2018-09-11 20:21:32 +02:00
Aleksei Kuzmin	7bd1b85d4e	Rename net/proxy_resolution/proxy_service* files ... https://chromium-review.googlesource.com/941901	2018-09-11 20:21:31 +02:00
Robo	14ed71fa1b	fix: use render client id to track deleted render process hosts (#14520) ... * fix: use render client id to track deleted render process hosts Instead of relying on OS process id, which may not be unique when a process is reused, we rely on the renderer client id passed by the content layer when starting the renderer process which is guaranteed to be unique for the lifetime of the app. * fix: store context id as int64_t Ensuring that it doesn't wrap easily with a large number of context creation on some malformed web pages.	2018-09-11 11:18:10 -07:00
Cheng Zhao	13334d023d	fix: read ignoreMenuShortcuts per WebContents	2018-09-10 19:06:16 +09:00
Nitish Sakhawalkar	a2ab0d8ebe	fix: notify focus change right away rather not on next tick (#14453) ... * fix: Notify focus change right away, not on next tick * fix: emit the JS blur/focus events on next tick to avoid race condition * address feedback from review * fix: bind deferred Emit() calls to a WeakPtr This is so that the deferred Emit() calls will be canceled if the TopLevelWindow is destroyed. * chore: remove wip/test code cruft * fix: make linter happy * Enable disabled tests * refactor: cleaner impl of EmitEventSoon() * Revert "Merge branch 'fix-win-focus' of github.com:electron/electron into fix-win-focus" This reverts commit 90576806eb271d059f0a215c67e9b4b04f7396a4, reversing changes made to 9c13e47779a3af78fe0970c1f3d6cd040a5354e6. * Restore 704722c1, which was removed in error. We apologise again for the fault in the subtitles. Those responsible for sacking the people who have just been sacked have been sacked.	2018-09-07 13:21:58 -05:00
Cheng Zhao	92e094c5f6	fix: manually manage WebContents of webview when it is detached	2018-09-07 15:47:58 +09:00
Nitish Sakhawalkar	826af1d676	fix: macOS Window Title And Accessibility Focus (#14472) ... - Override accessibility method in atom_ns_window - Add title attribute in accessibilityAttributeValue	2018-09-07 09:47:31 +10:00
Robo	35a1849e31	chore: enable debugger api specs (#14475)	2018-09-07 00:44:22 +10:00
Robo	8441d09a18	chore: refactor webContents module isCurrentlyAudible api spec (#14410)	2018-09-05 16:00:05 -05:00
Electron Bot	4d23e200f0	Bump v4.0.0-nightly.20180905	2018-09-05 10:06:13 -07:00
Milan Burda	aa01a7337c	refactor: replace base::Value::DeepCopy and CreateDeepCopy with Clone (#14420)	2018-09-02 17:38:35 -05:00
Milan Burda	c17a1b37ea	feat: add event.senderId property to IPCs sent via ipcRenderer.sendTo (#14395)	2018-08-31 20:13:51 -05:00
Paulius	b89848d683	feat: allow window above full screen windows on mac (#14122) ... * allow window above full screen windows on mac * add visibility change params to higher level files * adress feedback, fix bool issue, remove compilation hooks * adjust readme * switch to options object * single argument for native window views	2018-08-31 15:06:02 -07:00
Shelley Vohr	cbb460d476	Revert "Bump v4.0.0-nightly.20180830" ... This reverts commit 5f00e58029.	2018-08-30 23:12:00 -07:00
Electron Bot	5f00e58029	Bump v4.0.0-nightly.20180830	2018-08-30 22:10:45 -07:00
Milan Burda	5a0770f1d3	fix: allow Tray with title only (without icon) on Mac (#13851)	2018-08-30 21:16:56 +12:00
Samuel Attard	1b7418fb7b	Revert "sec: deprecate some webPreference defaults to be secure-by-default (#14284)" (#14380) ... This reverts commit 66d6ba8689.	2018-08-30 09:57:49 +12:00
Samuel Attard	66d6ba8689	sec: deprecate some webPreference defaults to be secure-by-default (#14284) ... * feat: deprecate default value of nodeIntegration * Use DeprecationStatus::Stable as the default instead of shadowing * change wording of deprecations * chore: also deprecate kWebviewTag and kContextIsolation * chore: do as we preach, lets be secure-by-default in the default app	2018-08-29 13:14:04 -05:00
Robo	edd5c4b9bb	fix: use OS process handle to clear object registry (#14324) ... RenderProcessHost switch can happen between ipc calls when speculative process are invvolved, which will lead to deletion of entries on current context. Use OS process handles to uniquely associate a destruction handler for a render process.	2018-08-28 13:32:46 -05:00
Alexey Kuzmin	7edd37bca1	build: add missing enable_view_api flag (#14351) ... * build: add missing enable_view_api flag Fixes #14340. * fix: properly pass a pointer to a SetLayoutManager() call	2018-08-28 10:55:31 -07:00
Robo	07d017dc01	fix: crash when tray is destroyed (#14347) ... Release the view of status item before destroying it, gives chance to perform cleanup on the view.	2018-08-28 10:45:24 -07:00
Samuel Attard	68da311ed1	feat: add session.setPermissionCheckHandler (#13925) ... * feat: add session.setPermissionCheckHandler to handle syncornous permission checks vs requests * spec: add tests for session.setPermissionCheckHandler * docs: add docs for session.setPermissionCheckHandler * feat: add mediaType to media permission checks * chore: cleanup check impl	2018-08-28 09:05:08 -05:00
Siddharth Dalal	afdb6c5f90	feat: 'will-move' event for windows. (#14283) ... * feat: 'will-resize' window event (Windows only) * documentation for 'will-move' event * comment and line break fix in docs	2018-08-28 08:44:10 -05:00
Samuel Attard	a43a292d18	fix: dont parse arguments after a -- in the inspector (#14297)	2018-08-27 10:50:23 -07:00
Milan Burda	a08ca9defb	fix: don't crash on tray.setContextMenu(null) (#14322)	2018-08-27 11:58:47 -05:00
Milan Burda	2a253c73db	refactor: use std::string instead of base::string16 for IPC channel names (ipcRenderer.sendTo) (#14302)	2018-08-24 15:30:10 -07:00
Emmanuel Kimmerlin	5f6706ac33	feat: BrowserWindow.getNormalBounds() (#13290) ... * First commit * Add Mac support (1st attempt) * Add Mac support (2nd attempt) * Simplify tests * Restore window state ! * Looking at other tests, seems minimize, maximize, fullscreen are skipped when in CI * Fix Mac tests * Restore tests in CI * Fix typo * widget getRestoredBounds not working on Mac !! * widget getRestoredBounds not working on Mac !! * Add IsNormal function * Add IsNormal * IsNormal => isNormal * Deactivate fullscreen on Mac. Do not receive leave-fullscreen event * Set default original_frame_ * Set default original_frame_ * Fix Mac	2018-08-24 14:33:27 -07:00
Milan Burda	c23e7fa101	refactor: implement ipcRenderer.sendTo in native code for better performance (#14285)	2018-08-24 14:14:39 -07:00
Milan Burda	e6e3ccfc50	refactor: use std::string instead of base::string16 for IPC channel names (#14286)	2018-08-24 10:30:37 -05:00
Electron Bot	ef4ae27b52	Bump v4.0.0-nightly.20180823	2018-08-23 21:23:50 -07:00
Robo	bce5bd87a8	fix: opt into location services once device service has been started (#14253) ... * fix: opt into location services once device service has been started * refactor: provide fake location provider to mock geolocation reponses * chore: add spec for navigator.geolocation api using fake location provider	2018-08-23 08:51:46 -07:00
Robo	c8f506a8aa	fix: add method and referrer properties to app login event (#14231) ... * refactor: remove brightray/network_delegate.{cc|h} * refactor: respond to http requests through network delegate	2018-08-23 18:55:13 +09:00
Cheng Zhao	cd8bb1d3b4	chore: print error when removed webview attribute is used (#14230) ... * chore: print error when removed webview attribute is used * docs: document removed webview features	2018-08-23 10:45:43 +09:00
Electron Bot	79eac1fdcb	Bump v4.0.0-nightly.20180821	2018-08-21 13:34:20 -07:00
Samuel Attard	20423df112	Revert "Bump v4.0.0-nightly.20180821" ... This reverts commit 73c43eaea7.	2018-08-21 13:14:37 -07:00
Electron Bot	73c43eaea7	Bump v4.0.0-nightly.20180821	2018-08-21 11:55:32 -07:00
Samuel Attard	5d06c77bf1	Revert "Bump v4.0.0-nightly.20180821" ... This reverts commit d2cd641381.	2018-08-21 11:44:51 -07:00
Electron Bot	d2cd641381	Bump v4.0.0-nightly.20180821	2018-08-21 11:15:56 -07:00
Milan Burda	7253c7f843	refactor: move SpecialStoragePolicy from brightray to atom (#13944)	2018-08-21 08:51:04 -07:00
Heilig Benedek	14ee5b3d3a	fix: enable osr (#14074) ... * fix: re-enable osr * fix: add changes from CEF to add MouseWheelPhaseHandler * fix: re-enable surface synchronization by applying fix from cef * update method call and enable AsyncWheelEvents var * fix: make BrowserCompositorMacGetGutterColor behave like chromium * fix: HANDLE only exists on windows * fix: pass correct params to mouse_wheel_phase_handler_ * fix variable accessing * revert: revert the workaround for disableHardwareAcceleration crash * fix: remove GuestViewCrossProcessFrames from the disabled features list * revert: remove check from BrowserChildProcessLaunchedAndConnected	2018-08-20 09:54:31 -07:00
Keerthi Niranjan	5b48e03c7c	fix: Dialog does not close on ESCAPE if defaultId is set (#14196) ... If defaultId is set, it was removing the key reference for the button at 0 which was previously set for the cancel_id	2018-08-19 13:41:03 -07:00
Electron Bot	dbee03d381	Bump v4.0.0-nightly.20180819	2018-08-19 01:09:28 +00:00
Electron Bot	3ba9a9b7bb	Bump v4.0.0-nightly.20180817	2018-08-17 23:55:31 +00:00
Samuel Attard	f7dc01b2c5	Revert "Bump v4.0.0-nightly.20180817" ... This reverts commit 26248323b4.	2018-08-17 16:52:48 -07:00
Electron Bot	26248323b4	Bump v4.0.0-nightly.20180817	2018-08-17 22:58:18 +00:00
Samuel Attard	1f23c5edc6	Revert "Bump v4.0.0-nightly.20180817" ... This reverts commit b900ea44bf.	2018-08-17 15:53:15 -07:00
Electron Bot	b900ea44bf	Bump v4.0.0-nightly.20180817	2018-08-17 21:40:50 +00:00
Samuel Attard	73f2a7dda9	Revert "Bump v4.0.0-nightly.20180817" ... This reverts commit 76a592a419.	2018-08-17 14:34:31 -07:00
Electron Bot	76a592a419	Bump v4.0.0-nightly.20180817	2018-08-17 20:06:28 +00:00
Cheng Zhao	dd5b8769be	fix: use OOPIF for webview tag (#13869) ... * fix: use OOIF for webview tag * fix: do not call GetNativeView for webview * fix: OOIPF webview's WebContents is managed by embedder frame * fix: guest view can not be focused * fix: clear zoom controller when guest is destroyed * fix: implement the webview resize event The webview is no longer a browser plugin with the resize event, use ResizeObserver instead. * test: disable failed tests due to OOPIF webview * fix: embedder can be destroyed earlier than guest This happens when embedder is manually destroyed. * fix: don't double attach * fix: recreate iframe when webview is reattached * fix: resize event may happen very early * test: some tests are working after OOPIF webview * chore: remove unused browser plugin webview code * fix: get embedder via closure When the "destroyed" event is emitted, the entry in guestInstances would be cleared. * chore: rename browserPluginNode to internalElement * test: make the visibilityState test more robust * chore: guestinstance can not work with OOPIF webview * fix: element could be detached before got response from browser	2018-08-16 15:57:40 -07:00
Samuel Attard	4cf2cde7fb	Bump v4.0.0-nightly.20180816	2018-08-16 08:58:46 -07:00
Robo	9989195f19	fix: notify request context shutdown on IO before cleanup (#14058)	2018-08-14 14:07:53 -07:00
Charles Kerr	b9490177da	Revert "[WIP] refactor: (Part I) make the ownership of URLRequestContextGetter more clear (#13956)" ... This reverts commit 1c0bb06d4a.	2018-08-13 16:16:04 -07:00
Robo	1c0bb06d4a	[WIP] refactor: (Part I) make the ownership of URLRequestContextGetter more clear (#13956) ... * refactor: desttroy URLRequestContextGetter on IO thread * Accepts a factory class that can customize the creation of URLRequestContext * Use a separate request context for media which is derived from the default * Notify URLRequestContextGetter observers and cleanup on IO thread * Move most of brightray net/ classes into atom net/ * refactor: remove refs to URLRequestContextGetter on shutdown * refactor: remove brigtray switches.{cc|h} * refactor: remove brightray network_delegate.{cc|h} * refactor: make AtomURLRequestJobFactory the top level factory. * Allows to use the default handler from content/ for http{s}, ws{s} schemes. * Removes the storage of job factory in URLRequestContextGetter.	2018-08-13 15:22:45 -07:00
Milan Burda	702cc84bd3	Don't pass preloadPath via ELECTRON_BROWSER_SANDBOX_LOAD for security reasons (#13031)	2018-08-10 17:19:49 -05:00
Milan Burda	271d582aac	refactor: make methods const, cleanup (#13937)	2018-08-09 10:15:23 -07:00
Shelley Vohr	9f328abe19	refactor: remove instances of createDeepCopy (#13703) ... * add new native_mate converters for base::Value * fix converter swapping * remove createDeepCopy from browser/api * replace missing ListValue converter * convert bulk of remaining createDeepCopy instances * convert last remaining instances of createDeepCopy * incremental progress and helper methods for value conversion * convert Get and add template function for GetString * final DictionaryValue method conversions * remove usage of base::DictionaryValue in web_contents_preferences * use IsEnabled helper where possible * Update atom_api_web_view_manager.cc	2018-08-04 07:23:07 +10:00
Milan Burda	f904057104	fix: add missing "simple" property in several APIs to prevent proxying of return values (#13905) ... * fix: add missing "simple" property in several APIs to prevent proxying of return values * add tests	2018-08-03 12:07:27 -07:00
Birunthan Mohanathas	23440a5ec3	fix: Improve --enable-features/--disable-features handling (#13920) ... As it turns out, we can reinitialize the feature list directly after the user JS script has been executed instead of much later. This allows modifications to `--enable-features`/`--disable-features` to work with a greater set of features.	2018-08-03 10:53:54 +10:00
Jeremy Apthorp	3bdff2d238	feat: allow setting window shape (#13789) ... This binds Widget::SetShape, an API that already exists in Chromium (for Windows and Linux). It's a more reliable method of having some parts of your window be "click-through" than the current `setIgnoreMouseEvents` API, which messes around with the `WS_EX_LAYERED` window style on Windows, causing strange bugs and incompatibility with hardware acceleration.	2018-07-30 13:37:40 -07:00
Gellert Hegyi	4bcf0e34c5	fix: window.setVibrancy parameter passing (#13627) ... * fix: setVibrancy parameter passing * fix: uses correct parameter types for setVibrancy	2018-07-30 11:29:18 +10:00
Samuel Attard	4b3011f3e8	feat: add getUploadProgress API to the net API (#13783)	2018-07-27 07:15:48 -07:00
Birunthan Mohanathas	c8dc2d3730	feat: Add will-resize event to TopLevelWindow (#13649) ... The new `will-resize` event can be used to prevent the resize from happening before the native window is actually resized. This is in contrast to the existing the `resize` event, which is sent *after* the native window has already been resized. For apps with e.g. custom window snapping logic, the `resize` event is not sufficient because it will result in flickering between the dragged size and the snapped size. `will-resize` is only emitted on macOS and Windows.	2018-07-27 18:53:01 +09:00
Birunthan Mohanathas	a42ca9eecc	feat: Add BrowserWindow.setWindowButtonVisibility() ... Fixes #12701 and supersedes #13131. Ideally we would have added `setTitleBarStyle()`, but that is a significantly more involved change. For example, consider the case where we switch from `hidden` to `normal`. We would not only have to show the traffic light buttons, we would also have to switch the window from a frameless to a framed window and deal with various other window state. Lets instead implement a simple solution for #12701.	2018-07-25 10:12:27 -07:00
Cheng Zhao	305e3aad40	refactor: remove private webContents.getId() API (#13674)	2018-07-23 18:08:36 +09:00
John Kleinschmidt	f8b646c90a	Merge pull request #13543 from electron/ajm-win7-crash ... Ensure DirectX capturer is supported.	2018-07-19 15:11:42 -04:00
Samuel Attard	777d0113d5	fix: create a window capturer correctly (#13689) ... * fix: create a window capturer correctly We were incorrectly creating two screen capturers instead of a window capturer * spec: ensure dc tests pass * spec: enable all tests after verifying dc tests work	2018-07-17 14:20:50 +10:00
Shelley Vohr	6045d1218a	refactor: remove experimentalCanvasFeatures property (#13684)	2018-07-16 13:32:42 -07:00
Cheng Zhao	4a7c85f43e	fix: use InspectableWebContentsView as content view	2018-07-16 10:20:35 +09:00
John Kleinschmidt	539b554ecc	Merge pull request #13578 from electron/miniak/refactoring ... refactor: statically link functions available on Windows 7+	2018-07-13 10:52:37 -04:00
Cheng Zhao	77ca5b7d64	fix: don't invoke callback after FrameSubscriber is destroyed (#13657)	2018-07-13 19:54:49 +10:00
Milan Burda	adaa32003d	refactor: DwmGetColorizationColor does not have to be dynamically resolved	2018-07-12 22:28:44 +02:00
Felix Rieseberg	deedf6c3f4	feat: Add isCurrentlyAudible() to WebContents (#13614) ... * 🔧 Add isCurrentlyAudible() to WebContents * ❤️ Implement feedback, use await to wait for event * 👷 Add missing imports	2018-07-12 21:35:11 +10:00
Cheng Zhao	0ec4ad288d	fix: fallback to FullSizeContentView for frameless window on mac (#13599) ... fix: draggable regions not working on macOS	2018-07-10 11:43:42 +10:00
Andrew MacDonald	7639e4a32a	Actually try building on Windows.	2018-07-03 01:03:05 -07:00
Andrew MacDonald	68541f2ae8	Ensure DirectX capturer is supported.	2018-07-02 21:37:10 -07:00
Maxine Whitely	6cf68f8247	fix: tray setContextMenu crash (#13513) ... Co-authored-by: Zhuo Lu <sethlu@mintkit.net> Co-authored-by: Kristine Zhang <kzhang@slack-corp.com>	2018-06-29 14:48:26 -07:00
Jeremy Apthorp	3d4487ccfd	Merge pull request #13463 from electron/remove_wtl ... refactor: Using win32 file open api instead of WTL	2018-06-29 10:00:50 -07:00
Jeremy Apthorp	733e495e91	chore: use full path for ui_unscaled_resources.h (#13492) ... This is the path that resolves in Chromium, it also works fine in the gyp build.	2018-06-28 14:41:37 -07:00
Jeremy Apthorp	d6af3bfcd2	chore: fix more chromium-style errors in windows code (#13487) ... Finding more chromium-style linting errors as I build more of the windows code :)	2018-06-28 14:20:11 -07:00
Shelley Vohr	003a92e099	refactor: remove deprecated GetAs methods (#13425) ... * refactor: remove deprecated GetAs methods * restructure URLRequestAsyncAsarJob on win * fix: add string conversion header	2018-06-27 14:52:48 -07:00
Samuel Attard	92588be2bd	refactor: add promise helper and change whenReady to be native impl (#13115) ... * Add promise helper and change whenReady to be native impl * remove commented code * add GetInner helper to dedupe promise code * add Promise.reject helper to be consistent with JS * fix linting * update promise impl per feedback * remove param name from unused isolate * Use non-depreceated resolvers for promises * Add thread dchecks for promise helper, intiialize promise pointer to nullptr	2018-06-27 16:06:08 -05:00
zacwalk	9db76394f7	Link gdi from gyp	2018-06-27 20:58:37 +02:00
Zac Walker	8151c90c6b	Fix warnings as error fixes.	2018-06-27 16:28:12 +02:00
Zac Walker	f122c44b07	Using win32 file open dialogs instead of WTL	2018-06-27 13:09:18 +02:00
Jeremy Apthorp	4b60efcaf8	chore: [gn] fix WTL include paths and namespace include (#13433) ... As of libchromiumcontent#576, the WTL namespace isn't included by default in the GN build.	2018-06-26 22:57:40 +02:00
Jeremy Apthorp	78bc1081fd	chore: fix some more warnings in windows build (#13431) ... Remove an unused function and fix an int type comparison warning. Only showed up when building with GN.	2018-06-26 02:00:20 +02:00
Jeremy Apthorp	6f91af9343	chore: fix various chromium-style errors in windows (#13394) ... These errors weren't previously picked up because the GN build wasn't running on Windows.	2018-06-25 22:30:00 +02:00
deepak1556	5e2406081e	build: move pepper flash behind feature flag	2018-06-21 17:02:12 +05:30
Jeremy Apthorp	8ccb5cc6eb	chore: Annotate fallthrough switch paths with FALLTHROUGH ... The compiler was throwing errors about unannotated fallthroughs when building with GN.	2018-06-20 14:38:18 -07:00
Jeremy Apthorp	3f40e93ba7	chore: fix chromium-style errors in frame_subscriber ... The chromium-style linter we run in the GN build was throwing errors about these issues.	2018-06-20 14:14:11 -07:00
Milan Burda	122d00f415	Revert "Drop support of Mac OS 10.9" (#13348) ... This reverts commit efa0ec0263481ae188f206625bec6f4a4e5d3ecf.	2018-06-20 13:40:18 -07:00
Samuel Attard	79fbd6bab1	Revert "fix: Drop support for OS X Mavericks (version 10.9)" (#13333)	2018-06-20 07:27:55 -05:00
Husayn	1a8c986fb1	set mac protocol to none (#13302)	2018-06-20 13:16:37 +10:00
Shelley Vohr	c20e0c30a2	src: base::Value::HasKey(key) => base::Value::FindKey(key) (#13312)	2018-06-20 13:07:10 +10:00
John Kleinschmidt	04a7a34c42	Merge pull request #13301 from electron/revert-frame-sub-deprecation ... fix: revert frame subscriber deprecation and re-enable tests	2018-06-19 14:26:14 -04:00
Heilig Benedek	f643ce4f66	revert: frame subscriber deprecation and re-enable tests	2018-06-19 19:49:44 +02:00
John Kleinschmidt	d367b75680	Merge pull request #13296 from electron/miniak/drop-macos-10.9 ... fix: Drop support for OS X Mavericks (version 10.9)	2018-06-19 13:19:24 -04:00
Milan Burda	794fe741e9	fix: Drop support for OS X Mavericks (version 10.9)	2018-06-19 17:49:27 +02:00
Justin Guze	137aaf2429	fix: pass down the bool value of enableAutoSize to setSize (#13282) ... * fix: pass the boolean value of enableAutoSize to setSize The webContents setSize API takes in an optional enableAutoSize boolean. Looking in the code, if that property is set, regardless if you pass in true or false, it will always set it to true. This change passes the appropriate boolean value down properly. * creating new bool for autosize	2018-06-19 10:38:55 -05:00
Jeremy Apthorp	9e8f83e25c	refactor: fix chromium-style in url_request_asar_job (#13284)	2018-06-19 10:31:55 -05:00
Milan Burda	d5d5386017	use std::make_unique<T>	2018-06-19 10:20:39 +02:00
Samuel Attard	2720fa751b	Fix windows desktop_capturer build	2018-06-19 15:29:16 +10:00
Samuel Attard	9d18be8fde	Remove removed variable popup_bounds_in_view_	2018-06-19 11:58:26 +10:00
Samuel Attard	5a28759fea	post all desktop capturer apis to worker threads	2018-06-19 11:49:46 +10:00
Samuel Attard	8200a132be	Re-enable cookie specs and add custom cookie name/url validation	2018-06-19 11:49:46 +10:00
Aleksei Kuzmin	f4a9575193	Drop support of Mac OS 10.9 ... - set minimum deployment target to 10.10 - set minimum system version to 10.10	2018-06-19 11:49:45 +10:00
Heilig Benedek	65b8dd48d8	Update OSR code	2018-06-19 11:49:44 +10:00
Heilig Benedek	60ba2013c4	Re-add dirtyOnly to FrameSubscriber and document API change	2018-06-19 11:49:44 +10:00
Heilig Benedek	b9413fe59d	Update FrameSubscriber implementation	2018-06-19 11:49:44 +10:00
Nitish Sakhawalkar	ca8843102a	Fix duplicate RTCDispatcher console error for debug build. ... The solution was to call CreateScreenCapturer from content, and not link the static library in.	2018-06-19 11:49:44 +10:00
Aleksei Kuzmin	90c3d87e21	Rename LocalSurfaceIdAllocator ... https://chromium-review.googlesource.com/809886	2018-06-19 11:49:44 +10:00
Tomas Rycl	1ac0ab2b71	Include missing "windows.h" and fix headers ordering ... For PCWSTR on line 198.	2018-06-19 11:49:43 +10:00
Aleksei Kuzmin	d6ffbc0148	Use an int for wm::ShadowElevation. Pick semantic constants. ... https://chromium-review.googlesource.com/899886	2018-06-19 11:49:43 +10:00
Aleksei Kuzmin	4a38c2d800	Remove deprecated View::SetLayoutManager ... https://chromium-review.googlesource.com/844760	2018-06-19 11:49:43 +10:00
Aleksei Kuzmin	f6648a0d4d	Remove ScopedComPtr and scoped_comptr.h ... https://chromium-review.googlesource.com/726461	2018-06-19 11:49:43 +10:00
Aleksei Kuzmin	82d204e932	Wrap X11 headers in ui/gfx/x/x11.h ... https://chromium-review.googlesource.com/756711	2018-06-19 11:49:43 +10:00
Heilig Benedek	1de1ca906a	Reimplement FrameSubscriber with mojo VideoCapture APIs	2018-06-19 11:49:43 +10:00
deepak1556	4068a62fa6	Define gfx::AcceleratedWidget to be uint64_t instead of NSView* ... https://chromium-review.googlesource.com/c/chromium/src/+/792295	2018-06-19 11:49:42 +10:00
deepak1556	c4b8e106c0	Create network_converter for services/network/* types	2018-06-19 11:49:42 +10:00
deepak1556	77f427acc8	Check for key system support using new mojo service KeySystemSupport ... https://chromium-review.googlesource.com/c/chromium/src/+/834764	2018-06-19 11:49:42 +10:00
deepak1556	5df0362361	Remove obsolete ShouldHandleSystemCommands function. ... https://chromium-review.googlesource.com/c/chromium/src/+/924315	2018-06-19 11:49:42 +10:00
deepak1556	66058c8cfe	REVIEW: Use RenderWidgetHost api for event routing ... https://chromium-review.googlesource.com/c/chromium/src/+/836267	2018-06-19 11:49:42 +10:00
deepak1556	d386ec0a2b	Remove unused elements from RWHV::CopyFromSurface() API and dead code. ... https://chromium-review.googlesource.com/c/chromium/src/+/929874	2018-06-19 11:49:42 +10:00
deepak1556	3ad0639b2e	Surface synchronization: Implement auto-resize for OOPIF/BrowserPlugin ... https://chromium-review.googlesource.com/c/chromium/src/+/753801	2018-06-19 11:49:42 +10:00
deepak1556	ea7e273a06	gin: Make gin/ remember external reference table ... https://chromium-review.googlesource.com/c/chromium/src/+/778741	2018-06-19 11:49:42 +10:00
deepak1556	383b21e20a	Change calls to GeolocationProvider::UserDidOptIntoLocationServices() to occur via Mojo. ... https://chromium-review.googlesource.com/c/chromium/src/+/760239	2018-06-19 11:49:42 +10:00
deepak1556	a5bdb8103b	Remove invalid include headers	2018-06-19 11:49:42 +10:00
deepak1556	0cbffb15cc	NetworkService: Implement URLLoader::OnAuthRequired ... https://chromium-review.googlesource.com/c/chromium/src/+/938960	2018-06-19 11:49:42 +10:00
deepak1556	27cb84eee0	NetworkService: Implement URLLoader::OnCertificateRequested ... https://chromium-review.googlesource.com/c/chromium/src/+/848303	2018-06-19 11:49:42 +10:00
deepak1556	b268e37663	Simplify ShouldInterceptResourceAsStream to remove unneeded code path. ... https://chromium-review.googlesource.com/c/chromium/src/+/939857	2018-06-19 11:49:42 +10:00
deepak1556	c9f20516ac	Make reading blobs work through Blob mojo interface. ... https://chromium-review.googlesource.com/c/chromium/src/+/773199	2018-06-19 11:49:42 +10:00
deepak1556	a1683eb4e8	Give the JS dialog manager the alerting frame. ... https://chromium-review.googlesource.com/c/chromium/src/+/928828 https://chromium-review.googlesource.com/c/chromium/src/+/791517	2018-06-19 11:49:42 +10:00
deepak1556	eab4227cbf	Make Origin(const GURL&) constructor private. ... https://chromium-review.googlesource.com/c/chromium/src/+/729284	2018-06-19 11:49:42 +10:00
deepak1556	11fc8374c0	Move DownloadUrlParameters from content/public to components/download ... https://chromium-review.googlesource.com/c/chromium/src/+/914232	2018-06-19 11:49:42 +10:00
deepak1556	8968c447f4	Include missing header	2018-06-19 11:49:41 +10:00
deepak1556	7b47d69efe	Remove did-get-response-details and did-get-redirect-request events ... https://chromium-review.googlesource.com/c/chromium/src/+/805008 https://chromium-review.googlesource.com/c/chromium/src/+/786320	2018-06-19 11:49:41 +10:00
deepak1556	2ea26cd4d7	Add MediaStoppedReason to WCO ... https://chromium-review.googlesource.com/c/chromium/src/+/758583	2018-06-19 11:49:41 +10:00
deepak1556	100291ec42	OOPIF-ize hung renderers ... https://chromium-review.googlesource.com/c/chromium/src/+/896343	2018-06-19 11:49:41 +10:00
deepak1556	2047929cb5	Convert ax_enums.idl to mojom. ... https://chromium-review.googlesource.com/c/chromium/src/+/877417	2018-06-19 11:49:41 +10:00
Aleksei Kuzmin	bb150185ac	Fix includes in AtomQuotaPermissionContext	2018-06-19 11:49:41 +10:00
Aleksei Kuzmin	c75f6f408e	DevTools: remove the 'forced' attribute from the AgentHostClosed in DevToolsAgentHost. ... https://chromium-review.googlesource.com/745301	2018-06-19 11:49:41 +10:00
Aleksei Kuzmin	4bb3e0da15	Rename buildflag_header targets in base for consistency ... https://chromium-review.googlesource.com/930033	2018-06-19 11:49:41 +10:00
Aleksei Kuzmin	576bf8f6c0	Move resource_response.h to //services/network/public/cpp. ... https://chromium-review.googlesource.com/865664	2018-06-19 11:49:41 +10:00
deepak1556	b7bc3ec20d	Update AtomBrowserClient::RenderProcessWillLaunch api ... https://chromium-review.googlesource.com/c/chromium/src/+/742344	2018-06-19 11:49:41 +10:00
deepak1556	409ff41c03	Remove SetCookieWithDetailsAsync API in favor of SetCanonicalCookieAsync. ... https://chromium-review.googlesource.com/c/chromium/src/+/777954	2018-06-19 11:49:41 +10:00
deepak1556	23f7ccbdda	Remove old cookie enum values ... https://chromium-review.googlesource.com/c/chromium/src/+/877515	2018-06-19 11:49:41 +10:00
Aleksei Kuzmin	343c42e4ef	Remove redundant device::PowerSaveBlocker enums. ... https://chromium-review.googlesource.com/754169 services/device: Fix enum naming in wake_lock.mojom. https://chromium-review.googlesource.com/755884	2018-06-19 11:49:41 +10:00
Aleksei Kuzmin	37168c0a95	Move ResourceRequestBody to services/network in preparation of moving content/network. ... https://chromium-review.googlesource.com/864422	2018-06-19 11:49:41 +10:00
deepak1556	d3c6aa12d1	Remove AtomAccessTokenStore ... Its a dummy class since chromium 63, https://chromium-review.googlesource.com/c/chromium/src/+/708494	2018-06-19 11:49:41 +10:00
deepak1556	bb36a26950	update native-mate ref	2018-06-19 11:49:41 +10:00
Aleksei Kuzmin	6b77fa5b3b	[desktop capture] remove dependencies on webrtc/desktop_capture from /chrome ... https://chromium-review.googlesource.com/876723	2018-06-19 11:49:41 +10:00
Aleksei Kuzmin	160b165358	move DownloadInterruptReasons from content/ to components/download ... https://chromium-review.googlesource.com/897967	2018-06-19 11:49:40 +10:00
Aleksei Kuzmin	7fc8814d13	move some files from content/public/browser to components/download/public/core ... https://chromium-review.googlesource.com/891686	2018-06-19 11:49:40 +10:00
Aleksei Kuzmin	4e580d5b39	Move download_item.h from content/public to components/download ... https://chromium-review.googlesource.com/907687	2018-06-19 11:49:40 +10:00
Aleksei Kuzmin	a315d6330c	Remove base::Value::IsType ... https://chromium-review.googlesource.com/659798	2018-06-19 11:49:40 +10:00
deepak1556	e3c580e905	Move away from BrowserThread::FILE ... * Migrate TtsPlatformImplLinux away from using BrowserThread::FILE. https://chromium-review.googlesource.com/c/chromium/src/+/570022 * Move PdfConverter off the FILE thread. https://chromium-review.googlesource.com/c/chromium/src/+/592393 * https://chromium.googlesource.com/chromium/src/+/master/docs/task_scheduler_migration.md	2018-06-19 11:49:40 +10:00
deepak1556	6d241e972b	Clean up net::HttpAuthPreferences. ... https://chromium-review.googlesource.com/c/chromium/src/+/727399	2018-06-19 11:49:40 +10:00
deepak1556	8e125b2953	REVIEW: Remove the notification close-closure in favour of an explicit method ... https://chromium-review.googlesource.com/c/chromium/src/+/744205	2018-06-19 11:49:40 +10:00
deepak1556	026e7bff40	Update NetworkDelegate ... * Remove Deprecated OnResponseStarted. https://chromium-review.googlesource.com/c/chromium/src/+/763193 * Replace cookie lines with CanonicalCookie in CanSetCookie delegates. https://chromium-review.googlesource.com/c/chromium/src/+/775606 * Reporting: Check upload permissions asynchronously https://chromium-review.googlesource.com/c/chromium/src/+/937566	2018-06-19 11:49:40 +10:00
deepak1556	bf55d856d2	Cookie Store: Extract change notifications to separate classes. ... https://chromium-review.googlesource.com/c/chromium/src/+/919159	2018-06-19 11:49:40 +10:00
deepak1556	806acbdf12	Move content/network to services/network. ... https://chromium-review.googlesource.com/891646	2018-06-19 11:49:40 +10:00
Aleksei Kuzmin	fba2ab0996	Move throttling to network service ... https://chromium-review.googlesource.com/703674	2018-06-19 11:46:59 +10:00
deepak1556	529ced80f2	Remove CancelRequest for PermissionManager ... https://chromium-review.googlesource.com/c/chromium/src/+/876746	2018-06-19 11:46:59 +10:00
deepak1556	f6665edc73	Convert ColorChooser from ipc to mojo. ... https://chromium-review.googlesource.com/c/chromium/src/+/800350 https://chromium-review.googlesource.com/c/chromium/src/+/821954	2018-06-19 11:46:59 +10:00
Aleksei Kuzmin	7c95100180	Rename ProxyService class to ProxyResolutionService ... https://chromium-review.googlesource.com/857421	2018-06-19 11:46:59 +10:00
Aleksei Kuzmin	079e5df740	Adds ability for BrowserMainParts::PreEarlyInitialization() to fail ... https://chromium-review.googlesource.com/862964	2018-06-19 11:46:59 +10:00
Aleksei Kuzmin	408b62bcc2	Move net/proxy to net/proxy_resolution ... https://chromium-review.googlesource.com/868176 Also includes changes from: Rename files relating to PAC (proxy auto config). https://chromium-review.googlesource.com/836927	2018-06-19 11:46:58 +10:00
Zhuo Lu	ab24a1e36d	feat: netLog API for dynamic logging control (#13068) ... * Introduce `net.{start|stop}Logging()` - Slight regression right now as Electron won't automatically start logging net-logs at launch, will soon be fixed - To implement callback for async controls * Add `net.isLogging` & optional callback param for `net.stopLogging()` * Fix small regression on --log-net-log --log-net-log should work again * Error on empty file path * Only start with valid file path * Remove unused var * Allow setting log file path before URLRequestContextGetter starts logging * Add net log tests * Remove redundant checks * Use brightray::NetLog * Clean up code * Should automatically stop listening * 🎨 Attempt to fix styles * Only run non-null callback * Dump file to tmpdir * Simplify net log spec Spawned Electron process on Linux CI can fail to launch * Separate netLog module * Remove net logging test from net spec * Add tests for netLog * Fix header guard * Clean up code * Add netLog.currentlyLoggingPath * Callback with filepath * Add test for case when only .stopLogging() is called * Add docs * Reintroduce error on invalid arg * Update copyright * Update error message * Juggle file path string types	2018-06-19 11:45:58 +10:00
Heilig Benedek	90911a423a	Fix autofill popup position when the popup is spawned from a webview (#13184)	2018-06-18 10:15:37 -05:00
Cheng Zhao	a11182ca84	feat: add SetText for TextField	2018-06-18 16:51:36 +09:00
Cheng Zhao	70e17b5f8f	feat: add LabelButton API	2018-06-18 16:51:36 +09:00
Cheng Zhao	c8e8cb86ce	feat: add Button API	2018-06-18 16:51:36 +09:00
Cheng Zhao	ba3700141f	feat: add TextField API	2018-06-18 16:51:36 +09:00
Milan Burda	2eb5b751f3	exit HTML fullscreen when window leaves fullscreen (#13090)	2018-06-18 16:48:20 +09:00
Milan Burda	28fd571d0c	refactoring: use std::make_unique<T> (#13245)	2018-06-18 16:32:55 +09:00
Michael Khalil	ef1e2d6fe0	fix: tray title not inverting when highlighted (#13085)	2018-06-16 16:24:26 +10:00
Milan Burda	c4942d931c	Add FILE_DIALOG_TREAT_PACKAGE_APP_AS_DIRECTORY to web open file dialog (#13220)	2018-06-15 15:51:38 -05:00
Thiago de Arruda	6ff111a141	perf: don't use JSON to send the result of ipcRenderer.sendSync. (#8953) ... * Don't use JSON to send the result of `ipcRenderer.sendSync`. - Change the return type of AtomViewHostMsg_Message_Sync from `base::string16` to `base::ListValue` - Adjust lib/browser/api/web-contents.js and /lib/renderer/api/ipc-renderer.js to wrap/unwrap return values to/from array, instead of serializing/deserializing JSON. This change can greatly improve `ipcRenderer.sendSync` calls where the return value contains Buffer instances, because those are converted to Array before being serialized to JSON(which has no efficient way of representing byte arrays). A simple benchmark where remote.require('fs') was used to read a 16mb file got at least 5x faster, not to mention it used a lot less memory. This difference tends increases with larger buffers. * Don't base64 encode Buffers * Don't allocate V8ValueConverter on the heap * Replace hidden global.sandbox with NodeBindings::IsInitialized() * Refactoring: check NodeBindings::IsInitialized() in V8ValueConverter * Refactor problematic test to make it more reliable * Add tests for NaN and Infinity	2018-06-13 17:38:31 +10:00
mdpetuum	1b8790aeb2	fix: tray icon bounds didn't allow negative macOS (#13162)	2018-06-07 18:48:39 +02:00
Charles Kerr	b89fe86fa1	Merge pull request #13050 from electron/3.0.0-deprecations ... chore: removal of 3.0.0 deprecations	2018-05-30 09:25:36 +02:00
Charles Kerr	6935addd38	fix: remove unused variable	2018-05-29 16:14:21 +02:00
Milan Burda	45e78728bd	chore: move more constants to options_switches.h/cc (#13093) ... * Add options::kNativeWindowOpen * Add options::kSandbox * Add options::kPlugins * Add options::kWebSecurity * Add options::kAllowRunningInsecureContent * Add options::kOffscreen	2018-05-29 03:09:51 -05:00
Shelley Vohr	8bb7525fe0	fix missing instance of kBlinkFeatures => kEnableBlinkFeatures	2018-05-25 11:12:40 -07:00
Cheng Zhao	0f7c25fc63	Put View APIs under a build flag	2018-05-24 15:44:07 +09:00
Cheng Zhao	2c8dc9e0bd	Add View.addChildView API	2018-05-24 15:36:29 +09:00
Cheng Zhao	322bde526c	Add LayoutManager/BoxLayout APIs	2018-05-24 15:36:29 +09:00
Shelley Vohr	bc10be3de6	rename exposed session method to setCertificateVerifyProc	2018-05-23 13:51:28 -07:00
Shelley Vohr	4a90056462	remove webContents.openDevTools() deprecation	2018-05-23 09:30:15 -07:00
Shelley Vohr	3deffa859d	remove appcommand media-play_pause option deprecation	2018-05-23 09:24:32 -07:00
Shelley Vohr	003a5a0160	remove tray.setHighlightMode() deprecation	2018-05-23 09:20:39 -07:00
Shelley Vohr	72c63a10ee	remove screen.getMenuBarHeight() deprecation	2018-05-23 09:11:48 -07:00
Milan Burda	2337237d58	Refactoring: use C++11 class member variable initialization	2018-05-22 00:18:38 +02:00
Cheng Zhao	595b0663b2	WebContents may be managed by multiple owners	2018-05-21 10:53:09 +09:00
Cheng Zhao	3b81312cf7	clear pointer when WebContents is closed	2018-05-21 10:53:09 +09:00
Cheng Zhao	51db1efb8a	prevent double-adding a WebContents to view	2018-05-21 10:53:09 +09:00
Cheng Zhao	aeeb2a259f	destruct objects in stack order	2018-05-21 10:53:09 +09:00
Cheng Zhao	fd4a0626c5	destroy WebContents when view is destroyed	2018-05-21 10:53:08 +09:00
htk3	7c2303c758	Correct app-command name of APPCOMMAND_MEDIA_PLAY_PAUSE (#12408) ... * correct app-command name * add compatibility with old app-command name * add temporary compatibility with old app-command name * add a comment saying that media-play_pause is deprecated * fix lint	2018-05-21 10:52:04 +09:00
Heilig Benedek	8b2bffcf9e	Only expand maximum size constraint if there was a constraint originally (#13003)	2018-05-21 10:56:45 +10:00
Jeremy Apthorp	156a97b80d	fix: Menu.setApplicationMenu(null) crash on Linux (#12983)	2018-05-18 10:29:28 -07:00
Zhuo Lu	d2653e8192	Fix: Prevent menu update while it's open (#12809) ... * Update application menu on default runloop Menu change should be prevented while the menu is open * Fix code style * Memory safety	2018-05-17 11:19:28 +10:00
Jeremy Apthorp	da0fd10423	refactor: chromium-style warnings in linux code (#12949)	2018-05-16 14:12:45 -05:00
John Kleinschmidt	9488ef4867	Merge pull request #12496 from mikeykhalil/8952-ignore-tray-double-click-events ... 8952 option to ignore tray double click events	2018-05-16 10:17:36 -04:00
John Kleinschmidt	e1c374de6e	Merge pull request #12954 from electron/web-dialog-helper ... Fix empty description when only one extension is given (GetFileTypesFromAcceptType)	2018-05-16 10:15:54 -04:00
Milan Burda	211d7825d3	feat: DIP <-> screen coordinate conversions (#12879)	2018-05-16 18:34:09 +09:00
Milan Burda	9d9d6ca20b	Fix empty description when only one extension is given	2018-05-16 01:58:58 +02:00
Jeremy Apthorp	73eb5af2cc	refactor: remove unnecessary std::moves in linux code (#12951) ... The compiler was complaining that the move was preventing copy elision.	2018-05-15 14:33:47 -07:00
Jeremy Apthorp	8fa48d1c04	fix: unused variable warnings in linux code (#12950)	2018-05-15 13:49:27 -05:00
Jeremy Apthorp	136105e353	fix: wrong list index type in file_dialog_gtk.cc (#12952)	2018-05-15 13:22:52 -05:00
Cheng Zhao	2f3fcb9dbe	give window a default content view ... Certain APIs are expecting the window to have a content view, having a default one simplifies our design.	2018-05-15 14:12:47 +09:00
Cheng Zhao	ea97f43145	check content view in SetMenuBarVisibility	2018-05-15 14:12:47 +09:00
Cheng Zhao	bb2715e7a5	feat: add TopLevelWindow.setContentView API	2018-05-15 14:12:47 +09:00
Cheng Zhao	2b24b26e59	refactor: do not pass WebContents to NativeWindow	2018-05-15 14:03:21 +09:00
Cheng Zhao	640877ebf8	attach native view after widget is created	2018-05-15 14:03:21 +09:00
Cheng Zhao	5a320222e2	feat: add WebContentsView API	2018-05-15 14:03:21 +09:00
Cheng Zhao	e058d11657	feat: add View API	2018-05-15 14:03:21 +09:00
John Kleinschmidt	0fd8513c80	Merge pull request #12904 from electron/fix-12875 ... Allow frameless transparent windows to be sized smaller than 64x64 on Windows	2018-05-14 10:46:40 -04:00
Heilig Benedek	ce8af7d499	#else instead of #elif	2018-05-12 22:05:25 +02:00
Heilig Benedek	c6bf39b283	Only include windows headers on windows	2018-05-12 21:33:47 +02:00
Heilig Benedek	f1fd457411	Format code with clang-format	2018-05-12 19:51:19 +02:00
Heilig Benedek	eae0674f61	Match chromium's workaround when setting size of unresizable windows	2018-05-12 17:37:31 +02:00
Jeremy Apthorp	cc386f2345	Merge pull request #12884 from nornagon/views-defines ... Require !OS_MACOSX as well as TOOLKIT_VIEWS for views code	2018-05-10 14:13:19 -07:00
Jeremy Apthorp	72057bf7ef	clang-format atom_api_web_contents.cc	2018-05-10 14:11:19 -07:00
Jeremy Apthorp	87d0175c76	Require !OS_MACOSX as well as TOOLKIT_VIEWS for views code	2018-05-10 14:11:19 -07:00
Jeremy Apthorp	73ac019882	Fix up #includes to work with both GYP and GN	2018-05-10 13:38:40 -07:00
Samuel Attard	5b5c161601	feat: new makeSingleInstance API (#12782) ... * Refactor app.makeSingleInstance * new API `app.isPrimaryInstance()` * new API `app.isSingleInstance()` * new event `app.on('second-instance')` * deprecated old syntax `app.makeSingleInstance(cb)` * deprecated old syntax of `app.makeSingleInstance() --> bool` in favor of `app.isPrimaryInstance()` * Fix spec, we don't need process.nextTick hacks any more * Make deprecation TODO for the return value of makeSingleInstance * Refactor makeSingleInstance to requestSingleInstanceLock and add appropriate deprecation comments * I swear this isn't tricking the linter * Make const * Add deprecation warnings for release, and add to planned-breaking-changes BREAKING CHANGE	2018-05-08 01:29:18 +10:00
Jeremy Apthorp	b280ea5579	chromium-style fixes (#12826)	2018-05-03 23:45:12 -07:00
Cheng Zhao	a2c3db666e	viewDidMoveToSuperview may not be implemented	2018-05-04 09:55:09 +09:00
Cheng Zhao	5547df6073	report correct content size in AtomNSWindow ... The views framework relies on NSWindow to return content size of window, since we don't use the borderless window, the original result would include titlebar. We have to override the function to return correct result for frameless window.	2018-05-04 09:55:09 +09:00
Cheng Zhao	28fc58067b	remove usage of FullSizeContentView	2018-05-04 09:55:09 +09:00
Cheng Zhao	a9709a635c	display WebContents as views::View on macOS	2018-05-04 09:55:09 +09:00
Cheng Zhao	ada884a129	refactor: setup contentView on initialization	2018-05-04 09:55:09 +09:00
mikeykhalil	94ffd4bfc0	add getter for ignoreDoubleClickEvents field	2018-05-03 13:49:33 -07:00
mikeykhalil	208374afa4	clean up ignore double click event implementation	2018-05-03 13:49:33 -07:00
mikeykhalil	1f29124d11	updated Tray API to ignore double click events on macOS (#8952)	2018-05-03 13:49:32 -07:00
Jeremy Apthorp	cdc5022305	Fix chromium-style errors (#12802)	2018-05-03 09:04:22 -05:00
bughit	55a7f6f0ce	add did-frame-navigate event to WebContents (#12723) ... * add did-frame-navigate event to WebContents, pass http response code to it and did-navigate * docs for frame routing id related api changes on WebFrame and WebContents	2018-05-01 13:34:41 +09:00
Cheng Zhao	c67d1b62e3	refactor: NativeWindowViews should not be a View (#12750)	2018-05-01 13:28:22 +09:00
Samuel Attard	338a816ffd	Screen Lock / Unlock events (#12714) ... * initial lock-screen and unlock-screen event implementation for macOS * Implementation of lock-screen and unlock-screen on windows	2018-05-01 02:04:27 +10:00
Cheng Zhao	089428857c	remove unnecessary defines	2018-04-30 10:56:54 +09:00
Cheng Zhao	e07ea24610	remove unnecessary static_cast	2018-04-30 10:56:54 +09:00
Cheng Zhao	2225cc9608	refactor: manage widget_ in NativeWindow	2018-04-30 10:56:54 +09:00
Cheng Zhao	727cd68cee	refactor: Use widget() instead of window_	2018-04-30 10:56:54 +09:00
Cheng Zhao	6d18bd0633	refactor: Make NativeWindow inherit WidgetDelegate	2018-04-30 10:56:54 +09:00
Zeke Sikelianos	cc98bd6b6d	Merge pull request #12662 from electron/prevent-default ... Stop overwriting prevent_default if default wasn't prevented	2018-04-26 12:12:18 -07:00
Jeremy Apthorp	dd7e0f80fe	Turn off visual zoom by default (#12679)	2018-04-26 10:27:35 -05:00
Jeremy Apthorp	1a64b9f0c2	Disable navigating on drag/drop (#12655) ... * Disable navigating on drag/drop * Add a WebPreferences option to re-enable navigate on drag/drop	2018-04-26 10:23:27 -05:00
bughit	4fcd178c36	expose WebFrame#routingId (#12614) ... * expose WebFrame#routingId and pass it to WebContents frame specific events along with frameProcessId; add WebContets.did-start-navigation event * fix compilation error on ia32 Windows	2018-04-26 19:17:55 +09:00
Cheng Zhao	cf70267871	remove unnecessary overrides	2018-04-26 09:48:12 +09:00
Cheng Zhao	5e48dd9d45	be aware of views::Widget's layer	2018-04-25 15:10:29 +09:00
Cheng Zhao	39242c978f	fix failed BrowserWindow tests	2018-04-25 15:10:29 +09:00
Cheng Zhao	75a624434c	refactor: use views::Widget on macOS	2018-04-25 15:10:29 +09:00
Nitish Sakhawalkar	2579071b98	Deprecate did-get-response-details and did-get-redirect-request (#12615) ... * Deprecate webContents events did-get-response-details and did-get-redirect-request. * Update guest view files * Update webview tag docs and update specs * Update deprecate.event function * Update comment * Update more * Update documentation for other deprecated event	2018-04-23 14:46:12 -05:00
Shelley Vohr	12a57ff1c2	clang-format objc files (#12673)	2018-04-20 11:47:04 -07:00
Cheng Zhao	28b85762fd	Merge pull request #12660 from electron/mac-views ... Refactor NativeWindow (Part 8): Prepare work for using views::Widget on macOS	2018-04-20 21:31:28 +09:00
Robo	ff571f3b5d	Part I: Move from base::Bind to base::BindOnce and remove unneeded base::Passed (#12661)	2018-04-20 19:55:05 +09:00
Cheng Zhao	aa5c80f8a6	Fix new clang warnings	2018-04-20 19:26:20 +09:00
Cheng Zhao	c44279bb10	Move AtomNSWindow to a new file	2018-04-20 19:26:20 +09:00
Cheng Zhao	569967ac21	Move QLPreviewPanelDataSource to AtomNSWindowDelegate	2018-04-20 19:17:08 +09:00
Cheng Zhao	f6a7e5ea23	Move NSTouchBarDelegate to AtomNSWindowDelegate	2018-04-20 19:15:45 +09:00
Cheng Zhao	8e9667d86c	Manage AtomTouchBar in NativeWindow instead of AtomNSWindow	2018-04-20 19:15:01 +09:00
Cheng Zhao	ce54fd334d	Move AtomNSWindowDelegate to a new file	2018-04-20 19:12:17 +09:00
Cheng Zhao	1c6c75da4f	Merge the logic of managing ViewsDelegate	2018-04-20 19:10:37 +09:00
Cheng Zhao	9bc79f840e	mac: Override NativeWidgetMac	2018-04-20 19:10:37 +09:00
Cheng Zhao	37a7df49d6	mac: Provide ViewsDelegate	2018-04-20 19:10:37 +09:00
deepak1556	30f1d0991b	enable chromium style checker plugin for electron and brightray targets	2018-04-19 11:12:58 -07:00
Jeremy Apthorp	eb7ccf8afa	Bring mac code into conformance with -Wobjc-missing-property-synthesis	2018-04-19 11:12:58 -07:00
Jeremy Apthorp	f3c00e96aa	Bring mac code into conformance with -Wunguarded-availability	2018-04-19 11:12:58 -07:00
Jeremy Apthorp	27cee90e5e	[chromium-style] move methods out of headers	2018-04-19 11:12:58 -07:00
Jeremy Apthorp	f1587da480	[chromium-style] out-of-line default constructors and destructors	2018-04-19 11:12:58 -07:00
Jeremy Apthorp	6c26bb1cf8	[chromium-style] destructors of ref-counted objects should be private	2018-04-19 11:12:10 -07:00
Jeremy Apthorp	e6695cf2ec	[chromium-style] override / virtual warnings	2018-04-19 11:12:10 -07:00
Jeremy Apthorp	a635f078c6	[chromium-style] auto variable type must not deduce to a raw pointer type	2018-04-19 11:10:52 -07:00
Birunthan Mohanathas	cd407d1c3f	Stop overwriting prevent_default if default wasn't prevented ... This didn't actually cause any issues because there is only one listener for the affected methods right now. Should we have added more, the last called observer would have overwritten `prevent_default`. Lets only set it when necessary to avoid this footgun in the future.	2018-04-19 12:45:21 +02:00
Cheng Zhao	7473b612c5	Make Menu API accept TopLevelWindow	2018-04-19 13:08:37 +09:00
Cheng Zhao	1340b17424	Do not return TopLevelWindow in BrowserWindow.getAllWindows	2018-04-19 13:08:37 +09:00
Cheng Zhao	e38f511737	Make BrowserWindow inheirt TopLevelWindow in JS	2018-04-19 13:08:37 +09:00
Cheng Zhao	71ebd99dfa	Expose TopLevelWindow to JavaScript	2018-04-19 13:08:36 +09:00
Cheng Zhao	cfed9fa4b9	Make sure we append parent->child_windows after InitWith	2018-04-19 12:45:48 +09:00
Cheng Zhao	89d909ab43	Only include UIAutomationCoreApi.h where necessary	2018-04-19 11:14:55 +09:00
Shelley Vohr	c6f4bbd143	also format missing .cc files	2018-04-18 20:48:45 -04:00
Shelley Vohr	53bdf22c85	clang-format atom files	2018-04-18 20:48:45 -04:00
Zeke Sikelianos	40ff17c9f9	Merge pull request #12619 from electron/add-before-update-event ... add new event to auto-updater	2018-04-16 12:43:15 -07:00
Samuel Attard	d06c79f5d3	Correct the default of allowRunningInsecureContent as per docs (#12556) ... * Correct the default of allowRunningInsecureContent as per docs * fix linting * Update calls to match native_mate API change	2018-04-16 08:28:54 -05:00
Shelley Vohr	06892775d4	add new event to auto-updater	2018-04-14 21:29:36 -04:00
Cheng Zhao	858828d343	Refactor NativeWindow (Part 6): Move NativeWindow bindings to api::TopLevelWindow (#12596) ... * Add atom::api::TopLevelWindow * Make BrowserWindow inherit TopLevelWindow * Fix reading from wrong weak map * Read options after setting content view * OnWindowClosed is not guarenteed to run now * Fix the offscreen hack in BrowserWindow * Fix building on Linux * Fix tests on Linux * Fix building on Windows	2018-04-14 11:04:23 +09:00
Zhuo Lu	a0cac05555	Clear cache storage data (#12546)	2018-04-13 13:03:16 -04:00
Shelley Vohr	d722008367	remove unnecessary ptr_util.h include	2018-04-12 22:34:26 -04:00
Shelley Vohr	b05932310b	replace base::MakeUnique with std::make_unique	2018-04-12 08:48:32 -04:00
Cheng Zhao	d706a30849	Fix crash when releasing window	2018-04-11 15:12:53 +09:00
Cheng Zhao	2b5bde4071	InstallView is no longer needed	2018-04-11 15:12:53 +09:00