mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1
electron/atom/browser
History
Robo e860748d6b fix: Invalidate weak ptrs before window Javascript object is destroyed (#14532) 
* fix: Invalidate weak ptrs before window Javascript object is destroyed

* chore: add regression test for #14513

This test is similar to the original gist at https://gist.github.com/bpasero/a02a645e11f4946dcca1331d0299149d -- the key is to open multiple windows and add an `app.on('browser-window-focus') listener that accesses window.id.

* fix: last commit didn't test the right thing.

The test needs to run in the main process to reproduce the
conditions reported in #14513
2018-09-12 13:58:04 -05:00
..
api fix: Invalidate weak ptrs before window Javascript object is destroyed (#14532) 2018-09-12 13:58:04 -05:00
lib Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
loader Move resource_response.h to //services/network/public/cpp. 2018-06-19 11:49:41 +10:00
mac Revert "fix: Drop support for OS X Mavericks (version 10.9)" (#13333) 2018-06-20 07:27:55 -05:00
net fix: add method and referrer properties to app login event (#14231) 2018-08-23 18:55:13 +09:00
osr chore: fix a chromium-style error 2018-09-11 20:24:03 +02:00
resources Bump v4.0.0-nightly.20180905 2018-09-05 10:06:13 -07:00
ui fix: macOS Window Title And Accessibility Focus (#14472) 2018-09-07 09:47:31 +10:00
atom_blob_reader.cc Make reading blobs work through Blob mojo interface. 2018-06-19 11:49:42 +10:00
atom_blob_reader.h Make reading blobs work through Blob mojo interface. 2018-06-19 11:49:42 +10:00
atom_browser_client.cc Need new #include for base::UTF8ToUTF16 2018-09-11 20:24:03 +02:00
atom_browser_client.h Handle external protocols with the network service. 2018-09-11 20:24:03 +02:00
atom_browser_context.cc refactor: move SpecialStoragePolicy from brightray to atom (#13944) 2018-08-21 08:51:04 -07:00
atom_browser_context.h refactor: move SpecialStoragePolicy from brightray to atom (#13944) 2018-08-21 08:51:04 -07:00
atom_browser_main_parts.cc inspector: stop dragging platform pointer 2018-09-11 20:24:03 +02:00
atom_browser_main_parts.h fix: opt into location services once device service has been started (#14253) 2018-08-23 08:51:46 -07:00
atom_browser_main_parts_mac.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
atom_browser_main_parts_posix.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_download_manager_delegate.cc move DownloadInterruptReasons from content/ to components/download 2018-06-19 11:49:40 +10:00
atom_download_manager_delegate.h Move download_item.h from content/public to components/download 2018-06-19 11:49:40 +10:00
atom_javascript_dialog_manager.cc refactor: remove instances of createDeepCopy (#13703) 2018-08-04 07:23:07 +10:00
atom_javascript_dialog_manager.h Give the JS dialog manager the alerting frame. 2018-06-19 11:49:42 +10:00
atom_permission_manager.cc Implement GetPermissionStatusForFrame in AtomPermissionManager 2018-09-11 20:24:03 +02:00
atom_permission_manager.h Implement GetPermissionStatusForFrame in AtomPermissionManager 2018-09-11 20:24:03 +02:00
atom_quota_permission_context.cc Fix includes in AtomQuotaPermissionContext 2018-06-19 11:49:41 +10:00
atom_quota_permission_context.h Fix includes in AtomQuotaPermissionContext 2018-06-19 11:49:41 +10:00
atom_resource_dispatcher_host_delegate.cc Handle external protocols with the network service. 2018-09-11 20:24:03 +02:00
atom_resource_dispatcher_host_delegate.h Handle external protocols with the network service. 2018-09-11 20:24:03 +02:00
atom_speech_recognition_manager_delegate.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_speech_recognition_manager_delegate.h [chromium-style] override / virtual warnings 2018-04-19 11:12:10 -07:00
atom_web_ui_controller_factory.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_web_ui_controller_factory.h [chromium-style] override / virtual warnings 2018-04-19 11:12:10 -07:00
auto_updater.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
auto_updater.h clang-format atom files 2018-04-18 20:48:45 -04:00
auto_updater_mac.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
bridge_task_runner.cc [chromium-style] out-of-line default constructors and destructors 2018-04-19 11:12:58 -07:00
bridge_task_runner.h [chromium-style] out-of-line default constructors and destructors 2018-04-19 11:12:58 -07:00
browser.cc fix: add method and referrer properties to app login event (#14231) 2018-08-23 18:55:13 +09:00
browser.h fix: add method and referrer properties to app login event (#14231) 2018-08-23 18:55:13 +09:00
browser_linux.cc refactor: chromium-style warnings in linux code (#12949) 2018-05-16 14:12:45 -05:00
browser_mac.mm refactor: remove deprecated GetAs methods (#13425) 2018-06-27 14:52:48 -07:00
browser_observer.h fix: add method and referrer properties to app login event (#14231) 2018-08-23 18:55:13 +09:00
browser_win.cc chore: fix various chromium-style errors in windows (#13394) 2018-06-25 22:30:00 +02:00
child_web_contents_tracker.cc Fix cpplint errors 2017-04-12 12:25:56 +09:00
child_web_contents_tracker.h Fix cpplint errors 2017-04-12 12:25:56 +09:00
common_web_contents_delegate.cc build: remove duplicate devtools sources (#14522) 2018-09-12 08:45:08 -05:00
common_web_contents_delegate.h build: remove duplicate devtools sources (#14522) 2018-09-12 08:45:08 -05:00
common_web_contents_delegate_mac.mm fix: read ignoreMenuShortcuts per WebContents 2018-09-10 19:06:16 +09:00
common_web_contents_delegate_views.cc fix: read ignoreMenuShortcuts per WebContents 2018-09-10 19:06:16 +09:00
fake_location_provider.cc fix: opt into location services once device service has been started (#14253) 2018-08-23 08:51:46 -07:00
fake_location_provider.h fix: opt into location services once device service has been started (#14253) 2018-08-23 08:51:46 -07:00
javascript_environment.cc fix: initialize tracing controller before starting platform (#14499) 2018-09-11 20:24:03 +02:00
javascript_environment.h [chromium-style] out-of-line default constructors and destructors 2018-04-19 11:12:58 -07:00
login_handler.cc fix: add method and referrer properties to app login event (#14231) 2018-08-23 18:55:13 +09:00
login_handler.h fix: add method and referrer properties to app login event (#14231) 2018-08-23 18:55:13 +09:00
native_browser_view.cc Make BrowserView DragRegionViews children of the WebContents view 2018-03-19 20:45:40 +02:00
native_browser_view.h clang-format atom files 2018-04-18 20:48:45 -04:00
native_browser_view_mac.h Store InspectableWebContents instead of InspectableWebContentsView in NativeBrowserView 2018-03-19 20:44:05 +02:00
native_browser_view_mac.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
native_browser_view_views.cc refactor: chromium-style warnings in linux code (#12949) 2018-05-16 14:12:45 -05:00
native_browser_view_views.h refactor: chromium-style warnings in linux code (#12949) 2018-05-16 14:12:45 -05:00
native_window.cc REVIEW: Delete WidgetDelegate before widget is destroyed. 2018-09-11 20:24:03 +02:00
native_window.h feat: allow window above full screen windows on mac (#14122) 2018-08-31 15:06:02 -07:00
native_window_mac.h feat: allow window above full screen windows on mac (#14122) 2018-08-31 15:06:02 -07:00
native_window_mac.mm feat: allow window above full screen windows on mac (#14122) 2018-08-31 15:06:02 -07:00
native_window_observer.h feat: 'will-move' event for windows. (#14283) 2018-08-28 08:44:10 -05:00
native_window_views.cc fix: notify focus change right away rather not on next tick (#14453) 2018-09-07 13:21:58 -05:00
native_window_views.h feat: allow window above full screen windows on mac (#14122) 2018-08-31 15:06:02 -07:00
native_window_views_win.cc feat: 'will-move' event for windows. (#14283) 2018-08-28 08:44:10 -05:00
node_debugger.cc inspector: stop dragging platform pointer 2018-09-11 20:24:03 +02:00
node_debugger.h inspector: stop dragging platform pointer 2018-09-11 20:24:03 +02:00
relauncher.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
relauncher.h Correctly quotes the argv on Windows 2016-06-02 21:10:39 +09:00
relauncher_linux.cc Improve process launch handle sharing API. 2018-02-23 10:21:24 +09:00
relauncher_mac.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
relauncher_win.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
render_process_preferences.cc refactor: replace base::Value::DeepCopy and CreateDeepCopy with Clone (#14420) 2018-09-02 17:38:35 -05:00
render_process_preferences.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
request_context_delegate.cc fix: notify request context shutdown on IO before cleanup (#14058) 2018-08-14 14:07:53 -07:00
request_context_delegate.h fix: notify request context shutdown on IO before cleanup (#14058) 2018-08-14 14:07:53 -07:00
session_preferences.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
session_preferences.h clang-format atom files 2018-04-18 20:48:45 -04:00
special_storage_policy.cc Improve ClearOnExit behavior of cookies using domain matching 2018-09-11 20:21:32 +02:00
special_storage_policy.h Improve ClearOnExit behavior of cookies using domain matching 2018-09-11 20:21:32 +02:00
unresponsive_suppressor.cc Replace DialogScope with UnresponsiveSuppressor 2016-07-11 15:29:03 +09:00
unresponsive_suppressor.h Replace DialogScope with UnresponsiveSuppressor 2016-07-11 15:29:03 +09:00
web_contents_permission_helper.cc feat: add session.setPermissionCheckHandler (#13925) 2018-08-28 09:05:08 -05:00
web_contents_permission_helper.h feat: add session.setPermissionCheckHandler (#13925) 2018-08-28 09:05:08 -05:00
web_contents_preferences.cc Revert "sec: deprecate some webPreference defaults to be secure-by-default (#14284)" (#14380) 2018-08-30 09:57:49 +12:00
web_contents_preferences.h Revert "sec: deprecate some webPreference defaults to be secure-by-default (#14284)" (#14380) 2018-08-30 09:57:49 +12:00
web_contents_zoom_controller.cc fix: use OOPIF for webview tag (#13869) 2018-08-16 15:57:40 -07:00
web_contents_zoom_controller.h fix: use OOPIF for webview tag (#13869) 2018-08-16 15:57:40 -07:00
web_dialog_helper.cc chore: Annotate fallthrough switch paths with FALLTHROUGH 2018-06-20 14:38:18 -07:00
web_dialog_helper.h clang-format atom files 2018-04-18 20:48:45 -04:00
web_view_guest_delegate.cc fix: use OOPIF for webview tag (#13869) 2018-08-16 15:57:40 -07:00
web_view_guest_delegate.h fix: use OOPIF for webview tag (#13869) 2018-08-16 15:57:40 -07:00
web_view_manager.cc [chromium-style] auto variable type must not deduce to a raw pointer type 2018-04-19 11:10:52 -07:00
web_view_manager.h clang-format atom files 2018-04-18 20:48:45 -04:00
window_list.cc [chromium-style] auto variable type must not deduce to a raw pointer type 2018-04-19 11:10:52 -07:00
window_list.h Add IsEmpty helper and remove GetInstance public usage 2017-04-11 09:09:17 -07:00
window_list_observer.h