Commit graph

11499 commits

Author SHA1 Message Date
Dan Stillman
cff7e45d90 Update locales from Transifex
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-19 03:40:42 -04:00
Tom Najdek
58234a133a
Fix localized labels after 4f1e449 (#4584) 2024-08-19 03:31:25 -04:00
Dan Stillman
f8fe506a86 Update locales from Transifex 2024-08-18 02:04:35 -04:00
Dan Stillman
db34491dfd Update English strings for Transifex 2024-08-18 01:47:35 -04:00
Dan Stillman
cc10987dee Fix error loading trash containing collection if bidi.browser.ui == true
https://forums.zotero.org/discussion/116980/zotero-7-0-1-center-right-panes-stop-displaying-items
2024-08-18 01:46:10 -04:00
Martynas Bagdonas
5dc17be46c Add missing string for reader
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-16 13:04:34 +03:00
windingwind
0f866d6d33
Fix Context Pane doesn't work in stack mode (#4578)
fix: #4577
2024-08-16 02:10:33 -04:00
windingwind
ca9508ebce
Lazy load attachment preview (#4568)
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-15 02:22:24 -04:00
Dan Stillman
874f42df36 Update utilities submodule
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
Includes zotero/utilities#36
2024-08-14 17:59:48 -04:00
Abe Jellinek
f0d453187d Fix editable-text dir not affecting existing input
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-14 11:19:04 -06:00
Abe Jellinek
64238d56bc Fix circular reference in getDirection()
Was preventing the field-specific switch branch from being reached.
2024-08-14 11:19:04 -06:00
Tom Najdek
4f1e44978e
Fix <wizard> sometimes starts with the wrong title. Resolve #4533.
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
This is caused by
https://searchfox.org/mozilla-central/source/toolkit/content/widgets/wizard.js#417-428
where fluent attribute is removed and replaced with the default value.
We need to stick with `data-header-label-id` until this is resolved
upstream.
2024-08-14 17:53:33 +02:00
Dan Stillman
f5af1898fd Proper fix for getDirection() problems
Hopefully the last fix for my edits to 181afb9 (#4534)

Follow-up to the previous two commits
2024-08-14 04:01:26 -04:00
Dan Stillman
531e8697be Fix additional breakage when bidi.browser.ui is true
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
Broken by me in an edit to 181afb9 (#4534)

Follow-up to previous commit
2024-08-14 03:42:08 -04:00
Dan Stillman
ec50539e80 Make Zotero.ItemFields.getBaseIDFromTypeAndField() more resilient
- Return base field instead of throwing if base field is passed for a
  type that has a base-mapped field
- Return false instead of throwing for invalid type-field combination
2024-08-14 03:14:29 -04:00
abaevbog
53ad856ef4
vpat 31 and 33 - aria tweaks for Tools > Plugins (#4560)
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
- vpat 31: mark which menuitems' button is checked,
otherwise selected options (e.g. Update plugins automatically)
are not announced as such
- vpat 33: when plugin details pane appears, remove
a misleading role="tabpanel" from its section because
it is not structured as a collection of tabs
2024-08-13 16:46:46 -04:00
Adomas Ven
ed311cacb9
Show a different error message for WinWord when no document is found (#4563)
And link to a different troubleshooting page
2024-08-13 16:13:00 -04:00
Dan Stillman
5d998a3b37 Load brand.ftl for Zotero.getString() 2024-08-13 16:06:47 -04:00
windingwind
0530afd669
Fix two item panes occasionally appear at same time (#4561)
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-13 02:43:14 -04:00
Dan Stillman
97650efe05 Fix blurry creator row buttons on non-HiDPI displays
From @yexingsha

Fixes #4549
2024-08-13 00:06:21 -04:00
Dan Stillman
9b23755190 Update CSL locales
Includes https://github.com/citation-style-language/locales/pull/319
2024-08-13 00:06:21 -04:00
abaevbog
8c3f13909c
vpat 59: make quickFormat reference box separator text darker (#4400)
So that on Windows, the separator text on white background
has a high enough contrast ratio for accessibility

Also remove opacity when reference panel opens. Without the opacity
on the reference panel, there is a shadow appearing below and to the
right of the panel on Windows. If we let the panel render with
opacity: 0.9 and only then set opacity: 1, the panel will no longer
be transparent and there will be no shadow.
2024-08-13 00:05:11 -04:00
Abe Jellinek
a566d83411 Migrate to our editMenuOverlay.js
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-12 15:25:31 -06:00
Abe Jellinek
d5deb406d7 Include editMenuOverlay.js in Web Link dialog
Fixes #4544
2024-08-12 15:24:56 -06:00
Abe Jellinek
16bb95ad3f
Collection tree: Keep editing state through refresh (#4556)
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
2024-08-12 16:43:49 -04:00
Abe Jellinek
51fe17c13d editable-text: Don't move cursor when value/alignment changes on focus (#4534)
Some checks are pending
CI / Build, Upload, Test (push) Waiting to run
For example, clicking in the middle of the Accessed field would move the
cursor to the end, no matter where the click happened. Clicking and
dragging when the field wasn't already focused would select from the
beginning of the field to the drag position.
2024-08-12 15:09:27 -04:00
Abe Jellinek
181afb92ac Bidi improvements and fixes (#4534) 2024-08-12 15:09:10 -04:00
Abe Jellinek
98b3745a20
Update Notes section on add (#4554) 2024-08-12 15:06:09 -04:00
abaevbog
a7eb49162e
tweaks to Zotero_Tooltip behavior (#4523)
- hide tooltip on click and make sure it does not appear
for a bit to avoid race conditions (e.g. clicking
right after mousemove stopped)
- do not display a tooltip if a mouse key is being
held (e.g. during drag in itemTree)

Fixes: #4519
2024-08-09 12:23:31 -04:00
windingwind
69b4789c17
Unify richlistitem styling rules (#4511)
Unify richlistitem styling rules

- Fix richlistitem unwanted focus ring on Linux
fix: #4510
- Simplify richlistbox styling rules and do not follow Mozilla code
- Use --default-focusring-width for v-table
2024-08-09 15:57:56 +03:00
Dan Stillman
794dc6bf01 Updated icons for creator row buttons
Fixes alignment issues brought up in
https://github.com/zotero/zotero/pull/4535#issuecomment-2276347669

From @yexingsha
2024-08-08 23:33:15 -04:00
Abe Jellinek
2d32efbccd
Apply tag text color to ellipsis (#4536) 2024-08-08 22:54:10 -04:00
Dan Stillman
9dd3807683 Wider icon for creator-field-mode button (#4535) 2024-08-08 22:50:47 -04:00
Bogdan Abaev
7450622047 itembox: switch creator mode button (#4535)
- added button to switch mode to creator rows
- removed that option from options menu
- extra tweak to avoid cursor flickering during re-render after
clicking on the button
- increased itemPane min-width to 320px

Fixes: #3959
2024-08-08 22:50:26 -04:00
Tom Najdek
19dad92b92
No longer create <browser> instance for each AbstractBox. Fix #4530 (#4532) 2024-08-08 17:54:17 -04:00
abaevbog
4c32317ba4
Quick Format: Prevent CSS override of background color (#4525)
Followup to 55017926b5
2024-08-08 01:39:18 -04:00
abaevbog
35da1187b3
prefs: fix text-link not clicking on space/enter (#4522)
Fix regression after 117197e11d
where space or enter would not trigger a click on
link outside of the main window.

".keyboard-clickable" is handled by listener in ZoteroPane,
so links outside of it (e.g. preferences) are not affected by it.
For now, just explicitly handle "keypress" event by the
zotero-text-link component.

Also, added a focus-ring around the link so it is visible
when it is focused.

Fixes: #4521
2024-08-08 00:24:19 -04:00
Abe Jellinek
531f55120c
Feed settings: Make disclosure triangle focusable, extract SCSS (#4513)
- <hbox> -> <button>, <toolbarbutton> -> <dropmarker>
- Extract styles to SCSS and use focus-ring mixin

Fixes #4512
2024-08-08 00:22:09 -04:00
Dan Stillman
d869d7898e Update locales from Transifex 2024-08-07 03:38:14 -04:00
abaevbog
b72bcc3118
tagsbox: focus new tag row on shift-enter (#4514)
On shift-Enter from any tag, add a new empty tag at the
bottom and focus it. Alternative to tabbing to + button
and clicking it.

Fixes: #4394
2024-08-07 03:03:38 -04:00
Abe Jellinek
206496332d EPUB recognition: Fix DOI search results being thrown away
https://forums.zotero.org/discussion/116524/epub-articles-and-books-not-getting-metadata-like-pdfs
2024-08-06 11:07:29 -04:00
Abe Jellinek
c1f681a228 EPUB indexing: Skip if textMaxLength is 0
Like we do for PDFs already.
2024-08-06 11:07:27 -04:00
Dan Stillman
151218e4de Update locales from Transifex 2024-08-06 02:25:39 -04:00
Adomas Venčkauskas
46813ff9ed Fix citation upgrade code from Zotero 6.0
Report https://forums.zotero.org/discussion/116459/z-beta-the-zotero-field-code-corresponding-to-this-citation-has-been-corrupted
2024-08-06 08:48:46 +03:00
abaevbog
0352fa35b4
OpenURL resolver pref: Fix glitchy drop-down keyboard navigation (#4506)
- minor refactoring to avoid deleting the first ("Custom") menuitem
of the resolver menulist. It is the first item that is selected when
popup opens and deleting it confuses keyboard navigation, so that
arrowDown/Up won't navigate the menu (unless the menu is hovered
over with a mouse)
- explicitly re-select the first item when the menulist closes.
Otherwise, in case of having navigated the menus with arrows
without changing selection and closing the popup, next time
resolver selector appears, arrowUp/Down will not navigate the list.
Only occurs on Windows.
- clear the resolver menus (except for the 1st item) when the popup closes
so that arrowUp/Down on focused dropdown don't select invalid
top-level menus (e.g. "North America").
- make sure that if the URL has been edited, the resolver dropdown's
value will switch to "Custom" even if the resolvers were not loaded

fixes: #4491
2024-08-06 01:31:47 -04:00
Dan Stillman
802210a6bc Quick Format: Use 450px for max-width 2024-08-06 01:21:56 -04:00
Bogdan Abaev
d446fc3c6f Quick Format: wrap description text of citation properties
- set max-width on the actual citation properties popup
- refactor _buildItemDescription to construct item description
as an array of spans, instead of labels, so that the
text can properly wrap.
2024-08-06 01:21:52 -04:00
Abe Jellinek
36e499c259
ExternalLinkHandler actor: Open some links internally, incl. styles (#4505) 2024-08-06 01:12:41 -04:00
windingwind
129938c8fe
Fix quick search styling (#4501)
fix: #4497
fix: #4498
2024-08-05 05:01:59 -04:00
abaevbog
c5027106c2
fix keyboard focus not landing on feeds itemTree (#4495)
Do not use specific "#item-tree-main-default" selector to
find the itemTree node to focus since a different id
can be set for the table, e.g for the list of feeds.

Use a more general "zotero-items-tree .virtualized-table"
selector to focus the itemTree on tab from quickSearch
and on Escape keypress from an editable-text of itemPane.

Fixes: #4494
2024-08-05 00:39:39 -04:00