Commit graph

8185 commits

Author SHA1 Message Date
Dan Stillman
cdf9d7ff32 Unregister tag selector when closed
This restores the pre-Reactification behavior.
2019-03-15 15:42:22 -04:00
Dan Stillman
94ccba45b9 Avoid unnecessary tag queries (regression from React tag selector) 2019-03-15 12:46:27 -04:00
Dan Stillman
cd55aebbc0 Fix detection of WebDAV settings on Windows and Linux
Fixes #1291, hopefully for real this time
2019-03-13 02:45:31 -04:00
Dan Stillman
435e628973 Fix high CPU during file syncing (regression from React tag selector) 2019-03-12 06:45:25 -04:00
Dan Stillman
99cfddaf18 Add separator above "Delete All Automatic Tags in This Library…" 2019-03-09 16:28:20 -05:00
Dan Stillman
c735423996 Don't show PDF icon for linked-URL PDFs (regression from 8cd5b09053) 2019-03-08 20:23:00 -05:00
Dan Stillman
c7698a2324 Restore disabling of automatic tag deletion option when no such tags 2019-03-07 04:08:45 -05:00
Dan Stillman
85c6ec0ca4 Actually change code that deletes automatic tags
Follow-up to d7dc5670d5
2019-03-07 03:35:37 -05:00
Adomas Venčkauskas
72fb67d15b Restore "Delete All Automatic Tags" menu option for tag selector. Closes #1660 2019-03-06 16:22:05 +02:00
Adomas Venčkauskas
d01038b13b Fix missing react localization in tests. Closes #1661 2019-03-06 14:35:38 +02:00
Adomas Venčkauskas
e8f186479f Address tag selector tests race conditions. Addresses #1659 2019-03-06 13:13:40 +02:00
Dan Stillman
9cdfe8e01c Update submodules 2019-03-05 21:17:14 -05:00
Dan Stillman
123f82571e Update locales from Transifex 2019-03-05 21:15:27 -05:00
Dan Stillman
ae9c54b76d Fix "Move to Top" logic for creators 2019-03-05 19:15:50 -05:00
Dan Stillman
d7dc5670d5 When clearing automatic tags, don't delete manual tags with same name 2019-03-05 07:55:00 -05:00
Dan Stillman
fc43514ff0 Deselect tags when deleted (regression from Reactification) 2019-03-05 07:55:00 -05:00
Dan Stillman
3c6ab77e44 Update locales from Transifex 2019-03-04 07:31:36 -05:00
Dan Stillman
8cd5b09053 Add icon for linked PDF files 2019-03-04 03:20:37 -05:00
Dan Stillman
e2c4e3e86a Use "PDF" attachment title for all individual PDFs from Mendeley import
https://forums.zotero.org/discussion/comment/327390/#Comment_327390
2019-03-03 04:52:39 -05:00
Dan Stillman
88f39cba80 Merge new English strings 2019-03-02 06:24:33 -05:00
Dan Stillman
04779d8d1c Add import option for storing or linking files
This allows files in Mendeley imports to be stored and files in
RIS/BibTeX/etc. to be linked.

Closes #329
2019-03-02 06:24:33 -05:00
Martynas Bagdonas
ca859e7aa4 Fix unescapeHTML on node.js 2019-03-01 09:59:21 +02:00
Dan Stillman
ad27e0c5fa Update locales from Transifex and merge new English strings 2019-02-26 22:30:29 -05:00
Dan Stillman
d0f7fd6df7 Add separate "Rename linked files" pref for auto-renaming
Defaulting to false

People who've been relying on auto-renaming of linked files for the last
year will have to turn this back on.
2019-02-26 22:23:43 -05:00
Adomas Venčkauskas
caac984345 Fix this.collectionTreeRow undefined errors in tag selector 2019-02-25 12:21:26 +02:00
Adomas Venčkauskas
891524b4ed Fix selected tags not clearing when switching collections. Closes #1646 2019-02-25 12:20:35 +02:00
Adomas Venčkauskas
6d82ac3970 Fix window.name being unset when loading include.js. Closes #1645 2019-02-25 11:45:42 +02:00
Dan Stillman
6929125708 Updates locales from Transifex and merge new English strings 2019-02-24 00:11:27 -05:00
Dan Stillman
df494415d7 Add "Move to Top" option in creator type menu
Drag-and-drop will be a better solution, but this should be useful in
some situations (and, unlike drag-and-drop, can be accessible).
2019-02-24 00:01:58 -05:00
Dan Stillman
945c413c42 Closes #1644, Allow selecting multiple items with zotero://select
This adds selectItems() to ZoteroPane and collectionTreeView and removes
the ancient, unused 'expand' argument to selectItem(), which didn't
really make sense there. It also includes a new
itemTreeView::ensureRowsAreVisible() that tries to scroll to an
appropriate place (or, better yet, not scroll at all) given the
specified rows and page size.
2019-02-23 17:35:09 -05:00
Dan Stillman
663acccbc2 Tweak debugging for missing-key sync error 2019-02-19 04:10:25 -05:00
Dan Stillman
1061893998 "Attachment Content" search improvements
- Fix incorrect results for ANY search with multiple "Attachment
  Content" conditions and no other conditions
- Dramatically speed up single-word searches by avoiding unnecessary
  text scans (which probably addresses #1595)
- Clean up code
2019-02-19 04:10:25 -05:00
Dan Stillman
977eb8d965 Fix "Show Automatic Tags" in tag selector 2019-02-18 15:00:18 -05:00
Dan Stillman
950e9de80f Make starting from Mac disk image fatal 2019-02-18 14:36:53 -05:00
Dan Stillman
0ea03ce72c Switch to services domain for recognizer requests
The recognizer endpoint can be customized by setting either
recognize.url (used directly) or services.url (used with a 'recognizer/'
suffix).
2019-02-18 14:30:54 -05:00
Frank Bennett
30b6bf6da7 Set processIndices for each processor return 2019-02-13 08:40:50 +02:00
Adomas Venčkauskas
6672efef0a Revert "Revert "Update citeproc-js to 1.1.215""
This reverts commit db56f002a5.
2019-02-12 10:30:33 +02:00
Adomas Venčkauskas
9410094ad8 Update citeproc usage logic. See #1638 2019-02-12 10:30:24 +02:00
Adomas Venčkauskas
a931c2ba51 Tidy up Integration.Session.addCitation() 2019-02-11 11:01:53 +02:00
Adomas Venčkauskas
0539deb58b Make sure citation edits are not treated as citation duplication 2019-02-11 11:01:01 +02:00
Adomas Venčkauskas
6ee87056b1 Fix integration previewFn providing wrong citationsPost data
See #1638
2019-02-11 10:45:07 +02:00
Adomas Venčkauskas
de4ce57768 Fix wrong httpIntegrationClient #convert call signature 2019-02-08 13:03:27 +02:00
Dan Stillman
db56f002a5 Revert "Update citeproc-js to 1.1.215"
This reverts commit d301fb6e43.
2019-02-06 14:59:27 -05:00
Dan Stillman
ff008d4bc1 Update locales from Transifex 2019-02-05 21:36:51 -05:00
Dan Stillman
d301fb6e43 Update citeproc-js to 1.1.215 2019-02-03 05:08:13 -05:00
Dan Stillman
98aa71655b RunJS tweaks
- Display result string directly instead of running through varDump()
- Better detect use of `await`
- Fix ESLint error
2019-02-02 14:17:14 -05:00
Dan Stillman
b1fad505d7 Fix sorting of colored tags after Reactification
Regressed to alphabetic sorting instead of number-key sorting
2019-01-29 22:18:49 -05:00
Dan Stillman
c2a637472e Fix foreign key constraint error for collections with all-numeric keys
This was like a lottery where instead of winning something your library
stopped syncing.
2019-01-29 05:09:00 -05:00
Adomas Venčkauskas
8bd35ee0d4 Fixes tag selector toggling via hotkey leaving gray area. Closes #1629 2019-01-28 16:35:20 +02:00
Dan Stillman
8b4bb62efc Don't load linked URLs during import
Regression from 5a6a772ca2, I think
2019-01-26 00:20:26 -05:00
Adomas Venčkauskas
a532af6114 Fix sync client tests that depend on stubbing concurrentCaller Promise.
Regression since f5c4fb06
2019-01-22 13:49:00 +02:00
Dan Stillman
8f58560751 Run JavaScript: Automatically switch to async mode if await is used
This will allow examples from the documentation to work without the
async option being explicitly chosen.
2019-01-22 04:44:32 -05:00
Dan Stillman
39eb2962a6 Run JavaScript: Support await and show errors
Adds a "Run as async function" checkbox that wraps the code in an async
function and displays the value returned by a `return` statement.

This also properly catches errors and displays them in the results pane.
2019-01-22 01:29:05 -05:00
Dan Stillman
f918e27e46 Add window for running arbitrary privileged JavaScript
This is a replacement for the Execute JS extension that could be used
with Zotero for Firefox.

To enable, go to the Config Editor in the Advanced pane of the
preferences and set devtools.chrome.enabled to true, and then restart
Zotero. A "Run JavaScript" option will appear in the Tools menu.
2019-01-22 00:12:34 -05:00
Dan Stillman
eb5d28b626
Merge pull request #1606 from adomasven/feature/reactify
Reactified Tag Selector
2019-01-21 04:07:28 -05:00
Adomas Venčkauskas
0e8788aca1 Update tag selector styling for Windows 2019-01-21 11:01:33 +02:00
Adomas Venčkauskas
fc41326319 Update tag selector styling for macOS 2019-01-21 11:01:33 +02:00
Adomas Venčkauskas
f5c4fb06e1 Ensure high-dpi icons are loaded in React components 2019-01-21 11:01:32 +02:00
Adomas Venčkauskas
90a70f7c31 Fix a /saveItems session management race condition bug 2019-01-21 11:01:32 +02:00
Adomas Venčkauskas
a24cada451 React Tag Selector polish, i18n and tests
- Added icon-button UI code for the menubutton
- Upgrade to React 16 to allow non-standard attrs, such as `tooltiptext`
to support XUL tooltips
- Add i18n support for React UI elements
- Update tests for reactified tag selector
2019-01-21 11:01:27 +02:00
Philipp Zumstein
97e53c5230 Fix some typos found by codespell (#1570)
$ codespell --skip="./.git,./styles,./translators,./chrome/locale,./resource,./chrome/content/zotero/xpcom/xregexp,./chrome/content/zotero/xpcom/rdf,./chrome/content/zotero/xpcom/citeproc.js,./test/resource,./node_modules" -q 2 -i 3 -w
2019-01-20 20:39:27 -05:00
Dan Stillman
4861b2e841 Update citeproc-js to 1.1.212 2019-01-19 02:38:56 -05:00
Dan Stillman
1c32d3856b Include item URI in translator item object for notes and attachments
This allows for related items, referenced by URI in
`.relations['dc:relation']`, to be included in the export.
2019-01-14 00:35:00 -05:00
Dan Stillman
0d5abb018a Ignore invalid paths during export
Invalid paths, including Windows UNC paths on other OSes, caused exports
to fail. Now they're ignored, which is what we do for other missing
attachment files.

Fixes #1622
2019-01-12 02:34:31 -05:00
Dan Stillman
9c0f5998a3 Use correct time-zone offset for access dates in bibliographies
Fixes #1069
2019-01-10 03:14:28 -05:00
Dan Stillman
bd78cacf24 Update locales from Transifex 2019-01-10 00:42:00 -05:00
Dan Stillman
ccdcb1bf72 Fix adding new advanced search row with More field selected
Broken in 28aa86eb79
2019-01-08 04:28:28 -05:00
Dan Stillman
5a6a772ca2 Fix linked-URL attachments not being saved to groups without files
It looks like this may have been broken for years.
2019-01-08 03:45:26 -05:00
Tom Najdek
897e74c7f1 Reactify the Tag Selector 2019-01-07 15:33:45 +02:00
Dan Stillman
506ed313da Fix moving item via connector to library with files from one without
Broken in ce5be0bc75 for non-webpage items
2019-01-07 05:16:17 -05:00
Brenton M. Wiernik
cf66cc6424 Print highlight colors in Reports (#1618) 2019-01-03 16:11:09 -05:00
Dan Stillman
5fa608e379 Deprecate DB.getNextName() in favor of Utilities.Internal.getNextName() 2018-12-27 07:12:26 -05:00
Dan Stillman
7575cd8b29 Don't accept keyboard input before new-collection prompt appears
Fixes #1613
2018-12-27 07:11:15 -05:00
Dan Stillman
4bc8fab4f5 Allow translators to specify that attachment URLs shouldn't be proxied
Translators can include `proxy: false` in the attachment object to
indicate that the URL should be used as is, without further proxying.
This generally isn't necessary, but sometimes it is (e.g., on
EBSCOhost), and in theory we should start using this whenever a PDF URL
is extracted from the page instead of being constructed manually by the
translator.

Closes #1612
2018-12-26 06:23:26 -05:00
Dan Stillman
b58def7bc4 Expose Zotero.Notes for translation-server/Node
Needed for CSL JSON export of notes, which is pointless but better than
throwing an error, I guess.
2018-12-21 02:40:18 -05:00
Dan Stillman
559881b896 Update submodules 2018-12-18 21:17:48 -05:00
Dan Stillman
f9c0e9a571 Update locales from Transifex 2018-12-18 19:46:43 -05:00
Dan Stillman
7594fe1800 Fix advanced search test failure after 13d55910e 2018-12-17 05:36:14 -05:00
Dan Stillman
e82283494b Update locales from Transifex and merge new English strings 2018-12-17 05:21:38 -05:00
Dan Stillman
bd5243221b Fix another typo in c81961a9be 2018-12-16 22:41:32 -05:00
Dan Stillman
adcae4b902 Fix typo in previous commit (c81961a9be) 2018-12-16 21:36:59 -05:00
Dan Stillman
c81961a9be Move Z.Items.getFirstCreatorFromItemJSON() to Z.Utilities.Internal
Needed for COinS export in translation-server
2018-12-16 21:26:16 -05:00
Dan Stillman
f4bf918f35 Remove ": a novel" from book titles
Closes #1581
2018-12-16 03:00:15 -05:00
Dan Stillman
6125d65bc2 Support duplicating saved searches
Closes #1431
2018-12-16 02:24:21 -05:00
Dan Stillman
c73e664312 Fix logged error when dragging collection to another library
"Collection ID '1234' is not an integer (string)"
2018-12-16 02:24:21 -05:00
Dan Stillman
13d55910ed Simplify cloning of collections and searches 2018-12-16 02:24:21 -05:00
Dan Stillman
5f07f36ae5 Allow Zotero.Item instance instead of itemID in Collection.hasItem() 2018-12-16 02:24:21 -05:00
Dan Stillman
80f6b857f6 Add Utilities.Internal.getNextName(name, existingNames)
Function to get the next available name when duplicating something
2018-12-16 02:24:21 -05:00
Dan Stillman
bf6f1432c5 Move Utilities.Internal.escapeSQLExpression() to Zotero.DB 2018-12-16 02:10:15 -05:00
Dan Stillman
28aa86eb79 Default to previous condition when creating new advanced search row
Fixes #1533
2018-12-15 23:52:57 -05:00
Dan Stillman
1c47d21937 Expose Zotero.Cite for translation-server/Node 2018-12-13 02:06:10 -05:00
Adomas Venčkauskas
ffbe44a159 Fix snapshot saves refetching page instead of using passed html 2018-12-12 10:59:58 +02:00
Dan Stillman
9ed8bed778 Find direct PDF from page URL if Content-Type includes invalid parameter
The 'application/pdf' Content-Type shouldn't have any parameters, but a
site was returning 'application/pdf;charset=ISO-8859-1', so instead just
look for the 'application/pdf' prefix.
2018-12-11 16:02:57 -05:00
Dan Stillman
368e225ab8 Update locales from Transifex and merge new English strings 2018-12-05 03:35:55 -07:00
Adomas Venčkauskas
a13e788a60 Change Word permission prompt to reference Zotero instead of Terminal
This should have been obvious, but we've been seeing Terminal when testing
because we're launching Zotero from the Terminal. Users with installed
Zotero version actually see 'Zotero' in instead of Terminal.
2018-12-05 12:14:18 +02:00
Dan Stillman
0706430609 Add setRequestHeaders() method to Translate.Web
For use in zotero/translation-server#16 to pass Accept-Language through
to translation web requests
2018-12-04 02:50:40 -07:00
Dan Stillman
a6fb0b35c3 Update processDocuments() signature for allow passing headers
Also:

- Actually use the cookie sandbox passed to processDocuments()

For zotero/translation-server#16, we want to include Accept-Language
(and maybe other headers) from the client request in upstream requests,
which requires passing it to both non-translate processDocuments().
translation-server's non-translate processDocuments() is defined in that
repo, but it's called by the cross-repo translate processDocuments() in
utilities_translate.js, so the signature needs to be changed in both
repos.

We also apparently weren't using the cookieSandbox in client
processDocuments() calls, though I think that only would've affected
translator testing.
2018-12-04 01:42:56 -07:00
Dan Stillman
223f582aa7 Fix search error on nonexistent collection in recursive mode
And don't return results for a nonexistent parent search
2018-11-28 15:31:57 -07:00
Dan Stillman
6137aeddb8 Follow meta redirects for Find Available PDF
This fixes direct and VPN-based retrieval of PDFs for Elsevier (e.g.,
ScienceDirect) items that have a DOI but no URL, since Elsevier resolves
DOIs through an intermediate page.
2018-11-26 00:57:48 -07:00
Dan Stillman
7d9b94c79e Fix autocomplete for tags beginning with _ or %
Addresses #1598
2018-11-25 00:36:04 -07:00