mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
7597 commits 9 branches 364 tags 290 MiB
Commit graph

5960 commits

Author SHA1 Message Date
Dan Stillman
7c7ea6a66d Fix PDF recognition 
But leave tests disabled, since they should maybe be mocked?
 2016-02-02 06:47:54 -05:00
Dan Stillman
8a85114c13 Update comments to recommend Zotero.HTTP.request() instead of .promise() 2016-02-02 05:31:35 -05:00
Dan Stillman
e8046d8ad2 Use Promise.coroutine() instead of Zotero.spawn() for saveItems() 
(Use -w for diff)
 2016-02-02 05:30:54 -05:00
Dan Stillman
a6caa14412 Fix Add Item by Identifier (and search translation in general) 2016-02-02 05:29:02 -05:00
Dan Stillman
741ca99c10 Restore open/save dialog when cancelling MIME type intercept 
Behavior from #617 apparently got lost in the transition to master
 2016-02-02 02:51:52 -05:00
Dan Stillman
d0a99fc0a1 Merge branch '4.0' 2016-02-02 02:44:51 -05:00
Dan Stillman
04d957a95c Fix "Add Identifier by ID" in Fx45 
const doesn't create a property on the global object in Fx45
 2016-02-02 02:03:46 -05:00
Dan Stillman
ef180d190f Update submodules 2016-02-01 04:43:49 -05:00
Dan Stillman
6b93704006 Update locales from Transifex 2016-02-01 04:41:11 -05:00
Dan Stillman
950e1a5047 Don't call stop handler twice in storage stream listener 
The second status code would be 0, so it could result in spurious
S3 retries.

Backported from master
 2016-02-01 04:20:22 -05:00
Dan Stillman
ec28c5a35d Retry S3 requests on 500 or 503 in addition to interruption 
And adjust S3 success/backoff counters on success
 2016-02-01 03:58:45 -05:00
Dan Stillman
eb85fdc42e An invalid translator file shouldn't break all translation 
For now, delete it and clear it from the cache so it's updated properly going
forward, but really we want to reinstall the correct file automatically
(#903).
 2016-01-29 05:34:26 -05:00
Dan Stillman
ab9330d88e Don't show open/save dialog in addition to style installation prompt 
This apparently has been happening for a year, since #617.

Might be better to show open/save on cancel, as implemented for the
RIS/BibTeX prompt in 4ecdd55 (which caused this), but that would have to
wait for the better promise handling in 5.0. Doing "Save Link As..." for
a CSL file also seems a bit more straightforward than for RIS/BibTeX,
which can be served in complicated ways.
 2016-01-23 02:26:06 -05:00
Dan Stillman
31d2f6aecb Merge branch '4.0' 2016-01-22 01:10:56 -05:00
Dan Stillman
e206d70595 Fix "undefined" prefix from md5Async() 2016-01-22 01:10:08 -05:00
Dan Stillman
bf58ba6faa Fix remaining old-style array comprehensions 2016-01-20 01:26:41 -05:00
Dan Stillman
3071b8093b Merge branch '4.0' 2016-01-20 01:23:02 -05:00
Dan Stillman
e873617890 Fix trashing of descendant items when deleting a collection 
Also allows 'collections' property to be passed to
createDataObject()/createUnsavedDataObject() in tests.
 2016-01-18 13:50:46 -05:00
Dan Stillman
a80f130997 Avoid temporary table when getting tags for current view 
Instead, pass ids directly to SQLite. This seems to take about the same
amount of time or a little less (by avoiding the time it takes to start
a transaction) and avoids blocking other transactions when switching
views.
 2016-01-18 13:50:46 -05:00
Dan Stillman
5ef89b1d0f Speed up DB methods slightly by avoiding unnecessary yields 
And tidy some things up
 2016-01-17 00:50:17 -05:00
Dan Stillman
0a5e31a4e1 Fix crashes due to "Parameter 4 is undefined" error 
Broken in 7d404e8d4a
 2016-01-14 19:42:25 -05:00
Dan Stillman
da71d6201a Fix file sync error due to Zotero.Utilities.Internal.md5() brokenness 
Broken in 7d404e8d4a
 2016-01-14 19:25:15 -05:00
Dan Stillman
c4d67c5b5e Don't unlink sync account in prefs when offline 2016-01-14 13:04:29 -05:00
Dan Stillman
99bba5d198 Allow Zotero.HTTP.request() for non-HTTP URLs when offline 
Otherwise Zotero throws an error at startup when offline.
 2016-01-14 12:47:52 -05:00
Dan Stillman
f05b98ba20 Fetch top-level items before other items when syncing 2016-01-14 01:50:13 -05:00
Dan Stillman
cd41609761 Improve debug logging for database transactions 
Among other things, add an id to each DB transaction for better tracking
 2016-01-13 04:24:27 -05:00
Dan Stillman
02eea99128 Get latest cache object versions in bulk during sync downloads 2016-01-12 21:57:00 -05:00
Dan Stillman
7d404e8d4a Closes #896, Legacy array/generator comprehension is removed in Firefox 46 
Possible there are some bugs here (and it also may fix a couple existing bugs).
 2016-01-12 01:58:38 -05:00
Dan Stillman
02b29ff14b Fix SQL error switching from ZFS to WebDAV 2016-01-09 17:02:13 -05:00
Dan Stillman
d53b9b993f Fix 'debug: false' option in DB.queryAsync() 2016-01-09 16:59:10 -05:00
Dan Stillman
d0d818840a Switch temp table inserts from SELECT...UNION to VALUES (x),(x)... 
Supported as of SQLite 3.7.11

Also use hard-coded values instead of bound params
 2016-01-09 16:58:40 -05:00
Dan Stillman
2ac27be95e Upgrade to Bluebird 3.1.1 2016-01-08 21:07:10 -05:00
Dan Stillman
a8c364d830 Remove duplicate ItemFields.isMultiline method 2016-01-08 04:31:28 -05:00
Dan Stillman
9fb42b6788 Fixes #890, Use text area for Book Title 2016-01-08 04:30:47 -05:00
Dan Stillman
08562e50cd Fixes #877, getPrimaryIDForType doesn't work due to typo 2016-01-08 03:44:38 -05:00
Dan Stillman
818ef28f88 Fixes #876, Uncaught error in getTypesForItemType with valid input 2016-01-08 03:43:10 -05:00
Dan Stillman
703cfd1fc5 Closes #521, [Async DB] Update DB integrity check for new schema 
Most checks are now just foreign key checks and can be checked with
"PRAGMA foreign_key_checK".

The DB Repair Tool will need to be updated to handle the new schema (but
still accept the old one).
 2016-01-08 03:09:55 -05:00
Dan Stillman
4a5de628ce Fix WebDAV test failure 2016-01-07 16:48:57 -05:00
Dan Stillman
739365fd28 Return boolean from Zotero.Library::hasItems() 
Fix test breakage in 2e389de47
 2016-01-07 16:27:36 -05:00
Adomas Venčkauskas
2e389de471 Closes #833, Displays a warning dialog if API key present but library empty 2016-01-07 21:11:20 +00:00
Adomas Venčkauskas
77a95b5e6d Closes #886, Fixes auth form showing until key info check finishes 2016-01-07 21:11:06 +00:00
Dan Stillman
1415b9fe45 Fix ZFS purgeDeletedStorageFiles() 2015-12-30 05:14:51 -05:00
Dan Stillman
2177a000ea Closes #891, Better incompatible-DB-version handling 
Fixes the incompatible-version dialog and adds info on the version used
to upgrade the database, which may be helpful for troubleshooting.

Also fixes showing of the Zotero toolbar icons even in case of a startup
error.
 2015-12-30 05:14:50 -05:00
Dan Stillman
0173e9084d Resize Sync prefpane after init 
Otherwise things can get cut off the bottom
 2015-12-30 05:14:50 -05:00
Dan Stillman
c5a9987f37 WebDAV file sync overhaul for 5.0 
Also:

- Remove last-sync-time mechanism for both WebDAV and ZFS, since it can
  be determined by storage properties (mtime/md5) in data sync
- Add option to include synced storage properties in item toJSON()
  instead of local file properties
- Set "Fake-Server-Match" header in setHTTPResponse() test support
  function, which can be used for request count assertions -- see
  resetRequestCount() and assertRequestCount() in webdavTest.js
- Allow string (e.g., 'to_download') instead of constant in
  Zotero.Sync.Data.Local.setSyncState()
- Misc storage tweaks
 2015-12-30 05:14:50 -05:00
Dan Stillman
6844deba60 Disable foreign key checks during schema modifications 
Otherwise renaming a table causes existing foreign keys to be renamed.
 2015-12-29 23:44:16 -05:00
Dan Stillman
8933e3b586 Item.toJSON() should output unset mtime/md5 as null, not undefined 2015-12-22 01:49:45 -05:00
Adomas Venčkauskas
8e0e86e59c Closes #882 
Hide password in debug output of key request
 2015-12-20 13:46:58 +00:00
Dan Stillman
cfee7ea9d2 Merge pull request #879 from adomasven/feature/transparent-api-keygen 
Restores the functionality of 4.0 for sync settings
 2015-12-14 19:28:56 -05:00
Adomas Venčkauskas
ffd9a07164 Restores sync credential functionality of 4.0. 
Improves UX of sync authentication.
The account is now linked and unlinked and an API key related to
the client is generated transparently in the background.
The API key is deleted on unlinking.
No sync options are allowed before linking an account.
 2015-12-14 23:55:28 +00:00
Dan Stillman
faf3b94b64 Clear existing DB user values when reinitializing Users for tests 2015-12-10 20:34:41 -05:00
Dan Stillman
0673face28 Update submodules and maxVersion 2015-12-10 16:33:51 -05:00
Dan Stillman
177dac3fd2 Closes #805, Translation shouldn't create new item in My Publications 
And in download overlay, save and switch to My Library if My
Publications is selected.
 2015-12-10 01:11:41 -05:00
Dan Stillman
18349b2232 Restore certificate checking for API syncing errors 
Closes #864

This adds a 'channel' property to Zotero.HTTP.UnexpectedStatusException,
because the 'channel' property of the XHR can be garbage-collected
before handling, and the channel's 'securityInfo' property is necessary
to detect certificate errors.
 2015-12-09 04:11:27 -05:00
Dan Stillman
bad92a1d22 Quick update of recognizePDF from Q to Bluebird 
This should be refactored further, but this is a start at swapping in
Bluebird. Unfortunately the process doesn't work correctly because of
issues in the translation framework, which will need to be addressed
separately -- right now a parent item is successfully created but the UI
still shows an error and the PDF isn't placed under the parent.
 2015-12-07 17:23:10 -05:00
Dan Stillman
1d4dd9faac Fix double filename in progress popup when saving files 
This appears to have started in a recent Fx version.
 2015-11-28 19:12:36 -05:00
Adomas Venčkauskas
4b16210ac6 Remove tags on shift-drag 
Closes #852

Currently shows a *+* icon for adding a tag and
a *link* icon for removing it.

There does not appear to be any way to have a custom mouse cursor,
which makes this interaction extremely unintuitive. It might be
possible to hack this in, but it does not really warrant the effort.
E.g. `window.setCursor` does not respond whilst dragging.
 2015-11-20 16:51:48 +00:00
Dan Stillman
08cb63f66d Fix various cases of saving items to selected collection 
This changes Zotero.Translate.Base.translate() to take an options object (in
order to take a 'collections' parameter, which is passed to the
Zotero.Translate.ItemSaver constructor). The old parameters are still supported
with a deprecation warning, and there may be other places that still need to be
updated.
 2015-11-15 17:49:31 -05:00
Dan Stillman
6d64526648 Ignore unknown fields in Zotero.Item::fromJSON() 2015-11-12 17:24:03 -05:00
Dan Stillman
3025123cb8 Merge pull request #867 from adomasven/feature/dropbox-alert 
Detect when data directory is in Dropbox
 2015-11-12 15:45:00 -05:00
Adomas Venčkauskas
b75cc8f9d0 Closes #437, Detect when data directory is in Dropbox 
Display a warning when choosing data directory
Or on opening Zotero Pane for existing users with data dir in dropbox

Also:
Fix a bug where it won't use custom path if "Choose..." button is
pressed instead of radio button.
Change filepicker to show current data directory on display
 2015-11-12 20:24:39 +00:00
Dan Stillman
cc9d1cc41d Merge pull request #871 from adomasven/fix/my-publications-linux 
Fixes the finish button on my publication wizard on linux
 2015-11-12 05:41:57 -05:00
Dan Stillman
62aeb1da32 Full-text syncing support via API [DB reupgrade] 2015-11-12 02:54:51 -05:00
Dan Stillman
cb81f3febd Set 'Content-Type: application/json' on object uploads 2015-11-12 02:51:48 -05:00
Dan Stillman
69e5c5ae05 Don't accept libraryVersion in syncAPIClient::getVersions() 
Since /settings is always called first with If-Modified-Since-Version,
it's never necessary to include that in the versions request.
 2015-11-12 02:50:24 -05:00
Dan Stillman
ae277391b6 Miscellaneous tweaks 2015-11-12 02:48:41 -05:00
Dan Stillman
614232754a Allow "Zotero.Fulltext" as "Zotero.FullText" 
"Zotero.Fulltext" should be considered deprecated, though there's no
warning for it yet.
 2015-11-12 02:42:20 -05:00
Dan Stillman
6d289797bf Retry API requests automatically after 5xx errors 2015-11-12 02:41:40 -05:00
Dan Stillman
790d6d3dd6 Fix "Save to Zotero" in download overlay 2015-11-10 15:52:09 -05:00
Adomas Venčkauskas
234c94be67 Fixes my publication wizard on linux, Closes #738 
Also:
- Removes horizontal scrollbar in linux my publications wizard, Closes
  #740
 2015-11-10 18:25:22 +00:00
Dan Stillman
32b7756898 Update locales from Transifex 2015-11-08 16:25:07 -05:00
Dan Stillman
ccd765ff74 Update versions and submodules 2015-11-08 16:21:20 -05:00
Philipp Zumstein
add3acbcd1 Relax condition in parseContextObject 
Especially, allow rft.subject and rft.description in core OpenURL without Dublin Core declared as format. This fixes #851
 2015-11-08 16:16:36 -05:00
Dan Stillman
8197fa4ce8 Fix LIKE binding error in Nightly loading duplicates 2015-11-08 16:16:05 -05:00
Philipp Zumstein
89a0f8910a Relax condition in parseContextObject 
Especially, allow rft.subject and rft.description in core OpenURL without Dublin Core declared as format. This fixes #851
 2015-11-08 11:21:45 +01:00
fbennett
4a475ff3aa Prevent duplicate items when copying citations to clipboard 2015-11-08 11:44:13 +09:00
Dan Stillman
1e6bb44e80 Show My Publications in Advanced Search and disable Save Search button 
Closes #703 (unless I'm forgetting something)
 2015-11-04 14:06:32 -05:00
Dan Stillman
3100f10396 Make Zotero.Libraries.getAll() return sorted Zotero.Library instances 
My Library, My Publications, and then groups sorted by name
 2015-11-04 14:04:21 -05:00
Dan Stillman
e8a887304e Move Zotero.CollectionTreeRow to separate file 2015-11-03 17:08:55 -05:00
Dan Stillman
41f5137e24 Update some attachmentMIMEType -> attachmentContentType 2015-11-03 17:08:55 -05:00
Dan Stillman
b8d00e2051 Fix error showing pages/modified in attachment box 2015-11-03 17:08:55 -05:00
Dan Stillman
b52cfae225 Show "Delete Permanently..." button in right-hand pane in trash 2015-11-03 17:08:54 -05:00
Dan Stillman
f2bef5998c Disable actions in My Publications and clean up trash item menu 
Disallow everything other than adding a child note in My Publications,
since the wizard only shows on drag (currently, at least). Need to
disable translation separately.

Also show "Delete Item[s]..." in the trash context menu, and hide rather
than disable various menu options.

Addresses #703 -- still need to disable saved search saving
 2015-11-03 17:08:10 -05:00
Dan Stillman
687ee6ba07 Fix sync error from items dragged between libraries before first sync 
And fix bug in Zotero.URI.getURILibrary()
 2015-11-02 20:36:47 -05:00
Dan Stillman
318528df4d Remove obsolete sync code 2015-11-02 03:23:15 -05:00
Dan Stillman
d07756d68d Store API key in login manager, and add temp field in prefs 2015-11-02 03:22:37 -05:00
Dan Stillman
e03cf637b6 Fix 412 handling 2015-11-02 03:20:29 -05:00
Dan Stillman
7f43ca9503 Merge branch '4.0' 2015-11-01 21:22:13 -05:00
Dan Stillman
e0b5111442 Update some outdated Zotero.Libraries.getType()/getName() calls 2015-11-01 18:29:02 -05:00
Dan Stillman
3ad6e78d98 "Use"->"Keep" existing rights field for clarity in My Publications 2015-11-01 18:21:48 -05:00
Dan Stillman
53478f4752 Allow 412 when uploading deletions 2015-11-01 13:28:03 -05:00
Dan Stillman
110f637d1e Don't default to Creative Commons license for My Publications 
Just share on zotero.org by default, and let user choose CC if desired.
 2015-11-01 03:59:01 -05:00
Dan Stillman
7e3ba7bc61 Misc. debug tweaks 2015-11-01 03:59:01 -05:00
Dan Stillman
1e6c29766f Add deletion uploading to API syncing [DB reupgrade] 
Tags deletions are not currently synced, and maybe don't need to be.
 2015-11-01 03:58:54 -05:00
Dan Stillman
6b8e5bafc6 Don't show deleted items outside of trash 2015-11-01 03:36:23 -05:00
Dan Stillman
3692536770 Fixes #862, Trash Looks Empty 
Broken by 3ff1ff88a9
 2015-10-31 17:13:51 -04:00
Dan Stillman
532d485793 Delete older versions of processed objects in cache 
And recover from "Sync cache had later version than remote" error, which
shouldn't actually happen...
 2015-10-31 15:19:50 -04:00
Dan Stillman
6ccfed2488 Don't show item context menu until it's ready 
With async generation, an incorrect menu was showing first before the
correct version appeared.
 2015-10-31 03:46:47 -04:00
Dan Stillman
b06d93be50 Fix error syncing items in unloaded library 2015-10-31 01:39:36 -04:00
Dan Stillman
37b6a14f17 Fix attachment pane loading 2015-10-31 01:36:49 -04:00