mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Item.toJSON() should output unset mtime/md5 as null, not undefined

Browse source
This commit is contained in:
Dan Stillman 2015-12-22 01:49:45 -05:00
parent 84a6ea18f6
commit 8933e3b586
2 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
chrome/content/zotero/xpcom/data/item.js
View file

@ -3905,8 +3905,8 @@ Zotero.Item.prototype.toJSON = Zotero.Promise.coroutine(function* (options = {})
}
if (this.isFileAttachment()) {
obj.md5 = yield this.attachmentHash;
obj.mtime = yield this.attachmentModificationTime;
obj.mtime = (yield this.attachmentModificationTime) || null;
obj.md5 = (yield this.attachmentHash) || null;
}
}

12
test/tests/itemTest.js
View file

@ -873,6 +873,18 @@ describe("Zotero.Item", function () {
assert.strictEqual(json.deleted, 1);
})
it("should output unset storage properties as null", function* () {
var item = new Zotero.Item('attachment');
item.attachmentLinkMode = 'imported_file';
item.fileName = 'test.txt';
var id = yield item.saveTx();
var json = yield item.toJSON();
Zotero.debug(json);
assert.isNull(json.mtime);
assert.isNull(json.md5);
})
})
describe("'full' mode", function () {