mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Disable foreign key checks during schema modifications

Browse source 
Otherwise renaming a table causes existing foreign keys to be renamed.
This commit is contained in:
Dan Stillman 2015-12-29 23:37:45 -05:00
parent 8933e3b586
commit 6844deba60
1 changed files with 24 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
chrome/content/zotero/xpcom/schema.js
View file

@ -117,26 +117,30 @@ Zotero.Schema = new function(){
yield Zotero.DB.backupDatabase(userdata, true);
}
var updated = yield Zotero.DB.executeTransaction(function* (conn) {
yield Zotero.DB.queryAsync("PRAGMA defer_foreign_keys = true");
var updated = yield _updateSchema('system');
// Update custom tables if they exist so that changes are in
// place before user data migration
if (Zotero.DB.tableExists('customItemTypes')) {
yield _updateCustomTables(updated);
}
updated = yield _migrateUserDataSchema(userdata);
yield _updateSchema('triggers');
// Populate combined tables for custom types and fields -- this is likely temporary
//
// We do this again in case custom fields were changed during user data migration
yield _updateCustomTables()
return updated;
}.bind(this));
yield Zotero.DB.queryAsync("PRAGMA foreign_keys = false");
try {
var updated = yield Zotero.DB.executeTransaction(function* (conn) {
var updated = yield _updateSchema('system');
// Update custom tables if they exist so that changes are in
// place before user data migration
if (Zotero.DB.tableExists('customItemTypes')) {
yield _updateCustomTables(updated);
}
updated = yield _migrateUserDataSchema(userdata);
yield _updateSchema('triggers');
// Populate combined tables for custom types and fields -- this is likely temporary
//
// We do this again in case custom fields were changed during user data migration
yield _updateCustomTables()
return updated;
}.bind(this));
}
finally {
yield Zotero.DB.queryAsync("PRAGMA foreign_keys = true");
}
if (updated) {
// Upgrade seems to have been a success -- delete any previous backups