Shelley Vohr
1a3661206e
remove unused deprecate module from crashreporter
2018-02-20 08:31:38 -05:00
Shelley Vohr
fc025064f7
remove setExtraParameter for 2.0
2018-02-20 08:26:10 -05:00
Shelley Vohr
24f60dcd1b
re-add warning removed in https://github.com/electron/electron/pull/11013
2017-12-07 11:42:18 -05:00
Cheng Zhao
1c0ea0286e
Merge pull request #11235 from electron/standard-10
...
infra: Upgrade to StandardJS 10
2017-11-27 15:42:52 +09:00
Aleksei Kuzmin
465f9009ff
Update stack string parsing in the CallbacksRegistry
...
Fixes the "ipc module > remote listeners
> detaches listeners subscribed to destroyed renderers, and shows a warning"
test.
2017-11-24 10:58:53 +09:00
Felix Rieseberg
f7d6e3fa7b
🔧 Disable standard/no-callback-literal where necessary
2017-11-23 13:53:03 -08:00
Felix Rieseberg
451a44c4b5
🔧 Don’t use deprecated new Buffer()
2017-11-23 13:41:47 -08:00
Felix Rieseberg
05bae0b4c4
🔧 Util is no longer used here
2017-11-20 09:52:13 -08:00
Felix Rieseberg
71b8eaf085
🔧 Don’t use deprecated util.is* methods
2017-11-20 09:40:47 -08:00
Felix Rieseberg
c9f2080e4b
🔧 fs.readFile: options are optional
2017-11-20 08:20:20 -08:00
Charles Kerr
4c04f1c7ed
Merge pull request #11117 from electron/add_deprecations_spec
...
Add to deprecations spec
2017-11-20 09:07:06 -06:00
Shelley Vohr
7904be8763
comment out unused methods
2017-11-20 15:12:34 +01:00
Shelley Vohr
933c7330a5
changes from review
2017-11-16 13:39:07 -05:00
Shelley Vohr
75a117e4e2
edit empty function for platform consistency
2017-11-16 13:27:08 -05:00
Shelley Vohr
f5c04c7037
fix includes
2017-11-16 13:27:08 -05:00
Shelley Vohr
e5983eacd6
add callbacks registry spec
2017-11-16 13:27:07 -05:00
Shelley Vohr
dc410efa36
rename and fix assoc. test
2017-11-14 14:56:16 -05:00
Shelley Vohr
99d35f7786
a few more updates to tests
2017-11-14 13:33:38 -05:00
Shelley Vohr
d05a1f8053
first pass at deprecation spec updates
2017-11-13 20:21:57 -05:00
Aleksei Kuzmin
bd766067ac
Remove unused deprecate
var to make linter happy
2017-11-04 07:52:47 +03:00
Aleksei Kuzmin
b3a1fc65e5
Disable deprecation warning of crashReported.setExtraParameter()
...
It caused a couple of Crash Reported tests to timeout on Mac.
Task to enable it back:
https://github.com/electron/electron/issues/11012
2017-11-04 07:48:39 +03:00
Shelley Vohr
65f125a245
wrap deprecation warning
2017-11-01 23:27:20 -04:00
Shelley Vohr
24acd74d15
update deprecation warning
2017-11-01 22:23:33 -04:00
Shelley Vohr
3af83f1c97
add new method and mark setExtraParameter for deprecation
2017-11-01 21:57:43 -04:00
Shelley Vohr
93df164485
add const and other small edits
2017-10-31 23:42:25 -04:00
Shelley Vohr
3136f833a5
fixes and updates to GetParameters
2017-10-31 13:51:44 -04:00
Shelley Vohr
a9c13359dc
first attempt to add new GetParameters method to CrashReporter
2017-10-31 13:06:54 -04:00
Shelley Vohr
cb78e4875b
fix two failing tests
2017-10-30 23:15:57 -04:00
Shelley Vohr
603060f051
add new tests
2017-10-30 22:51:22 -04:00
Siyuan Liu
f56abac7a8
fix linting error
2017-08-01 17:52:48 +08:00
Siyuan Liu
5a48c1feed
fixes 10128
2017-07-31 09:32:45 +08:00
Kevin Sawicki
de62f1ea6c
Restart crash service in each spec
2017-04-19 16:37:24 -07:00
Thiago de Arruda
d78f3cae7b
Expose builtin v8 modules to AtomSandboxedRendererClient
...
- Adapt node.cc code that implements `process.binding` to create a similar
object in AtomSandboxedRendererClient.
- Replace the ipc binding object passed to `lib/sandboxed_renderer/init.js` by
the new binding object.
- Refactor the initialization script to use this new object to fetch the ipc
binding and store as a hidden value using the `v8_util` module.
This change also required applying a patch to node.js, so the submodule commit
was updated.
2017-03-09 20:39:14 -03:00
Thiago de Arruda
44bd93589a
Refactor electron exports to keep module list in separate files
2017-03-09 19:08:01 -03:00
Felix Rieseberg
4aaa936803
Fix init check for process.windowsStore
...
Windows now allows users to move their `WindowsApps` folder, meaning that it can end up on a different drive (and outside of `Program Files`).
2017-03-01 11:48:51 -08:00
Kevin Sawicki
b51adf8ae5
Add spec for updated extra parameters
2017-02-14 09:37:09 -08:00
Kevin Sawicki
ba975d552a
Add setExtraParameter support on macOS
2017-02-14 09:37:09 -08:00
Kevin Sawicki
3e18d8baf5
Remove _ prefix on binding methods
2017-02-14 09:37:09 -08:00
Kevin Sawicki
d6d85ade8e
🎨 Assign binding as const
2016-12-02 13:40:31 -08:00
Kevin Sawicki
3b99827540
Coerce features to string
2016-12-02 13:40:31 -08:00
Kevin Sawicki
f56b00718b
Remove unused method
2016-12-01 14:56:00 -08:00
Kevin Sawicki
c8ff67ab75
Use spread syntax instead of function apply
2016-12-01 14:56:00 -08:00
Kevin Sawicki
bb9876bd6e
Remove deprecation warning for autoSubmit
2016-11-28 15:08:28 -08:00
Samuel Attard
2bf6f28152
shouldUpload --> uploadToServer
2016-11-28 15:08:28 -08:00
Samuel Attard
4b61a4d3de
Fix linting
2016-11-28 15:08:28 -08:00
Samuel Attard
285a36f9de
Use GetUploadsEnabled to return GetShouldUpload
2016-11-28 15:08:28 -08:00
Samuel Attard
5a1a2616aa
Fix build issues
2016-11-28 15:08:12 -08:00
Samuel Attard
0d1804b2a0
Fix issues and deprecate the old prop
2016-11-28 15:08:12 -08:00
Samuel Attard
7b8eb3e09c
Rename autoUpload to shouldUpload
2016-11-28 15:08:12 -08:00
Kevin Sawicki
0593696344
Remove unnecessary escape characters
2016-11-23 14:27:54 -08:00
Kevin Sawicki
bea1a0643c
Memoize ELECTRON_NO_ASAR env var check
2016-11-16 07:37:53 -08:00
Kevin Sawicki
1718697ef0
Read/write find pasteboard text via IPC in renderer process
2016-10-25 14:15:54 +09:00
Kevin Sawicki
68c2c9825f
Remove lint warnings
2016-10-25 10:36:43 +09:00
Kevin Sawicki
3aad6a0c99
Use forEach and destructuring for parsing features
2016-10-25 10:31:50 +09:00
Paul Frazee
f35536bdc5
factor out parse-features-string.js
2016-10-24 20:21:42 -05:00
Kevin Sawicki
f553d16539
Only support ELECTRON_NO_ASAR in non browser/renderer processes
2016-10-12 11:11:27 -07:00
Benjamin Pasero
656ee0d9c3
introduce ELECTRON_NO_ASAR
2016-10-12 11:11:27 -07:00
Kevin Sawicki
d39182b41a
Pass crashes directory instead of product name and temp dir
2016-10-06 10:55:11 -07:00
Kevin Sawicki
16e3991ffa
Guard against app.getPath throwing with OS fallback
2016-10-06 10:07:40 -07:00
Kevin Sawicki
883c4b63d0
temp_path -> temp_dir
2016-10-06 09:02:02 -07:00
Kevin Sawicki
0380d3ae50
Pass crashes directory to crash service process
2016-10-06 09:02:02 -07:00
Kevin Sawicki
43702e0f8e
Support calling getUploadedReports on unstarted crash reporter
2016-10-06 09:02:02 -07:00
Kevin Sawicki
a0db484510
Use app.getPath directly for temp path
2016-10-06 09:02:02 -07:00
Kevin Sawicki
f282b51c98
🎨 Use ES6 class, destructuring, and let/const
2016-10-06 09:02:01 -07:00
Kevin Sawicki
ac0658bbf1
Use PathService for temp dir path for crashes
2016-10-06 09:02:01 -07:00
Kevin Sawicki
e77d7e7f62
🎨
2016-09-16 11:41:53 -07:00
Kevin Sawicki
5d0f3534eb
Rethrow binding errors
2016-09-16 11:34:52 -07:00
Kevin Sawicki
902bd0564e
Require Buffer explicitly instead of relying on global
2016-09-08 10:17:06 -07:00
Kevin Sawicki
28b33074cf
Setup stdin in both processes on Windows
2016-09-07 14:45:56 -07:00
Kevin Sawicki
46fbb6ed61
Reset process.noAsar in finally block
2016-09-06 13:40:25 -07:00
Kevin Sawicki
8eca019157
Support paths as Buffers
2016-07-25 11:10:36 -07:00
Kevin Sawicki
30fbe92970
Add asar-supported fs.accessSync implementation
2016-07-25 11:05:18 -07:00
Kevin Sawicki
3ad5504194
Add asar-supported fs.access implementation
2016-07-25 10:50:30 -07:00
Kevin Sawicki
a518c47f4c
Use let/const instead of var
2016-07-25 10:43:38 -07:00
Cheng Zhao
1c9421bc89
Use ArrayBuffer.isView to detect Buffer and ArrayBuffer
2016-07-25 16:39:09 +09:00
haad
fac330fb50
Fix TypedArray check, add check when instanceof doesn't work for TypedArrays.
2016-07-23 12:43:49 +01:00
haad
2757046e71
Add isTypedArray to Electron exports
2016-07-23 11:30:14 +01:00
haad
e6c8900a18
Fix linting
2016-07-22 20:20:24 +01:00
haad
c717cd9192
🐛 Add support for TypedArrays in IPC.
...
Fixes https://github.com/electron/electron/issues/2104 .
2016-07-22 19:44:19 +01:00
Cheng Zhao
f792b6c752
Remove callbackId when callback is removed from registry
2016-06-24 11:22:48 +09:00
Kevin Sawicki
bac4d51169
Reuse root path variable
2016-06-23 15:56:29 -07:00
Kevin Sawicki
905e9e9645
Include trailing separator in comparisons
2016-06-23 15:45:08 -07:00
Kevin Sawicki
b273b70eee
Filter existing search paths instead reimplementing
2016-06-23 15:27:45 -07:00
Cheng Zhao
93b8237e1f
Merge pull request #5700 from felixrieseberg/standard-7
...
Implement JavaScript Standard Style 7
2016-05-26 04:57:36 +00:00
Cheng Zhao
8a4b7eb062
Merge pull request #5689 from cdaringe/master
...
Support non-native promises
2016-05-26 04:49:40 +00:00
Felix Rieseberg
bef6748c06
🎨 Implement JS Standard Code Style 7
...
Updates Standard Code Style to 7 (latest major) and ensures that code
is conform.
* camelCase is now enforced
* No assignments in return statements
2016-05-25 16:20:49 -07:00
cdaringe
32073fa079
🎨 Support non-native promises
2016-05-25 10:11:18 -06:00
Kevin Sawicki
7e209dd982
ATOM_SHELL_INTERNAL_CRASH_SERVICE -> ELECTRON_INTERNAL_CRASH_SERVICE
2016-05-25 09:08:09 -07:00
Kevin Sawicki
a4f94b89b4
Add comment about Module path
2016-05-23 15:15:39 -07:00
Kevin Sawicki
6ac0151e65
Remove lint warnings
2016-05-23 15:14:55 -07:00
Kevin Sawicki
19fd841c30
🎨
2016-05-23 15:14:55 -07:00
Kevin Sawicki
566b0676bc
Pre-resolve electron require path
2016-05-23 15:14:55 -07:00
Kevin Sawicki
daea448b61
.coffee -> .js
2016-05-23 15:14:55 -07:00
Cheng Zhao
4193fb1742
Merge pull request #5617 from electron/dont-return-from-on-functions
...
Remove returns from event listeners
2016-05-20 00:26:29 +00:00
Kevin Sawicki
cc7395eea8
Remove returns from event listeners
2016-05-19 15:28:08 -07:00
Juan Cruz Viotti
1a27ecdad4
Override child_process.execFile
asar patch for child_process.exec
...
NodeJS implements `child_process.exec` by simply passing the whole
command to `child_process.execFile`. See:
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L90
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L99
Electron patches `child_process.execFile` to add support for `asar`
archives by injecting logic that extracts the required files from the
`asar` to a temporary location before delegating the work to the
original `child_process.execFile`.
In order to decide whether to inject the custom `asar` extracting logic,
Electron makes use of a helper function called `splitPath()`. See:
- https://github.com/electron/electron/blob/master/lib/common/asar.js#L37
If the first argument of the returned array equals `true`, means that
the path is considered to be an `asar` archive, and thus the extraction
logic takes place. The problem is that if the command passed to
`child_process.execFile` *contains* a path to an asar archive, padded
with other commands/arguments, `splitPath()` will consider it to be an
`asar` archive, and will try to extract it, throwing a rightfully
`Invalid package` error.
Fixes: https://github.com/electron/electron/issues/5571
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-05-19 17:19:36 -04:00
Kevin Sawicki
d627ead273
Remove linter errors
2016-05-06 10:12:55 -07:00
Kevin Sawicki
16d4c436cb
Keep exporting deprecate/deprecations
2016-05-06 10:12:55 -07:00
Kevin Sawicki
2ce4237083
Remove hideInternalModules API
2016-05-06 10:12:54 -07:00
Kevin Sawicki
dafa14fe42
Don't export deprecate API
2016-05-06 10:12:54 -07:00