mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
21076 commits 1 branch 183 tags 5.3 GiB
Commit graph

6964 commits

Author SHA1 Message Date
deepak1556
d21e30f57b Reorganize MediaStreamType enums 
https://chromium-review.googlesource.com/c/chromium/src/+/1160000
 2018-12-03 20:07:40 +05:30
deepak1556
d1da0aad7f Make IsolateHolder aware of the isolate type. 
https://chromium-review.googlesource.com/c/chromium/src/+/1183194
 2018-12-03 20:07:40 +05:30
deepak1556
321f87fe61 Complete TaskPriority::BACKGROUND->BEST_EFFORT mass rename 
https://chromium-review.googlesource.com/c/chromium/src/+/1153461
 2018-12-03 20:07:40 +05:30
deepak1556
6743b83786 Add notifications to UKM.xml. 
https://chromium-review.googlesource.com/c/chromium/src/+/1071649
 2018-12-03 20:07:40 +05:30
deepak1556
f464b8c4c5 Respond for handling protocol commands async 
https://chromium-review.googlesource.com/c/chromium/src/+/1139575
 2018-12-03 20:07:40 +05:30
deepak1556
25d0a7b62a Create a CodeCache per each storage_partition to store generated code 
https://chromium-review.googlesource.com/c/chromium/src/+/1120179
 2018-12-03 20:07:40 +05:30
deepak1556
b5b49c9ed0 FIXME: Remove SchemeRegistry::RegisterURLSchemeAsCORSEnabled 
https://chromium-review.googlesource.com/c/chromium/src/+/1157364
 2018-12-03 20:07:40 +05:30
deepak1556
ffeab383b5 Move NetworkConnectionTracker getter to network_service_instance.h 
https://chromium-review.googlesource.com/1162888
 2018-12-03 20:07:40 +05:30
deepak1556
0bd006a8eb ProxyConfigDictionary: Use base::Value 
https://chromium-review.googlesource.com/c/chromium/src/+/1150846
 2018-12-03 20:07:40 +05:30
deepak1556
0f9dd3736c Move CRLSets to being part of CertVerifier::Config 
https://chromium-review.googlesource.com/c/chromium/src/+/1132706
 2018-12-03 20:07:39 +05:30
deepak1556
6310d6c699 Flatten ResourceRequestBody data 
https://chromium-review.googlesource.com/c/chromium/src/+/1114258
 2018-12-03 20:07:39 +05:30
deepak1556
b2d53f1e1e FIXME: word_start and medial_capital_as_word_start are removed from WebFindOptions 
https://chromium-review.googlesource.com/c/chromium/src/+/1175645
 2018-12-03 20:07:39 +05:30
deepak1556
4179cedf37 Change SubscribePermissionStatusChange to use a RFH to query permissions 
https://chromium-review.googlesource.com/c/chromium/src/+/979735
 2018-12-03 20:07:39 +05:30
deepak1556
66349261a5 fix: update to per context v8::Script::Compile api 2018-12-03 20:07:39 +05:30
deepak1556
c1f32afeeb Use CompletionOnceCallback in URLRequestSimpleJob. 
https://chromium-review.googlesource.com/c/chromium/src/+/1155089
 2018-12-03 20:07:39 +05:30
deepak1556
8f1fa4177e Fix invalid handle errors found with App Verifier 
https://chromium-review.googlesource.com/c/chromium/src/+/1145767
 2018-12-03 20:07:39 +05:30
deepak1556
535d264497 fix: [UI] Resolve method conflict between MenuModel, SimpleMenuModel::Delegate 
https://chromium-review.googlesource.com/c/chromium/src/+/1230581
 2018-12-03 20:07:39 +05:30
deepak1556
2eedcde914 fix: Remove DEFINE_WEB_CONTENTS_USER_DATA_KEY in //electron. 
https://bugs.chromium.org/p/chromium/issues/detail?id=589840
 2018-12-03 20:07:39 +05:30
Samuel Attard
6b4b7c9831 chore: make BrowserObserver a CheckedObserver 
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1053338
 2018-12-03 20:07:38 +05:30
Samuel Attard
b6aae790cf fixme: C70 removed DidReceiveCompositorFrame 
(OSR relatied)

refs: 1de1ca906a

cc @brenca
 2018-12-03 20:07:38 +05:30
Samuel Attard
74d1685523 chore: fix ShouldFork impl, referrer stripping has been removed 
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1124329
 2018-12-03 20:07:38 +05:30
Samuel Attard
c9007557e5 chore: post_task and friends now live under base/task 
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1161088
 2018-12-03 20:07:38 +05:30
Samuel Attard
c4cb90ab85 chore: replace PreContentInitialization with PreCreateMainMessageLoop 2018-12-03 20:07:38 +05:30
Sylvester Keil
2e91bf1e15 Fix GTK menubar item color (#15878) 
Use menubar item color (not menu item color).
Closes #15194
 2018-11-30 09:28:45 -08:00
Jeremy Apthorp
83d951db7e chore: DCHECK that events are only emitted on the UI thread (#15873) 
* chore: DCHECK that events are only emitted on the UI thread

* move dcheck to EmitWithEvent
 2018-11-30 18:48:27 +09:00
Andy Dill
8cca1c987b fix: move NativeWindow tracking to OSR WCV (#15585) 
* fix: move NativeWindow tracking to OSR WCV

* fix oops
 2018-11-29 21:25:02 -08:00
Heilig Benedek
78b88a70bb fix: backport patch that ensures that cookie store is always created (#15836) 
* fix: backport patch that ensures that cookie store is always created

* fix: disable cookie encryption

* fix: flush the cookie store when NetworkContext shuts down

* test: add test for cookie store persistance

* Update patches/common/chromium/ensure_cookie_store.patch

Co-Authored-By: brenca <benecene@gmail.com>

* Update patches/common/chromium/ensure_cookie_store.patch

Co-Authored-By: brenca <benecene@gmail.com>
 2018-11-29 10:51:13 -08:00
Shelley Vohr
165d168ee5
fix: ignore unused freopen result (#15884) 2018-11-29 09:36:08 -08:00
Jeremy Apthorp
62eb077f29
refactor: simplify logic for enabling stack dumping (#15872) 
ref #15785
 2018-11-28 22:23:41 -08:00
Michelle Tilley
8f04def7b2 fix: prevent bluetooth device list from growing without bound (#15805) 
* fix: include bluetooth strings in build

* fix: prevent bluetooth device list from growing without bound
 2018-11-28 11:36:00 -05:00
Andy Dill
55808dffcd fix: osr windows respect display scale factor (#15733) 2018-11-28 11:16:03 -05:00
Milan Burda
07f8f5f95a refactor: eliminate duplicate code exposing process APIs (#15824) 2018-11-28 11:08:17 -05:00
Nitish Sakhawalkar
9890d1e251 feat: Implement process.getProcessMemoryInfo to get the process memory usage (#14847) 
* feat: Implement process.getMemoryFootprint to get the process memory usage

* Add spec

* fix: must enter node env in callback

* Update function call

* Update spec

* Update API data

* update spec

* Update include

* update test for shared bytes

* Update atom/common/api/atom_bindings.cc

Co-Authored-By: nitsakh <nitsakh@icloud.com>

* Update atom/common/api/atom_bindings.cc

Co-Authored-By: nitsakh <nitsakh@icloud.com>

* Update API

* Update the callback isolate

* Update to work after app ready

* Update docs

* Update docs/api/process.md

Co-Authored-By: nitsakh <nitsakh@icloud.com>

* Update docs/api/process.md

Co-Authored-By: nitsakh <nitsakh@icloud.com>

* Fix crash
 2018-11-28 17:57:53 +09:00
Shelley Vohr
41c2685204
feat: promisify win.capturePage() (#15743) 
* feat: promisify win.capturePage

* mark optional arg correctly

* Add to breaking changes doc

* properly deprecate win.capturePage

* remove change from api-contract

* document both callback and promise versions

* address docs feedback

* update promisification progress doc
 2018-11-27 23:50:53 -05:00
Shelley Vohr
73fbb69c50
chore: change return type of platform_util::SetLoginItemEnabled (#15854) 2018-11-27 23:16:53 -05:00
Milan Burda
81e00d8e56 chore: fix V8 deprecation warnings (#15842) 2018-11-27 16:42:02 -05:00
Milan Burda
d63a848011 feat: add activate option to webContents.openDevTools (#13852) 2018-11-27 18:34:44 +09:00
Cheng Zhao
d1f0d6c184 fix: remove event monitor before destroying window 2018-11-27 11:10:07 +09:00
Jeremy Apthorp
23de301955 chore: remove scoped_clipboard_writer.patch (#15843) 
replace with already-exposed APIs
 2018-11-27 09:51:26 +09:00
Simone Cattaneo
6f116eeaa4 fix: improved event flow management related to 'will-resize' event on Windows (#15695) 2018-11-26 12:26:48 -08:00
Heilig Benedek
0242818f39 feat: add registerAccelerator flag to allow menu items to optionally skip accelerator registration (#15723) 
* feat: add registerAccelerator flag to allow menu items to skip registration

* docs: add docs for registerAccelerator

* docs: re-add accidentally removed line
 2018-11-26 10:43:55 -08:00
Jeremy Apthorp
a8a881c8db
chore: restore //url dchecks (#15637) 2018-11-22 09:02:52 -08:00
Robo
9e8b26cc4e fix: bypass CORB when web security is disabled (#15737) 
* fix: extend content layer hook to bypass corb when web security is disabled.

* chore: add patch to disable CORB
 2018-11-21 14:10:05 -06:00
Heilig Benedek
5db8197a5d fix: schedule a paint after browserview's background is set (#15784) 2018-11-21 13:04:10 -06:00
Samuel Attard
0b0a17ff91 fix: load the chrome.* API on chrome-extension pages in sandbox mode (#15563) 
With mixed sandbox enabled we need to load the chrome.* APIs in the
sandbox init.js so that chrome extensions load correctly.

This mirrors the equivilant impl in `atom_renderer_client.cc`

Fixes #15561
 2018-11-21 12:56:58 -05:00
malern
a68e3371f3 fix: remove duplicated status code (#15707) 
Removed the hardcoded status code from the protocol response as the real status code is appended immediately after.
 2018-11-21 10:47:05 -06:00
Cheng Zhao
47bf8e1bb3
view: add ResizeArea class (#15752) 2018-11-21 22:39:59 +09:00
Charles Kerr
40619efb3b chore: remove FileChooser AddExtensionForFilename (#15510) 2018-11-20 16:24:39 -05:00
Ondřej Záruba
de05ff894b feat: Add app.getLocaleCountryCode() method for region detection (#15035) 
* Add method to get system´s user region

* Fix linter

* Remove auto types

* Improved detection for POSIX

* Change name, add specs, minor fixes

* Remove left overs

* Fix locale test

* Fix Linux test

* Coding style fixes

* Fix docs

* Add test excaption for Linux

* fix spelling

* Polishing
 2018-11-20 15:33:23 -05:00
Pedro Pontes
57d2ae1aec revert: "fix: window.open site instance should belong to same browsing instance (#15216)" (#15757) 
This reverts commit 8f35198bfb.
 2018-11-20 21:28:26 +01:00
Jeremy Apthorp
90d1c0b2b6
chore: don't explicitly destroy asar archives (#15734) 2018-11-19 13:12:41 -08:00
Andrzej Szombierski
51cb36fa9b fix: ensure that file descriptors 0/1/2 are opened at startup (#15555) 
* fix: ensure that file descriptors 0/1/2 are opened at startup

This fixes an issue where the gpu subprocess was writing messages to a
random pipe or socket. The standard file desciptors are closed in
chromium's subprocesses because of an unfortunate interaction with
libuv's tty handling code leaving them with the FD_CLOEXEC flag.

* style: fix lint warnings
 2018-11-19 11:53:55 -05:00
Simone Cattaneo
b97d7e7ecd fix: On close trying to remove observer from an empty collection leads to an access violation (#15739) 2018-11-19 11:47:04 -05:00
Cheng Zhao
e12c0dcf66
Merge pull request #15618 from electron/system_netwok_context 
fix: create system network context for global requests
 2018-11-19 11:25:34 +09:00
Jeremy Apthorp
20116d7f05
fix: always disable setuid sandbox on linux (#15722) 2018-11-15 13:27:56 -08:00
Jeremy Apthorp
0642be296d
fix: crash in sandbox on linux when getting execPath (#15701) 2018-11-15 12:59:01 -08:00
Shelley Vohr
511dc9a80b
feat: add numpad accelerator strings (#15689) 2018-11-14 14:02:18 -05:00
deepak1556
7e1168c518 fix: return system shared url loader for content layer 2018-11-14 12:42:24 +05:30
deepak1556
57356036db fix: initialize system network context from IOThread 2018-11-14 12:42:24 +05:30
deepak1556
666a106fa8 refactor: move IOThread and NetLog ownership to g_browser_process 2018-11-14 12:42:24 +05:30
deepak1556
414dcfcd07 fix: create system network context for global requests 
Global requests currently includes DNS over HTTPS requests,
certain cert validation requests (OCSP, AIA, etc) on some platforms
and geolocation requests.
 2018-11-14 12:42:24 +05:30
Shelley Vohr
787dbbe610
feat: add about panel customization on linux (#15658) 2018-11-13 17:12:24 -05:00
Pedro Pontes
8f35198bfb fix: window.open site instance should belong to same browsing instance (#15216) 2018-11-12 22:01:43 +01:00
Shelley Vohr
a54dd1085a
feat: expose showAboutPanel for MacOS (#15674) 2018-11-11 22:52:27 -05:00
Samuel Attard
1cf28e8b75 build: auto-gen libnotify_loader.cc (#15648) 2018-11-10 14:21:40 -05:00
Shelley Vohr
9fd98bb27b
refactor: no longer require submenu for services menuitem (#15656) 2018-11-10 12:47:55 -05:00
Nitish Sakhawalkar
025aa49f67 fix: NSWindow crash happening on macos 10.9 (#15660) 2018-11-10 14:53:35 +01:00
Nitish Sakhawalkar
5994bf6745
fix: Menu accelerators not working (#15094) 
This change fixes the regression in the menu accelerators working in linux, on some environments.
 2018-11-09 13:54:16 -08:00
Samuel Attard
e7b2b93cee
chore: re-enable DCHECK in node_debugger (#15649) 2018-11-09 14:44:31 +11:00
Robo
82322968a3 refactor: printing implementation (#15143) 
* refactor: basic printing

* move build files to chromium_src/BUILD.gn
* remove dependency on chrome prerender sources

* spec: move printing specs behind feature flag

* build: register pdf compositor service
 2018-11-09 14:42:34 +11:00
Samuel Attard
9aed2a465f fix: send NSView* as the response to getNativeWindowHandle() instead of a null handle (#15521) 2018-11-08 09:03:19 -08:00
Cheng Zhao
746beb0d8b fix: destroy WebContents synchronously on shutdown (#15541) 2018-11-08 07:57:28 -08:00
Jeremy Apthorp
7e0e12b8a3 fix: match Chrome's font fallback behavior (#15486) 
* fix: match Chrome's font fallback behavior

Fixes #15481

* add a cache

* add test

* another test

* fix tests

* arial -> dejavu sans on linux apparently?
 2018-11-08 10:51:51 -04:00
Heilig Benedek
ca2d74e118 feat: add methods to allow customization of save dialog during will-download event (#15497) 
* feat: add method to DownloadItem that allows customization of dialog options

* docs: add docs for get/setSaveDialogOptions

* add missing copy constructor for DialogSettings on mac and linux

* fix: don't filter dialog options for mas build, don't return properties

* test: add test for get/setSaveDialogOptions

* fix: remove openDevtools added for debugging

* test: fix failing test because of new event parameter

* docs: use SaveDialogOptions instead of Object
 2018-11-08 10:51:06 -04:00
Michelle Tilley
2a8e8a0603 fix: make certain values on process read-only (#15628) 
* docs: Add 'worker' as a possible value for `process.type`

* fix: make certain properties on `process` read only:

* `mas`
* `windowsStore`
* `versions.electron`
* `versions.chrome`
* `type`
* `pid`
* `sandboxed`
 2018-11-08 10:28:06 -04:00
Shelley Vohr
e9ba26f50e
feat: allow registering multiple shortcuts (#15542) 
This PR allows for multiple global shortcuts to be registered such that triggering any of them calls the same callback.
 2018-11-07 09:40:38 -08:00
Jeremy Apthorp
934a7fc118
refactor: don't use AppIndicatorIcon directly (#15536) 2018-11-06 11:00:37 -08:00
Shelley Vohr
ece4c81c1a
fix: hiddenInset titleBar console spam (#15576) 2018-11-05 21:02:46 -08:00
Shelley Vohr
dcd2bf451d
refactor: remove 10.9 specific menu code (#15578) 2018-11-05 20:42:19 -08:00
Jeremy Apthorp
77f69cbe08
chore: remove unused use_transparent_window.patch (#15534) 
Unneeded since 6f2f761df3 (diff-0bbbec38254ebb1146b15c15277c6aa1)
 2018-11-05 13:19:21 -08:00
Shelley Vohr
c60745b8a3
fix: use NSURL path for receipt url (#15355) 2018-11-05 09:49:51 -08:00
Milan Burda
a19d20cfb8 refactor: more cleanup of chromium_src (#15424) 2018-11-05 10:29:33 -04:00
Samuel Attard
7f73240fd5
chore: use chromes auto generated definition of CHROME_VERSION_STRING (#15275) 2018-11-02 23:32:33 +11:00
Charles Kerr
feb31d088b
fix: honor properties.showHiddenFiles on Linux (#15503) 
Previously the code only set the GtkFileChooser's property if `properties.showHiddenFiles` was set. 

This PR unconditionally sets the GtkFileChooser's property so that hidden files will be hidden if `properties.showHiddenFiles` was not set.
 2018-10-31 16:13:01 -05:00
Shelley Vohr
b2e1a93177
refactor: remove hardcoded google api key (#15478) 
* refactor: remove hardcoded Google API key

* address changes from review
 2018-10-31 07:49:44 -07:00
Heilig Benedek
6d2a088be9 feat: detect high contrast color mode (#15493) 
* feat: add event and method to detect high contrast color mode

* docs: add docs for isHighContrastColorScheme and high-contrast-color-scheme-changed

* refactor: correct type of contrast
 2018-10-31 10:22:18 -04:00
Heilig Benedek
aa6f7a5d9f fix: don't append Shift modifier text twice to accelerators (#15400) 
* fix: don't append Shift modifier text twice to accelerators

* style: use the new way of creating patches

* test: add menu item accelerator display tests

* fix: allocate accelerator on the stack

* fix: adjust tests to match expected behavior on mac
 2018-10-31 10:13:44 -04:00
Heilig Benedek
894ae1b3f5 refactor: Improve accessibility of menus (#15302) 
* refactor: improve menubar keyboard accessibility

* fix: create a temporary widget for tray icon context menu

* fix: focus menu bar with Alt when autohide is off

* fix: make menu bar focus work more like the native menus

* fix: only focus menu bar if it's not already focused

* fix: track accelerator registration to avoid duplicates

* docs: add docs for & notation in app menu item names

* fix: only try to activate accelerator if it's registered

* fix: add friend to monitor window focus change

* style: add <memory> include
 2018-10-29 13:08:46 -05:00
Milan Burda
f921df7ad1 chore: move spellcheck out of chromium_src (#15407) 2018-10-26 10:34:57 -07:00
Shelley Vohr
bea4de9262
fix: use gio as default linux trash impl (#15399) 
* fix: use gio as default linux trash impl

* doc: add ELECTRON_TRASH env var
 2018-10-26 08:36:56 -07:00
Shelley Vohr
d21d83cfc8
fix: folder open not working in devtools (#15387) 2018-10-25 08:36:48 -07:00
Milan Burda
1f3a89197c chore: bump minimum supported macOS version to 10.10 (#15357) 2018-10-25 10:59:42 +02:00
Cheng Zhao
2f3a8ecd42
fix: child window with nativeWindowOpen should disable node integration (#15213) 
* fix: child window with nativeWindowOpen should disable node integration

* Revert "fix: do not enable node integration in child window if not enabled (#15076)"

This reverts commit 0252d7686c.

This patch is not needed anymore since we are force disabling node integration
for child windows.
 2018-10-25 15:31:07 +09:00
Andy Dill
7a23980f4b fix: set NSResizableWindowMask at init time (#15106) 2018-10-25 10:34:11 +09:00
Islam Sharabash
3b6f0d83e1 fix: allow stream protocols to return headers with multiple values (#14887) 
* fix: allow stream protocols to return headers with multiple values

This allows stream protocols to return headers with multiple values as
an array of values.

Fixes https://github.com/electron/electron/issues/14778

* Prefer ConvertFromV8

* Cleanup header conversion

1. Deduplicate the code by using a lambda
2. Remove duplicate calls to headers->Get(key)

* Fix broken test

Headers with multiple values are now being converted correctly, this
test asserted the wrong behavior.
 2018-10-25 11:34:20 +11:00
Milan Burda
8ba271efba refactor: eliminate brightray (#15240) 2018-10-24 12:49:10 +02:00
Jeremy Apthorp
1d8ab03146 refactor: use public WakeLock interface (#15351) 
* refactor: use public WakeLock interface

* remove power_save_blocker visibility patch
 2018-10-23 22:12:58 -07:00
Milan Burda
465dee2c33 refactor: eliminate brightray::BrowserMainParts (#15336) 2018-10-23 13:15:55 -07:00
Charles Kerr
869e0ab14d
fix: honor dialog.showMessageBox()'s Icon argument on Linux (#15326) 
* Don't call gtk_widget_show_all() on popup dialog.

Fixes #15317.

Notes: Fixed incorrect display of some GtkMessageDialog icons.

The issue is caused because GtkMessageDialog contains an icon widget
which is not shown when there's no associated icon. Our call to
`gtk_widget_show_all()` overrides this, showing the uninitialized
icon widget.

This PR fixes the issue by calling `gtk_widget_show()` where needed
and removing use of `gtk_widget_show_all()` in the message dialog.

* use gtk_dialog_set_default_response() for default

* fix: support icons on gtk+ messageboxes.
 2018-10-23 12:44:47 -05:00
Cheng Zhao
260778e0fb feat: add MdTextButton to View APIs (#15328) 
* view: make button focusable by default

* view: add MdTextButton

* view: add common methods to LabelButton
 2018-10-23 10:57:13 -04:00
Nitish Sakhawalkar
ca4b4709e5 fix: Native window close crash (#15327) 2018-10-23 10:35:00 -04:00
Milan Burda
809bd3757b refactor: eliminate brightray::MainDelegate (#15333) 2018-10-23 14:16:13 +02:00
Milan Burda
fbbb704146 refactor: eliminate brightray::BrowserClient (#15320) 2018-10-23 10:45:41 +02:00
Michelle Tilley
13247e592b
fix: correct reversed logic in NativeWindowMac::SetEnabled (#15257) 2018-10-22 13:01:45 -07:00
Cheng Zhao
cb9be091aa refactor: remove potential double free when managing WebContents (#15280) 
* refactor: remove -new-contents-created event

Chromium expects us to take ownership of WebContents in AddNewContents,
we should not create V8 wrapper in WebContentsCreated, otherwise we
would have WebContents being managed by 2 unique_ptr at the same time.

* refactor: make CreateAndTake take unique_ptr
 2018-10-22 13:02:25 -05:00
Milan Burda
e8e7edf017 refactor: eliminate brightray::ContentClient (#15303) 2018-10-22 19:04:23 +02:00
Milan Burda
6d844a0b67 refactor: move media/net from brightray to atom (#15288) 2018-10-19 14:51:43 -04:00
Milan Burda
6f3c46cc7e refactor: move devtools from brightray to atom (#15234) 2018-10-19 15:50:30 +02:00
Cheng Zhao
94aa0762f0
refactor: remove WebContents::CreateFrom (#15241) 2018-10-19 17:52:07 +09:00
Samuel Attard
8bc0c343fa
fix: convert wstring to string on windows in node_bindings (#15266) 2018-10-19 13:11:43 +11:00
Andy Dill
37f2113032 feat: expose setBackgroundThrottling api (#15104) 2018-10-19 11:32:22 +11:00
Shelley Vohr
a0b9d47d5e fix: enable NODE_OPTIONS env var (#15158) 2018-10-19 10:57:28 +11:00
Michelle Tilley
51f3fb9bde
fix: correctly enable and disable windows on Windows and Linux (#15184) 2018-10-18 14:23:40 -07:00
Nitish Sakhawalkar
a9ca152069 feat: Spellchecker Async Implementation (#14032) 
* feat:Spellchecker Async Implementation

* Adhere to chromium style

* Updating dependency to use gh branch

* Update docs and electron-typescript-definitions module

* Fix lint

* Update electron typescript definitions version

* Update spec

* Address review
 2018-10-18 11:11:53 -05:00
Milan Burda
db37ab1039 feat: add remote.require() / remote.getGlobal() filtering (#15014) 2018-10-18 14:36:45 +11:00
Milan Burda
a369a4172b refactor: move notifications from brightray to atom (#15209) 2018-10-17 20:01:11 +02:00
Heilig Benedek
4d085c4aae fix: don't call ReadRawDataComplete if it's not necessary (#15185) 2018-10-16 21:57:26 -07:00
Cheng Zhao
0252d7686c
fix: do not enable node integration in child window if not enabled (#15076) 2018-10-16 18:10:03 +09:00
Jeremy Apthorp
2a4f5c3284 chore: add --fix option to lint:cpp (#14977) 
* chore: add --fix option to lint:cpp

* fix lint errors
 2018-10-15 22:59:45 -07:00
Nitish Sakhawalkar
0c711f690e fix: add microtask runner and fix promise test (#15071) 
* fix: Promise resolution and unit test

* Update to use microtask runner

* Address review
 2018-10-16 02:26:47 +11:00
Andy Dill
89bf71e580 fix: preserve background color through reload (#15105) 
* fix: preserve background color through reload

* fix: only set backgroundColor on top-level frames
 2018-10-14 10:59:47 -07:00
Milan Burda
d3efc52745 feat: add webPreferences.enableRemoteModule option (#13028) 2018-10-13 20:50:07 +03:00
Heilig Benedek
a82bcc7e3c refactor: move printing out of chromium_src (#15023) 
* remove printing related things from chromium_src

* chore: add printing build flag and patch

* fix: include PrintingService on other platforms too

* fix: printing_handler is only needed on Windows

* fix: format BUILD.gn properly

* fix: rename printing build flag to avoid conflict with chromium

* fix: place previously missed printing calls behind build flag

* fix: accidentally renamed flag in patch file

* fix: don't include all printing strings

* fix: allow ShowItemInFolder and OpenItem to block, fixing a DCHECK crash

* fix: make things compile, some changes got lost while rebasing

* fix: remove rogue line from BUILD.gn

* chore: update patch description

* style: lint fix

* chore: use chromium printing buildflag, move node related stuff out of patch

* revert: remove ScopedAllowBlockingForTesting call

* fix: fix my rebase blooper

* fix: re-add header lost during rebase, update patch

* fix: add <map> include, tweak the patch a bit

* revert: remove rogue diff from patch

* fix: clean up after rebase
 2018-10-13 12:57:04 +11:00
Shelley Vohr
6fc2a2a051 fix: natively implement LoginItem functions (#15010) 2018-10-12 15:19:27 -07:00
Heilig Benedek
5ef5d60f77 refactor: move color_chooser out of chromium_src (#15091) 
* chore: move color_chooser out of chromium_src

* fix: remove deleted source files

* fix: add build flag, patch and build instructions for ColorChooser
 2018-10-12 10:53:46 +11:00
Heilig Benedek
95696c9456 refactor: move text-to-speech out of chromium_src (#15024) 
* chore: add tts patch and buildflag, makes tts work again

* chore: add tts patch and buildflag, makes tts work again

* fix: make things compile

* build: add relevant tts files for linux

* fix: update patch and patch description, should now compile on mac

* build: move chrome specific sources under chromium_src:chrome target

* build: enable_extensions again

We are depending on them, check `//electron/chromium_src:chrome` target
for more info.

* fix: update tts.patch to receive notifications about browser context destruction

* fix: extend browser process from chrome layer

The global state g_browser_process is shared between //chrome
and //electron.

* spec: add basic speech synthesis test

* spec: skip speech tests on ci

* build: fix compilation on windows
 2018-10-11 08:52:12 -05:00
Shelley Vohr
ba9a55c391 fix: update and enable osr (#15046) 
* fix: update and enable osr

* fix: update MacHelper view to call GetNativeView

* style: move stuff around to make more sense

* chore: move OSR related things in SetOwnerWindow to CommonWebContentsDelegate

* fix: avoid crashing when GetOffscreenRenderWidgetHostView is called

* fix: specify default for current_device_scale_factor_
 2018-10-11 09:14:01 -04:00
Milan Burda
a9475f3590 feat: add workingDirectory option to shell.openExternal() (#15065) 
Allows passing `workingDirectory` to the underlying `ShellExecuteW` API on Windows.

the motivation is that by default `ShellExecute` would use the current working directory, which would get locked on Windows and can prevent autoUpdater from working correctly. We need to be able specify a different `workingDirectory` to prevent this situation.
 2018-10-10 22:46:54 +02:00
Electron Bot
539d6d20b7 Bump v4.0.0-nightly.20181010 2018-10-10 06:38:01 -07:00
Samuel Attard
5667c16767
Revert "Bump v4.0.0-nightly.20181010" 
This reverts commit c96847206e.
 2018-10-11 00:04:35 +11:00
Electron Bot
c96847206e Bump v4.0.0-nightly.20181010 2018-10-10 03:45:40 -07:00
Samuel Attard
d48c3ec8da
Revert "Bump v4.0.0-nightly.20181010" 
This reverts commit 8b3f915623.
 2018-10-10 21:43:32 +11:00
Electron Bot
8b3f915623 Bump v4.0.0-nightly.20181010 2018-10-10 02:22:24 -07:00
Samuel Attard
1b9600e510
Revert "Bump v4.0.0-nightly.20181010" 
This reverts commit 181195ee20.
 2018-10-10 20:21:17 +11:00
Electron Bot
181195ee20 Bump v4.0.0-nightly.20181010 2018-10-10 01:04:16 -07:00
Samuel Attard
b0068cecc8
Revert "Bump v4.0.0-nightly.20181009" 
This reverts commit 1b9a8bb854.
 2018-10-10 21:02:17 +13:00
Electron Bot
1b9a8bb854 Bump v4.0.0-nightly.20181009 2018-10-09 22:59:47 -07:00
Samuel Attard
f6dd201401 Revert "Bump v4.0.0-nightly.20181009" 
This reverts commit 32e041d917.
 2018-10-10 16:53:56 +11:00
Samuel Attard
5b43c249ce Revert "FIXME: temporary debugging to maybe diagnose netlog issue on mac" 
This reverts commit f8f318da93.
 2018-10-10 16:49:31 +11:00
Kevin Lynagh
af4cf1e969 fix: simpleFullscreen window should be on top of other OS X menu bars. (#14881) 
If an app has no menu bar (because `app.dock.hide()` has been called),
OS X will still render the menu bar of the previously-focused app.

This commit ensures simpleFullscreen windows will be drawn on top of
that menu bar by setting their level to NSPopUpMenuWindowLevel while
simpleFullscreen mode is active.

Ref: https://github.com/electron/electron/issues/11468
 2018-10-09 22:38:52 -07:00
Electron Bot
32e041d917 Bump v4.0.0-nightly.20181009 2018-10-09 21:34:34 -07:00
Milan Burda
5bd6de52e0 feat: add app.enableSandbox() (#14999) 2018-10-10 15:32:09 +11:00
Samuel Attard
cc0c6ad14a
Merge pull request #14972 from electron/chromium-upgrade/69 
feat: upgrade to Chromium 69.0.3497.106
 2018-10-10 15:29:21 +11:00
Shelley Vohr
dd43e92186
fix: simplify SetBackgroundColor 
The compositor_superview member of BridgedNativeWidgetMac has been removed so as a consequence there is only one layer on which we need to call setBackgroundColor
 2018-10-09 20:37:07 -07:00
Nitish Sakhawalkar
185fe6ced9 fix: Lifetime of auth_info_ in login handler (#15042) 2018-10-10 10:50:44 +11:00
Jeremy Apthorp
f8f318da93 FIXME: temporary debugging to maybe diagnose netlog issue on mac 2018-10-09 15:43:33 -07:00
Jeremy Apthorp
30850f491f fix: [mac] restore SetBackgroundColor functionality 2018-10-09 14:39:39 -07:00
Jeremy Apthorp
ee8a54d186 chore: update line reference in gpuinfo comment 2018-10-09 14:39:39 -07:00
deepak1556
363aafc25b fix: ensure webcontents is destroyed before its associated browser context. 2018-10-09 14:39:39 -07:00
Jeremy Apthorp
a71755e1b6 fix: crash in webRequest due to unsafe static_cast 
upstream was changed to wrap the network delegate

see https://chromium.googlesource.com/chromium/src/+/69.0.3497.106/services/network/network_context.cc#948
 2018-10-09 14:38:00 -07:00
Heilig Benedek
e548ed1a6e fix: remove conflicting header 2018-10-09 14:38:00 -07:00
Cheng Zhao
a6256c672a feat: getGPUInfo not longer supports 'complete' on macOS 
See https://chromium-review.googlesource.com/c/chromium/src/+/1208362
 2018-10-09 14:38:00 -07:00
Charles Kerr
f027e62b2a fix: only call NetworkService::SetUpHttpAuth once. 2018-10-09 14:38:00 -07:00
deepak1556
be719a1ec3 fix: Use the new isolate initialization api 
https://chromium-review.googlesource.com/c/chromium/src/+/1015020
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
56e26c27f2 clang-format 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
c920e453dc Stop using ResourceContext::GetHostResolver() 
https://chromium-review.googlesource.com/c/chromium/src/+/1135366
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
6df9c04270 Hook up HttpAuthHandlerFactory configuration to the network service 
https://chromium-review.googlesource.com/c/chromium/src/+/1089661
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
67611d69af Refactor of ServiceManagerContext 
https://chromium-review.googlesource.com/c/chromium/src/+/1093021
 2018-10-09 14:38:00 -07:00
Samuel Attard
80ffc26713 fixme: disable pepper flash 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
f5eaa97d9d migrate off QuitCurrent*Deprecated in browser.cc 
modelled after https://chromium-review.googlesource.com/c/chromium/src/+/1096475 and https://chromium-review.googlesource.com/c/chromium/src/+/1096475
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
8eb15f7554 Creates TaskScheduler and MessageLoop on main thread early 
https://chromium-review.googlesource.com/c/chromium/src/+/1072387
 2018-10-09 14:38:00 -07:00
Samuel Attard
d8e58dffe6 chore: update CHROME_VERSION_STRING 2018-10-09 14:38:00 -07:00
Samuel Attard
7589c56cea fix: intercept the isolate_holder's new isolate and register it with the node platform before initialization 
Chromium Change: https://chromium-review.googlesource.com/c/chromium/src/+/1015020
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
b57b342352 Remove PlatformAccelerator 
https://chromium-review.googlesource.com/c/chromium/src/+/1140211
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
7ce338e420 Handle deleting cookies with session-only policy in network service 
https://chromium-review.googlesource.com/c/chromium/src/+/1090035
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
120b6079a8 Move Net.HttpRequestCompletionErrorCodes to NetworkContext 
https://chromium-review.googlesource.com/c/chromium/src/+/1108083
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
42120b4a72 Remove SupportsOCSPStapling from CertVerifier and CertVerifyProc 
https://chromium-review.googlesource.com/c/chromium/src/+/1117034
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
b8774374a8 Fixed reporting for iframe ugprade-insecure-requests upgrades 
https://chromium-review.googlesource.com/c/chromium/src/+/1096360
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
34e54b93a4 Remove WebContentsUserData::kLocatorKey 
https://chromium-review.googlesource.com/c/chromium/src/+/1093015
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
2d46164ce0 Switch NetworkDelegate to OnceCallbacks 
https://chromium-review.googlesource.com/c/chromium/src/+/1085855
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
0955fa7bcf Remove unused RunMicrotasksObserver 
https://chromium-review.googlesource.com/c/chromium/src/+/1086889
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
9e110ec915 Remove content::SpeechRecognitionResult 
https://chromium-review.googlesource.com/c/chromium/src/+/1070587
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
56bc636706 Make content::PermissionManager a delegate of PermissionController 
https://chromium-review.googlesource.com/c/chromium/src/+/1111340
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
eef375a428 Port //services/device/geolocation to network::SimpleURLLoader 
https://chromium-review.googlesource.com/c/chromium/src/+/1119398
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
63176acde2 Collect NV12, YUY2, and BGRA overlay support information in GPUInfo 
https://chromium-review.googlesource.com/c/chromium/src/+/1121622
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
e3fef30789 Refactor RWH::RestartHang...Timeout... into a generic base::Closure 
https://chromium-review.googlesource.com/c/chromium/src/+/1096362
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
4570330c7b Rename WebContentsDelegate methods 
https://chromium-review.googlesource.com/c/chromium/src/+/1085427
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
af03e4a962 Rename content::PermissionManager into content::PermissionControllerDelegate 
https://chromium-review.googlesource.com/c/chromium/src/+/1136858
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
7861f75a3e media: Refactor KeySystemSupport 
https://chromium-review.googlesource.com/c/chromium/src/+/1102836
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
9c2cd5a84c Support add/overwrite redirect request headers in NavigationURLLoader 
https://chromium-review.googlesource.com/c/chromium/src/+/1072643
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
18128a1582 Use CompletionOnceCallback 
several CLs, e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1092933
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
ec1bd5375a FIXME: Delete RenderWidgetHostViewMac::AcceleratedWidgetGetNSView 
https://chromium-review.googlesource.com/c/chromium/src/+/1121957

https://chromium-review.googlesource.com/c/chromium/src/+/1037145
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
2a3a845262 Change CreateWebUIControllerForURL() to return a unique_ptr 
https://chromium-review.googlesource.com/c/chromium/src/+/1087627
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
c576d442fd Rename base::Timer to base::TimerBase 
https://chromium-review.googlesource.com/c/chromium/src/+/1124200
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
a7c687f160 ChildProcessSecurityPolicy: only use granted schemes for requests 
https://chromium-review.googlesource.com/c/chromium/src/+/1108485
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
4f540fe52a Replace DupCryptoBuffer with bssl::UpRef 
https://chromium-review.googlesource.com/c/chromium/src/+/1128194
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
90aa277c26 Migrate MediaResponseCallback to OnceCallback 
https://chromium-review.googlesource.com/c/chromium/src/+/1093052
 2018-10-09 14:38:00 -07:00
Jeremy Apthorp
3ded109c2e stop using x-devtools-emulate-network-conditions-client-id header 
https://chromium-review.googlesource.com/c/chromium/src/+/1086949
 2018-10-09 14:38:00 -07:00
Troy
d678d9ee75 fix: Check minSize constraints before resizing (#14931) 
* Inital setSize check

* Only resize if above minimum size constraints

* lint

* Resize to min if size is changed

* Remove unneeded if statement

* chore: remove trailing whitespace

* Add note about setSize method in docs
 2018-10-09 12:08:15 -05:00
Charles Kerr
05f4860889
fix: power observer dbus crash (#15030) 
* fix: check dbus response for nullptr before using

* chore: use BindOnce for ProxyObject::CallMethod cb

* chore: comment out name of unused argument

* fix: re-enable and fix linux power monitor tests

* fix: change tyop from code comments

* refactor: don't keep unnecessary dbus pointer

* chore: remove the 'TODO: fix this' spec comment
 2018-10-09 00:32:19 -05:00
Milan Burda
b50f86ef43 refactor: use separate ipc-renderer-internal / ipc-main-internal APIs for Electron internals (#13940) 2018-10-07 00:48:00 +13:00
Electron Bot
f7122610cc Bump v4.0.0-nightly.20181006 2018-10-06 02:43:36 -07:00
Samuel Attard
59681f989f
Revert "Bump v4.0.0-nightly.20181006" 
This reverts commit c74a3b82d7.
 2018-10-06 22:21:12 +13:00
Electron Bot
c74a3b82d7 Bump v4.0.0-nightly.20181006 2018-10-06 00:13:06 -07:00
Samuel Attard
251a3c712b
Revert "Bump v4.0.0-nightly.20181005" 
This reverts commit 2a2ec7700e.
 2018-10-06 20:10:21 +13:00
Electron Bot
2a2ec7700e Bump v4.0.0-nightly.20181005 2018-10-05 21:09:00 -07:00
Robo
6e5dd735f6 refactor: enable weak ptr unwrap sequence dcheck (#14816) 
* refactor: enable weak ptr unwrap sequence dcheck

* spec: remove WeakPtrDeathTest.* from disabled list
 2018-10-05 15:29:57 -05:00
Robo
2700eaca1e build: remove //chrome/browser/icon_loader source copies (#14955) 
* build: remove //chrome/browser/icon_loader source copies

* chore: add DCHECK to ensure IconManager is accessed from UI thread
 2018-10-05 14:12:53 -05:00
Shelley Vohr
71058fd9a3
fix: re-enable osr following m68 upgrade (#14973) 2018-10-05 11:03:35 -07:00
Charles Kerr
859567983a
chore: run clang-format to clear linter for #14977 (#14990) 2018-10-05 10:38:27 -05:00