Nitish Sakhawalkar
e6952e2a16
fix: correctly destroy spellcheck client ( #16448 )
...
* fix: Destroy spellcheck client
* Address review comments
2019-01-24 08:18:54 -08:00
Electron Bot
90151879cc
Bump v6.0.0-nightly.20190123
2019-01-23 11:49:22 -08:00
Milan Burda
cc90919384
refactor: pass internal flag via IPC message struct for consistency ( #16490 )
2019-01-23 08:24:57 -08:00
Samuel Attard
f3e30c7ae3
Merge remote-tracking branch 'origin/chromium-upgrade/72'
2019-01-22 12:01:18 -08:00
Samuel Attard
0b85fb7ea2
Revert "feat: upgrade to Chromium 72.0.3626.52 ( #16334 )"
...
This reverts commit 1918e76913
.
2019-01-22 12:01:04 -08:00
Samuel Attard
58a6fe13d6
feat: preloads and nodeIntegration in iframes ( #16425 )
...
* feat: add support for node / preloads in subframes
This feature has delibrately been built / implemented in such a way
that it has minimum impact on existing apps / code-paths.
Without enabling the new "nodeSupportInSubFrames" option basically none of this
new code will be hit.
The things that I believe need extra scrutiny are:
* Introduction of `event.reply` for IPC events and usage of `event.reply` instead of `event.sender.send()`
* Usage of `node::FreeEnvironment(env)` when the new option is enabled in order to avoid memory leaks. I have tested this quite a bit and haven't managed to cause a crash but it is still feature flagged behind the "nodeSupportInSubFrames" flag to avoid potential impact.
Closes #10569
Closes #10401
Closes #11868
Closes #12505
Closes #14035
* feat: add support preloads in subframes for sandboxed renderers
* spec: add tests for new nodeSupportInSubFrames option
* spec: fix specs for .reply and ._replyInternal for internal messages
* chore: revert change to use flag instead of environment set size
* chore: clean up subframe impl
* chore: apply suggestions from code review
Co-Authored-By: MarshallOfSound <samuel.r.attard@gmail.com>
* chore: clean up reply usage
* chore: fix TS docs generation
* chore: cleanup after rebase
* chore: rename wrap to add in event fns
2019-01-22 11:24:46 -08:00
Jeremy Apthorp
92b9525cfd
feat: enable mixed-sandbox mode by default ( #15894 )
2019-01-22 10:44:28 -08:00
Jeremy Apthorp
1918e76913
feat: upgrade to Chromium 72.0.3626.52 ( #16334 )
2019-01-22 10:39:32 -08:00
Jeremy Apthorp
6d4480ea6b
feat: allow setting autoplayPolicy in webPreferences ( #16396 )
2019-01-22 10:32:06 -08:00
Jeremy Apthorp
f115376595
fix: remove pretarget handler before window destruction
2019-01-22 10:32:06 -08:00
Cheng Zhao
03d499bf34
fix: detach webview instead of destroying it
...
Chromium no longer cleans up everything when a guest webcontents is
destroyed, we have to force detaching it and let Chromium destroy everything.
2019-01-22 10:32:06 -08:00
Jeremy Apthorp
5e043812ef
fix HandleKeyboardEvent merge failure
2019-01-22 10:32:06 -08:00
Jeremy Apthorp
7764ca7209
add missing include for l10n_util.h on win
2019-01-22 10:32:06 -08:00
Jeremy Apthorp
212d858bf4
set autoplay policy to no-user-gesture-required by default
2019-01-22 10:32:06 -08:00
Jeremy Apthorp
55d5b02f87
include glib.h in atom_main_delegate
...
it was complaining about 'undeclared identifier 'TRUE''
2019-01-22 10:32:06 -08:00
deepak1556
826f1cb90c
Move the base/sys_info* files to base/system/
...
https://chromium-review.googlesource.com/c/chromium/src/+/1327441
2019-01-22 10:32:05 -08:00
deepak1556
ed5a865efb
Update GetAccessibleName() in view::ImageView and view::Button
...
https://chromium-review.googlesource.com/c/chromium/src/+/1256308
2019-01-22 10:32:05 -08:00
deepak1556
90b6d13714
Remove menu_marker from MenuButton.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1324375
2019-01-22 10:32:05 -08:00
deepak1556
85333a5974
Move ViewsDelegate::NotifyAccessibilityEvent to an observer pattern
...
https://chromium-review.googlesource.com/c/chromium/src/+/1352265
2019-01-22 10:32:05 -08:00
deepak1556
5f941c5180
Remove CR_DEFINE_STATIC_LOCAL
...
https://bugs.chromium.org/p/chromium/issues/detail?id=893317
2019-01-22 10:32:05 -08:00
deepak1556
06a5ade3c6
fixup! Use strong ownership for attached inner WebContents
2019-01-22 10:32:05 -08:00
deepak1556
374406375b
Add interface and Mac implementation for responsiveness::NativeEventObserver.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1157235/
2019-01-22 10:32:05 -08:00
deepak1556
4089620729
fix: Initialize resource bundle for the browser process earlier
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
94246d428b
resource_coordinator_parts stub in BrowserProcessImpl
...
https://chromium-review.googlesource.com/c/1324134
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
3b88dd6ef7
tts was migrated to content
...
https://chromium-review.googlesource.com/c/1341154
https://chromium-review.googlesource.com/c/1351806
https://chromium-review.googlesource.com/c/1352055
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
2cbf3080d0
Make webkitRelativePath interoperable
...
https://chromium-review.googlesource.com/c/1325579
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
d0621db8fd
Remove ResourceContext::GetRequestContext since it's no longer used.
...
https://chromium-review.googlesource.com/c/1352035
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
6f9ff39728
CORS -> Cors
...
https://chromium-review.googlesource.com/c/1333018
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
a64cf5514f
move pdf_compositor off ServiceContext/ServiceTest
...
https://chromium-review.googlesource.com/c/1343506
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
93fbb6c092
remove name parameter from AllowIndexedDB
...
https://chromium-review.googlesource.com/c/1306914
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
600c3f2c2f
StoragePartition::ClearData no longer takes an OriginMatcher
...
https://chromium-review.googlesource.com/c/1162172
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
deff96a1b0
NativeWidgetMac::CreateNSWindow params changed
...
https://chromium-review.googlesource.com/c/1295251
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
b03daaebe4
ChildProcessData.{GetHandle() => GetProcess().GetHandle()}
...
https://chromium-review.googlesource.com/c/1298345
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
4ddd337a64
CurrentProcessInfo::CreationTime -> Process::Current().CreationTime()
...
https://chromium-review.googlesource.com/c/1280642
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
a64a0fa88e
remove ipc/struct_destructor_macros.h
...
https://chromium-review.googlesource.com/c/1261082
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
c0cf065c1a
REVIEW: Use strong ownership for attached inner WebContents
...
https://chromium-review.googlesource.com/c/1301843
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
96b2623887
replace base::AssertBlockingAllowed with base::ScopedBlockingCall
...
https://chromium-review.googlesource.com/c/1278540
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
e0d277e667
CopyNSImage was removed
...
https://chromium-review.googlesource.com/c/1333876
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
485bbd9ccb
ContentRulesetService -> RulesetService
...
https://chromium-review.googlesource.com/c/1294299
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
d228bdfb9e
gfx::NativeView is no longer NSView on mac
...
https://chromium-review.googlesource.com/c/1270343
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
70887ae21a
extra parameters to BrowserClient::HandleExternalProtocol
...
https://chromium-review.googlesource.com/c/1318976
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
96f9611cf4
GetCachePath replaced with GetGeneratedCodeCacheSettings
...
https://chromium-review.googlesource.com/c/1301973
https://chromium-review.googlesource.com/c/chromium/src/+/1213093
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
ef80cc3d56
base/sys_info.h -> base/system/sys_info.h
...
https://chromium-review.googlesource.com/c/1327441
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
0d9de7deaf
blink::WebReferrerPolicy -> network::mojom::ReferrerPolicy
...
https://chromium-review.googlesource.com/c/chromium/src/+/1212345
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
96ca070c3a
less const in WebContents
...
https://chromium-review.googlesource.com/c/1349466
2019-01-22 10:32:03 -08:00
Jeremy Apthorp
8948e27ced
ScopedNestableTaskAllower in MessageLoopCurrent
...
https://chromium-review.googlesource.com/c/chromium/src/+/1020288
2019-01-22 10:32:03 -08:00
Jeremy Apthorp
30e5e993c1
HandleKeyboardEvent returns bool
...
https://chromium-review.googlesource.com/c/chromium/src/+/1262404
2019-01-22 10:32:03 -08:00
Jeremy Apthorp
fd7b49b32b
remove OnAreExperimentalCookieFeaturesEnabled
...
https://chromium-review.googlesource.com/c/1287209
2019-01-22 10:32:03 -08:00
Jeremy Apthorp
d36a6de25c
OnCanEnablePrivacyMode -> OnForcePrivacyMode
...
https://chromium-review.googlesource.com/c/1343051
2019-01-22 10:32:03 -08:00
Jeremy Apthorp
d01db5a656
migrate to non-deprecated v8 functions
...
https://bugs.chromium.org/p/v8/issues/detail?id=8238
https://bugs.chromium.org/p/v8/issues/detail?id=7295
https://chromium-review.googlesource.com/c/v8/v8/+/1352273
2019-01-22 10:32:03 -08:00