Samuel Attard
d2707315e6
s/global/session
2017-12-05 11:35:53 +09:00
Samuel Attard
0ddd078aaf
Add ability to set global preload scripts
2017-12-05 11:35:27 +09:00
Felix Rieseberg
9646f0c99a
🔧 Sprinkle some ES6 across the file
2017-12-01 17:18:57 -08:00
Felix Rieseberg
c5abe96b39
🔧 Hide subprocess window
2017-12-01 17:18:37 -08:00
Cheng Zhao
59476f0b30
Create webContents for webview even when src is not set
2017-12-01 10:35:23 +09:00
Cheng Zhao
b161a4f515
Merge pull request #11166 from sethlu/openrecent
...
feat: Recent documents menu item
2017-11-28 10:55:14 +09:00
Zhuo Lu
dcdc3621ac
Rename roles
2017-11-27 17:26:22 +09:00
Zhuo Lu
5d44dbaf54
Redesign recent documents role API
...
- For more flexibility in designing the recent documents menu, now there can be one menu item (known issue: you may specify more but AppKit doens't display more than one) in the submenu list, rather than separating the labels with a tab.
- Also added is the role `clearrecent` that can be given to a menu item that can clear the recent documents.
2017-11-27 17:26:22 +09:00
Zhuo Lu
828d233f2a
Rollback duplicated feature
2017-11-27 17:26:22 +09:00
Zhuo Lu
0b9cea334f
Specify "Clear Menu" through label option
...
Like a bit of a hack right now, conforming to the existing menu item definition
2017-11-27 17:26:22 +09:00
Zhuo Lu
4da2eb9366
Introduce openrecent role
...
- Does not yet accept any options except label--"Clear Menu" can't be modified through exposed node API
- If `openrecent` is present across multiple menu items, the last seen will be visible in the main menu due to that it is designed to behave like a singleton
2017-11-27 17:26:22 +09:00
Zhuo Lu
f0bff74995
Add "Open Recent" submenu to default
2017-11-27 17:26:22 +09:00
Cheng Zhao
1c0ea0286e
Merge pull request #11235 from electron/standard-10
...
infra: Upgrade to StandardJS 10
2017-11-27 15:42:52 +09:00
Aleksei Kuzmin
465f9009ff
Update stack string parsing in the CallbacksRegistry
...
Fixes the "ipc module > remote listeners
> detaches listeners subscribed to destroyed renderers, and shows a warning"
test.
2017-11-24 10:58:53 +09:00
Birunthan Mohanathas
4e859b4718
Remove "async" option from menu.popup()
...
All menus are async now. See "Cleanup MenuRunner API"
https://codereview.chromium.org/2790773002
2017-11-24 10:58:17 +09:00
Felix Rieseberg
f7d6e3fa7b
🔧 Disable standard/no-callback-literal where necessary
2017-11-23 13:53:03 -08:00
Felix Rieseberg
f81bfb7b86
🔧 Fix style issues
2017-11-23 13:42:48 -08:00
Felix Rieseberg
451a44c4b5
🔧 Don’t use deprecated new Buffer()
2017-11-23 13:41:47 -08:00
Charles Kerr
9c217fc6c7
Merge pull request #11224 from electron/browser-view-window
...
feature: Add `BrowserWindow.fromBrowserView()`
2017-11-23 14:41:36 +01:00
Felix Rieseberg
037f76c47b
🐛 Ooops, fix that
2017-11-22 17:07:57 -08:00
Felix Rieseberg
4d18cbe728
🔧 BrowserView.fromWebContents()
2017-11-22 16:59:00 -08:00
Felix Rieseberg
7630ac6e90
🔧 Return null if not found
2017-11-22 15:48:11 -08:00
Felix Rieseberg
8c5aad8b17
🔧 Add BrowserWindow.fromBrowserView()
2017-11-22 14:36:54 -08:00
Felix Rieseberg
05bae0b4c4
🔧 Util is no longer used here
2017-11-20 09:52:13 -08:00
Felix Rieseberg
b029c088db
🔧 Bonus ;
2017-11-20 09:48:33 -08:00
Felix Rieseberg
b8b3b441a7
🔧 util._extend is deprecated, too
2017-11-20 09:46:02 -08:00
Felix Rieseberg
71b8eaf085
🔧 Don’t use deprecated util.is* methods
2017-11-20 09:40:47 -08:00
Felix Rieseberg
c9f2080e4b
🔧 fs.readFile: options are optional
2017-11-20 08:20:20 -08:00
Charles Kerr
5eb00e45aa
Merge pull request #11158 from electron/execute-errors
...
fix: Pass on errors thrown in `executeJavaScript`
2017-11-20 09:14:05 -06:00
Charles Kerr
4c04f1c7ed
Merge pull request #11117 from electron/add_deprecations_spec
...
Add to deprecations spec
2017-11-20 09:07:06 -06:00
Shelley Vohr
7904be8763
comment out unused methods
2017-11-20 15:12:34 +01:00
Ronald Eddy
14c6e78147
Update electron.atom.io -> electronjs.org
...
Update electron.atom.io -> electronjs.org to reduce redirects and speed navigation.
2017-11-19 04:01:33 -08:00
Felix Rieseberg
5b18bea7e3
🔧 Alex has good ideas
2017-11-18 10:59:09 -08:00
Felix Rieseberg
cf7e9df3a0
🔧 Appease the linter
2017-11-18 01:02:09 -08:00
Felix Rieseberg
9a2d103e7f
:thinking_face: What if we made it an Error again?
2017-11-18 00:51:14 -08:00
Felix Rieseberg
1dea186a6e
:thinking_face: What if you could return an Error?
2017-11-18 00:50:53 -08:00
Shelley Vohr
aaae1bb176
Merge pull request #11124 from electron/expose-desktop-capturer
...
Expose desktopCapturer in sandbox mode.
2017-11-16 17:36:39 -05:00
Thiago de Arruda
be0e3d9555
Expose desktopCapturer in sandbox mode.
2017-11-16 16:57:29 -03:00
Shelley Vohr
933c7330a5
changes from review
2017-11-16 13:39:07 -05:00
Shelley Vohr
75a117e4e2
edit empty function for platform consistency
2017-11-16 13:27:08 -05:00
Shelley Vohr
f5c04c7037
fix includes
2017-11-16 13:27:08 -05:00
Shelley Vohr
e5983eacd6
add callbacks registry spec
2017-11-16 13:27:07 -05:00
Shelley Vohr
dc410efa36
rename and fix assoc. test
2017-11-14 14:56:16 -05:00
Shelley Vohr
99d35f7786
a few more updates to tests
2017-11-14 13:33:38 -05:00
Shelley Vohr
d05a1f8053
first pass at deprecation spec updates
2017-11-13 20:21:57 -05:00
Heilig Benedek
cafb9477b0
lint fix
2017-11-13 15:46:46 +09:00
Heilig Benedek
13b86598e8
don't show osr dummy window when dialog is shown on mac
2017-11-13 15:46:46 +09:00
Felix Rieseberg
d475eaf011
🔧 One commit per character is now hot
2017-11-07 19:44:24 -08:00
Felix Rieseberg
3dcde82485
🔧 Make this easier to read
2017-11-07 18:26:10 -08:00
Felix Rieseberg
1454783450
🔧 Check menu for being falsy
2017-11-07 13:29:14 -08:00
Aleksei Kuzmin
bd766067ac
Remove unused deprecate var to make linter happy
2017-11-04 07:52:47 +03:00
Aleksei Kuzmin
b3a1fc65e5
Disable deprecation warning of crashReported.setExtraParameter()
...
It caused a couple of Crash Reported tests to timeout on Mac.
Task to enable it back:
https://github.com/electron/electron/issues/11012
2017-11-04 07:48:39 +03:00
Shelley Vohr
8736a41cfb
Merge pull request #10909 from electron/update_remote
...
Simplify and remove excess code from remote module
2017-11-03 09:16:28 -04:00
Shelley Vohr
803fa35484
fix null value check
2017-11-03 08:47:21 -04:00
Shelley Vohr
2b2c7d7f9f
fix object serialization test issue
2017-11-02 21:29:17 -04:00
Shelley Vohr
41fa61b446
Merge pull request #10995 from electron/initialize-retroactive-event-emitters
...
singletons that are retroactively turned into EventEmitters should ca…
2017-11-02 21:22:27 -04:00
Shelley Vohr
5c318932c2
add some structural changes
2017-11-02 21:07:40 -04:00
Charles Kerr
1c09dede1a
singletons that are retroactively turned into EventEmitters should call the EventEmitter ctor
2017-11-01 23:05:27 -05:00
Shelley Vohr
65f125a245
wrap deprecation warning
2017-11-01 23:27:20 -04:00
Shelley Vohr
24acd74d15
update deprecation warning
2017-11-01 22:23:33 -04:00
Shelley Vohr
3af83f1c97
add new method and mark setExtraParameter for deprecation
2017-11-01 21:57:43 -04:00
Shelley Vohr
93df164485
add const and other small edits
2017-10-31 23:42:25 -04:00
Shelley Vohr
3136f833a5
fixes and updates to GetParameters
2017-10-31 13:51:44 -04:00
Shelley Vohr
a9c13359dc
first attempt to add new GetParameters method to CrashReporter
2017-10-31 13:06:54 -04:00
Shelley Vohr
cb78e4875b
fix two failing tests
2017-10-30 23:15:57 -04:00
Shelley Vohr
603060f051
add new tests
2017-10-30 22:51:22 -04:00
John Kleinschmidt
beb06c0787
Merge pull request #10537 from qazbnm456/improve-content_scripts.css
...
[Security] Use textContent instead innerHTML to remediate DOM based XSS
2017-10-26 11:51:43 -04:00
Shelley Vohr
bb04b22ec8
Merge pull request #10888 from electron/menu_refactor
...
refactor menu.js to bring it up to readability and es6 standards
2017-10-26 00:31:47 -04:00
Shelley Vohr
5f6f117bad
changes from review
2017-10-25 23:41:11 -04:00
Cheng Zhao
4db34ff092
Merge pull request #10711 from yuya-oc/did-attach-webview
...
Add did-attach-webview event
2017-10-26 10:55:50 +09:00
Shelley Vohr
d4880b135a
revert ipc lookup table
2017-10-25 15:36:16 -04:00
Shelley Vohr
bccaf56200
remove common sense comments
2017-10-25 12:23:41 -04:00
Shelley Vohr
ffd43c1886
remove quotes and const replaces
2017-10-25 10:17:41 -04:00
Shelley Vohr
c0f2a7b44a
fix standard issues
2017-10-25 09:56:02 -04:00
Shelley Vohr
f129622446
clean up remote
2017-10-25 09:51:21 -04:00
Shelley Vohr
7593bec687
update reviewed items
2017-10-24 19:36:06 -04:00
Shelley Vohr
e8935232b1
clean falsy statements
2017-10-24 18:52:12 -04:00
Shelley Vohr
98df153750
convert to map and remove shift param
2017-10-24 15:47:09 -04:00
Shelley Vohr
491a00fd84
clean main process desktop_capturer
2017-10-24 12:49:37 -04:00
Shelley Vohr
b58ceae69c
appease linter gods
2017-10-24 12:28:15 -04:00
Shelley Vohr
43e118fe45
update desktop capturer and remove unnessary vars
2017-10-24 12:01:51 -04:00
Shelley Vohr
75f32afcd5
clean up excess code from generateGroupId
2017-10-24 00:24:57 -04:00
Shelley Vohr
f93121b226
don't reassign parameters in Menu.prototype.popup
2017-10-24 00:07:39 -04:00
Shelley Vohr
b1e707d535
abstract out switch case from Menu.prototype.insert
2017-10-23 23:46:39 -04:00
Shelley Vohr
7c0f7329d9
appease the linter overlords
2017-10-23 22:35:42 -04:00
Shelley Vohr
508b614769
remove excess code in delegate
2017-10-23 22:33:23 -04:00
Shelley Vohr
9b364d5be3
refactor menuWillShow
2017-10-23 22:22:39 -04:00
Shelley Vohr
9038987e1d
significant cleanup; all tests still passing
2017-10-23 20:04:22 -04:00
Shelley Vohr
3fc5d51a96
clean up delegate
2017-10-23 18:35:16 -04:00
Shelley Vohr
577c0042b0
update to ES6
2017-10-23 14:47:47 -04:00
Shelley Vohr
87802b2c17
initial port of things into a Menu class
2017-10-23 12:11:59 -04:00
Shelley Vohr
61a93c711c
clean up popup
2017-10-23 00:47:02 -04:00
Shelley Vohr
f9c3123f5f
clean up menuWillShow
2017-10-23 00:16:35 -04:00
Shelley Vohr
1cd53768ab
clean up indexToInsertByPosition
2017-10-22 23:57:23 -04:00
Shelley Vohr
b7ebee985b
refactor indexOfItemById
2017-10-22 23:51:33 -04:00
Felix Rieseberg
2bd8877be3
🔧 String comparison
2017-10-07 08:26:32 -07:00
Yuya Ochiai
6326c6727e
Add did-attach-webview event
2017-10-07 22:52:20 +09:00
Felix Rieseberg
63749e281d
🔧 Linters gotta lint
2017-10-06 13:36:54 -07:00
Felix Rieseberg
11ac780caf
🔧 Add security warning
2017-10-06 13:02:54 -07:00
Birunthan Mohanathas
945fef8a5a
Merge pull request #10483 from jublonet/fix-double-downloads
...
Use Squirrel.Windows --checkForUpdate
2017-09-27 20:26:24 +03:00
Shelley Vohr
c932871bb1
change default to null
2017-09-26 20:35:14 -04:00
Shelley Vohr
f49f7d65a5
remove check on items instance
2017-09-26 14:38:34 -04:00
Shelley Vohr
afe033a6e1
stray semicolon fml
2017-09-26 12:10:16 -04:00
Shelley Vohr
4753ada7a9
rewrite method with only id parameter
2017-09-26 12:05:45 -04:00
Shelley Vohr
5217718d7b
conform to linter standard
2017-09-26 09:50:47 -04:00
Shelley Vohr
ea42851c9b
add first pass at getMenuItemById
2017-09-26 09:47:13 -04:00
Boik
16499358b3
fix lint
2017-09-17 14:09:12 +08:00
Boik
d86724f17a
code improvement
2017-09-17 13:56:22 +08:00
Boik
26e6f2c46c
use textContent instead innerHTML to remediateDOM based XSS vulnerbilities
2017-09-17 11:27:03 +08:00
Alexandre Lachèze
e1a232e7c8
Add support for css in content_scripts
2017-09-14 17:23:33 +09:00
Cheng Zhao
6ebd00267e
Merge pull request #10355 from owais/master
...
Add support for indicators in Ubuntu Gnome Session
2017-09-12 15:22:31 +09:00
J.M
6442e6b5e8
Use Squirrel.Windows --checkForUpdate
...
Avoid downloading updates twice. Fix #5057 .
2017-09-11 00:54:08 +02:00
Owais Lone
dc43dc2a13
Add support for indicators in Ubuntu Gnome Session
...
Ubuntu is switching to Gnome in 17.10 but it's not going to be the stock Gnome session. It's going to support the existing Unity APIs. Support has already landed for application indicators and likely other APIs (Launcher,etc) will be supported soon. The Ubuntu Gnome session will have `XDG_CURRENT_DESKTOP=ubuntu:GNOME` environment variable.
Ref: https://didrocks.fr/2017/08/23/ubuntu-gnome-shell-in-artful-day-7/
2017-08-25 23:25:08 +05:30
sungpark
eca7ff986c
add webFrame to sandboxed renderer
2017-08-23 10:52:02 -07:00
Cheng Zhao
d233fc044a
Pass dpiVertical and dpiHorizontal to print settings
2017-08-22 13:54:49 +09:00
Samuel Attard
15db4ee450
Merge pull request #10275 from electron/windowclose-exception
...
Fixing uncaught exception on window close
2017-08-19 13:58:55 +10:00
Hari Juturu
340431750b
Removing try/catch
2017-08-17 10:56:37 -07:00
Cheng Zhao
f6792c0232
Merge pull request #10264 from electron/fix-sandbox-crash-on-background-tab
...
Fix sandbox crash when opening a background tab
2017-08-17 15:57:29 +09:00
Hari Juturu
9120774c00
Fixing uncaught exception on window close
2017-08-15 14:59:48 -07:00
Kevin Sawicki
34fff57646
Grant the devtools access to the extension origins
2017-08-15 16:19:21 +03:00
Thiago de Arruda
1709b8e39d
Fix sandbox crash when opening a background tab
...
When a link is clicked with the middle mouse button, chrome opens a window with
"background-tab" disposition. This is not currently handled in sandbox mode,
causing an api::WebContents to leak leading to eventual crash(since it has no
wrapper).
Also fix the event handler for "-add-new-contents" by having it call
`event.preventDefault()` when the window creation should be cancelled.
2017-08-15 09:55:39 -03:00
John Kleinschmidt
72d2e176dd
Merge pull request #10160 from liusy182/liusy182-10128-asar
...
Return empty string when fs.readFile with 'utf8' option from asar file
2017-08-07 21:42:15 -04:00
John Kleinschmidt
ccdff72ee4
Merge pull request #9918 from alexstrat/add-extensions-loading-api
...
Introduce Chrome extensions management APIs independent of Dev Tools Extensions
2017-08-07 20:06:22 -04:00
Siyuan Liu
f56abac7a8
fix linting error
2017-08-01 17:52:48 +08:00
Siyuan Liu
5a48c1feed
fixes 10128
2017-07-31 09:32:45 +08:00
Samuel Attard
59e85c0f33
Fix stupid or check in scrubber defaults
2017-07-27 17:49:05 +10:00
Cheng Zhao
bd87982b5c
Merge pull request #10075 from alexstrat/fix/fix-content_scripts-match
...
Fix content scripts matches
2017-07-24 15:27:55 +09:00
Cheng Zhao
25f168cecb
Merge pull request #9951 from alexstrat/fix-chrome-storage
...
Fix chrome storage access scope
2017-07-24 14:01:15 +09:00
Alexandre Lachèze
a2ba4e0a6a
fix content scripts matches
2017-07-20 20:01:49 +02:00
Alexandre Lachèze
498f344e2e
Correct mkdir
2017-07-20 19:50:55 +02:00
Kevin Sawicki
959231f766
Merge pull request #9834 from shubham2892/input-type-file-treating-packaged-app-as-directory
...
Fix treat packaged app as directory
2017-07-18 10:21:07 -07:00
Shubham
b25a1d10a2
🍎 Add treatPackageasDirectory as an option
2017-07-18 10:13:25 -07:00
Kevin Sawicki
fc53ac3d38
Always register closed listeners
2017-07-17 11:55:16 -07:00
Kevin Sawicki
86b1deedfa
Inherit enabled-sandbox in opened windows
2017-07-17 11:55:15 -07:00
Kevin Sawicki
61167ca296
Inherit nativeWindowOpen from parent window
2017-07-17 11:55:15 -07:00
Kevin Sawicki
553021bc9c
Only assign opener when not using nativeWindowOpen
2017-07-17 11:55:15 -07:00
Alexandre Lachèze
ec8407c65d
Recursively mkdir the parent directories
2017-07-11 00:56:45 +02:00
Alexandre Lachèze
c85f3cbd2c
Change storage implementation to async
2017-07-11 00:35:53 +02:00
Alexandre Lachèze
9aac8967aa
👕
2017-07-10 23:56:44 +02:00
Alexandre Lachèze
969c74b886
Use es6 string templating
2017-07-10 23:50:59 +02:00
Alexandre Lachèze
73e8769b1f
content_scripts[].matches use the URL without hash part
2017-07-07 04:14:36 +02:00
Alexandre Lachèze
ec10338364
Per-extension storage
2017-07-07 03:13:19 +02:00
Alexandre Lachèze
d2002ff3fc
Use a file as Chrome Storage rather than localStorage
2017-07-07 03:06:53 +02:00
Alexandre Lachèze
03ec155ecb
Oops
2017-07-05 17:34:04 +02:00
Alexandre Lachèze
cba53604eb
Introduce extensions management APIs indépendant of Dev Tools Extensions
...
- introduce API BrowserWindow#[add,remove,get]Extension
- make [add,remove, get]DevToolsExtension use newly introduced API
- make the app persist only the extensions added via
#addDevToolsExtension
2017-07-03 20:01:08 +02:00
Kevin Sawicki
2cd49f3036
Merge pull request #9644 from electron/webview-sandbox
...
Enable sandbox on webview
2017-06-28 10:10:25 -07:00
Kevin Sawicki
14178d9826
Expose argv to preload process object
2017-06-26 13:52:19 -07:00
Cheng Zhao
5fbcb6ef4e
Merge pull request #9396 from drulm/printtopdf-custom-pagesize
...
Add Math.ceil to pageSize.height and pageSize.width to printToPDF() o…
2017-06-26 14:48:44 +09:00
Kevin Sawicki
f9f697298d
Add FIXME link to #6828
2017-06-14 14:12:51 -07:00
Kevin Sawicki
626a1550dc
Send cached visibility state when guest DOM is ready
2017-06-14 14:11:38 -07:00
Boik
2e9ace6f59
Use Buffer.from instead of deprecated new Buffer
...
Use Buffer.from instead of deprecated new Buffer.
2017-06-12 16:57:42 +08:00
Vanessa Yuen
43271c162a
use includes instead of indexOf
2017-06-09 14:45:47 -07:00
Matthias Niess
254dcdaa45
add tray icon workaround for newer Ubuntu releases ( fixes #9046 )
2017-06-09 15:22:18 +02:00
Birunthan Mohanathas
7d2226e05e
Let Chromium manage document.visibilityState and document.hidden
...
Chromium already includes the necessary plumbing to manage the
visibility properties and `visibilitychange` event so this gets rid of
most of our custom logic for `BrowserWindow` and `BrowserView`.
Note that `webview` remains unchanged and is still affected by the issues
listed below.
User facing changes:
- The `document` visibility properties and `visibilitychange` event are
now also updated/fired in response to occlusion changes on macOS. In
other words, `document.visibilityState` will now be `hidden` on macOS
if the window is occluded by another window.
- Previously, `visibilitychange` was also fired by *both* Electron and
Chromium in some cases (e.g. when hiding the window). Now it is only
fired by Chromium so you no longer get duplicate events.
- The visiblity state of `BrowserWindow`s created with `{ show: false }`
is now initially `visible` until the window is shown and hidden.
- The visibility state of `BrowserWindow`s with `backgroundThrottling`
disabled is now permanently `visible`.
This should also fix #6860 (but not for `webview`).
2017-06-06 15:16:01 -07:00
Kevin Sawicki
53b6ee0e3f
Merge pull request #9468 from tonyganch/9296-history-state
...
Remove page url check during `history.pushState`
2017-06-05 14:47:49 -07:00
Cheng Zhao
e82af41591
Merge pull request #9269 from electron/main-notifications
...
Notifications from the main process
2017-05-31 17:21:05 +09:00
Samuel Attard
3938373ecb
Fix linting errors and add isSupported
2017-05-30 20:27:24 +10:00
Kevin Sawicki
e735aa7dee
web-preferences -> webPreferences
2017-05-26 10:10:36 -07:00
Kevin Sawicki
9ac2cf0d44
Add comment about disablePopups setting
2017-05-26 10:10:36 -07:00
Kevin Sawicki
dbd240a7cb
Return null from native window.open when allowpopups is unset
2017-05-26 10:10:36 -07:00
Kevin Sawicki
4e9efebf47
🎨
2017-05-26 10:10:36 -07:00
Kevin Sawicki
47759a01de
Only forward events when nativeWindowOpen is set
2017-05-26 10:10:36 -07:00
Kevin Sawicki
7baf472c0f
Implement BrowserPluginGuestDelegate::CreateNewGuestWindow for nativeWindowOpen
2017-05-26 10:10:36 -07:00
Tony Ganch
3a9b035d36
Remove page url check in history.pushState
...
Current implementation of NavigationController does not allow using
`history.pushState()` if page url is not changed.
It worked by mistake in versions < 1.3.6 and got visible after fix 180a77e6
2017-05-23 22:42:33 +02:00
Samuel Attard
5dd4d6a961
macOS implementation of notifications in the main process
2017-05-23 02:05:13 +10:00
Kevin Sawicki
a285a3e64b
Default webviewTag to false
2017-05-17 14:01:45 -07:00
Kevin Sawicki
9e88d337ec
Inherit webviewTag setting from parent window
2017-05-17 13:37:23 -07:00
Kevin Sawicki
bde13353fb
Rename option to webviewTag and default to nodeIntegration value
2017-05-17 13:12:23 -07:00
Kevin Sawicki
837ea884de
Merge remote-tracking branch 'origin/master' into enable-webview
2017-05-17 12:45:29 -07:00
Thiago de Arruda
6b5bd3b6ce
Fix how rpc-server releases references after page reload
...
In addition to listening for "render-view-deleted", listen for
"ELECTRON_BROWSER_CONTEXT_RELEASE" synchronous message, which is sent by the
remote module when the page is about to be navigated.
This is required to allow child windows running in the same renderer to
correctly manage remote object references, since `render-view-deleted` is only
called when the renderer exits.
Close #9387
2017-05-16 09:05:52 -03:00
Ryohei Ikegami
7ac93045b7
Merge branch 'master' into native-window-open
2017-05-11 13:51:43 +09:00
HariJ
a05eb9047e
Fixing missed variable name
2017-05-08 18:50:20 -07:00
Hari Krishna Reddy Juturu
3321f7d39c
Changing command line option name
2017-05-08 17:27:31 -07:00
Hari Krishna Reddy Juturu
94d054cf11
Add option to override webview security
2017-05-06 22:10:42 -07:00
Hari Krishna Reddy Juturu
b4a8ed01f1
PR 44648: Enabling creation on webview with node-integration disabled and raising events
...
- Enabling creation on webview with node-integration disabled and raising events
Conflicts:
lib/browser/guest-view-manager.js
2017-05-06 20:50:01 -07:00
Darrell Ulm
fa2bfd3ff5
Add Math.ceil to pageSize.height and pageSize.width to printToPDF() options to prevent error on display.
2017-05-06 19:19:31 -04:00
Kevin Sawicki
70e199e255
Merge pull request #9333 from electron/process-memory-info-sandbox
...
Expose `process.get{System,Process}MemoryInfo` to sandbox
2017-05-04 14:17:44 -07:00
Kevin Sawicki
eebae82bc1
Merge pull request #9315 from electron/segmented-control-mode
...
Add mode prop to segmented touch bar control
2017-05-04 14:16:28 -07:00
Samuel Attard
718dc732ad
Add docs and add isSelected arg
2017-05-03 20:25:50 +10:00
Kevin Sawicki
fa4ec11a12
Use isSameOrigin helper when posting message
2017-05-01 08:45:38 -07:00
Thiago de Arruda
bbe21cce67
Expose more atom_bindings.cc functions to sandbox
2017-05-01 09:12:39 -03:00
deepak1556
5e976be43b
remove page-title-updated workaround for #3380
2017-05-01 16:53:55 +09:00
Ryohei Ikegami
8b6b512485
Pass nativeWindowOpen flag to isolated init.js
2017-04-30 19:35:41 +09:00
Samuel Attard
225ccab3d2
Add mode prop to segmented touch bar control
2017-04-28 14:50:58 +10:00
Ryohei Ikegami
1d73e84a29
Merge branch 'master' into native-window-open
2017-04-27 12:03:55 +09:00
Kevin Sawicki
95ef422ab4
Coerce offset to number in renderer process
2017-04-26 12:37:16 -07:00
Kevin Sawicki
507f60e33e
Don't allow webPreferences to be overrideden in features string
2017-04-26 10:56:53 -07:00
Kevin Sawicki
91a1e5cdfe
Store frame to guests in map
2017-04-26 10:14:11 -07:00
Kevin Sawicki
2c48300daa
Fix typos in comment
2017-04-26 09:09:42 -07:00
Kevin Sawicki
246937a372
Convert targetOrigin to string in render process
2017-04-26 09:08:47 -07:00
Kevin Sawicki
3894c1c625
Convert frameName/features to strings in render process
2017-04-26 09:08:47 -07:00
Kevin Sawicki
05b6d91bf4
Disable node integration in chrome-devtools: URLs
2017-04-25 13:36:08 -07:00
Kevin Sawicki
3e2a1034af
Disable JavaScript on child when disabled on parent
2017-04-25 12:57:53 -07:00
Kevin Sawicki
6ec74060b4
Enable setting javascript and contextIsolation via window.open
2017-04-25 12:57:53 -07:00
Kevin Sawicki
c90fd4dc88
Convert message/title to strings in render process
2017-04-24 09:15:01 -07:00
Kevin Sawicki
a004cada7c
Merge pull request #9095 from seanchas116/better-path-resolve
...
Search for module from app path when URL is not file protocol
2017-04-20 10:49:53 -07:00
Kevin Sawicki
de62f1ea6c
Restart crash service in each spec
2017-04-19 16:37:24 -07:00
Samuel Attard
11c7c107a9
add iconPosition property to touch bar buttons
2017-04-18 08:56:39 -07:00
Ryohei Ikegami
8dff29185b
Merge branch 'master' into native-window-open
2017-04-18 21:59:22 +09:00
Birunthan Mohanathas
8b9f7e5b00
Implement initial, experimental BrowserView API
...
Right now, `<webview>` is the only way to embed additional content in a
`BrowserWindow`. Unfortunately `<webview>` suffers from a [number of
problems](https://github.com/electron/electron/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aopen%20label%3Awebview%20 ).
To make matters worse, many of these are upstream Chromium bugs instead
of Electron-specific bugs.
For us at [Figma](https://www.figma.com ), the main issue is very slow
performance.
Despite the upstream improvements to `<webview>` through the OOPIF work, it is
probable that there will continue to be `<webview>`-specific bugs in the
future.
Therefore, this introduces a `<webview>` alternative to called `BrowserView`,
which...
- is a thin wrapper around `api::WebContents` (so bugs in `BrowserView` will
likely also be bugs in `BrowserWindow` web contents)
- is instantiated in the main process like `BrowserWindow` (and unlike
`<webview>`, which lives in the DOM of a `BrowserWindow` web contents)
- needs to be added to a `BrowserWindow` to display something on the screen
This implements the most basic API. The API is expected to evolve and change in
the near future and has consequently been marked as experimental. Please do not
use this API in production unless you are prepared to deal with breaking
changes.
In the future, we will want to change the API to support multiple
`BrowserView`s per window. We will also want to consider z-ordering
auto-resizing, and possibly even nested views.
2017-04-13 01:27:27 +03:00
Thiago de Arruda
ce1a5e3c9c
Fix sandboxed crashReporter for windows.
...
- Use `path` module from browser process in sandboxed renderer. This is required
because the return value of `path.join` is platform-specific, and this is an
assumtion of crash-reporter.js which is shared between sandboxed and
non-sandboxed renderers.
- Set `process.platform` and `process.execPath` in sandboxed renderer
environment. This is required to spawn the windows crash service from
sandboxed renderer.
- Use a single temporary directory for all crashReporter tests. This is required
to make tests more deterministic across platforms(since mac's crashpad doesn't
support changing the crash dump directory). Also make a few improvements/fixes
to the `uploadToServer` test.
2017-04-05 18:09:24 -03:00
Samuel Attard
bea56bbdc8
Update as per feedback
2017-04-04 13:51:38 -07:00
Samuel Attard
2fd62d090a
Allow items to be assigned to multiple popovers
2017-04-04 13:51:33 -07:00
Samuel Attard
f05dfc74da
Store parent popover in popover touch bar items
2017-04-04 13:51:13 -07:00
Kevin Sawicki
74a3a34caa
Add spec for interaction event with escape item
2017-04-04 13:14:56 -07:00
Kevin Sawicki
bbadeb62ac
Check that escape item is non-null before checking id
2017-04-04 13:12:29 -07:00
Kevin Sawicki
414540bfcb
Support passing escape item to TouchBar constructor
2017-04-04 12:50:41 -07:00
Kevin Sawicki
b24b4212c5
Make escape item a property instead of setter
2017-04-04 12:50:41 -07:00
Kevin Sawicki
21c1ddffb3
Handle change and interaction events on escape items
2017-04-04 12:50:41 -07:00
Kevin Sawicki
591cd8d073
Update window via listener when escape item changes
2017-04-04 12:50:41 -07:00
Kevin Sawicki
d596d85288
🎨
2017-04-04 12:50:41 -07:00
Samuel Attard
60cc862031
Make everything pointer like
2017-04-04 12:50:41 -07:00
Samuel Attard
4d6b0fc01b
Add a method to set the escape identifier on the touch bar
2017-04-04 12:50:41 -07:00
Kevin Sawicki
fdd36334e5
Match args style of other IPC handlers
2017-04-04 11:18:16 -07:00
Kevin Sawicki
7065123266
Wrap remote value being set as an arg
2017-04-04 11:18:16 -07:00
Kevin Sawicki
3e9014c371
Merge pull request #9099 from electron/certificate-trust
...
macOS: Add certificate trust API
2017-04-04 11:17:09 -07:00
Kevin Sawicki
2e32525e8f
Make browser window optional
2017-04-04 10:49:10 -07:00
joshaber
2749ded062
Fix c&p error
2017-04-04 11:45:27 -04:00
Ryohei Ikegami
61fa8693d2
Merge branch 'master' into native-window-open
2017-04-04 20:54:37 +09:00
joshaber
e2bda3ca0f
Use an options object for most of the params
2017-04-03 21:33:21 -04:00
Ryohei Ikegami
4a7eec8f2d
Pass app path as command line argument
2017-04-04 09:36:01 +09:00
joshaber
0b7ffd094a
Expose through the actual JS API too
2017-04-03 15:25:06 -04:00
Kevin Sawicki
e85e483c71
Parse setting response to surface thrown errors
2017-04-03 12:16:51 -07:00
Ryohei Ikegami
001d03c859
Do not add search paths in devtools
2017-04-03 22:40:36 +09:00
Ryohei Ikegami
50c99e4507
Search for module under the app directory
2017-04-03 20:19:10 +09:00
Kevin Sawicki
fcb7cbc54a
Check name directly instead of arguments length
2017-03-30 14:03:00 -07:00
Thiago de Arruda
b3cf00a19a
Fix net module to accept non-string header values
...
This is required to be compatible with node.js http module.
2017-03-30 16:01:40 -03:00
Kevin Sawicki
57edc28b0d
Merge pull request #8880 from mst128256/2814
...
Default menu items for 'Edit' and 'Window' #2814
2017-03-29 12:31:58 -07:00
Kevin Sawicki
8b4bf1f29e
🎨
2017-03-29 12:29:36 -07:00
mst128256
6ae198a625
Empty objects within default menu replaced by nulls
2017-03-29 12:50:31 +02:00
deepak1556
3ae62615f4
net: allow controlling redirects
2017-03-28 18:46:21 +05:30
Ryohei Ikegami
9edfbab89f
Add comment why defaultPrevented = false
2017-03-28 19:58:58 +09:00
Ryohei Ikegami
de2019f6b8
Change webContents -> options.webContents
2017-03-28 19:58:23 +09:00
mst128256
9e471d8f1c
Added specs
2017-03-24 12:14:08 +01:00
Ryohei Ikegami
4e473897b7
Use ===
2017-03-24 11:08:08 +09:00
Ryohei Ikegami
6f9dbd4e04
Merge branch 'master' into native-window-open
2017-03-24 00:11:43 +09:00
Ryohei Ikegami
deba6553f5
Better preventDefault for ELECTRON_GUEST_WINDOW_MANAGER_INTERNAL_WINDOW_OPEN
2017-03-23 23:51:33 +09:00
Thiago de Arruda
3a97cfc359
Expose crashReporter to sandbox
2017-03-23 10:01:02 -03:00
Thiago de Arruda
e1aebef57c
Make sandbox APIs more compatible with normal renderers
...
- Expose remote shortcuts for the `fs`, `os` and `child_process` modules.
- Expose the `url` and `timers` modules(the browserify versions)
- Add `process.crash` and `process.platform`
2017-03-23 10:01:02 -03:00
Cheng Zhao
e539129db2
Merge pull request #8852 from electron/web-worker-hook
...
Add Node.js integration to WebWorker
2017-03-22 09:01:42 -07:00
Ryohei Ikegami
d3252e0eb1
Reuse existing event
2017-03-21 16:09:53 +09:00
Kevin Sawicki
23b235c9c7
Default async to false when object is specified
2017-03-20 20:37:52 -07:00
Cheng Zhao
bb5ad4ac05
Correctly initialize Node environment in worker
2017-03-20 12:52:45 -07:00
Kevin Sawicki
286f529968
Merge pull request #8890 from twolfson/dev/proxy.to.string.sqwished
...
🐛 Add toString support to remote functions
2017-03-20 09:35:51 -07:00
Ryohei Ikegami
076427673e
Fix JavaScript style
2017-03-19 18:20:10 +09:00
Ryohei Ikegami
319a7759d0
Fix ELECTRON_GUEST_WINDOW_MANAGER_INTERNAL_WINDOW_OPEN handler
2017-03-19 17:52:39 +09:00
Ryohei Ikegami
a1f9a45276
Use native window.open implementation
2017-03-19 17:41:20 +09:00
Kevin Sawicki
c50b518493
Check toString after loading remote properties
2017-03-17 10:29:07 -07:00
Kevin Sawicki
f71353a4c5
Merge pull request #8939 from electron/expose-remote-to-sandbox
...
Expose remote module to sandbox
2017-03-17 09:41:59 -07:00
Todd Wolfson
818738ce84
🐛 Add toString support to remote functions
2017-03-17 08:21:37 -07:00
