mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
18747 commits 1 branch 183 tags 5.3 GiB
Commit graph

814 commits

Author SHA1 Message Date
Cheng Zhao
4dc74776c1 Merge pull request #10709 from electron/fix-notification-actions-hs 
Fix notification actions not working on High Sierra
 2017-10-17 15:18:53 +08:00
Ales Pergl
1d25d58c26 Fixed font DPI scaling 2017-10-09 10:17:00 +02:00
Samuel Attard
e5d4574d3a Use NSUserNotification identifiers to uniquely find the correct notification from CocoaNotification 2017-10-07 14:51:28 +11:00
Shelley Vohr
96f1a25bbd
convert to wstring for windows 2017-09-29 10:29:45 -04:00
Shelley Vohr
e7bb553d3b
consolidate code and rename for clarity 2017-09-29 09:32:30 -04:00
Shelley Vohr
c620d0de05
move overrides into the appropriate namespace 2017-09-28 23:03:01 -04:00
Shelley Vohr
0dfadf7c09
remove unresolved external symbol 2017-09-28 13:35:24 -04:00
Shelley Vohr
911e266e9a
add function signature declaration 2017-09-28 13:35:24 -04:00
Shelley Vohr
223942bf99
fix incorrect std namespacing 2017-09-28 13:35:24 -04:00
Zeke Sikelianos
94f46c9059
fix typo in comment 2017-09-28 13:35:24 -04:00
Shelley Vohr
fc443a8c2c
fix header and line length lint errors 2017-09-28 13:35:24 -04:00
Shelley Vohr
d2d4b4cc23
fix escape backslashes 2017-09-28 13:35:24 -04:00
Shelley Vohr
c1c8f7b0f1
fix string concat errors 2017-09-28 13:35:23 -04:00
Shelley Vohr
2353fdb400
add dir creation if none exists 2017-09-28 13:35:23 -04:00
Shelley Vohr
e81cf74b39
add windows override path and cleanup linux 2017-09-28 13:35:23 -04:00
Shelley Vohr
e096b5ce83
fix override path 2017-09-28 13:35:23 -04:00
Shelley Vohr
3de008035a
appeasing the linter 2017-09-28 13:35:23 -04:00
Shelley Vohr
f026bbb454
add first go at linux log path override 2017-09-28 13:35:23 -04:00
Shelley Vohr
5ef4caf8ab
add ability to access logs in getPath() 2017-09-28 13:35:22 -04:00
Cheng Zhao
91e11f8e6f Merge pull request #10609 from electron/win32_toast_update 
Fix for narrowing conversion warnings, minor style change
 2017-09-26 10:50:45 +09:00
Felix Rieseberg
741dc1eb0b 🔧 Ensure correct path 2017-09-25 13:51:16 -07:00
Ales Pergl
75feb495ad Fix for narrowing conversion warnings, minor style change 2017-09-25 18:08:54 +02:00
Yuya Ochiai
d621471eb2 🏁 Set duration for Windows 7 notifications based on Control Panel 2017-09-22 21:28:29 +09:00
Ales Pergl
af92a639be Fixed potential crash in Win32 notifications. 2017-09-14 11:52:53 +02:00
Charlie Hess
2b9b186fd1
Rename soundName → sound. 2017-08-17 17:28:14 -07:00
Charlie Hess
0cfae1cc2b
Plumb in the macOS soundName property for notifications. 2017-08-17 13:31:20 -07:00
Kevin Sawicki
ad33e569d6 Register default layout provider 2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
48821a6d2a Fix compilation 2017-08-15 16:19:21 +03:00
Aleksei Kuzmin
adddff3ee2 Move PrefRegistrySimple to use unique_ptr<Value> 
https://codereview.chromium.org/2784513002
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
99e57f9072 Add display::GetDisplayNearestView 
https://codereview.chromium.org/2751833004
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
7c7300ff82 Make GetDisplayedNotifications asynchronous. 
https://codereview.chromium.org/2749453002
 2017-08-15 16:19:20 +03:00
Aleksei Kuzmin
a20f633272 Remove base::StringValue 
https://codereview.chromium.org/2664753002
 2017-08-15 16:19:20 +03:00
Milan Burda
a196bf97bc 🍎 Add subtitle to Notification properties 2017-06-30 16:54:28 +02:00
Samuel Attard
3774482859 Update notification PR as per feedback 2017-06-28 17:00:19 +10:00
Samuel Attard
7eb14243eb Refactor notification options 2017-06-24 21:39:06 +10:00
Samuel Attard
17e737eba2 s/label/text 2017-06-23 21:04:39 +10:00
Samuel Attard
4f0d48f164 Add support for notification actions on macOS 2017-06-23 20:50:20 +10:00
Cheng Zhao
e82af41591 Merge pull request #9269 from electron/main-notifications 
Notifications from the main process
 2017-05-31 17:21:05 +09:00
Cheng Zhao
5fa2831756 Coding style fixes 2017-05-31 16:17:29 +09:00
Samuel Attard
227a2bd5dc
Fix reference typed reply placeholder 2017-05-30 20:29:27 +10:00
Samuel Attard
3938373ecb
Fix linting errors and add isSupported 2017-05-30 20:27:24 +10:00
Samuel Attard
686b1388b1
Fix linting issues 2017-05-30 19:12:36 +10:00
Samuel Attard
5048425e6e
Update implementation as per feedback 2017-05-30 19:06:51 +10:00
Samuel Attard
9aa6b83f86 Fix compilation and click events on macOS 2017-05-29 21:22:44 +10:00
Samuel Attard
058bdfbced Use NotificationPresenter - macOS 2017-05-29 20:02:33 +10:00
Kevin Sawicki
c43c3b3d80 Revert "protocol: use streaming interface between fetcher and requestjob" 
This reverts commit 71b5d946e0.
 2017-05-26 09:47:22 -07:00
Kevin Sawicki
7e185ef1a3 Remove extra newlines 2017-05-19 08:46:15 -07:00
Kevin Sawicki
e19eef025d Remove lint from inspectable_web_contents_view_views.h/cc 2017-05-19 08:46:15 -07:00
Kevin Sawicki
4625159310 Add memory include for std::unique_ptr 2017-05-19 08:46:15 -07:00
Kevin Sawicki
278a283801 🎨 Group includes 2017-05-19 08:46:15 -07:00
Kevin Sawicki
d7321ed980 Add brightray prefix to include paths from within brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
c4608c0f37 Fix build/include_alpha linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
f193b2b2a6 Fix build/include_what_you_use linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
cfb5b6ac89 Fix build/header_guard linter violations in brightray 2017-05-19 08:46:15 -07:00
Kevin Sawicki
bb4a61c7ff Remove unused includes 2017-05-19 08:46:15 -07:00
Kevin Sawicki
c6190dc094 Remove unused BRYApplication class 2017-05-19 08:46:15 -07:00
Kevin Sawicki
ca274f7be0 Use kIgnoreCertificateErrors from content_switches.h 2017-05-19 08:46:15 -07:00
Kevin Sawicki
f556d1924d Merge pull request #9358 from electron/fetch_job_uaf_patch 
protocol: use streaming interface between fetcher and requestjob
 2017-05-18 09:58:05 -07:00
Kevin Sawicki
ed076a8693 Remove unneeded HasSwitch check 2017-05-15 10:35:43 -07:00
Dun Liang
5b02974aa8 fix line is > 80 characters long 2017-05-15 10:35:43 -07:00
Dun Liang
9ce08d08de support --disk-cache-size flag #290 2017-05-15 10:35:43 -07:00
deepak1556
71b5d946e0 protocol: use streaming interface between fetcher and requestjob 2017-05-11 22:52:49 +05:30
Cheng Zhao
55e9c3196a Fix building on Linux 2017-04-17 16:52:24 +09:00
Cheng Zhao
b82845dc4a A quick fix for crashing when closing devtools 2017-04-17 16:16:02 +09:00
Cheng Zhao
98c039c880 Detach from devtools before destroying 
Otherwise Electron would crash on exit in Chrome 58.
 2017-04-17 16:16:02 +09:00
Cheng Zhao
79a441874e Fill missing NetworkDelegate method 2017-04-17 16:16:02 +09:00
Cheng Zhao
bbd4749668 base::WrapUnique has changed its API 2017-04-17 16:16:02 +09:00
Cheng Zhao
c41fb922b3 Fix API changes of Chrome 58 2017-04-17 16:16:02 +09:00
Cheng Zhao
0a110a44f9 ScopedPtrHashMap has been removed 2017-04-17 16:16:02 +09:00
Birunthan Mohanathas
708d39ebe5 Merge pull request #289 from poiru/windows-wm-state 
Initialize wm::WMState on Windows as well
 2017-04-16 17:58:41 +03:00
Birunthan Mohanathas
ed9795514e Initialize wm::WMState on Windows as well 
See:
cd4f72fdea/ui/views_content_client/views_content_client_main_parts_aura.cc (23)

This fixes electron/electron#9197.
 2017-04-16 17:32:28 +03:00
Ales Pergl
fbe3b27409 Addressed review feedback 2017-04-05 14:30:17 +02:00
Ales Pergl
f73233ee55 Changed local variable and parameter names to snake case style 2017-04-05 14:30:17 +02:00
Ales Pergl
ba03c544f3 Address cpplint issue ""public:" should be preceded by a blank line [whitespace/blank_line] [3]" 2017-04-05 14:30:17 +02:00
Ales Pergl
3336e02769 Address cpplint issue "Constructors callable with one argument should be marked explicit. [runtime/explicit] [5]" 2017-04-05 14:30:17 +02:00
Ales Pergl
1a7d9a5d20 Address cpplint issue "At least two spaces is best between code and comments [whitespace/comments] [2]" 2017-04-05 14:30:17 +02:00
Ales Pergl
bf86718d61 Address cpplint issue "DISALLOW_COPY_AND_ASSIGN should be the last thing in the class [readability/constructors] [3]" 2017-04-05 14:30:16 +02:00
Ales Pergl
161b4e752b Address cpplint issue "public: should be indented +1 space inside class NotificationPresenterWin7 [whitespace/indent] [3]" 2017-04-05 14:30:16 +02:00
Ales Pergl
9d75e9f54c Address cpplint issue "Namespace should be terminated with "// namespace brightray" [readability/namespace] [5]" 2017-04-05 14:30:16 +02:00
Ales Pergl
64bf0d210e Address cpplint issue "An else should appear on the same line as the preceding } [whitespace/newline] [4]" 2017-04-05 14:30:16 +02:00
Ales Pergl
9b7fbd4d22 Address cpplint issue "Using C-style cast. Use reinterpret_cast<BYTE*>(...) instead [readability/casting] [4]" 2017-04-05 14:30:16 +02:00
Ales Pergl
91cff2e6c7 Address cpplint issue "Missing space before ( in if( [whitespace/parens] [5]" 2017-04-05 14:30:16 +02:00
Ales Pergl
29f3332276 Address cpplint issue "{ should almost always be at the end of the previous line [whitespace/braces] [4]" 2017-04-05 14:30:16 +02:00
Ales Pergl
63eeb96e71 Address cpplint issue "Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]" 2017-04-05 14:30:16 +02:00
Ales Pergl
20d0bda538 Address cpplint issue "Found C++ system header after other header. Should be: toast.h, c system, c++ system, other. [build/include_order] [4]" 2017-04-05 14:30:16 +02:00
Ales Pergl
33b4936a68 Address cpplint issue "Include the directory when naming .h files [build/include] [4]" 2017-04-05 14:30:15 +02:00
Ales Pergl
0bba5b9b41 Address cpplint issue "Lines should be <= 80 characters long [whitespace/line_length] [2]" 2017-04-05 14:30:15 +02:00
Ales Pergl
392d606848 Changed member variable naming style to snake case 2017-04-05 14:30:15 +02:00
Ales Pergl
0fa6c82b3f Use NotificationPresenterWin7 on Windows 7 2017-04-05 14:30:15 +02:00
Ales Pergl
fe05b66a6c Added desktop notifications implementation for Windows 7 (and earlier) 2017-04-05 14:30:15 +02:00
Ales Pergl
e6a30388da Make Notification factory function a member of NotificationPresenter so that we can create different types of notifications based on runtime conditions. 2017-04-05 14:30:15 +02:00
Kevin Sawicki
0981807261 Merge pull request #287 from electron/no-anonymous-ns-in-header 
Don't use anonymous namespace in header file.
 2017-04-03 08:27:51 -07:00
Haojian Wu
e80a9bbb93 Move title_ to InspectableWebContentsViewVies to get rid of cast. 2017-04-01 15:10:52 +02:00
Haojian Wu
ee1f3acf7b Don't use anonymous namespace in header file. 
Anonymous namespace should be forbidden in header files even for the
forward declarations:

* As declarations defined in anonymous namespace are internal linkage, each
translation unit which includes this header will get unique copy, which
wastes space.
* It is easy to violate C++ ODR rule.

Consider the following "foo.h":

```cpp
namespace { class Foo; }
class Bar {
  public:
    Foo* getFoo();
    Foo* foo;
}
```

If the 'foo.h' is included in multiple `.cc` files, the compiler will
put `Foo` into a different anonymous namespace in each `.cc`, which
means there are different definitions of `Foo` in the program (a
violation of the ODR).
 2017-04-01 08:57:34 +02:00
Haojian Wu
f506047a9b Remove an extra blank line. 2017-03-31 21:56:19 +02:00
Haojian Wu
22035e2d6d Fix cpplint: at least two spaces between code and comments. 2017-03-31 20:59:27 +02:00
Haojian Wu
d18b34d55f Replace size() method with empty() when possible. 
There is no guaranteed that size() is a constant-time function.
 2017-03-30 21:49:16 +02:00
Haojian Wu
e4c571fc68 Remove unused using namespace declaration. 2017-03-30 21:49:15 +02:00
Haojian Wu
424078cfdb Fix namespace comments. 2017-03-30 21:49:15 +02:00
Cheng Zhao
bd5c53c2f7 Merge pull request #283 from electron/devtools_shutdown_patch_revert_revert 
Revert "Revert "close devtools web contents when available to trigger cleanup""
 2017-03-27 22:46:06 -07:00
Kevin Sawicki
21956071e6 Fix compilation issue 2017-03-24 09:52:37 -07:00
Kevin Sawicki
2ece711c2e Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
Kevin Sawicki
be0c0e278a Remove cpplint errors 2017-03-23 12:48:27 -07:00
deepak1556
99fd1394e4 Revert "Revert "close devtools web contents when available to trigger cleanup"" 
This reverts commit 7f01bf4e73c188db2406ded1286b661c61c78bba.
 2017-03-19 01:25:22 +05:30
Kevin Sawicki
8877d78e79 Revert "close devtools web contents when available to trigger cleanup" 2017-03-17 09:35:01 -07:00
deepak1556
07c4f3563e close devtools web contents when available to trigger cleanup 2017-03-14 22:23:08 +05:30
Kevin Sawicki
4ed9f63989 Cleanly shutdown browser context 2017-02-13 11:04:02 -08:00
deepak1556
0b76a9c073 Persist zoom levels per partition 2017-02-10 22:54:32 +05:30
Cheng Zhao
abececd78b libgtk2ui => libgtkui 2017-01-26 20:02:01 +09:00
Cheng Zhao
a749a3dd2a Fix Debug building on Windows 2017-01-26 16:09:45 +09:00
Cheng Zhao
94fdcb4f48 WebInspector has been split up 2017-01-25 08:43:27 +09:00
Cheng Zhao
bf4c413947 Update PlatformNotificationService 2017-01-23 17:48:16 +09:00
Cheng Zhao
ac4ef926e1 URLRequestContenxtGetter now accepts task runner 2017-01-23 15:43:17 +09:00
Cheng Zhao
622fd8d1d7 Update InspectableWebContentsImpl 2017-01-23 15:43:17 +09:00
Cheng Zhao
db7959619e Update DevToolsNetworkUploadDataStream 2017-01-23 15:18:52 +09:00
Cheng Zhao
70ffec1134 There is no content::MEDIA_ENUMERATE_DEVICES anymore 2017-01-23 15:14:38 +09:00
Cheng Zhao
0236f87507 Update DevToolsNetworkTransaction 2017-01-23 15:10:34 +09:00
Cheng Zhao
e7ee9f1be9 DevToolsDelegate is no longer needed 2017-01-23 15:07:18 +09:00
Cheng Zhao
804d56e139 Signature of StartDataRequest has changed 2017-01-23 14:55:06 +09:00
Cheng Zhao
eb89edbf5b devtools_discovery and devtools_http_handler are gone 2017-01-23 14:54:58 +09:00
Ales Pergl
85db1bb47d Adjustments after upgrading to Chromium 54 2017-01-17 17:18:51 +09:00
Kevin Sawicki
e5ec6adf7d Update std:move call to fix macOS compiler error 2017-01-12 14:04:12 -08:00
deepak1556
cddce77ea4 force attach devtools client when requested by inspectable webcontents 2017-01-10 16:43:16 +05:30
deepak1556
237cb7d0a3 interceptor should handle default values of download and upload throughput 2017-01-06 23:28:49 +05:30
deepak1556
dbf4e52e05 persist media device id salt across sessions 2016-12-03 16:47:31 +05:30
Kevin Sawicki
7cb8c1fdb9 Add dismiss notification guard on Linux 2016-10-28 11:24:47 -07:00
Kevin Sawicki
0a5f7171d4 Add more guards around null notification 2016-10-28 10:54:55 -07:00
deepak1556
ee4442f964 set notification close callback before requesting user permission 2016-10-25 19:04:09 +05:30
Kevin Sawicki
4fdca64030 Merge pull request #256 from deepak1556/ct_delegate_patch 
allow embedder to provide RequireCTDelegate
 2016-10-24 15:39:49 +09:00
deepak1556
aa7255bad5 allow embedder to provide RequireCTDelegate 2016-10-17 16:06:37 +05:30
deepak1556
f652760c7a use dock state from peferences when not set by embedder 2016-10-11 13:47:06 +05:30
deepak1556
968bc5c9a2 set dock state using devtools dockController 2016-10-06 17:31:38 +05:30
Kevin Sawicki
67eff02a65 🎨 2016-09-29 08:43:33 -07:00
Kevin Sawicki
cbe92b5fb5 Support configuring a cookie delegate 2016-09-29 08:43:33 -07:00
Kevin Sawicki
c46200761f Use net::URLRequestContextBuilder::SetHttpNetworkSessionComponents helper 2016-09-28 16:00:23 -07:00
Kevin Sawicki
096d3e61fa Remove unused instance variables 2016-09-28 11:17:42 -07:00
Kevin Sawicki
14c4b1eabb Set certificate transparency objects on URLRequestContextStorage 2016-09-28 11:14:18 -07:00
Kevin Sawicki
bffd87c118 Call AddLogs through unique pointer 2016-09-21 10:16:05 -07:00
Kevin Sawicki
39a69467ed Add verifiers for known logs 2016-09-21 09:48:17 -07:00
Cheng Zhao
d435df77f8 Revert "initialize crypto delegate in CookieStoreConfig" 
This reverts commit ad1d1dce72c6fcb6c15a18dac04ff382d9bf4db0.
 2016-09-19 16:30:16 +09:00
Cheng Zhao
7917aa8938 Merge pull request #246 from deepak1556/cookie_crypto_patch 
initialize crypto delegate in CookieStoreConfig
 2016-09-16 21:26:19 +09:00
Cheng Zhao
676a389ecd Add new network parameters needed by chrome53 2016-09-07 17:54:55 +09:00
Cheng Zhao
ab14221a85 Fix API changes of Chrome 53 2016-09-06 17:22:52 +09:00
deepak1556
a56c6b1b79 initialize crypto delegate in CookieStoreConfig 2016-09-03 11:05:38 +05:30
Cheng Zhao
900225bb03 Put definetion of GetCookieableSchemes in .cc to match other methods 2016-08-05 16:23:31 +09:00
Cheng Zhao
5ecefd298a Merge pull request #244 from deepak1556/cookieable_schemes_patch 
allow additional schemes that should support cookies
 2016-08-05 16:19:13 +09:00
Cheng Zhao
03e2250638 Fix building under linux 2016-08-04 16:40:13 +09:00
Cheng Zhao
1a80cb22b7 Show label for offscreen webview 2016-08-04 16:35:09 +09:00
deepak1556
e96b224307 allow delegate to provide cookieable schemes 2016-08-04 12:21:54 +05:30
deepak1556
826fbf3e21 allow additional schemes that should support cookies 2016-08-03 15:52:09 +05:30