mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
electron/brightray/browser
History
Haojian Wu ee1f3acf7b Don't use anonymous namespace in header file. 
Anonymous namespace should be forbidden in header files even for the
forward declarations:

* As declarations defined in anonymous namespace are internal linkage, each
translation unit which includes this header will get unique copy, which
wastes space.
* It is easy to violate C++ ODR rule.

Consider the following "foo.h":

```cpp
namespace { class Foo; }
class Bar {
  public:
    Foo* getFoo();
    Foo* foo;
}
```

If the 'foo.h' is included in multiple `.cc` files, the compiler will
put `Foo` into a different anonymous namespace in each `.cc`, which
means there are different definitions of `Foo` in the program (a
violation of the ODR).
2017-04-01 08:57:34 +02:00
..
linux Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
mac Add more guards around null notification 2016-10-28 10:54:55 -07:00
media Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
net Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
views Don't use anonymous namespace in header file. 2017-04-01 08:57:34 +02:00
win Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
brightray_paths.h Change our PATH_START to 11000 2016-01-11 10:40:20 +08:00
browser_client.cc Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
browser_client.h Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
browser_context.cc Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
browser_context.h persist media device id salt across sessions 2016-12-03 16:47:31 +05:30
browser_main_parts.cc libgtk2ui => libgtkui 2017-01-26 20:02:01 +09:00
browser_main_parts.h DevToolsDelegate is no longer needed 2017-01-23 15:07:18 +09:00
browser_main_parts_mac.mm No more need to call setrlimit 2015-10-20 22:38:20 +08:00
devtools_contents_resizing_strategy.cc Use new devtools resizing strategy from Chrome 37. 2014-09-01 19:15:07 +08:00
devtools_contents_resizing_strategy.h basictypes.h => macros.h 2016-03-07 21:40:41 -08:00
devtools_embedder_message_dispatcher.cc Fix API changes of Chrome 53 2016-09-06 17:22:52 +09:00
devtools_embedder_message_dispatcher.h fix devtools filesystem api and allow delegate to request stored filesystem paths 2016-03-15 07:53:40 +05:30
devtools_file_system_indexer.cc Adjustments after upgrading to Chromium 54 2017-01-17 17:18:51 +09:00
devtools_file_system_indexer.h port DevToolsFileSystemIndexer 2016-05-07 04:36:42 +05:30
devtools_manager_delegate.cc DevToolsDelegate is no longer needed 2017-01-23 15:07:18 +09:00
devtools_manager_delegate.h DevToolsDelegate is no longer needed 2017-01-23 15:07:18 +09:00
devtools_ui.cc Signature of StartDataRequest has changed 2017-01-23 14:55:06 +09:00
devtools_ui.h use browser context from webcontents for registering datasource 2015-08-31 21:04:48 +05:30
inspectable_web_contents.cc web_contents_view.h has been hidden from user. 2014-07-27 11:27:04 +00:00
inspectable_web_contents.h Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
inspectable_web_contents_delegate.h allow delegate to handle file system indexing requests 2016-05-07 04:36:00 +05:30
inspectable_web_contents_impl.cc Merge pull request #283 from electron/devtools_shutdown_patch_revert_revert 2017-03-27 22:46:06 -07:00
inspectable_web_contents_impl.h Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
inspectable_web_contents_view.h Add IsDevToolsViewFocused method 2015-09-15 11:04:46 +08:00
inspectable_web_contents_view_delegate.cc Add InspectableWebContentsViewDelegate 2015-06-25 12:29:34 +08:00
inspectable_web_contents_view_delegate.h Revert "Merge pull request #218 from deepak1556/devtools_extensions_load_patch" 2016-05-12 18:57:54 +05:30
inspectable_web_contents_view_mac.h Add IsDevToolsViewFocused method 2015-09-15 11:04:46 +08:00
inspectable_web_contents_view_mac.mm notify devtools opened and closed once per lifetime 2016-05-12 19:16:13 +05:30
net_log.cc Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
net_log.h Store NetLog in BrowserClient 2015-08-11 18:29:55 +08:00
network_delegate.cc Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
network_delegate.h Fix API changes of Chrome 53 2016-09-06 17:22:52 +09:00
notification.cc Store weak ref to Notification in ToastEventHandler 2016-04-15 16:14:13 +09:00
notification.h set notification close callback before requesting user permission 2016-10-25 19:04:09 +05:30
notification_delegate.h win: Fire NotificationFailed when failed to show notification 2015-12-25 11:17:35 +08:00
notification_delegate_adapter.cc Adapt to changes of Chrome 51 API changes 2016-05-23 10:59:07 +09:00
notification_delegate_adapter.h Adapt to changes of Chrome 51 API changes 2016-05-23 10:59:07 +09:00
notification_presenter.cc Decouple notification code from content module 2015-12-25 10:16:07 +08:00
notification_presenter.h Decouple notification code from content module 2015-12-25 10:16:07 +08:00
permission_manager.cc Adjustments after upgrading to Chromium 54 2017-01-17 17:18:51 +09:00
permission_manager.h Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
platform_notification_service.cc Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
platform_notification_service.h Update PlatformNotificationService 2017-01-23 17:48:16 +09:00
special_storage_policy.cc Update to API changes of Chrome 47 2015-12-07 19:55:01 +08:00
special_storage_policy.h Update to API changes of Chrome 47 2015-12-07 19:55:01 +08:00
url_request_context_getter.cc Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
url_request_context_getter.h Format line length to 80 instead of 100 2017-03-23 15:47:30 -07:00
web_ui_controller_factory.cc Modernize to C++11 : NULL => nullptr 2016-07-10 12:30:17 +02:00
web_ui_controller_factory.h basictypes.h => macros.h 2016-03-07 21:40:41 -08:00
zoom_level_delegate.cc Persist zoom levels per partition 2017-02-10 22:54:32 +05:30
zoom_level_delegate.h Persist zoom levels per partition 2017-02-10 22:54:32 +05:30