Fix build/include_what_you_use linter violations in brightray

2017-05-18 15:06:57 -07:00 · 2017-05-18 15:06:57 -07:00 · f193b2b2a6
commit f193b2b2a6
parent cfb5b6ac89
28 changed files with 60 additions and 4 deletions
--- a/brightray/CPPLINT.cfg
+++ b/brightray/CPPLINT.cfg
@ -1 +1 @@
-filter=-build/include_what_you_use,-legal/copyright,-runtime/references
+filter=-legal/copyright,-runtime/references
--- a/brightray/browser/browser_client.h
+++ b/brightray/browser/browser_client.h
@ -5,6 +5,9 @@
 #ifndef BRIGHTRAY_BROWSER_BROWSER_CLIENT_H_
 #define BRIGHTRAY_BROWSER_BROWSER_CLIENT_H_

+#include <string>
+#include <vector>
+
 #include "browser/net_log.h"
 #include "content/public/browser/content_browser_client.h"

--- a/brightray/browser/browser_context.h
+++ b/brightray/browser/browser_context.h
@ -6,6 +6,7 @@
 #define BRIGHTRAY_BROWSER_BROWSER_CONTEXT_H_

 #include <map>
+#include <string>

 #include "browser/net/devtools_network_controller_handle.h"
 #include "browser/permission_manager.h"
--- a/brightray/browser/devtools_file_system_indexer.cc
+++ b/brightray/browser/devtools_file_system_indexer.cc
@ -6,7 +6,9 @@

 #include <stddef.h>

+#include <algorithm>
 #include <iterator>
+#include <set>

 #include "base/bind.h"
 #include "base/files/file_enumerator.h"
--- a/brightray/browser/devtools_manager_delegate.h
+++ b/brightray/browser/devtools_manager_delegate.h
@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_DEVTOOLS_MANAGER_DELEGATE_H_
 #define BRIGHTRAY_BROWSER_DEVTOOLS_MANAGER_DELEGATE_H_

+#include <string>
+
 #include "base/macros.h"
 #include "base/compiler_specific.h"
 #include "content/public/browser/devtools_manager_delegate.h"
--- a/brightray/browser/inspectable_web_contents.h
+++ b/brightray/browser/inspectable_web_contents.h
@ -1,6 +1,8 @@
 #ifndef BRIGHTRAY_BROWSER_INSPECTABLE_WEB_CONTENTS_H_
 #define BRIGHTRAY_BROWSER_INSPECTABLE_WEB_CONTENTS_H_

+#include <string>
+
 #include "content/public/browser/web_contents.h"

 namespace base {
--- a/brightray/browser/inspectable_web_contents_impl.h
+++ b/brightray/browser/inspectable_web_contents_impl.h
@ -6,6 +6,10 @@
 #ifndef BRIGHTRAY_BROWSER_INSPECTABLE_WEB_CONTENTS_IMPL_H_
 #define BRIGHTRAY_BROWSER_INSPECTABLE_WEB_CONTENTS_IMPL_H_

+#include <map>
+#include <string>
+#include <vector>
+
 #include "browser/inspectable_web_contents.h"

 #include "browser/devtools_contents_resizing_strategy.h"
--- a/brightray/browser/inspectable_web_contents_view_delegate.h
+++ b/brightray/browser/inspectable_web_contents_view_delegate.h
@ -1,6 +1,8 @@
 #ifndef BRIGHTRAY_BROWSER_INSPECTABLE_WEB_CONTENTS_VIEW_DELEGATE_H_
 #define BRIGHTRAY_BROWSER_INSPECTABLE_WEB_CONTENTS_VIEW_DELEGATE_H_

+#include <string>
+
 #include "ui/gfx/image/image_skia.h"

 namespace brightray {
--- a/brightray/browser/linux/libnotify_notification.h
+++ b/brightray/browser/linux/libnotify_notification.h
@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_LINUX_LIBNOTIFY_NOTIFICATION_H_
 #define BRIGHTRAY_BROWSER_LINUX_LIBNOTIFY_NOTIFICATION_H_

+#include <string>
+
 #include "browser/linux/libnotify_loader.h"
 #include "browser/notification.h"
 #include "ui/base/glib/glib_signal.h"
--- a/brightray/browser/mac/cocoa_notification.h
+++ b/brightray/browser/mac/cocoa_notification.h
@ -7,6 +7,8 @@

 #import <Foundation/Foundation.h>

+#include <string>
+
 #include "base/mac/scoped_nsobject.h"
 #include "browser/notification.h"

--- a/brightray/browser/media/media_capture_devices_dispatcher.h
+++ b/brightray/browser/media/media_capture_devices_dispatcher.h
@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_MEDIA_MEDIA_CAPTURE_DEVICES_DISPATCHER_H_
 #define BRIGHTRAY_BROWSER_MEDIA_MEDIA_CAPTURE_DEVICES_DISPATCHER_H_

+#include <string>
+
 #include "base/memory/singleton.h"
 #include "content/public/browser/media_observer.h"
 #include "content/public/common/media_stream_request.h"
--- a/brightray/browser/net/devtools_network_protocol_handler.cc
+++ b/brightray/browser/net/devtools_network_protocol_handler.cc
@ -4,6 +4,8 @@

 #include "browser/net/devtools_network_protocol_handler.h"

+#include <string>
+
 #include "browser/browser_context.h"
 #include "browser/net/devtools_network_conditions.h"
 #include "browser/net/devtools_network_controller.h"
@ -12,7 +14,6 @@
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/devtools_agent_host.h"

-
 namespace brightray {

 namespace {
--- a/brightray/browser/net/devtools_network_transaction.cc
+++ b/brightray/browser/net/devtools_network_transaction.cc
@ -4,6 +4,8 @@

 #include "browser/net/devtools_network_transaction.h"

+#include <string>
+
 #include "browser/net/devtools_network_controller.h"
 #include "browser/net/devtools_network_upload_data_stream.h"
 #include "net/base/load_timing_info.h"
--- a/brightray/browser/net/devtools_network_transaction_factory.cc
+++ b/brightray/browser/net/devtools_network_transaction_factory.cc
@ -4,6 +4,9 @@

 #include "browser/net/devtools_network_transaction_factory.h"

+#include <set>
+#include <string>
+
 #include "browser/net/devtools_network_controller.h"
 #include "browser/net/devtools_network_transaction.h"

--- a/brightray/browser/notification.h
+++ b/brightray/browser/notification.h
@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_NOTIFICATION_H_
 #define BRIGHTRAY_BROWSER_NOTIFICATION_H_

+#include <string>
+
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string16.h"

--- a/brightray/browser/permission_manager.h
+++ b/brightray/browser/permission_manager.h
@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_PERMISSION_MANAGER_H_
 #define BRIGHTRAY_BROWSER_PERMISSION_MANAGER_H_

+#include <vector>
+
 #include "base/callback_forward.h"
 #include "base/macros.h"
 #include "content/public/browser/permission_manager.h"
--- a/brightray/browser/platform_notification_service.h
+++ b/brightray/browser/platform_notification_service.h
@ -5,6 +5,9 @@
 #ifndef BRIGHTRAY_BROWSER_PLATFORM_NOTIFICATION_SERVICE_H_
 #define BRIGHTRAY_BROWSER_PLATFORM_NOTIFICATION_SERVICE_H_

+#include <set>
+#include <string>
+
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/platform_notification_service.h"

--- a/brightray/browser/url_request_context_getter.h
+++ b/brightray/browser/url_request_context_getter.h
@ -5,6 +5,9 @@
 #ifndef BRIGHTRAY_BROWSER_URL_REQUEST_CONTEXT_GETTER_H_
 #define BRIGHTRAY_BROWSER_URL_REQUEST_CONTEXT_GETTER_H_

+#include <string>
+#include <vector>
+
 #include "base/files/file_path.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/content_browser_client.h"
--- a/brightray/browser/views/views_delegate.h
+++ b/brightray/browser/views/views_delegate.h
@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_VIEWS_VIEWS_DELEGATE_H_
 #define BRIGHTRAY_BROWSER_VIEWS_VIEWS_DELEGATE_H_

+#include <string>
+
 #include "base/compiler_specific.h"
 #include "ui/views/views_delegate.h"

--- a/brightray/browser/win/notification_presenter_win.cc
+++ b/brightray/browser/win/notification_presenter_win.cc
@ -6,6 +6,9 @@

 #include "browser/win/notification_presenter_win.h"

+#include <string>
+#include <vector>
+
 #include "base/files/file_util.h"
 #include "base/md5.h"
 #include "base/strings/utf_string_conversions.h"
--- a/brightray/browser/win/notification_presenter_win7.cc
+++ b/brightray/browser/win/notification_presenter_win7.cc
@ -1,4 +1,7 @@
 #include "browser/win/notification_presenter_win7.h"
+
+#include <string>
+
 #include "browser/win/win32_notification.h"

 namespace brightray {
--- a/brightray/browser/win/win32_notification.cc
+++ b/brightray/browser/win/win32_notification.cc
@ -1,6 +1,10 @@
 #define WIN32_LEAN_AND_MEAN
+
 #include "browser/win/win32_notification.h"
+
 #include <windows.h>
+#include <string>
+
 #include "third_party/skia/include/core/SkBitmap.h"

 namespace brightray {
--- a/brightray/browser/win/windows_toast_notification.h
+++ b/brightray/browser/win/windows_toast_notification.h
@ -12,6 +12,7 @@
 #include <windows.h>
 #include <windows.ui.notifications.h>
 #include <wrl/implements.h>
+#include <string>

 #include "browser/notification.h"

--- a/brightray/browser/zoom_level_delegate.cc
+++ b/brightray/browser/zoom_level_delegate.cc
@ -5,6 +5,7 @@
 #include "browser/zoom_level_delegate.h"

 #include <functional>
+#include <vector>

 #include "base/bind.h"
 #include "base/strings/string_number_conversions.h"
--- a/brightray/browser/zoom_level_delegate.h
+++ b/brightray/browser/zoom_level_delegate.h
@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_BROWSER_ZOOM_LEVEL_DELEGATE_H_
 #define BRIGHTRAY_BROWSER_ZOOM_LEVEL_DELEGATE_H_

+#include <string>
+
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "components/prefs/pref_service.h"
--- a/brightray/common/content_client.cc
+++ b/brightray/common/content_client.cc
@ -4,10 +4,9 @@

 #include "common/content_client.h"

-#include "common/application_info.h"
-
 #include "base/strings/stringprintf.h"
 #include "base/strings/string_util.h"
+#include "common/application_info.h"
 #include "content/public/common/user_agent.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
--- a/brightray/common/content_client.h
+++ b/brightray/common/content_client.h
@ -5,6 +5,8 @@
 #ifndef BRIGHTRAY_COMMON_CONTENT_CLIENT_H_
 #define BRIGHTRAY_COMMON_CONTENT_CLIENT_H_

+#include <string>
+
 #include "base/compiler_specific.h"
 #include "content/public/common/content_client.h"

--- a/brightray/common/main_delegate.h
+++ b/brightray/common/main_delegate.h
@ -6,6 +6,7 @@
 #define BRIGHTRAY_COMMON_MAIN_DELEGATE_H_

 #include <memory>
+#include <string>

 #include "base/macros.h"
 #include "content/public/app/content_main_delegate.h"