Jeremy Apthorp
212d858bf4
set autoplay policy to no-user-gesture-required by default
2019-01-22 10:32:06 -08:00
Jeremy Apthorp
55d5b02f87
include glib.h in atom_main_delegate
...
it was complaining about 'undeclared identifier 'TRUE''
2019-01-22 10:32:06 -08:00
deepak1556
826f1cb90c
Move the base/sys_info* files to base/system/
...
https://chromium-review.googlesource.com/c/chromium/src/+/1327441
2019-01-22 10:32:05 -08:00
deepak1556
ed5a865efb
Update GetAccessibleName() in view::ImageView and view::Button
...
https://chromium-review.googlesource.com/c/chromium/src/+/1256308
2019-01-22 10:32:05 -08:00
deepak1556
90b6d13714
Remove menu_marker from MenuButton.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1324375
2019-01-22 10:32:05 -08:00
deepak1556
85333a5974
Move ViewsDelegate::NotifyAccessibilityEvent to an observer pattern
...
https://chromium-review.googlesource.com/c/chromium/src/+/1352265
2019-01-22 10:32:05 -08:00
deepak1556
5f941c5180
Remove CR_DEFINE_STATIC_LOCAL
...
https://bugs.chromium.org/p/chromium/issues/detail?id=893317
2019-01-22 10:32:05 -08:00
deepak1556
06a5ade3c6
fixup! Use strong ownership for attached inner WebContents
2019-01-22 10:32:05 -08:00
deepak1556
374406375b
Add interface and Mac implementation for responsiveness::NativeEventObserver.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1157235/
2019-01-22 10:32:05 -08:00
deepak1556
4089620729
fix: Initialize resource bundle for the browser process earlier
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
94246d428b
resource_coordinator_parts stub in BrowserProcessImpl
...
https://chromium-review.googlesource.com/c/1324134
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
3b88dd6ef7
tts was migrated to content
...
https://chromium-review.googlesource.com/c/1341154
https://chromium-review.googlesource.com/c/1351806
https://chromium-review.googlesource.com/c/1352055
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
2cbf3080d0
Make webkitRelativePath interoperable
...
https://chromium-review.googlesource.com/c/1325579
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
d0621db8fd
Remove ResourceContext::GetRequestContext since it's no longer used.
...
https://chromium-review.googlesource.com/c/1352035
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
6f9ff39728
CORS -> Cors
...
https://chromium-review.googlesource.com/c/1333018
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
a64cf5514f
move pdf_compositor off ServiceContext/ServiceTest
...
https://chromium-review.googlesource.com/c/1343506
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
93fbb6c092
remove name parameter from AllowIndexedDB
...
https://chromium-review.googlesource.com/c/1306914
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
600c3f2c2f
StoragePartition::ClearData no longer takes an OriginMatcher
...
https://chromium-review.googlesource.com/c/1162172
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
deff96a1b0
NativeWidgetMac::CreateNSWindow params changed
...
https://chromium-review.googlesource.com/c/1295251
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
b03daaebe4
ChildProcessData.{GetHandle() => GetProcess().GetHandle()}
...
https://chromium-review.googlesource.com/c/1298345
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
4ddd337a64
CurrentProcessInfo::CreationTime -> Process::Current().CreationTime()
...
https://chromium-review.googlesource.com/c/1280642
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
a64a0fa88e
remove ipc/struct_destructor_macros.h
...
https://chromium-review.googlesource.com/c/1261082
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
c0cf065c1a
REVIEW: Use strong ownership for attached inner WebContents
...
https://chromium-review.googlesource.com/c/1301843
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
96b2623887
replace base::AssertBlockingAllowed with base::ScopedBlockingCall
...
https://chromium-review.googlesource.com/c/1278540
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
e0d277e667
CopyNSImage was removed
...
https://chromium-review.googlesource.com/c/1333876
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
485bbd9ccb
ContentRulesetService -> RulesetService
...
https://chromium-review.googlesource.com/c/1294299
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
d228bdfb9e
gfx::NativeView is no longer NSView on mac
...
https://chromium-review.googlesource.com/c/1270343
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
70887ae21a
extra parameters to BrowserClient::HandleExternalProtocol
...
https://chromium-review.googlesource.com/c/1318976
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
96f9611cf4
GetCachePath replaced with GetGeneratedCodeCacheSettings
...
https://chromium-review.googlesource.com/c/1301973
https://chromium-review.googlesource.com/c/chromium/src/+/1213093
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
ef80cc3d56
base/sys_info.h -> base/system/sys_info.h
...
https://chromium-review.googlesource.com/c/1327441
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
0d9de7deaf
blink::WebReferrerPolicy -> network::mojom::ReferrerPolicy
...
https://chromium-review.googlesource.com/c/chromium/src/+/1212345
2019-01-22 10:32:04 -08:00
Jeremy Apthorp
96ca070c3a
less const in WebContents
...
https://chromium-review.googlesource.com/c/1349466
2019-01-22 10:32:03 -08:00
Jeremy Apthorp
8948e27ced
ScopedNestableTaskAllower in MessageLoopCurrent
...
https://chromium-review.googlesource.com/c/chromium/src/+/1020288
2019-01-22 10:32:03 -08:00
Jeremy Apthorp
30e5e993c1
HandleKeyboardEvent returns bool
...
https://chromium-review.googlesource.com/c/chromium/src/+/1262404
2019-01-22 10:32:03 -08:00
Jeremy Apthorp
fd7b49b32b
remove OnAreExperimentalCookieFeaturesEnabled
...
https://chromium-review.googlesource.com/c/1287209
2019-01-22 10:32:03 -08:00
Jeremy Apthorp
d36a6de25c
OnCanEnablePrivacyMode -> OnForcePrivacyMode
...
https://chromium-review.googlesource.com/c/1343051
2019-01-22 10:32:03 -08:00
Jeremy Apthorp
d01db5a656
migrate to non-deprecated v8 functions
...
https://bugs.chromium.org/p/v8/issues/detail?id=8238
https://bugs.chromium.org/p/v8/issues/detail?id=7295
https://chromium-review.googlesource.com/c/v8/v8/+/1352273
2019-01-22 10:32:03 -08:00
Electron Bot
cd25ddeb06
Bump v5.0.0-nightly.20190122
2019-01-22 08:55:08 -08:00
Milan Burda
7d71ad6f91
fix: takeHeapSnapshot() using public IPC channel for internal implementation ( #16480 )
2019-01-22 17:32:24 +09:00
Milan Burda
0e27f133d7
refactor: delete atom_api_renderer_ipc.h ( #16481 )
2019-01-21 22:31:37 -08:00
Milan Burda
b965e54efc
fix: <webview> not working with contextIsolation + sandbox ( #16469 )
2019-01-22 10:08:16 +09:00
Electron Bot
033efdcaa1
Bump v5.0.0-nightly.20190121
2019-01-21 15:28:16 -08:00
Cheng Zhao
ac65f38842
fix: prevent double-destroy of window ( #16472 )
2019-01-21 14:56:30 -08:00
Shelley Vohr
3ca87d205f
feat: make zoomLevel/zoomFactor sync ( #16410 )
...
* feat: make zoomLevel/zoomFactor sync
* update ts defs dep
2019-01-20 23:40:27 -08:00
Electron Bot
dacf7f8bdc
Revert "Bump v5.0.0-nightly.20190119"
...
This reverts commit 2cca0f9bb7
.
2019-01-19 21:14:06 -08:00
Electron Bot
2cca0f9bb7
Bump v5.0.0-nightly.20190119
2019-01-19 19:52:39 -08:00
Electron Bot
902c239fdf
Revert "Bump v5.0.0-nightly.20190118"
...
This reverts commit 9e6726f304
.
2019-01-18 15:21:39 -08:00
Electron Bot
9e6726f304
Bump v5.0.0-nightly.20190118
2019-01-18 15:21:39 -08:00
Electron Bot
329d45562b
Revert "Bump v5.0.0-nightly.20190118"
...
This reverts commit 83b44b735f
.
2019-01-18 14:12:13 -08:00
Electron Bot
83b44b735f
Bump v5.0.0-nightly.20190118
2019-01-18 14:12:01 -08:00
Electron Bot
7f4064af16
Revert "Bump v5.0.0-nightly.20190118"
...
This reverts commit ace11f9bc8
.
2019-01-18 13:42:51 -08:00
Electron Bot
ace11f9bc8
Bump v5.0.0-nightly.20190118
2019-01-18 13:42:51 -08:00
Electron Bot
cd91440e47
Revert "Bump v5.0.0-nightly.20190118"
...
This reverts commit 5e5c71e1d7
.
2019-01-18 12:46:16 -08:00
Electron Bot
5e5c71e1d7
Bump v5.0.0-nightly.20190118
2019-01-18 12:32:29 -08:00
Jeremy Apthorp
98d0daa2fd
chore: remove unused osfhandle hack ( #16305 )
2019-01-17 15:58:47 -08:00
Shelley Vohr
1f2b02c18f
feat: promisify protocol.isProtocolHandled() ( #16423 )
...
* feat: promisify protocol
* fix base::Bind and specs
* update documentation
* make callback-compatible
* async awaitify tests
2019-01-17 09:05:10 -08:00
Electron Bot
32d98851bc
Revert "Bump v5.0.0-nightly.20190116"
...
This reverts commit 82fc099602
.
2019-01-16 11:28:09 -08:00
Electron Bot
82fc099602
Bump v5.0.0-nightly.20190116
2019-01-16 11:04:22 -08:00
Shelley Vohr
8e2ab8b20b
refactor: promise_util promise creation ( #16401 )
...
* refactor: promise_util creation
* enter correct contexts on resolve/reject
* return Local in helper
* set context correctly
* forgot one
2019-01-15 09:54:59 -08:00
Shelley Vohr
0881fd6397
feat: split openExternal into sync and async ( #16176 )
...
* feat: split openExternal into sync and async
* v8::Locker => mate::Locker
* fix: enter js env when resolving promise
2019-01-14 20:35:21 -08:00
Milan Burda
52e257668d
fix: windowmenu did not show the window list on macOS ( #16387 )
2019-01-14 17:27:52 +01:00
Alex Garbutt
dcb670fa46
fix: emit IPC event in correct context if isolation and sandbox enabled ( #16352 )
...
* fix: emit IPC event in correct context if isolation and sandbox enabled
IPC events were not being delivered to renderer processes when both
`contextIsolation` and `sandbox` were enabled. This is because the
`AtomSandboxedRenderFrameObserver` class was incorrectly using the
`MainWorldScriptContext`, rather than conditionally selecting the
context based on if isolation was enabled.
Fixes #11922
2019-01-12 14:19:20 +01:00
Electron Bot
134792a594
Revert "Bump v5.0.0-nightly.20190111"
...
This reverts commit 71f542d8f6
.
2019-01-11 21:40:55 -08:00
Electron Bot
71f542d8f6
Bump v5.0.0-nightly.20190111
2019-01-11 21:18:40 -08:00
Robo
52fe92d02e
feat: Upgrade to Chromium 71.0.3578.98 ( #15966 )
2019-01-11 17:00:43 -08:00
Electron Bot
92ddfd0d4c
Revert "Bump v5.0.0-nightly.20190111"
...
This reverts commit c81c9ee2b4
.
2019-01-11 12:35:25 -08:00
Electron Bot
c81c9ee2b4
Bump v5.0.0-nightly.20190111
2019-01-11 11:40:15 -08:00
Shelley Vohr
fc169221be
Revert "Bump v5.0.0-nightly.20190111"
...
This reverts commit c43a61c576
.
2019-01-11 11:38:26 -08:00
Electron Bot
c43a61c576
Bump v5.0.0-nightly.20190111
2019-01-11 10:01:46 -08:00
Electron Bot
c4e4f085dd
Revert "Bump v5.0.0-nightly.20190111"
...
This reverts commit 088f936dab
.
2019-01-11 09:55:58 -08:00
Electron Bot
088f936dab
Bump v5.0.0-nightly.20190111
2019-01-11 09:54:46 -08:00
Alexey Kuzmin
3cb9aadb80
build: fix the build with enable_run_as_node disabled ( #15711 )
2019-01-11 08:02:06 -08:00
Charles Kerr
52852b963a
fix: beep on Ubuntu ( #16350 )
...
beeps on Linux are made by writing BEL to /dev/console,
which requires elevated permissions on Ubuntu. So if
opening /dev/console fails, fall back to /dev/tty.
2019-01-10 13:43:07 -08:00
Jeremy Apthorp
782825fc29
fix: return after handling Esc for fullscreen in WebContentsDelegate ( #16342 )
2019-01-10 11:03:48 -05:00
Electron Bot
0299328521
Bump v5.0.0-nightly.20190110
2019-01-10 07:59:58 -08:00
Electron Bot
72af4941f8
Bump v5.0.0-nightly.20190109
2019-01-09 21:43:29 -08:00
Michelle Tilley
744f737cba
fix: properly determine if WebContents is offscreen in WebContentsDelegate ( #16329 )
2019-01-09 09:55:45 -08:00
Electron Bot
17d2467932
Revert "Bump v5.0.0-nightly.20190108"
...
This reverts commit 241baf77f1
.
2019-01-08 20:46:56 -08:00
Electron Bot
241baf77f1
Bump v5.0.0-nightly.20190108
2019-01-08 18:11:20 -08:00
Electron Bot
45baaeaf2c
Revert "Bump v5.0.0-nightly.20190108"
...
This reverts commit 1fd7a4bfab
.
2019-01-08 16:30:25 -08:00
Electron Bot
1fd7a4bfab
Bump v5.0.0-nightly.20190108
2019-01-08 16:22:33 -08:00
Electron Bot
596c0a8672
Bump v5.0.0-nightly.20190107
2019-01-07 13:47:13 -08:00
Electron Bot
ff1c90b638
Revert "Bump v5.0.0-nightly.20190107"
...
This reverts commit 90f23c187f
.
2019-01-07 13:14:41 -08:00
Electron Bot
90f23c187f
Bump v5.0.0-nightly.20190107
2019-01-07 12:26:08 -08:00
Milan Burda
fade3eb679
chore: make "nodeIntegration" and "webviewTag" default to false ( #16235 )
2019-01-07 22:19:27 +03:00
Electron Bot
cdf4bfa68f
Revert "Bump v4.0.0-nightly.20190107"
...
This reverts commit f8614ab019
.
2019-01-07 09:17:17 -08:00
Electron Bot
f8614ab019
Bump v4.0.0-nightly.20190107
2019-01-07 09:17:04 -08:00
Milan Burda
6f117b8e0c
feat: add app.commandLine.hasSwitch() / app.commandLine.getSwitchValue() ( #16282 )
...
* feat: add app.commandLine.hasSwitch() / app.commandLine.getSwitchValue()
* add more tests
* refactor: move appendSwitch / appendArgument to command_line module
* replace AppendSwitchASCII with AppendSwitchNative
* remove castArgs
2019-01-07 07:48:27 -08:00
Shelley Vohr
de0e4735de
fix: error if a11y support changed before ready ( #16261 )
2019-01-04 10:20:06 -05:00
Shelley Vohr
876064036d
fix: don't register some shortcuts without accessibility ( #16125 )
...
Fixed crash on macOS when using globalShortcut for media keys when accessibility access is not granted.
2019-01-03 20:40:17 -08:00
Shelley Vohr
b57046e67d
feat: add mac support to systemPrefs.getColor() ( #16249 )
2019-01-03 16:17:07 -08:00
Shelley Vohr
03892153de
feat: expose systemPreferences.getSystemColor() ( #16248 )
2019-01-03 14:30:38 -08:00
Shelley Vohr
439ba5116f
feat: add mac support to systemPrefs.getAccentColor() ( #16251 )
...
* feat: add mac support to systemPrefs.getAccentColor()
* note 10.14 retriction
2019-01-03 13:24:55 -08:00
Milan Burda
3f1d22759a
refactor: use helpers for command-line parsing in renderer/init.js ( #16239 )
2019-01-03 11:22:34 -05:00
Shelley Vohr
baaeb7cece
chore: update deprecated LSGetApplicationForURL ( #16180 )
...
* chore: update deprecated LSGetApplicationForURL
* wrap with @available
2019-01-02 15:20:32 -08:00
Vladimir
5ae3d1a1b2
feat: add multi BrowserView support to BrowserWindow ( #16148 )
...
* feat: add multi BrowserView support to BrowserWindow
Add functions addBrowserView, removeBroserView, getBrowserViews to
BrowserWindow class. Existing API as setBrowserView and
getBrowserView code replaced to use new api inside.
* fix: for lint and osx compile errors
* fix: lint error in test code
* feat: add multi BrowserView support to BrowserWindow
Add functions addBrowserView, removeBroserView, getBrowserViews to
BrowserWindow class. Existing API as setBrowserView and
getBrowserView code replaced to use new api inside.
* fix: for lint and osx compile errors
* fix: lint error in test code
* fix: method to be accessible on mac api impl
* fix: missed function declarations for mac impl
* fix: use base class reset function
2018-12-22 10:49:26 +09:00
Zac Walker
51cfb5cff1
fix: extend tracing startRecording API to take a full tracing config ( #13914 )
...
This allows memory-infra to be traced correctly.
Fixes #12506 .
2018-12-20 15:11:17 +03:00
Milan Burda
547097b036
security: allow to block desktopCapturer.getSources() calls ( #15964 )
...
* security: allow to block desktopCapturer.getSources() calls
* return empty instead of error
* fix: release resources of DesktopCapturer on exit
2018-12-20 11:44:30 +09:00
Pedro Pontes
9c783f53ba
fix: do not allow the window to grab focus when tabbing / shift+tabbing ( #16042 )
...
* fix: do not allow the window to grab focus when tabbing / shift+tabbing
* test: add tests.
2018-12-18 23:44:51 -07:00
David Baker
cc85946f55
feat: Support response headers in File protocol handler ( #16098 )
...
* feat: Support response headers in File protocol handler
* bugfix: Null check headers value & fix tests
* refactor: Use non-deprecated FindKeyOfType
2018-12-18 23:17:02 -07:00
Shelley Vohr
a58d989b60
feat: expose app accessibility status api ( #16119 )
...
* feat: expose app accessibility status api
* fix prompt
2018-12-18 11:15:22 -05:00
Shelley Vohr
280f9bf49c
feat: allow immediate MacOS notifications ( #16060 )
...
* feat: allow immediate MacOS notifications
* fix args->GetNext
* update docs/api/system-preferences.md
Co-Authored-By: codebytere <codebytere@github.com>
* address feedback from @ckerr's review
2018-12-14 13:46:46 -08:00
Cheng Zhao
c7aa747891
chore: no need to expose Initialize of ipc module ( #16066 )
2018-12-14 08:01:29 -08:00
Cheng Zhao
8584c2f14b
fix: register webview in main world when using contextIsolation ( #16067 )
2018-12-14 15:38:35 +09:00
Cheng Zhao
897c6e93cb
chore: simplify main world setup of contextIsolation ( #16046 )
2018-12-13 16:25:12 -05:00
Simone Cattaneo
649633bbb7
fix: make 'setParentWindow' compatible under Windows ( #15775 )
2018-12-12 16:05:16 -08:00
Jeremy Apthorp
4250f84272
chore: enable v2 sandbox on mac ( #15647 )
2018-12-12 16:01:10 -08:00
Cheng Zhao
624ade2c25
fix: return pointer instead of pointer's content ( #16014 )
2018-12-11 12:45:55 -05:00
bughit
e044ada65c
fix: allow 2 threads for CreateIoCompletionPort on single-core to prevent busy looping ( #15975 )
...
* allow 2 threads for CreateIoCompletionPort on single-core
* use base::SysInfo::NumberOfProcessors instead of env var
* CHECK that uv_loop_ has not been used before replacing its iocp
2018-12-11 11:07:35 +09:00
Shelley Vohr
45a937df0a
fix: incorrect view ordering for customButtonsOnHover ( #15564 )
2018-12-10 11:05:30 -08:00
Cheng Zhao
db2fda1b6f
chore: make rpc-server reply to sender frame instead of the main frame ( #15973 )
...
* chore: make rpc-server reply to frame
* fix: check IsRenderFrameLive
2018-12-10 09:37:42 +09:00
Jeremy Apthorp
2845267c18
feat: support mixed-sandbox mode on linux ( #15870 )
2018-12-05 17:42:12 -08:00
Saswat Bhattacharya
d243a45173
feat: implement 'app-command' events for browser history navigation keys on Linux ( #15441 )
...
* Added mouse forward/back button support on Linux
* Added browser history navigation action bindings for Windows, Mac, and Linux keyboard
* Removed new `history-action` event and modified `app-command` to execute on such events
* Removed attempt at macOS support and added constants
* Clarified app-command documentation
* Reverted 'app-command' description change
* Format code
2018-12-05 09:35:59 -08:00
Shelley Vohr
3f15f51615
feat: promisify app.getFileIcon() ( #15742 )
2018-12-05 08:50:12 -08:00
Pedro Pontes
d5d1fa8290
fix: use appropriate site instance for cross-site nav's ( #15821 )
...
* fix: use Chromium's determined new site instance as candidate when navigating.
When navigating to a new address, consider using Chromium's determined site instance
for the new page as it should belong to an existing browsing instance when the
navigation was triggered by window.open().
fixes 8100.
* Revert "fix: use Chromium's determined new site instance as candidate when navigating."
This reverts commit eb95f935654a2c4d4457821297670836c10fdfd5.
* fix: delegate site instance creation back to content when sandboxed.
* fix: ensure site isolation is on
* test: adapt ut for cross-site navigation
* fix: register pending processes during a navigation.
* refactor: dont call loadURL for a window constructed from an existing webContents.
* test: add sandboxed affinity UT's.
* fix: check affinity before deciding if to force a new site instance.
* chore: adapt subsequent patch.
* refactor: constify logically const methods.
* fix: do not reuse site instances when navigation redirects cross-site.
* test: ensure localStorage accessible after x-site redirect.
* test: adapt localStorage acess denied UT for site isolation.
* fix: do not send render-view-deleted for speculative frames.
* chore: amend tests after rebase.
* test: add ut for webContents' render-view-deleted emission
* fix: introduce current-render-view-deleted for current RVH's deletions.
Revert render-view-deleted to being emitted with any RVH's deletion.
current-render-view-deleted is emitted only when the RVH being deleted
is the current one.
* refactor: style and comments fixed.
2018-12-05 17:03:39 +09:00
Shelley Vohr
c31629ad98
feat: add media access APIs for macOS Mojave ( #15624 )
2018-12-04 07:54:13 -08:00
Julien Isorce
1f55f1635f
feat: add support for DesktopCapturerSource.appIcon
...
Useful to get the icon of the application owning the source.
Only available for sources of type window, i.e. not for screen.
https://github.com/electron/electron/issues/14845
2018-12-04 15:42:49 +09:00
deepak1556
06a501d4a2
chore: use base::JoinString to concatenate vector
2018-12-03 20:07:44 +05:30
deepak1556
e1336d8453
chore: fix v8 deprecation warnings
2018-12-03 20:07:43 +05:30
deepak1556
5017db855c
fix: remove explicitly enabled SharedArrayBuffer feature flag
...
It is enabled by default now.
2018-12-03 20:07:43 +05:30
deepak1556
4eb0d497ab
chore: update printing.patch
2018-12-03 20:07:43 +05:30
Heilig Benedek
6deb7afb82
fix: reimplement FrameSubscriber with mojo, re-enable tests
2018-12-03 20:07:43 +05:30
Heilig Benedek
8727636fcc
fix: update and re-enable OSR
2018-12-03 20:07:42 +05:30
deepak1556
7a68d632e6
fix: use proxy lookup api of network context to resolve proxies
2018-12-03 20:07:42 +05:30
deepak1556
28cff4644e
fix: disable kSpareRendererForSitePerProcess feature
2018-12-03 20:07:42 +05:30
Samuel Attard
9d72bd4de4
chore: update CreateSkBitmapFromHICON usage for new API (no pointer)
...
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1234372
2018-12-03 20:07:42 +05:30
Samuel Attard
85fdacbc49
chore: replace ShowWithWindowState with Show inside native_window_views
...
The functionality was merged in as a parameter to the core Show method, default
for restore_bounds is an empty gfx::Rect()
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1174910
2018-12-03 20:07:42 +05:30
Samuel Attard
f8f091c250
chore: update GetLabelFrontList to be GetLabelStyle in menu model
...
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1186702
2018-12-03 20:07:41 +05:30
Shelley Vohr
c51fef1568
fix: use url::AddCORSEnabledScheme
2018-12-03 20:07:41 +05:30
Samuel Attard
92f50664d0
chore: fix linting
2018-12-03 20:07:41 +05:30
Samuel Attard
5798b152a6
chore: check GetAgent as GetTracingController() crashes if no agent is set
2018-12-03 20:07:41 +05:30
Samuel Attard
b1e69e1357
chore: update asar injection for new node internal module loader
2018-12-03 20:07:41 +05:30
Samuel Attard
9c36576ddd
chore: SetTracingController becomes SetAgent and corresponing contructions updated
2018-12-03 20:07:41 +05:30
deepak1556
f7f09b028b
Introduce explicit configuration to CertVerifier
...
https://chromium-review.googlesource.com/c/chromium/src/+/1122709
2018-12-03 20:07:41 +05:30
deepak1556
089001bd92
fix: update node inspector api usage
2018-12-03 20:07:41 +05:30
deepak1556
97aa7b8e68
Use CompletionOnceCallback in URLFetcherResponseWriter.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1155087
2018-12-03 20:07:41 +05:30
deepak1556
366ca47136
Change Value::BlobStorage to std::vector<uint8_t>
...
https://chromium-review.googlesource.com/c/chromium/src/+/1137819
2018-12-03 20:07:40 +05:30
deepak1556
d21e30f57b
Reorganize MediaStreamType enums
...
https://chromium-review.googlesource.com/c/chromium/src/+/1160000
2018-12-03 20:07:40 +05:30
deepak1556
d1da0aad7f
Make IsolateHolder aware of the isolate type.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1183194
2018-12-03 20:07:40 +05:30
deepak1556
321f87fe61
Complete TaskPriority::BACKGROUND->BEST_EFFORT mass rename
...
https://chromium-review.googlesource.com/c/chromium/src/+/1153461
2018-12-03 20:07:40 +05:30
deepak1556
6743b83786
Add notifications to UKM.xml.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1071649
2018-12-03 20:07:40 +05:30
deepak1556
f464b8c4c5
Respond for handling protocol commands async
...
https://chromium-review.googlesource.com/c/chromium/src/+/1139575
2018-12-03 20:07:40 +05:30
deepak1556
25d0a7b62a
Create a CodeCache per each storage_partition to store generated code
...
https://chromium-review.googlesource.com/c/chromium/src/+/1120179
2018-12-03 20:07:40 +05:30
deepak1556
b5b49c9ed0
FIXME: Remove SchemeRegistry::RegisterURLSchemeAsCORSEnabled
...
https://chromium-review.googlesource.com/c/chromium/src/+/1157364
2018-12-03 20:07:40 +05:30
deepak1556
ffeab383b5
Move NetworkConnectionTracker getter to network_service_instance.h
...
https://chromium-review.googlesource.com/1162888
2018-12-03 20:07:40 +05:30
deepak1556
0bd006a8eb
ProxyConfigDictionary: Use base::Value
...
https://chromium-review.googlesource.com/c/chromium/src/+/1150846
2018-12-03 20:07:40 +05:30
deepak1556
0f9dd3736c
Move CRLSets to being part of CertVerifier::Config
...
https://chromium-review.googlesource.com/c/chromium/src/+/1132706
2018-12-03 20:07:39 +05:30
deepak1556
6310d6c699
Flatten ResourceRequestBody data
...
https://chromium-review.googlesource.com/c/chromium/src/+/1114258
2018-12-03 20:07:39 +05:30
deepak1556
b2d53f1e1e
FIXME: word_start and medial_capital_as_word_start are removed from WebFindOptions
...
https://chromium-review.googlesource.com/c/chromium/src/+/1175645
2018-12-03 20:07:39 +05:30
deepak1556
4179cedf37
Change SubscribePermissionStatusChange to use a RFH to query permissions
...
https://chromium-review.googlesource.com/c/chromium/src/+/979735
2018-12-03 20:07:39 +05:30
deepak1556
66349261a5
fix: update to per context v8::Script::Compile api
2018-12-03 20:07:39 +05:30
deepak1556
c1f32afeeb
Use CompletionOnceCallback in URLRequestSimpleJob.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1155089
2018-12-03 20:07:39 +05:30
deepak1556
8f1fa4177e
Fix invalid handle errors found with App Verifier
...
https://chromium-review.googlesource.com/c/chromium/src/+/1145767
2018-12-03 20:07:39 +05:30
deepak1556
535d264497
fix: [UI] Resolve method conflict between MenuModel, SimpleMenuModel::Delegate
...
https://chromium-review.googlesource.com/c/chromium/src/+/1230581
2018-12-03 20:07:39 +05:30
deepak1556
2eedcde914
fix: Remove DEFINE_WEB_CONTENTS_USER_DATA_KEY in //electron.
...
https://bugs.chromium.org/p/chromium/issues/detail?id=589840
2018-12-03 20:07:39 +05:30
Samuel Attard
6b4b7c9831
chore: make BrowserObserver a CheckedObserver
...
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1053338
2018-12-03 20:07:38 +05:30
Samuel Attard
b6aae790cf
fixme: C70 removed DidReceiveCompositorFrame
...
(OSR relatied)
refs: 1de1ca906a
cc @brenca
2018-12-03 20:07:38 +05:30
Samuel Attard
74d1685523
chore: fix ShouldFork impl, referrer stripping has been removed
...
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1124329
2018-12-03 20:07:38 +05:30
Samuel Attard
c9007557e5
chore: post_task and friends now live under base/task
...
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1161088
2018-12-03 20:07:38 +05:30
Samuel Attard
c4cb90ab85
chore: replace PreContentInitialization with PreCreateMainMessageLoop
2018-12-03 20:07:38 +05:30
Sylvester Keil
2e91bf1e15
Fix GTK menubar item color ( #15878 )
...
Use menubar item color (not menu item color).
Closes #15194
2018-11-30 09:28:45 -08:00
Jeremy Apthorp
83d951db7e
chore: DCHECK that events are only emitted on the UI thread ( #15873 )
...
* chore: DCHECK that events are only emitted on the UI thread
* move dcheck to EmitWithEvent
2018-11-30 18:48:27 +09:00
Andy Dill
8cca1c987b
fix: move NativeWindow tracking to OSR WCV ( #15585 )
...
* fix: move NativeWindow tracking to OSR WCV
* fix oops
2018-11-29 21:25:02 -08:00
Heilig Benedek
78b88a70bb
fix: backport patch that ensures that cookie store is always created ( #15836 )
...
* fix: backport patch that ensures that cookie store is always created
* fix: disable cookie encryption
* fix: flush the cookie store when NetworkContext shuts down
* test: add test for cookie store persistance
* Update patches/common/chromium/ensure_cookie_store.patch
Co-Authored-By: brenca <benecene@gmail.com>
* Update patches/common/chromium/ensure_cookie_store.patch
Co-Authored-By: brenca <benecene@gmail.com>
2018-11-29 10:51:13 -08:00
Shelley Vohr
165d168ee5
fix: ignore unused freopen result ( #15884 )
2018-11-29 09:36:08 -08:00
Jeremy Apthorp
62eb077f29
refactor: simplify logic for enabling stack dumping ( #15872 )
...
ref #15785
2018-11-28 22:23:41 -08:00
Michelle Tilley
8f04def7b2
fix: prevent bluetooth device list from growing without bound ( #15805 )
...
* fix: include bluetooth strings in build
* fix: prevent bluetooth device list from growing without bound
2018-11-28 11:36:00 -05:00
Andy Dill
55808dffcd
fix: osr windows respect display scale factor ( #15733 )
2018-11-28 11:16:03 -05:00
Milan Burda
07f8f5f95a
refactor: eliminate duplicate code exposing process APIs ( #15824 )
2018-11-28 11:08:17 -05:00
Nitish Sakhawalkar
9890d1e251
feat: Implement process.getProcessMemoryInfo to get the process memory usage ( #14847 )
...
* feat: Implement process.getMemoryFootprint to get the process memory usage
* Add spec
* fix: must enter node env in callback
* Update function call
* Update spec
* Update API data
* update spec
* Update include
* update test for shared bytes
* Update atom/common/api/atom_bindings.cc
Co-Authored-By: nitsakh <nitsakh@icloud.com>
* Update atom/common/api/atom_bindings.cc
Co-Authored-By: nitsakh <nitsakh@icloud.com>
* Update API
* Update the callback isolate
* Update to work after app ready
* Update docs
* Update docs/api/process.md
Co-Authored-By: nitsakh <nitsakh@icloud.com>
* Update docs/api/process.md
Co-Authored-By: nitsakh <nitsakh@icloud.com>
* Fix crash
2018-11-28 17:57:53 +09:00
Shelley Vohr
41c2685204
feat: promisify win.capturePage() ( #15743 )
...
* feat: promisify win.capturePage
* mark optional arg correctly
* Add to breaking changes doc
* properly deprecate win.capturePage
* remove change from api-contract
* document both callback and promise versions
* address docs feedback
* update promisification progress doc
2018-11-27 23:50:53 -05:00
Shelley Vohr
73fbb69c50
chore: change return type of platform_util::SetLoginItemEnabled ( #15854 )
2018-11-27 23:16:53 -05:00
Milan Burda
81e00d8e56
chore: fix V8 deprecation warnings ( #15842 )
2018-11-27 16:42:02 -05:00
Milan Burda
d63a848011
feat: add activate option to webContents.openDevTools ( #13852 )
2018-11-27 18:34:44 +09:00
Cheng Zhao
d1f0d6c184
fix: remove event monitor before destroying window
2018-11-27 11:10:07 +09:00
Jeremy Apthorp
23de301955
chore: remove scoped_clipboard_writer.patch ( #15843 )
...
replace with already-exposed APIs
2018-11-27 09:51:26 +09:00
Simone Cattaneo
6f116eeaa4
fix: improved event flow management related to 'will-resize' event on Windows ( #15695 )
2018-11-26 12:26:48 -08:00
Heilig Benedek
0242818f39
feat: add registerAccelerator flag to allow menu items to optionally skip accelerator registration ( #15723 )
...
* feat: add registerAccelerator flag to allow menu items to skip registration
* docs: add docs for registerAccelerator
* docs: re-add accidentally removed line
2018-11-26 10:43:55 -08:00
Jeremy Apthorp
a8a881c8db
chore: restore //url dchecks ( #15637 )
2018-11-22 09:02:52 -08:00
Robo
9e8b26cc4e
fix: bypass CORB when web security is disabled ( #15737 )
...
* fix: extend content layer hook to bypass corb when web security is disabled.
* chore: add patch to disable CORB
2018-11-21 14:10:05 -06:00
Heilig Benedek
5db8197a5d
fix: schedule a paint after browserview's background is set ( #15784 )
2018-11-21 13:04:10 -06:00
Samuel Attard
0b0a17ff91
fix: load the chrome.* API on chrome-extension pages in sandbox mode ( #15563 )
...
With mixed sandbox enabled we need to load the chrome.* APIs in the
sandbox init.js so that chrome extensions load correctly.
This mirrors the equivilant impl in `atom_renderer_client.cc`
Fixes #15561
2018-11-21 12:56:58 -05:00
malern
a68e3371f3
fix: remove duplicated status code ( #15707 )
...
Removed the hardcoded status code from the protocol response as the real status code is appended immediately after.
2018-11-21 10:47:05 -06:00
Cheng Zhao
47bf8e1bb3
view: add ResizeArea class ( #15752 )
2018-11-21 22:39:59 +09:00
Charles Kerr
40619efb3b
chore: remove FileChooser AddExtensionForFilename ( #15510 )
2018-11-20 16:24:39 -05:00
Ondřej Záruba
de05ff894b
feat: Add app.getLocaleCountryCode() method for region detection ( #15035 )
...
* Add method to get system´s user region
* Fix linter
* Remove auto types
* Improved detection for POSIX
* Change name, add specs, minor fixes
* Remove left overs
* Fix locale test
* Fix Linux test
* Coding style fixes
* Fix docs
* Add test excaption for Linux
* fix spelling
* Polishing
2018-11-20 15:33:23 -05:00
Pedro Pontes
57d2ae1aec
revert: "fix: window.open site instance should belong to same browsing instance ( #15216 )" ( #15757 )
...
This reverts commit 8f35198bfb
.
2018-11-20 21:28:26 +01:00
Jeremy Apthorp
90d1c0b2b6
chore: don't explicitly destroy asar archives ( #15734 )
2018-11-19 13:12:41 -08:00
Andrzej Szombierski
51cb36fa9b
fix: ensure that file descriptors 0/1/2 are opened at startup ( #15555 )
...
* fix: ensure that file descriptors 0/1/2 are opened at startup
This fixes an issue where the gpu subprocess was writing messages to a
random pipe or socket. The standard file desciptors are closed in
chromium's subprocesses because of an unfortunate interaction with
libuv's tty handling code leaving them with the FD_CLOEXEC flag.
* style: fix lint warnings
2018-11-19 11:53:55 -05:00
Simone Cattaneo
b97d7e7ecd
fix: On close trying to remove observer from an empty collection leads to an access violation ( #15739 )
2018-11-19 11:47:04 -05:00
Cheng Zhao
e12c0dcf66
Merge pull request #15618 from electron/system_netwok_context
...
fix: create system network context for global requests
2018-11-19 11:25:34 +09:00
Jeremy Apthorp
20116d7f05
fix: always disable setuid sandbox on linux ( #15722 )
2018-11-15 13:27:56 -08:00
Jeremy Apthorp
0642be296d
fix: crash in sandbox on linux when getting execPath ( #15701 )
2018-11-15 12:59:01 -08:00
Shelley Vohr
511dc9a80b
feat: add numpad accelerator strings ( #15689 )
2018-11-14 14:02:18 -05:00
deepak1556
7e1168c518
fix: return system shared url loader for content layer
2018-11-14 12:42:24 +05:30
deepak1556
57356036db
fix: initialize system network context from IOThread
2018-11-14 12:42:24 +05:30
deepak1556
666a106fa8
refactor: move IOThread and NetLog ownership to g_browser_process
2018-11-14 12:42:24 +05:30
deepak1556
414dcfcd07
fix: create system network context for global requests
...
Global requests currently includes DNS over HTTPS requests,
certain cert validation requests (OCSP, AIA, etc) on some platforms
and geolocation requests.
2018-11-14 12:42:24 +05:30
Shelley Vohr
787dbbe610
feat: add about panel customization on linux ( #15658 )
2018-11-13 17:12:24 -05:00
Pedro Pontes
8f35198bfb
fix: window.open site instance should belong to same browsing instance ( #15216 )
2018-11-12 22:01:43 +01:00
Shelley Vohr
a54dd1085a
feat: expose showAboutPanel for MacOS ( #15674 )
2018-11-11 22:52:27 -05:00
Samuel Attard
1cf28e8b75
build: auto-gen libnotify_loader.cc ( #15648 )
2018-11-10 14:21:40 -05:00
Shelley Vohr
9fd98bb27b
refactor: no longer require submenu for services menuitem ( #15656 )
2018-11-10 12:47:55 -05:00
Nitish Sakhawalkar
025aa49f67
fix: NSWindow crash happening on macos 10.9 ( #15660 )
2018-11-10 14:53:35 +01:00
Nitish Sakhawalkar
5994bf6745
fix: Menu accelerators not working ( #15094 )
...
This change fixes the regression in the menu accelerators working in linux, on some environments.
2018-11-09 13:54:16 -08:00
Samuel Attard
e7b2b93cee
chore: re-enable DCHECK in node_debugger ( #15649 )
2018-11-09 14:44:31 +11:00
Robo
82322968a3
refactor: printing implementation ( #15143 )
...
* refactor: basic printing
* move build files to chromium_src/BUILD.gn
* remove dependency on chrome prerender sources
* spec: move printing specs behind feature flag
* build: register pdf compositor service
2018-11-09 14:42:34 +11:00
Samuel Attard
9aed2a465f
fix: send NSView* as the response to getNativeWindowHandle() instead of a null handle ( #15521 )
2018-11-08 09:03:19 -08:00
Cheng Zhao
746beb0d8b
fix: destroy WebContents synchronously on shutdown ( #15541 )
2018-11-08 07:57:28 -08:00
Jeremy Apthorp
7e0e12b8a3
fix: match Chrome's font fallback behavior ( #15486 )
...
* fix: match Chrome's font fallback behavior
Fixes #15481
* add a cache
* add test
* another test
* fix tests
* arial -> dejavu sans on linux apparently?
2018-11-08 10:51:51 -04:00
Heilig Benedek
ca2d74e118
feat: add methods to allow customization of save dialog during will-download event ( #15497 )
...
* feat: add method to DownloadItem that allows customization of dialog options
* docs: add docs for get/setSaveDialogOptions
* add missing copy constructor for DialogSettings on mac and linux
* fix: don't filter dialog options for mas build, don't return properties
* test: add test for get/setSaveDialogOptions
* fix: remove openDevtools added for debugging
* test: fix failing test because of new event parameter
* docs: use SaveDialogOptions instead of Object
2018-11-08 10:51:06 -04:00
Michelle Tilley
2a8e8a0603
fix: make certain values on process
read-only ( #15628 )
...
* docs: Add 'worker' as a possible value for `process.type`
* fix: make certain properties on `process` read only:
* `mas`
* `windowsStore`
* `versions.electron`
* `versions.chrome`
* `type`
* `pid`
* `sandboxed`
2018-11-08 10:28:06 -04:00
Shelley Vohr
e9ba26f50e
feat: allow registering multiple shortcuts ( #15542 )
...
This PR allows for multiple global shortcuts to be registered such that triggering any of them calls the same callback.
2018-11-07 09:40:38 -08:00
Jeremy Apthorp
934a7fc118
refactor: don't use AppIndicatorIcon directly ( #15536 )
2018-11-06 11:00:37 -08:00
Shelley Vohr
ece4c81c1a
fix: hiddenInset titleBar console spam ( #15576 )
2018-11-05 21:02:46 -08:00
Shelley Vohr
dcd2bf451d
refactor: remove 10.9 specific menu code ( #15578 )
2018-11-05 20:42:19 -08:00
Jeremy Apthorp
77f69cbe08
chore: remove unused use_transparent_window.patch ( #15534 )
...
Unneeded since 6f2f761df3 (diff-0bbbec38254ebb1146b15c15277c6aa1)
2018-11-05 13:19:21 -08:00
Shelley Vohr
c60745b8a3
fix: use NSURL path for receipt url ( #15355 )
2018-11-05 09:49:51 -08:00
Milan Burda
a19d20cfb8
refactor: more cleanup of chromium_src ( #15424 )
2018-11-05 10:29:33 -04:00
Samuel Attard
7f73240fd5
chore: use chromes auto generated definition of CHROME_VERSION_STRING ( #15275 )
2018-11-02 23:32:33 +11:00
Charles Kerr
feb31d088b
fix: honor properties.showHiddenFiles on Linux ( #15503 )
...
Previously the code only set the GtkFileChooser's property if `properties.showHiddenFiles` was set.
This PR unconditionally sets the GtkFileChooser's property so that hidden files will be hidden if `properties.showHiddenFiles` was not set.
2018-10-31 16:13:01 -05:00
Shelley Vohr
b2e1a93177
refactor: remove hardcoded google api key ( #15478 )
...
* refactor: remove hardcoded Google API key
* address changes from review
2018-10-31 07:49:44 -07:00
Heilig Benedek
6d2a088be9
feat: detect high contrast color mode ( #15493 )
...
* feat: add event and method to detect high contrast color mode
* docs: add docs for isHighContrastColorScheme and high-contrast-color-scheme-changed
* refactor: correct type of contrast
2018-10-31 10:22:18 -04:00
Heilig Benedek
aa6f7a5d9f
fix: don't append Shift modifier text twice to accelerators ( #15400 )
...
* fix: don't append Shift modifier text twice to accelerators
* style: use the new way of creating patches
* test: add menu item accelerator display tests
* fix: allocate accelerator on the stack
* fix: adjust tests to match expected behavior on mac
2018-10-31 10:13:44 -04:00
Heilig Benedek
894ae1b3f5
refactor: Improve accessibility of menus ( #15302 )
...
* refactor: improve menubar keyboard accessibility
* fix: create a temporary widget for tray icon context menu
* fix: focus menu bar with Alt when autohide is off
* fix: make menu bar focus work more like the native menus
* fix: only focus menu bar if it's not already focused
* fix: track accelerator registration to avoid duplicates
* docs: add docs for & notation in app menu item names
* fix: only try to activate accelerator if it's registered
* fix: add friend to monitor window focus change
* style: add <memory> include
2018-10-29 13:08:46 -05:00
Milan Burda
f921df7ad1
chore: move spellcheck out of chromium_src ( #15407 )
2018-10-26 10:34:57 -07:00
Shelley Vohr
bea4de9262
fix: use gio as default linux trash impl ( #15399 )
...
* fix: use gio as default linux trash impl
* doc: add ELECTRON_TRASH env var
2018-10-26 08:36:56 -07:00
Shelley Vohr
d21d83cfc8
fix: folder open not working in devtools ( #15387 )
2018-10-25 08:36:48 -07:00
Milan Burda
1f3a89197c
chore: bump minimum supported macOS version to 10.10 ( #15357 )
2018-10-25 10:59:42 +02:00
Cheng Zhao
2f3a8ecd42
fix: child window with nativeWindowOpen should disable node integration ( #15213 )
...
* fix: child window with nativeWindowOpen should disable node integration
* Revert "fix: do not enable node integration in child window if not enabled (#15076 )"
This reverts commit 0252d7686c
.
This patch is not needed anymore since we are force disabling node integration
for child windows.
2018-10-25 15:31:07 +09:00
Andy Dill
7a23980f4b
fix: set NSResizableWindowMask at init time ( #15106 )
2018-10-25 10:34:11 +09:00
Islam Sharabash
3b6f0d83e1
fix: allow stream protocols to return headers with multiple values ( #14887 )
...
* fix: allow stream protocols to return headers with multiple values
This allows stream protocols to return headers with multiple values as
an array of values.
Fixes https://github.com/electron/electron/issues/14778
* Prefer ConvertFromV8
* Cleanup header conversion
1. Deduplicate the code by using a lambda
2. Remove duplicate calls to headers->Get(key)
* Fix broken test
Headers with multiple values are now being converted correctly, this
test asserted the wrong behavior.
2018-10-25 11:34:20 +11:00
Milan Burda
8ba271efba
refactor: eliminate brightray ( #15240 )
2018-10-24 12:49:10 +02:00
Jeremy Apthorp
1d8ab03146
refactor: use public WakeLock interface ( #15351 )
...
* refactor: use public WakeLock interface
* remove power_save_blocker visibility patch
2018-10-23 22:12:58 -07:00
Milan Burda
465dee2c33
refactor: eliminate brightray::BrowserMainParts ( #15336 )
2018-10-23 13:15:55 -07:00
Charles Kerr
869e0ab14d
fix: honor dialog.showMessageBox()'s Icon argument on Linux ( #15326 )
...
* Don't call gtk_widget_show_all() on popup dialog.
Fixes #15317 .
Notes: Fixed incorrect display of some GtkMessageDialog icons.
The issue is caused because GtkMessageDialog contains an icon widget
which is not shown when there's no associated icon. Our call to
`gtk_widget_show_all()` overrides this, showing the uninitialized
icon widget.
This PR fixes the issue by calling `gtk_widget_show()` where needed
and removing use of `gtk_widget_show_all()` in the message dialog.
* use gtk_dialog_set_default_response() for default
* fix: support icons on gtk+ messageboxes.
2018-10-23 12:44:47 -05:00
Cheng Zhao
260778e0fb
feat: add MdTextButton to View APIs ( #15328 )
...
* view: make button focusable by default
* view: add MdTextButton
* view: add common methods to LabelButton
2018-10-23 10:57:13 -04:00
Nitish Sakhawalkar
ca4b4709e5
fix: Native window close crash ( #15327 )
2018-10-23 10:35:00 -04:00
Milan Burda
809bd3757b
refactor: eliminate brightray::MainDelegate ( #15333 )
2018-10-23 14:16:13 +02:00
Milan Burda
fbbb704146
refactor: eliminate brightray::BrowserClient ( #15320 )
2018-10-23 10:45:41 +02:00
Michelle Tilley
13247e592b
fix: correct reversed logic in NativeWindowMac::SetEnabled ( #15257 )
2018-10-22 13:01:45 -07:00
Cheng Zhao
cb9be091aa
refactor: remove potential double free when managing WebContents ( #15280 )
...
* refactor: remove -new-contents-created event
Chromium expects us to take ownership of WebContents in AddNewContents,
we should not create V8 wrapper in WebContentsCreated, otherwise we
would have WebContents being managed by 2 unique_ptr at the same time.
* refactor: make CreateAndTake take unique_ptr
2018-10-22 13:02:25 -05:00
Milan Burda
e8e7edf017
refactor: eliminate brightray::ContentClient ( #15303 )
2018-10-22 19:04:23 +02:00
Milan Burda
6d844a0b67
refactor: move media/net from brightray to atom ( #15288 )
2018-10-19 14:51:43 -04:00
Milan Burda
6f3c46cc7e
refactor: move devtools from brightray to atom ( #15234 )
2018-10-19 15:50:30 +02:00
Cheng Zhao
94aa0762f0
refactor: remove WebContents::CreateFrom ( #15241 )
2018-10-19 17:52:07 +09:00
Samuel Attard
8bc0c343fa
fix: convert wstring to string on windows in node_bindings ( #15266 )
2018-10-19 13:11:43 +11:00
Andy Dill
37f2113032
feat: expose setBackgroundThrottling api ( #15104 )
2018-10-19 11:32:22 +11:00
Shelley Vohr
a0b9d47d5e
fix: enable NODE_OPTIONS env var ( #15158 )
2018-10-19 10:57:28 +11:00
Michelle Tilley
51f3fb9bde
fix: correctly enable and disable windows on Windows and Linux ( #15184 )
2018-10-18 14:23:40 -07:00