Shelley Vohr
b05932310b
replace base::MakeUnique with std::make_unique
2018-04-12 08:48:32 -04:00
Cheng Zhao
d706a30849
Fix crash when releasing window
2018-04-11 15:12:53 +09:00
Cheng Zhao
2b5bde4071
InstallView is no longer needed
2018-04-11 15:12:53 +09:00
Cheng Zhao
5a95aaaa54
kVibrancyType should be read in InitFromOptions
2018-04-11 15:12:53 +09:00
Cheng Zhao
cfd8ea8eb0
mac: Correctly unload previous content view
2018-04-11 15:12:53 +09:00
Cheng Zhao
56735d4ff5
Add NativeWindow::SetContentView
2018-04-11 15:12:53 +09:00
Cheng Zhao
13473ee138
web_view_ => content_view_
2018-04-11 15:12:53 +09:00
Cheng Zhao
97e8800677
Remove web_contents from NativeWindow's constructor
2018-04-11 15:12:53 +09:00
Nitish Sakhawalkar
6fc819dae1
Fix transparency in capturePage ( #12561 )
...
* Fix transparent window capture. Transparency is preserved and not converted to black pixels anymore
* Add test to make sure aplha channel exists in captured image
2018-04-10 19:07:15 +09:00
Andreas
6b5e09478c
Mouse forward on macOS ( #12281 )
...
* Accept mouse events according to the forward parameter on macOS.
* Update BrowserWindow docs: mouse forward is available on macOS
2018-04-09 19:35:05 +09:00
Cheng Zhao
41134f52d9
Fix memory leaks in file_dialog_mac.mm
2018-04-09 16:51:25 +09:00
Yuya Ochiai
2131dc839a
Show file filter name for accessory view of file dialog
...
- Respect filters option of dialog.showOpenDialog() and
dialog.showSaveDialog(). (#10335 )
- Show "All Files" for <input> apart from "accept" attribute. (#11456 )
2018-04-09 16:50:21 +09:00
OJ Kwon
4c51c03779
feat(performspellcheck): queue spell check request asynchronously ( #12112 )
...
* feat(spellcheckrequest): implement spellcheckrequest
* feat(performspellcheck): queue spell check request asynchronously
2018-04-09 15:18:50 +09:00
Andrew MacDonald
6bfb122cd1
Add a display_id parameter to the desktopCapturer API. ( #12417 )
...
* Add a screen_api_id parameter to the desktopCapturer API.
When using the DirectX capturer on Windows, there was previously no way
to associate desktopCapturer/getUserMedia and electron.screen API
screens. This new parameter provides the association.
* Fix non-Windows build.
* Fix Mac.
* Fix Mac harder.
* JS lint
* clang-format C++ code.
* IWYU
* display_id, Linux comment, better test
* lint
* Fix tests on Linux.
* Add display_id documentation.
2018-04-09 14:43:35 +09:00
Robo
65e8199a93
Enable plznavigate aka browser side navigation ( #12535 )
...
* enable plznavigate code path
* AtomBrowserClient::GetGeolocationApiKey returns the right default
* use IsLoadingToDifferentDocument to identify top level navigation in mainFrame
* use candidate site instance when available
* spec: don't test httpReferrer option for file origin
* update libcc ref
* affinity: only group same site in this mode
* plznavigate: don't emit did-get-response-details event for blob scheme
2018-04-06 16:22:52 +09:00
Charles Kerr
f8b8dc1494
Simplify views/menu_bar focus management ( #12536 )
...
* Simplify views/menu_bar focus management
* Make the linter happy
* Remove NativeWindowView focus manager listener API
* remove unnecessary change
* MenuBar ctor now takes a views::View
2018-04-05 21:53:08 -05:00
Charles Kerr
cad8eed6e4
Use ui:view's Activate() on Linux ( #12539 )
...
In NativeWindowViews, we started rolling our own _NET_ACTIVE_WINDOW
event in June 2016 to raise windows because Chromium's implementation
wasn't working as expected. (See commit 32b692b6
)
I'm not seeing this behavior in our current version of libcc,
so I wonder if this workaround is still needed?
2018-04-05 22:39:53 -04:00
Jeremy Apthorp
f0d08f4da1
Propagate referrer to new windows ( #12397 )
...
* Propagate referrer to new windows
Fixes #9205
* Rearrange -new-window event arguments for backwards-compatibility
* Plumb referrer policy through guest-window-manager
* Document the Referrer structure and its uses
* Add tests for referrer in new windows
* Docs nits
2018-04-05 18:13:24 -05:00
Heilig Benedek
a14ebc80d2
Disable chromium's redraw locking on Windows when DWM is disabled ( #12501 )
...
* disable redraw locking on windows
* update libcc ref
2018-04-05 15:55:26 +09:00
Adrien Fery
5486a65702
Improve in-app purchase for MacOS ( #12464 )
...
* Add methods to finish transactions
* Add a method to get the product descriptions from the App Store
* Improve the documentation of a transaction structure
* Add a tutorial for In App Purchase
* Fix typo in In-App Purchase tutorial
* Fix style of In-App Purchase files
* Fix In-App-Purchase product structure conversion in amr64
* Fix code style in In-App Purchase tutorial documentation
* Fix typos in In-App Purchase documentation
* Fix typo in In-App Purchase spec
* Slight style fixes
2018-04-05 15:33:13 +09:00
Heilig Benedek
52b1065b3b
Focus webview directly in offscreen mode ( #12507 )
2018-04-05 15:14:42 +09:00
Robo
c1404ff2c1
vendor: Update native mate to fix v8 DCHECK crash ( #12534 )
...
* update native_mate ref
* Remove MarkHighMemoryUsage api
2018-04-05 00:47:18 -05:00
Cheng Zhao
c75dd93b92
Move AutofillPopup from NativeWindow to WebContents ( #12514 )
2018-04-05 09:53:51 +09:00
Aleš Pergl
3a45d541f3
Expose IsOffScreen method always to JS. ( #12530 )
2018-04-04 12:19:08 -05:00
MadfishDT
200388ff96
add moveTop API to move window z-oder to top for win32, mac ( #12485 )
...
* add moveTop API to move window z-oder to top for win32, mac
* BrowserWindow::MoveTop SetMethod bug fix
2018-04-03 08:04:32 -05:00
Cheng Zhao
8fc5c6c862
Refactor NativeWindow (Part 3): Remove is_offscreen_dummy from NativeWindow ( #12503 )
...
* Don't use is_offscreen_dummy in MessageBox
* Don't use is_offscreen_dummy in DownloadManagerDelegate
* Don't use is_offscreen_dummy in CommonWebContentsDelegate
* Remove is_offscreen_dummy from NativeWindow
2018-04-03 12:19:35 +09:00
Jeremy Apthorp
a7352e57d5
WebFrame.setVisualZoomLevelLimits sets user-agent scale constraints ( #12488 )
...
Fixes #11216 .
2018-04-02 18:20:13 -04:00
Nitish Sakhawalkar
fbff355742
Support for navigator.languages ( #12419 )
2018-04-02 12:47:00 +09:00
Robo
171230e45d
Cleanup destruction of URLRequestContextGetter ( #12305 )
...
- Add Leak detector
- Indicate shutdown of request context from Browser Context
- Change stored references to URLRequestContextGetter to use BrowserContext
- Destroy session properties explicitly
2018-03-30 08:24:55 -05:00
Zhuo Lu
c50a460ce6
Do not block main process for async dialog ( #12404 )
2018-03-22 08:57:33 -04:00
Clément Beffa
642f5a84d4
Workspace notifications support on macOS ( #12093 )
2018-03-22 18:41:03 +09:00
Nitish Sakhawalkar
9d1527b1df
Fix context menu for sandbox devtools ( #11933 )
2018-03-22 16:15:57 +09:00
Cheng Zhao
05fcec829e
Use Clone explicitly instead of MergeDictionary
2018-03-22 15:29:20 +09:00
Cheng Zhao
0abbedcdae
Fix error caused by refactor
2018-03-22 15:21:56 +09:00
Cheng Zhao
6df2326a30
Cleanup the static methods of WebContentsPreferences
...
The static methods are totally unnecessary, and it makes code harder to
understand since we are using different ways to do the same things.
2018-03-22 15:21:56 +09:00
Cheng Zhao
001275339b
Hide WebContentPreferences::GetWebContentsFromProcessID from public
2018-03-22 15:20:03 +09:00
Cheng Zhao
3d47a8a2fd
Remove the static getter methods from WebContentsPreferences
2018-03-22 15:20:03 +09:00
Cheng Zhao
887bc12350
Add WebContentsPreferences::From that checks parameter
2018-03-22 15:16:26 +09:00
Cheng Zhao
9772777919
web_prefrences() => dict()
...
Having property name being the same with class name is making code
harder to understand, and dict is much shorter.
2018-03-22 15:15:30 +09:00
Shelley Vohr
05dc04dacc
don't check darkmode for drawStatusBarBackgroundInRect ( #12395 )
2018-03-21 19:03:57 -04:00
Charles Kerr
0d7becff87
Use the appname as the tray icon's default tooltip ( #12388 )
...
This makes an upstream DCHECK happy in AppIndicatorIcon::SetToolTip.
Empty tooltip strings are discouraged, as discussed in commit log
b6c510aa543193337041517c2d70113840189b06.
Fixes #12386 .
2018-03-21 12:15:30 -05:00
John Kleinschmidt
060b592fc8
Merge pull request #12348 from electron/fix-browser-view-draggable-region
...
Update draggable regions when changing BrowserView
2018-03-20 10:40:27 -04:00
Cheng Zhao
2e94a730cc
Isolate the code using content::WebContentsImpl
2018-03-20 10:13:17 +03:00
Gellert Hegyi
a9cdd6614a
fixes class name
2018-03-20 10:13:17 +03:00
Gellert Hegyi
0ad8815bbc
fixes offscreen rendering issues
2018-03-20 10:13:17 +03:00
Cheng Zhao
d4969783d7
Avoid including web_contents_impl.h
...
This can fix the build error caused by duplicate typedefs.
2018-03-20 10:13:17 +03:00
deepak1556
e24c0dda5d
add features module to detect availability of build time features at runtime
2018-03-20 10:13:17 +03:00
deepak1556
4b39d17e5f
move pdf viewer behind feature flag
2018-03-20 10:13:17 +03:00
deepak1556
c1908147a9
Fix windows build
2018-03-20 10:13:17 +03:00
Cheng Zhao
94fce43ed9
Emit document-start for the correct env
...
This fixes the crash in RunScriptsAtDocumentStart when "affinity" option
is specified. Previously we were assuming only one main frame exists in
the renderer process, but the "affinity" option breaks this option.
There is also a bug that "node::Environment::GetCurrent" does not return
nullptr for context without a env in it, I'm not sure whether it is a
bug of Node or V8.
2018-03-20 10:13:17 +03:00
deepak1556
c3f8f6bc42
re-use request context from IOThread
2018-03-20 10:13:17 +03:00
Cheng Zhao
97fcf7079b
Update chrome_version.h
2018-03-20 10:13:17 +03:00
deepak1556
9702898dcd
AccessTokenStore is only needed to initialize network location service
2018-03-20 10:13:17 +03:00
deepak1556
97eb7f2c98
REVIEW: ContentBrowserClient now provides geolocation api key and request context
2018-03-20 10:13:16 +03:00
Aleksei Kuzmin
d3afb595dc
Tab Capture in VIZ: CopyOutputRequest/Result API changes.
...
https://chromium-review.googlesource.com/637003
2018-03-20 10:13:16 +03:00
Aleksei Kuzmin
639be7f7bc
Simplify transparent backgrounds
...
https://chromium-review.googlesource.com/669646
2018-03-20 10:13:16 +03:00
Cheng Zhao
624e09533c
Avoid using deprecated skia size methods
2018-03-20 10:13:16 +03:00
deepak1556
f4ee48eaf4
v8-platform header is not required explicitly
2018-03-20 10:13:16 +03:00
Cheng Zhao
d141d2445d
Fix build error caused by base::Passed changes
2018-03-20 10:13:16 +03:00
deepak1556
b08d086b0f
fix stale rebase
2018-03-20 10:13:16 +03:00
Shelley Vohr
7e7634d344
Chromium 63 - upgrade to Node v9.7.0 ( #12219 )
...
* OPENSSL_PRODUCT => openssl_product
* node => node_lib and V8_BASE => v8_base
* build node target for <(node_lib_target_name)
* update node ref
* update node::Environment::TickInfo calls
* update node ref
* Use InternalCallbackScope for ticking event loop
* enter context scope before InternalCallbackScope
* don't lint v8 platform header
2018-03-20 10:13:16 +03:00
Cheng Zhao
76ef6e3ecc
CertificateList => ScopedCERTCertificateList
2018-03-20 10:13:16 +03:00
Nitish Sakhawalkar
ecd0f9d0e7
Fix build by adding define in node_includes.h
2018-03-20 10:13:15 +03:00
Aleksei Kuzmin
f68cba0c71
Update Chrome version
2018-03-20 10:13:15 +03:00
deepak1556
719980a948
REVIEW: remove device emulation ipc dependecny on rvh
2018-03-20 10:13:15 +03:00
deepak1556
5684f8886f
REVIEW: move ipc use from rvh to rfh
2018-03-20 10:13:15 +03:00
deepak1556
b552ad7065
add taskpriority when creating sequences task runners
2018-03-20 10:13:15 +03:00
deepak1556
1f2d229862
re-use title information from NavigationEntry
2018-03-20 10:13:15 +03:00
deepak1556
6de49f515e
FIXME: Disbale browser side navigation aka PlzNavigate
2018-03-20 10:13:15 +03:00
deepak1556
007ea500d0
REVIEW: Re-use devtools network throttling from content layer
...
https://chromium-review.googlesource.com/c/chromium/src/+/664356
2018-03-20 10:13:15 +03:00
Samuel Attard
8269a6dc37
Temporarily disable OnCursorChange
...
ScopedProfile is removed
https://chromium-review.googlesource.com/c/chromium/src/+/655147
2018-03-20 10:13:15 +03:00
Samuel Attard
b0fe23072d
Update chrome version
2018-03-20 10:13:15 +03:00
Aleksei Kuzmin
aab6f27503
Move DrawQuads to components/viz/
...
https://chromium-review.googlesource.com/667539
2018-03-20 10:13:15 +03:00
Aleksei Kuzmin
74cedd3255
Move ReleaseCallbacks and CopyOutputRequests out of quads/
...
https://chromium-review.googlesource.com/682760
2018-03-20 10:13:15 +03:00
Aleksei Kuzmin
d1061692d5
Move CompositorFrame{Metadata} to viz/common/quads.
...
https://chromium-review.googlesource.com/676726
2018-03-20 10:13:14 +03:00
Aleksei Kuzmin
481c70311a
Move SoftwareOutputDevice to the viz service display compositor.
...
https://chromium-review.googlesource.com/677463
2018-03-20 10:13:14 +03:00
Samuel Attard
7c8be94a6e
IPC fixes for WebContents
2018-03-20 10:13:14 +03:00
Samuel Attard
f80b328937
WebExceptionCode has been removed
2018-03-20 10:13:14 +03:00
Samuel Attard
7356be0164
Convert optional webpoint
2018-03-20 10:13:14 +03:00
Samuel Attard
a8e013dcb6
GetRenderProcessHost() has been removed for OOPI support, should use #include GetMainFrame()->GetProcess()
2018-03-20 10:13:14 +03:00
Samuel Attard
6402b23041
tracked_objects::Location --> base::Location
2018-03-20 10:08:58 +03:00
Samuel Attard
1158d35021
experimental_webgl_enabled is not supported, now use webgl1/2_enabled
2018-03-20 10:08:58 +03:00
Samuel Attard
021e383418
GetBlockingPool has been removed
2018-03-20 10:08:58 +03:00
Samuel Attard
0291dc8214
Calling non-const callbacks requires some tricks
2018-03-20 10:08:58 +03:00
Samuel Attard
ce755483ba
DialogClosedCallback are not const references anymore
2018-03-20 10:08:58 +03:00
Samuel Attard
41b9825f00
WebContents are no longer IPC Sender's
2018-03-20 10:08:58 +03:00
Samuel Attard
12066a60f3
make_scoped_refptr --> WrapRefCounted
2018-03-20 10:08:58 +03:00
Samuel Attard
4666879f94
WebContentsObserver no longer provides explicit_set, we can calculate it
2018-03-20 10:08:57 +03:00
Samuel Attard
fb55db665c
AllowCertificateError no longer sends overridable
2018-03-20 10:08:57 +03:00
Samuel Attard
7f50c3d08e
TracingController -> Coordinator -- content tracing now uses 'endpoints' instead of 'sinks'
2018-03-20 10:08:57 +03:00
Samuel Attard
ed992ae6a1
trackable_object has moved to base namespace
2018-03-20 10:08:57 +03:00
Aleksei Kuzmin
b608152c41
Update Chrome version to 63.0.3239.84
2018-03-20 10:08:57 +03:00
Samuel Attard
0ac883c6d4
Remove the race condition between new process creation and context release ( #12342 )
...
* Remove the race condition between new process creation and old process releasing remote context
Previously there was a race condition where the getId() method would return the new context ID even
though the release was for the old context. This changes it to send the "initial" context ID with
the release message to ensure there is no race.
* fetch context ID from remote in sandbox mode
2018-03-20 15:54:47 +11:00
Birunthan Mohanathas
20a0508a16
Update draggable regions when changing BrowserView
...
Fixes #12150 .
2018-03-19 20:45:42 +02:00
Birunthan Mohanathas
42934a1006
Make BrowserView DragRegionViews children of the WebContents view
...
Previously they were children of the `InspectableWebContentsView` view,
which caused this assertion to fail:
f993888424/brightray/browser/mac/bry_inspectable_web_contents_view.mm (L162)
2018-03-19 20:45:40 +02:00
Birunthan Mohanathas
3b8ddd0997
Use NSView convertRect:toView: for BrowserView DragRegionView positioning
2018-03-19 20:44:05 +02:00
Birunthan Mohanathas
377e6c3210
Rename system_drag_exclude_areas => drag_exclude_rects
2018-03-19 20:44:05 +02:00
Birunthan Mohanathas
61160ff9e5
Store InspectableWebContents instead of InspectableWebContentsView in NativeBrowserView
2018-03-19 20:44:05 +02:00
Shelley Vohr
9599615b23
Fix nil tray title crash ( #12352 )
...
* Add check for title_ being nil
* remove print stub
2018-03-19 10:49:39 -05:00
Birunthan Mohanathas
6f6f388f38
Fix non-draggable regions on macOS ( #12327 )
...
This was a regression in 503b0ba1
.
2018-03-17 06:49:11 +09:00
Charles Kerr
558ef7352d
Better GTK+ Menu color support ( #12300 )
...
* Better GTK+ Menu color support
* Fix 'invisible menu' issue (#12275 )
* Now updates menu text color when focus changes!
* Better caching of colors when system theme changes
* Removed all GTK+ deprecation warnings from menubar
* Don't highlight menu text on mouseover in GTK+
* Fix textColor declaration scope error
* Simplify FocusManager connection management a bit
* Make the linter happy
* Decouple MenuBar view recoloring from rebuilding
This way we don't need to rebuild the subview each time a recolor
is needed, e.g. when window focus changes or the system theme changes
* Don't iterate child views if we don't need to
* Move variable declaration outside of a loop
* More efficient iteration of MenuBar children
* Cleaner MenuButton bounds testing
* Fix oops
* Add a nullptr check in MenuBar::GetItemCount()
* Simplify iteration in MenuBar::RebuildChildren()
* Make the linter happy
* Fix signed-unsigned comparison
* Remove declarations of nonexistent methods
* Make SubmenuButton accessor const
* Cleaner accelerator iteration
* Windows fixes
2018-03-17 06:37:36 +09:00
Robo
792837bd71
net: change mime type deduction in Change URLRequestAsarJob ( #12319 )
2018-03-16 16:48:26 +09:00
Charles Kerr
c2673aa970
Set appropriate defaults for webview options ( #12271 )
...
* Persist defaults to webPreferences object to JS land can read the inferred values instead of just user defined values
* Test inherited default propogation
* Refactor to remove coupling from fetching values and defaults
* Test description type
* Fix up tests
2018-03-15 13:56:46 +09:00
OJ Kwon
e7181eb89c
feat(powerMonitor): expose interface to query system idle state ( #11807 )
...
* feat(BrowserWindow): expose interface to query system idle state
* test(BrowserWindow): update test cases for querySystemIdle interface
* docs(BrowserWindow): add querySystemIdle interface documentation
* refactor(powerMonitor): move querySystemIdle into powerMonitor
* test(powerMonitor): split test cases for all platform
2018-03-14 14:42:08 +09:00
Cheng Zhao
134872e9c1
Merge pull request #12198 from electron/fix_crash_handler
...
Fixed passing of exception to the system crash handler
2018-03-14 11:40:11 +09:00
Robo
e741bc0577
fix crash when using getWebPreferences api with devtools webContents ( #12254 )
2018-03-14 11:19:22 +09:00
Samuel Attard
8664dd2139
Merge pull request #12190 from electron/fix-double-preload-master
...
Ensure that a document has been created before sending IPC messages
2018-03-14 10:34:05 +09:00
Charles Kerr
dd2c2660b9
Fix desktop-id notification edge case ( #12216 )
...
* Fix desktop-id notification edge case
* Extract-method platform_util::GetDesktopName()
This removes duplicated code from libnotify_notifications.cc
and atom/common/linux/application_info.cc.
* Check for empty case in GetDesktopName().
* Move GetDesktopName() to brightray::util
* Remove unnecessary changes in platform_util
* Add a brightray::platform_util namespace
2018-03-12 16:02:47 +09:00
Charles Kerr
86af20ded0
Linux named notifications ( #12192 )
...
* Set name & desktop-entry on Linux notifications
* DBusMock now honors verbose mode flag
* Disable DBus Notification tests on ia32
2018-03-12 09:33:06 +09:00
Robo
06bf72da67
remove process preference lock from AtomBrowserClient ( #12194 )
2018-03-09 12:37:26 -05:00
Ales Pergl
4673c67835
Fixed passing of exception to the system crash handler
2018-03-09 15:46:27 +01:00
Ales Pergl
94299f6cd8
Fixed Mac build when enable_run_as_node==false
2018-03-09 13:33:04 +01:00
deepak1556
2bf1131dab
add NOLINT rule for include order in renderer_client_base
2018-03-09 15:19:07 +05:30
deepak1556
3cfe66e4c3
move ipc use from rvh to rfh
2018-03-09 15:01:09 +05:30
Charles Kerr
0d12fc3033
Make the linter happy
2018-03-09 17:03:00 +09:00
Cheng Zhao
e79b18762e
Enter context scope before InternalCallbackScope
2018-03-09 16:14:24 +09:00
Cheng Zhao
83f01096c0
When a render process is crashed, it might be reused
2018-03-09 16:13:51 +09:00
Cheng Zhao
5d2452608d
Use InternalCallbackScope for ticking event loop
2018-03-09 15:23:40 +09:00
Shelley Vohr
1882b88c78
clean node ref and remove short circuit
2018-03-09 15:23:39 +09:00
Shelley Vohr
c8ef15cf40
update node::Environment::TickInfo calls
2018-03-09 15:23:39 +09:00
Samuel Attard
a9dcce82ed
Ensure that a document has been created before sending IPC messages
...
* Reverts 370476c4af
in favor of moving the previous logic to the new RenderFrameObserver instead of RenderViewObserver
Fixes #12045
2018-03-09 14:24:56 +11:00
Cheng Zhao
44c66fc284
Merge pull request #12167 from lyallh/menubar-autohide-fix
...
Fix menubar toggle alt key detection on focus
2018-03-09 10:13:32 +09:00
Aleš Pergl
0937b84b01
Use content origin in screen coordinates for calculating popup menu position ( #12180 )
2018-03-09 05:48:35 +09:00
Lyall Hamilton
ba24920fec
Fix menubar toggle alt key detection on focus
...
Reset alt keypress flag on window blur so switching window via
Alt+* window manager keybindings can't incedentally trigger
annoying menubar toggles
2018-03-08 21:48:43 +13:00
Samuel Attard
8c138e74be
More vibrancy fixes ( #12157 )
...
* Only set title bar to transparent when vibrant with a custom titlebar
* Correctly set the transparent state of the GpuSwitcher so vibrancy works on reload
* Document case where using frame: false without custom titleBarStyle and vibrant
2018-03-07 11:40:36 -05:00
Hari Juturu
2f4fd3324b
Preload doesn't load in sandboxed render if preload path contains special chars ( #12037 )
...
* Adding missing headers
* adding ut
* Removing the file path exists check
* fixing test
* exposing window.require in UT
2018-03-07 11:40:00 -05:00
Andreas
69e7afee26
fix dev tools window interfering with mouse forward ( #12132 )
2018-03-07 07:44:55 -05:00
Cheng Zhao
cc6bcb6c81
Fix some flaky tests in CI ( #12153 )
...
* Guard whole InitPrefs with ScopedAllowIO
Saw a crash:
0 0x7f8d2f7d918d base::debug::StackTrace::StackTrace()
1 0x7f8d2f7d755c base::debug::StackTrace::StackTrace()
2 0x7f8d2f867caa logging::LogMessage::~LogMessage()
3 0x7f8d2fa157c7 base::ThreadRestrictions::AssertIOAllowed()
4 0x7f8d2f83453a base::OpenFile()
5 0x7f8d2f82a967 base::ReadFileToStringWithMaxSize()
6 0x7f8d2f82ad44 base::ReadFileToString()
7 0x7f8d2f846f73 JSONFileValueDeserializer::ReadFileToString()
8 0x7f8d2f84738c JSONFileValueDeserializer::Deserialize()
9 0x7f8d35a5d1f6 <unknown>
10 0x7f8d35a5c217 JsonPrefStore::ReadPrefs()
11 0x7f8d35a87d3e PrefService::InitFromStorage()
12 0x7f8d35a87c60 PrefService::PrefService()
13 0x7f8d35a91a10 PrefServiceFactory::Create()
14 0x000000e86e1b brightray::BrowserContext::InitPrefs()
15 0x000000c2bd64 atom::AtomBrowserContext::AtomBrowserContext()
16 0x000000c320db atom::AtomBrowserContext::From()
17 0x000000b4b8b5 atom::api::Session::FromPartition()
* Fix done being called twice in setInterval test
The callback passed to browser process is called asyncly, so it is
possible that multiple callbacks has already been scheduled before we
can clearInternval.
* Fix failing test when dir name has special chars
The pdfSource is not escaped while parsedURL.search is.
* Call done with Error instead of string
* Fix crash caused by not removing input observer
Solve crash:
0 libcontent.dylib content::RenderWidgetHostImpl::DispatchInputEventWithLatencyInfo(blink::WebInputEvent const&, ui::LatencyInfo*) + 214
1 libcontent.dylib content::RenderWidgetHostImpl::ForwardMouseEventWithLatencyInfo(blink::WebMouseEvent const&, ui::LatencyInfo const&) + 1350
2 libcontent.dylib content::RenderWidgetHostViewMac::ProcessMouseEvent(blink::WebMouseEvent const&, ui::LatencyInfo const&) + 44
3 libcontent.dylib content::RenderWidgetHostInputEventRouter::RouteMouseEvent(content::RenderWidgetHostViewBase*, blink::WebMouseEvent*, ui::LatencyInfo const&) + 1817
* Print detailed error
* Run tests after server is ready
2018-03-07 14:40:27 +09:00
Cheng Zhao
411da169ac
Repect old logic in windowWillUseStandardFrame
2018-03-06 16:54:20 +09:00
Cheng Zhao
78468098c5
Don't store WebContents in NativeWindow
2018-03-06 16:21:18 +09:00
Cheng Zhao
9000bd6679
views: Explicitly set initially focused view
2018-03-06 16:21:18 +09:00
Cheng Zhao
413fdc6f0d
views: Show menu on window's content view
2018-03-06 16:21:18 +09:00
Cheng Zhao
9c7854aef6
NativeWindow is no longer WebContentsObserver
2018-03-06 16:21:18 +09:00
Cheng Zhao
bf862d1d07
views: Focus webContents in BrowserWindow
2018-03-06 16:21:17 +09:00
Cheng Zhao
8bbe28e998
No need to get BrowserContext from NativeWindow
2018-03-06 16:21:17 +09:00
Cheng Zhao
702f1631a3
Remove NativeWindow::FromWebContents
2018-03-06 16:21:17 +09:00
Cheng Zhao
eea4e60b73
Remove NativeWindow's webview APIs
2018-03-06 16:20:37 +09:00
Cheng Zhao
5a4c2fb61d
mac: Pass the view to install
2018-03-06 16:20:37 +09:00
Cheng Zhao
498f5d65fd
mac: UninstallView is not used
2018-03-06 16:20:37 +09:00
Cheng Zhao
3b3e69f8b2
Save browser_view_ in the NativeWindow
...
No need to store it separately in subclasses.
2018-03-06 16:20:37 +09:00
Cheng Zhao
503b0ba1b1
mac: Move draggable region code to BrowserWindow
...
On macOS current draggable region implementation highly relies on
WebContents, the code is only meaningful for BrowserWindow.
2018-03-06 16:20:37 +09:00
Cheng Zhao
bc34ca9e25
mac: Call setMouseDownCanMoveWindow in BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
7d4ff3b061
mac: Call SetBackgroundOpaque in BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
8a1884c407
mac: AcceleratedWidget should be window's content view
2018-03-06 16:20:37 +09:00
Cheng Zhao
e7f175d578
Only mac needs to call SetActive
2018-03-06 16:20:37 +09:00
Cheng Zhao
4c7b48e596
mac: Window's native view should be its content view
2018-03-06 16:20:37 +09:00
Cheng Zhao
1681ee35db
Set WebContents background color in BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
7b8890a4c9
web_contents can't be null
2018-03-06 16:20:37 +09:00
Cheng Zhao
2eaa6d0874
Move StoreFocus/RestoreFocus to BrowserWindow
2018-03-06 16:20:37 +09:00
Cheng Zhao
cad3d694ab
mac: Remove access to webContents in windowWillUseStandardFrame
2018-03-06 16:20:37 +09:00
Cheng Zhao
ca42325ade
Make OnMessageBoxCallback a method since it is accessing members
2018-03-06 11:35:53 +09:00
Cheng Zhao
7516b059fe
Code style fixes
2018-03-06 11:31:56 +09:00
Samuel Attard
7dec3c9320
Fixup cpplint
2018-03-06 11:19:15 +09:00
Samuel Attard
731240e0e9
Use USER_WANTS_NO_MORE_DIALOGS constant for -1 magic number
2018-03-06 11:19:15 +09:00
Charles Kerr
a5a068b2ee
fix cpplint errors
...
atom/browser/atom_javascript_dialog_manager.cc:39: Lines should be <= 80 characters long [whitespace/line_length] [2]
atom/browser/atom_javascript_dialog_manager.cc:39: If/else bodies with multiple statements require braces [readability/braces] [4]
atom/browser/atom_javascript_dialog_manager.cc:62: Lines should be <= 80 characters long [whitespace/line_length] [2]
atom/browser/atom_javascript_dialog_manager.cc:89: If/else bodies with multiple statements require braces [readability/braces] [4]
2018-03-06 11:19:15 +09:00
Charles Kerr
2435ffaf09
fix cpplint error
...
atom/browser/atom_javascript_dialog_manager.h:9: Include "map" not in alphabetical order [build/include_alpha] [4]
2018-03-06 11:19:15 +09:00
Samuel Attard
795447f61a
Implement dialog (alert/confirm) blocking as a user switch after the first dialog
...
* This is to enable more browser-like behavior so that users who run third-party code
will not be DOS'ed with alerts and confirms. This is already handled like this
in most major browsers so this will greatly help these developers
2018-03-06 11:19:15 +09:00
Shelley Vohr
199cf31b9e
deprecate screen.getMenuBarHeight
2018-03-05 19:45:51 -05:00
Aleksei Kuzmin
52c0864cb8
Use version 0.0.0-dev everywhere
2018-03-05 16:24:48 +01:00
Shelley Vohr
bf491de9fe
fix styling and add spec
2018-02-28 00:22:42 -08:00
Shelley Vohr
2abc69780e
move native-mate back into the api layer
2018-02-27 13:00:42 -08:00
Shelley Vohr
837a2d4bbd
appease the linter
2018-02-26 22:25:09 -08:00
Samuel Attard
b722150d87
Don't cast manually for NativeWindow*
2018-02-27 16:13:17 +11:00
Samuel Attard
5336b4a89c
Pass arguments instance through the chain in order to throw error
2018-02-27 16:11:58 +11:00
Shelley Vohr
e84d7c0cda
add warning when addTabbedWindow is called on self
2018-02-26 14:47:36 -08:00
Cheng Zhao
53229e3d6c
Fix network delegate race condition ( #12044 )
...
* Fix race condition when getting network delegate
* Remove the evil URLRequestContextGetter::network_delegate
* Move the arguments instead of const referrencing
Safer and more efficient.
2018-02-26 06:23:59 -08:00
Cheng Zhao
fdd66bd76d
Merge pull request #11607 from bughit/frame_navigation_api
...
frame navigation API
2018-02-26 15:50:11 +09:00
Cheng Zhao
ccf30e0934
Coding style fixes
2018-02-26 15:19:44 +09:00
Cheng Zhao
f7786a9e48
Merge pull request #11230 from electron/upgrade-to-chromium-62
...
Upgrade to Chromium 62
2018-02-26 14:20:21 +09:00
kaylie
da9f12d1e2
restore old cb
2018-02-25 14:19:40 -08:00
Cheng Zhao
b9ab2fe0fb
Disable stack dumping for 32bit ARM
2018-02-23 10:22:00 +09:00
Cheng Zhao
39e0433570
Fix build error after rebasing
2018-02-23 10:22:00 +09:00
shelley vohr
0e5b6f9300
Upgrade to node v9.3.0 ( #11507 )
...
* update submodule refs for node v9.3.0
* Define "llvm_version" for Node.js build
* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE
* update NodePlatform to MultiIsolatePlatform
* fix linting error
* update node ref
* REVIEW: Explicitly register builtin modules
https://github.com/nodejs/node/pull/16565
* update libcc ref
* switch libcc to c62
* REVIEW: Address node api changes
- Always start the inspector agent for https://github.com/nodejs/node/pull/17085
- Set the tracing controller for node https://github.com/nodejs/node/pull/15538
- Isolate data creation now requires plaform https://github.com/nodejs/node/pull/16700
2018-02-23 10:22:00 +09:00
Aleksei Kuzmin
f5d207f8f0
Improve process launch handle sharing API.
...
https://codereview.chromium.org/2950153002
2018-02-23 10:21:24 +09:00
deepak1556
5eb0a89579
REVIEW: let browser context manage cookie change sub list
2018-02-23 10:21:24 +09:00
Aleksei Kuzmin
9fa08fdbc0
Merge views::CustomButton into views::Button.
...
https://chromium-review.googlesource.com/617407
2018-02-23 10:21:24 +09:00
Aleksei Kuzmin
6f00e4a014
REVIEW: Implements core logic for Pixel Canvas
...
https://codereview.chromium.org/2877483003
2018-02-23 10:21:24 +09:00
deepak1556
d846c9006e
Replace somemore uses of SetStringWithoutPathExpansion
2018-02-23 10:21:24 +09:00
deepak1556
69ca6ccdc1
Remove chrome_utility_messages.h, it's unused
2018-02-23 10:21:23 +09:00
deepak1556
25d966110e
FIXME: PDF component IPC should be converted to Mojo.
...
https://codereview.chromium.org/2455543002
2018-02-23 10:21:23 +09:00
deepak1556
e03f7baa60
gfx::Image::SwapRepresentations is removed in favor of std::move
...
https://chromium-review.googlesource.com/c/chromium/src/+/588033
2018-02-23 10:21:23 +09:00
deepak1556
62635f43f4
base::LaunchOptions fds_to_remap is no longer a pointer
...
https://codereview.chromium.org/2950153002
2018-02-23 10:21:23 +09:00
deepak1556
248d572077
REVIEW: Subscribe to cookie store for changes in place of CookieMonsterDelegate
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
b02edd014a
Rename CompositionUnderline to ImeTextSpan
...
https://chromium-review.googlesource.com/609524
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
412b9e9ad8
Move IDMap to base namespace.
...
https://chromium-review.googlesource.com/618801
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
8f78bd3307
Remove was_ignored_by_handler from frame_messages.h
...
https://chromium-review.googlesource.com/587701
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
91a339b625
viz: Move BeginFrame(Args|Ack) to components/viz/common/frame_sinks
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
1a9b056e93
Move CompositorFrameSink and FrameSinkManager mojom from cc to viz
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
abc6003640
viz: Move BeginFrameSource to components/viz/common/frame_sinks
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
76683c0af5
viz: Move CopyOutput(Request|Result)=> components/viz/common/quads
2018-02-23 10:21:23 +09:00
Shelley Vohr
128cb7f5b2
updates to build flags and comp errors
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
8c0c1e4ded
media: Replace ENABLE_PEPPER_CDMS buildflag with ENABLE_LIBRARY_CDMS
...
https://chromium-review.googlesource.com/582309
2018-02-23 10:21:23 +09:00
deepak1556
75c17cf846
Use generic base::Value::SetKey
...
Remove base::Value::SetDoubleWithoutPathExpansion
https://chromium-review.googlesource.com/591654
Remove base::Value::SetStringWithoutPathExpansion
https://chromium-review.googlesource.com/592368
Remove base::Value::SetIntegerWithoutPathExpansion
https://chromium-review.googlesource.com/591655
2018-02-23 10:21:23 +09:00
Aleksei Kuzmin
5783ce0b3c
Update chrome_version.h
2018-02-23 10:21:23 +09:00
Cheng Zhao
3be92f550c
Better clarity and fix typo
2018-02-23 09:15:13 +09:00
Cheng Zhao
816a96c2cc
Update font settings in api::WebContents
2018-02-22 19:01:45 +09:00
Cheng Zhao
c87fc2426d
Handle transparent WebContents in api::BrowserWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
c611eb061d
Move InputEventObserver to api::BrowserWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
aa3eafcea1
Move closing logic to api::BrowserWindow
...
Closing a BrowserWindow is essentially closing a WebContents, the logic
should not be in NativeWindow.
2018-02-22 19:01:45 +09:00
Cheng Zhao
66fab65a1a
Add NativeWindowObserver::OnCloseButtonClicked
2018-02-22 19:01:45 +09:00
Cheng Zhao
a25b49a127
Add ExtendedWebContentsObserver
2018-02-22 19:01:45 +09:00
Cheng Zhao
a3124e8873
Use observer to provide OnRendererUnresponsive
2018-02-22 19:01:45 +09:00
Cheng Zhao
bffb31c337
Remove OnMessageReceived from NativeWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
44e7282b4b
The UpdateDraggableRegions does not share implementations
2018-02-22 19:01:45 +09:00
Cheng Zhao
c2aa312e0c
Check weak ptr before using it
2018-02-22 19:01:45 +09:00
Cheng Zhao
384b03d49b
UpdateDraggableRegionViews is redundant
2018-02-22 19:01:45 +09:00
Cheng Zhao
6650a06339
Move RenderViewCreated logic to api::BrowserWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
c256a43139
Move ready-to-show to api::BrowserWindow
2018-02-22 19:01:45 +09:00
Cheng Zhao
0d9a157914
Turn api::Window into a WebContentsObserver
2018-02-22 19:01:45 +09:00
Cheng Zhao
973647eaa2
Rename api::Window to api::BrowserWindow
2018-02-22 12:50:47 +09:00
bughit
88b887fe47
frame navigation API
2018-02-21 18:50:15 -05:00
Cheng Zhao
f7ec346e9f
Merge pull request #11956 from brenca/transparent-window-devtools-fix
...
Fix transparent windows losing transparency when devtools detaches
2018-02-21 19:54:35 +09:00
Heilig Benedek
6f2609f9d2
Remove outdated comments
2018-02-21 11:28:53 +01:00
shelley vohr
193febd18c
deprecate boolean highlightMode param ( #11993 )
...
* deprecate boolean highlightMode param
* add process.noDeprecations check
* fix native method override
* add todo
2018-02-20 22:30:32 -06:00
shelley vohr
c2575c4944
remove app.getAppMemoryInfo ( #11985 )
...
* remove app.getMemoryInfo
* semicolons are important
2018-02-20 18:52:33 -06:00
John Kleinschmidt
dcaff20cfd
Merge pull request #11981 from electron/set-tray-highlightmode
...
no longer support bool param for setHighlightMode
2018-02-20 12:57:52 -05:00
shelley vohr
846be03f1d
remove support for hidden-inset ( #11975 )
2018-02-20 11:09:54 -06:00
shelley vohr
7bcccdec41
remove atom-shell process name ( #11979 )
2018-02-20 10:33:38 -06:00
shelley vohr
6a3fde6e20
Merge pull request #11973 from electron/remove-clipboard-methods
...
Remove html/rtf methods marked for 2.0
2018-02-20 11:21:10 -05:00
Charles Kerr
8d086a43cb
Fix brightray::GetApplicationName(), ..Version() on Linux ( #11980 )
...
* add brightray API to override app version
* in atom browser, use brightray app version API
* on Linux, have GetApplicationVersion() use brightray version API
* on Linux, implement brightray::GetApplicationName()
* fix typo in brightray API
* make browser.GetName() logic follow GetVersion() logic
* improve variable name in OverrideApplicationVersion declaration
* fix typo in brightray impl
2018-02-20 10:16:51 -06:00
Cheng Zhao
dc62e51ba4
Fix the cyclic reference in menu delegate ( #11967 )
...
* Fix the cyclic reference in menu delegate
* Fix menu tests due to delegate change
2018-02-20 10:11:35 -06:00
shelley vohr
8d4bf3e29a
Merge pull request #11974 from electron/remove-setZoomLevelLimits
...
remove setZoomLevelLimits
2018-02-20 10:51:41 -05:00
shelley vohr
a2856db982
Remove nativeImage deprecated methods ( #11978 )
...
* remove deprecated nativeimage methods
* remove .only from spec
2018-02-20 09:15:27 -06:00
Shelley Vohr
57738e6981
no longer support bool param for setHighlightMode
2018-02-20 10:06:59 -05:00
Shelley Vohr
211b542ae4
remove setZoomLevelLimits
2018-02-20 08:57:48 -05:00
Shelley Vohr
e4e20d667b
remove html/rtf methods marked for 2.0
2018-02-20 08:41:58 -05:00
Shelley Vohr
fc025064f7
remove setExtraParameter for 2.0
2018-02-20 08:26:10 -05:00
Heilig Benedek
d31d2087a3
use SK_ColorTRANSPARENT as the default color to fix issue with transparent window devtools detach
2018-02-19 15:07:28 +01:00
Charles Kerr
56859531cd
fix floating reference glib warning ( #11948 )
...
use gtk_widget_destroy() rather than g_object_unref() on the floating temporary menubar widget that we use to calculate colors
2018-02-19 00:12:54 -06:00
Thiago de Arruda
bc76f35691
Fix protocol filtering of net.request
...
net::URLRequest inherits from base::SupportsUserData, which allows
associating arbitrary data with the request. Use this mechanism as a
condition for filtering requests from custom protocols.
Close #11657
2018-02-16 13:03:53 -05:00
John Kleinschmidt
78ccfa0612
Merge pull request #11879 from electron/fix-gtk-deprecations
...
Fix GTK+ 3 deprecations
2018-02-16 10:01:01 -05:00
Cheng Zhao
67fa13d7cf
Merge pull request #11925 from electron/squirrel-mac-cdn
...
Update to use Squirrel.Mac that supports CDN releases
2018-02-16 15:28:39 +09:00
Samuel Attard
549042160f
requestHeaders --> headers
2018-02-16 13:41:21 +11:00
Charles Kerr
5e7a5ce3a9
run clang-format on changed sources
2018-02-15 15:20:55 -06:00
Charles Kerr
381ed2e2b2
remove GTK+ 2 specific code
2018-02-15 14:57:45 -06:00
Cheng Zhao
af92b04eb9
Merge pull request #11654 from sethlu/set-notification-close-button-text
...
feat: Set macOS notification close button title
2018-02-15 16:01:30 +09:00
Samuel Attard
6318cd781d
Update to use Squirrel.Mac that supports CDN releases
2018-02-15 14:00:46 +11:00
Shelley Vohr
31b074ff0e
change to return emit
2018-02-14 09:28:21 -05:00
Shelley Vohr
c3d11a51cc
emit console-message in OSR mode
2018-02-14 09:09:45 -05:00
Charles Kerr
402201ac39
Fix cppcheck warnings ( #11883 )
...
* remove unused variable
* limit scope of variable 'ret'
* pass shared_ptr<SkBitmap> by reference
* silence warning: value reassign before read
* fix oops
* don't refer to 'response' after std::move()ing it
* make the linter happy
2018-02-14 02:21:46 -06:00
shelley vohr
a55fd06aa2
Revert "Merge pull request #11737 from kwonoj/feat-cache-capacity" ( #11906 )
...
This reverts commit 181169b743
, reversing
changes made to baced3152f
.
2018-02-13 10:49:27 -05:00
Cheng Zhao
affa21600c
Remove unnecessary methods on WebContentsPreferences
2018-02-13 15:57:54 +09:00
Emmanuel Kimmerlin
9c1b47361f
Add an "affinity" option to webPreferences
2018-02-13 15:18:55 +09:00
Samuel Attard
9bd7d53cf8
Handle empty handles ( #11598 )
...
* Handle empty handles
* Close and dispose window at end of void test
* Dispose of existing window before running void 0 spec
2018-02-12 14:46:29 -05:00
Samuel Attard
181169b743
Merge pull request #11737 from kwonoj/feat-cache-capacity
...
feat(webframe): export set cache capacity interface
2018-02-13 06:02:25 +11:00
Samuel Attard
ae65938752
Fix frameless windows with vibrancy ( #11886 )
2018-02-12 13:38:37 -05:00
acheronfail
d1d50a4c92
Implement App-Scoped Security scoped bookmarks ( #11711 )
...
* implementation of security scoped bookmarks
* option is now only available on mas builds
2018-02-12 13:25:06 -05:00
Samuel Attard
01dcddef35
Merge pull request #11819 from kwonoj/feat-worditerator
...
feat(worditerator): bump up worditerator into latest
2018-02-13 05:11:01 +11:00
Samuel Attard
b3234f634b
Add ability to set arbitrary arguments in a renderer process ( #11850 )
2018-02-12 11:54:31 -06:00
Samuel Attard
66b57858b8
Fix child touch bar items not updating ( #11812 )
...
* Fix child touch bar items not updating
Deep children of a TouchBar didn't cause the top level touch bar to update, now they do
Fixes #11761 .
* Remove unused newValue property in TB setter
2018-02-12 12:53:04 -05:00
John Kleinschmidt
e6ac2637d3
Merge pull request #11728 from brenca/osr-gpu-update-master
...
Improve OSR API (master)
2018-02-12 12:29:11 -05:00
shelley vohr
fae71f9987
Merge pull request #11880 from nitsakh/better-ipc-logging
...
Add ability to log atom ipc messages
2018-02-12 09:20:37 -05:00
universeroc
069c6187cf
Fix #11893 Remove unused member variable content_client_ ( #11894 )
2018-02-12 08:07:12 -06:00
Nitish Sakhawalkar
e19e2b9242
Address review comments
2018-02-11 10:25:11 -08:00
Shelley Vohr
36cf548114
change weak ptr ref to strong
2018-02-10 21:04:26 -05:00
Zhuo Lu
29f9929703
Organize code
2018-02-10 03:19:47 -08:00
Zhuo Lu
be118d4f13
Make it able to set close button text
2018-02-10 03:19:47 -08:00
Shelley Vohr
3085c78bcf
implement selectFormat selector
2018-02-09 21:38:21 -05:00
Nitish Sakhawalkar
5194288fce
Add ability to log atom ipc messages
2018-02-09 18:01:14 -08:00
Charles Kerr
3710e0e38b
make the linter happier
2018-02-09 19:34:37 -06:00
Charles Kerr
4b766d26df
make the linter happy
2018-02-09 19:29:32 -06:00
Charles Kerr
3f5ce6d74f
fix gtk3 deprecation warnings setting menubar colors
2018-02-09 19:04:59 -06:00
Charles Kerr
b107d3f440
remove icons from messageboxes on gtk
...
Icons are deprecated in GtkMessageBoxes as of GTK+ 3.12. The GNOME HIG no longer shows icons in example dialogs; see https://developer.gnome.org/hig/stable/dialogs.html.en and https://developer.gnome.org/gtk3/stable/GtkMessageDialog.html
2018-02-09 17:53:02 -06:00
Charles Kerr
ffff400236
fix 'GTK_STOCK_*' deprecation warnings
2018-02-09 17:45:34 -06:00
Charles Kerr
e5eeab6e29
fix 'GTK_STOCK_*' deprecation warnings
2018-02-09 09:57:39 -06:00
Shelley Vohr
0fff336481
add accessory view for format picker
2018-02-09 09:08:04 -05:00
shelley vohr
ca34978e73
add app.setLocale() ( #11469 )
...
* infrastructure for setLocale via klang
* add documentation for setLocale
* add test for setLocale
* fix spec
* add spec and update docs
* fix carriage feeds on windows
* SetLocale() sets LC_ALL on Linux
* in SetLocale() on Linux, use g_setenv()
* fix tyop: '#ifdef OSX_POSIX'
* make the linter happy
* improvements from review
2018-02-08 08:26:37 -06:00
OJ Kwon
e869c27041
feat(worditerator): bump up worditerator into latest
2018-02-06 15:31:18 -08:00
Felix Rieseberg
6c6fa3190f
Fix PRE_RELEASE_VERSION (on master) ( #11844 )
...
* 🔧 Fix PRE_RELEASE_VERSION
* 🔧 Fix spacing
* 🔧 Fix this, but harder
2018-02-06 16:33:51 -06:00
Shelley Vohr
5b901d9f82
revert TOOLKIT_VIEWS check change
2018-02-06 13:34:27 -05:00
Shelley Vohr
3f6d2eb3ab
remove extraneous variable
2018-02-06 09:27:30 -05:00
Shelley Vohr
80aa399f8a
updates to mac enable method
2018-02-06 09:16:22 -05:00
Shelley Vohr
131aa38768
typo fix
2018-02-06 08:30:33 -05:00
Shelley Vohr
faf08b2b77
add documentation
2018-02-06 08:28:41 -05:00
Shelley Vohr
ae632193c0
migrate to virtual void and start mac impl
2018-02-06 08:21:53 -05:00
Shelley Vohr
97589bbe33
first pass at api method to enable window
2018-02-05 14:49:59 -05:00
Cheng Zhao
42fa018277
Merge pull request #11492 from timmyhadwen/master
...
Fixed Bluetooth chooser bug. Closes #11399
2018-02-05 20:44:42 +09:00
Samuel Attard
87c2f0f14f
Fix build and ensure no breaking change
2018-02-05 17:29:59 +09:00
Samuel Attard
72464a6db5
Fix implicit appUserModelId set
2018-02-05 17:29:59 +09:00
Cheng Zhao
9337959f51
The tryToTerminateApp is not really needed
2018-02-05 16:25:50 +09:00
Cheng Zhao
983e1b1a70
Implement shutdown event for macOS
2018-02-05 16:20:57 +09:00
Cheng Zhao
c470e758cc
Remove the AllocateSystemIOPorts call
...
It is no longer needed and it is crashing.
2018-02-05 16:15:49 +09:00
Cheng Zhao
109e2c760f
Do not use virtual function to request shutdown
...
Would make it easier to port to other platforms.
2018-02-05 15:50:55 +09:00
Cheng Zhao
8ae3d9dd0b
Simplify the public PowerObserver interface
2018-02-05 15:28:58 +09:00
Thiago de Arruda
e0e7dd2a8f
fixup! Implement powerMonitor 'shutdown' event for Linux.
2018-02-05 15:21:31 +09:00
Thiago de Arruda
f0e210360f
fixup! Implement powerMonitor 'shutdown' event for Linux
2018-02-05 15:21:31 +09:00
Thiago de Arruda
45763c0afb
fixup! Implement powerMonitor 'shutdown' event for Linux
2018-02-05 15:21:31 +09:00
Thiago de Arruda
56b53e71aa
Implement powerMonitor 'shutdown' event for Linux.
...
The event is emitted when the OS is rebooting/shutting down, and allows
an electron app to call `e.preventDefault()` in order to delay shutdown
and exit cleanly.
2018-02-05 15:21:31 +09:00
Charles Kerr
e51c78f10c
fix oops
...
because compiling before pushing is for wusses
2018-01-31 22:25:57 -07:00
Charles Kerr
1106cde687
fix oops
2018-01-31 17:40:11 -07:00
Charles Kerr
09a2c80443
use std::binary_search to search switch blacklist
2018-01-31 17:36:06 -07:00
Charles Kerr
8405fe763e
Make a copy-paste recipe for rebuilding the blacklist
2018-01-31 17:35:34 -07:00
Samuel Attard
ce361a12e3
Use case-insensitive switch comparisons
2018-01-31 17:35:09 -07:00
shelley vohr
f24eab74d8
Merge pull request #11726 from electron/faster-compare-blacklist
...
Make use of sorted list to speed up searching
2018-01-30 09:46:38 -05:00
shelley vohr
12d4f984f3
Merge pull request #11754 from electron/menu-events
...
Add and document menu events
2018-01-29 12:40:57 -05:00
Shelley Vohr
bef4c84799
turn class into observer
2018-01-27 10:40:50 -05:00
Shelley Vohr
3399480304
first pass at menu event emission
2018-01-27 09:35:58 -05:00
Heilig Benedek
df3d94b20d
Remove web_contents_impl() helper to clarify code and remove unnecessary guard
2018-01-26 10:30:20 +01:00
OJ Kwon
d172e29270
feat(webframe): export set cache capacity interface
2018-01-25 20:43:01 -08:00
Heilig Benedek
406f171c88
Move OSR api to OsrWCV to allow api calls to take effect sooner
2018-01-25 16:11:56 +01:00